profile
viewpoint
Brent Vatne brentvatne @expo Vancouver, Canada

acumenbrands/rest_suite 79

Server-side Javascript library that wraps parts of the Netsuite SuiteScript API

brentvatne/apollo-sqlite-experiment 8

Work in progress fun-times with using apollo-client and graphql-anywhere to use a SQLite WebDatabase as a backend

brentvatne/angular-delay 7

Delay execution of a ngChange callback

acumenbrands/best_in_place 1

A RESTful unobtrusive jQuery Inplace-Editor and a helper as a Rails Gem

push eventexpo/expo-cli

Brent Vatne

commit sha 49025298afa6590e6f3262d6ab1bcb79cc297512

Remove log

view details

push time in 10 hours

push eventexpo/expo-cli

Brent Vatne

commit sha 207a35126a094ccc02d3e19116fb078bcac4da64

Fix ejecting on Android to use package rather than name and remove displayName prompt

view details

push time in 10 hours

issue commentexpo/expo

exp build:android fails

@Katacha1537 - every time you run expo build:* it will publish first, and every time you publish (expo publish) it currently publishes to ios and android. if you want to use a previously published version, then do expo build:android --no-publish

SKempin

comment created time in 11 hours

IssuesEvent

issue openedexpo/expo-cli

Logging should support %s format

Warning: %s: Error boundaries should implement getDerivedStateFromError(). In that method, return a state update to display an error message or fallback UI., RootErrorBoundary

created time in 16 hours

issue commentexpo/expo

Possible incompatibility with @react-native-community/react-native-netinfo

is your app in bare workflow or expokit?

Andrea-Arguello

comment created time in 16 hours

issue openedexpo/expo

[docs] Update Facebook docs

  • The screenshot of the Facebook app configuration screen is out of date.
  • The setup process asks the developer to make selections -- eg: they need to specifically pick "Facebook Login" once they make an app. Then they need to choose iOS, Android, or Web. They are then guided through a process that asks them for information they don't have (on Android, the main activity class).

created time in 16 hours

create barnchbrentvatne/camera-example

branch : master

created branch time in 17 hours

created repositorybrentvatne/camera-example

created time in 17 hours

push eventexpo/expo

Brent Vatne

commit sha 0ea17941426c1e45a3bf669ada7847799afdf201

[template] Change bare template to use function component

view details

Brent Vatne

commit sha ba5abfbb9024dd0330121c75d9a94c445bb2f012

[templates] Clean up: fix names so they can be init properly and remove sdkVersion/privacy fields

view details

Brent Vatne

commit sha 456b312bcd22abe3b5726a3fd2fd022d64541238

[templates][bare] publish

view details

push time in 17 hours

issue commentexpo/expo

Root background color always white when using Modal with presentationStyle pageSheet

hey folks i didn't get around to this for sdk 37 after all, sorry about that

brentvatne

comment created time in 18 hours

push eventexpo/expo

Brent Vatne

commit sha 73919c57db1bbc82f17e7cda38bd49c92215ccd4

[templates] Clean up: fix names so they can be init properly and remove sdkVersion/privacy fields

view details

push time in 18 hours

issue closedexpo/expo

Possible incompatibility with @react-native-community/react-native-netinfo

🐛 Bug Report

Environment

Expo CLI 3.15.5 environment info:
    System:
      OS: Linux 5.3 Pop!_OS 18.04 LTS
      Shell: 5.4.2 - /usr/bin/zsh
    Binaries:
      Node: 10.19.0 - /usr/bin/node
      Yarn: 1.22.4 - /usr/bin/yarn
      npm: 6.13.4 - /usr/bin/npm

Ejected project on ExpoKit 36.0.1 and Expo 36.0.2.

Steps to Reproduce

Run yarn add @react-native-community/netinfo, I specifically installed the 4.6.0 version, since an expo message prompted me to do so.

Expected Behavior

App runs without problems.

Actual Behavior

I instance as the app mounts that uses the library to check for internet connectivity. I am greeted by the following error just by running NetInfo.fetch().then(state => console.log(state.type)); image

Additionally, another dev on my team left the following comment inside the code back when we were still using Expo SDK 34.

/*
TODO: this whole module was originally created with @react-community/net-info
but expo didn't seem to handle it well. Then I replaced it with the deprecated
NetInfo react native api. Please review this in the future in order to assure
future proof.
*/

This seems to be a problem in the current SDK.

closed time in 18 hours

Andrea-Arguello

issue commentexpo/expo

Possible incompatibility with @react-native-community/react-native-netinfo

you should follow the docs:

https://docs.expo.io/versions/v36.0.0/sdk/netinfo/#installation

expo install @react-native-community/netinfo

this installs the version that is compatible with your sdk version

Andrea-Arguello

comment created time in 18 hours

pull request commentexpo/expo

webp format support (Android Only) for GLContext.takeSnapshot function

@nikki93 will review this next time he's around!

pacoelayudante

comment created time in 18 hours

issue commentexpo/expo

camera.takePictureAsync error on android, and silent error on ios

the base64 string would be huuuuge, i'm not sure if the ios alert dialog would even display that (seems like maybe not?)

yes, a runnable example that shows the minimal number of options and code required to reproduce the issue you have encountered is going to be necessary to investigate further

kopax

comment created time in 18 hours

issue commentexpo/expo

Firebase Firestore: Can't find variable: crypto

@RazaShehryar - post a mcve (https://stackoverflow.com/help/mcve)

RazaShehryar

comment created time in 19 hours

push eventexpo/expo

Brent Vatne

commit sha 370d2eed766e973ae82c24f700315ae95b378797

[template] Change bare template to use function component

view details

push time in 20 hours

issue commentexpo/expo-cli

2.88.2 Request has been deprecated

@alijatoi - https://github.com/npm/npm/issues/16313

alijatoi

comment created time in a day

issue commentexpo/expo-cli

2.88.2 Request has been deprecated

Extracting tar content of undefined failed, the file appears to be corrupt: "ENOSPC: no space left on device

alijatoi

comment created time in 2 days

push eventexpo/expo-cli

Brent Vatne

commit sha 54a71d89b9674f4907dfb0ec59397c3e3c29ae23

Add back legacy eject

view details

Brent Vatne

commit sha 8cda0f6483832b6364a7679b338915d75226bdac

Add Facebook config and some placeholders

view details

push time in 2 days

issue commentexpo/expo-cli

2.88.2 Request has been deprecated

@lucasantoniooficial - i'm not sure, you would have to look at the npm documentation

alijatoi

comment created time in 2 days

issue commentexpo/expo-cli

2.88.2 Request has been deprecated

@alijatoi - if you post the full error msg that you get when trying to install expo-cli i can guide you to a resource to fix the problem. the message you included in your original post is just a warning and it's unrelated

alijatoi

comment created time in 2 days

issue commentexpo/expo-cli

2.88.2 Request has been deprecated

@lucasantoniooficial - you don't have any hard drive space left, it says that like a hundred times in the error message you pasted 😆

alijatoi

comment created time in 2 days

issue commentexpo/expo-cli

2.88.2 Request has been deprecated

this is unrelated to the request warning! if you are having an issue with this you are most likely using windows and have some issue with permissions on your windows setup

alijatoi

comment created time in 2 days

issue commentexpo/expo

orientation is not locked during app's initial startup

can someone record a video of this? i'm not sure how to reproduce

3p3r

comment created time in 2 days

push eventreact-native-community/directory

jonsamp

commit sha 643890cad5059fb1658586508f5eaae67e1aa16d

Redesigns global header

view details

jonsamp

commit sha ef783512ec6969392dff40f7e939df57dbed07c2

adds styleguide

view details

jonsamp

commit sha d20167ae196ac6515a2f3f420923194b943801f5

Designs search

view details

jonsamp

commit sha 575902198c84ceeeb5b953f1140a32cca4bb30d0

better serach padding

view details

jonsamp

commit sha e209200c955e2b27b6a739ad3562d792bbb15a2d

removes office code

view details

jonsamp

commit sha e7644b77499dab2af28fae0b52f0ef13fb74c1e3

removes column 2

view details

jonsamp

commit sha 1bab9324d287d6928767f24e6b3a70e1cbe07ac5

wip

view details

jonsamp

commit sha cd0377f1e91b803125b4803caed4f233b05caa2e

Adds typography

view details

jonsamp

commit sha 337c339d42c65dcd9ae64beafa9dc9f09ff2c26f

Adds all icons

view details

jonsamp

commit sha 535e001aa516e35ecdfd0e159141c020d9e5cfe2

updates header

view details

jonsamp

commit sha f8c19254549480dc2e4d180c314edc70d1da1e28

Adds filter button and filters section

view details

jonsamp

commit sha b106636c3c15f3faefee279b294e629c109ae7cc

Adds sorting elements

view details

jonsamp

commit sha d40697e0c8736e34cc4ee5d932e368cae30086b3

fixes sort picker styles

view details

jonsamp

commit sha 9b8eb96dcf1f700eb6ed0ec2c05cd8863398b941

renames components

view details

jonsamp

commit sha ec7fcb9b48d7c0ebbae46e9485512cc1de1eb1da

Replaces ExternalLink

view details

jonsamp

commit sha cdac376435161037a74287088613bc4ddb4e9305

General cleanup + adds types

view details

jonsamp

commit sha 6972165450e83d77215fa52f6d0752c0ca32ae7a

Rename to Results

view details

jonsamp

commit sha e75f85bd70ef2bb88d03b202d44c6722bcdf9a77

Merge empty results into Results

view details

jonsamp

commit sha 5551a42cddd4c02a24150cf0e0de4488d15f2d70

column 1

view details

jonsamp

commit sha f705e3cc5bb43c687670f7c1f476eb90a692c569

Creates meta data

view details

push time in 2 days

PR merged react-native-community/directory

Redesigns React Native Directory

Summary

This PR redesigns the react native directory according to designs I created. The goal is summed up in this discussion.

This PR:

  • Adds a styleguide, with colors and typography components.
  • Adds icons to support designs
  • Reworks pretty much every visible element to adhere to the new design.

This PR does not:

  • Change the functionality of the directory or any of its data.
  • Does not change the footer.

Test Plan

Clone this branch, then run the site normally (yarn start). Then search, filter, order, and advance/decrease pagination pages. Make sure the URL updates like we expect.

Look at the existing site and make sure you can replicate its behavior on this branch.

Screenshots

Screen Shot 2020-03-25 at 11 46 42 PM Screen Shot 2020-03-25 at 11 46 48 PM Screen Shot 2020-03-25 at 11 47 08 PM

+1319 -922

1 comment

52 changed files

jonsamp

pr closed time in 2 days

push eventexpo/expo-cli

Eric Samelson

commit sha 263933d1b4ef71244116bb8d37e38f36feea996d

[expo-cli][xdl] make default target managed for all projects in SDK 36 and below (#1737)

view details

push time in 2 days

delete branch expo/expo-cli

delete branch : @eric/expo-sdk37-managed

delete time in 2 days

PR merged expo/expo-cli

[expo-cli][xdl] make default target managed for all projects in SDK 36 and below

This PR makes #1734 and #1736 no longer a breaking change for existing projects. SDK 36 and below projects will default to --target managed in expo publish and export.

Tested the following configurations to ensure the correct target was chosen:

  • [x] SDK 37 bare project : bare
  • [x] SDK 37 bare project with --target managed : managed
  • [x] SDK 37 managed project : managed
  • [x] SDK 37 managed project with --target bare : bare
  • [x] SDK 36 bare project : managed
  • [x] SDK 36 bare project with --target bare : bare
+16 -7

0 comment

3 changed files

esamelson

pr closed time in 2 days

push eventexpo/expo-cli

Brent Vatne

commit sha 0a8ee7648ce7135bc5ecc9d93deeff20848a054f

Extract Android standalone app config to @expo/config and apply on eject (#1698) * Add Android config to @expo/config * first pass at integrating into eject command * fix integration, get working e2e * add warnings for icon/adaptiveIcon, modify mainactivity.java * do not duplicate onConfigurationChanged method * add warning for SplashScreen * use memfs in tests, or remove filesystem interaction entirely * remove flag to run tests serially Co-authored-by: cruzach <charliecruzan@gmail.com>

view details

push time in 2 days

delete branch expo/expo-cli

delete branch : android-config

delete time in 2 days

PR merged expo/expo-cli

Extract Android standalone app config to @expo/config and apply on eject
  • [x] version
  • [x] versionCode
  • [x] scheme
  • [x] Permissions
  • [x] userInterfaceStyle - also iOS and android specific values. default to light
  • [x] orientation
  • [x] backgroundColor - also iOS and android specific values
  • [x] primaryColor
  • [x] androidStatusBar
  • [x] androidNavigationBar
  • [x] googleServicesFile
  • [x] “Config” object - branch, googleMapsApiKey, googleMobileAdsAppId, googleMobileAdsAutoInit
  • [x] intentfilters

Facebook:

  • [x] facebookappid
  • [x] Facebookautoinitenabled
  • [x] facebookAutoLogAppEventsEnabled
  • [x] facebookAdvertiserIDCollectionEnabled
  • [x] facebookDisplayName
  • [x] facebookScheme

Log Warnings for:

  • [x] adaptiveIcon
  • [x] icon
  • [x] Splash
+2330 -16

2 comments

45 changed files

brentvatne

pr closed time in 2 days

PR closed expo/expo-cli

Reviewers
fix: apply version, buildNumber, and versionCode on eject

ref https://github.com/expo/expo-cli/issues/1494

+29 -6

1 comment

2 changed files

cruzach

pr closed time in 2 days

delete branch expo/expo-cli

delete branch : @eric/expo-export-target

delete time in 2 days

push eventexpo/expo-cli

Eric Samelson

commit sha 0ec10410fad007ed10f6069619b1e7cebeebcfff

[export] add --target managed|bare option (#1736)

view details

push time in 2 days

PR merged expo/expo-cli

[expo-cli] add --target managed|bare option to export

Followup to #1734 -- add the same option to expo export so it's available to self-hosted apps. This has the same breaking change as well; expo export will no longer use .expo.* files by default in bare workflow projects.

Tested by logging the output of sourceExts in Project.ts and ensuring it has the correct extensions when running expo export, expo export --target managed, and expo export --target bare in both a bare and managed workflow project.

+44 -20

1 comment

1 changed file

esamelson

pr closed time in 2 days

issue commentexpo/expo

Facebook login not working with SDK35 after SDK36 release

@appseugene - can you create a new issue with a simple mcve and explanation of what's happening? it would be very helpful!

SeanRenet

comment created time in 3 days

push eventexpo/expo-cli

Eric Samelson

commit sha 3485aa2310e9b19a32b688f386b0e14954ce5728

[expo-cli][xdl][config] add expo publish --target managed|bare (#1734) * [expo-cli][xdl][config] add expo publish --target managed|bare, affects whether or not .expo.* files are used * Apply suggestions from code review Co-authored-by: Brent Vatne <brentvatne@gmail.com>

view details

push time in 3 days

delete branch expo/expo-cli

delete branch : @eric/expo-publish-target

delete time in 3 days

PR merged expo/expo-cli

[expo-cli][xdl][config] add expo publish --target managed|bare

Why

https://www.notion.so/expo/App-entry-points-94433d55f7524837be7b37bccb2154a1

TL;DR In order to make expo publish able to create bundles for both the managed Expo client environment and bare native client environments, we need to be able to choose at runtime whether or not to resolve .expo.* files in the project source.

This PR adds a --target flag to expo publish; for --target managed, the packager resolves .expo.* files, and for --target bare the packager ignores them.

This PR also changes the default behavior for bare projects. Previously, expo publish always resolved .expo.* files, but now it only does so by default for managed workflow projects.

This is a breaking change for people who rely on expo publish resolving .expo.* files in bare workflow projects -- these developers will need to add the explicit --target managed flag to the command after this commit.

How

  • Added a new getBareExtensions to @expo/config to match getManagedExtensions and thread target param through to startReactNativeServerAsync
  • Save the target in the packager info on disk; if there is an existing server instance running we only use it if the target matches, and close and restart otherwise
  • Added Project.isBareWorkflowProject util for distinguishing between managed & bare projects

Test Plan

Tested on a new bare workflow project from https://github.com/expo/expo/pull/7466

  • [x] --target field overrides default
  • [x] publishing with --target managed produces a build that errors with The Expo SDK requires Expo to run...
  • [x] publishing with --target bare or unspecified target produces a build that runs
  • [x] if expo start is running in a different process, publishing with --target managed uses the same server instance
  • [x] if expo start is running in a different process, publishing with --target bare closes that instance and starts a new one
+87 -8

0 comment

4 changed files

esamelson

pr closed time in 3 days

Pull request review commentexpo/expo-cli

[cli] tests for release channels

+import { vol } from 'memfs';+import { ApiV2 } from '@expo/xdl';++import { getPublicationDetailAsync, getPublishHistoryAsync } from '../utils/PublishUtils';++jest.mock('fs');+jest.mock('resolve-from');+jest.mock('ora', () =>+  jest.fn(() => {+    return {+      start: jest.fn(() => {+        return { stop: jest.fn(), succeed: jest.fn() };+      }),+    };+  })+);+jest.mock('@expo/xdl', () => {+  const user = {+    kind: 'user',+    username: 'test-username',+    nickname: 'test-nickname',+    userId: 'test-id',+    picture: 'test-pic',+    currentConnection: 'Username-Password-Authentication',+    sessionSecret: 'test-session-secret',+  };+  const pkg = jest.requireActual('@expo/xdl');+  pkg.UserManager.getCurrentUserAsync = jest.fn(() => user);

this will mutate the actual @expo/xdl module can could lead to some confusing errors - when tests are run in parallel there will be failures in random places depending on the load order of the tests relative to this test.

a safer way to do this is:

return {
  ...pkg,
  UserManager: {
    ...pkg.UserManager,
   getCurrentUserAsync: jest.fn(() => user),
  },
  // etc..
}
quinlanj

comment created time in 3 days

Pull request review commentexpo/expo-cli

[cli] tests for release channels

+import { vol } from 'memfs';+import { ApiV2 } from '@expo/xdl';++import {+  rollbackPublicationFromChannelAsync,+  setPublishToChannelAsync,+} from '../utils/PublishUtils';++jest.mock('fs');+jest.mock('resolve-from');+jest.mock('ora', () =>+  jest.fn(() => {+    return {+      start: jest.fn(() => {+        return { stop: jest.fn(), succeed: jest.fn() };+      }),+    };+  })+);+jest.mock('@expo/xdl', () => {+  const user = {+    kind: 'user',+    username: 'test-username',+    nickname: 'test-nickname',+    userId: 'test-id',+    picture: 'test-pic',+    currentConnection: 'Username-Password-Authentication',+    sessionSecret: 'test-session-secret',+  };+  const pkg = jest.requireActual('@expo/xdl');+  pkg.UserManager.getCurrentUserAsync = jest.fn(() => user);

same comment as in other file re: mutating @expo/xdl

quinlanj

comment created time in 3 days

issue commentexpo/expo

Permissions not working in standalone iOS build

@Rutvik17 - there have been no other reports of this so the error is likely on your side. please create a new issue with a minimal reproducible example and i would be happy to help, thanks! https://stackoverflow.com/help/mcve

dwkoogt

comment created time in 3 days

issue commentexpo/expo-cli

Outdated/deprecated dependencies

@anton-bot - that seems reasonable, care to open a PR?

edumorlom

comment created time in 3 days

push eventexpo/expo-cli

Brent Vatne

commit sha 2781d86a66d375d52112f5c90677644f940cb4ff

Apply suggestions from code review

view details

push time in 3 days

Pull request review commentexpo/expo-cli

[expo-cli][xdl][config] add expo publish --target managed|bare

 export async function action(projectDir: string, options: Options = {}) {       )}.`     );   }++  const target =+    options.target ?? ((await Project.isBareWorkflowProject(projectDir)) ? 'bare' : 'managed');
    options.target ?? ((await Project.isBareWorkflowProjectAsync(projectDir)) ? 'bare' : 'managed');
esamelson

comment created time in 3 days

Pull request review commentexpo/expo-cli

[expo-cli][xdl][config] add expo publish --target managed|bare

 export async function currentStatus(projectDir: string): Promise<ProjectStatus>   } } +export async function isBareWorkflowProject(projectDir: string): Promise<boolean> {
export async function isBareWorkflowProjectAsync(projectDir: string): Promise<boolean> {
esamelson

comment created time in 3 days

push eventexpo/expo-cli

Brent Vatne

commit sha 2b2b1b7e7ec7705d7952bd13a1345a325111a73b

Improve formatting of upgrade command and eject

view details

push time in 3 days

issue commentexpo/expo

SDK 37 library upgrades

@dotjsNet - i don't think it does, it updates to sdk 36. i just tried it :O

esamelson

comment created time in 3 days

issue commentexpo/expo

Android standalone app crashing on Android X

@caioedut - can you create a new issue with a minimal reproducible example? (https://stackoverflow.com/help/mcve)

serhanozcan

comment created time in 3 days

delete branch expo/expo-cli

delete branch : @fson/codemod-sdk37-imports

delete time in 3 days

push eventexpo/expo-cli

Ville Immonen

commit sha faaf076cd6d52eff4581bfeda32a38f8ce2dc94f

feat(expo-codemod): SDK 37 imports codemod (#1732) This codemod transforms AuthSession and ScreenOrientation imports to use the new expo-auth-session and expo-screen-orientation packages. Co-authored-by: Juwan Wheatley <datwheat@gmail.com> Co-authored-by: Juwan Wheatley <datwheat@gmail.com>

view details

push time in 3 days

PR merged expo/expo-cli

feat(expo-codemod): SDK 37 imports codemod

This codemod transforms AuthSession and ScreenOrientation imports to use the new expo-auth-session and expo-screen-orientation packages.

+170 -1

0 comment

3 changed files

fson

pr closed time in 3 days

PR opened expo/expo

Reviewers
[expo] Remove packages that don't actually need any additional setup now

Why

These don't require additional setup on eject anymore.

How

In some cases we have apply the config automatically from app.json so it's not needed, in other cases autolinking and improvements to the libraries remove the extra work needed.

+1 -8

0 comment

1 changed file

pr created time in 3 days

pull request commentexpo/expo

[android][web-browser] Fix WebBrowser sending 'dismiss' before opening

I can't reproduce the issue described here on SDK36 on Android.

import React from "react";
import { AppState, Button, StyleSheet, Text, View } from "react-native";
import * as WebBrowser from "expo-web-browser";

export default function App() {
  return (
    <View style={styles.container}>
      <Text>{AppState.currentState}</Text>
      <Button
        title="Press me"
        onPress={() => {
          WebBrowser.openAuthSessionAsync(
            "https://expo.io",
            "exp://127.0.0.1:19000"
          );
        }}
      />
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: "#fff",
    alignItems: "center",
    justifyContent: "center"
  }
});
  1. the AppState.currentState text is initialized to active, which is what is to be expected for React Native 0.61 (the docs appear to be outdated and incorrect - see https://github.com/facebook/react-native/blob/master/Libraries/AppState/AppState.js#L42
  2. I added logs to the app state change function that you modified and it fired with the values I expected: first background and then active when I return to the app.

I tried this inside of Expo client and in a standalone app (download apk here)

Can you explain how I can reproduce this problem on SDK36?

LucaColonnello

comment created time in 3 days

push eventexpo/expo-cli

Brent Vatne

commit sha 6c2ea657211408ae4eb742fa6440a34677cd92f1

Prompt for Android package

view details

Brent Vatne

commit sha 0f72dec9331e57279cdaafddf8e2575723d48e6f

Add other entitlements

view details

Brent Vatne

commit sha 4ca443518bd9e88ab5d11f6812e6ef366c74af84

Use ora succeed/fail in a few places

view details

Brent Vatne

commit sha 9a683d8ee043f457338cf704e9ca85e5a1a92f73

Improve formatting and fix typo

view details

push time in 3 days

create barnchexpo/expo

branch : @brent/updated-extra-setup-packages

created branch time in 3 days

Pull request review commentexpo/expo

[expo] make expo AppEntry work in bare workflow

+import Constants from 'expo-constants'; import * as React from 'react'; import { AppRegistry } from 'react-native'; +import isManagedEnvironment from '../environment/isManagedEnvironment'; import withExpoRoot from './withExpoRoot'; import { InitialProps } from './withExpoRoot.types';  export default function registerRootComponent<P extends InitialProps>(-  component: React.ComponentType<P>+  component: React.ComponentType<P>,+  appName?: string ): void {-  AppRegistry.registerComponent('main', () => withExpoRoot(component));+  const rootComponent = () => (isManagedEnvironment() ? withExpoRoot(component) : component);+  AppRegistry.registerComponent('main', rootComponent);++  if (Constants && Constants.manifest && Constants.manifest.slug) {
  if (Constants?.manifest?.slug) {
esamelson

comment created time in 4 days

Pull request review commentexpo/expo

[templates][bare] move to simpler index.js entryPoint that's a clone of expo/AppEntry.js

-import { AppRegistry } from 'react-native';+import { registerRootComponent } from 'expo';  import App from './App';-import { name as appName } from './app.json';-import 'expo-asset'; -AppRegistry.registerComponent(appName, () => App);

maybe it's worth adding a comment here so people have a clear understanding of what's going on and why we aren't using AppRegistry here

// registerRootComponent calls AppRegistry.registerComponent('main', () => App);
// It also handles ensuring if you load the app in Expo client or in a native build the environment is set up appropriately
esamelson

comment created time in 3 days

issue openedexpo/expo

[docs] Improve installation instructions

Installation block in docs can be a bit confusing to read, should reword the bare installation bit to

"If installing to a bare React Native app, also follow these additional installation instructions."

Managed installation instructions in README should be easier to read / remove the part about it not being in the SDK potentially (except where that still applies). The link should go to the docs, not the README.

For managed managed Expo projects, please follow the installation instructions in the documentation for the latest stable release.

created time in 3 days

pull request commentexpo/expo

[expo-apple-auth] Add “Sign up with Apple” option

we should wait until after sdk 37 is released before merging this because we don't want to pull the docs changes in from unversioned to 37

IjzerenHein

comment created time in 3 days

issue commentexpo/expo

Using MailCompser, working examples as mine stopped working

it's actually not in the bare react native section, it's just in the installation section. perhaps this needs to be made more clear.

the API section doesn't mention Installation instructions because that's what the Installation section is for

teckel12

comment created time in 3 days

issue commentexpo/expo-cli

expo init not creating project

I am using 6.13.7, I suspect it isn't really the npm version but the status of the installation on your machine. Do you use Windows by any chance? Do you have git installed?

nikijoe

comment created time in 3 days

issue openedexpo/expo

[docs] Add example for MailComposer

It's useful to have things that people can just copy+paste into their code. Should be a code example that links out to Snack, can use this as a basis for it: https://snack.expo.io/@notbrent/mailcomposer

Related to #7472

created time in 3 days

issue closedexpo/expo

Using MailCompser, working examples as mine stopped working

MailComposer stopped working

Environment

Expo CLI 3.15.5 environment info: System: OS: macOS 10.15.4 Shell: 3.2.57 - /bin/bash Binaries: Node: 12.9.1 - /usr/local/bin/node Yarn: 1.17.3 - /usr/local/bin/yarn npm: 6.10.2 - /usr/local/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman IDEs: Android Studio: 3.4 AI-183.6156.11.34.5692245 Xcode: 11.4/11E146 - /usr/bin/xcodebuild npmPackages: expo: ^36.0.0 => 36.0.2 react: 16.9.0 => 16.9.0 react-native: https://github.com/expo/react-native/archive/sdk-36.0.1.tar.gz => 0.61.4 react-navigation: ^2.11.2 => 2.11.2 npmGlobalPackages: expo-cli: 3.15.5

Target app: iOS/Android

Steps to Reproduce

import { MailComposer } from 'expo';

        MailComposer.composeAsync({
            subject: 'test',
            body: 'test',
            recipients: ['teckel@domain.com'],
            isHtml: true
        });

Expected Behavior

Should open an email, like it did previously

Actual Behavior

Throws the error:

TypeError: undefined is not an object (evaluating `_expo.MailComposer.composeAsync')

closed time in 3 days

teckel12

issue commentexpo/expo

Using MailCompser, working examples as mine stopped working

here's an example you can run on your phone: https://snack.expo.io/@notbrent/mailcomposer

teckel12

comment created time in 3 days

issue commentexpo/expo

Using MailCompser, working examples as mine stopped working

from the docs:

Screen Shot 2020-03-25 at 10 59 57 AM

notice import * as MailComposer from 'expo-mail-composer';

teckel12

comment created time in 3 days

push eventexpo/expo-cli

Brent Vatne

commit sha bf40f957c7686a7033ad9d102be1eb6ee4d3ae3f

More formatting changes and add notice about web script to end of eject

view details

push time in 3 days

push eventexpo/expo-cli

Brent Vatne

commit sha ef9dd6259d2c04e71db4ec7bb2538305b29b3fa1

Bold looks better than underline

view details

push time in 3 days

push eventexpo/expo-cli

Brent Vatne

commit sha a7c3aa598ffc1f6d48fe03567c334be65b9b632b

Work in progress improving the eject command flow

view details

Brent Vatne

commit sha 91e98a42ad3e3a6ad4f0b0afe97467d4ddbd4552

More formatting and fix issue with entitlements path

view details

push time in 3 days

issue commentexpo/expo

Facebook login not working with SDK35 after SDK36 release

you might want to create a new issue with more information. the comment directly above yours indicate they were using expo-facebook@8.0.0 so i assumed that you were in the same position. this issue has been known to be resolved so it's best to have a new issue that follows the issue template so we have all of the information we need to help you. thanks!

SeanRenet

comment created time in 4 days

issue commentexpo/expo

Facebook login not working with SDK35 after SDK36 release

use expo install expo-facebook to get the correct version of expo-facebook for your sdk version

SeanRenet

comment created time in 4 days

issue commentexpo/expo

SDK 37 library upgrades

that will have to come in sdk 38, we have already done the upgrades for sdk 37 and will be shipping it soon

esamelson

comment created time in 4 days

issue commentoblador/react-native-progress

Doesn't work in Expo SDK36

Expo docs claim they have ART built in, but maybe it's time to rethink the choice of vector rendering library now that it's been janked from core.

yeah we removed ART from expo managed apps and updated our docs accordingly: https://docs.expo.io/versions/latest/sdk/art/

we don't plan to include it because it is not really maintained and its functionality can be achieved in a more standard way using svg

sungsong88

comment created time in 4 days

issue commentexpo/expo-cli

expo init not creating project

@RyanMitchellWilson - this isn't an issue with expo it's an issue with npm. i only recommended yarn here because it is easier to switch to that than to help people to debug issues with npm.

if you can post an issue with more information to demonstrate that the issue is on the expo side (to show that you are using the latest stable version of npm and that the installation is working correctly) we will definitely investigate. however, with a properly working npm setup, expo init works exactly as expected

nikijoe

comment created time in 4 days

push eventexpo/expo-cli

Evan Bacon

commit sha 51b94d566f06d719636d9c75d1b1b36de6d69545

Use devcert to create SSL certificate (#1518) * Use devcert to create SSL certificate * Open routes to localhost when possible

view details

Evan Bacon

commit sha 251585bf897193bbc788924f6e0e785e23ad1498

Create method for getting sharp instance (#1710)

view details

Evan Bacon

commit sha ddc78506ba6fd47bfb96778be3dffc6b20fd8b77

Created option for clearing web caches (#1711)

view details

Eric Samelson

commit sha 4c48f890d059ea995e3352aad76d4a7f7f71a7be

[xdl] autofill expo-updates properties on `expo publish` (#1533)

view details

Evan Bacon

commit sha 99efb37cbfd54b96db5e8d59665fe937fe14b95d

Bump babel to fix #7419 (#1714)

view details

Brent Vatne

commit sha cd5e92ea3b1e7ec9c792a86aaab5b85e63d590c5

Publish - @expo/babel-preset-cli@0.2.7 - @expo/config@2.6.6 - @expo/dev-tools@0.10.12 - @expo/electron-adapter@0.0.0-alpha.28 - expo-cli@3.15.5 - expo-codemod@1.0.14 - expo-optimize@0.1.6 - @expo/image-utils@0.2.14 - @expo/json-file@8.2.7 - @expo/next-adapter@2.0.14 - @expo/osascript@2.0.12 - @expo/package-manager@0.0.7 - @expo/schemer@1.3.7 - @expo/webpack-config@0.11.9 - @expo/webpack-pwa-manifest-plugin@1.2.26 - @expo/xdl@57.6.4

view details

Evan Bacon

commit sha 88f4115c3c9f9de8c6ba8327b73ae617a8807247

Use new progress plugin for better logging (#1715)

view details

Evan Bacon

commit sha 09cf705a315b7964c5ea61cb0c8c45b544223190

[config] Move define plugin reducer method to webpack-config (#1716) * Move define plugin reducer * remove productionManifestPath argument

view details

Evan Bacon

commit sha 09586b4bc53b74b95970f1f41966676f1cc3df64

[image-utils] Created methods for generating favicons and icons (#1713) * Created methods for generating favicons and icons * Update yarn.lock

view details

Evan Bacon

commit sha 5324106496db7a23740721b221c554118943fd0d

Deprecate custom `expo.web.build.rootId` key (#1717) * Deprecate custom `rootId` control * Update Web.ts

view details

Evan Bacon

commit sha dd99d7eeda9225070e02df9c72c98e0c1be398f1

[webpack-config] Deprecate built-in Webpack reporting (#1718) * Deprecate built-in Webpack reporting * Remove unused

view details

Evan Bacon

commit sha 6d9db5b3ce5f71668904009b82b4c1b2fcdb1793

Ignore more packages

view details

Evan Bacon

commit sha 4786c8188bff1c8558f75030516523c99e372773

[webpack-config] Deprecate noJavaScriptMessage (#1719) * Deprecate noJavaScriptMessage * fix reload button

view details

Evan Bacon

commit sha c2ca5ad4ad797a156b5901923714004d2bf328a2

Use dynamic aliases for Webpack (#1721)

view details

Brent Vatne

commit sha 8af3766a43ceab3afeef7625c471a0b41cd488e7

[xdl][config] Move IosSetBundleIdentifier to @expo/config/ios

view details

Brent Vatne

commit sha 0e45f816008fe46c44ed1b1d38459eb7edc14d97

[config][xdl] Extract BundleIdentifier, Name, Version config to @expo/config

view details

Brent Vatne

commit sha 384b213013deff0581cc7efa8969bd11baa69434

Fix old reference by path

view details

Brent Vatne

commit sha f49e525bf82b53d8ef326c3a519c16b8480f6e4c

Add scheme config

view details

Brent Vatne

commit sha 11b1d09644eed5490c75384b97a45ecd34bd49b9

Add config from ios.infoPlist

view details

Brent Vatne

commit sha 45d87b3a98b1781067b674c8e6ce07793843fd07

UIUserInterfaceStyle config

view details

push time in 4 days

issue commentexpo/expo

SDK 37 library upgrades

you shouldn't upgrade to new sdk verisons until we publish the release notes on blog.expo.io

esamelson

comment created time in 4 days

issue openedexpo/expo-cli

Update codemod for SDK37 to apply to auth-session and screen-orientation

These APIs were extracted in SDK37 and it would be useful for people to be able to update their imports automatically.

created time in 4 days

issue openedexpo/expo-cli

Warn when git is not installed and possibly install it for people too

Git is currently required to use expo-cli. This is mainly because some packages point to a git repo (eg: the react-native expo fork).

created time in 5 days

push eventexpo/expo

Javier Ubillos

commit sha 525f1be314f0b1f268bf30bdc118ffeb334d74ae

Added link to expo-server-sdk-java in push-notifications doc. (#7429) Added link to a Java implementation of the expo-server-sdk. https://github.com/jav/expo-server-sdk-java Added to v36.0.0 and unversioned. Co-authored-by: Javier Ubillos <javier@ubillos.org>

view details

push time in 6 days

PR merged expo/expo

Added link to expo-server-sdk-java in push-notifications doc.

Added link to a Java implementation of the expo-server-sdk. https://github.com/jav/expo-server-sdk-java

Added to v36.0.0 and unversioned.

I chose "maintained by communicty maintainers" to follow the pattern. I'm not sure it is correct, however, it seemed to be the norm.

Why

I re-implemented expo-server-sdk-node in java. This PR updates the push-notification parts of the docs to link to the java implementation

How

It's a markup update of the bullet-list listing expo-server-sdk-* implementations, found in the push notification docs.

Test Plan

No test plan. In CONTRIBUTING.md#-updating-documentation it's suggested that no tests are needed.

+2 -0

1 comment

2 changed files

jav

pr closed time in 6 days

pull request commentexpo/expo

Added link to expo-server-sdk-java in push-notifications doc.

thank you!

jav

comment created time in 6 days

push eventexpo/expo

Evan Bacon

commit sha 75a2002b102eb498b6b9c13c027f448d636b7ba7

Added web-build to bare template git ignores (#7428) * Added web-build to bare template git ignores * Update gitignore

view details

push time in 7 days

delete branch expo/expo

delete branch : @evanbacon/templates/add-web-build-to-gitignore

delete time in 7 days

PR merged expo/expo

Added web-build to bare template git ignores Platform: web

Why

Prevent web-build files from being added to the git tree

+2 -0

0 comment

2 changed files

EvanBacon

pr closed time in 7 days

issue commentexpo/expo

[web] Failed to compile - Unknown helper createSuper

can you post a reproducible example? this is working locally for me and that was the error that should have been fixed

ggunti

comment created time in 8 days

issue commentexpo/expo

[web] Failed to compile - Unknown helper createSuper

if you update to expo-cli@3.15.5 this is resolved - we bumped the babel versions in the webpack config

ggunti

comment created time in 8 days

push eventexpo/expo-cli

Brent Vatne

commit sha cd5e92ea3b1e7ec9c792a86aaab5b85e63d590c5

Publish - @expo/babel-preset-cli@0.2.7 - @expo/config@2.6.6 - @expo/dev-tools@0.10.12 - @expo/electron-adapter@0.0.0-alpha.28 - expo-cli@3.15.5 - expo-codemod@1.0.14 - expo-optimize@0.1.6 - @expo/image-utils@0.2.14 - @expo/json-file@8.2.7 - @expo/next-adapter@2.0.14 - @expo/osascript@2.0.12 - @expo/package-manager@0.0.7 - @expo/schemer@1.3.7 - @expo/webpack-config@0.11.9 - @expo/webpack-pwa-manifest-plugin@1.2.26 - @expo/xdl@57.6.4

view details

push time in 8 days

push eventexpo/expo-cli

Evan Bacon

commit sha 99efb37cbfd54b96db5e8d59665fe937fe14b95d

Bump babel to fix #7419 (#1714)

view details

push time in 8 days

delete branch expo/expo-cli

delete branch : @evanbacon/webpack-config/bump-babel

delete time in 8 days

PR merged expo/expo-cli

[webpack-config] Bump babel Platform: web bug with another tool

fix https://github.com/expo/expo/issues/7419

Test Plan

  • expo start:web should open without errors
+172 -6

0 comment

2 changed files

EvanBacon

pr closed time in 8 days

issue closedexpo/expo

[web] Failed to compile - Unknown helper createSuper

🐛 Bug Report

Environment

<!-- In your terminal run expo diagnostics and paste the output here. --> Expo CLI 3.13.8 environment info: System: OS: macOS 10.15.2 Shell: 3.2.57 - /bin/bash Binaries: Node: 10.15.3 - /usr/local/bin/node Yarn: 1.22.4 - /usr/local/bin/yarn npm: 6.13.7 - /usr/local/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman IDEs: Android Studio: 3.4 AI-183.6156.11.34.5522156 Xcode: 11.3/11C29 - /usr/bin/xcodebuild npmPackages: expo: ~36.0.0 => 36.0.2 react: ~16.9.0 => 16.9.0 react-native: https://github.com/expo/react-native/archive/sdk-36.0.0.tar.gz => 0.61.4 npmGlobalPackages: expo-cli: 3.13.8

<!-- Please also let us know about your app's target (iOS, Android, Client, Standalone, ExpoKit) --> Target: web

Steps to Reproduce

<!-- How would you describe your issue to someone who doesn’t know you or your project? Try to write a sequence of steps that anybody can repeat to see the issue. Be specific! If the bug cannot be reproduced, your issue may be closed. --> Run expo init <yourProjectName> and npm run web inside <yourProjectName> directory.

Expected Behavior

<!-- How did you expect your project to behave? It’s fine if you’re not sure your understanding is correct. Just write down what you thought would happen. --> Run the app for web.

Actual Behavior

<!-- Did something go wrong? Is something broken, or not behaving as you expected? Describe this section in detail, and attach screenshots if possible. Don't just say "it doesn't work"! --> I get 'Failed to compile' error, like here: Captură de ecran din 2020-03-20 la 21 04 00

NOTE THAT IT WORKS ON ANDROID & IOS.

Reproducible Demo

<!-- Please share a project that reproduces the issue. There are two ways to do it:

* Create a new app using https://snack.expo.io/ and try to reproduce the issue in it.
  This is useful if you roughly know where the problem is, or can’t share the real code.

* Or, copy your app and remove things until you’re left with the minimal reproducible demo.
  This is useful for finding the root cause. You may then optionally create a Snack.

This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve Once you’re done, copy and paste the link to the Snack or a public GitHub repository below.

(Even if your issue can only be reproduced in a standalone app, please include a Snack or GitHub repo we can use to build a standalone app!) -->

<!-- What happens if you skip this step?

Someone will read your bug report, and maybe will be able to help you, but it’s unlikely that it will get much attention from the team. Eventually, the issue will likely get closed in favor of issues that have reproducible demos.

Please remember that:

* Issues without reproducible demos have a very low priority.
* The person fixing the bug would have to do that anyway. Please be respectful of their time.
* You might figure out the issues yourself as you work on extracting it.

Thanks for helping us help you! -->

closed time in 8 days

ggunti

push eventexpo/expo-cli

Brent Vatne

commit sha cf08b10a65333a90d2f7e95cf586410f469d6b4f

First end-to-end entitlements working

view details

push time in 8 days

issue commentexpo/expo

[web] Failed to compile - Unknown helper createSuper

this impacted create-react-app as well, we should have a solution soon after the pull request @EvanBacon mentioned is merged and released

ggunti

comment created time in 8 days

issue commentexpo/expo

[web] Failed to compile - Unknown helper createSuper

@EvanBacon will investigate shortly

ggunti

comment created time in 8 days

push eventexpo/expo-cli

Brent Vatne

commit sha 7df05857e2450bce2e52f289197197ad9422dce3

Remove duplicate function definition

view details

jkh

commit sha 6add11a7b4da43e655af2fcd4f4ee2409f11a461

[expo-cli][credentials] make credentials query api v2 by default (#1700)

view details

Hein Rutjes

commit sha e636fff3f11894177726a7d6610f329c0932d858

Fix app.json parse errors not reported correctly (#1709) When `app.json` contains invalid json it would fall-though the config loading process and result in an empty JSON object. No error message is then printed pointing to the location in the JSON file that contains the syntax error. Instead, schema validation errors such as ‘no slug` or ‘no name` would be printed which are confusing.

view details

Brent Vatne

commit sha a853b2f463680008746a5ef996d1cadf8db77d98

[xdl][config] Move IosSetBundleIdentifier to @expo/config/ios

view details

Brent Vatne

commit sha 9f22f9694b5c2726d83176cca0a85d0d1f6a6e0b

[config][xdl] Extract BundleIdentifier, Name, Version config to @expo/config

view details

Brent Vatne

commit sha 0f9f8ec2f96b27b0fa5bfd4f4fd9a2bebf0b958d

Fix old reference by path

view details

Brent Vatne

commit sha e54bcb6d190e8b943d8d3ff16baf84f0e5cb3f5d

Add scheme config

view details

Brent Vatne

commit sha ecf6fc87ddab94037faf9060783d85afa40df828

Add config from ios.infoPlist

view details

Brent Vatne

commit sha f57bd046bc6264e500f99f31950581650d472d63

UIUserInterfaceStyle config

view details

Brent Vatne

commit sha a44b1f05fa2fc65eac0d72290fb0e6908cc097ec

Add UIDeviceFamily

view details

Brent Vatne

commit sha e2e83c29469e515a5146447d29643f66c27d5ec7

Add UIRequiresFullScreen

view details

Brent Vatne

commit sha 4eaa10596dc31f8de437598d2dd4ea64187a8678

Import ReadEntry type from tar

view details

Brent Vatne

commit sha 2cfd6971d92337f39134eef8c00290a76fa42575

Add TODO comment for template names

view details

Brent Vatne

commit sha 0deb13bcd7d8b7a5e4ddd4df02749dd3048b91c1

Start wiring up eject

view details

Brent Vatne

commit sha 124eff89f6398ba5c14a8a2941ad98d627b3682a

Integrate IOSConfig into Eject command

view details

Brent Vatne

commit sha 1b4912896dc9e0c7081ad4611e340fa590a88a4b

Use fs-extra instead of spawning cp/rm

view details

Brent Vatne

commit sha 172a79cf5a34b85853e1e407a638fa561bc57cfc

Deprecate eject-method flag

view details

Brent Vatne

commit sha 833f6ebfb2dc0a3b6e1e1d5adbb9d4dc802f3d5a

Add hidden apply command for easy testing

view details

Brent Vatne

commit sha 6d85951735be6feeb861b555f21ed5eee474d280

Add UsesNonExemptEncryption and Branch

view details

Brent Vatne

commit sha aa9d84e11a61d2bd862338f13193901772f2a244

Get icon path

view details

push time in 8 days

pull request commentexpo/expo-cli

[cli] fix publish:rollback

could you add some unit tests here? ideally all new code being added to expo-cli should improve test coverage

quinlanj

comment created time in 8 days

pull request commentexpo/expo-cli

Fix app.json parse errors not reported correctly

thanks!

IjzerenHein

comment created time in 8 days

more