profile
viewpoint
Brendan Kowitz brendankowitz @Microsoft Redmond, WA

brendankowitz/Caliburn.Micro.Autofac 12

Integration of Caliburn.Micro and Autofac

brendankowitz/AgilityWall 3

A windowsphone and windowsstore Trello client built with Caliburn Micro

brendankowitz/devicedetection 3

Mobile and Tablet device detection

brendankowitz/agilitywall.com 0

Agility Wall App Website

brendankowitz/aspnet-redis-providers 0

ASP.NET Redis Providers

brendankowitz/Autofac 0

An addictive .NET IoC container

brendankowitz/Autofac.iOS 0

An Autofac build for iOS

brendankowitz/azure-content 0

Repository containing the Articles on azure.microsoft.com Documentation Center

brendankowitz/azure-docs 0

Open source documentation of Microsoft Azure

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha b47cd980814bb525ac3f466aa4721ef48f2b8740

Cleanup

view details

push time in 2 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 489b2105391893b6b2de66ea7deabebea2a1a47c

Cleanup

view details

push time in 2 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 0e47fb2911e67c38b4b8c15098db79dfaed8b932

Cleanup

view details

push time in 2 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 965d396b827de47e74908a6233e6707476301ead

Cleanup

view details

push time in 2 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha f6f394fb122163b107c5835843673cbb80dfd1fd

Updates package 'Newtonsoft.Json.Schema' to version '3.0.13' (#1132)

view details

push time in 2 days

delete branch microsoft/fhir-server

delete branch : auto-nuget-update/newtonsoft

delete time in 2 days

PR opened microsoft/fhir-server

Bubbles through the service unavailable if EnsureInitialization fails

Description

Exposes the ServiceUnavailable exception and status code if EnsureInitialization fails.

+26 -5

0 comment

4 changed files

pr created time in 2 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha bc976ce59f91fd2a68a53f3d799d1e452243f36e

Bubbles through the service unavailable if ensureintitialized fails

view details

push time in 2 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 41019573738923ca3e4e1609bd513b53793ca6ab

Upgrade to CosmosDb SDK v3 (#1107)

view details

Michael Hansen

commit sha 13d50a8217f288c42434ed4de837c48266e377f4

Prometheus (#1130) * Adding optional Prometheus metrics * Adding PrometheusMetrics Server (separate port)

view details

Robert Johnson

commit sha f06ef6d044f2f9cbde44fafd0b6c4047989d1b0b

Add export for Patient compartment data (#1108) * Add sub search support * Add Patient compartment export

view details

Michael Hansen

commit sha 1a242e6eb52b89c21cd9130152dc1aca4da546e0

Added a deploy master images step to CI build (#1138) Added last known good master tag.

view details

Microsoft Health

commit sha e3f489d617b851848e1d4873cd18e39f86ce4b58

Updates package 'AngleSharp' to version '0.14.0' (#1129)

view details

Brendan Kowitz

commit sha 569c592700f58f3b76d4515fca355999120fa9e4

Merge remote-tracking branch 'origin/master' into auto-nuget-update/microsoft.aspnet # Conflicts: # src/Microsoft.Health.CosmosDb/Microsoft.Health.CosmosDb.csproj # src/Microsoft.Health.Fhir.CosmosDb/Microsoft.Health.Fhir.CosmosDb.csproj # src/Microsoft.Health.Fhir.R4.Web/Microsoft.Health.Fhir.R4.Web.csproj # src/Microsoft.Health.Fhir.R5.Web/Microsoft.Health.Fhir.R5.Web.csproj # src/Microsoft.Health.Fhir.Stu3.Web/Microsoft.Health.Fhir.Stu3.Web.csproj

view details

push time in 2 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha cb173530c8d63e75664988bcdf585c83a6747b15

Updates package 'Ensure.That' to version '9.2.0' (#1123)

view details

Microsoft Health

commit sha 6549ceb0b64e45f09b30fb055c430c7a521671e1

Updates package 'Polly' to version '7.2.1' (#1127)

view details

Jared Erwin

commit sha 024b1b52f551010da35bb6498046f74241d4322e

Update Reindex job task to query search parameters that are not yet indexed (#1090) Updates the reindex worker to query the search parameters for any supported but not yet indexed parameters.

view details

Brendan Kowitz

commit sha 41019573738923ca3e4e1609bd513b53793ca6ab

Upgrade to CosmosDb SDK v3 (#1107)

view details

Michael Hansen

commit sha 13d50a8217f288c42434ed4de837c48266e377f4

Prometheus (#1130) * Adding optional Prometheus metrics * Adding PrometheusMetrics Server (separate port)

view details

Robert Johnson

commit sha f06ef6d044f2f9cbde44fafd0b6c4047989d1b0b

Add export for Patient compartment data (#1108) * Add sub search support * Add Patient compartment export

view details

Michael Hansen

commit sha 1a242e6eb52b89c21cd9130152dc1aca4da546e0

Added a deploy master images step to CI build (#1138) Added last known good master tag.

view details

Microsoft Health

commit sha e3f489d617b851848e1d4873cd18e39f86ce4b58

Updates package 'AngleSharp' to version '0.14.0' (#1129)

view details

Brendan Kowitz

commit sha 9d0b840096ef73e723596ee7d5f586c57a0e7f4b

Merge branch 'master' into auto-nuget-update/newtonsoft

view details

push time in 2 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 41019573738923ca3e4e1609bd513b53793ca6ab

Upgrade to CosmosDb SDK v3 (#1107)

view details

Michael Hansen

commit sha 13d50a8217f288c42434ed4de837c48266e377f4

Prometheus (#1130) * Adding optional Prometheus metrics * Adding PrometheusMetrics Server (separate port)

view details

Robert Johnson

commit sha f06ef6d044f2f9cbde44fafd0b6c4047989d1b0b

Add export for Patient compartment data (#1108) * Add sub search support * Add Patient compartment export

view details

Michael Hansen

commit sha 1a242e6eb52b89c21cd9130152dc1aca4da546e0

Added a deploy master images step to CI build (#1138) Added last known good master tag.

view details

Microsoft Health

commit sha e3f489d617b851848e1d4873cd18e39f86ce4b58

Updates package 'AngleSharp' to version '0.14.0' (#1129)

view details

Brendan Kowitz

commit sha b00b3678c81f072e8d634df2841e05dd2844b384

Merge branch 'master' into auto-nuget-update/mediatr

view details

push time in 2 days

delete branch microsoft/fhir-server

delete branch : auto-nuget-update/anglesharp

delete time in 2 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha e3f489d617b851848e1d4873cd18e39f86ce4b58

Updates package 'AngleSharp' to version '0.14.0' (#1129)

view details

push time in 2 days

pull request commentmicrosoft/fhir-server

Updates package 'AngleSharp' to version '0.14.0'

/azp run

MicrosoftHealthService

comment created time in 2 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 41019573738923ca3e4e1609bd513b53793ca6ab

Upgrade to CosmosDb SDK v3 (#1107)

view details

push time in 3 days

delete branch microsoft/fhir-server

delete branch : personal/bkowitz/upgrade-cosmos-sdk

delete time in 3 days

PR merged microsoft/fhir-server

Upgrade to CosmosDb SDK v3

Description

Removes the v2 SDK and upgrades all apis to use v3. Going forward this has functionality such as Batches/Transactions/Bulk apis that we can look into utilizing.

Also merges the two *Fhir.CosmosDb and *.CosmosDb projects back together

Related issues

Addresses AB#74576.

Testing

Converts all existing tests to use new API

+1468 -5355

7 comments

106 changed files

brendankowitz

pr closed time in 3 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha 3f7ae9d0e862b77df4aefde55f672315825baf09

Updates package 'Microsoft.Azure.KeyVault' to version '3.0.5' (#1124)

view details

Microsoft Health

commit sha b5b1e6b758c58327b8b29449faff1d3a43d80e65

Updates package 'Microsoft.Azure.Storage.Blob' to version '11.1.7' (#1126)

view details

Microsoft Health

commit sha cb173530c8d63e75664988bcdf585c83a6747b15

Updates package 'Ensure.That' to version '9.2.0' (#1123)

view details

Microsoft Health

commit sha 6549ceb0b64e45f09b30fb055c430c7a521671e1

Updates package 'Polly' to version '7.2.1' (#1127)

view details

Jared Erwin

commit sha 024b1b52f551010da35bb6498046f74241d4322e

Update Reindex job task to query search parameters that are not yet indexed (#1090) Updates the reindex worker to query the search parameters for any supported but not yet indexed parameters.

view details

Brendan Kowitz

commit sha 6dd743dcf2fe0856f0c8aa7ca8967259ce9c7951

Merge remote-tracking branch 'origin/master' into auto-nuget-update/microsoft.aspnet

view details

push time in 3 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha cb173530c8d63e75664988bcdf585c83a6747b15

Updates package 'Ensure.That' to version '9.2.0' (#1123)

view details

Microsoft Health

commit sha 6549ceb0b64e45f09b30fb055c430c7a521671e1

Updates package 'Polly' to version '7.2.1' (#1127)

view details

Jared Erwin

commit sha 024b1b52f551010da35bb6498046f74241d4322e

Update Reindex job task to query search parameters that are not yet indexed (#1090) Updates the reindex worker to query the search parameters for any supported but not yet indexed parameters.

view details

Brendan Kowitz

commit sha ef3f55b51541ed9fb1089b023d8a738797d91448

Merge remote-tracking branch 'origin/master' into auto-nuget-update/mediatr

view details

push time in 3 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha 3f7ae9d0e862b77df4aefde55f672315825baf09

Updates package 'Microsoft.Azure.KeyVault' to version '3.0.5' (#1124)

view details

Microsoft Health

commit sha b5b1e6b758c58327b8b29449faff1d3a43d80e65

Updates package 'Microsoft.Azure.Storage.Blob' to version '11.1.7' (#1126)

view details

Microsoft Health

commit sha cb173530c8d63e75664988bcdf585c83a6747b15

Updates package 'Ensure.That' to version '9.2.0' (#1123)

view details

Microsoft Health

commit sha 6549ceb0b64e45f09b30fb055c430c7a521671e1

Updates package 'Polly' to version '7.2.1' (#1127)

view details

Jared Erwin

commit sha 024b1b52f551010da35bb6498046f74241d4322e

Update Reindex job task to query search parameters that are not yet indexed (#1090) Updates the reindex worker to query the search parameters for any supported but not yet indexed parameters.

view details

Brendan Kowitz

commit sha 7aaccf489f8cd2dccafc83d48b853e4bf803a722

Merge remote-tracking branch 'origin/master' into auto-nuget-update/anglesharp # Conflicts: # src/Microsoft.Health.Fhir.Core/Microsoft.Health.Fhir.Core.csproj # src/Microsoft.Health.Fhir.R4.Core/Microsoft.Health.Fhir.R4.Core.csproj # src/Microsoft.Health.Fhir.R5.Core/Microsoft.Health.Fhir.R5.Core.csproj # src/Microsoft.Health.Fhir.Stu3.Core/Microsoft.Health.Fhir.Stu3.Core.csproj

view details

push time in 3 days

Pull request review commentmicrosoft/fhir-server

Prometheus

 public virtual void ConfigureServices(IServiceCollection services)                 });             } +            PrometheusMetricsConfig prometheusConfig = new PrometheusMetricsConfig();+            Configuration.Bind("PrometheusMetrics", prometheusConfig);+            services.AddSingleton(Options.Create(prometheusConfig));++            if (prometheusConfig.Enabled)+            {+                services.Add<PrometheusMetricsServer>()+                    .Singleton()+                    .AsService<IStartable>();++                if (prometheusConfig.SystemMetrics)+                {+                    services.AddSystemMetrics();+                }+            }

Not required for now, but IStartupModel(IConfiguration) allows you to move this type of code out

hansenms

comment created time in 3 days

Pull request review commentmicrosoft/fhir-server

Prometheus

 public virtual void ConfigureServices(IServiceCollection services)                 });             } +            PrometheusMetricsConfig prometheusConfig = new PrometheusMetricsConfig();+            Configuration.Bind("PrometheusMetrics", prometheusConfig);+            services.AddSingleton(Options.Create(prometheusConfig));++            if (prometheusConfig.Enabled)+            {+                services.Add<PrometheusMetricsServer>()+                    .Singleton()+                    .AsService<IStartable>();++                if (prometheusConfig.SystemMetrics)+                {+                    services.AddSystemMetrics();+                }+            }+             AddApplicationInsightsTelemetry(services);         }          // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.-        public virtual void Configure(IApplicationBuilder app)+        public virtual void Configure(IApplicationBuilder app, IOptions<PrometheusMetricsConfig> prometheusConfig)         {             if (string.Equals(Configuration["ASPNETCORE_FORWARDEDHEADERS_ENABLED"], "true", StringComparison.OrdinalIgnoreCase))             {                 app.UseForwardedHeaders();             } +            var prometheusMetricsConfig = prometheusConfig.Value;+            if (prometheusMetricsConfig.Enabled)+            {+                if (prometheusMetricsConfig.HttpMetrics)+                {+                    app.UseHttpMetrics();+                }+            }

Perhaps to make this cleaner, we could follow app.UsePrometheusMetrics() pattern. Then resolve the config with app.ApplicationServices.GetService<> instead of changing this Configure signature

hansenms

comment created time in 3 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 39f3de7a43f0f12182fcad41353f78e008902225

Updates CosmosFhirOperationDataStore

view details

push time in 3 days

push eventmicrosoft/fhir-server

John Stairs

commit sha 60f8975a6a39e1376d37227a2eafce211ee0f9bd

Fix continuation token issues with chained searches (#1106) * ExportDataValidationTests fail if there are duplicate IDs * Promote denormalized predicates to chained table expressions * Added some comments

view details

John Stairs

commit sha 1b2cc1340718856607db2b1c5b95845e1f9d9d6d

Fix errors when _summary=count or _total=accurate is specified with an _include parameter (#1116)

view details

Jared Erwin

commit sha 0fe9a2a23b36176d38aa0e8c5e53745577b1ad8b

Remove start/end time from return Parameters after initial job creation (#1105) Updates the returned Parameters resource after creating a Reindex job to include queued time, but not start/end time. Also updates the GET reindex job route.

view details

brandonpollett

commit sha 8db48042f7b2d27581e7e7b1757ff01e73dc6f24

Update implementation of FhirClient to use Credential providers. (#1113)

view details

Microsoft Health

commit sha 3f7ae9d0e862b77df4aefde55f672315825baf09

Updates package 'Microsoft.Azure.KeyVault' to version '3.0.5' (#1124)

view details

Microsoft Health

commit sha b5b1e6b758c58327b8b29449faff1d3a43d80e65

Updates package 'Microsoft.Azure.Storage.Blob' to version '11.1.7' (#1126)

view details

Microsoft Health

commit sha cb173530c8d63e75664988bcdf585c83a6747b15

Updates package 'Ensure.That' to version '9.2.0' (#1123)

view details

Microsoft Health

commit sha 6549ceb0b64e45f09b30fb055c430c7a521671e1

Updates package 'Polly' to version '7.2.1' (#1127)

view details

Jared Erwin

commit sha 024b1b52f551010da35bb6498046f74241d4322e

Update Reindex job task to query search parameters that are not yet indexed (#1090) Updates the reindex worker to query the search parameters for any supported but not yet indexed parameters.

view details

Brendan Kowitz

commit sha 668011a853b53dbb86a6d6603521f62a8beaf819

Merge remote-tracking branch 'origin/master' into personal/bkowitz/upgrade-cosmos-sdk # Conflicts: # src/Microsoft.Health.CosmosDb/Microsoft.Health.CosmosDb.csproj

view details

push time in 3 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha cb173530c8d63e75664988bcdf585c83a6747b15

Updates package 'Ensure.That' to version '9.2.0' (#1123)

view details

Microsoft Health

commit sha 6549ceb0b64e45f09b30fb055c430c7a521671e1

Updates package 'Polly' to version '7.2.1' (#1127)

view details

Jared Erwin

commit sha 024b1b52f551010da35bb6498046f74241d4322e

Update Reindex job task to query search parameters that are not yet indexed (#1090) Updates the reindex worker to query the search parameters for any supported but not yet indexed parameters.

view details

Brendan Kowitz

commit sha d7341d6eba9984ecfb336f530a9e5e9dabe8ee4a

Merge branch 'master' into auto-nuget-update/system.collections.immutable

view details

push time in 4 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha 6549ceb0b64e45f09b30fb055c430c7a521671e1

Updates package 'Polly' to version '7.2.1' (#1127)

view details

push time in 4 days

delete branch microsoft/fhir-server

delete branch : auto-nuget-update/polly

delete time in 4 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha cb173530c8d63e75664988bcdf585c83a6747b15

Updates package 'Ensure.That' to version '9.2.0' (#1123)

view details

push time in 4 days

delete branch microsoft/fhir-server

delete branch : auto-nuget-update/ensure

delete time in 4 days

Pull request review commentmicrosoft/fhir-server

Prometheus

     <PackageReference Include="Microsoft.Azure.Services.AppAuthentication" Version="1.3.1" />     <PackageReference Include="Microsoft.Extensions.Configuration.AzureKeyVault" Version="3.1.3" />     <PackageReference Include="Microsoft.Extensions.Logging.ApplicationInsights" Version="2.12.0" />+    <PackageReference Include="prometheus-net.AspNetCore" Version="3.6.0" />

Should this be added to https://github.com/microsoft/fhir-server/blob/master/THIRDPARTYNOTICES.md?

hansenms

comment created time in 4 days

issue commentmicrosoft/fhir-server

FHIR Server open-source implementation

I had a fairly minimal example from a DevDays presentation: https://github.com/microsoft/fhir-server/compare/master...brendankowitz:feature/file-storage-provider slides are here: https://github.com/brendankowitz/FHIRDevDays/blob/master/2019/Amsterdam/DD19Adam_HackingFHIRServerForAzure.pdf. Also a sample provider for TableStorage: https://github.com/microsoft/fhir-server/compare/personal/bkowitz/tablestoragetest

only1sham

comment created time in 4 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha 3f7ae9d0e862b77df4aefde55f672315825baf09

Updates package 'Microsoft.Azure.KeyVault' to version '3.0.5' (#1124)

view details

Microsoft Health

commit sha b5b1e6b758c58327b8b29449faff1d3a43d80e65

Updates package 'Microsoft.Azure.Storage.Blob' to version '11.1.7' (#1126)

view details

Brendan Kowitz

commit sha 3facd6d6307c5b237c21117231ee11cd878e8b38

Merge branch 'master' into auto-nuget-update/ensure

view details

push time in 5 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 54ad24085f1838545e9e0488d1d47489e9eee87a

Updates

view details

push time in 5 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha f13e832c89cb81785600addea5e5d74ba5ac6de0

Update THIRDPARTYNOTICES.md

view details

push time in 5 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha e4dc2a1b9532a5f91c891d79f5f401b3ba80669e

Update THIRDPARTYNOTICES.md

view details

push time in 5 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha 3f7ae9d0e862b77df4aefde55f672315825baf09

Updates package 'Microsoft.Azure.KeyVault' to version '3.0.5' (#1124)

view details

Microsoft Health

commit sha b5b1e6b758c58327b8b29449faff1d3a43d80e65

Updates package 'Microsoft.Azure.Storage.Blob' to version '11.1.7' (#1126)

view details

Brendan Kowitz

commit sha 925cf02a454b5a50a9a39d50765f6e0de96dbb3f

Merge branch 'master' into auto-nuget-update/microsoft.azure.services.appauthentication

view details

push time in 5 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha 3f7ae9d0e862b77df4aefde55f672315825baf09

Updates package 'Microsoft.Azure.KeyVault' to version '3.0.5' (#1124)

view details

Microsoft Health

commit sha b5b1e6b758c58327b8b29449faff1d3a43d80e65

Updates package 'Microsoft.Azure.Storage.Blob' to version '11.1.7' (#1126)

view details

Brendan Kowitz

commit sha a83b23ac78fc59c444841161149b401289635a64

Merge branch 'master' into auto-nuget-update/polly

view details

push time in 5 days

pull request commentmicrosoft/fhir-server

Updates package 'AngleSharp' to version '0.14.0'

/azp run

MicrosoftHealthService

comment created time in 5 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha b5b1e6b758c58327b8b29449faff1d3a43d80e65

Updates package 'Microsoft.Azure.Storage.Blob' to version '11.1.7' (#1126)

view details

push time in 5 days

delete branch microsoft/fhir-server

delete branch : auto-nuget-update/microsoft.azure.storage.blob

delete time in 5 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha 3f7ae9d0e862b77df4aefde55f672315825baf09

Updates package 'Microsoft.Azure.KeyVault' to version '3.0.5' (#1124)

view details

push time in 5 days

delete branch microsoft/fhir-server

delete branch : auto-nuget-update/microsoft.azure.keyvault

delete time in 5 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha 047ac9fd820d3b91c67397839d12e5149fdf1d82

Updates current version

view details

push time in 5 days

push eventbrendankowitz/nugetpackageupdate

abhijeett

commit sha 0279e507112e4cfe713b3b2f724c8ed104ca86f1

Updated registration url to registration5-gz-semver2 and added gzip decompression handling. (#10)

view details

push time in 5 days

issue openedbrendankowitz/nugetpackageupdate

Look at api to determine RegistrationsBaseUrl for the public nuget api

Look at https://api.nuget.org/v3-index/index.json to determine "RegistrationsBaseUrl"

created time in 6 days

delete branch brendankowitz/nugetpackageupdate

delete branch : update-nuget-url

delete time in 6 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha 7237ede0d68879508f0bcd22a75fb91b3ca5b44f

Updates nuget api url (#8)

view details

push time in 6 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha a340ba843557e240eb2ae0aaf6ba0d904809da4f

Updates nuget api url

view details

push time in 6 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha efef45f6ca06996f3da656b104b206a2d7e8eeab

Updates nuget api url

view details

push time in 6 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha 9a76b8d0fa2e28d3b95c53bbede8cb7f740d8b5e

Updates nuget api url

view details

push time in 6 days

create barnchbrendankowitz/nugetpackageupdate

branch : update-nuget-url

created branch time in 6 days

Pull request review commentmicrosoft/fhir-server

Update Reindex job task to query search parameters that are not yet indexed

 public async Task ExecuteAsync(ReindexJobRecord reindexJobRecord, WeakETag weakE                 if (_reindexJobRecord.QueryList?.Count == 0)                 {                     // Build query based on new search params+                    // Find supported, but not yet searchable params+                    var notYetIndexedParams = _supportedSearchParameterDefinitionManager.GetSupportedButNotSearchableParams();

I guess this is also the same as _supportedSearchParameterDefinitionManager.AllSearchParameters.Where(p => !p.IsSearchable). All search params returned from _supportedSearchParameterDefinitionManager should be supported

feordin

comment created time in 6 days

Pull request review commentmicrosoft/fhir-server

Add export for Patient compartment data

 protected ExportJobProgress()         [JsonProperty(JobRecordProperties.Page)]         public uint Page { get; private set; } +        [JsonProperty(JobRecordProperties.TriggeringResourceId)]+        public string TriggeringResourceId { get; private set; }++        [JsonProperty(JobRecordProperties.SubSearch)]+        public ExportJobProgress SubSearch { get; private set; }

Would it make sense to call this CompartmentSearch?

LTA-Thinking

comment created time in 6 days

Pull request review commentmicrosoft/fhir-server

Add export for Patient compartment data

 private async Task UpdateJobRecordAsync(CancellationToken cancellationToken)             }         } -        private async Task ProcessSearchResultsAsync(IEnumerable<SearchResultEntry> searchResults, uint partId, CancellationToken cancellationToken)+        private async Task RunExportSearch(+            ExportJobConfiguration exportJobConfiguration,+            ExportJobProgress progress,+            List<Tuple<string, string>> sharedQueryParametersList,+            uint pagesWaitingForCommit,+            string batchIdPrefix,+            CancellationToken cancellationToken,+            bool compartmentSearch = false)+        {

Looks like we should have some ensureArgs in here

LTA-Thinking

comment created time in 6 days

Pull request review commentmicrosoft/fhir-server

Add export for Patient compartment data

 public string GetExportedData(Uri fileUri)              return null;         }++        public int GetExportedDataFileCount()

Looks like it should be a property public int ExportedDataFileCount => ...

LTA-Thinking

comment created time in 6 days

Pull request review commentmicrosoft/fhir-server

Add support for Sub Searches to export

 protected ExportJobProgress()         [JsonProperty(JobRecordProperties.Page)]         public uint Page { get; private set; } +        [JsonProperty(JobRecordProperties.SubSearchResourceId)]+        public string SubSearchResourceId { get; private set; }++        [JsonProperty(JobRecordProperties.SubSearch)]+        public ExportJobProgress SubSearch { get; private set; }

CompartmentSearch maybe?

LTA-Thinking

comment created time in 6 days

issue commentmicrosoft/fhir-server

Issue with fhir-server/samples/templates/default-azuredeploy-docker-sql.json

@LTA-Thinking can you look at this issue?

sethuraj

comment created time in 6 days

startedaleju/imgaug

started time in 9 days

delete branch brendankowitz/nugetpackageupdate

delete branch : adds-workflow

delete time in 10 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha 29fc7d805d6d5158871659465224e13e94393e6a

Create dotnet-core.yml

view details

Brendan Kowitz

commit sha 1d011ffc4c4bea911c32c25f1de9cf97d63d3220

Update dotnet-core.yml

view details

Brendan Kowitz

commit sha 46abb8e77f5638cf2d2ba922a56a8507014132b4

Update dotnet-core.yml

view details

Brendan Kowitz

commit sha d75f14a82af2eff3412f1de942507252a4e8e884

Update dotnet-core.yml

view details

Brendan Kowitz

commit sha 41639051e45e92d7f3d0c3d12c73078a931bea14

Update dotnet-core.yml

view details

Brendan Kowitz

commit sha 01674fc3d3df3bf0c869bb58ffefdfdfb905e583

Update NugetUpdate.csproj

view details

Brendan Kowitz

commit sha 3d4db82b44eb662608609d34ea087bbb4e067109

Merge pull request #7 from brendankowitz/adds-workflow

view details

push time in 10 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha 01674fc3d3df3bf0c869bb58ffefdfdfb905e583

Update NugetUpdate.csproj

view details

push time in 10 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha 41639051e45e92d7f3d0c3d12c73078a931bea14

Update dotnet-core.yml

view details

push time in 10 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha d75f14a82af2eff3412f1de942507252a4e8e884

Update dotnet-core.yml

view details

push time in 10 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha 46abb8e77f5638cf2d2ba922a56a8507014132b4

Update dotnet-core.yml

view details

push time in 10 days

push eventbrendankowitz/nugetpackageupdate

Brendan Kowitz

commit sha 1d011ffc4c4bea911c32c25f1de9cf97d63d3220

Update dotnet-core.yml

view details

push time in 10 days

create barnchbrendankowitz/nugetpackageupdate

branch : adds-workflow

created branch time in 10 days

push eventbrendankowitz/nugetpackageupdate

LTA-Thinking

commit sha cb6925c63e935de85e89f22cdcffd6a042476e12

Find all pages of project files

view details

Brendan Kowitz

commit sha 6bb687cdb8cfcc3347792c6c09b7a46521f13dc6

Merge pull request #6 from LTA-Thinking/master Find all pages of project files

view details

push time in 10 days

PR merged brendankowitz/nugetpackageupdate

Find all pages of project files

Continues searching for project files until it gets an empty page back.

+19 -7

0 comment

1 changed file

LTA-Thinking

pr closed time in 10 days

push eventmicrosoft/fhir-server

Microsoft Health

commit sha 91a3f0722e6126034946fdd3109f7996a0d28078

Auto-update for packages related to 'healthcare-components-1.0.0-master-20200629-1' (#1112) * Auto-update for packages related to 'healthcare-components-1.0.0-master-20200629-1'

view details

Brendan Kowitz

commit sha 3f5df1f7abb0e4fe67730df2784ef5e71b745583

Updates CosmosSDK

view details

Brendan Kowitz

commit sha 26757b272dcd971886eeea236bd02addb80506ff

Merged CosmosDb projects

view details

Brendan Kowitz

commit sha 7e4190ba888ba8784b9bab8e69db34e4754dd6cb

Cleanup

view details

push time in 11 days

push eventmicrosoft/fhir-server

Elad Iwanir

commit sha a3845bbb2d78473709f6183ae65a0d90a3c2cb97

Supporting _list (sql + cosmos) (#1091) Support _list in all databases

view details

Robin Todd

commit sha 9fd45aca1eb1b5cf8fae977f0c3dd6c29b4d213c

Refactors SqlServerFhirModel initialization. (#1072) Adds a start method to the fhir model and removes the initializer.

view details

Robert Johnson

commit sha a39087313c3516453ddfb2e395195d5853ec1bcf

Split tests based on database type (#1098)

view details

Robert Johnson

commit sha 69db8b4a2953b59e2c5a9bea4ae8ed0426ad8097

Add max resources and pages to job record (#1099) * Add max resources and pages to job record

view details

Michael Hansen

commit sha ddc06c0efd388e2a797fe4e2eeee29cdaba6dbfa

Added resource requests AKS deployments (#1109) Co-authored-by: Michael Hansen <Michael.Hansen@microsoft.com>

view details

rbans96

commit sha e6bbc126cf73da9e1b085768137baa5e1a0c1448

Sort by _lastUpdated in Sql server (#1069) * Sort by lastUpdated * Fixes tests * Fix sort tests * Addresses feedback * Refactoring * Addressed feedback * Merge master * Addresses review comments * Adds a blank line * Triggering pipeline * Initial commit

view details

Joe Rowan

commit sha 1d569e4e66e697c408084efdd6a7726bcda95da3

Localization Update: Fix for GeoPol_ManifestFile into master branch (#1087) * Localization Update: Fix for GeoPol_ManifestFile into master branch * ExcludeAllJsonInPath

view details

Brendan Kowitz

commit sha 3f3d24cdb090a04c5934608a862283a2fb9e8039

Updates CosmosSDK

view details

Brendan Kowitz

commit sha 3f16625a603cbf69b1399bda44ef7cc13bb0d7d6

Merged CosmosDb projects

view details

Brendan Kowitz

commit sha b5239702f58a8d35b2941a3661ae6f9fa652a133

Cleanup

view details

push time in 11 days

pull request commentmicrosoft/fhir-server

Fix errors when _summary=count or _total=accurate is specified with an _include parameter

Can you also update my comment here now this is fixed :) https://github.com/microsoft/fhir-server/blob/master/test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/IncludeSearchTests.cs#L125

johnstairs

comment created time in 11 days

issue commentmicrosoft/fhir-server

Error with FHIR hosted on local IIS

Local IIS is not a typical scenario we are running or testing with. When launching from VS there are launch settings that are applied from (https://github.com/microsoft/fhir-server/blob/master/src/Microsoft.Health.Fhir.R4.Web/Properties/launchSettings.json#L25) that override some settings and provide others not defined in appSettings.json, make sure all of these exist in your deployment

only1sham

comment created time in 12 days

issue closedmicrosoft/fhir-server

Error - while running from local machine directly

URL - https://localhost:44348/ It keep on showing loading and after sometime I get an error, can someone please help me.

SocketException: No connection could be made because the target machine actively refused it.

closed time in 12 days

nagendra421

issue commentmicrosoft/fhir-server

Error - while running from local machine directly

I'm closing this for now, I've added some information to the wiki section (https://github.com/microsoft/fhir-server/wiki/Build-and-debug-locally) please see if this resolves the issue.

nagendra421

comment created time in 12 days

GollumEvent

issue commentmicrosoft/fhir-server

Allow throttling based on number of concurrent requests

Closing as this is merged

YazanMSFT

comment created time in 12 days

GollumEvent
GollumEvent
GollumEvent
GollumEvent

Pull request review commentmicrosoft/fhir-server

Upgrade to CosmosDb SDK v3

 public sealed class FhirCollectionSettingsUpdater : IFhirCollectionUpdater             _logger = logger;         } -        public async Task ExecuteAsync(IDocumentClient client, DocumentCollection collection, Uri relativeCollectionUri)+        public async Task ExecuteAsync(Container client)         {             EnsureArg.IsNotNull(client, nameof(client));-            EnsureArg.IsNotNull(collection, nameof(collection)); -            var thisVersion = await GetLatestCollectionVersion(client, collection);+            var thisVersion = await GetLatestCollectionVersion(client);              if (thisVersion.Version < CollectionSettingsVersion)             {-                _logger.LogDebug("Ensuring indexes are up-to-date {CollectionUri}", _configuration.GetAbsoluteCollectionUri(_collectionConfiguration.CollectionId));+                _logger.LogDebug("Ensuring indexes are up-to-date {CollectionUri}"); -                collection.IndexingPolicy = new IndexingPolicy+                var container = await client.ReadContainerAsync();++                // For more information on setting indexing policies refer to:+                // https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-manage-indexing-policy+                // It is no longer necessary to explicitly set the kind (range/hash)+                container.Resource.IndexingPolicy.IncludedPaths.Clear();+                container.Resource.IndexingPolicy.IncludedPaths.Add(new IncludedPath+                {+                    Path = "/*",+                });++                container.Resource.IndexingPolicy.ExcludedPaths.Clear();+                container.Resource.IndexingPolicy.ExcludedPaths.Add(new ExcludedPath                 {-                    IncludedPaths = new Collection<IncludedPath>-                    {-                        new IncludedPath-                        {-                            Path = "/*",-                            Indexes = new Collection<Index>-                            {-                                new RangeIndex(DataType.Number, -1),-                                new RangeIndex(DataType.String, -1),-                            },-                        },-                    },-                    ExcludedPaths = new Collection<ExcludedPath>-                    {-                        new ExcludedPath-                        {-                            Path = $"/{KnownResourceWrapperProperties.RawResource}/*",-                        },-                    },-                };+                    Path = $"/{KnownResourceWrapperProperties.RawResource}/*",

Possibly also add the default "path": "/\"_etag\"/?" here too

brendankowitz

comment created time in 12 days

Pull request review commentmicrosoft/fhir-server

Fix continuation token issues with chained searches

 internal class TableExpression : Expression             Expression normalizedPredicate,             Expression denormalizedPredicate,             TableExpressionKind kind,-            int chainLevel = 0)+            int chainLevel = 0,+            Expression denormalizedPredicateOnChainRoot = null)

It might be helpful to add some parameter documentation to some of these common types, this constructor has 3 expression parameters now :)

johnstairs

comment created time in 12 days

pull request commentmicrosoft/fhir-server

Upgrade to CosmosDb SDK v3

/azp run

brendankowitz

comment created time in 13 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha ce5b1a6881d45c09b497e92d5287bdf41906703d

Cleanup

view details

push time in 13 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 17197ea952d82c94f8047bf51431ab12365f1379

Cleanup

view details

push time in 13 days

push eventmicrosoft/fhir-server

Brendan Kowitz

commit sha 4e900d1e385fc5007138fd77ba19be8ed9b15d7f

Cleanup

view details

push time in 16 days

more