profile
viewpoint

zalmoxisus/crossmessaging 6

Crossextension messaging.

bmenant/wordpress-domain-name-autoswitch 1

A WordPress plugin which add a domain name field to posts’ form, so each post can have its own domain name and can be displayed as a front page.

bmenant/5stardata.info 0

Information around TimBL's 5 star Open Data plan

bmenant/addon-simple-storage-editor 0

Firefox Add-on SDK simple storage viewer and editor

bmenant/analytics 0

Simple, open-source, lightweight (< 1 KB) and privacy-friendly web analytics alternative to Google Analytics.

bmenant/atom-smart-tab-name 0

Provide smarter tab names form Atom editor.

bmenant/cpeam-webdoc 0

Bx3 - CPEAM - Webdoc

bmenant/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

bmenant/faker 0

Generate massive amounts of fake data in the browser and node.js

PR opened faker-js/faker

fix(finance): update iso-3166-1 country codes for IBAN/BIC

I had posted the issue #1261 on the original repository, followed by a pull request (from this branch).

To put it short: this simply update the list of ISO-3166-1 country codes [1] used for IBAN & BIC generations. As a matter of fact, some codes were nonexistent in the official specifications. Those have caused Faker.js to generate invalid IBAN and BIC codes (notably when checked against validator.js, for example).

FYI, as of today, I’m unable to run tests: Error: Cannot find module './lib'

[1] Both BIC (ISO-9362) and IBAN (ISO-13616) explicitly refers to ISO-3166-1.


It has also been suggested (here: #131) to use fake-numbers for IBAN generation. AFAIK, it uses a restricted list of country codes for IBAN generation (which I believe to be just fine). However, for BIC generation, fake-numbers uses a random string of 2 letters as a country code (which are unlikely to ever produce a valid BIC code IMHO).

+3 -19

0 comment

2 changed files

pr created time in 2 days

create barnchbmenant/faker

branch : fix/issue-1261-iban-bic-eu-country-code

created branch time in 2 days

fork bmenant/faker

Generate massive amounts of fake data in the browser and node.js

https://fakerjs.dev

fork in 2 days

create barnchbmenant/woocommerce-local-pickup-time

branch : language/fr

created branch time in a month

fork bmenant/woocommerce-local-pickup-time

Adds an option to the WooCommerce checkout pages for Local Pickup that allows the user to choose a pickup time.

https://wordpress.org/plugins/woocommerce-local-pickup-time-select/

fork in a month

issue commentMarak/faker.js

Tests failing from fresh fork?

Happened to me as well while making https://github.com/Marak/faker.js/pull/1262

marvinIsSacul

comment created time in a month

push eventbmenant/faker.js

Benjamin Menant

commit sha dc4815f34adb5e8df6d6b2006ee91655e2b520d1

fix(finance): update iso-3166-1 country codes for IBAN/BIC

view details

push time in a month

pull request commentDefinitelyTyped/DefinitelyTyped

[ioredis] add lmove and blmove commands

Ready to merge

bmenant

comment created time in a month

PR closed bmenant/DefinitelyTyped

[ioredis] add lmove and blmove commands

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • [ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [ ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [ ] tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • [ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/luin/ioredis/issues/1265
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.
+11 -0

0 comment

2 changed files

bmenant

pr closed time in a month

PR opened DefinitelyTyped/DefinitelyTyped

[ioredis] add lmove and blmove commands

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • [ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [ ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [ ] tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • [ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/luin/ioredis/issues/1265
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.
+11 -0

0 comment

2 changed files

pr created time in a month

push eventbmenant/faker.js

Benjamin Menant

commit sha 5f5cdf79fde205abd95feff8650826fc691c1128

fix(finance): remove EU from iso-3166-1 country codes for IBAN/BIC fixes #1261

view details

push time in a month

create barnchbmenant/faker.js

branch : fix/issue-1261-iban-bic-eu-country-code

created branch time in a month

fork bmenant/faker.js

generate massive amounts of realistic fake data in Node.js and the browser

fork in a month

issue openedMarak/faker.js

faker.finance.bic() sometimes returns invalid BIC codes

I’ve got a test suit to check some data validation specifications. Validator.js is used for some of those and in particular for BIC codes. From time to time, the test suit fails on BIC code validation.

Recently, I checked one of the Faker.js’s BIC code against another online validator, and it turned out the code was invalid indeed.

Here is an invalid BIC code from Faker.js@5.5.3:

QEWIEUB1
    ^^

As a matter of fact, EU is not a valid country code (since the European Union is not a country). It is not included in ISO 3166-1, as defined in ISO 9362 (Business Identifier Codes). Change EU for BE or FR and the code becomes valid (e.g. QEWIBEB1).

https://github.com/Marak/faker.js/blob/29234378807c4141588861f69421bf20b5ac635e/lib/finance.js#L326

I suppose ibanLib.iso3166 should not include EU. IBAN (ISO 13616) is defined with ISO 3166-1 as well.

https://github.com/Marak/faker.js/blob/29234378807c4141588861f69421bf20b5ac635e/lib/iban.js#L1128

Am I correct?

created time in a month

PR opened bmenant/DefinitelyTyped

[ioredis] add lmove and blmove commands

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • [ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [ ] If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [ ] tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • [ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/luin/ioredis/issues/1265
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.
+11 -0

0 comment

2 changed files

pr created time in a month

create barnchbmenant/DefinitelyTyped

branch : ioredis/feat/lmove

created branch time in a month

fork bmenant/DefinitelyTyped

The repository for high quality TypeScript type definitions.

fork in a month

pull request commentdis-moi/extension

fix: revert "fix: yarn lock"

:tada: This PR is included in version 3.88.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

lutangar

comment created time in 3 months

created tagdis-moi/extension

tagv3.88.2

:speech_balloon: Never browse alone again

created time in 3 months

push eventdis-moi/extension

Semaphore CI

commit sha 1b98496c1b71d23135c69cac7b7bd99ab4deb125

chore: release 3.88.2 ## [3.88.2](https://github.com/dis-moi/extension/compare/v3.88.1...v3.88.2) (2021-11-01) ### Bug Fixes * revert "fix: yarn lock" ([e73d491](https://github.com/dis-moi/extension/commit/e73d491c22a27af5b4fad8b4da99c5bca804c70f))

view details

push time in 3 months

issue commentdis-moi/extension

Make long local profile names readable on the page listing profiles - Le Même en Nord-Pas-de-Calais etc.

:tada: This issue has been resolved in version 3.88.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

MaartenLMEM

comment created time in 3 months

issue commentdis-moi/extension

Introduce ENV variables to distinguish between DisMoi build and LMEL DisMoi

:tada: This issue has been resolved in version 3.88.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

JalilArfaoui

comment created time in 3 months

pull request commentdis-moi/extension

fix(profilesList): changes list item width

:tada: This PR is included in version 3.88.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

newick

comment created time in 3 months

pull request commentdis-moi/extension

chore: add FACET ENV variable along with NODE_ENV and PLATFORM

:tada: This PR is included in version 3.88.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

JalilArfaoui

comment created time in 3 months

created tagdis-moi/extension

tagv3.88.1

:speech_balloon: Never browse alone again

created time in 3 months

push eventdis-moi/extension

Benjamin Menant

commit sha 76b1006d26a8e6f2c042662114e267c7529ec903

chore: release 3.88.1 ## [3.88.1](https://github.com/dis-moi/extension/compare/v3.88.0...v3.88.1) (2021-10-31) ### Bug Fixes * **profilesList:** changes list item width ([55c426e](https://github.com/dis-moi/extension/commit/55c426e373e32ce4317ed3a49e40c35e31e70383))

view details

push time in 3 months

more