profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/bmarty/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

matrix-org/matrix-android-sdk2 82

Matrix SDK for Android, extracted from the Element Android application

bmarty/JavadocBlockGenerator 1

Automatically add javadoc blocks to the java source files

matrix-org/matrix-dev-tools 1

This project will host scripts used by other matrix projects

bmarty/BigImageViewer 0

Big image viewer supporting pan and zoom, with very little memory usage and full featured image loading choices. Powered by Subsampling Scale Image View, Fresco, Glide, and Picasso. Even with gif and webp support! 🍻

bmarty/JsonViewer 0

An android JsonViewer to display formatted json with fold/unfold options

bmarty/kotlin 0

The Kotlin Programming Language

bmarty/material-dialogs 0

A beautiful, easy-to-use, and customizable dialogs API.

poljar/element-android 0

A glossy Matrix collaboration client for Android.

PullRequestReviewEvent

push eventvector-im/element-android

Valere

commit sha b1c95e32eb58b1fc5fd8230390e6933fa9849454

Better room preview, use room Summary API if available

view details

ganfra

commit sha 2144bb9d496636b864737fe2ff0a774d79467014

Timeline: remove reaction animation views for now

view details

ganfra

commit sha f96485c4934074531ffd2120c63517ea32740aa2

Timeline: use json directly to be a bit more speedy (those methods are called a lot)

view details

ganfra

commit sha 27d4f6057882d4ae7d55d10e9b964b7e52b35e0a

Jitsi: introduces ConferenceEvent to avoid using directly Jitsi sdk from fragments/activities

view details

Valere

commit sha f2b7ee3e060b2fa8c632cf9b787bcc7a6ff0025c

Code review

view details

ganfra

commit sha 0460a48c0c8046a826bcf40298b5e2e482ac43c5

Fix DTMF not working #4015

view details

ariskotsomitopoulos

commit sha c89b2c05367cca644d7dcf4c0d05bbc6dbc32be7

Optimize dependencies handling

view details

Benoit Marty

commit sha c1b14bd80032000e619aab2d8eb7f4d8c3d8b4e6

Merge pull request #4016 from vector-im/feature/fga/fix_dtmf Fix DTMF not working #4015

view details

Benoit Marty

commit sha d6b261ce4c91848fd5be5325768699c082fd31cc

Merge pull request #3986 from vector-im/feature/bca/room_summary_api Better room preview, use room Summary API if available

view details

Valere

commit sha 2c1435f08cb2eedad8647298f1b0b69ad6f6fa8c

Change default power to invite in private space + setting

view details

Valere

commit sha 70ebb3a3f2abac23dc2de73ffac8bb7a1d60303d

Code review

view details

Valere

commit sha bb459a6e5ecbe33b58a90d1aec37cf8d66e709ec

Merge pull request #4001 from vector-im/feature/bca/spaces_fix_invite_private Change default power to invite in private space + setting

view details

ariskotsomitopoulos

commit sha 87fefdc7bb3a3df533d1d91470b49ff2b4b9cb2b

Add more dependencies to common dependencies.gradle

view details

Valere

commit sha 8fd784e27592811558256c8a234361fa18a9fc6b

Improve leave space (all + none)

view details

Valere

commit sha 9a9a3d8cc6764372ec36b6ee041116393f0844b3

Cherry pick room on leave space

view details

Valere

commit sha 31c0831aba3ae5a300499f1bc89a0ef26143775c

Update change log

view details

Valere

commit sha cfed0f839b1f25015c98b9e7d87eab93688b6740

Code review

view details

Valere

commit sha 94f88c80fc77853774ae56bd4e990296e4d6b575

Fix parent relation handling

view details

Valere

commit sha e5de62b57c8c5b9f790bc3a37f5dc1b37faaa21a

Code review

view details

Valere

commit sha 22319a0f0a56676ba870b41009fa02c8fc9469b9

Cleaning, line too long

view details

push time in a day

Pull request review commentvector-im/element-android

feature/aris/issue_dinsic_618

          <service             android:name=".features.call.telecom.VectorConnectionService"-            android:permission="android.permission.BIND_TELECOM_CONNECTION_SERVICE">+            android:permission="android.permission.BIND_TELECOM_CONNECTION_SERVICE"+            android:exported="true">

ok, thanks!

ariskotsomitopoulos

comment created time in a day

PullRequestReviewEvent

Pull request review commentvector-im/element-android

feature/aris/issue_dinsic_618

         A media button receiver receives and helps translate hardware media playback buttons,         such as those found on wired and wireless headsets, into the appropriate callbacks in your app.            -->-        <receiver android:name="androidx.media.session.MediaButtonReceiver">+        <receiver+            android:name="androidx.media.session.MediaButtonReceiver"+            android:exported="true" >

thanks!

ariskotsomitopoulos

comment created time in a day

PullRequestReviewEvent

Pull request review commentvector-im/element-android

Fix switch to best space when tapping notification

 class RoomDetailViewModel @AssistedInject constructor(         if (OutboundSessionKeySharingStrategy.WhenEnteringRoom == BuildConfig.outboundSessionKeySharingStrategy && room.isEncrypted()) {             prepareForEncryption()         }++        if (initialState.switchToParentSpace) {+            // We are coming from a notification, try to switch to the most relevant space+            // so that when hitting back the room will appear in the list+            appStateHandler.getCurrentRoomGroupingMethod()?.space().let { currentSpace ->+                val currentRoomSummary = room.roomSummary() ?: return@let+                // nothing we are good+                if (currentSpace == null || !currentRoomSummary.flattenParentIds.contains(currentSpace.roomId)) {

if currentSpace is null, there is nothing to do, no?

BillCarsonFr

comment created time in a day

Pull request review commentvector-im/element-android

Fix switch to best space when tapping notification

 class RoomDetailViewModel @AssistedInject constructor(         if (OutboundSessionKeySharingStrategy.WhenEnteringRoom == BuildConfig.outboundSessionKeySharingStrategy && room.isEncrypted()) {             prepareForEncryption()         }++        if (initialState.switchToParentSpace) {+            // We are coming from a notification, try to switch to the most relevant space+            // so that when hitting back the room will appear in the list+            appStateHandler.getCurrentRoomGroupingMethod()?.space().let { currentSpace ->+                val currentRoomSummary = room.roomSummary() ?: return@let+                // nothing we are good+                if (currentSpace == null || !currentRoomSummary.flattenParentIds.contains(currentSpace.roomId)) {+                    // take first one or switch to home+                    appStateHandler.setCurrentSpace(+                            currentRoomSummary+                                    .flattenParentIds.firstOrNull { it.isNotBlank() },

Also why taking the first space here?

BillCarsonFr

comment created time in a day

Pull request review commentvector-im/element-android

Fix switch to best space when tapping notification

 class RoomDetailViewModel @AssistedInject constructor(         if (OutboundSessionKeySharingStrategy.WhenEnteringRoom == BuildConfig.outboundSessionKeySharingStrategy && room.isEncrypted()) {             prepareForEncryption()         }++        if (initialState.switchToParentSpace) {+            // We are coming from a notification, try to switch to the most relevant space+            // so that when hitting back the room will appear in the list+            appStateHandler.getCurrentRoomGroupingMethod()?.space().let { currentSpace ->+                val currentRoomSummary = room.roomSummary() ?: return@let+                // nothing we are good+                if (currentSpace == null || !currentRoomSummary.flattenParentIds.contains(currentSpace.roomId)) {+                    // take first one or switch to home+                    appStateHandler.setCurrentSpace(+                            currentRoomSummary+                                    .flattenParentIds.firstOrNull { it.isNotBlank() },+                            // force persist, because if not on resume the AppStateHandler will resume+                            // the current space from what was persisted on enter background+                            persistNow = true)

It looks like a weird workaround. Do we want to update the notifications to group them by space instead, and/or include a spaceId in the notification intent itself?

BillCarsonFr

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

push eventvector-im/element-android

Valere

commit sha 8036f50a6e906506d0105a386ac8c495eee98cb0

Show mxto bottom sheet when tapping invite notification

view details

Benoit Marty

commit sha 6bf8202e656a4fb21abc7ab05514cbe439cf1be5

Merge pull request #4044 from vector-im/feature/bca/fix_show_invitebottomsheet_on_notif_intent Show mxto bottom sheet when tapping invite notification

view details

push time in a day

issue closedvector-im/element-android

Spaces invitation system notifications don't take me to the join space toast

Steps to reproduce

  1. Be logged into your account on your Android phone
  2. Receive system notification (e.g. from email invite to your registered address) -> See the notification pop-up
  3. Click the notification -> App opens on previous view, not showing notification

What happened?

What did you expect?

Join space toast

What happened?

Previous view of the app

https://photos.app.goo.gl/KNbAKmPJZiCAvrhKA

Your phone model

No response

Operating system version

No response

Application version and app store

Spaces release test version

Homeserver

No response

Have you submitted a rageshake?

No

closed time in a day

kittykat

delete branch vector-im/element-android

delete branch : feature/bca/fix_show_invitebottomsheet_on_notif_intent

delete time in a day

PR merged vector-im/element-android

Show mxto bottom sheet when tapping invite notification A-Spaces NextRelease

Fixes #4043

Tapping on a space invite notification, was only opening the app in the home screen. Was acceptable for rooms as the invite would show up on top of the roomlist.

But now with spaces we need to do more (the space invite will only appear in the left drawer). So with this PR, on notification tap a bottomsheet will appear with preview and join button: image

Will work also for rooms

+25 -5

1 comment

3 changed files

BillCarsonFr

pr closed time in a day

PullRequestReviewEvent

push eventvector-im/element-android

Benoit Marty

commit sha ef5848af1082652aaee04494cb0f75c1bd5fcae0

add missing import after rebase

view details

push time in a day

pull request commentvector-im/element-android

Incr sync investigation

image

???

bmarty

comment created time in a day

push eventvector-im/element-android

Benoit Marty

commit sha 66c7728331c7fc56eda4294bbab031809b0aeaf9

Rename some classes after new feature implemented

view details

Benoit Marty

commit sha 22d20c9d6b513f487d3769c560f4cefec7708be1

changelog

view details

push time in a day

PR opened vector-im/element-android

Reviewers
Incr sync investigation

This PR add debug info on room list and on room detail screen, if and only if developer mode and new option "show de bug info on screen" is on:

image

Displayed info are:

  • state of the sync thread
  • state of the sync request
  • number of PUSH received

Also this PR improves the log related to those parts of the code, so rageshakes will be more valuable

I used JetPack DataStore to store the number of received Push.

+344 -78

0 comment

24 changed files

pr created time in a day

issue commentvector-im/element-android

Add option to change email notification settings

Ok, let's implement this:

  • [ ] Add a setting to enable/disable email notification for emails associated to the account
  • [ ] Under settings/Notifications add a new section below the section "Notifications", named "Email notification".
  • [ ] If there is no email, a list item show "To receive email with notification, please associate an email to your Matrix account". Clicking on this item oopen the screen Settings/General/Emails and Phone numbers.
  • [ ] If there are emails, for each email, a list item with a checkbox, same wording than Element Web, showing the state of the pusher related to the email.
  • [ ] In the debug screen Settings/Advanced settings/Notification target, add a way to delete a pusher manually. Sometimes, ghost pushers stay here, maybe due to an (old) bug on Synapse, which did not delete pusher when user sign out
samuel-p

comment created time in a day

push eventvector-im/element-android

ganfra

commit sha 27d4f6057882d4ae7d55d10e9b964b7e52b35e0a

Jitsi: introduces ConferenceEvent to avoid using directly Jitsi sdk from fragments/activities

view details

ganfra

commit sha 8e9cd52cf0d0a606b521c8010ea9458dcfebc299

Add changelog file

view details

Benoit Marty

commit sha f418683da5261242f70a322d0efe8ce57831f8ee

Merge pull request #4014 from vector-im/feature/fga/hide_jitsi_event Jitsi: introduces ConferenceEvent

view details

push time in 4 days

delete branch vector-im/element-android

delete branch : feature/fga/hide_jitsi_event

delete time in 4 days

PR merged vector-im/element-android

Jitsi: introduces ConferenceEvent

This is just a small wrapper around Jitsi BroadcastEvent to avoid using this directly Fragment/Activity so we can get rid of Jitsi dependencies more easily.

+59 -45

2 comments

7 changed files

ganfra

pr closed time in 4 days

push eventvector-im/element-android

ganfra

commit sha 2144bb9d496636b864737fe2ff0a774d79467014

Timeline: remove reaction animation views for now

view details

ganfra

commit sha f96485c4934074531ffd2120c63517ea32740aa2

Timeline: use json directly to be a bit more speedy (those methods are called a lot)

view details

Benoit Marty

commit sha b5f73515643719c8d4ed7c4521ad102595506ced

Merge pull request #4008 from vector-im/feature/fga/small_timeline_optimisation Feature/fga/small timeline optimisation

view details

push time in 4 days

delete branch vector-im/element-android

delete branch : feature/fga/small_timeline_optimisation

delete time in 4 days

PR merged vector-im/element-android

Feature/fga/small timeline optimisation

This PR simplifies layout on ReactionButton as animation was broken anyway. Also uses JsonDict directly instead of Moshi on some methods used a lot for building timeline event in epoxy. (we might want to do that for other things later when it makes sense).

+34 -253

0 comment

16 changed files

ganfra

pr closed time in 4 days

push eventvector-im/element-android

ariskotsomitopoulos

commit sha c89b2c05367cca644d7dcf4c0d05bbc6dbc32be7

Optimize dependencies handling

view details

Valere

commit sha 2c1435f08cb2eedad8647298f1b0b69ad6f6fa8c

Change default power to invite in private space + setting

view details

Valere

commit sha 70ebb3a3f2abac23dc2de73ffac8bb7a1d60303d

Code review

view details

Valere

commit sha bb459a6e5ecbe33b58a90d1aec37cf8d66e709ec

Merge pull request #4001 from vector-im/feature/bca/spaces_fix_invite_private Change default power to invite in private space + setting

view details

ariskotsomitopoulos

commit sha 87fefdc7bb3a3df533d1d91470b49ff2b4b9cb2b

Add more dependencies to common dependencies.gradle

view details

Valere

commit sha 8fd784e27592811558256c8a234361fa18a9fc6b

Improve leave space (all + none)

view details

Valere

commit sha 9a9a3d8cc6764372ec36b6ee041116393f0844b3

Cherry pick room on leave space

view details

Valere

commit sha 31c0831aba3ae5a300499f1bc89a0ef26143775c

Update change log

view details

Valere

commit sha cfed0f839b1f25015c98b9e7d87eab93688b6740

Code review

view details

Valere

commit sha 94f88c80fc77853774ae56bd4e990296e4d6b575

Fix parent relation handling

view details

Valere

commit sha e5de62b57c8c5b9f790bc3a37f5dc1b37faaa21a

Code review

view details

Valere

commit sha 22319a0f0a56676ba870b41009fa02c8fc9469b9

Cleaning, line too long

view details

Valere

commit sha 421c2ae0ba894857f0e46907dd51d8464ac6dc5d

Fix missing string resource

view details

Valere

commit sha 8b980e522729839287d343b9e7a722855f6588b6

Merge pull request #3759 from vector-im/feature/bca/improve_leave_space Feature/bca/improve leave space

view details

Valere

commit sha 100ac49cac37b2fb3839f6f9a7e41a8cc5c22b30

Merge pull request #4000 from vector-im/feature/bca/fix_space_parent Fix parent relation handling

view details

Valere

commit sha 932a43ef58a1b437f99f36b88190e757038c283e

Add subspace action

view details

Valere

commit sha f79681b343790bcc415b1e8252ea0433e814c41f

Clean unneeded beta pills

view details

Valere

commit sha 84ef0792065375597c0289ce7f77b1a33cb27acb

Add change log

view details

Valere

commit sha 6d023188da475565f1dd2312364522381ff531a1

code review

view details

ariskotsomitopoulos

commit sha 1dcf6b95392937a4a8b1ea50d11749f790abf3bf

Enhance dependencies handling to support Dependabot

view details

push time in 4 days