profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/bluwy/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Bjorn Lu bluwy @opslock Malaysia https://bjornlu.com Web dev & tooling goes a long way

bluwy/LuaTween-for-Rainmeter 13

Animate stuff in Rainmeter easily

bluwy/pick-palette 12

A color palette manager made with Svelte

bluwy/release-for-reddit-action 11

🚀️ Submit a Reddit post about your release in GitHub Actions

bluwy/substitute-string-action 8

🚀️ Easily substitute or replace strings in GitHub Actions using YAML

bluwy/colorblind 5

A zero-dependencies color blindness simulation library

bluwy/material-shadow-preview 3

Visualize Material Design's elevations and generate CSS!

bluwy/svelte-preprocess-import-assets 3

Import assets directly in your markup

bluwy/penn-todo 1

A todo app built on the PENN stack

issue commentsveltejs/svelte

Any string variable containing </script> breaks the parser

Duplicate of #3039 and more https://github.com/sveltejs/svelte/issues/6656#issuecomment-899172539

TheCoinPerspective

comment created time in 6 hours

Pull request review commentsveltejs/kit

[breaking] rename context param of load to stuff

 export function normalize(loaded) { 		} 	} +	if (dev && /** @type {any} */ (loaded).context) {

Would context still work in prod? If not I think we should make a hard error here.

But regarding the error, I believe it's because import.meta.env is non-standard in nodejs so it would resolve to undefined, hence the error. A workaround is to shim it with import.meta.env = { /* ... */ } at the top of this file, though we need to make sure we do that for tests only. Using process.env.NODE_ENV may be fine for this as well.

dummdidumm

comment created time in 9 hours

PullRequestReviewEvent

issue commentsveltejs/kit

`svelte-kit package` errors due to not removing `lang="ts"`

I tend to add a quick fix for this into SvelteKit until we have a way forward. I'm not sure if Svelte core should be responsible of this, or if it should be the preprocessors. If the preprocessor rework RFC is implemented in some form, it means that every preprocessor has the whole source content at its hand and then should be responsible (IMO) for removing the lang tag.

A quick fix would be nice in the meantime since the svelte fix (https://github.com/sveltejs/svelte/pull/6611) doesn't seem it would be merged soon. Though maybe we can extract the attributes feature out and leave the custom parser aside?

I do think Svelte core should be responsible for it though since any script/style preprocessor outside of svelte-preprocess would need a common way of removing attributes, and also to prevent the need to manually sequence the preprocessors. The RFC would definitely be a welcome change once the API has been agreed upon.

https://github.com/sveltejs/svelte-preprocess/blob/main/docs/preprocessing.md#replace

Interesting, we could use that for svelte-kit package perhaps.

probablykasper

comment created time in 10 hours

issue commentsveltejs/kit

`svelte-kit package` errors due to not removing `lang="ts"`

Even though this is actually a real issue, I don't think the fix should be in SvelteKit nor svelte-preprocess. There are 3rd party preprocessor that needs a simple way to remove the lang as well, so it should be supported by Svelte instead, which is tracked here: https://github.com/sveltejs/svelte/issues/5900

probablykasper

comment created time in 16 hours

push eventsveltejs/vite-plugin-svelte

Dominik G

commit sha abc02338b682de8950d14be095ec4e0b56021ca3

chore: update dependencies; refactor 1 testcase to be resilient against order changes in an array (#165)

view details

Bjorn Lu

commit sha adccb238e37a5a041d3cb38541faa926e9a58781

fix: add svelte lib without components to noExternal (#166) * chore: add test * fix: add svelte lib without components to noExternal * chore: update test * chore: add changeset * perf(dependencies): better svelte lib check

view details

github-actions[bot]

commit sha 7ed8e0e051caee57faf13d625982e8425e97b38a

Version Packages (next) (#167) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

Bjorn Lu

commit sha 4f49edb94dec63b4bcbf92eab3082a04b763e865

fix(ssr): simplify noExternal in dev (#169) * fix(ssr): simplify noExternal in dev * chore: add changeset * refactor(options): cleanup svelte deps flow

view details

github-actions[bot]

commit sha 786c180f851b12042f53daef3c2bb2de4c744ad3

Version Packages (next) (#170) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

bluwy

commit sha c083e3ca99dbfa87ea58bf948eb115f72d73b19c

docs: update include and exclude info

view details

bluwy

commit sha 6d33a682f25b23637cde9091d7cd20ea1cf698b9

feat: improve useVitePreprocess

view details

bluwy

commit sha 137469ae6fd4aa6fc998644d622222e70051909a

refactor(preprocessor): remove unneeded checks

view details

bluwy

commit sha 9750519ec6b583d739b036878674e8638f29b904

refactor(preprocessor): clean code

view details

bluwy

commit sha 4d341492bd801940c0687645e986d3d83e55a092

fix: typo

view details

bluwy

commit sha b8f0cb6b38ae82137eaab361499b60e5a5865cd0

refactor: use esbuild types

view details

bluwy

commit sha ec3ba3b4ba1542c4e9cfe67379a149cc26088c8a

refactor: again

view details

push time in 16 hours

issue commentsveltejs/kit

Environment variables in Svelte templates don't work with `npm run build`

I've sent a PR in Svelte implementing solution no1: https://github.com/sveltejs/svelte/pull/6744

timdeschryver

comment created time in 16 hours

push eventbluwy/kit

Bjorn Lu

commit sha 84b4c75a0447cd4df0850e6a737535d81cbc85ed

chore: update vite-plugin-svelte (#2423)

view details

Ben McCann

commit sha 1c9b43e189402ae8b2389dd7f7eecbd0c7fb7792

revert change to versioning during release workflow

view details

github-actions[bot]

commit sha 34aeed6e6322f0e29e3a06a296882cba1c97f4d5

Version Packages (next) (#2420) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

Ben McCann

commit sha 3ce209faaf6afa14601ccbc97aadef04072356de

[fix] encodeURI during prerender (#2427)

view details

Geoff Rich

commit sha 1b799ab5722986f8cd665a53ffdd7e3bc4dc87d6

docs: use fragment for prefetching link (#2429)

view details

frederikhors

commit sha b02ea03dbb01d8e891de51354f3782fb42f0d3e3

[chore] add links to repository and homepage to package.json (#2425)

view details

Simon H

commit sha d8efaa2faa9c7a93c9b7e7cf234bc485de330d28

[fix] update to TS 4.4.3 (#2432)

view details

Ben McCann

commit sha 0ea411ca6e8a72d24aea49883c854fa22812b6e8

[chore] update lockfile

view details

github-actions[bot]

commit sha 4f748a9580b49290725a92e3ca60cfb0be5db080

Version Packages (next) (#2428) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

Simon H

commit sha 306742213686df929fbf051f547b34e40dcace60

[fix] add svelte field when packaging (#2431) Several heuristics in Kit/vite-plugin-svelte to tell Vite to mark Svelte packages rely on the "svelte" property. Vite/Rollup/Webpack plugin can all deal with it. Fixes #1959 Co-authored-by: Bjorn Lu <34116392+bluwy@users.noreply.github.com>

view details

The Cashew Trader

commit sha 056b56024d4c39af2da71dd50560de66422055de

[docs] fix typo (#2443)

view details

Даниил Пронин

commit sha 7c1c9bdc148bb4b4648a2476bcac1eb8bdb68ef6

[fix] provide valid value for `letter-spacing` CSS property in template (#2437)

view details

Ben McCann

commit sha b0ddbb3eead4e60fb9146c3294fef55de91e5b0e

[feat] use the Vite server options in dev mode (#2232)

view details

Ben McCann

commit sha c32218b7dd41e41d695c0eb1bda1a2542e7d763b

Fix invalid changeset. Thanks GitHub bot :-p

view details

Ben McCann

commit sha 9ab737b63b0d9b2f40f3389719fd3c980beaf449

[docs] add link to envPrefix option in env var FAQ (#2445)

view details

Dominik G

commit sha 10fedb4a444ee2ec0d5f943a63ee270d8e4138b3

chore: update dependencies (#2447)

view details

Ben McCann

commit sha 96312000e18617778a98c0671501b734b84825eb

[fix] revert #2354 and fix double character decoding a different way (#2435)

view details

github-actions[bot]

commit sha 197b09d254bd950cc513e50dcfd61be4a6e00741

Version Packages (next) (#2438) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

view details

push time in 19 hours

push eventbluwy/svelte

bluwy

commit sha 208a05f4343357950a80e6d9b3c4e3cc1909c28c

flip

view details

push time in a day

push eventbluwy/svelte

bluwy

commit sha e1ffe35b3b35d586325155b76a6911bba68d4d09

remove default wrapper

view details

push time in a day

push eventbluwy/svelte

bluwy

commit sha 8ca90e88dd5ee3c0f709a4bfc2daa23b583d04a6

use default instead of node

view details

push time in a day

PR opened sveltejs/svelte

[fix] ssr remove css map

Fixes https://github.com/sveltejs/kit/issues/720.

The inline sourcemap's sourcesContent was interfering with Vite's production replacement, since they are applied near the end of the build process (after svelte has been compiled). So we remove the sourcemap instead since it wasn't actually being used.

See https://github.com/sveltejs/kit/issues/720#issuecomment-922336782 for more info.

Before submitting the PR, please make sure you do the following

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] Prefix your PR title with [feat], [fix], [chore], or [docs].
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with npm test and lint the project with npm run lint
+5 -3

0 comment

2 changed files

pr created time in a day

create barnchbluwy/svelte

branch : ssr-remove-css-map

created branch time in a day

PR opened sveltejs/svelte

[feat] export svelte/ssr in node

Credit to @benmccann for the idea. This prevents the need for bundlers to bundle external dependencies that imports svelte in order to resolve them to svelte/ssr.

Before submitting the PR, please make sure you do the following

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] Prefix your PR title with [feat], [fix], [chore], or [docs].
  • [ ] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with npm test and lint the project with npm run lint
+8 -2

0 comment

1 changed file

pr created time in a day

create barnchbluwy/svelte

branch : svelte-ssr-export-map

created branch time in a day

push eventbluwy/svelte

Simon H

commit sha 98aefd3cf6023e087a446a0402f4887ed753f305

[fix] make Source type in preprocess private (#6726) Is only used internally, shouldn't be exposed. Fixes #6622

view details

Simon H

commit sha 88204355d34a1496f1bb7aa7a345038d5fbd5a56

[docs] clarify readable callback timing (#6725) #6724

view details

Bjorn Lu

commit sha 79df74b087fac62031a99898555282a4a664311c

[fix] run else-if reactive function on re-renders (#6727)

view details

Conduitry

commit sha 33c0c4383313cbdb18beedb0853cde3b6a02ce7d

update changelog

view details

Conduitry

commit sha dad02847718084df495c7272c9e0d0f122d99c27

-> v3.42.6

view details

push time in a day

issue commentsveltejs/kit

Environment variables in Svelte templates don't work with `npm run build`

Investigated this today, https://github.com/sveltejs/kit/issues/1396#issuecomment-837383498 was right. IMO there are some ways we can fix this (easy to hard):

  1. remove css map in svelte's ssr compilation, since it's not used
  2. vite run define plugin first, then compile svelte, so css map generates properly
    • problem: define plugin runs between normal and post plugins, compiling svelte in post phase could not work.
    • solution: run a vite:define svelte preprocessor to replace the svelte code before compiling (handled by vite-plugin-svelte)
  3. vite set import.meta.env in runtime for ssr
    • problem: many tooling expects this to be statically replaced, it would be a breaking change

I'll probably try no2 first, before no1

timdeschryver

comment created time in a day

delete branch bluwy/vite

delete branch : feat/export-transformwithesbuild

delete time in a day

push eventbluwy/vite

Bjorn Lu

commit sha 05fae60958823b710a005b1503002840de92ee46

docs: clarify assetsInclude (#4955)

view details

Xuguang Mei

commit sha b9e837a2aa2c1a7a8f93d4b19df9f72fd3c6fb09

fix: use pkgId to get relative path (#4957) (#4961)

view details

underfin

commit sha 714a78c0bd5e73c353f78ee536cad4113cb37bde

feat(plugin-react-refresh): support configure babel plugins fix: #3276

view details

Alec Larson

commit sha 8bfae18425d1712acc59ff8f62e4656ba0876fa2

chore: rename plugin-react-refresh This preserves the commit history.

view details

Alec Larson

commit sha 89284ab8ed4a8ec561cdd38df3a77d387988f883

refactor: migrate plugin-react-refresh to plugin-react See #3588 for full commit history Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Peng Xiao <pengxiao@outlook.com>

view details

bz-pepite

commit sha ba89bd6df9231da85cebd089199bc4ad097af243

fix: disable `inputSourceMap` option of babel (#4834) Closes #4055 Co-authored-by: benoit zegels <b.zegels@pepite.be> Co-authored-by: Alec Larson <1925840+aleclarson@users.noreply.github.com>

view details

btea

commit sha c7499949bae7c50dae6b07f7c3c4b42014a64252

chore: run format (#4969)

view details

push time in a day

startedantfu/vite-plugin-inspect

started time in 2 days

issue commentsveltejs/svelte

Reactive blocks run only once per tick, losing changes and allowing fast pace apps to get out of sync

Thanks for the explanation @isaacHagoel. You're right about reactive programming should ensure program correctness, and there are many ways to achieve that. I think Svelte does ensure that, but in a different way by relying on IoC.

If you do insist on making an optional feature, there are some hurdles I can see:

  1. Deep compare won't work robustly in all cases, which could lead to either infinite loops or program incorrectness.
  2. Infinite loops needs to be detected in some way, we can't have the browser freezing as heuristic, that wouldn't be ideal for prod.
  3. Maybe immutable: true could help with the comparison, but that could be an undesirable side-effect.

IMO this path would as well cause some subtle bugs, and is just one of the many ways to ensure program correctness. So from my POV, you could try that if you want, but it isn't a silver bullet too.

Also: The maintainers have not forgotten about this! We're still discussing asynchronously the best path forward.

isaacHagoel

comment created time in 2 days

PullRequestReviewEvent

issue commentsveltejs/kit

Page with At sign (@) at the beginning of the file name ignored by routes

Note: The fix might be related to #2401, but looks like it's a different issue.

maxcoredev

comment created time in 2 days

delete branch bluwy/vite

delete branch : docs-clarify-assetsinclude

delete time in 3 days

PullRequestReviewEvent

Pull request review commentsveltejs/kit

[docs] rename troubleshooting docs section and link more resources

+---+title: Additional Resources+---++### FAQs++Please see the [SvelteKit FAQ](/faq) for solutions to common issues and helpful tips and tricks.++The [Svelte FAQ](https://svelte.dev/faq) and [`vite-plugin-svelte` FAQ](https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md) may also be helpful for questions deriving from those libraries.++### Integrations++[Svelte Adders](https://sveltesociety.dev/templates#category-Svelte%20Add) allow you to setup many different integrations with a single command. Please see [sveltesociety.dev](https://sveltesociety.dev/) for a full listing of templates, components, and tools available for use with Svelte and SvelteKit. The SvelteKit FAQ also has a [section on integrations](faq#integrations), which may be helpful if you run into any issues.
[Svelte Adders](https://sveltesociety.dev/templates#category-Svelte%20Add) allow you to setup many different integrations with a single command. Please see [sveltesociety.dev](https://sveltesociety.dev/) for a full listing of templates, components, and tools available for use with Svelte and SvelteKit. The SvelteKit FAQ also has a [section on integrations](/faq#integrations), which may be helpful if you run into any issues.

Maybe /faq (with a leading slash) just in case,

benmccann

comment created time in 3 days

PR opened vitejs/vite

docs: clarify assetsInclude

<!-- Thank you for contributing! -->

Description

Closes #4948 and maybe #4953

assetsInclude is often mistaken as an array of file extensions, which internally it's passed to @rollup/pluginutils's createFilter function, so specifying file extensions doesn't work. Clarified as picomatch patterns instead.

Additional context

<!-- e.g. is there anything you'd like reviewers to focus on? -->


What is the purpose of this pull request? <!-- (put an "X" next to an item) -->

  • [ ] Bug fix
  • [ ] New Feature
  • [x] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines.
  • [x] Read the Pull Request Guidelines and follow the Commit Convention.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [ ] Ideally, include relevant tests that fail without this PR but pass with it.
+10 -2

0 comment

2 changed files

pr created time in 3 days

create barnchbluwy/vite

branch : docs-clarify-assetsinclude

created branch time in 3 days

push eventsveltejs/vite-plugin-svelte

bluwy

commit sha c083e3ca99dbfa87ea58bf948eb115f72d73b19c

docs: update include and exclude info

view details

push time in 3 days

push eventbluwy/vite

Andy Li

commit sha f19282f003f64093518290a61446403b1f022d18

feat: allow `apply` condition to be a function (#4857)

view details

Yunfei He

commit sha e623b4a34878d8f2a88f515ea798d814790742ee

chore: delete unused plugin hook 'watchChange' (#4617)

view details

vwkd

commit sha ce292735f538556996540d764e4024fcb9dc9ac7

fix: compute getPkgName only when used (#4729)

view details

TropicalRaisel

commit sha 3392a8ad5618cc68b6898a327b6c8959de6f4992

fix: pnpm create-vite command documentation (#4902) * Fixed pnpm create-vite command documentation pnpx is deprecated: https://pnpm.io/pnpx-cli * Replaced other pnpx entries

view details

ygj6

commit sha 5cc458753171e88bb56fa49dbbf5c87a19d0294f

fix(esbuildDepPlugin): externalize built-in module during SSR (#4904)

view details

Dominik G

commit sha 015290a169d5ca3806aa0b2eb417426d61df9b7d

fix(css): return sourcemap in vite:css transform (#4880)

view details

Ben McCann

commit sha bfbafee0f50ff8afa0c76b1903c484b5008ab95d

chore: give history middleware a name (#4908) * chore: give history middleware a name * chore: move spa fallback middleware to new file * Update packages/vite/src/node/server/middlewares/spaFallback.ts Co-authored-by: patak <matias.capeletto@gmail.com> * fix: typo * chore: better naming for impl function Co-authored-by: patak <matias.capeletto@gmail.com>

view details

Hex

commit sha 7e929ae4932ef89e56b92acdd46856ae41171302

fix: the base is duplicated in `importAnalysisBuild.ts` (#4740)

view details

Anthony Fu

commit sha 9e51a76b3fce27cb0a4a4ae558c4499e9dd540cd

feat(ssr): exports `dynamicDeps` for ssrTransform, close #4898 (#4909)

view details

patak-js

commit sha a93e03a81e256d566558d0c5594dea26c46cd974

release: v2.5.7

view details

ygj6

commit sha b61b044d8fc957c0511ca7d33380ab60bad5754f

feat: add resolve.preserveSymlinks option (#4708)

view details

Andy Li

commit sha e687d9886fd351d9941fc0a1a4c754440a94335f

feat(html): Inline entry chunk when possible (#4555)

view details

meteorlxy

commit sha 9e06b81973cf298aeb0a1f48c67a496bf984c663

fix: avoid wrong warning of explicit public paths (#4927)

view details

Shinigami

commit sha e59997f79c8b450bdc9ab357d90f444dc0a99f50

chore: format (#4931)

view details

patak

commit sha 394d5f1ce5c3f6312f77a0efb119d02ce9646193

docs: authoring tips and vite-plugin-inspect (#4938)

view details

Evan You

commit sha 15bb5a19b45786b097e46ba95a4056bb63bb3c3c

chore: lockfile

view details

Evan You

commit sha 3e3c20364d6c065026f7362bbcb7094099705cc9

fix: do not include css string in bundle if not needed This reduces bundle size when using esbuild as minifier.

view details

Anthony Fu

commit sha 4b90e0fee981faa9e734402bd482c168e4bbdf9f

docs: add vite audio for pronunciation (#4941)

view details

patak

commit sha 398456966df54fa8f74c3cfa42cadeb7540792ff

feat: async script module support, close #3163 (#4864)

view details

Mike Ledger

commit sha 9260848ee7ca15ac5c1a91fce8755beb62269e0d

fix: websocket proxies not the same as http (#4893)

view details

push time in 3 days