profile
viewpoint

blkeller/acme-dns 0

Limited DNS server with RESTful HTTP API to handle ACME DNS challenges easily and securely.

blkeller/emberfire 0

Official Ember Data adapter for Firebase

blkeller/fogproject 0

An open source computer cloning & management system

blkeller/FreeBSD-ports 0

FreeBSD ports tree with pfSense changes

blkeller/freenas 0

FreeNAS Git Repository

blkeller/libcec 0

USB CEC Adapter communication Library http://libcec.pulse-eight.com/

blkeller/linux 0

Linux kernel source tree

blkeller/linuxacademy-dl 0

Download videos from Linux Academy (linuxacademy.com) for personal offline use

blkeller/pfsense 0

Main repository for pfSense

blkeller/plugin.video.jupiterbroadcasting 0

:tv: Jupiter Broadcasting Kodi Addon

startederichgoldman/add-url-to-window-title

started time in 11 days

startedP3TERX/GeoLite.mmdb

started time in 2 months

pull request commenttestem/testem

Explicitly call the `io()` function to get a socket in latest socket.io

@johanneswuerbach It looks like the current version is passing all CI except for SL_IE_9 in browser-tests. I don't think there's anything inherent in this PR that would cause this, and from the looks of it, that particular test has been failing for all PRs since at least Aug. 9, including for PRs that ended up getting merged. Is there any expectation that this test should pass right now, or are we all good here?

blkeller

comment created time in 3 months

pull request commentpfsense/pfsense

Document that upstream gateway controls WAN type vs. LAN type interface

@jim-p I've updated the help text changes to be more general and to link to the relevant documentation, as you recommended. Please take another look when you have a moment.

blkeller

comment created time in 3 months

push eventblkeller/pfsense

Viktor G

commit sha 138f2dd0087989cfd5cbb2caa71af83529139475

Send notification on WebGUI reboot/reroot/halt. Implements #12441

view details

Viktor G

commit sha aa1936eefc251b5330e7392f3b1fbc23a006a400

DNS check optimization for NDP diag page. Fixes #11512

view details

Viktor G

commit sha 46cdd9ab8e3f5e22a9178f9bca2d8785f7de38a7

Allow to select PPPoE Server authentication protocol. Implements #12438

view details

Brad Davis

commit sha 5a1436da475a0ad73f3e0d34607c1d9397c9b89a

Tell us the name of the logs tarball so we don't have to go hunting through s3

view details

Viktor G

commit sha a96a7151f15c0ad54bdac522b1ac3876409766b9

Delete stale OpenVPN RADIUS ACL generated rules. Fixes #12481

view details

Viktor G

commit sha c7a78ad6792a4cff9ab53fd1171b9f77c925d390

Elliptic Curve 25519, 448 bit -> Elliptic Curve 448, 448 bit PH2 rename. Fixes #12350

view details

Renato Botelho do Couto

commit sha 3d1db50b3e09bed8e90d1336a09474d7313e782e

vim-console is now a FLAVOR

view details

jim-p

commit sha 5814ad25aab38f8fdbd961eb039871881fe94b0a

Revise IPsec widget icon behavior. Fixes #12347 * Change P1 status test so it can detect the "connecting" state and show a distinct icon. * Use gettext() for icon tooltip text * Code optimization

view details

jim-p

commit sha 66b1de4c7b70d092bf03f23ce54700c3a38cbc15

IPsec SPD status updates. Implements #12397 * Fix backend parsing of setkey data * Check for VTI vs tunnel mode * Output mode in GUI status, and VTI interface name if available * Make directionality of endpoints and arrow icon match in both the direction column and tunnel endpoints column.

view details

Brett Keller

commit sha d6bc49df19b40ad8359a06d0f93848848eb525bf

Document that upstream gateway controls WAN type vs. LAN type interface

view details

push time in 3 months

Pull request review commentpfsense/pfsense

Document that upstream gateway implies auto outbound NAT

 function build_gatewayv6_list() { ))->setAttribute('type','button')->addClass('btn-success')->setAttribute('data-target', '#newgateway4')->setAttribute('data-toggle', 'modal');  $group->setHelp('If this interface is an Internet connection, select an existing Gateway from the list or add a new one using the "Add" button.%1$s' .-				'On local area network interfaces the upstream gateway should be "none". ' .+				'On local area network interfaces the upstream gateway should be "none".%1$s' .+				'Selecting an upstream gateway will ensure reply traffic for rules on this interface will always route back to that gateway ("reply-to"), ' .

Sorry, I committed that change before your first review came in. I certainly didn't intend to ignore your review, if that's what it might have appeared had happened.

blkeller

comment created time in 3 months

PullRequestReviewEvent

Pull request review commentpfsense/pfsense

Document that upstream gateway implies auto outbound NAT

 function build_gatewayv6_list() { ))->setAttribute('type','button')->addClass('btn-success')->setAttribute('data-target', '#newgateway4')->setAttribute('data-toggle', 'modal');  $group->setHelp('If this interface is an Internet connection, select an existing Gateway from the list or add a new one using the "Add" button.%1$s' .-				'On local area network interfaces the upstream gateway should be "none". ' .+				'On local area network interfaces the upstream gateway should be "none".%1$s' .+				'Selecting an upstream gateway will include this interface in automatic outbound NAT rule generation.%1$s' .

EDIT: Link to this new document instead: https://docs.netgate.com/pfsense/en/latest/interfaces/wanvslan.html

That document is great and answers all of the questions I ever had about what this setting does! Thanks for the link. I only wish I'd come across it before. Every time I've previously tried to find this information in the documentation while setting up interfaces, I was never able to find it.

I'll change this PR to provide a link to that document instead of trying to itemize the many implications of this setting. I think it's especially important to specifically mention "WAN type interface" by name in the help text, since using the exact terminology in the help text as is used in the documentation would likely have been the key for me to know what to read up on.

blkeller

comment created time in 3 months

PullRequestReviewEvent

push eventblkeller/pfsense

Viktor G

commit sha 138f2dd0087989cfd5cbb2caa71af83529139475

Send notification on WebGUI reboot/reroot/halt. Implements #12441

view details

Viktor G

commit sha aa1936eefc251b5330e7392f3b1fbc23a006a400

DNS check optimization for NDP diag page. Fixes #11512

view details

Viktor G

commit sha 46cdd9ab8e3f5e22a9178f9bca2d8785f7de38a7

Allow to select PPPoE Server authentication protocol. Implements #12438

view details

Brad Davis

commit sha 5a1436da475a0ad73f3e0d34607c1d9397c9b89a

Tell us the name of the logs tarball so we don't have to go hunting through s3

view details

Viktor G

commit sha a96a7151f15c0ad54bdac522b1ac3876409766b9

Delete stale OpenVPN RADIUS ACL generated rules. Fixes #12481

view details

Viktor G

commit sha c7a78ad6792a4cff9ab53fd1171b9f77c925d390

Elliptic Curve 25519, 448 bit -> Elliptic Curve 448, 448 bit PH2 rename. Fixes #12350

view details

Renato Botelho do Couto

commit sha 3d1db50b3e09bed8e90d1336a09474d7313e782e

vim-console is now a FLAVOR

view details

jim-p

commit sha 5814ad25aab38f8fdbd961eb039871881fe94b0a

Revise IPsec widget icon behavior. Fixes #12347 * Change P1 status test so it can detect the "connecting" state and show a distinct icon. * Use gettext() for icon tooltip text * Code optimization

view details

jim-p

commit sha 66b1de4c7b70d092bf03f23ce54700c3a38cbc15

IPsec SPD status updates. Implements #12397 * Fix backend parsing of setkey data * Check for VTI vs tunnel mode * Output mode in GUI status, and VTI interface name if available * Make directionality of endpoints and arrow icon match in both the direction column and tunnel endpoints column.

view details

push time in 3 months

push eventblkeller/pfsense

Brett Keller

commit sha 6dee2d0bb29b992a18c3de32688bbafe38c08662

Document that upstream gateway also implies auto outbound NAT It's not clear from the existing help text that adding an upstream gateway will not only apply "reply-to" to interface firewall rules, but it will also include the interface in automatic outbound NAT rule generation.

view details

push time in 3 months

push eventblkeller/pfsense

Brett Keller

commit sha be7019c26a4abcc62ef353793e276f2ad483149b

Document that upstream gateway also implies auto outbound NAT It's not clear from the existing help text that adding an upstream gateway will not only apply "reply-to" to interface firewall rules, but it will also include the interface in automatic outbound NAT rule generation.

view details

push time in 3 months

more