profile
viewpoint
Bingqin Zhou bingqinzhou San Francisco, CA

bingqinzhou/airflow 0

Apache Airflow - A platform to programmatically author, schedule, and monitor workflows

bingqinzhou/debezium 0

Change data capture for a variety of databases. Please log issues at https://issues.redhat.com/browse/DBZ.

bingqinzhou/debezium-connector-cassandra 0

An incubating Debezium CDC connector for Apache Cassandra

bingqinzhou/debezium-incubator 0

New Debezium modules and connectors in incubation phase

bingqinzhou/debezium.github.io 0

Source for the Debezium website at http://debezium.io Please log issues in our JIRA at https://issues.jboss.org/projects/DBZ/issues

bingqinzhou/kafka-connect-bigquery 0

A Kafka Connect BigQuery sink connector

bingqinzhou/ManagementSoftwareDev 0

CS 5500 Software Development

bingqinzhou/MapReduce 0

CS 6240 Parallel Data Processing and MapReduce

bingqinzhou/WebDevSpring2016 0

CS 5610 Web Development

pull request commentdebezium/debezium-connector-cassandra

DBZ-2514

I'll take a look soon later this week or early next week. Currently I'm a bit concerned about 119 files being changed. @smiklosovic Can you list the major changes you're trying to make in the description section please? From my understanding, you are working on the ticket to enable the use of Java 11 on Cassandra Connector. But with a quick look at this PR, it seems to be changed to use a different version of cassandra-driver ? Want to understand why this is related to the Java 11 migration. Thanks!

smiklosovic

comment created time in 3 days

push eventdebezium/debezium-connector-cassandra

fuxiao224

commit sha 1a980c0cbeb5962a17972bbc92125666779e551e

DBZ-3906 add protobuf converter

view details

push time in 2 months

pull request commentdebezium/debezium-connector-cassandra

DBZ-3885 change UUID handling

LGTM, let's wait for @gunnarmorling's approval as well

fuxiao224

comment created time in 3 months

Pull request review commentdebezium/debezium-connector-cassandra

DBZ-3885 change UUID handling

 public SchemaBuilder getSchemaBuilder(AbstractType<?> abstractType) {     @Override     public Object formatDeserializedValue(AbstractType<?> abstractType, Object value) {         byte[] bytes = UuidUtil.asBytes((java.util.UUID) value);-        return Values.convertToString(getSchemaBuilder(abstractType).build(), bytes);+        StringBuilder sb = new StringBuilder();+        for (byte b : bytes) {+            sb.append(String.format("%02x", b));+        }+        return sb.toString();

This doesn't seem to be the correct way to convert byte array into UUID string to me, that might be why it omits the hyphen in UUID. Can you try the following ways to see if any of them works?

  1. ((java.util.UUID) value).toString()
  2. java.util.UUID(value).toString()
  3.  long high = bb.getLong();
     long low = bb.getLong();
     UUID uuid = new UUID(high, low);
     return uuid.toString();```
    
    
fuxiao224

comment created time in 3 months

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentconfluentinc/kafka-connect-bigquery

Register TimestampConverter in DebeziumLogicalConverters

Merged this change with #137. Thanks for bearing with me @bingqinzhou!

@C0urante Thank you so much for helping me merge this fix!

bingqinzhou

comment created time in 3 months

pull request commentconfluentinc/kafka-connect-bigquery

Register TimestampConverter in DebeziumLogicalConverters

@bingqinzhou I've cherry-picked onto 1.6.x and pushed to a new branch which is used in #137. If that looks good to you, we can merge it, propagate the change forward through to master, and put out a new release on the relevant branches.

@C0urante Yes #137 looks good to me. Thank you so much!

bingqinzhou

comment created time in 3 months

more