profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/bidoubiwa/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
cvermand bidoubiwa MeiliSearch Paris Software Engineer @meilisearch | @42 alumni

bidoubiwa/Advent-of-Code 0

Completetion of advent of code challenges

bidoubiwa/aimasterclasslabs 0

AI Masterclass Labs

bidoubiwa/bgg_dataset 0

Script to extract all boardgames from boardgamegeek

bidoubiwa/bulletproof-nodejs 0

Implementation of a bulletproof node.js API 🛡️

bidoubiwa/check-md 0

checks dead links of markdown

bidoubiwa/code-sample-template-test 0

Code sample collector

bidoubiwa/coli-conc-examples 0

Example projects demonstrating how to use services of project coli-conc.

bidoubiwa/documentation 0

MeiliSearch documentation

pull request commentmeilisearch/meilisearch-swift

Make update settings not override previous settings

bors merge

bidoubiwa

comment created time in 4 days

issue openedmeilisearch/documentation

Remove movies.json from doc add download it from dataset repo

Because we only want one place to keep the movies.json dataset up to date we should remove movies.json from this repository and download it on documentation build.

This means that on yarn build a script should download movies.json from the dataset repository.

We also have to create a custom script if the documentation is run using yarn dev to avoid downloading the movies.json on every save action.

created time in 4 days

startedRigellute/spotify-tui

started time in 4 days

push eventmeilisearch/cloud-scripts

Charlotte Vermandel

commit sha 26d7d8005f7a05d9f28919c8675ee58536cf03e7

Create rollback in case of failure

view details

push time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue openedmeilisearch/product

Absence of --dump-import as a environment variable makes version updates complex

Describe the bug The flag --dump-import has no related environment variable (see doc). This causes the import dump process in environments where meilisearch runs a service to be complex.

For example, if MeiliSearch runs with systemctl the launch command is located in the following file: /etc/systemd/system/meilisearch.service

In this file the following line is present:

ExecStart=/usr/bin/meilisearch --env production --db-path /var/lib/meilisearch/data.ms

I could edit the file with a script but it would mean I have to edit it once to add --import-dump flag and once to remove it.

So this is another solution I used to avoid file parsing, and string manipulation:

Imagine I want to update my MeiliSearch version and create a dump before hands. This is the current script:

  1. create dump
  2. Stop the service
  3. delete data.ms
  4. Download new version of meilisearch
  5. launch meilisearch where it has been downloaded using --import-dump with the dump id of step 1 ./meilisearch --import-dump --db-path /var/lib/meilisearch/data.ms
  6. wait for import
  7. Close MeiliSearch local instance
  8. move local meilisearch binary into /usr/bin/meilisearch to override previous version
  9. restart meilisearch service
  10. delete dump file

It is now updated to the new MeiliSearch version

If we had MEIL_DUMP_IMPORT the migration would have been as follow:

  1. create dump
  2. stop service
  3. delete data.ms
  4. download new MeiliSearch version
  5. move meilisearch binary into /usr/bin/meilisearch to override previous version
  6. create MEIL_DUMP_IMPORT with correct dump path
  7. restart meilisearch service
  8. Remove env variable: MEILI_DUMP_IMPORT
  9. delete dump file

MeiliSearch version: v0.22.0

created time in 5 days

issue openedmeilisearch/MeiliSearch

Absence of --dump-import as a environment variable makes updates complex

Describe the bug The flag --dump-import has no related environment variable (see doc). This causes the import dump process in environments where meilisearch runs a service to be complex.

For example, if MeiliSearch runs with systemctl the launch command is located in the following file: /etc/systemd/system/meilisearch.service

In this file the following line is present:

ExecStart=/usr/bin/meilisearch --env production --db-path /var/lib/meilisearch/data.ms

I could edit the file with a script but it would mean I have to edit it once to add --import-dump flag and once to remove it.

So this is another solution I used to avoid file parsing, and string manipulation:

Imagine I want to update my MeiliSearch version and create a dump before hands. This is the current script:

  1. create dump
  2. Stop the service
  3. delete data.ms
  4. Download new version of meilisearch
  5. launch meilisearch where it has been downloaded using --import-dump with the dump id of step 1 ./meilisearch --import-dump --db-path /var/lib/meilisearch/data.ms
  6. wait for import
  7. Close MeiliSearch local instance
  8. move local meilisearch binary into /usr/bin/meilisearch to override previous version
  9. restart meilisearch service
  10. delete dump file

It is now updated to the new MeiliSearch version

If we had MEIL_DUMP_IMPORT the migration would have been as follow:

  1. create dump
  2. stop service
  3. delete data.ms
  4. download new MeiliSearch version
  5. move meilisearch binary into /usr/bin/meilisearch to override previous version
  6. create MEIL_DUMP_IMPORT with correct dump path
  7. restart meilisearch service
  8. Remove env variable: MEILI_DUMP_IMPORT
  9. delete dump file

MeiliSearch version: v0.22.0

created time in 5 days

PR closed meilisearch/meilisearch-swift

Fix issue where settings are being erased and add tests bug

Hi,

In this PR I fixed the issue where the settings are being deleted, this was happening because the library didn't know the different between the delete, removal and keep of a value. In my solution I had to add the Action enum (should I rename it to Transaction?) that flags the type of Action and a new struct only used on the update settings. Reusing the same Setting struct could make the read from Meilisearch server more complex because everything is wrapped around Action.

Unfortunately these are breaking changes. If you have a better solution, please let me know. We could transform all arrays to optional arrays, but it could be a problem with the distinctAttribute which is already an optional value.

Regards, Pedro

+316 -18

1 comment

5 changed files

ppamorim

pr closed time in 5 days

pull request commentmeilisearch/meilisearch-swift

Fix issue where settings are being erased and add tests

Thanks so much for your contribution @ppamorim I found a working solution at #188

fixed by: #188

ppamorim

comment created time in 5 days

push eventmeilisearch/meilisearch-swift

Charlotte Vermandel

commit sha 83761332fab1bde6d492e31acc9829cc98e14b90

Fix linting error

view details

push time in 5 days

push eventmeilisearch/meilisearch-swift

Charlotte Vermandel

commit sha ae91e16b679d3cdf42703092c252a972060606fc

Fix linting errors

view details

Charlotte Vermandel

commit sha d7aa6ec452b5145672a75758d4978bc9e15cb5a9

Change get/update/resetSetting to get/update/resetSettings with a s

view details

push time in 5 days

push eventmeilisearch/meilisearch-swift

Charlotte Vermandel

commit sha ae91e16b679d3cdf42703092c252a972060606fc

Fix linting errors

view details

push time in 5 days

PR opened meilisearch/meilisearch-swift

Change get/update/resetSetting to get/update/resetSettings with a s breaking-change

For consistency between SDK the naming of the following methods have been changed:

  • getSetting becomes getSettings
  • updateSetting becomes updateSettings
  • resetSetting becomes resetResstings
+33 -37

0 comment

8 changed files

pr created time in 5 days

create barnchmeilisearch/meilisearch-swift

branch : change_settings_function_naming

created branch time in 5 days

create barnchmeilisearch/meilisearch-swift

branch : update_settings_fix

created branch time in 5 days

PR opened meilisearch/documentation

Add trace in log level

To keep the doc exhaustive and follow the moto

the documentation is always complete but never finished

I think we should not hide any feature.

I've added the missing log level as this may be used by external contributors but also for futur meili developers that uses the doc to know the possibilities MeiliSeach offers.

+1 -0

0 comment

1 changed file

pr created time in 5 days

push eventmeilisearch/documentation

cvermand

commit sha fafa702e878d4c869af4907173f4d6802fa87f47

Change wording

view details

push time in 5 days

push eventmeilisearch/documentation

cvermand

commit sha e3e1d337b5799c7b6ee1038c7a2c0d9e51f47f13

Add trace in log level

view details

push time in 5 days

create barnchmeilisearch/documentation

branch : exhaustive_information

created branch time in 5 days

startedmrdoob/three.js

started time in 5 days

push eventmeilisearch/meilisearch-swift

Charlotte Vermandel

commit sha dc57ecc30bdb57cddc33fc943a7ac0b4706a3417

Improve comments

view details

push time in 5 days

create barnchmeilisearch/meilisearch-swift

branch : codable_doc_update

created branch time in 5 days

push eventmeilisearch/meilisearch-swift

cvermand

commit sha ece5c047f8364967f817423aa05c9cc52f6c8441

Update MeiliSearch.podspec

view details

cvermand

commit sha 0fc0ce30c594c0f3874953bf4c617a5f55764617

Merge pull request #187 from meilisearch/bidoubiwa-patch-1 Update MeiliSearch.podspec

view details

push time in 5 days