profile
viewpoint

atom/github 980

:octocat: Git and GitHub integration for Atom

benogle/curve-app 131

Vector drawing desktop application

benogle/curve 44

Vector drawing library

atom/pr-changelog 39

Generate a PR changelog between two refs

anvilco/apollo-server-plugin-introspection-metadata 5

A plugin for Apollo Server that allows for adding metadata to GraphQL Introspection Query responses.

benogle/autocomplete-clang 5

A proof of concept clang provider for Atom

benogle/electron-dark-syntax 5

A modern dark syntax theme for atom

benogle/bre 4

ROM editor for old Honda OBD0 VTEC ECUs

issue commentanvilco/node-anvil

Non-json errors not returned to client

🎉

benogle

comment created time in a month

delete branch anvilco/react-ui

delete branch : bo/on-error

delete time in a month

delete branch anvilco/anvil-e-signature-api-node-example

delete branch : bo/new-docs

delete time in a month

delete branch anvilco/anvil-e-signature-api-node-example

delete branch : bo/fix-link

delete time in a month

delete branch anvilco/anvil-e-signature-api-node-example

delete branch : bo/handle-errors

delete time in a month

push eventanvilco/anvil-e-signature-api-node-example

Ben Ogle

commit sha 927279aa6bf6a687750fb71d6d4e597826e943d4

Show error details

view details

Ben Ogle

commit sha ee0f5d252400bd15455637720cd8e6bf208aca65

Handle the new onError callback on AnvilSignatureFrame et al

view details

Ben Ogle

commit sha 4f0ea306a5e44c137b31d64cc7bcb5e34aefbe76

Upgrade packages to 1.6

view details

Ben Ogle

commit sha 658ccc0a84353da86b773704e981a533659aaf22

Merge pull request #24 from anvilco/bo/handle-errors Implement onError handling from ReactSignatureFrame / Modal

view details

push time in a month

PR merged anvilco/anvil-e-signature-api-node-example

Implement onError handling from ReactSignatureFrame / Modal

Implements the new callback from https://github.com/anvilco/react-ui/pull/6.

Screen Shot 2021-10-22 at 3 12 25 PM

When https://github.com/anvilco/react-ui/pull/6 is released, I will update this with the new version....

+65 -22

0 comment

4 changed files

benogle

pr closed time in a month

push eventanvilco/anvil-e-signature-api-node-example

Ben Ogle

commit sha 4f0ea306a5e44c137b31d64cc7bcb5e34aefbe76

Upgrade packages to 1.6

view details

push time in a month

push eventanvilco/react-ui

Ben Ogle

commit sha 16affa7746d135f3e09d0cb4104f0ef24e4547cc

Update changelogs

view details

push time in a month

push eventanvilco/react-ui

Ben Ogle

commit sha 6a7b781ea7fa864c82341cc2c21f56bf84af3a94

Publish - @anvilco/react-signature-frame@1.6.0 - @anvilco/react-signature-modal@1.6.0

view details

push time in a month

created taganvilco/react-ui

tag@anvilco/react-signature-modal@1.6.0

React UI components for Anvil

created time in a month

created taganvilco/react-ui

tag@anvilco/react-signature-frame@1.6.0

React UI components for Anvil

created time in a month

push eventanvilco/react-ui

Ben Ogle

commit sha 78b6eae3cea76fddd389a57730e5dd4a6330a7cc

Add changelogs and related commands

view details

Ben Ogle

commit sha 9c7a84d6d12bae2ff818ae6d8c7efeb71875b6be

Add breaking pattern

view details

Ben Ogle

commit sha 697d7a2e0b67c182b7c213847c45879fe5309d45

Add mocha / enzyme tests

view details

Ben Ogle

commit sha 92eb83ac0674f8587b58e257df6bfb85c3912333

Attempt and fail to get mocha to watch files

view details

Ben Ogle

commit sha 9788646c2617a569d2a4a841d3d3bacbcf555be6

Add helpers, test + use them

view details

Ben Ogle

commit sha 906f77671363c88415e69d20676619f3de0e5788

Make sure it's cloned

view details

Ben Ogle

commit sha 5562038dc3a40fa81e3de654701cba661df8c066

Add bdd-lazy-bar and lint improvements to tests

view details

Ben Ogle

commit sha 1a2e04263d0cbf557047ba3d10a63df5daf24a59

Add tests for the frame component

view details

Ben Ogle

commit sha 00afce3b7bdd60404f023925154e7e938d99bae5

Fix react warnings

view details

Ben Ogle

commit sha 62e14c88631567ab505fbeab9948ffff6e546bea

Pass onError to the frame

view details

Ben Ogle

commit sha 5903305838f78bac4ab9c4609db1b68b8509f9ac

Update docs for onError + clean up links & formatting

view details

Ben Ogle

commit sha 9326948300676d10ad17f3effda2558f5ee3041d

Fix links

view details

Ben Ogle

commit sha c6b92dee89b9431d2d788ed329064096798d798c

Make types italic

view details

Ben Ogle

commit sha 48ccad1406dc6a0cc8dd76c2f17dddccc4bf39fa

Add test action

view details

Ben Ogle

commit sha 43d5616e6e696a24f3f7bdb09418ae72ed326f80

Links for the signURL mutation

view details

Ben Ogle

commit sha 23be44b86788f1050e61266279104205d50520f8

Update test name

view details

Ben Ogle

commit sha fbc0a96fea18060bf2dc471ac7bf73f08e59f268

Merge pull request #6 from anvilco/bo/on-error Add onError handler

view details

push time in a month

PR merged anvilco/react-ui

Add onError handler

Adds an onError handler to both components. It will emit the following payload

{
  action: "signerError",
  documentGroupEid: "jxvp0Z9OJeafwJdCnfsP",
  documentGroupStatus: "sent",
  error: "Token Expired",
  errorType: "tokenExpired",
  etchPacketEid: "tkpEqbyzIM1IMsFEW1JU",
  message: "Please contact the Workflow administrator to get a new link.",
  signerEid: "Pu7NW1y0BewNIIlFtuR1",
  signerStatus: "sent",
}

This PR also adds

  • A test harness and tests for the handling of the postMessage from the iframe.
  • Auto generation of a CHANGELOG.md in each package

Type of change

  • [ ] Bug fix (non-breaking change that fixes an issue)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+2137 -396

0 comment

24 changed files

benogle

pr closed time in a month

PullRequestReviewEvent

Pull request review commentanvilco/react-ui

Add onError handler

+import React from 'react'+import ReactSignatureFrame from '../../src/index'++describe('ReactSignatureFrame', function () {+  def('anvilURL', 'https://app.useanvil.com')+  def('handleLoad', () => sinon.spy())+  def('handleError', () => sinon.spy())+  def('handleFinish', () => sinon.spy())+  def('handleFinishSigning', () => sinon.spy())++  def('render', () => shallow(+    <ReactSignatureFrame+      signURL="http://localhost"+      anvilURL={$.anvilURL}+      onLoad={$.handleLoad}+      onError={$.handleError}+      onFinish={$.handleFinish}+      onFinishSigning={$.handleFinishSigning}+    />,+  ))++  it('renders', async function () {+    const wrapper = $.render+    expect(wrapper).to.exist+    expect(wrapper.find('iframe')).to.exist+  })++  describe('handleSignFinish', function () {+    it('does not call any callbacks when non-anvil url passed in', async function () {+      const origin = 'https://google.com'+      const data = {}+      const wrapper = $.render+      wrapper.instance().handleSignFinish({ origin, data })+      expect($.handleLoad).not.to.have.been.called+      expect($.handleError).not.to.have.been.called+      expect($.handleFinish).not.to.have.been.called+      expect($.handleFinishSigning).not.to.have.been.called+    })++    it('does not call any callbacks when a string data passed in', async function () {+      const origin = $.anvilURL+      const data = { action: 'signerComplete' }+      const wrapper = $.render+      wrapper.instance().handleSignFinish({ origin, data })+      expect($.handleLoad).not.to.have.been.called+      expect($.handleError).not.to.have.been.called+      expect($.handleFinish).not.to.have.been.called+      expect($.handleFinishSigning).not.to.have.been.called+    })

Updated

benogle

comment created time in a month

push eventanvilco/react-ui

Ben Ogle

commit sha 23be44b86788f1050e61266279104205d50520f8

Update test name

view details

push time in a month

Pull request review commentanvilco/node-anvil

Handle different error patterns better

 describe('Anvil API Client', function () {         await expect(client.requestREST('/test', options)).to.eventually.have.been.rejectedWith('problem')       }) -      it('recovers when JSON parsing of error response fails', async function () {+      it('handles various error response structures', async function () {+        options = {+          method: 'GET',+        }+        clientOptions = {+          dataType: 'json',+        }++        const errors = [+          {+            name: 'AssertionError',+            message: 'PDF did not generate properly from given HTML!',+          },+          {+            name: 'ValidationError',+            fields: [{ message: 'Required', property: 'data' }],+          },+        ]++        for (const error of errors) {+          client._request.callsFake((url, options) => {+            return Promise.resolve(+              mockNodeFetchResponse({+                status: 404,

What about a test for a 200 error (e.g. graphql...)

newhouse

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

push eventanvilco/react-ui

Ben Ogle

commit sha 43d5616e6e696a24f3f7bdb09418ae72ed326f80

Links for the signURL mutation

view details

push time in a month

push eventanvilco/react-ui

Ben Ogle

commit sha 48ccad1406dc6a0cc8dd76c2f17dddccc4bf39fa

Add test action

view details

push time in a month

push eventanvilco/react-ui

Ben Ogle

commit sha 9326948300676d10ad17f3effda2558f5ee3041d

Fix links

view details

Ben Ogle

commit sha c6b92dee89b9431d2d788ed329064096798d798c

Make types italic

view details

push time in a month

push eventanvilco/react-ui

Ben Ogle

commit sha 5903305838f78bac4ab9c4609db1b68b8509f9ac

Update docs for onError + clean up links & formatting

view details

push time in a month

PR opened anvilco/anvil-e-signature-api-node-example

Implement onError handling from ReactSignatureFrame / Modal

Implements the new callback from https://github.com/anvilco/react-ui/pull/6.

Screen Shot 2021-10-22 at 3 12 25 PM

When https://github.com/anvilco/react-ui/pull/6 is released, I will update this with the new version....

+55 -12

0 comment

2 changed files

pr created time in a month

PR opened anvilco/react-ui

Reviewers
Add onError handler

Adds an onError handler to both components. It will emit the following payload

{
  action: "signerError",
  documentGroupEid: "jxvp0Z9OJeafwJdCnfsP",
  documentGroupStatus: "sent",
  error: "Token Expired",
  errorType: "tokenExpired",
  etchPacketEid: "tkpEqbyzIM1IMsFEW1JU",
  message: "Please contact the Workflow administrator to get a new link.",
  signerEid: "Pu7NW1y0BewNIIlFtuR1",
  signerStatus: "sent",
}

This PR also adds a test harness and tests for the handling of the postMessage from the iframe.

Type of change

  • [ ] Bug fix (non-breaking change that fixes an issue)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+1938 -98

0 comment

20 changed files

pr created time in a month

push eventanvilco/anvil-e-signature-api-node-example

Winggo Tse

commit sha 437442550999906f011a4c438a1d21330f302610

use onFinishSigning

view details

Winggo Tse

commit sha 16f1ddf68082d58b2be8a6e3939341d0a3a7f889

bump to v1.5.0

view details

Winggo Tse

commit sha 42e3dba1f49a23d85fae1bcb5b23cb27c5c83c3a

remove handleModalSignFinish

view details

Winggo Tse

commit sha 3c392f1367db5cdb144c8f78f8ddb94e6fd32a01

dynamic description

view details

Winggo Tse

commit sha 20ba485441d47b557a0ffe1eee3c99e6c649191e

Merge pull request #23 from anvilco/wt/use-onFinishSigning Use `onFinishSigning` instead of `onFinish`

view details

Ben Ogle

commit sha 927279aa6bf6a687750fb71d6d4e597826e943d4

Show error details

view details

Ben Ogle

commit sha ee0f5d252400bd15455637720cd8e6bf208aca65

Handle the new onError callback on AnvilSignatureFrame et al

view details

push time in a month

push eventanvilco/react-ui

Ben Ogle

commit sha 00afce3b7bdd60404f023925154e7e938d99bae5

Fix react warnings

view details

Ben Ogle

commit sha 62e14c88631567ab505fbeab9948ffff6e546bea

Pass onError to the frame

view details

push time in a month

PullRequestReviewEvent

push eventanvilco/react-ui

Ben Ogle

commit sha 5562038dc3a40fa81e3de654701cba661df8c066

Add bdd-lazy-bar and lint improvements to tests

view details

Ben Ogle

commit sha 1a2e04263d0cbf557047ba3d10a63df5daf24a59

Add tests for the frame component

view details

push time in a month

more