profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/benlangmuir/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ben Langmuir benlangmuir Waterloo, ON, Canada

llvm/llvm-project 10451

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

benlangmuir/sourcekit-lsp 2

Language Server Protocol implementation for Swift

benlangmuir/clang 1

Mirror of official clang git repository located at http://llvm.org/git/clang. Updated hourly.

benlangmuir/gitignore 1

A collection of useful .gitignore templates

benlangmuir/home 1

Dotfiles, scripts, etc.

benlangmuir/indexstore-db 1

Index database library for use with sourcekit-lsp

benlangmuir/lldb 1

Mirror of official lldb git repository located at http://llvm.org/git/lldb. Updated hourly.

benlangmuir/language-server-protocol 0

Defines a common protocol for language servers.

benlangmuir/llvm 0

Mirror of official llvm git repository located at http://llvm.org/git/llvm. Updated hourly.

create barnchbenlangmuir/swift

branch : restrict-ArrayBuffer_CopyContents.swift

created branch time in 2 days

delete branch benlangmuir/swift

delete branch : restrict-ArrayBuffer_CopyContents.swift

delete time in 2 days

push eventapple/swift

Ben Langmuir

commit sha 8ee2ce6f081634b1c5f107e6c041ee50aeebd2cb

[test] Restrict test/stdlib/ArrayBuffer_CopyContents.swift to newer runtimes This test is crashing on older runtimes, so disable it until someone can investigate and decide what if anything should be done about it.

view details

Ben Langmuir

commit sha 71eedb1fa3fd473a72736b485bdf3edfed6b2d92

Merge pull request #39447 from benlangmuir/restrict-ArrayBuffer_CopyContents.swift [test] Restrict test/stdlib/ArrayBuffer_CopyContents.swift to newer runtimes

view details

push time in 2 days

PR merged apple/swift

[test] Restrict test/stdlib/ArrayBuffer_CopyContents.swift to newer runtimes

This test is crashing on older runtimes, so disable it until someone can investigate and decide what if anything should be done about it.

+4 -0

0 comment

1 changed file

benlangmuir

pr closed time in 2 days

PR opened apple/swift

[test] Restrict test/stdlib/ArrayBuffer_CopyContents.swift to newer runtimes

This test is crashing on older runtimes, so disable it until someone can investigate and decide what if anything should be done about it.

+4 -0

0 comment

1 changed file

pr created time in 2 days

delete branch apple/llvm-project

delete branch : benlangmuir-patch-1

delete time in 2 days

delete branch apple/llvm-project

delete branch : benlangmuir-patch-2

delete time in 2 days

PR closed apple/llvm-project

DNM: for testing

Checking if we have any PR test failures from an "unmodified" llvm-project.

+2 -0

1 comment

1 changed file

benlangmuir

pr closed time in 2 days

delete branch benlangmuir/swift-source-compat-suite

delete branch : disable-two

delete time in 2 days

pull request commentapple/llvm-project

Try harder to emit diagnostic on errors in file-descriptor destructor and proceed, instead of calling `report_fatal_error` and `abort()`.

These failures are new on the PR bot, so we should confirm they're not related before proceeding. Created https://github.com/apple/llvm-project/pull/3287 to run tests in the same configuration, but without this change.

artemcm

comment created time in 3 days

pull request commentapple/llvm-project

DNM: for testing

@swift-ci please test

benlangmuir

comment created time in 3 days

PR opened apple/llvm-project

DNM: for testing

Checking if we have any PR test failures from an "unmodified" llvm-project.

+2 -0

0 comment

1 changed file

pr created time in 3 days

create barnchapple/llvm-project

branch : benlangmuir-patch-2

created branch time in 3 days

create barnchapple/llvm-project

branch : benlangmuir-patch-1

created branch time in 3 days

create barnchbenlangmuir/swift

branch : disable-conc-mangle-test-old-os-stdlib

created branch time in 3 days

delete branch benlangmuir/swift

delete branch : disable-conc-mangle-test-old-os-stdlib

delete time in 3 days

push eventapple/swift

Ben Langmuir

commit sha 2144f72a03187ed2535704b4b46c0b432ae13e72

[test] Disable Concurrency/Backdeploy/mangling.swift with OS stdlib This test is failing when run on 10.15 and earlier using the OS stdlib. Disable until we can fix it. rdar://83465277

view details

Ben Langmuir

commit sha 27f7dfb29daa877cf79f446067f1a1c1aeaa50b7

Merge pull request #39427 from benlangmuir/disable-conc-mangle-test-old-os-stdlib [test] Disable Concurrency/Backdeploy/mangling.swift with OS stdlib

view details

push time in 3 days

PR merged apple/swift

[test] Disable Concurrency/Backdeploy/mangling.swift with OS stdlib

This test is failing when run on 10.15 and earlier using the OS stdlib. Disable until we can fix it.

rdar://83465277

+3 -0

0 comment

1 changed file

benlangmuir

pr closed time in 3 days

PR opened apple/swift

[test] Disable Concurrency/Backdeploy/mangling.swift with OS stdlib

This test is failing when run on 10.15 and earlier using the OS stdlib. Disable until we can fix it.

rdar://83465277

+3 -0

0 comment

1 changed file

pr created time in 3 days

pull request commentapple/swift-source-compat-suite

XFAIL two failing projects

@swift-ci please test with toolchain

benlangmuir

comment created time in 3 days

push eventbenlangmuir/swift-source-compat-suite

Ben Langmuir

commit sha 8e0a1a1d67a6f241332fa0caca014c3de9d02f34

XFAIL two failing projects

view details

push time in 3 days

Pull request review commentapple/swift-source-compat-suite

XFAIL two failing projects

       {         "action": "BuildSwiftPackage",         "configuration": "release",+        "xfail": [+          {+            "issue": "rdar://83452858",+            "compatibility": ["5.0"],

😭 I'm used to having a more lenient json parser. Thanks

benlangmuir

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventapple/swift

Ben Langmuir

commit sha 190b6583f88d0d50f3daa5ade8967e0ee1acb8b6

[test] Restrict test/Concurrency/voucher_propagation.swift This is failing (possibly non-deterministically) on some device platforms, so restrict it to macOS until we fix it. rdar://83459813 (cherry picked from commit 80d3310d36ed80508544c57fa04586bbacfff2d0)

view details

Ben Langmuir

commit sha 92a2a513b8652f3feb565e46ff0fdf1bec881933

Merge pull request #39424 from benlangmuir/restrict-voucher-test-5.5 [test] Restrict test/Concurrency/voucher_propagation.swift

view details

push time in 3 days

delete branch benlangmuir/swift

delete branch : restrict-voucher-test-5.5

delete time in 3 days

PR merged apple/swift

[test] Restrict test/Concurrency/voucher_propagation.swift r5.5

Cherry-pick #39423 to 5.5


This is failing (possibly non-deterministically) on some device platforms, so restrict it to macOS until we fix it.

rdar://83459813 (cherry picked from commit 80d3310d36ed80508544c57fa04586bbacfff2d0)

+3 -0

1 comment

1 changed file

benlangmuir

pr closed time in 3 days

pull request commentapple/swift

[test] Restrict test/Concurrency/voucher_propagation.swift

@swift-ci please test

benlangmuir

comment created time in 3 days

Pull request review commentapple/llvm-project

Try harder to emit diagnostic on errors in file-descriptor destructor and proceed, instead of calling `report_fatal_error` and `abort()`.

 raw_fd_ostream::~raw_fd_ostream() {   // to avoid report_fatal_error calls should check for errors with   // has_error() and clear the error flag with clear_error() before   // destructing raw_ostream objects which may have errors.-  if (has_error())-    report_fatal_error("IO failure on output stream: " + error().message(),-                       /*gen_crash_diag=*/false);+  if (has_error()) {+    // The following is a workaround for a Swift compiler issue wherein the+    // compiler occassionally crashes in this destructor with no meaningful+    // error diagnostic being emitted. This is possibly due to Swift's+    // installed error handler relying on standard output/error streams,+    // which may in fact be the ones causing the error here.+    //+    // In order to get a richer diagnostic signal than a stack trace indicating+    // this as a point of failure, let's try blasting the error to stderr+    // without relying on things like errs(), in the hope that these error+    // messages can help yield actionable bug reports.+    //+    // Also, as a part of this temporary workaround, we can try to minimize+    // the impact of the crash by avoiding `report_fatal_error` and its+    // subsequent call to `abort()`.+    {+      SmallVector<char, 64> Buffer;+      raw_svector_ostream OS(Buffer);+      OS << "Error encountered during compilation; ";+      OS << "please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project\n";+      OS << "File Descriptor close failed on FD: " << FD << "\n";+      OS << "Error: " << error().message() << "\n";+      StringRef MessageStr = OS.str();+      ::write(2, MessageStr.data(), MessageStr.size());

Nit: STDERR_FILENO

artemcm

comment created time in 3 days

Pull request review commentapple/llvm-project

Try harder to emit diagnostic on errors in file-descriptor destructor and proceed, instead of calling `report_fatal_error` and `abort()`.

 raw_fd_ostream::~raw_fd_ostream() {   // to avoid report_fatal_error calls should check for errors with   // has_error() and clear the error flag with clear_error() before   // destructing raw_ostream objects which may have errors.-  if (has_error())-    report_fatal_error("IO failure on output stream: " + error().message(),-                       /*gen_crash_diag=*/false);+  if (has_error()) {+    // The following is a workaround for a Swift compiler issue wherein the+    // compiler occassionally crashes in this destructor with no meaningful+    // error diagnostic being emitted. This is possibly due to Swift's+    // installed error handler relying on standard output/error streams,+    // which may in fact be the ones causing the error here.+    //+    // In order to get a richer diagnostic signal than a stack trace indicating+    // this as a point of failure, let's try blasting the error to stderr+    // without relying on things like errs(), in the hope that these error+    // messages can help yield actionable bug reports.+    //+    // Also, as a part of this temporary workaround, we can try to minimize+    // the impact of the crash by avoiding `report_fatal_error` and its+    // subsequent call to `abort()`.+    {+      SmallVector<char, 64> Buffer;

Your string below is already more than double this length, so this is going to heap allocate, and likely twice. I suspect 256 would be big enough to not allocate unless error().message() was huge for some reason.

artemcm

comment created time in 3 days