profile
viewpoint
Benedikt Heine bebehei private Somewhere in the Internet https://bebehei.de Github tells me to write a "bio" here. Has this anything to do with biology?

bebehei/df 8

my personal dotfiles

bebehei/akulm 7

After KernelUpgrade Loadable Modules

bebehei/background-for-i3-tray 7

Generate icons without an alpha channel suited for i3 traybar.

bebehei/check_dnsserials 6

Check your DNS is in sync (general icinga/icinga2/nagios plugin)

bebehei/backup-with-borg 4

Simple script to backup with borg

bebehei/kpicosim-docker 4

Such a shitty university assignment, I even have to port the software first!

bebehei/borgbackup-docker 3

borgbackup server inside a dockercontainer

bebehei/fork-cleanup 3

Cleanup your unneccessary Github forks and gain overview.

bebehei/backup-with-restic 2

A fork of backup-with-borg adapted for restic usage

startedLeantime/leantime

started time in 8 days

delete branch bebehei/jenkins-formula

delete branch : jenkins_port-nginx

delete time in a month

delete branch bebehei/i3

delete branch : fix-workspace-next_prev

delete time in a month

delete branch bebehei/docker-lineageos

delete branch : apt-calls

delete time in a month

delete branch bebehei/docker-lineageos

delete branch : docker-build-pull

delete time in a month

delete branch bebehei/dav-backup

delete branch : dev

delete time in a month

delete branch bebehei/mailcow-dockerized

delete branch : pop-port-typo

delete time in a month

delete branch bebehei/mailcow-dockerized

delete branch : patch-1

delete time in a month

delete branch bebehei/mailcow-dockerized

delete branch : perms

delete time in a month

delete branch bebehei/borgbackup

delete branch : samefs-mountpoints-doc

delete time in a month

delete branch bebehei/borgbackup

delete branch : 1.0-maint

delete time in a month

delete branch bebehei/borgbackup

delete branch : borg-remote-path-docs

delete time in a month

delete branch bebehei/redshift

delete branch : bebehei-patch-1

delete time in a month

delete branch bebehei/redshift

delete branch : patch-1

delete time in a month

delete branch bebehei/salt

delete branch : develop

delete time in a month

create barnchbebehei/salt

branch : master

created branch time in a month

delete branch bebehei/salt

delete branch : git-shared-fix

delete time in a month

delete branch bebehei/salt

delete branch : patch-1

delete time in a month

push eventbebehei/salt

Benedikt Heine

commit sha e05824a36ca62aa9f3a21854ec8b40a3e0f7a68d

Split monit status fields on monit version With the commit [0] on monit, the field size changed. So splitting hard after 35 chars, new versions of monit break when using monit.status. [0] https://bitbucket.org/tildeslash/monit/commits/ 471c4bbc388c1c536f07ce1dd26b811bd39a9467

view details

push time in a month

push eventbebehei/salt

Julio Gonzalez Gil

commit sha 88f7822895e76dd1e65ce20e05251040432da119

Clarify how to get the master fingerprint

view details

HG00

commit sha 9b6049ad5802a31158cd7008de2bdc69e2ad27cb

Docs: Add SSH Key auth section to libvirt #55094

view details

Jochen Breuer

commit sha d7d0778ff0d6d839cfc637f76154108e72fb3fef

Update to more current SLE version numbers SLE 15 and SLE 15 SP1 are more current. Also those versions ship with Salt in the base repos. No need to add additional repos. Adding additional repos would actually be harmful, since those would have skipped the openQA checks.

view details

Daniel Wozniak

commit sha c611274bd5a6d882d62d5152d0b116c3546aac8f

Merge branch 'master' into patch-1

view details

cmcmarrow

commit sha 2aa6338ed0f42dcc7416624fd5a016cb94ca1c71

fix Indefinitely code

view details

Jochen Breuer

commit sha b0bbb186d2e34c40313d61e25916c2bab3d95efa

Removed mention of further SPs There is now SLE 15 SP2 coming and nothing will change here. Salt is in the base repos and no repo needs to be added to install Salt.

view details

Jochen Breuer

commit sha 51582f70dd30e81114adde367fb72c45a331889f

Merge branch 'master' into patch-5

view details

stratusjerry

commit sha 455eb522ad7b42aae9c08806239b9d471e532afa

Fix broken documentation examples

view details

cmcmarrow

commit sha 5839da81ee51f70cf2658a3e48a55f370fca7fad

add test

view details

Charles McMarrow

commit sha 6e923f75fce99363e55c12542ddaa70f2b7e4a85

Merge branch 'master' into win_task_repeat

view details

Charles McMarrow

commit sha beaf05d5147492abf124f2c7f33b759f55b6adf4

Update test_win_task.py

view details

Jorge Schrauwen

commit sha 95d46d6cc87866e2bf2462d8d418a102fbe80402

#55185 pdbedit module should check for version 4.8.x or newer

view details

Jorge Schrauwen

commit sha a5179434e754e28ec0bc36e37cf797e91fa7c6cf

Merge branch 'master' into pdbedit_55185

view details

Jorge Schrauwen

commit sha f77719c179f4bbf9ce9681bfe95a0db5565be028

smartos state should handle vrrp config When using vrrp_vrid configuration option the mac address gets automatically calculated based on the value. This allows the smartos state to handle this instead of trying to remove the nic and add a new vrrp nic. (which fails)

view details

Jorge Schrauwen

commit sha 5bd7dd009a6ec85e028a43b52b353cef97b3d4cd

Merge branch 'master' into smartos_vrrp

view details

Charles McMarrow

commit sha dee9c134e708c0956a3cdbd1ddd217f1a82c286d

Merge branch 'master' into win_task_repeat

view details

Charles McMarrow

commit sha 22a2d0b9ec0371f7d62b526fce346576eb10183f

Merge branch 'master' into win_task_repeat

view details

Charles McMarrow

commit sha 9df94569c4d6de0917f664e463ae678c772ac726

Merge branch 'master' into win_task_repeat

view details

Charles McMarrow

commit sha 4b80301338a9bf982cc0faaa1103905409eaa31e

Merge branch 'master' into win_task_repeat

view details

cmcmarrow

commit sha cf4ab215b55beda7076c15fe3c12f80b3ad0c296

add fix for bin_env

view details

push time in a month

delete branch bebehei/salt

delete branch : bash-completion

delete time in a month

delete branch bebehei/salt

delete branch : bashcompletion-cache

delete time in a month

delete branch bebehei/salt

delete branch : fix-hide-timeout

delete time in a month

delete branch bebehei/salt

delete branch : bashcompletion-saltkey

delete time in a month

delete branch bebehei/i3status

delete branch : testsuite-285

delete time in a month

delete branch bebehei/i3status

delete branch : mem-support

delete time in a month

delete branch bebehei/i3status

delete branch : percent

delete time in a month

delete branch bebehei/i3status

delete branch : percent-stash

delete time in a month

push eventbebehei/i3status

Øyvin Halfdan Thuv

commit sha 3e1213123fb0d49339b11eafa8b283f87b237d6f

Read multiple batteries on DragonFly BSD. Using ACPI to read individual battery information instead of just accumulations from sysctl.

view details

Olivier Gayot

commit sha ca8c3e73372babbf1aaa47db55a9360739ca37c5

No longer use a temporary buffer in the die() function Before the following change f947d0a Breaks configfiles! Major refactoring of i3status, see below The die(fmt, ...) function was outputting the reason to the status bar in addition to stderr. For this reason, it was meaningful to create a temporary string according to the format string and then passing it around to the different functions. Nowadays, we only display the error message to stderr so calling fprintf(stderr, ...) is much simpler. Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

view details

Olivier Gayot

commit sha 598b76cc5332e196518a9ec6d722ebaeb3781a9c

Make sure the arguments passed to printf/die(...) match the format Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

view details

Olivier Gayot

commit sha a6dd14c8c62e7e771ca76e9a5d897e8c90d1882a

Avoid assigning a new value to a var before using the old value Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

view details

Olivier Gayot

commit sha 95c068358acb303ab01ab8dc372f893aec5fe1b0

Fix use of undefined macro __OpenBSD__ Compiling on Linux with -Wundef produces the following warning: warning: "__OpenBSD__" is not defined, evaluates to 0 [-Wundef] Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

view details

Olivier Gayot

commit sha c64195d14728aa82e280d022e9f7ceff71cfc6c1

Fix invalid handling of glob() errors on Linux The manual of glob(3) says that the function returns 0 on successful completion. Any other integer value should be considered an error, not only negative integers. In practice, *BSD systems use negative values but Linux uses positive integers. Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

view details

Olivier Gayot

commit sha 445b1925e3d2e239740d7765e5892d0671174e8e

Fix potential memory leak on Linux The function slurp_all_batteries(), on Linux, allocates memory dynamically Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

view details

Olivier Gayot

commit sha c221b4d331d46d07fe24afc78e4eeb021556d013

Prevent potential crash if glob() fails Calling globfree(NULL) is undefined behaviour. In Linux (glibc), it results in a segmentation fault. It is also undefined behaviour to call globfree(&pglob) if a previous call to glob(&pglob) returned an error. Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

view details

Ingo Bürk

commit sha 4d3344ab9cd68bad5faf4ed3dad185dfcacb1e3d

Merge pull request #290 from duskCoder/changes Fix potential issues & avoid unnecessary instructions

view details

Olivier Gayot

commit sha 03c8908ec6429a67c3a8f480f1002788ff155bfb

Stop requiring CAP_NET_ADMIN Since the following commit in the Linux kernel tree 0fdc100bdc4b ethtool: allow non-netadmin to query settings it is no longer necessary to have the CAP_NET_ADMIN capability to query a device speed using ioctl(..., SIOCETHTOOL) in conjonction with the ETHTOOL_GSET ethtool command. The mentioned commit landed first in the 2.6.37 version of the Kernel. This version is no longer maintained nowdays. Since it is not necessary anymore, it is strongly prefered from a security standpoint to drop the CAP_NET_ADMIN capability from the binary. Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>

view details

Felix Buehler

commit sha 50b899ba42c074c430f612fbf868bae364bcabd7

hide seconds in battery by default

view details

Ingo Bürk

commit sha a916481aab2d81b1882a25da34a2fe327d74cff4

Merge pull request #291 from duskCoder/cap_net_admin Stop requiring CAP_NET_ADMIN

view details

Ingo Bürk

commit sha 78c0a53c45428a9671c2d0c38dc5483f66465bf2

Merge pull request #293 from Stunkymonkey/hide_seconds_battery hide seconds in battery by default

view details

Felix Buehler

commit sha 4ea804b751f9394b7b10b520212169a491c698a6

add format_quality option in wireless

view details

Ingo Bürk

commit sha 302966374bd7d9ca5b97171cedd3613ae10360c8

Merge pull request #292 from Stunkymonkey/format_quality add format_quality option in wireless

view details

Felix Buehler

commit sha 4e62a853eec10cf60124cd543744f26ae61578ab

forgot to remove memory discussion from man page (it is implemented)

view details

Ingo Bürk

commit sha c5ad20bf50ca0e28d5e21395c06496b0ded74b00

Merge pull request #294 from Stunkymonkey/remove_memory_discussion forgot to remove memory discussion from man page (it is implemented)

view details

Felix Buehler

commit sha 530c6f01d33c402f400b0858c69b8019ec4bfe2b

fix min_width doc

view details

Felix Buehler

commit sha a40d7d928f2a24dcb4b9eeae0997f143f4651191

switch to clang 3.8 & ignore sort oder of includes

view details

Ingo Bürk

commit sha c7f04b74473c94bfce0900513847d2b3d6dbb320

Merge pull request #295 from Stunkymonkey/fix-min_width-docs fix min_width doc

view details

push time in a month

delete branch bebehei/i3status

delete branch : testsuite

delete time in a month

delete branch bebehei/i3lock

delete branch : newcommits

delete time in a month

delete branch bebehei/docker-graphite-statsd

delete branch : smaller-baseimage

delete time in a month

delete branch bebehei/docker-graphite-statsd

delete branch : flatten-layers

delete time in a month

push eventbebehei/albert

manuel

commit sha 7a61e8b0a601b39ef065a2342c0ae9e822489580

Avoid segfaults in QFuture. Closes #395, #401, #435, #436.

view details

Manuel Schneider

commit sha 835a33e3398dd2f7eb3505510f6633543fa581b8

Disable lineEdit instead of hiding it.

view details

Manuel Schneider

commit sha 41a42553741359606e114c7097df2d8700e9be4d

v0.11.1

view details

idkCpp

commit sha 73593b0e11070b8f176bb9bf71c285112f830513

Fixing autocomplete issue (Closes #410)

view details

idkCpp

commit sha 24ef84a501e3a6d806a62a8ee809daf91ec9001b

Closes #449 "MPRIS freezes app" This was not tested but I implemented timeouts. So I guess it's safe to say that this fixes the problem.

view details

Bart Zaalberg

commit sha 87c385dd34288934e521e03164c9dcc967de7a4f

Updated the highlight color

view details

Legge

commit sha ab03e2f2578fedb2f4e4cd570e46ddf410c0ba0b

Fixed two spelling errors in configwidget.ui

view details

Manuel Schneider

commit sha 1837c1c8b96d9a35cb45ae14a87b9274b2046cce

[Debug] Fix sync mode

view details

Manuel Schneider

commit sha e535c7c9b23e1b83fc5ea8ce00e9486a8bb4e767

Be more verbose on library loading process.

view details

Manuel Schneider

commit sha 69fb53cd21bb2f3d2eaacff50fd17d728ca6189c

Set visibility on libraries only. (Avoid cmake warnings)

view details

Manuel Schneider

commit sha 2bd1d37fc189aac23fb5ed25d5e7ad08977826f2

Save files cache to cache dir instead of data dir

view details

Manuel Schneider

commit sha 71472b48fadbc32997340be15770806ee38a5a3c

Change config location of websearches (data -> config) And a lot of refactoring

view details

Manuel Schneider

commit sha 895af1de70507ba38d79866f5c26b0bd40d6df54

[Websearch] Add trigger on completion

view details

Manuel Schneider

commit sha f77d8e943c9666b1db450e14d8f96ba097744ff2

Skip TLD checks if scheme is http or https

view details

Manuel Schneider

commit sha 798c935a78b88725078cbb94ce83add86bcd3535

Drop min three char limitation for files.

view details

Manuel Schneider

commit sha 550614539b5ea005ec1627085786eba78ff3460b

Several improvements for websearch As a side effect the fallbacks cannot be disabled anymore.

view details

Manuel Schneider

commit sha da1546a835f6da6496ee4b7a8be5787ef8002d1a

Expose the navigation hidden by the lineedit with the control modifier

view details

Manuel Schneider

commit sha 66e2e2db85d02d69a34846aecee1625726b59feb

Fix GCC 7 builds. Closes #456.

view details

Manuel Schneider

commit sha 86e38ec07ed5e3e33b9f5fc6a33f809ed6e5746f

v0.11.2

view details

Manuel Schneider

commit sha 9576bf2b652f7f64c13b7c3195ff7df143b006d7

Fix Home and End

view details

push time in a month

push eventbebehei/albert

Manuel Schneider

commit sha f45a64445336125e835d2e50986f3d6578870321

Update donation link

view details

Manuel Schneider

commit sha affce3e8b664714b129fefe5e4da30a40673f093

v0.14.15

view details

Manuel Schneider

commit sha 7a00ad37eb6fb5590420991c5728e04542973fe9

[Travis] Use docker with 16.04 image

view details

Manuel Schneider

commit sha ff456cb9d1bd72da86d9be3d9bed8f74122b8810

Update README.md

view details

Manuel Schneider

commit sha 1833db00b8fc3d15b6dc0df8c469f85f8d6791a4

Fix typo. Closes #617

view details

Manuel Schneider

commit sha a900d81f6e396f6f70fa5250b6c0e592ea96fbce

Merge the two first run notes.

view details

Manuel Schneider

commit sha 70e3662a8e3a08137073b5932dbd7ddee136ff65

Fix resource leak. Closes #634

view details

Manuel Schneider

commit sha 3f1f7ee54548ac8ba395c3a8235bc5ebd4a64b1e

Update supporters link.

view details

Manuel Schneider

commit sha 49de9caac811bf41256e131013a8f50debe0b4e3

v0.14.16

view details

Benedikt Heine

commit sha e391fc0b80da2307cd4280ce399244fd6a9c775b

Improve Dockerfile (#643) Sticks to Dockerfile best practices, by sorting the multiline arguments and packing commands together in the same layer. Also do not clone the repository via git, copy it instead. As this would build always the master branch and not the one built by travis.

view details

Manuel Schneider

commit sha 64f04034b4049d6834ce9fa689bf472a0e4a9804

Adjust to new gnome-terminal cli. Closes #635.

view details

Manuel Schneider

commit sha de6bd87d907ee6fee0aabe2e44ef9c97df764756

Optimize IPC Do not instanciate a full blown GuiApp for IPC. Reduces runtime to 1/4 which is about 25ms.

view details

Manuel Schneider

commit sha b796ab9243f5f4f20014d3063d436cb6baf8d4bd

No quotes in IPC output

view details

Manuel Schneider

commit sha c29ecd4755ccd7a68f9aefa83790142fdc949524

v0.14.17

view details

Manuel Schneider

commit sha a5625c8f1ad154cf657185fad59a820d4f4f326f

Update .travis.yml

view details

Manuel Schneider

commit sha 51f4b187ca29486860ae4ed307d7549972afeb11

v0.14.18

view details

Manuel Schneider

commit sha c6275568bd33bf6b34f96f1f6b5e1ffb8abefd4f

Update travis.yml

view details

Manuel Schneider

commit sha a7a6a8b38215c07c649b6aef6b979b91f06a0422

Shorten template

view details

Manuel Schneider

commit sha 195a34dac2febb9d7e95313bd0036fccb9579bfe

Add option "Autostart on login". Closes #579.

view details

Manuel Schneider

commit sha 3c0d786e9a323f1e0eb6e592da1a31e083f14c48

Update Dockerfile

view details

push time in a month

delete branch bebehei/akulm

delete branch : fix/issue-1

delete time in a month

delete branch bebehei/command-not-found

delete branch : error-message

delete time in a month

push eventbebehei/command-not-found

Benedikt Heine

commit sha cd8b2d4d6b373f45179f860b95ddc728f4c53521

zsh-handler: add output on fail

view details

Matthias Männich

commit sha 802f0f30365be34184c721782d1f7a34399dcf8a

Merge pull request #11 from bebehei/error-message zsh-handler: add output on fail

view details

Matthias Männich

commit sha c063563c9cc919d5063a72cc5c5e13e92192f46f

set version 0.6.1

view details

Jagannathan Tiruvallur Eachambadi

commit sha 102ea6e2797b6191a7357c94a162f08a3eef4e66

Include an install target for systemd timer

view details

Matthias Maennich

commit sha cac90efe5f38b9500381ee84edd141ddb155dcfb

switch to C++14 standard

view details

Matthias Maennich

commit sha 1f72fdb2a89e32b243570ff3ce9ff364be942d43

add clang-tidy integration

view details

Matthias Maennich

commit sha 1783d5f5a2846b3216864fd3906c696f2937a348

update patch version (forgotten during release)

view details

Matthias Maennich

commit sha d7b019b27c099b2967a62446714d3bae78e01c93

CMake: always export compile commands

view details

Matthias Maennich

commit sha a6b5489f1883110fa34dfef7dd0b8f2044d66709

.gitignore: also ignore bld* prefix That is another handy common prefix for build directories.

view details

Matthias Maennich

commit sha 83a11dbc5204868a4b341c3375ba069ca63ee47b

update travis environment

view details

Matthias Maennich

commit sha a506ce7e2d498791c22a81fe895e0a0a9de33cd2

Apply clang-format on codebase

view details

Matthias Maennich

commit sha b551693a586d6d2bd9463d13f1461550f4994be2

clang-tidy: apply modernize fixes

view details

Matthias Maennich

commit sha 2b491e04e17455c92385031e79ea430d136399f0

clang-tidy: apply performance fixes

view details

Matthias Maennich

commit sha 06e375c4a18e59e64b6ff99a8681a5f06cf32017

clang-tidy: apply readability fixes

view details

Matthias Maennich

commit sha 80320b70c3d19f7324b70f1c8680eed937c9deb2

clang-tidy: fix one dead store warning

view details

Matthias Maennich

commit sha 5c4101df8f87fe74c22c83d496fbc746e5d2c5d9

clang-tidy: add default configuration

view details

Matthias Maennich

commit sha a3defd97c0f5648b870c30dbec66828163820029

update travis integration

view details

Matthias Maennich

commit sha 9e2c61f784ee68e918e15706077c5ae687aed0b7

remove some useless similar words Drop empty strings and strings with linebreaks.

view details

Matthias Maennich

commit sha eec22a850bc6670dd4c1abf982daf36872835cbf

add catch2 testing facilities

view details

Matthias Maennich

commit sha 126805d6571a8e4bdd72d548c7c58f024718397b

add test for similar words calculation

view details

push time in a month

delete branch bebehei/tempsense

delete branch : makefile

delete time in a month

delete branch bebehei/tempsense

delete branch : easier-tempfields

delete time in a month

push eventbebehei/tempsense

Benedikt Heine

commit sha fbc2abe55ab40eb6c34c425064aac8ad8a838ea8

Convert to build to Makefile

view details

Benedikt Heine

commit sha f5b216d76adaed9fd125a5cd78d7b937efdc4e2c

Use easier code to merge both bytes

view details

kyb

commit sha b2fc31be63570afd70ade7bf6281a8a3f5921b6a

Merge pull request #5 from bebehei/makefile Convert to build to Makefile

view details

kyb

commit sha 43956c5f4b3d99bce31202834b3721cdf8e6ea41

Merge pull request #4 from bebehei/easier-tempfields use easier code to merge both bytes

view details

kyb

commit sha 538905d15b999f7e964dea1d748e4e6c8bc0c714

hamfisting away stuff that has been reported broken

view details

kyb

commit sha 7c4e5405c323ecb397b88302bb17aa59f5c9e984

update email address

view details

push time in a month

Pull request review commentdunst-project/dunst

Implement a command line control (dunstctl)

 show_help() { 	  help                     Show this help 	EOH }+dbus_send_checked() {+	dbus-send "$@"+	rc="$?"+	if [ "$rc" -eq "1" ]; then+		echo "Failed to communicate with dunst, is it running? Or maybe the version is outdated." >&2+		echo "Hint: You can try 'dunstctl debug' as a next debugging step." >&2+		exit 1+	fi

We would still stick to set -e :wink:

bebehei

comment created time in 2 months

Pull request review commentdunst-project/dunst

Implement a command line control (dunstctl)

 show_help() { 	  help                     Show this help 	EOH }+dbus_send_checked() {+	dbus-send "$@"+	rc="$?"+	if [ "$rc" -eq "1" ]; then+		echo "Failed to communicate with dunst, is it running? Or maybe the version is outdated." >&2+		echo "Hint: You can try 'dunstctl debug' as a next debugging step." >&2+		exit 1+	fi
	dbus-send "$@" \
	    || die "Failed to communicate with dunst, is it running? Or maybe the version is outdated."

(I'm using the online editor here. indentation tabs/spaces are fucked up)

bebehei

comment created time in 2 months

Pull request review commentdunst-project/dunst

Implement a command line control (dunstctl)

 die(){ printf "%s\n" "${1}" >&2; exit 1; }  show_help() { 	cat <<-EOH-	Usage: dunstctl <command> [parameters]"-	Commands:-	  close                    Close the last notification-	  close-all                Close the all notifications-	  context                  Open context menu of latest notification-	  history-pop              Pop one notification from history-	  status                   Check if-	  status-set [true|false]  Set the status-	  debug                    Print debugging information-	  help                     Show this help+        Usage: dunstctl <command> [parameters]"+        Commands:+          action                   Perform the default action, or open the+                                   context menu of the notification at the+                                   given position+          close                    Close the last notification+          close-all                Close the all notifications+          context                  Open context menu+          history-pop              Pop one notification from history+          status                   Check if+          status-set [true|false]  Set the status+          debug                    Print debugging information+          help                     Show this help

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_04

bebehei

comment created time in 2 months

Pull request review commentdunst-project/dunst

Implement a command line control (dunstctl)

 case "${1:-}" in 		die "dunstctl: No command specified. Please consult the usage." 		;; 	*)-		die "dunstctl: unrecognized command '${1:-}'. Please consult the usage."+		echo "dunstctl: unrecognized command '${1:-}'." >&2+		show_help

Same comment from the "no parameter given" change applies here.

bebehei

comment created time in 2 months

Pull request review commentdunst-project/dunst

Implement a command line control (dunstctl)

 case "${1:-}" in 			|| die "Dunst controlling interface not available. Is the version too old?" 		;; 	"")-		die "dunstctl: No command specified. Please consult the usage."+		echo "dunstctl: No command specified. Please consult the usage."+		show_help
  1. I'd prefer having a clear error message without the clutter of a long help page.
  2. The exit code is now 0.
bebehei

comment created time in 2 months

Pull request review commentdunst-project/dunst

Implement a command line control (dunstctl)

 die(){ printf "%s\n" "${1}" >&2; exit 1; }  show_help() { 	cat <<-EOH-	Usage: dunstctl <command> [parameters]"-	Commands:-	  close                    Close the last notification-	  close-all                Close the all notifications-	  context                  Open context menu of latest notification-	  history-pop              Pop one notification from history-	  status                   Check if-	  status-set [true|false]  Set the status-	  debug                    Print debugging information-	  help                     Show this help+        Usage: dunstctl <command> [parameters]"+        Commands:+          action                   Perform the default action, or open the+                                   context menu of the notification at the+                                   given position+          close                    Close the last notification+          close-all                Close the all notifications+          context                  Open context menu+          history-pop              Pop one notification from history+          status                   Check if+          status-set [true|false]  Set the status+          debug                    Print debugging information+          help                     Show this help

The indentation-tabs are right now replaced with spaces. To make the - of <<- useful, these have to be tabs.

bebehei

comment created time in 2 months

Pull request review commentdunst-project/dunst

Implement a command line control (dunstctl)

 static void dbus_cb_dunst_NotificationAction(GDBusConnection *connection,          LOG_D("CMD: Calling action for notification %d", notification_nr); -        if (notification_nr < 0 || queues_length_waiting() < notification_nr)-                return; //FIXME return error+        if (notification_nr < 0 || queues_length_waiting() < notification_nr) {+                g_dbus_method_invocation_return_error(invocation, G_DBUS_ERROR, G_DBUS_ERROR_INVALID_ARGS,+                        "Couldn't activate action for notification in position %d, %d notifications currently open",+                        notification_nr, queues_length_waiting());+                return;+        }

We previously had the style to align the agument list in one row, right?

        if (notification_nr < 0 || queues_length_waiting() < notification_nr) {
                g_dbus_method_invocation_return_error(invocation,
                                                      G_DBUS_ERROR,
                                                      G_DBUS_ERROR_INVALID_ARGS,
                                                      "Couldn't activate action for notification in position %d, %d notifications currently open",
                                                      notification_nr,
                                                      queues_length_waiting());
                return;
        }
bebehei

comment created time in 2 months

pull request commentdunst-project/dunst

Implement a command line control (dunstctl)

I'll review this now.

bebehei

comment created time in 2 months

push eventbebehei/dunst

Jonas Berlin

commit sha ab3b5c28051640f83420d24a79cf4bdffea7738d

Implement #392

view details

Jonas Berlin

commit sha 364bce1ed0366dc3b24ed8eac12881e033858d2a

Scale icons during loading to get best quality for e.g. vector images

view details

Jonas Berlin

commit sha 39c97e28f6f3be8aedd492ca8e538a672f547529

[ReviewFix] get_pixbuf_from_file: Free memory on error return

view details

Jonas Berlin

commit sha e077b949a6282f25dceab14c29062ba72d10ccd0

[ReviewFix] gdk_pixbuf_from_file: Update valgrind suppressions to match new code paths

view details

Jonas Berlin

commit sha 445d305bf86e7dc65c7005392261982bee746f59

[ReviewFix] dunstrc: Add min_icon_size

view details

Jonas Berlin

commit sha 9264b0f994615ff6b8bd05f19049a3eaee944f42

[ReviewFix] dunst.pod: Update icon scaling documentation

view details

Jonas Berlin

commit sha 87491192cb9d4af974f0db6cd0676881dbd29e9d

[RegressionFix] Slightly different valgrind leak trace in CI env

view details

Jonas Berlin

commit sha 667503ef7dc41b9cdfc4a6bd0d47c306f0dbb8e0

Cleanup, documentation

view details

Jonas Berlin

commit sha 03253e82f7fce95c3e330fcc6e8bda03c6d7a316

[ReviewFix] Remove bogous g_error_free() cal

view details

Jonas Berlin

commit sha ad5d20bd6a0437544abdf913ae03ff2401a156b4

Add tests for icon scaling math & loading

view details

Nikos Tsipinakis

commit sha 3f3082efb3724dcd369de78dc94d41190d089acf

Merge pull request #674 from xkr47/patch-min_icon_size-20191122 Implement #392, take 2

view details

chronus

commit sha 89d7a81b9c687b7b6412e7ee951a2885e7fb15cd

Adding vertical content alignment control. This adds the option `content_alignment`, which allows the user to set the vertical alignment of the notification's content (i.e. icon and text) to either top (`CONTENT_TOP`), center (`CONTENT_CENTER`, default), or bottom (`CONTENT_BOT`). The default preserves current behaviour, while the other options fulfill #486.

view details

chronus

commit sha f9b6f6a066c627ffc46290d5c785cb233464a57c

fixing comparison issue in bottom alignment

view details

chronus

commit sha e665eea97ef536430966457fbe0414c6ec4e759b

adding `content_alignment` to config and documentation

view details

chronus

commit sha 4c09883ef687696a151be94091600d9b20108101

adding changes according to review - adding default to config.h#defaults - changing naming from content_* to vertical_* - replacing switch-case with if-else-if

view details

Nikos Tsipinakis

commit sha dfd6e76de5226b1c42ce435de0587540c801a8b3

Merge pull request #684 from chronus7/master Adding vertical content alignment control.

view details

Benedikt Heine

commit sha 9591af02a83575d7b5c0ed3867e15f5bc58bc4a0

Retrieve user's home from passwd entry as fallback For weird reasons, the HOME-variable might not always be set. So we should fallback on something more reliable. Fixes #693

view details

Nikos Tsipinakis

commit sha fbdef7b58aace3fde3f3dc4f1f523a892efb09dc

Merge pull request #694 from bebehei/issue-693-unset-home Retrieve user's home from passwd entry as fallback

view details

Nikos Tsipinakis

commit sha 43c614559ceb69b84daf2ab65d2b4f86e61ba183

Remove WantedBy in systemd unit file This avoids dunst starting automatically on session start, since it usually happens before the graphical session is brought up and ends up cluttering the journal with errors. Either way, dunst is autostarted by dbus when a notification is sent. See #314

view details

Nikos Tsipinakis

commit sha 69e319c7294acefe94fecef576286cdec5def443

Invalidate actions after notification is closed

view details

push time in 2 months

Pull request review commentdurst-notification/durst

[config] reading of yaml config (no structure yet)

 impl interface::OrgFreedesktopNotifications for Mutex<Notifications> {     } } -impl AsRef<dyn interface::OrgFreedesktopNotifications + 'static> for Rc<Mutex<Notifications>> {+impl AsRef<dyn interface::OrgFreedesktopNotifications + 'static> for Rc<Mutex<Container>> {     fn as_ref(&self) -> &(dyn interface::OrgFreedesktopNotifications + 'static) {         &**self     } }  fn run() -> Result<(), Box<dyn std::error::Error>> {-    let notifications_rc = Rc::new(Mutex::new(Notifications {+    let tmp = config::load_config("~/.config/durst/config.yaml".to_string());

Just as a personal preference, I'd go for ".yml" instead of ".yaml".

Stunkymonkey

comment created time in 2 months

Pull request review commentdurst-notification/durst

[config] reading of yaml config (no structure yet)

 impl interface::OrgFreedesktopNotifications for Mutex<Notifications> {     } } -impl AsRef<dyn interface::OrgFreedesktopNotifications + 'static> for Rc<Mutex<Notifications>> {+impl AsRef<dyn interface::OrgFreedesktopNotifications + 'static> for Rc<Mutex<Container>> {     fn as_ref(&self) -> &(dyn interface::OrgFreedesktopNotifications + 'static) {         &**self     } }  fn run() -> Result<(), Box<dyn std::error::Error>> {-    let notifications_rc = Rc::new(Mutex::new(Notifications {+    let tmp = config::load_config("~/.config/durst/config.yaml".to_string());

The important thing: This should be the $XDG_CONFIG_DIR/durst/config.yaml.

It's just that XDG_CONFIG_DIR is unset on most systems and defaults to ~/.config if unset.

There might be a proper XDG lib in Rust. This might seem to the be the right method: https://docs.rs/dirs/1.0.4/dirs/fn.config_dir.html

Stunkymonkey

comment created time in 2 months

issue commentdurst-notification/durst

Project goals & design

Well just continue. If something isn't clear, ask. There will be always another pair of eyes looking on your code, before it's getting merged. So you can consider yourself as safe. If you'll break the standard, someone will tell you. For the case, that nobody found the mistake prior to merging it, nobody will rip off your head :smiley: :hocho:

And yeah, I could continue. But I'm not just not familiar with Rust, I've got no skills in it currently. The output would be a solid zero. The goal for me is clearly to learn Rust first.

Are you afraid of making "wrong decisions"? You won't be immune to wrong decisions. Today, someone delivered a perfect Pull Request on the dunst repository. it was in itself complete. I could have pressed the merge button. The only thing: he implemented a string splitter function (see python's "a,b,c".split(',')). But this functionality is already in GLib and he can remove half of his code again.

I bet we all experience a similar situation, you probably have already. The only difference between you and me: I haven't. But I haven't tried at all.

So, please keep up the work and we'll support each other! :muscle:

tsipinakis

comment created time in 2 months

pull request commentdunst-project/dunst

Allow for multiple actions per mouse event

But anyways, all in all the code looks nice and polished. I've seldomly seen a PR written with perfect style! Keep up the good work :+1:

mkrasnitski

comment created time in 2 months

Pull request review commentdunst-project/dunst

Allow for multiple actions per mouse event

 bool string_parse_mouse_action(const char *s, enum mouse_action *ret)         return false; } +bool string_parse_mouse_action_list(char **s, enum mouse_action **ret)+{+        ASSERT_OR_RET(s, false);+        ASSERT_OR_RET(ret, false);++        int len = 0;+        while (s[len])+                len++;++        *ret = g_malloc((len + 1) * sizeof(enum mouse_action));

Sorry, it's called g_malloc_n(). See here: https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-malloc-n

mkrasnitski

comment created time in 2 months

Pull request review commentdunst-project/dunst

Allow for multiple actions per mouse event

 void string_strip_delimited(char *str, char a, char b)         str[iwrite] = 0; } +/* see utils.h */+char **string_to_array(const char *string)

I guess you implemented g_strsplit() here, right?

mkrasnitski

comment created time in 2 months

Pull request review commentdunst-project/dunst

Allow for multiple actions per mouse event

 bool string_parse_mouse_action(const char *s, enum mouse_action *ret)         return false; } +bool string_parse_mouse_action_list(char **s, enum mouse_action **ret)+{+        ASSERT_OR_RET(s, false);+        ASSERT_OR_RET(ret, false);++        int len = 0;+        while (s[len])+                len++;++        *ret = g_malloc((len + 1) * sizeof(enum mouse_action));

Please use g_n_malloc() it avoids buffer overflows.

mkrasnitski

comment created time in 2 months

fork bebehei/durst

dunst written in Rust

fork in 2 months

pull request commentdurst-notification/durst

Implement notification id counter

" 1 Pending invitation " :grinning:

tsipinakis

comment created time in 2 months

issue commentdurst-notification/durst

Project goals & design

So, I forgot the most important thing.

So I'd definitely like to help here and see how this evolves.

Nice to have you on board! I'm not sure about your Rust skills, but as you can see, there are plenty of different jobs to do. Currently, I'm not familiar with Rust and have to learn it, too. But most of the jobs aren't really bound to Rust.

So, whenever you make your first PR, I'll invite you into the org.

tsipinakis

comment created time in 2 months

issue commentdurst-notification/durst

Project goals & design

I have flashbacks to reviewing that markup parser @bebehei wrote... God knows what that must have been like writing it

And it's stil not merged yet :see_no_evil: :joy: I wanted to automate everything.... Mhmmm. well. But hey, I've learnt cool things about coccinelle. I'm still subscribed there on the users mailing list. :grin:

Are we doing a 1:1 rewrite of dunst or will we look into improving the design?

We're not doing a 1:1 rewrite of dunst. We're splitting the good things from the bad things of dunst, "borrow" (I don't want to say steal :grinning:) the good things and enrich them with the better concepts.

Configuration: I've already opened numerous issues [...]

Oh yeah. That's one part we'll completely drop and won't provide any backwards compatibility. The dunst ini file is disastrous. Ini is just a 1-dimensional file format with groups.The command line arguments are awful (who the heck has thought, that I want to supply my config file via cli arguments!?!). Modern programming languages use dictionaries (or trees however you want to call it) and so I think it's the right thing to use a dictionary-based config file: YAML (I remember you've asked the question once to implement it in dunst, can't find it rn).

Also having the possibility to have proper rule naming schemes (having matchers and actions):....

[...]
    rules:
        ruleA:
            match:
                - appname: "NAME"
            action:
                - foreground: "green"
        ruleB:
            match:
                - appname: "NAME2"
            action:
                - foreground: "blue"

Customizability: There have been many issues opened on the dunst repo about requests to slightly tweak the layout in one place,

Oh yeah, those are getting more and more on dunst. But we haven't yet defined a path to go. We had thoughts about using HTML/CSS for the GUI stack once another time we thought just using plain cairo (like dunst does it). We haven't settled on this topic yet.

The only thing GUI-wise, we have settled: GUI is logically split from the core. So that it's easy to support X11 and wayland at the same time (@Stunkymonkey uses wayland, I'm still on X).

customisability with rules? Definitely! Every option is a rule!


Our current plan for durst:

  1. Finish the FDN DBus server:
    • Implement the org.freedesktop.Notifications API fully
    • Implement a Notification Object
    • Make the history waiting and displayed queue work together
  2. Add configuration file support
    • YAML
    • add rules support (no rules needed at the beginning)
  3. Vendoring steps (make it easy)
    • Provide proper build
    • Add dbus/systemd service files
    • add debug tools (like what other manager is currently running)
  4. docs docs docs
    • setup proper infrastructure (maybe RTD) to write docs
    • write user docs
    • implementation docs
    • website
    • screenshots!
    • examples!
    • FAQs
  5. CI testing infrastructure
    • add testing framework
    • add tests
    • evaluate coverage (?)
    • CI build
  6. durstctl
    • Implement easy structure
    • add simple commands
    • enhance later to query state and data
  7. Add GUI support
    • ... ?

At our start (IIRC beginning of march), we said, that we want to have a replacement, which works for our use case. It'll take some additional time and effort (we're willing to take) to make others regard it as a viable replacement.

tsipinakis

comment created time in 2 months

pull request commentdunst-project/dunst

RGB*A* support (fixes #289)

What is the 'timeout loop' for you?

We've got the event loop, which is located inside dunst.c, which gets called periodically over and over by the interval, which is taken from queues_get_next_datachange().

bebehei

comment created time in 2 months

startedandrexus/terraform-provider-inwx

started time in 2 months

pull request commentdunst-project/dunst

Implement a command line control (dunstctl)

PS: If you want to join the project, we'd be happy to have you there.

bebehei

comment created time in 2 months

pull request commentdunst-project/dunst

Implement a command line control (dunstctl)

@tsipinakis Well, sad news. @Stunkymonkey and I started a new project together and our goal is to rewrite dunst in Rust. You may have seen it already in your GitHub timeline, it's called durst (german for thirst and a funny combination of dunst and rust).

Beginning with the lockdown for the corona pandemic, I've got more time to contribute to OSS projects again. In relation to the durst notification manager, I'll continue to help here in dunst. But my long term goal will be the switch to durst.

So yes, I won't finish this PR here in its full intention. Feel free to clone the branch and continue (or start over and rewrite commits). I won't have the necessary power and motivation to finish this PR.

bebehei

comment created time in 2 months

Pull request review commentdunst-project/dunst

Fix dunstify installation

 if ! [ -z "$(find "${PREFIX}" -type f)" ]; then         find "${PREFIX}" -type f         exit 1 fi+

Well, I do not read code in a review, which is obviously copied multiple times. How am I supposed to find the bits, which are different? How am I supposed understand the differences in the future? Would a comment help? (spoiler: no) ...

Keep your IT DRY. Here's a perfect article to summarize it.

braunbearded

comment created time in 2 months

issue commentdunst-project/dunst

icons stopped displaying

aus alter Config übernommen

Ja, das funktioniert halt nicht. Genau die optionen müssen in die global section :wink:


For all other english folks: You're applying options to the urgency_critical rule, which actually should be in the global section.

prankousky

comment created time in 2 months

push eventdurst-notification/durst

Felix Buehler

commit sha 0846b19cceec690180b7bca183f6edff5eb7b76e

[dbus] add introspectable function for e.g. d-feet

view details

Felix Buehler

commit sha fbfe5ca475445e0bc9734e8fbfd97fa30f2c6d7d

[Cargo] update to include repo and description

view details

Felix Buehler

commit sha f04d3d11cf5f3a2646b70b159972860a6acbc9e4

[cargo] remove hard coded versions and use the cargo one

view details

Felix Buehler

commit sha 25484b44c6659269d5e15c81711a3f3c193c9f34

[log] enable use of logging

view details

Felix Buehler

commit sha bdda8347ff66fa666031d50430ac81ef9d767749

[structure] move notification to seperate file

view details

Felix Buehler

commit sha 01bbbd1a21b50db469e54cc423faa58347634c9c

[dbus] use queue as ref for having shared state across dbus-method

view details

Felix Buehler

commit sha 99818abb7752d0811810b14b65d981fb45a71263

[test] initial test file

view details

Felix Buehler

commit sha 6a02abef7ba1a06242f50a455a0072e5f6d477dc

[log] ignore unused imports {error, info, trace}

view details

Benedikt Heine

commit sha 3a3a27e818d236d96739b6ce70bdac9fe5bc6f3e

Merge pull request #3 from durst-notification/dbus-debug Dbus-[debug, AsRefClosure] + use cargo version + initial test file

view details

push time in 2 months

issue openeddurst-notification/durst

Issue the project with a License

What License do we want? Why?

created time in 2 months

Pull request review commentdurst-notification/durst

Dbus-[debug, AsRefClosure] + use cargo version + initial test file

 type Err = tree::MethodErr;  impl interface::OrgFreedesktopNotifications for Notifications {     fn get_capabilities(&self) -> Result<Vec<String>, Err> {-        println!("get_capabilities");+        debug!("get_capabilities");

Nice! :+1:

Stunkymonkey

comment created time in 2 months

Pull request review commentdurst-notification/durst

Dbus-[debug, AsRefClosure] + use cargo version + initial test file

 name = "durst" version = "0.1.0" authors = ["Felix Buehler <account@buehler.rocks>"] edition = "2018"+license = "GPL-3.0-or-later"+repository = "https://github.com/durst-notification/durst"+description = "dunst written Rust"

"dunst written in Rust" (I've removed the typo in the repo description :wink: )

Stunkymonkey

comment created time in 2 months

Pull request review commentdurst-notification/durst

Dbus-[debug, AsRefClosure] + use cargo version + initial test file

 name = "durst" version = "0.1.0" authors = ["Felix Buehler <account@buehler.rocks>"] edition = "2018"+license = "GPL-3.0-or-later"

We should rather add the GPL as a license file, which is rather common. (can be done later, too).

Stunkymonkey

comment created time in 2 months

Pull request review commentdurst-notification/durst

Dbus-[debug, AsRefClosure] + use cargo version + initial test file

 impl interface::OrgFreedesktopNotifications for Notifications {     fn get_server_information(&self) -> Result<(String, String, String, String), Err> {         println!("running getserverinformation");         Ok((-            "durst".to_string(),+            env!("CARGO_PKG_NAME").to_string(),

At the end of the day, the user will run durst without cargo. The env variable won't be there anymore.

Stunkymonkey

comment created time in 2 months

starteddiwic/dbus-rs

started time in 2 months

Pull request review commentdunst-project/dunst

Fix dunstify installation

 if ! [ -z "$(find "${PREFIX}" -type f)" ]; then         find "${PREFIX}" -type f         exit 1 fi+

This patch doesn't look right.

braunbearded

comment created time in 2 months

pull request commentdunst-project/dunst

Install dunstify

I guess you have to fix the tests :wink: You have to make changes here: https://github.com/dunst-project/dunst/blob/master/test/test-install.sh

braunbearded

comment created time in 2 months

pull request commentdunst-project/dunst

RGB*A* support (fixes #289)

@jpldcarvalho This may be another hint: https://github.com/dunst-project/dunst/issues/573#issuecomment-450522461

bebehei

comment created time in 2 months

startedmonitoror/monitoror

started time in 2 months

PR closed bebehei/dunst

test github actions
+83 -110

2 comments

5 changed files

bebehei

pr closed time in 2 months

pull request commentdunst-project/dunst

Update CI to Github actions

Thanks for the hint. It succeeded in my fork. I'm not sure, but I guess we have to merge it blind and preliminarily without a commit status.

Does this suffice for you? https://github.com/bebehei/dunst/runs/554651286

bebehei

comment created time in 2 months

push eventdunst-project/docker-images

Benedikt Heine

commit sha 619ff25b97d9750c48100d18ec85308f45cde2e0

Install curl for Codecov

view details

push time in 2 months

pull request commentdunst-project/dunst

Update CI to Github actions

Yep, I pushed those changes already into the git repo.... well not. :confused: ... It was still in my local staging :see_no_evil:

bebehei

comment created time in 2 months

PR opened dunst-project/dunst

Reviewers
Update CI to Github actions

As discussed in #699, I've updated the CI to use github actions. It works even smoother than CircleCI. I haven't expected this.

+83 -110

0 comment

5 changed files

pr created time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha 29e02c2a2927f24c93fb14d85fb87e0243b591fd

Introduce Github Actions as CI

view details

Benedikt Heine

commit sha db76fff1ca1b9b9125c48df31f2f3413d12a467e

Add coveralls settings

view details

Benedikt Heine

commit sha c4fe74df37037bcf23d1044badb1dc4791d0ee4c

Use Codecov, coveralls doesn't work at all The docs of the Github action aren't working at all and are not deemed to work. The "parallels" feature is completely broken and others have solved it by switching to Codecov. See coverallsapp/github-action#13

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha 665fd79dbd5f78672c1b89d065757000e8aceb3a

use codecov, coveralls doesn't work at all

view details

Benedikt Heine

commit sha 16200231da55922536325fe0bcdaeaf09b88cf78

quickfix: install curl for Codecov

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha 4dc83d041c284bb7c1ff6c8dbe45e059841beb8d

test

view details

Benedikt Heine

commit sha 2cbf04007c020d9ed559f1380b58389224ae261d

test

view details

Benedikt Heine

commit sha 74d235a73bc38e8784ff514e843e45c1258aa19e

use codecov

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha 543b9d7c19b7a724c33eb4a5ca95de800eb71d87

use codecov

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha 531e06d0798b39f1635825e519e16c6a1f187ff5

test

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha 8465c7e885b398ddf2d51d7ba0559a5e0841c301

test

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha dd80dd0643a4829e96b8c70e19039c8b430777f2

temp remove arch

view details

push time in 2 months

push eventdunst-project/docker-images

Benedikt Heine

commit sha 6d3ce4217d28cc7b580b195d7f54de718be97e1f

Add lcov dependencies in ArchLinux

view details

push time in 2 months

issue commentdunst-project/dunst

Custom indicators for URL and Actions

@tsipinakis Yeah, we had been discussing previously about this. But I'm not sure, where. I know I had been starting to implement similar stuff with a date field (IIRC I closed this PR because I didn't find an acceptable solution).

Sweenu

comment created time in 2 months

pull request commentdunst-project/dunst

Invalidate actions after notification is closed

The latest set of docker images will get built now. It'll finish in about 2 hours. Dockerhub is slow.

Afterwards, I'll open a PR from my ci branch..

tsipinakis

comment created time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha 709cf6f507f6bc36ec06148cc596818f3cdead33

Introduce Github Actions as CI

view details

Benedikt Heine

commit sha cec95988ad51472f370dc17b1c272b72ac5ada13

Add coveralls settings

view details

push time in 2 months

push eventdunst-project/docker-images

Benedikt Heine

commit sha f1735b89396e4211ad310f97ff64f85cc33ca837

alpine: add compiler-rt

view details

Benedikt Heine

commit sha 49e2065533432c74ba7468991121577d499a0cde

Add lcov in every image

view details

Benedikt Heine

commit sha 89b6c21183d8e769cbcacb9095c9aeafdc0d0f89

Make alpine able to generate coverage for clang

view details

Benedikt Heine

commit sha f923e51a8ab33cdf2654a5e49b98d215f902e45c

Remove old ubuntu dockerfile

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha f4212c5d14b4372bdd6b067fa72aec27488d13fe

Revert "test bionic for lcov support" This reverts commit 281a8c8069bd3ebb63f1db900159dccef4b22cca.

view details

Benedikt Heine

commit sha cc93407d5f6850d00df1749d62efbea40579aa0d

test lcov support

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha 80e69b872df58d862c0d0e1aed86b5eccd60211e

Introduce Github Actions as CI

view details

Benedikt Heine

commit sha a2695489509a71e9e14890517be2fba3a4ac100b

Add coveralls settings

view details

Benedikt Heine

commit sha 281a8c8069bd3ebb63f1db900159dccef4b22cca

test bionic for lcov support

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha d6f9dc8040577060825657bcafc35c61db7abe4c

fixup! fixup! fixup! fixup! fixup! update CI

view details

push time in 2 months

push eventbebehei/dunst

Benedikt Heine

commit sha be7f3a26b0b75046de1c8a969777b4371313e6c5

fixup! fixup! fixup! fixup! update CI

view details

push time in 2 months

more