profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/bdewater/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Bart de Water bdewater @Shopify Montréal, Canada http://somnilocode.nl

bdewater/fido_metadata 8

Client for looking up metadata about FIDO authenticators, for use by WebAuthn relying parties

bdewater/acme-client 0

A Ruby client for the letsencrypt's ACME protocol.

bdewater/activerecord-session_store 0

Active Record's Session Store extracted from Rails

bdewater/activerecord-typedstore 0

ActiveRecord::Store but with type definition

bdewater/active_merchant 0

Active Merchant is a simple payment abstraction library extracted from Shopify. The aim of the project is to feel natural to Ruby users and to abstract as many parts as possible away from the user to offer a consistent interface across all supported gateways.

bdewater/android_key_attestation 0

Ruby gem to verify Android key attestation

bdewater/awesome-webauthn 0

A curated list of awesome WebAuthn/FIDO2 resources

bdewater/bcrypt-ruby 0

bcrypt-ruby is a Ruby binding for the OpenBSD bcrypt() password hashing algorithm, allowing you to easily store a secure hash of your users' passwords.

created tagactivemerchant/active_merchant

tagv1.123.0

Active Merchant is a simple payment abstraction library extracted from Shopify. The aim of the project is to feel natural to Ruby users and to abstract as many parts as possible away from the user to offer a consistent interface across all supported gateways.

created time in 14 days

push eventactivemerchant/active_merchant

Leah Riffell

commit sha 81abb486021f8cadfbd3a4d616f698ee1fa102f3

Release v1.123.0

view details

push time in 14 days

PR merged activemerchant/active_merchant

Release v1.123.0

Release new version 1.123.0.

+3 -1

0 comment

2 changed files

leahriffell

pr closed time in 14 days

push eventactivemerchant/active_merchant

Leah Riffell

commit sha d30be1cd0a38248aee59c2b0597b681cd1345d3f

Pull UnionPay's 62* BIN ranges out of Discover's China UnionPay cards beginning with 62 are able to run on Discover rails in the US and Canada. Because of this, these cards were previously lumped together with Discover. We would now like to break them out in order to have UnionPay cards correctly identified. Discover's BIN list (https://www.discoverglobalnetwork.com/content/dam/discover/en_us/dgn/pdfs/IPP-VAR-Enabler-Compliance.pdf) was used in order to understand specific BIN ranges belonging to UnionPay.

view details

push time in 17 days

PR merged activemerchant/active_merchant

Pull UnionPay's 62* BIN ranges out of Discover's

China UnionPay cards beginning with 62 are able to run on Discover rails in the US and Canada. Because of this, these cards were previously lumped together with Discover. There is no change to how these transactions will be processed, but we would like to break them out in order to identify UnionPay cards correctly.

Discover's BIN list was used in order to understand specific BIN ranges belonging to UnionPay.


Unit tests: 4897 tests, 74184 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

+7 -15

1 comment

3 changed files

leahriffell

pr closed time in 17 days

Pull request review commentactivemerchant/active_merchant

Pull UnionPay's 62* BIN ranges out of Discover's

 module CreditCardMethods         589562..589562       ] -      # In addition to the BIN ranges listed here that all begin with 81, UnionPay cards-      # include many ranges that start with 62.-      # Prior to adding UnionPay, cards that start with 62 were all classified as Discover.-      # Because UnionPay cards are able to run on Discover rails, this was kept the same.+      # UnionPay cards beginning with 62 are able to run on Discover rails in the US and Canada

I would remove this comment (and also adjust the tests below). The doc linked doesn't support the claim it's only the 62* range - it also mentions the 81* one :) leaving the doc itself as a source is fine.

We don't make this sort of comment for JCB either - which as discussed on Slack has a more complicated acceptance story (Discover rails in the US, Amex in Canada, Australia, New Zealand, native in Japan). The "card brand in country using other network"-concept is something that is not a defined thing in Active Merchant at the moment. That could be a useful addition but for now I would recommend to just call a UnionPay card a UnionPay card.

Nitpicking aside - code looks good!

leahriffell

comment created time in 21 days

PullRequestReviewEvent

Pull request review commentrails/rails

Adds Yes/No to ActiveModel::Type::Boolean options.

 class Boolean < Value         "FALSE", :FALSE,         "off", :off,         "OFF", :OFF,+        "no", :no,+        "NO", :NO,

Doesn't this introduce the Norway ('NO' is the ISO 3166 country code) problem YAML has? Also see https://hitchdev.com/strictyaml/why/implicit-typing-removed/

fabionl

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

delete branch bdewater/fido_metadata

delete branch : dependabot/bundler/addressable-2.8.0

delete time in 2 months

push eventbdewater/fido_metadata

dependabot[bot]

commit sha d8992723ef3e9872c70df64a9a7bd447af397cf5

Bump addressable from 2.7.0 to 2.8.0 Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/sporkmonger/addressable/releases) - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](https://github.com/sporkmonger/addressable/compare/addressable-2.7.0...addressable-2.8.0) --- updated-dependencies: - dependency-name: addressable dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Bart de Water

commit sha 97ba90d90c283eb1c264aeb91b920d803f6ddeb1

Merge pull request #3 from bdewater/dependabot/bundler/addressable-2.8.0 Bump addressable from 2.7.0 to 2.8.0

view details

push time in 2 months

PR merged bdewater/fido_metadata

Bump addressable from 2.7.0 to 2.8.0 dependencies

Bumps addressable from 2.7.0 to 2.8.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md">addressable's changelog</a>.</em></p> <blockquote> <h1>Addressable 2.8.0</h1> <ul> <li>fixes ReDoS vulnerability in Addressable::Template#match</li> <li>no longer replaces <code>+</code> with spaces in queries for non-http(s) schemes</li> <li>fixed encoding ipv6 literals</li> <li>the <code>:compacted</code> flag for <code>normalized_query</code> now dedupes parameters</li> <li>fix broken <code>escape_component</code> alias</li> <li>dropping support for Ruby 2.0 and 2.1</li> <li>adding Ruby 3.0 compatibility for development tasks</li> <li>drop support for <code>rack-mount</code> and remove Addressable::Template#generate</li> <li>performance improvements</li> <li>switch CI/CD to GitHub Actions</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/sporkmonger/addressable/commit/6469a232c0f1892809ff66737370c765d574e16c"><code>6469a23</code></a> Updating gemspec again</li> <li><a href="https://github.com/sporkmonger/addressable/commit/24336385de0261571b3adaad0431459edb420c79"><code>2433638</code></a> Merge branch 'main' of github.com:sporkmonger/addressable into main</li> <li><a href="https://github.com/sporkmonger/addressable/commit/e9c76b889789c75d7073c17b0ab557635d3f6704"><code>e9c76b8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/sporkmonger/addressable/issues/378">#378</a> from ashmaroli/flat-map</li> <li><a href="https://github.com/sporkmonger/addressable/commit/56c5cf7ece9223ff4240e07078cc26d3adbbbd30"><code>56c5cf7</code></a> Update the gemspec</li> <li><a href="https://github.com/sporkmonger/addressable/commit/c1fed1ca0a44c448e74d761fd44ed94869199807"><code>c1fed1c</code></a> Require a non-vulnerable rake</li> <li><a href="https://github.com/sporkmonger/addressable/commit/0d8a3127e35886ce9284810a7f2438bff6b43cbc"><code>0d8a312</code></a> Adding note about ReDoS vulnerability</li> <li><a href="https://github.com/sporkmonger/addressable/commit/89c76130ce255c601f642a018cb5fb5a80e679a7"><code>89c7613</code></a> Merge branch 'template-regexp' into main</li> <li><a href="https://github.com/sporkmonger/addressable/commit/cf8884f815c96b646c796f707bf768cf6eb65543"><code>cf8884f</code></a> Note about alias fix</li> <li><a href="https://github.com/sporkmonger/addressable/commit/bb03f7112e8e478240a0f96e1cc7428159b41586"><code>bb03f71</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/sporkmonger/addressable/issues/371">#371</a> from charleystran/add_missing_encode_component_doc_entry</li> <li><a href="https://github.com/sporkmonger/addressable/commit/6d1d8094a66cbf932ecf69db6850bc9edaf86de0"><code>6d1d809</code></a> Adding note about :compacted normalization</li> <li>Additional commits viewable in <a href="https://github.com/sporkmonger/addressable/compare/addressable-2.7.0...addressable-2.8.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+2 -2

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

push eventShopify/money

Bart de Water

commit sha 20e4aca45780e3cba686c96e2435e21ea9f5a1d5

Update readme to remove manual require This hasn't been needed since c191ebf843fe07b260ecb41abb2b85a06b328290

view details

push time in 3 months