profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/bassosimone/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Simone Basso bassosimone @ooni Ventimiglia, Italy

bassosimone/aladdin 11

Experimental Web Connectivity implementation

bassosimone/iconvis 5

Visualizing data through ontologies

bassosimone/libneubot 2

libneubot: the ancestor of Measurement Kit

bassosimone/buridan 1

Free will is annoying and may lead to starvation

bassosimone/libsocks5 1

PoC: SOCKS5 server for running OONI measurements

bassosimone/api-cxx 0

PoC: C++ API for MK based on ffi.h

bassosimone/arduindow 0

Project for the first Turin OpenData Hackathon

bassosimone/bassosimone.github.io 0

My personal website at github.io

pull request commentooni/probe-cli

doc: explain how to write ooni nettests

(I am not surprised to see tests failing. There is a fair amount of engineering to do in order to land this code. As mentioned also above, the first step is to figure out which diffs can go in separately, and submit them as small PRs with tests.)

bassosimone

comment created time in a day

delete branch ooni/probe-cli

delete branch : WORK

delete time in a day

PR closed ooni/probe-cli

Reviewers
doc: explain how to write ooni nettests

Checklist

  • [x] I have read the contribution guidelines
  • [x] reference issue for this pull request: https://github.com/ooni/ooni.org/issues/361 and https://github.com/ooni/probe/issues/1733.
  • [x] related ooni/spec pull request: N/A

Location of the issue tracker: https://github.com/ooni/probe

Description

This is a preliminary commit and requires more work. I am going to push this commit so others soon can start to review it.

This draft supersedes https://github.com/ooni/probe-cli/pull/505

This diff also contains a library of building blocks that is instrumental to complete websteps. In fact, the tutorial I have written here will eventually guide people to write their own implementation of websteps.

I have not written any test for the new code so far. It is also a stretch to call this new code. It is existing code that has been written by me or @kelmenhorst that I have adapted for the purpose of writing the tutorial.

The nice exercise of writing a tutorial is that you are more easily frustrated if the code is difficult to use XD.

How to review the tutorials

Navigate to internal/tutorial/measure and follow the links inside the README.md file. Or go to https://github.com/ooni/probe-cli/tree/WORK/internal/tutorial/measure and read starting from there, which is equivalent.

Editing is quite tricky. Most text comes from comments in Go files. You need to edit the comments and then you need to regenerate all the files. The README.md of the internal/tutorial/measure tutorial contains instructions on how to do that.

What remains to be done before merging

Mainly adding tests and making sure I didn't lose anything when adapting existing code. I like the interface of the new code more, but existing code written last August may have a better implementation of corner cases.

+7370 -13

2 comments

38 changed files

bassosimone

pr closed time in a day

pull request commentooni/probe-cli

doc: explain how to write ooni nettests

Superseded by https://github.com/ooni/probe-cli/pull/506

bassosimone

comment created time in a day

PR opened ooni/probe-cli

Reviewers
Planc

Checklist

  • [x] I have read the contribution guidelines
  • [x] reference issue for this pull request: https://github.com/ooni/ooni.org/issues/361 and https://github.com/ooni/probe/issues/1733.
  • [x] related ooni/spec pull request: N/A

Location of the issue tracker: https://github.com/ooni/probe

Description

This is a rather advanced draft that still requires QA. I am going to push this commit so others soon can start to review it.

This diff also contains a library of building blocks that is instrumental to complete websteps. In fact, the tutorial I have written here will eventually guide people to write their own implementation of websteps.

I have not written any test for the new code so far. It is also a stretch to call this new code. It is existing code that has been written by me or @kelmenhorst that I have adapted for the purpose of writing the tutorial.

The nice exercise of writing a tutorial is that you are more easily frustrated if the code is difficult to use XD.

How to review the tutorials

Navigate to internal/tutorial/measurex and follow the links inside the README.md file. Or go to https://github.com/ooni/probe-cli/tree/planc/internal/tutorial/measure and read starting from there, which is equivalent.

Editing is quite tricky. Most text comes from comments in Go files. You need to edit the comments and then you need to regenerate all the files. The README.md of the internal/tutorial/measurex tutorial contains instructions on how to do that.

What remains to be done before merging

Mainly adding tests and making sure I didn't lose anything when adapting existing code. I like the interface of the new code more, but existing code written last August may have a better implementation of corner cases.

+11234 -111

0 comment

79 changed files

pr created time in a day

push eventooni/probe-cli

Simone Basso

commit sha e155a08d83f116676fdd619a20665695aac8820d

the tutorials are now ready

view details

push time in a day

push eventooni/probe-cli

Simone Basso

commit sha 05e38f4914b297e8456d96d860ece53a5fd42cc5

continue improving docs

view details

push time in 2 days

push eventooni/probe-cli

Simone Basso

commit sha a2c562844bdb69ac7446f5ddf631d51ba622f3f7

some readability fixes

view details

push time in 2 days

push eventooni/probe-cli

Simone Basso

commit sha 19e45d57c787217c9964a09c5ee835a6c5c0ed24

make th work and fix a bunch of bugs

view details

push time in 3 days

push eventooni/probe-cli

Simone Basso

commit sha 80681e58d612cfbade0647b914ee1d9ac7e3f1c4

simplify archival by making dnsx data format equal to archival

view details

Simone Basso

commit sha ad0a3cf4ce02b12aa1900aaa8e5cd1d7c2809ca4

now also http uses the ooni data format

view details

Simone Basso

commit sha cbcfb28559d38b04184fd4aa2b7a93a7f1a1918c

finish converting to ooni data format

view details

Simone Basso

commit sha ca728c38cb5cbfaca5bfc60d746cf5594bd4e4ef

adjusted TH to use most abstract measurex

view details

push time in 3 days

push eventooni/probe-cli

Simone Basso

commit sha ab48a8bad57a2bf6da8ddcc34b719ab74ef27b50

start refactoring to simplify the TH

view details

Simone Basso

commit sha 02bb05a7a683efc7bde2afe73026f71c86eaae28

continue preparing for reducing th code complexity

view details

push time in 3 days

push eventooni/probe-cli

Simone Basso

commit sha 00258d2eee35b112ccc33c9a3782136bf05c3b36

heavy refactoring to simplify plan C

view details

push time in 3 days

push eventooni/probe-cli

Simone Basso

commit sha a75f50f5e29e2172b278209a38bcb7e56de164fe

document each file's content and rationale

view details

push time in 3 days

push eventooni/probe-cli

Simone Basso

commit sha a431a0d20cf1334dbaaba103d277eb6a8e6accd8

implement and expose new websteps test helper We need to do something different now: simpler TH and basically no need to explore too much

view details

Simone Basso

commit sha 2a304713d33f3fdde44207d00e6e27ffb45b387a

make sure we also parse alt-svc

view details

push time in 3 days

push eventooni/probe-cli

Simone Basso

commit sha 74e8fa57ce4be1864de5f178548371960db7e6bc

fix: also save elapsed time Simplifies processing with python

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha a4b1cfacc885d113ca4b33e295ce228af9a3e0a3

improve logging after feedback and add bandwidth monitoring

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 0ec2e7ab945b7e6fd5e7b2d09d25d50d11de0704

more clarity

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 9e11026a263e9e895220d9c11075741b53950fbd

fix: improve UX related to logging

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha c9f88ccce0c54113554ebebad7e9e8d30b7abbe9

feat: add runtime metrics before experimental run

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 4b8f005e480f9f1e81bd07ec4fdbeb87c2760766

fix: compute measurement runtime in a better way

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 6dd602ac7b4f3f735f301364dc9ecb1aae986551

teach miniooni to run websteps

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 91b0ae3bb4b6bd92c47f0524bc4371792bd43186

ignore jafar binary

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 57d9f5dc45f8b4b36274af78e216f36cdb8c43ff

start to commit the tutorials

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha d163f46bbe35ef54182a26281df61fb0057f00ae

also archival now is okay

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 97519ae9f59d16454777998d91172a8e93cb6a22

fix: pass around the measurement ID Allows to cut the most significant bit of complexity which also happened to be buggy :^)

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha f922ec5d9006a09adfebc83eea86eb4275357f09

implement following redirections

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha e77020f9fe47cf07e5cc3d5efcfcf17802f0b973

compute all the redirections

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 9a25631492cbd63516696258f43a855345e48257

at last add code for parsing a URL

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha df68e4655a603a1cfa05660df3ab17bf8858f858

allow running automatic "parallel" TH queries

view details

push time in 4 days

push eventooni/probe-cli

Simone Basso

commit sha 1272aa273d43d714fe876528e083a6609e26c941

allow for parallel dns resolutions

view details

push time in 4 days