profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/at-syot/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Todsapon Boontap at-syot Thailand Hello, I'm Oat JS composer, Swift

at-syot/Alamofire 1

Elegant HTTP Networking in Swift

at-syot/AFNetworking 0

A delightful iOS and OS X networking framework

at-syot/awesome-swift 0

A collaborative list of awesome swift resources. Feel free to contribute!

at-syot/codeigniter-restserver 0

A fully RESTful server implementation for CodeIgniter using one library, one config file and one controller.

at-syot/DEV-ios 0

DEV Community iOS App

at-syot/every-programmer-should-know 0

A collection of (mostly) technical things every software developer should know

at-syot/first-contributions 0

🚀✨ Help beginners to contribute to open source projects

at-syot/FlappySwift 0

swift implementation of flappy bird. More at fullstackedu.com

at-syot/ifme 0

Free, open source mental health communication web app to share experiences with loved ones

issue commentbeyondhb1079/s4us

Component unit tests: HeaderNavMenu

OK let's assign this to me.

josueetcom

comment created time in 3 months

issue commentbeyondhb1079/s4us

Component unit tests: ProfileDropdown

Ahh OK, could you assign this to me ?

josueetcom

comment created time in 3 months

pull request commentSwiftPackageIndex/SwiftPackageIndex-Server

Collection ownername

No, the name is also changing. You can see it in the validation of the new test that I added, test_generate_ownerName:

         XCTAssertEqual(res.name, "Packages by Foo Org")
         XCTAssertEqual(res.overview, "A collection of packages authored by Foo Org from the Swift Package Index")

What I did though was ensure that you can still provide your own name and overview to generate and they'll be used as is. Only if the parameters are unset (nil) will these changes take effect.

Does that make sense?

Ah, i see it now.

finestructure

comment created time in 3 months

pull request commentSwiftPackageIndex/SwiftPackageIndex-Server

Collection ownername

Just to confirm, after review the changed code, i assume that Package's collection name will stay the same with owner(short name), Only overview change to use owner_name's (multiple owner's full-name) instead. Am i understand correct ?

finestructure

comment created time in 3 months

pull request commentSwiftPackageIndex/SwiftPackageIndex-Server

Collection ownername

The tests exposed a few little edge cases but it's all sorted now.

Thanks again @at-syot , this has been really helpful!

Oh, the thx should go to you guys, i didn't do much haha. the true is i'm not sure about an expected result and how much i can make an edit to the function, i mean, am i allow to do this ? that's why i open draft pull request first to update, something like that. So thank you again to lets me do this issue and the improved code is look good to.

finestructure

comment created time in 3 months

Pull request review commentSwiftPackageIndex/SwiftPackageIndex-Server

Collection ownername

 extension PackageCollection {                 Dictionary(grouping: versions, by: { $0.package })                     .sorted(by: { $0.key.url < $1.key.url })             }-            .mapEachCompact { Package.init(package: $0.key,-                                           prunedVersions: $0.value,-                                           keywords: keywords) }-            .map {+            .map { packageToVersions in+                (packageToVersions, ownerName(packages: packageToVersions.map { $0.key }))+            }+            .map { (packageToVersions, ownerName) in+                let packages = packageToVersions.compactMap {+                    Package.init(package: $0.key,+                                 prunedVersions: $0.value,+                                 keywords: keywords) }+                return (packages, ownerName)+            }+            .map { (packages: [Package], ownerName: String) -> PackageCollection in                 PackageCollection.init(-                    name: collectionName,-                    overview: overview,+                    name: "Packages by \(ownerName)",+                    overview: "A collection of packages authored by \(ownerName) from the Swift Package Index",                     keywords: keywords,-                    packages: $0,+                    packages: packages,                     formatVersion: .v1_0,                     revision: revision,                     generatedAt: Current.date(),                     generatedBy: authorName.map(Author.init(name:)))             }     }++    static func ownerName(packages: [App.Package]) -> String {

look better.

finestructure

comment created time in 3 months

PullRequestReviewEvent
PullRequestReviewEvent

push eventat-syot/SwiftPackageIndex-Server

Oat Bo

commit sha 3a0289c9c1039313245fc181a19fe74e3b53ff77

generate ownerName by [App.Package]

view details

Oat Bo

commit sha abd8ccc54925038e73969af058f158d324350fd8

distinct package's names.

view details

push time in 3 months

issue commentSwiftPackageIndex/SwiftPackageIndex-Server

Use full owner name when building package collections

What if we change the generator func from static to normal func, and introduce new helper (new query, single purpose) func that take care for (owner_name, overview).

daveverwer

comment created time in 3 months

issue commentbeyondhb1079/s4us

Component unit tests: HeaderNavMenu

Hi, Im interest to work on this task.

josueetcom

comment created time in 3 months

issue commentbeyondhb1079/s4us

Component unit tests: ProfileDropdown

Hi, is this task available to work ?

josueetcom

comment created time in 3 months

startedat-syot/SwiftPackageIndex-Server

started time in 3 months

push eventat-syot/SwiftPackageIndex-Server

Oat Bo

commit sha bbc9486a9df0106b49ed5380e190cd4621029fe1

add overview.

view details

push time in 3 months

PR opened SwiftPackageIndex/SwiftPackageIndex-Server

add owner_name as a collectionName.

Issue

I think this is not done yet, i just want to update you some progress and need to ask more about the issue. I'm not sure that should i change a PackageCollection.generate func signature ? because i saw this has used by collection API route (only development env) to.

+16 -5

0 comment

2 changed files

pr created time in 3 months

create barnchat-syot/SwiftPackageIndex-Server

branch : collection-ownername

created branch time in 3 months