profile
viewpoint
Aaron Schlesinger arschles @Microsoft @Azure CA https://arschles.com/ Gopher & Kubernaut

aarons-talks/2017-12-04-KubeCon-North-America-2017 202

Best practices for building an app to run on Kubernetes

aarons-talks/2017-KubeCon-EU 31

Code for KubeCon EU 2017

aarons-talks/2019-06-18-JFrog-SwampUP 4

Sample Code from my JFrog SwampUP 2019 Talk

arschles/assert 4

Simple assertions for Go (golang) tests

arschles/athens-workshops 4

Workshops for the Athens Project

aarons-talks/2019-07-26-GopherCon-US 3

Demo code from my GopherCon US 2019 Talk

aarons-talks/2017-09-24-Ignite 2

Code, demos and resources for Ignite 2017 talks

arschles/awesome-go 2

A curated list of awesome Go frameworks, libraries and software

aarons-talks/2019-08-23-GopherCon-UK 1

Demo code from my GopherCon UK 2019 Talk

arschles/30mb-file 1

a lame-ass repository that has a 30 mb file in it

delete branch arschles/http-add-on

delete branch : ref-doc-2-target

delete time in 6 hours

push eventkedacore/http-add-on

Aaron Schlesinger

commit sha 84d97e4105eaac42cab02a66bee978aea79938fe

fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (#372) Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 6 hours

PR merged kedacore/http-add-on

Reviewers
fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documenta… documentation

The targetPendingRequests field was misplaced in the reference documentation for HTTPScaledObjects in v0.2.0

Checklist

Ref #368

+1 -1

0 comment

1 changed file

arschles

pr closed time in 6 hours

push eventarschles/http-add-on

Aaron Schlesinger

commit sha 752fce2ac6bc07ba931f19473da35deb7ab0d2ba

adding targetPendingRequests to the xkcd helm chart (#373) Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

Aaron Schlesinger

commit sha f32f36fdc98135a594c8f161b6afeec60b099d3e

Merge branch 'main' into ref-doc-2-target

view details

push time in 6 hours

delete branch arschles/http-add-on

delete branch : xkcd-target

delete time in 6 hours

push eventkedacore/http-add-on

Aaron Schlesinger

commit sha 752fce2ac6bc07ba931f19473da35deb7ab0d2ba

adding targetPendingRequests to the xkcd helm chart (#373) Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 6 hours

PR merged kedacore/http-add-on

Reviewers
adding targetPendingRequests to the xkcd helm chart

The xkcd sample chart did not allow the user to set targetPendingRequests on its HTTPScaledObject. This PR adds that ability

Checklist

Ref #361

+2 -0

0 comment

2 changed files

arschles

pr closed time in 6 hours

push eventasw101/http-add-on

dependabot[bot]

commit sha 5289b0fe768cc22f73dffd35e8c9eec98b8e3fd5

Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (#378) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

whitesource-bolt-for-github[bot]

commit sha b3ce0e4e67ba887b24b523419d6a48bc2641d1ce

Configure WhiteSource Bolt for GitHub (#379) Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>

view details

Aaron Schlesinger

commit sha bc587115291bfe2ec9ab517717b6fdc21508a1da

Merge branch 'main' into asw101/285

view details

push time in 6 hours

push eventarschles/http-add-on

Aaron Schlesinger

commit sha 65678544cdab29c9c990ff1e4817bba0888228ed

Updating dependencies (#348) * updating dependencies Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * NullLogger => Discard() Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * removing redundant import Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * updating to use go 1.17.2 Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * upgrading vulnerable packages Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * upgrading sftp Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * force-upgrading sftp Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

dependabot[bot]

commit sha 589dae079ebd56d49a669ca94b5d1b743b5d8011

Bump go.uber.org/zap from 1.19.1 to 1.20.0 (#362) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](https://github.com/uber-go/zap/compare/v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 247655f643e43ad8017b74625498149b5d5f2671

Bump github.com/go-logr/zapr from 0.4.0 to 1.2.2 (#357) Bumps [github.com/go-logr/zapr](https://github.com/go-logr/zapr) from 0.4.0 to 1.2.2. - [Release notes](https://github.com/go-logr/zapr/releases) - [Commits](https://github.com/go-logr/zapr/compare/v0.4.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/go-logr/zapr dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha d597b47839290acff84c6522789563f6e42a3172

Bump k8s.io/apimachinery from 0.23.1 to 0.23.2 (#376) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 1e14f2a237ec5b4488735b9da8f8af2e2e1826e6

Bump k8s.io/client-go from 0.23.1 to 0.23.2 (#375) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Aaron Wislang

commit sha 08b050940016bb37551fe2e48fddf4ad2c552b64

Compile binaries and docker images with git SHA (#377) * Compile binaries and docker images with git SHA Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Fix test Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Apply suggestions from @arschles Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

view details

dependabot[bot]

commit sha 5289b0fe768cc22f73dffd35e8c9eec98b8e3fd5

Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (#378) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

whitesource-bolt-for-github[bot]

commit sha b3ce0e4e67ba887b24b523419d6a48bc2641d1ce

Configure WhiteSource Bolt for GitHub (#379) Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>

view details

Aaron Schlesinger

commit sha ebfc372622674611f0ef0dc6ed59a89a539d1231

Merge branch 'main' into ref-doc-2-target

view details

push time in 7 hours

push eventarschles/http-add-on

Aaron Schlesinger

commit sha 65678544cdab29c9c990ff1e4817bba0888228ed

Updating dependencies (#348) * updating dependencies Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * NullLogger => Discard() Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * removing redundant import Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * updating to use go 1.17.2 Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * upgrading vulnerable packages Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * upgrading sftp Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * force-upgrading sftp Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

dependabot[bot]

commit sha 589dae079ebd56d49a669ca94b5d1b743b5d8011

Bump go.uber.org/zap from 1.19.1 to 1.20.0 (#362) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](https://github.com/uber-go/zap/compare/v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 247655f643e43ad8017b74625498149b5d5f2671

Bump github.com/go-logr/zapr from 0.4.0 to 1.2.2 (#357) Bumps [github.com/go-logr/zapr](https://github.com/go-logr/zapr) from 0.4.0 to 1.2.2. - [Release notes](https://github.com/go-logr/zapr/releases) - [Commits](https://github.com/go-logr/zapr/compare/v0.4.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/go-logr/zapr dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha d597b47839290acff84c6522789563f6e42a3172

Bump k8s.io/apimachinery from 0.23.1 to 0.23.2 (#376) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 1e14f2a237ec5b4488735b9da8f8af2e2e1826e6

Bump k8s.io/client-go from 0.23.1 to 0.23.2 (#375) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Aaron Wislang

commit sha 08b050940016bb37551fe2e48fddf4ad2c552b64

Compile binaries and docker images with git SHA (#377) * Compile binaries and docker images with git SHA Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Fix test Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Apply suggestions from @arschles Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

view details

dependabot[bot]

commit sha 5289b0fe768cc22f73dffd35e8c9eec98b8e3fd5

Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (#378) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

whitesource-bolt-for-github[bot]

commit sha b3ce0e4e67ba887b24b523419d6a48bc2641d1ce

Configure WhiteSource Bolt for GitHub (#379) Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>

view details

Aaron Schlesinger

commit sha f1611146bb7833b9ef7f416454c84b0e3e62c4b8

Merge branch 'main' into xkcd-target

view details

push time in 7 hours

push eventiompo/http-add-on

Aaron Schlesinger

commit sha 99b0e9ac2b0e8e11ed915b2daf085390155097c1

converting bug report issue template to a form issue (#363) Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

Aaron Schlesinger

commit sha eb4e1e9f42841259640c8a96fa6b47bf919a4995

Allowing cluster-global operation (#269) * Allowing cluster-global operation Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * passing less unnecessary data in the operator Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * setting namespace Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * updating tests: Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * Updating deployment cache interfaces To accommodate multi-namespace gets and watches Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * starting on deployment cache informer Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * switching over to informer-based deployment cache Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * fixing test compile errors and merging fake and in-memory deployment caches Signed-off-by: Aaron <aaron@ecomaz.net> * fixing tests Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * fixing more compile errs Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * improving logging, and several other small changes Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * go mod tidy Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * Adding config validation Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * improving ns and svc name var names to indicate interceptor Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * running go mod tidy Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * removing unused code Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * passing a function to transform target to in-cluster URL Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * not requiring namespace for operator Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * splitting namespace config for operator into watch and current Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * removing appInfo, passing current namespace everywhere in its place Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * using proper namespace when creating scaled object Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * allowing xkcd chart to set ingress namespace Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * printing namespace in error Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * using proper fully-qualified hostname of external scaler in scaledobject Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * adding note on cluster-global vs. namespaced mode Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * adding note about installing the xkcd chart in cluster-global mode Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * fixing hostname test Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * merging scaler queue counts with routing table hosts. removing merge functionality from interceptors Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * fix assumption in tests that queue has all hosts from routing table Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * adding test for MergeCountsWithRoutingTable Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * sleep for longer to wait for server to start Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * adding handler test for merging hosts Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * adding test to GetMetrics test cases for host not in queue pinger Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

Aaron Wislang

commit sha a65ceb05bfe1885c2e96269a54da0e4cee66f972

Return custom header when request was returned from a cold start (#366) * Add X-KEDA-HTTP-Cold-Start header - Add X-KEDA-HTTP-Cold-Start header - Change signature of forwardWaitFunc to include deployment.Status.ReadyReplicas Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> * Update tests for X-KEDA-HTTP-Cold-Start header Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> * Update interceptor/main_test.go Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> * add bracket Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

view details

Aaron Schlesinger

commit sha 65678544cdab29c9c990ff1e4817bba0888228ed

Updating dependencies (#348) * updating dependencies Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * NullLogger => Discard() Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * removing redundant import Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * updating to use go 1.17.2 Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * upgrading vulnerable packages Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * upgrading sftp Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * force-upgrading sftp Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

dependabot[bot]

commit sha 589dae079ebd56d49a669ca94b5d1b743b5d8011

Bump go.uber.org/zap from 1.19.1 to 1.20.0 (#362) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](https://github.com/uber-go/zap/compare/v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 247655f643e43ad8017b74625498149b5d5f2671

Bump github.com/go-logr/zapr from 0.4.0 to 1.2.2 (#357) Bumps [github.com/go-logr/zapr](https://github.com/go-logr/zapr) from 0.4.0 to 1.2.2. - [Release notes](https://github.com/go-logr/zapr/releases) - [Commits](https://github.com/go-logr/zapr/compare/v0.4.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/go-logr/zapr dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha d597b47839290acff84c6522789563f6e42a3172

Bump k8s.io/apimachinery from 0.23.1 to 0.23.2 (#376) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 1e14f2a237ec5b4488735b9da8f8af2e2e1826e6

Bump k8s.io/client-go from 0.23.1 to 0.23.2 (#375) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Aaron Wislang

commit sha 08b050940016bb37551fe2e48fddf4ad2c552b64

Compile binaries and docker images with git SHA (#377) * Compile binaries and docker images with git SHA Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Fix test Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Apply suggestions from @arschles Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

view details

dependabot[bot]

commit sha 5289b0fe768cc22f73dffd35e8c9eec98b8e3fd5

Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (#378) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

whitesource-bolt-for-github[bot]

commit sha b3ce0e4e67ba887b24b523419d6a48bc2641d1ce

Configure WhiteSource Bolt for GitHub (#379) Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>

view details

Aaron Schlesinger

commit sha 3479c5de55b64f006809813c61d220566a6c5718

Merge branch 'main' into scale-dobject-doc-fix

view details

push time in 7 hours

push eventkedacore/http-add-on

Aaron Wislang

commit sha 08b050940016bb37551fe2e48fddf4ad2c552b64

Compile binaries and docker images with git SHA (#377) * Compile binaries and docker images with git SHA Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Fix test Signed-off-by: Aaron Wislang <aaron.wislang@microsoft.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Apply suggestions from @arschles Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>

view details

push time in a day

issue closedkedacore/http-add-on

Build docker images or compile binaries with git SHA

This would be useful so that anybody could report, from any given running canary or latest (i.e. mutable) image, what code version is being run.

Use-Case

When someone reports an issue with a versioned, immutable image tag like v0.1.0 or similar, it's easy to figure out what specific code is being run because you can simply go to that tag on GitHub. In the case of the latest and canary images - which correspond to the latest stable release and latest checkin to the main branch, respectively - the running code might vary because these images get rebuilt and overwritten as releases get cut and code changes.

Specification

  • Every running pod that gets built should get built with the current git SHA built into it
  • Every pod should have a /version endpoint built into its admin API, which outputs the aforementioned SHA

closed time in a day

arschles

PR merged kedacore/http-add-on

Reviewers
Compile binaries and docker images with git SHA

Compile binaries and build docker images with git SHA both locally, within Dockerfiles, and in GitHub Actions workflows.

Checklist

Fixes #266

+78 -17

0 comment

14 changed files

asw101

pr closed time in a day

PullRequestReviewEvent

Pull request review commentkedacore/http-add-on

Compile binaries and docker images with git SHA

 ENV GOARCH=${GOARCH} ENV GOPROXY="https://proxy.golang.org"  # Build-RUN go build -a -o /bin/operator ./operator+RUN go build -ldflags "-X github.com/kedacore/http-add-on/pkg/build.version=$VERSION" -a -o /bin/operator ./operator

same here regarding the { and }

asw101

comment created time in a day

Pull request review commentkedacore/http-add-on

Compile binaries and docker images with git SHA

 ENV CGO_ENABLED=0 ENV GOOS=${GOOS} ENV GOARCH=${GOARCH} ENV GOPROXY="https://proxy.golang.org"-RUN go build -o /bin/interceptor ./interceptor+RUN go build -ldflags "-X github.com/kedacore/http-add-on/pkg/build.version=$VERSION" -a -o /bin/interceptor ./interceptor

do we need to do ${VERSION} here? not sure if the { and } are required

asw101

comment created time in a day

Pull request review commentkedacore/http-add-on

Compile binaries and docker images with git SHA

 ENV CGO_ENABLED=0 ENV GOOS=${GOOS} ENV GOARCH=${GOARCH} ENV GOPROXY="https://proxy.golang.org"-RUN go build -o /bin/scaler ./scaler+RUN go build -ldflags "-X github.com/kedacore/http-add-on/pkg/build.version=$VERSION" -a -o /bin/scaler ./scaler

same here regarding ${VERSION}

asw101

comment created time in a day

Pull request review commentkedacore/http-add-on

Compile binaries and docker images with git SHA

 func startHealthcheckServer( 	})  	kedahttp.AddConfigEndpoint(lggr, mux, cfg)+	kedahttp.AddVersionEndpoint(lggr, mux)

thoughts on this?

	kedahttp.AddVersionEndpoint(lggr.WithName("scalerAdmin"), mux)
asw101

comment created time in a day

Pull request review commentkedacore/http-add-on

Compile binaries and docker images with git SHA

 func runAdminServer( 		}, 	) 	kedahttp.AddConfigEndpoint(lggr, adminServer, servingConfig, timeoutConfig)+	kedahttp.AddVersionEndpoint(lggr, adminServer)

thoughts on the below?

	kedahttp.AddVersionEndpoint(lggr.WithName("interceptorAdmin"), adminServer)
asw101

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

push eventarschles/dotfiles

Aaron Schlesinger

commit sha a8fe95e666be8c2772a3cbda104de07f4d8f2ea9

Delete bootstrap

view details

push time in 4 days

push eventarschles/dotfiles

Aaron Schlesinger

commit sha 1863672eb88366cb64e6ba167fb5d401379c4a10

updating gitconfig

view details

push time in 4 days

push eventarschles/http-add-on

dependabot[bot]

commit sha 1e14f2a237ec5b4488735b9da8f8af2e2e1826e6

Bump k8s.io/client-go from 0.23.1 to 0.23.2 (#375) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Aaron Schlesinger

commit sha 695d5e819725c3828b568b13f0a933ca619e28b4

Merge branch 'main' into update-replicas

view details

push time in 4 days

push eventarschles/http-add-on

Aaron Schlesinger

commit sha 65678544cdab29c9c990ff1e4817bba0888228ed

Updating dependencies (#348) * updating dependencies Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * NullLogger => Discard() Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * removing redundant import Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * updating to use go 1.17.2 Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * upgrading vulnerable packages Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * upgrading sftp Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net> * force-upgrading sftp Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

dependabot[bot]

commit sha 589dae079ebd56d49a669ca94b5d1b743b5d8011

Bump go.uber.org/zap from 1.19.1 to 1.20.0 (#362) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](https://github.com/uber-go/zap/compare/v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 247655f643e43ad8017b74625498149b5d5f2671

Bump github.com/go-logr/zapr from 0.4.0 to 1.2.2 (#357) Bumps [github.com/go-logr/zapr](https://github.com/go-logr/zapr) from 0.4.0 to 1.2.2. - [Release notes](https://github.com/go-logr/zapr/releases) - [Commits](https://github.com/go-logr/zapr/compare/v0.4.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/go-logr/zapr dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha d597b47839290acff84c6522789563f6e42a3172

Bump k8s.io/apimachinery from 0.23.1 to 0.23.2 (#376) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Aaron Schlesinger

commit sha 4a33d5d4824d04d80ce19224a29b5981d535a94d

Merge branch 'main' of github.com:kedacore/http-add-on into update-replicas Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

view details

push time in 4 days

push eventkedacore/http-add-on

dependabot[bot]

commit sha 1e14f2a237ec5b4488735b9da8f8af2e2e1826e6

Bump k8s.io/client-go from 0.23.1 to 0.23.2 (#375) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/kubernetes/client-go/compare/v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 4 days

delete branch kedacore/http-add-on

delete branch : dependabot/go_modules/k8s.io/client-go-0.23.2

delete time in 4 days

PR merged kedacore/http-add-on

Reviewers
Bump k8s.io/client-go from 0.23.1 to 0.23.2 enhancement dependency-management

Bumps k8s.io/client-go from 0.23.1 to 0.23.2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/kubernetes/client-go/commit/c096072e38356e3b21224ac59c2ee271adaa09e6"><code>c096072</code></a> Update dependencies to v0.23.2 tag</li> <li><a href="https://github.com/kubernetes/client-go/commit/857d6f1290cb212569fc981d366cc2ec5e9c45ac"><code>857d6f1</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/kubernetes/client-go/issues/107567">#107567</a> from <a href="https://github-redirect.dependabot.com/jiahuif-forks/automated-cherry-pick-of-/issues/10756">jiahuif-forks/automated-cherry-pick-of-#10756</a>...</li> <li><a href="https://github.com/kubernetes/client-go/commit/94fb0d02e401e661cfd67aeb25aa29f72254b572"><code>94fb0d0</code></a> generated: ./hack/update-vendor.sh</li> <li><a href="https://github.com/kubernetes/client-go/commit/f739adfab1907fd4f5b4df1d4b41dbe097af6466"><code>f739adf</code></a> upgrade sigs.k8s.io/structured-merge-diff/v4 to v4.2.1</li> <li><a href="https://github.com/kubernetes/client-go/commit/3074be12fea7943697c2150c2796eae3eee284ae"><code>3074be1</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/kubernetes/client-go/issues/107334">#107334</a> from fasaxc/automated-cherry-pick-of-#107311-upstr...</li> <li><a href="https://github.com/kubernetes/client-go/commit/8ae6aa22f315bff071fbcc22ab99a6b7cb1dcc14"><code>8ae6aa2</code></a> client-go: Clear the ResourceVersionMatch on paged list calls</li> <li>See full diff in <a href="https://github.com/kubernetes/client-go/compare/v0.23.1...v0.23.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+6 -4

3 comments

2 changed files

dependabot[bot]

pr closed time in 4 days

PullRequestReviewEvent
more