profile
viewpoint

aredridel/html5 582

Event-driven HTML5 Parser in Javascript

arlolra/meek 70

https://git.torproject.org/pluggable-transports/meek.git

arlolra/ctypes-otr 31

js-ctypes wrapper for libotr

arlolra/bulb 9

A tor relay web status dashboard

arlolra/flashproxy 9

forked from https://git.torproject.org/flashproxy.git

arlolra/check 5

forked from https://git.torproject.org/check.git

arlolra/jquery-editlist 5

jQuery plugin to make lists editable.

arlolra/node-cesu-8 4

Convert a node.js utf-8 buffer w/ smp characters into a v8 string with surrogate pairs.

arlolra/exitaddr 3

Scan Tor nodes for their exiting addresses.

arlolra/oauth 1

OAuth 1.0 implementation in go (golang).

delete branch arlolra/snowflake-webext

delete branch : T34127

delete time in 22 days

push eventarlolra/snowflake-webext

Arlo Breault

commit sha c0b6d25eb3b298428fbaf2968fdf5c0e801dac16

Add some publishing info to the README Trac: 34127

view details

push time in 22 days

created tagarlolra/snowflake-webext

tagwebext-0.3.1

forked from https://gitweb.torproject.org/pluggable-transports/snowflake-webext.git

created time in 22 days

push eventarlolra/snowflake-webext

Arlo Breault

commit sha d2a9a8fd136ac6bbba393de3d51fb7ca85e17b8a

bump version to 0.3.1

view details

push time in 22 days

create barncharlolra/snowflake-webext

branch : T34127

created branch time in 23 days

pull request commentnode-webrtc/node-webrtc

Don't signal iceGatheringState complete if connection closed

Fixes #624

arlolra

comment created time in 23 days

PR opened node-webrtc/node-webrtc

Don't signal iceGatheringState complete if connection closed

Note that, although this adds a test, I didn't actually try running it :)

This only happens internal to node-webrtc, https://chromium.googlesource.com/external/webrtc/+/branch-heads/m79/pc/peer_connection.cc#4385

+18 -1

0 comment

2 changed files

pr created time in 23 days

create barncharlolra/node-webrtc

branch : I624

created branch time in 23 days

fork arlolra/node-webrtc

node-webrtc is a Node.js Native Addon that provides bindings to WebRTC M79

fork in 23 days

issue openednode-webrtc/node-webrtc

onicecandidate fires on pc.close

var wrtc = require('wrtc');

var RTCPeerConnection = wrtc.RTCPeerConnection;

var pc = new RTCPeerConnection({
	iceServers: [{ urls: ['stun:stun.l.google.com:19302'] }]
});

pc.onicecandidate = function (evt) {
	console.log(evt);
};

pc.close();

This doesn't seem to happen browsers.

created time in 23 days

delete branch arlolra/snowflake-webext

delete branch : T34140

delete time in 23 days

push eventarlolra/snowflake-webext

Arlo Breault

commit sha 6788592d492bc61324e48721b56fb671ba8639fb

Require semis Trac: 34140

view details

push time in 23 days

push eventarlolra/snowflake-webext

Arlo Breault

commit sha 0c2ab25864c803fbffe8bb23cfdcb0a01f93381c

Handle onicecandidate firing after connection closed This might just be an issue with node-webrtc but seems a harmless workaround. Trac: 34126

view details

push time in 23 days

delete branch arlolra/snowflake-webext

delete branch : onice

delete time in 23 days

delete branch arlolra/snowflake-webext

delete branch : T34128

delete time in 23 days

push eventarlolra/snowflake-webext

Arlo Breault

commit sha 5aa149724e66ace86a6a548c50f7800e8f772749

Add version meta tag to embed.html when building Trac: 34128

view details

push time in 23 days

create barncharlolra/snowflake-webext

branch : T34140

created branch time in 23 days

CommitCommentEvent

delete branch arlolra/snowflake-webext

delete branch : T34132

delete time in 23 days

push eventarlolra/snowflake-webext

Arlo Breault

commit sha 5f85f38954cfc4d5bd902c0359431c59c7165cbc

Add shebang for cl bin Trac: 34132

view details

push time in 23 days

create barncharlolra/snowflake-webext

branch : T34132

created branch time in 24 days

delete branch arlolra/snowflake-webext

delete branch : pub

delete time in 24 days

push eventarlolra/snowflake-webext

Arlo Breault

commit sha 68f9cf8fb2481d9116190b83d0303b38cf405b86

Bump package.json to match manifest.json Trac: 34127

view details

push time in 24 days

create barncharlolra/snowflake-webext

branch : T34128

created branch time in 24 days

create barncharlolra/snowflake-webext

branch : pub

created branch time in 24 days

create barncharlolra/snowflake-webext

branch : onice

created branch time in 24 days

created tagkeroserene/snowflake

tagwebext-0.2.2

WebRTC Pluggable Transport

created time in 24 days

created tagkeroserene/snowflake

tagwebext-0.2.1

WebRTC Pluggable Transport

created time in 24 days

push eventkeroserene/snowflake

David Fifield

commit sha c8293a5de315ddc5e212e0c894ebdc82a46ce1e1

Format the establishDataChannel error log message like other log messages. It was sticking out in the context of other log messages. 2020/04/30 22:39:10 WebRTC: DataChannel created. 2020/04/30 22:39:20 establishDataChannel: timeout waiting for DataChannel.OnOpen 2020/04/30 22:39:20 WebRTC: closing PeerConnection 2020/04/30 22:39:20 WebRTC: Closing 2020/04/30 22:39:20 WebRTC: WebRTC: Could not establish DataChannel Retrying in 10s...

view details

David Fifield

commit sha 7043a055f9fb0680281ecffd7d458a43f2ce65b5

Reduce DataChannelTimeout from 30s to 10s. https://bugs.torproject.org/34042

view details

push time in 24 days

created tagarlolra/snowflake-webext

tagwebext-0.3.0

forked from https://gitweb.torproject.org/pluggable-transports/snowflake-webext.git

created time in 24 days

push eventarlolra/snowflake-webext

Cecylia Bocovich

commit sha 4312865a6eeaed1dc81e141b1c103a4590e82d41

bump version to 0.3.0

view details

push time in 24 days

push eventkeroserene/snowflake

David Fifield

commit sha d376d7036bdee70797dbda50af34d5930d45dadd

Make WebRTCPeer and Peers not inherit the methods of BytesLogger. You would have been able to do, for example, snowflake.(*WebRTCPeer).AddInbound(...).

view details

David Fifield

commit sha 9a4e3e7bd97ba87255453a005b2a3474d1914621

Remove unused BytesSyncLogger.IsLogging.

view details

David Fifield

commit sha 2853fc93628bf997903de33cd7aebd1420e5975f

Make BytesSyncLogger's implementation details internal. Provide NewBytesSyncLogger that returns an opaque data structure. Automatically start up the logging loop goroutine in NewBytesSyncLogger.

view details

David Fifield

commit sha 73173cb6987dbf26fdb1036e4b7710c200f87141

Simplify BytesSyncLogger.

view details

David Fifield

commit sha 6c2e3adc41c2c6d1ed794adac019a5a6eb069536

Disable trickle ICE. https://bugs.torproject.org/33984 OnICEGatheringStateChange is no longer called when candidate gathering is complete. SetLocalDescription kicks off the gathering process. https://bugs.torproject.org/28942#comment:28 https://bugs.torproject.org/33157#comment:2

view details

David Fifield

commit sha 17c0d0ff82ccc0fad077ceb8ff8b20d580c56a24

Remove unused Resetter interface. WaitForReset is not used since 70126177fbdf5b1fa4977f2fc26f624641708098.

view details

David Fifield

commit sha 3520f4e8b96e05dfb30874ec2174457684269db6

Simplify Peers.Pop.

view details

David Fifield

commit sha 51bb49fa6f4ac7e01b19fd3136411a54a67a4ff6

Move pc.CreateOffer/pc.SetLocalDescription out of a goroutine. This allows us to remove the internal errorChannel.

view details

David Fifield

commit sha d9b076c32eed106a382a19bda973a9616cc44501

Don't do a separate check for a short write. A short write will result in a non-nil error. It's an io.PipeWriter anyway, which blocks until all the data has been read or the read end is closed, in which case it returns io.ErrClosedPipe if not some other error.

view details

David Fifield

commit sha 76732155e7d730573b3ced62209e4e1e4ead511c

Remove `Snowflake` interface, use `*WebRTCPeer` directly. The other interfaces in client/lib/interfaces.go exist for the purpose of running tests, but not Snowflake. Existing code would not have worked with other types anyway, because it does unchecked .(*WebRTCPeer) conversions.

view details

David Fifield

commit sha b48fb781ee15cf033efc61496746a295dc0d63c7

Have util.{Serialize,Deserialize}SessionDescription return an error https://bugs.torproject.org/33897#comment:4

view details

David Fifield

commit sha 32207d6f06c9254b3229f8e3161b80fd7f5df645

Eliminate separate WebRTCPeer.Connect method. Do it as a side effect of NewWebRTCPeer. Remove WebRTCPeer tests as they currently require invasively modifying internal fields at different stages of construction.

view details

David Fifield

commit sha 8caa737700d282dc7b174b4df3e514cc02bb0386

Remove SnowflakeDataChannel interface. Use *webrtc.DataChannel directly.

view details

David Fifield

commit sha 5787d5b8b0a78a27a12385fbeea7bb12f5b11fb1

Simplify WebRTCPeer.exchangeSDP. No need to run sendOfferToBroker in a goroutine.

view details

David Fifield

commit sha 81d14ad33a21ac487cefb2912a32a72a7cc8ee39

Make WebRTCPeer.preparePeerConnection block. Formerly, preparePeerConnection set up a callback that sent into a channel, and exchangeSDP waited until it could receive from the channel. We can move the channel entirely into preparePeerConnection (having it not return until the callback has been called) and that way remove some shared state.

view details

David Fifield

commit sha 8295c87fbe4a3fb0d9e6c5fb04f6f0a52573faaf

Make preparePeerConnection a standalone function.

view details

David Fifield

commit sha 85277274fd3020819fe5c556b8164e7671bb799b

Make exchangeSDP into a standalone function.

view details

David Fifield

commit sha e8c41650ae44e300aabe57e361c445808635fb4f

Move establishDataChannel to after exchangeSDP.

view details

David Fifield

commit sha 047d3214bfb46de07e5d9f223e4fb1ba24584c8a

Wait for data channel OnOpen before returning from NewWebRTCPeer. Now callers cannot call Write without there being a DataChannel to write to. This lets us remove the internal buffer and checks for transport == nil. Don't set internal fields like writePipe, transport, and pc to nil when closing; just close them and let them return errors if further calls are made on them. There's now a constant DataChannelTimeout that's separate from SnowflakeTimeout (the latter is what checkForStaleness uses). Now we can set DataChannel timeout to a lower value, to quickly dispose of unconnectable proxies, while still keeping the threshold for detecting the failure of a once-working proxy at 30 seconds. https://bugs.torproject.org/33897

view details

Cecylia Bocovich

commit sha 1d2df3cd719cc6074880ed7f6a39f9eae535dee1

Update calls to session description utils in proxy

view details

push time in a month

delete branch keroserene/snowflake

delete branch : retry

delete time in a month

push eventarlolra/snowflake-webext

Arlo Breault

commit sha 58406af560b78a807fd6dc70087c07157cf54eef

Remove proxy/ prefix from .gitignore

view details

push time in a month

create barncharlolra/snowflake-webext

branch : retry

created branch time in a month

push eventarlolra/snowflake-webext

Arlo Breault

commit sha 11f3d871f34ccb0ab732ac943ac7af6416830a3b

Move getMessage inside missingFeature

view details

Arlo Breault

commit sha dc9d4fab26e788f6a4b5bd4f3cf40f2a31b3a78a

Refactor popup on/off to be shared between webext and badge

view details

Arlo Breault

commit sha 2ba8f859afbfb5259c6c3a830eb94fb3d536f351

Add a button to retry probe Trac: 33365 Trac: 33112

view details

push time in a month

CommitCommentEvent

push eventarlolra/snowflake-webext

Cecylia Bocovich

commit sha 4d59bcbb4deace2e7acc5f4aaabde7da3f91884b

Update node wrtc version for web proxies

view details

Cecylia Bocovich

commit sha d05041a24a1bc0c87f7c00a018f27cb7238f8d91

bump version to 0.2.3

view details

Cecylia Bocovich

commit sha 4c28d98f04fb91dea2cd47aa6be2ac7ae286f2ea

Move proxy datachannel timeout value to config

view details

Cecylia Bocovich

commit sha c283c35a7e128d72763b7f4a925103bd0b062227

Dynamically adjust proxy poll interval If the proxy succeeds in opening a datachannel to the client, decrease the poll interval. If they fail, increase the poll interval. This will cause less reliable/more restrictive proxies to poll less frequently.

view details

push time in a month

push eventarlolra/snowflake-webext

Cecylia Bocovich

commit sha 03d7dd26d419bc4441e3eb06c11e1813bc8e9b3c

Remove all Go pieces This repository is for the web proxy only

view details

Cecylia Bocovich

commit sha 712def7a62a0ce0276782131be7df8216efa66d6

Move proxy code to top level directory

view details

Cecylia Bocovich

commit sha 6b4ec94becd1ef51f7823115edaa359ce9a9f67b

Update .travis.yml and CONTRIBUTING.md Remove the parts that apply only to the Go code and get CI working on the new directory structure.

view details

Cecylia Bocovich

commit sha 891b826c8eec3d357d60b8e59269101dd80e3eeb

Clean up .gitignore

view details

push time in a month

push eventkeroserene/snowflake

David Fifield

commit sha ee2fb42d33ea105995adfc84d2be47a9d6dfc97f

Immediately and unconditionally grant new SOCKS connections.

view details

David Fifield

commit sha 904af9cb8aa6aa25e094da1c025c7afed55d46ea

Let copyLoop exit when either direction finishes. Formerly we waiting until *both* directions finished. What this meant in practice is that when the remote connection ended, copyLoop would become useless but would continue blocking its caller until something else finally closed the socks connection.

view details

David Fifield

commit sha 222ab3d85a4113088db3e3b742411806922c028c

Import Turbo Tunnel support code. Copied and slightly modified from https://gitweb.torproject.org/pluggable-transports/meek.git/log/?h=turbotunnel&id=7eb94209f857fc71c2155907b0462cc587fc76cc https://github.com/net4people/bbs/issues/21 RedialPacketConn is adapted from clientPacketConn in https://dip.torproject.org/dcf/obfs4/blob/c64a61c6da3bf1c2f98221bb1e1af8a358f22b87/obfs4proxy/turbotunnel_client.go https://github.com/net4people/bbs/issues/14#issuecomment-544747519

view details

David Fifield

commit sha 70126177fbdf5b1fa4977f2fc26f624641708098

Turbo Tunnel client and server. The client opts into turbotunnel mode by sending a magic token at the beginning of each WebSocket connection (before sending even the ClientID). The token is just a random byte string I generated. The server peeks at the token and, if it matches, uses turbotunnel mode. Otherwise, it unreads the token and continues in the old one-session-per-WebSocket mode.

view details

David Fifield

commit sha 0790954020b550f5d5351d9e54b108c9d357fa50

USERADDR support for turbotunnel sessions. The difficulty here is that the whole point of turbotunnel sessions is that they are not necessarily tied to a single WebSocket connection, nor even a single client IP address. We use a heuristic: whenever a WebSocket connection starts that has a new ClientID, we store a mapping from that ClientID to the IP address attached to the WebSocket connection in a lookup table. Later, when enough packets have arrived to establish a turbotunnel session, we recover the ClientID associated with the session (which kcp-go has stored in the RemoteAddr field), and look it up in the table to get an IP address. We introduce a new data type, clientIDMap, to store the clientID-to-IP mapping during the short time between when a WebSocket connection starts and handleSession receives a fully fledged KCP session.

view details

David Fifield

commit sha 2022496d3b6fc76b7725135758c37d7d49546d3d

Use a global RedialPacketConn and smux.Session. This allows multiple SOCKS connections to share the available proxies, and in particular prevents a SOCKS connection from being starved of a proxy when the maximum proxy capacity is less then the number of the number of SOCKS connections. This is option 4 from https://bugs.torproject.org/33519.

view details

David Fifield

commit sha 2f52217d2f62e61a05ea265257d2229410f79732

Restore `go 1.13` to go.mod, lost in the turbotunnel merge.

view details

David Fifield

commit sha 65ecb798ca8842a431214c2aa5133620e576c5f3

Update a comment (no signal pipe anymore).

view details

push time in a month

push eventkeroserene/snowflake

Cecylia Bocovich

commit sha 6f89fc14f6aa8692b44dc71bd7b04cbe2cf20aa8

Remove proxy/translation submodule We're moving all web proxy code to another repository.

view details

Cecylia Bocovich

commit sha 51b0b7ed2e02b9444eebf75612d53c3a32301f6f

Remove proxy/ subdirectory We're moving all web proxy code to a different repsitory.

view details

Cecylia Bocovich

commit sha da01bf232385cd1ae57e818d955990ced478b5df

Remove web proxy instructions from README.md

view details

Cecylia Bocovich

commit sha 3ff04c3c65bef4f10ed33c037f77a95c3e550b78

Update .travis.yml for proxy/ code removal

view details

Cecylia Bocovich

commit sha 20180dcb041929c1ddd37106e6e74ff8c847f2ee

Rename proxy-go/ directory to proxy/ Now that the web proxies are in a different repository, no need to distinguish the two.

view details

Cecylia Bocovich

commit sha e9b218a65cf731d0cf50a8655602ea82e67c128e

Clean up .gitignore

view details

push time in a month

CommitCommentEvent

push eventarlolra/forksoid

James D. Forrester

commit sha 6cc2b705fc36e346b55e3cfe0500d0acbb7ec7cd

build: Upgrade eslint-config-wikimedia to current and make pass This is using a catastrophically old version of everything; that's fine, as most of this code is on its way out, but it's irritating. ;-) Change-Id: I7658acbca65ca611eed35cac8cf0764466f2be55

view details

push time in a month

push eventkeroserene/snowflake

Cecylia Bocovich

commit sha ea01bf41c3011590938b079ed96c7b35cb40588b

Change dummy address for snowflake This will prevent a bug where tor skips bandwidth events for local addresses (see https://bugs.torproject.org/33693)

view details

David Fifield

commit sha 237fed1151f900c08edf83441cb2edebf8743978

Update GitHub issue numbers to Trac ticket numbers.

view details

David Fifield

commit sha 8eef3b63482deb50d988e3703b7a718802cdd2f1

Remove uniuri dependency. https://bugs.torproject.org/33800

view details

push time in a month

push eventkeroserene/snowflake

Arlo Breault

commit sha 90c3406a4ec7867e671ea6f156e20aebe9051939

Retry probe once a day Trac: 33365 Trac: 33112

view details

push time in a month

create barncharlolra/snowflake-webext

branch : master

created branch time in a month

created repositoryarlolra/snowflake-webext

forked from https://gitweb.torproject.org/snowflake-webext.git/

created time in a month

pull request commentcohosh/snowflake-webext

Ticket/33593

Some cleanup can happen in the .gitignore

cohosh

comment created time in a month

pull request commentcohosh/snowflake

Ticket/33593

The readme still mentions,

Proxy:

JavaScript

and,

cd proxy-go
go build
./proxy-go

The .gitignore has a bunch unnecessary cruft still.

cohosh

comment created time in a month

create barnchkeroserene/snowflake

branch : retry

created branch time in a month

create barncharlolra/forksoid

branch : audit

created branch time in 2 months

push eventarlolra/forksoid

push time in 2 months

push eventarlolra/forksoid

Arlo Breault

commit sha bb2b4a7a6f7b411abc8eed4f797a028c59383d1d

npm update marked --depth 2 To resolve the alert from WhiteSource, https://github.com/wikimedia/parsoid/network/alert/package-lock.json/marked/closed And then `npm audit fix` to update jsdoc for, https://www.npmjs.com/advisories/812 This is all in dev dependencies. Bug: T248208 Change-Id: Ic5a2d7e36de0337b7f9f6fa301509736d2994147

view details

push time in 2 months

fork arlolra/parsoid

This is a mirror from https://gerrit.wikimedia.org. See https://www.mediawiki.org/wiki/Developer_access for contributing.

https://www.mediawiki.org/wiki/Parsoid

fork in 2 months

delete branch wikimedia/parsoid

delete branch : T227209

delete time in 2 months

delete branch wikimedia/parsoid

delete branch : deploy-2020-01-21

delete time in 2 months

delete branch wikimedia/parsoid

delete branch : deploy-20200213

delete time in 2 months

delete branch keroserene/snowflake

delete branch : lan

delete time in 2 months

push eventkeroserene/snowflake

Arlo Breault

commit sha 670e4ba4380b3fa5cf82043559dcb8c2ca790a7d

Move StripLocalAddresses to a common util Trac: 19026

view details

Arlo Breault

commit sha 1867f89562fb25bf9a3c2172a7b6f0a198c81adb

Remove local LAN address ICE candidates in proxy-go answer Trac: 19026

view details

push time in 2 months

create barnchkeroserene/snowflake

branch : lan

created branch time in 2 months

delete branch keroserene/snowflake

delete branch : unsafe

delete time in 2 months

push eventkeroserene/snowflake

Arlo Breault

commit sha f58c865d82fa5d3670c1df9a587d61450aeb664b

Add unsafe logging

view details

Arlo Breault

commit sha 5fa757865507e340b6117c784e4ac0bd88ac7858

Rename logToStateDir/keepLocalAddresses to kebab case https://en.wikipedia.org/wiki/Letter_case#Special_case_styles

view details

push time in 2 months

push eventkeroserene/snowflake

Cecylia Bocovich

commit sha e521a7217a0888dbb893c64636e841244bbc56c3

Update license

view details

push time in 2 months

push eventkeroserene/snowflake

David Fifield

commit sha 380b133155ad725126bc418d0e66b3c550b4c555

Close internal Pipes in websocketconn.Conn Close. Unless something externally called Write after Close, the writeLoop(ws, pr2) goroutine would run forever, because nothing would ever close pw2/pr2. https://bugs.torproject.org/33367#comment:4

view details

David Fifield

commit sha c124e8c643f2de5730af9079d326b9cabc3b264a

In server, treat a client IP address of 0.0.0.0 as missing. Some proxies currently send ?client_ip=0.0.0.0 because of an error in how they attempt to grep the address from the client's SDP. That's inflating our "%d/%d connections had client_ip" logs. Instead, treat these cases as if the IP address were absent. https://bugs.torproject.org/33157 https://bugs.torproject.org/33385

view details

David Fifield

commit sha c2a12c25d1dd740b055aff736379a4a0c45b51d6

Update appengine for the Go 1.11 runtime. https://cloud.google.com/appengine/docs/standard/go111/go-differences This is untested, because I wasn't actually able to deploy without enabling Cloud Build and setting up a billing account.

view details

Cecylia Bocovich

commit sha 2e9e8071787398d9713395d94d93b5427ac8d452

Remove unecessary log messages Ever since we started scrubbing log messages, with the help of regexes for https://bugs.torproject.org/21304 logging has become more CPU intensive due to our use of regular expressions. Logging the byte count of every incoming and outgoing message at the proxy-go instances was taking up a lot of CPU and contrubuting to the high CPU usage seen in https://bugs.torproject.org/33211.

view details

David Fifield

commit sha 125e71fa6ee27a929438dafc82bba1ddc0172814

Remove the now-unused appengine directory. https://bugs.torproject.org/33429

view details

Cecylia Bocovich

commit sha 03315dde029d37d93f894c6ae4932851fd1460a1

bump version to 0.2.2

view details

Cecylia Bocovich

commit sha 920f6791f3ec8e7467c43ee0cefffe63200bed2b

Add a go.mod and go.sum for snowflake

view details

Cecylia Bocovich

commit sha 58b52eb9f7987789d8e90a982a6df16013e200dd

Remove go get commands from travis.yml We no longer need standalone get commands now that we are using go modules.

view details

Cecylia Bocovich

commit sha 6054c09949dfeb807a898e369c546344e26373dd

Remove the abandoned server-webrtc test code This existed solely for testing purposes and is no longer being maintained.

view details

Cecylia Bocovich

commit sha c11461d3391febd62ba5f7fb5517aa65dbcf5c59

Update go.mod and go.sum

view details

Arlo Breault

commit sha d10af300c128955599aefabba10ac8db7027e063

Refactor (De)SerializeSessionDescription as common utils

view details

Arlo Breault

commit sha 7d15422ae0acbe27dafcefea6c7287a68788ba92

Add unsafe logging

view details

Arlo Breault

commit sha b2bce35877d430cde83e6e33d5630fd35d117c6c

Rename logToStateDir/keepLocalAddresses to kebab case https://en.wikipedia.org/wiki/Letter_case#Special_case_styles

view details

push time in 2 months

delete branch keroserene/snowflake

delete branch : util

delete time in 2 months

push eventkeroserene/snowflake

Arlo Breault

commit sha d10af300c128955599aefabba10ac8db7027e063

Refactor (De)SerializeSessionDescription as common utils

view details

push time in 2 months

push eventkeroserene/snowflake

Cecylia Bocovich

commit sha 6054c09949dfeb807a898e369c546344e26373dd

Remove the abandoned server-webrtc test code This existed solely for testing purposes and is no longer being maintained.

view details

Cecylia Bocovich

commit sha c11461d3391febd62ba5f7fb5517aa65dbcf5c59

Update go.mod and go.sum

view details

push time in 2 months

Pull request review commentcohosh/snowflake

Use pion/webrtc for server-webrtc test code

 func receiveSignalsHTTP(addr string, config *webrtc.Configuration) error { 	log.Printf("listening HTTP on %s", addr) 	return http.ListenAndServe(addr, nil) }++func deserializeSessionDescription(msg string) *webrtc.SessionDescription {

I took a stab at this here, https://github.com/keroserene/snowflake/commit/7b761d4c8d0e56b9148f106eb01667a7ec5c0424

cohosh

comment created time in 2 months

create barnchkeroserene/snowflake

branch : util

created branch time in 2 months

pull request commentcohosh/snowflake

Remove the abandoned server-webrtc test code

👍

cohosh

comment created time in 2 months

Pull request review commentcohosh/snowflake

Use pion/webrtc for server-webrtc test code

 func receiveSignalsHTTP(addr string, config *webrtc.Configuration) error { 	log.Printf("listening HTTP on %s", addr) 	return http.ListenAndServe(addr, nil) }++func deserializeSessionDescription(msg string) *webrtc.SessionDescription {

Sounds good

cohosh

comment created time in 2 months

pull request commentcohosh/snowflake

Remove the abandoned server-webrtc test code

Looks like the main README needs some cleaning up as well, https://github.com/keroserene/snowflake#---testing-directly-via-webrtc-server---

cohosh

comment created time in 2 months

Pull request review commentcohosh/snowflake

Use pion/webrtc for server-webrtc test code

 func receiveSignalsHTTP(addr string, config *webrtc.Configuration) error { 	log.Printf("listening HTTP on %s", addr) 	return http.ListenAndServe(addr, nil) }++func deserializeSessionDescription(msg string) *webrtc.SessionDescription {

This code will now live in three places: client/lib/util.go, proxy-go/snowflake.go, and here. Maybe it belongs under common/?

cohosh

comment created time in 2 months

push eventkeroserene/snowflake

David Fifield

commit sha 380b133155ad725126bc418d0e66b3c550b4c555

Close internal Pipes in websocketconn.Conn Close. Unless something externally called Write after Close, the writeLoop(ws, pr2) goroutine would run forever, because nothing would ever close pw2/pr2. https://bugs.torproject.org/33367#comment:4

view details

David Fifield

commit sha c124e8c643f2de5730af9079d326b9cabc3b264a

In server, treat a client IP address of 0.0.0.0 as missing. Some proxies currently send ?client_ip=0.0.0.0 because of an error in how they attempt to grep the address from the client's SDP. That's inflating our "%d/%d connections had client_ip" logs. Instead, treat these cases as if the IP address were absent. https://bugs.torproject.org/33157 https://bugs.torproject.org/33385

view details

David Fifield

commit sha c2a12c25d1dd740b055aff736379a4a0c45b51d6

Update appengine for the Go 1.11 runtime. https://cloud.google.com/appengine/docs/standard/go111/go-differences This is untested, because I wasn't actually able to deploy without enabling Cloud Build and setting up a billing account.

view details

Cecylia Bocovich

commit sha 2e9e8071787398d9713395d94d93b5427ac8d452

Remove unecessary log messages Ever since we started scrubbing log messages, with the help of regexes for https://bugs.torproject.org/21304 logging has become more CPU intensive due to our use of regular expressions. Logging the byte count of every incoming and outgoing message at the proxy-go instances was taking up a lot of CPU and contrubuting to the high CPU usage seen in https://bugs.torproject.org/33211.

view details

David Fifield

commit sha 125e71fa6ee27a929438dafc82bba1ddc0172814

Remove the now-unused appengine directory. https://bugs.torproject.org/33429

view details

Cecylia Bocovich

commit sha 03315dde029d37d93f894c6ae4932851fd1460a1

bump version to 0.2.2

view details

Cecylia Bocovich

commit sha 920f6791f3ec8e7467c43ee0cefffe63200bed2b

Add a go.mod and go.sum for snowflake

view details

Cecylia Bocovich

commit sha 58b52eb9f7987789d8e90a982a6df16013e200dd

Remove go get commands from travis.yml We no longer need standalone get commands now that we are using go modules.

view details

push time in 2 months

push eventkeroserene/go-webrtc

David Fifield

commit sha 6a5742e01c3a5133c901f182cf8cdf4812212327

Note that the repo is no longer maintained in README.md. Closes #109.

view details

push time in 3 months

issue closedkeroserene/go-webrtc

Archive/deprecate this repo?

The reason for creating go-webrtc was to support the development of Snowflake. But since October 2019, Snowflake no longer uses go-webrtc, instead using pion/webrtc. That means the maintainers of go-webrtc are no longer paying much attention to it.

Should we archive this repo, or add a note that it is no longer actively maintained? Hand over maintainership to someone else? As evidenced by the issues page, there are uses besides Snowflake; what would they like to see happen?

closed time in 3 months

uumaro

push eventarlolra/envisa

Arlo Breault

commit sha 5341109dde854a7f4ffbb9960c46cafb8c7d324a

Add spec

view details

push time in 3 months

create barncharlolra/envisa

branch : master

created branch time in 3 months

created repositoryarlolra/envisa

created time in 3 months

more