profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/aplaice/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

anki-geo/ultimate-geography 359

Geography flashcard deck for Anki

aplaice/chromium-vim 1

Unofficial, pre-pre-alpha port of chromium-vim to Firefox

aplaice/DeDRM_tools 1

DeDRM tools for ebooks

aplaice/anki 0

Anki for desktop computers

aplaice/anki-addons-misc 0

Various add-ons I've written for Anki

aplaice/anki-dm 0

Anki Deck Manager

aplaice/anki-ultimate-geography 0

Geography flashcard deck for Anki

aplaice/brain-brew 0

Automated Anki flashcard creation and extraction to/from Csv

release streetcomplete/StreetComplete

v32.2

released time in a day

issue closedStvad/CrowdAnki

Error on Import

Hello,

i have a Problem with importing a existing Anki deck from Github or from Disk.

I have the deck from here: Deck

When i try to import it i get this exception:

Fehler
Es ist ein Fehler aufgetreten. Bitte starten Sie Anki neu und halten Sie während des Startvorgangs die Umschalttaste gedrückt, damit Anki die installierten Erweiterungen temporär deaktiviert.
Wenn das Problem nur auftritt, wenn die Erweiterungen aktiviert sind, dann benutzen Sie bitte den Menueintrag Extras > Erweiterungen um die problembehaftete Erweiterung durch selektives Deaktivieren herauszufinden.
Wenn Sie die entsprechende Erweiterung herausgefunden haben, dann bitten wir, dass Sie sich mit einem entsprechenden Problembericht an die Support-Seite für Erweiterungen wenden, damit der Fehler behoben werden kann.
Debuginformationen:
Anki 2.1.40 (cf446733) Python 3.8.1 Qt 5.15.1 PyQt 5.15.1
Platform: Linux
Flags: frz=True ao=True sv=2
Add-ons, last update check: 2021-06-08 16:56:43
Möglicherweise beteiligte Erweiterungen: ⁨CrowdAnki JSON exportimport Edit history Collaborate on deck creation⁩

Caught exception:
Traceback (most recent call last):
  File "/home/user/.local/share/Anki2/addons21/1788670778/anki/ui/action_vendor.py", line 31, in <lambda>
    lambda: AnkiJsonImporter.import_deck(self.window.col, self.directory_vendor))
  File "/home/user/.local/share/Anki2/addons21/1788670778/importer/anki_importer.py", line 114, in import_deck
    AnkiJsonImporter.import_deck_from_path(collection, Path(directory_path))
  File "/home/user/.local/share/Anki2/addons21/1788670778/importer/anki_importer.py", line 103, in import_deck_from_path
    if importer.load_deck(directory_path):
  File "/home/user/.local/share/Anki2/addons21/1788670778/importer/anki_importer.py", line 41, in load_deck
    deck.save_to_collection(self.collection, import_config=import_config)
  File "/home/user/.local/share/Anki2/addons21/1788670778/representation/deck.py", line 131, in save_to_collection
    self.save_decks_and_notes(collection=collection,
  File "/home/user/.local/share/Anki2/addons21/1788670778/representation/deck.py", line 154, in save_decks_and_notes
    note.save_to_collection(collection, self, model_map_cache, import_config=import_config)
  File "/home/user/.local/share/Anki2/addons21/1788670778/representation/note.py", line 115, in save_to_collection
    self.handle_import_config_changes(import_config, note_model)
  File "/home/user/.local/share/Anki2/addons21/1788670778/representation/note.py", line 131, in handle_import_config_changes
    if import_config.is_personal_field(note_model.anki_dict['name'], note_model.anki_dict['flds'][num]['name']):
IndexError: list index out of range

I tried a few work arounds from other solutions like #121 but could not make any progress. Is there any way to fix this on my end?

Thanks for your help and the great work!

closed time in 15 days

caplett

issue commentStvad/CrowdAnki

Error on Import

I found a fix for this case. It seems like it was also error in how the deck was exported. A NoteType was missing and cards were wrongly labeld as another note type.

I fixed it by manual cleaning the deck.json. As far as i understand it this issue is known so i close this issue here.

caplett

comment created time in 15 days

issue openedStvad/CrowdAnki

Error on Import

Hello,

i have a Problem with importing a existing Anki deck from Github or from Disk.

I have the deck from here: Deck

When i try to import it i get this exception: ` Fehler Es ist ein Fehler aufgetreten. Bitte starten Sie Anki neu und halten Sie während des Startvorgangs die Umschalttaste gedrückt, damit Anki die installierten Erweiterungen temporär deaktiviert. Wenn das Problem nur auftritt, wenn die Erweiterungen aktiviert sind, dann benutzen Sie bitte den Menueintrag Extras > Erweiterungen um die problembehaftete Erweiterung durch selektives Deaktivieren herauszufinden. Wenn Sie die entsprechende Erweiterung herausgefunden haben, dann bitten wir, dass Sie sich mit einem entsprechenden Problembericht an die Support-Seite für Erweiterungen wenden, damit der Fehler behoben werden kann. Debuginformationen: Anki 2.1.40 (cf446733) Python 3.8.1 Qt 5.15.1 PyQt 5.15.1 Platform: Linux Flags: frz=True ao=True sv=2 Add-ons, last update check: 2021-06-08 16:56:43 Möglicherweise beteiligte Erweiterungen: ⁨CrowdAnki JSON exportimport Edit history Collaborate on deck creation⁩

Caught exception: Traceback (most recent call last): File "/home/user/.local/share/Anki2/addons21/1788670778/anki/ui/action_vendor.py", line 31, in <lambda> lambda: AnkiJsonImporter.import_deck(self.window.col, self.directory_vendor)) File "/home/user/.local/share/Anki2/addons21/1788670778/importer/anki_importer.py", line 114, in import_deck AnkiJsonImporter.import_deck_from_path(collection, Path(directory_path)) File "/home/user/.local/share/Anki2/addons21/1788670778/importer/anki_importer.py", line 103, in import_deck_from_path if importer.load_deck(directory_path): File "/home/user/.local/share/Anki2/addons21/1788670778/importer/anki_importer.py", line 41, in load_deck deck.save_to_collection(self.collection, import_config=import_config) File "/home/user/.local/share/Anki2/addons21/1788670778/representation/deck.py", line 131, in save_to_collection self.save_decks_and_notes(collection=collection, File "/home/user/.local/share/Anki2/addons21/1788670778/representation/deck.py", line 154, in save_decks_and_notes note.save_to_collection(collection, self, model_map_cache, import_config=import_config) File "/home/user/.local/share/Anki2/addons21/1788670778/representation/note.py", line 115, in save_to_collection self.handle_import_config_changes(import_config, note_model) File "/home/user/.local/share/Anki2/addons21/1788670778/representation/note.py", line 131, in handle_import_config_changes if import_config.is_personal_field(note_model.anki_dict['name'], note_model.anki_dict['flds'][num]['name']): IndexError: list index out of range `

I tried a few work arounds from other solutions like #121 but could not make any progress. Is there any way to fix this on my end?

Thanks for your help and the great work!

created time in 15 days

Pull request review commentStvad/CrowdAnki

Avoid storing `deck_config_uuid` in Anki db and deal with fallout

 def _load_deck_config(self):         new_config = DeckConfig.from_collection(self.collection, self.anki_dict["conf"])         self.deck_config_uuid = new_config.get_uuid() +        # TODO Remove this once enough time has passed that #106/#116

also - does this actually help? would we write an updated version of the dict to db?

aplaice

comment created time in 17 days

Pull request review commentStvad/CrowdAnki

Avoid storing `deck_config_uuid` in Anki db and deal with fallout

 def _load_deck_config(self):         new_config = DeckConfig.from_collection(self.collection, self.anki_dict["conf"])         self.deck_config_uuid = new_config.get_uuid() +        # TODO Remove this once enough time has passed that #106/#116

create a separate issue to track this?

aplaice

comment created time in 17 days

Pull request review commentStvad/CrowdAnki

Prevent crash when trying to export all decks

 def warning(self, title: str, message: str):     def error(self, title: str, message: str):         pass +def run_closure_in_main(closure):+    """Run the closure in the main thread.++This is necessary, because GUI operations in a background thread cause+a crash.  For instance, export is now run in a background thread.++    """+    if aqt.mw.inMainThread():+        closure()+    else:+        aqt.mw.taskman.run_on_main(lambda: aqt.mw.progress.timer(50, closure, False))

Thanks for diving deeper on this!

aplaice

comment created time in 19 days

push eventStvad/CrowdAnki

Adam Plaice

commit sha 578a83503b8290d7cfc982556bcbe3ec43734532

Prevent crash when trying to export all decks The crash was caused by the warning dialog, itself! The issue was that export is now run in a background thread, but GUI operations from a background thread cause a crash. AnkiModalNotifier is used in `anki_exporter_wrapper.py` and `github_importer.py`. The former is in a background thread, the latter in the main thread. In both cases, error messages are now correctly displayed, without crashing. Tested on Anki 2.1.40 and 2.1.43.

view details

Adam Plaice

commit sha b7cb5715bf01667e2ba7fc2a052f78f7932f2467

Try to run the notifier closure immediately The attempted run times (in ms) will be (0, 100, 200, 300). A timeout of 0 does not seem to be used anywhere in the main Anki codebase, but is valid: https://doc.qt.io/qt-5/qtimer.html#details

view details

Vlad Sitalo

commit sha b25eace61c2ddbc4dad078b83093b291581c0d87

Merge pull request #129 from aplaice/crashing_export_all_decks Prevent crash when trying to export all decks

view details

push time in 19 days

PR merged Stvad/CrowdAnki

Prevent crash when trying to export all decks

Fix #128.

The crash was caused by the warning dialog, itself! The issue was that export is now run in a background thread, but GUI operations from a background thread cause a crash.

AnkiModalNotifier is used in anki_exporter_wrapper.py and github_importer.py. The former is in a background thread, the latter in the main thread. In both cases, error messages are now correctly displayed, without crashing.

Tested on Anki 2.1.40 and 2.1.43.

For comparison / a similar issue see.

I'm not very happy about the solution — particularly the timer — but without the timer run_on_main results in some sort of weird deadlock and I can't think of a better method.

+15 -3

2 comments

1 changed file

aplaice

pr closed time in 19 days

issue closedStvad/CrowdAnki

Trying to export all decks crashes Anki

To reproduce:

  1. Try to export all decks (File > Export > CrowdAnki JSON representation > Export...).

Expected behaviour:

Export fails with an error message.

Actual behaviour:

Anki crashes.

closed time in 19 days

aplaice

Pull request review commentStvad/CrowdAnki

Prevent crash when trying to export all decks

 def warning(self, title: str, message: str):     def error(self, title: str, message: str):         pass +def run_closure_in_main(closure):+    """Run the closure in the main thread.++This is necessary, because GUI operations in a background thread cause+a crash.  For instance, export is now run in a background thread.++    """+    if aqt.mw.inMainThread():+        closure()+    else:+        aqt.mw.taskman.run_on_main(lambda: aqt.mw.progress.timer(50, closure, False))

or, actually what does that number signify? (I initially assumed - delay)

aplaice

comment created time in 20 days

pull request commentStvad/CrowdAnki

Prevent crash when trying to export all decks

hey, apologies for the delay getting back to this. have some big changes in life that I'm focusing on. should be able to review both your PR's now though!

aplaice

comment created time in 20 days

Pull request review commentStvad/CrowdAnki

Prevent crash when trying to export all decks

 def warning(self, title: str, message: str):     def error(self, title: str, message: str):         pass +def run_closure_in_main(closure):+    """Run the closure in the main thread.++This is necessary, because GUI operations in a background thread cause+a crash.  For instance, export is now run in a background thread.++    """+    if aqt.mw.inMainThread():+        closure()+    else:+        aqt.mw.taskman.run_on_main(lambda: aqt.mw.progress.timer(50, closure, False))

any reason not to have 0 there?

aplaice

comment created time in 20 days

create barnchohare93/brain-brew

branch : dependabot/pip/urllib3-1.26.5

created branch time in 22 days

PR opened ohare93/brain-brew

Bump urllib3 from 1.26.4 to 1.26.5

Bumps urllib3 from 1.26.4 to 1.26.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>1.26.5</h2> <p>:warning: <strong>IMPORTANT: urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p> <ul> <li>Fixed deprecation warnings emitted in Python 3.10.</li> <li>Updated vendored <code>six</code> library to 1.16.0.</li> <li>Improved performance of URL parser when splitting the authority component.</li> </ul> <p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a></strong></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h2>1.26.5 (2021-05-26)</h2> <ul> <li>Fixed deprecation warnings emitted in Python 3.10.</li> <li>Updated vendored <code>six</code> library to 1.16.0.</li> <li>Improved performance of URL parser when splitting the authority component.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/d1616473df94b94f0f5ad19d2a6608cfe93b7cdf"><code>d161647</code></a> Release 1.26.5</li> <li><a href="https://github.com/urllib3/urllib3/commit/2d4a3fee6de2fa45eb82169361918f759269b4ec"><code>2d4a3fe</code></a> Improve performance of sub-authority splitting in URL</li> <li><a href="https://github.com/urllib3/urllib3/commit/2698537d52f8ff1f0bbb1d45cf018b118e91f637"><code>2698537</code></a> Update vendored six to 1.16.0</li> <li><a href="https://github.com/urllib3/urllib3/commit/07bed791e9c391d8bf12950f76537dc3c6f90550"><code>07bed79</code></a> Fix deprecation warnings for Python 3.10 ssl module</li> <li><a href="https://github.com/urllib3/urllib3/commit/d725a9b56bb8baf87c9e6eee0e9edf010034b63b"><code>d725a9b</code></a> Add Python 3.10 to GitHub Actions</li> <li><a href="https://github.com/urllib3/urllib3/commit/339ad34c677c98fd9ad008de1d8bbeb9dbf34381"><code>339ad34</code></a> Use pytest==6.2.4 on Python 3.10+</li> <li><a href="https://github.com/urllib3/urllib3/commit/f271c9c3149e20d7feffb6429b135bbb6c09ddf4"><code>f271c9c</code></a> Apply latest Black formatting</li> <li><a href="https://github.com/urllib3/urllib3/commit/1884878aac87ef0494b282e940c32c24ee917d52"><code>1884878</code></a> [1.26] Properly proxy EOF on the SSLTransport test suite</li> <li>See full diff in <a href="https://github.com/urllib3/urllib3/compare/1.26.4...1.26.5">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+29 -37

0 comment

1 changed file

pr created time in 22 days

pull request commentStvad/CrowdAnki

Bump urllib3 from 1.26.4 to 1.26.5

Kudos, SonarCloud Quality Gate passed!

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Bugs
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Vulnerabilities
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Security Hotspots
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' /> <img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' /> 0 Code Smells

<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' /> No Coverage information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' /> No Duplication information

dependabot[bot]

comment created time in 22 days

PR opened Stvad/CrowdAnki

Bump urllib3 from 1.26.4 to 1.26.5

Bumps urllib3 from 1.26.4 to 1.26.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>1.26.5</h2> <p>:warning: <strong>IMPORTANT: urllib3 v2.0 will drop support for Python 2</strong>: <a href="https://urllib3.readthedocs.io/en/latest/v2-roadmap.html">Read more in the v2.0 Roadmap</a></p> <ul> <li>Fixed deprecation warnings emitted in Python 3.10.</li> <li>Updated vendored <code>six</code> library to 1.16.0.</li> <li>Improved performance of URL parser when splitting the authority component.</li> </ul> <p><strong>If you or your organization rely on urllib3 consider supporting us via <a href="https://github.com/sponsors/urllib3">GitHub Sponsors</a></strong></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h2>1.26.5 (2021-05-26)</h2> <ul> <li>Fixed deprecation warnings emitted in Python 3.10.</li> <li>Updated vendored <code>six</code> library to 1.16.0.</li> <li>Improved performance of URL parser when splitting the authority component.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/d1616473df94b94f0f5ad19d2a6608cfe93b7cdf"><code>d161647</code></a> Release 1.26.5</li> <li><a href="https://github.com/urllib3/urllib3/commit/2d4a3fee6de2fa45eb82169361918f759269b4ec"><code>2d4a3fe</code></a> Improve performance of sub-authority splitting in URL</li> <li><a href="https://github.com/urllib3/urllib3/commit/2698537d52f8ff1f0bbb1d45cf018b118e91f637"><code>2698537</code></a> Update vendored six to 1.16.0</li> <li><a href="https://github.com/urllib3/urllib3/commit/07bed791e9c391d8bf12950f76537dc3c6f90550"><code>07bed79</code></a> Fix deprecation warnings for Python 3.10 ssl module</li> <li><a href="https://github.com/urllib3/urllib3/commit/d725a9b56bb8baf87c9e6eee0e9edf010034b63b"><code>d725a9b</code></a> Add Python 3.10 to GitHub Actions</li> <li><a href="https://github.com/urllib3/urllib3/commit/339ad34c677c98fd9ad008de1d8bbeb9dbf34381"><code>339ad34</code></a> Use pytest==6.2.4 on Python 3.10+</li> <li><a href="https://github.com/urllib3/urllib3/commit/f271c9c3149e20d7feffb6429b135bbb6c09ddf4"><code>f271c9c</code></a> Apply latest Black formatting</li> <li><a href="https://github.com/urllib3/urllib3/commit/1884878aac87ef0494b282e940c32c24ee917d52"><code>1884878</code></a> [1.26] Properly proxy EOF on the SSLTransport test suite</li> <li>See full diff in <a href="https://github.com/urllib3/urllib3/compare/1.26.4...1.26.5">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+102 -103

0 comment

1 changed file

pr created time in 22 days

create barnchStvad/CrowdAnki

branch : dependabot/pip/urllib3-1.26.5

created branch time in 22 days

push eventanki-geo/ultimate-geography

José Alberto Orejuela García

commit sha 576102a70cc06a4d3c24db5901b774799551eb9c

Improve flag similarities for Sudan and Palestine Co-authored-by: Adam Plaice <plaice.adam+github@gmail.com>

view details

José Alberto Orejuela García

commit sha 65fcfa68868dc445769eb9f931ab93dc9fa86088

Fix inconsistencies in flag similarities The inconsistencies were found in Norwegian Bokmål and Czech in flag similarities between Cameroon and Senegal.

view details

Axel Bocciarelli

commit sha 570b177582eb2571f4d295ae27c1c9330da28154

Merge pull request #432 from josealberto4444/master Better flag similarities between Sudan and Palestine

view details

push time in a month

issue closedanki-geo/ultimate-geography

Flag similarities between Sudan and Palestine

The flags:

Sudan Palestine
Sudan Palestine

The flag similarity field says:

  • Sudan (green arrow, red stripe)
  • Palestine (red arrow, green stripe)

So, when learning, when I saw the first of them (Palestine), I expected the Sudan flag to have red and green swapped. However, black stripe also changes position, so I find this hint a bit misleading. I'm not sure if it's just my problem, though, but I wanted to report it in case you think it should be improved.

I think a more useful hint would be this one (following Cameroon/Senegal):

  • Sudan (red/white/black, green arrow)
  • Palestine (black/white/green, red arrow)

closed time in a month

josealberto4444

PR merged anki-geo/ultimate-geography

Better flag similarities between Sudan and Palestine

Fixes #404

Wait a bit, don't merge it yet, please.

Ready to merge.

+4 -4

0 comment

1 changed file

josealberto4444

pr closed time in a month

pull request commentanki-geo/ultimate-geography

Add more flag similarities

@josealberto4444 I think the fix is pretty much ready to go. There's a couple of extra fields to fix, but seems easy-enough. Want to open a PR?

Done! ^^ #432

gaetjen

comment created time in a month

issue commentanki-geo/ultimate-geography

Flag similarities between Sudan and Palestine

Other fields to be made consistent:

Senegal (grønt, gult og rødt samt grønn stjerne) Kamerun (zelená/červená/žlutá), žlutá hvězda)

I guess this should be:

Senegal (grønn/gul/rød, grønn stjerne)
Kamerun (zelená/červená/žlutá, žlutá hvězda)

so I submitted #432 including this as well. ^^

josealberto4444

comment created time in a month

PR closed anki-geo/ultimate-geography

Add a link to a blank world map to desc.html

I found having a blank world map available extremely helpful for pointing at a physical map when being asked where a card is located. So I linked to one resource on wikimedia that is similar to the map in the deck

+2 -0

2 comments

1 changed file

whnr

pr closed time in a month

pull request commentanki-geo/ultimate-geography

Add a link to a blank world map to desc.html

I'm going to close this for now, sorry.

Hopefully this is a use case that our deck manager, BrainBrew, can support in the future. 🤞

whnr

comment created time in a month

pull request commentanki-geo/ultimate-geography

Add more flag similarities

I'll add a link to it in the contributing guide now.

... and, done! https://github.com/anki-geo/ultimate-geography/blob/master/CONTRIBUTING.md#flag-similarity-field -- Of course, feel free to edit the wiki page as you see fit @aplaice


Maybe this is a good opportunity for solving #404 as well? =)

@josealberto4444 I think the fix is pretty much ready to go. There's a couple of extra fields to fix, but seems easy-enough. Want to open a PR?

gaetjen

comment created time in a month

push eventanki-geo/ultimate-geography

Axel Bocciarelli

commit sha 813922c525ae39a4a401d140482055f5cb4b6053

Fix link to wiki page

view details

push time in a month

push eventanki-geo/ultimate-geography

Axel Bocciarelli

commit sha 82425dd072552e1d7b3c55d632e3c433baca3742

Link to "Flag similarities" wiki page from contributing guide

view details

push time in a month

pull request commentanki-geo/ultimate-geography

Add more flag similarities

@axelboc, should/could we have your amazing, extremely thorough categorisation copied somewhere better exposed and globally-editable or easily-commentable (such as a discussion or a Wiki page) and linked to from CONTRIBUTING.md? Having old decisions regarding what was/wasn't accepted and why, is often useful for reference.

Done! https://github.com/anki-geo/ultimate-geography/wiki/Flag-similarities - good call on the wiki page 💯 I'll add a link to it in the contributing guide now.

@aplaice can I please leave you to add the country pairs that you've newly audited? (With 🔨 or something next to the three similarities that will be added once this PR is merged, maybe?)


Hence, overall, I think that only the Slovak-Russian, Slovak-Slovenia and Palestine-Sahrawi Arab Democratic Republic similarities should be added.

@gaetjen can you please update the PR as per @aplaice's feedback? Once you're done, we'll work on the translations. Thanks! 🙌

gaetjen

comment created time in a month