profile
viewpoint

antoinetran/json-io 0

Convert Java to JSON. Convert JSON to Java. Pretty print JSON. Java JSON serializer.

antoinetran/kind 0

Kubernetes IN Docker - local clusters for testing Kubernetes

issue commentkubernetes/kubernetes

Add subPath(Expr) under volume for dynamic volume

Should we consider this is not in the scope of CSI, but to be done at each CSI level?

antoinetran

comment created time in a month

issue openedrancher/rancher

Missing port for firewall

<!-- Please search for existing issues first, then read https://rancher.com/docs/rancher/v2.x/en/contributing/#bugs-issues-or-questions to see what we expect in an issue For security issues, please email security@rancher.com instead of posting a public issue in GitHub. You may (but are not required to) use the GPG key located on Keybase. -->

What kind of request is this (question/bug/enhancement/feature request): enhancement

Steps to reproduce (least amount of steps as possible): For port 9796 error:

  1. deploys a cluster with rke
  2. deploys rancher as a single instance
  3. goes to the Web UI a. sets the admin password b. creates a cluster in web UI c. enable metrics (Prometheus)

Result: Look in Grafana: only one node sends the metrics. The reason is a missing port 9796 according to https://rancher.com/docs/rancher/v2.x/en/cluster-admin/tools/monitoring/prometheus/#node-exporter . However, this is not described in the prerequisites: https://rancher.com/docs/rke/latest/en/os/#ports I took a day to investigate why I didn't have any metrics.

Same thing with Calico port 179, although it is described in https://rancher.com/docs/rancher/v2.x/en/faq/networking/cni-providers/#calico

Same thing with port 53 for coredns: I don't know why this is needed but I can see in my firewall REJECT for udp 53 from pod CDIR to coredns CDIR. Although I don't know what is the impact, because I can still resolve services in my pods without this rule.

Other details that may be helpful:

Environment information

  • Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.4.3
  • Installation option (single install/HA): single install for Rancher, but 3 master and 7 workers for RKE

<!-- If the reported issue is regarding a created cluster, please provide requested info below -->

Cluster information

  • Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Hosted
  • Machine type (cloud/VM/metal) and specifications (CPU/memory): metal
  • Kubernetes version (use kubectl version):
kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.2", GitCommit:"59603c6e503c87169aea6106f57b9f242f64df89", GitTreeState:"clean", BuildDate:"2020-01-18T23:30:10Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.5", GitCommit:"e0fccafd69541e3750d460ba0f9743b90336f24f", GitTreeState:"clean", BuildDate:"2020-04-16T11:35:47Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
  • Docker version (use docker version):
Client: Docker Engine - Community
 Version:           19.03.5
 API version:       1.40
 Go version:        go1.12.12
 Git commit:        633a0ea
 Built:             Wed Nov 13 07:25:41 2019
 OS/Arch:           linux/amd64
 Experimental:      false

created time in a month

issue commentjirutka/ssh-ldap-pubkey

Ldap password bindpw cannot contain #

Can Ldap contain space as password? Is "password #" a valid password?

antoinetran

comment created time in a month

issue commentcheckstyle/checkstyle

ImportOrderCheck: separated=false not respected

Ok, after I looked at how to adapt CustomImportOrder to reproduce ImportOrder module... I discovered that this code:

		<module name="ImportOrder">
			<metadata name="net.sf.eclipsecs.core.comment" value="EUM-JCRule-680: Import order check" />
			<property name="ordered" value="false" />
			<property name="separated" value="false" />
		</module>

does absolutely nothing so I just removed it! And the workaround does not seem that hard to get so to my mind, ok for only the workaround. As for me, I removed this module.

jonmbake

comment created time in 2 months

issue commentcheckstyle/checkstyle

ImportOrderCheck: separated=false not respected

@jonmbake , please respond to support your issue.

if no respond till end of April I will close the issue.

Hi, I just want to add my two cents here since our project set separated=false for whatever reason, and share the Checkstyle configuration to our subcontractors. Now each time we change a shared configuration, it must undergo a review and there can be financial impacts (especially for a change from our initiative). Thus, making a breaking change like this without a retro-compatibility option is not great for us, because we either keep our old CheckStyle version or pay a cost of migration. We need to spend time in this CustomImportOrder to find a similar (exact?) behavior than before and in worst case pay our subcontractor for them to update the CheckStyle policy.

Thanks @RohanNagar for the example of CustomImportOrder!

jonmbake

comment created time in 2 months

issue commentrabbitmq/rabbitmq-server

badarith error for "rabbitmqctl await_startup"

Hi, this is just a workaround script for people like me that cannot upgrade Rabbitmq immediately (but in the future yes):

            rabbitmq_await() {
              # Workaround of https://github.com/rabbitmq/rabbitmq-server/issues/2158
              # TODO: remove this sleep if rabbitmq >= 3.8.2.
              while ! rabbitmqctl cluster_status &>/dev/null ; do
                sleep 2
              done
              echo "Rabbitmq ready!"
            }
sergey-safarov

comment created time in 3 months

issue commentmoosefs/moosefs-csi

sourceMountPath or subPath(Expr) for volumes

Hi, is this going to be added soon? Also, I can see "ext4", should we write the filesystem containing MooseFs chunks or do we always need to write that? Thank you.

antoinetran

comment created time in 3 months

pull request commentkubernetes-sigs/kind

[doc] Fix 1361 node label

TEST CLA

antoinetran

comment created time in 3 months

more