profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/amilajack/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Amila Welihinda amilajack @amzn San Francisco, CA https://amilajack.com Autodidact. Working on JS tooling. Lead maintainer @electron-react-boilerplate. Prev @uber @trulywireless @popsql https://twitter.com/amilajack

amilajack/alfred 42

A Modular Toolchain for JavaScript

amilajack/108 1

A minimal beat machine played in the browser.

amilajack/5to6-codemod 1

A collection of codemods that allow you to transform your js code from ES5 to ES6.

amilajack/ableton-live-redesign 1

Ableton Live Redesign. Read all about it here: http://nenadmilosevic.co/ableton-live-redesign/

amilajack/acorn 1

A small, fast, JavaScript-based JavaScript parser

amilajack/amilajack 1

my personal w̶e̶b̶s̶i̶t̶e̶ npm module

amilajack/adm-zip 0

A Javascript implementation of zip for nodejs. Allows user to create or extract zip files both in memory or to/from disk

amilajack/adsr-envelope-graph 0

React component that renders an ADSR envelope graph

amilajack/adsrnode 0

Advanced ADSR envelope node for WebAudio

amilajack/aframe 0

:a: web framework for building virtual reality experiences.

PullRequestReviewEvent

push eventtide-app/tide

Hamir Mahal

commit sha 12608f23234c71b7b7abb6e9a22eb2dcaf61d863

fix #325 by updating URL Cypress intercepts (#332)

view details

push time in 2 days

delete branch tide-app/tide

delete branch : fix/cypress-incorrect-pack-url

delete time in 2 days

PR merged tide-app/tide

Reviewers
fix #325 by updating URL Cypress intercepts bug infra testing

This pull request fixes #325 if we merge it.

In addition to fixing the URL Cypress intercepts, making packs sounds populate on sound pages, I added a test sound, and fixtures for it, to test that no pack list should appear when visiting a sound through the address bar if the sound does not have a pack.

+353 -3

0 comment

4 changed files

hamirmahal

pr closed time in 2 days

issue closedtide-app/tide

bug: Cypress is intercepting incorrect URL for pack sounds, causing pack sounds to not display in test runs

Cypress is intercepting https://freesound.org/apiv2/packs/26158/.

This is causing pack sounds not to appear in Cypress test runs, since that is not the URL this application uses to get pack sounds.

Screen Shot 2021-09-14 at 4 09 08 PM</details>

This application actually uses https://freesound.org/apiv2/packs/26158/? to request pack sounds.

Screen Shot 2021-09-14 at 4 14 16 PM

This should be a really easy fix: we just add a ? to https://freesound.org/apiv2/packs/26158/ to get https://freesound.org/apiv2/packs/26158/?, and Cypress should show pack sounds in our testing suite.

The reason our testing suite has been passing all along even with this bug present is because we never tested for the presence of pack sounds.

I'm happy to contribute the fix for this issue. I came across it when testing the pagination of pack sounds, and saw that the tests were failing not because of issues relating to the pagination feature, but because of the missing question mark, as described in this issue.

closed time in 2 days

hamirmahal
PullRequestReviewEvent

pull request commenttide-app/tide

close #333 by "un-skipping" skipped e2e test

Nice!

hamirmahal

comment created time in 2 days

delete branch tide-app/tide

delete branch : infra/un-skip-skipped-e2e-test

delete time in 2 days

push eventtide-app/tide

Hamir Mahal

commit sha 8e005073f3b75b32cac0c17d203154b97345d705

close #333 by "un-skipping" skipped e2e test (#334) * close #333 by "un-skipping" skipped e2e test * delete duplicate `search-results.json` intercept

view details

push time in 2 days

PR merged tide-app/tide

Reviewers
close #333 by "un-skipping" skipped e2e test infra testing

This pull request closes #333 if we merge it by removing .skip from an end-to-end test that we previously skipped.

The testing suite passes locally even after we stop skipping the test, and even with offline testing.

+1 -8

1 comment

1 changed file

hamirmahal

pr closed time in 2 days

issue closedtide-app/tide

infra: delete or "un-skip" skipped test in `cypress/integration/app_spec.ts`

We should either delete or not skip the skipped test in cypress/integration/app_spec.ts.

This issue is to help keep track of removing or "un-skipping" the skipped test.

Screen Shot 2021-09-24 at 8 05 26 AM

closed time in 2 days

hamirmahal
PullRequestReviewEvent

push eventamilajack/esm-dep-check

Rıdvan Altun

commit sha 22bae7caad6e77e082ff4b5849de625655c13dac

fix: check type property to detect esm usage

view details

Amila Welihinda

commit sha f491e3696a3a112ad8bc1c1bb771c2f954a2f742

Merge pull request #8 from ridvanaltun/master

view details

push time in 3 days

PR merged amilajack/esm-dep-check

fix: check type property to detect esm usage
+1 -1

0 comment

1 changed file

ridvanaltun

pr closed time in 3 days

PullRequestReviewEvent

startedbrunosimon/doom-portal-in-webgl

started time in 5 days

startedpacocoursey/writer

started time in 6 days

pull request commentelectron-react-boilerplate/electron-react-boilerplate

Load the `/` path, instead of `/index.html`

This change causes the packaged version of the boilerplate to fail

DhrumanGupta

comment created time in 7 days

PR closed electron-react-boilerplate/electron-react-boilerplate

Fix PORT env var not passed to webpack.config.renderer

This fixes a bug whereby changing the port from 1212 -> 4343 for example leads to errors such as: Failed to load resource: net::ERR_CONNECTION_REFUSED :1212/sockjs-node/info?t=1631071460786:1

In the electron browser console. Because it is still using port 1212.

+1 -1

1 comment

1 changed file

AustEcon

pr closed time in 7 days

pull request commentelectron-react-boilerplate/electron-react-boilerplate

Fix PORT env var not passed to webpack.config.renderer

Thanks for this! Closed in https://github.com/electron-react-boilerplate/electron-react-boilerplate/commit/aa60317066507871efcd47c250b1c896d0fcbb34

AustEcon

comment created time in 7 days

push eventelectron-react-boilerplate/electron-react-boilerplate

Amila Welihinda

commit sha aa60317066507871efcd47c250b1c896d0fcbb34

fix: use port env in dev renderer webpack config

view details

push time in 7 days

PullRequestReviewEvent

startedajitid/fzf-for-js

started time in 8 days

startedbevacqua/fuzzysearch

started time in 8 days

push eventamilajack/reading

Amila Welihinda

commit sha b73aeda463ddb6b0cad99158ca38291414e16f06

Added initial Books section to readme

view details

Amila Welihinda

commit sha c48ee6aa0a19edb176173860d534d1d7144e4b3d

Added Thou Shalt Not Depend on Me- Analysing the Use of Outdated JavaScript Libraries on the Web

view details

Amila Welihinda

commit sha 43140527711a0c35684babf5794b1fcfeabeb941

Added 'other sources of good reading'

view details

Amila Welihinda

commit sha 58e8e576f109502752a6cf05f06fa29ae8655138

Added new readings

view details

Amila Welihinda

commit sha 0f566039e4d67aa6fc06a981c2f1c8de82bf9e8a

Addd flow research paper to readings

view details

Connor Leech

commit sha 0aacc2a737df8a1ceb073e891bbde791aa2a55cc

add js data struc + algo book and add folders

view details

Connor Leech

commit sha fcd8b0b1c36cb29a84e3cff947093ae166cf082d

remove ds_store for great glory

view details

Amila Welihinda

commit sha e1088da6fd60ebdab0cff98da8168d0da746e031

Merge pull request #4 from connor11528/master group titles into folders

view details

Amila Welihinda

commit sha 7ae340eab74757175b5d886ae2d6d2da64da0054

Reorganized directory structure

view details

Amila Welihinda

commit sha 73c47fd1a23b0b32a6b5375fb1bda3d1d67f02d9

Added new papers

view details

Amila Welihinda

commit sha 54335bbb4c0fec736953183fc9335f522347aaf2

Added to PLT

view details

Amila Welihinda

commit sha bb833a62a8e4fc25eb040ef3ac6f898297235001

Added Type_Systems dir

view details

Amila Welihinda

commit sha 203aaf44a8595de30214417c1a4efcd2824b1925

Added "Formal Reasoning About Programs"

view details

Amila Welihinda

commit sha 0165fd763665de28b7fda3abf7f25b5cdec81f88

Added JaVert

view details

Amila Welihinda

commit sha 3c3fb1a6e25f6f48a50971e26c615cd1ac9cc5ce

Added GC reading and type system readings

view details

Amila Welihinda

commit sha b5dcbb86f0594d890409b881d055804bbd449095

Updated README

view details

Amila Welihinda

commit sha f5b7fc66e39dad3ae1f7ac1e5f65dd6f2841c78e

Added new AI_and_ML section

view details

Amila Welihinda

commit sha 9202de1528aa9434bbb58bcfe25789fbc96e8d45

Added Crypto and Math section

view details

Amila Welihinda

commit sha 7e0ec94803ba5226681907f42ac81eb47715f239

Added bitcoin books

view details

Amila Welihinda

commit sha 85cc80fe7867675b4997a614383c61663d557a21

Delete Operating Systems - Three Easy Pieces.pdf

view details

push time in 8 days

push eventamilajack/reading

Amila Welihinda

commit sha 17f6908e06844cb9a3571c18ae5aab384e7b134c

misc updates

view details

push time in 8 days

push eventelectron-react-boilerplate/electron-react-boilerplate

Boris Berman

commit sha 22dc101eb0c25424cd61465427b6a298d0afca07

Make use of previously created `isDevelopment` constant (#2981)

view details

push time in 9 days

PullRequestReviewEvent

push eventelectron-react-boilerplate/electron-react-boilerplate

chengxuncc

commit sha 45db9473e65e52403092b2a50188c32bc9a20320

fix native dependency installation instructions (#2967)

view details

push time in 9 days