Fixes

Thanks to @pankajk07 highlighting it here

:+1: Thank you!

Re-implementation of https://github.com/microsoft/monaco-typescript/pull/59 without the TS build changes

:+1: Looks very good! Thank you!

This PR adds support for XK_ISO_Level3_Shift and XK_ISO_Level5_Shift.

The AltGr key is mapped to XK_ISO_Level3_Shift in the default German keyboard layout (and others). The Neo keyboard layout (which is like a German Dvorak) and other layouts derived from it additionally use XK_ISO_Level5_Shift. Adding these might make it possible to fix some keyboard layout related bugs in VS Code, p.e. https://github.com/Microsoft/vscode/issues/24043, https://github.com/Microsoft/vscode/issues/23991 (at least for Linux).

The property withAltGr now depends on kLevel3KeyModifierMask (instead of kControlKeyModifierMask | kAltKeyModifierMask). This works for both the default German keyboard layout as well as for the Neo layout. Without this PR it doesn't work for Neo (see https://github.com/microsoft/vscode/issues/24043#issuecomment-612576998).

This PR also considers level 5 in the output. This is only important for layouts that use XK_ISO_Level5_Shift, like Neo.

I have added withLevel3Level5 as sixth property (instead of the expected withShiftLevel5) because the latter seems to have no relevance but the former corresponds layer 6 in the Neo keyboard layout.

This looks very good! Thank you! :heart:

@nnethery I looked at the CPU profile and I see something very bizzare around proxies / CAs:

Are you using some weird proxying ?

@connor4312 I cannot reproduce. Here is what I am doing:

• configure "extensions.webWorker": true
• create a file test.js with the content console.log(hello world!);
• put a breakpoint on the console statement
• press F5

I notice that the breakpoint is hit:

I don't really know, but one thing is interesting: we download extensions using the nodejs network stack and not curl. Perhaps there are some proxy settings that curl picks up which nodejs does not? Maybe the best to troubleshoot would be to have a small nodejs script that downloads something from the marketplace (like a well-known hard-coded extension) and prints if it downloaded it OK or not.

Issue Type: <b>Bug</b>

I have swapped escape and caps lock to make vim use more comfortable. In VS Code not all uses of the escape key work with the remapping. It seems like escape it's the editor that's broken.

Reproduction:

1. Run linux with KDE Plasma.
2. Go to System Settings > Input Devices > Keyboard > Advanced > Caps Lock Behaviour > Swap Esc and Caps Lock and check that box.

Some things that don't work:

• Escape to close an auto complete list.
• Escape to cancel a selection.
• Escape to cancel multiple cursors.

Some things that do work:

• Closing command palette
• Canceling creating a new file

Top of command Developer: Inspect Key Mappings

Layout info:
{
	"model": "pc86",
	"layout": "us,se",
	"variant": "dvp,svdvorak",
	"options": "caps:swapescape",
	"rules": "evdev"
}
isUSStandard: true

VS Code version: Code - OSS 1.47.2 (17299e413d5590b14ab0340ea477cdd86ff13daf, 2020-07-18T16:10:16.658Z) OS version: Linux x64 5.7.10-arch1-1

<details> <summary>System Info</summary>

</details> <!-- generated by issue reporter -->

@Leteesh Thank you for the extra information. So the following built-in extensions activate eagerly:

• vscode.debug-auto-launch
• vscode.emmet
• vscode.git
• vscode.github-authentication
• vscode.merge-conflict
• vscode.microsoft-authentication
• vscode.search-result
• vscode.github

Given you mention that there appear to be some trouble with git, I wonder if there is some kind of mix-up with your git.exe which might lead to the crash. Could you please go to the extensions viewlet, the type @builtin, then under Features look for the Git extension and disable it. Does the crash reproduce after disabling the builtin git extension?

I will try to set some time aside in August. I didn't look at it because the PR is marked as a draft. I thought that a "draft PR" represents work-in-progress and is not ready for review.

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. --> I tried to search 2-4 page for this issued but could not spot one so here is my request I would like insert {tab} key in the text when I am in Space Indent mode. I could suggest shortcut like Ctrl+Alt+T, Ctrl+Alt+T to trigger this. Or better, vscode could detect if current cursor is not at start of line then just intercepts tab key as is instead of translate to spaces

This is possible via keybindings. e.g.:

{ "key": "cmd+t", "command": "type", "args": { "text": "\t" }, "when": "editorTextFocus" },

Please let me know if you see this again if you find any steps.

Have you seen https://github.com/microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-linux-keybindings , specifically:

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Bumps jquery from 3.4.1 to 3.5.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jquery/jquery/releases">jquery's releases</a>.</em></p> <blockquote> <h2>jQuery 3.5.0 Released!</h2> <p>See the blog post: <a href="https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/">https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/</a> and the upgrade guide: <a href="https://jquery.com/upgrade-guide/3.5/">https://jquery.com/upgrade-guide/3.5/</a></p> <p><strong>NOTE:</strong> Despite being a minor release, this update includes a breaking change that we had to make to fix <a href="https://github.com/advisories/GHSA-gxr4-xjj5-5px2">a security issue</a> ( <a href="https://nvd.nist.gov/vuln/detail/CVE-2020-11022"><code>CVE-2020-11022</code></a>). Please follow the blog post & the upgrade guide for more details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jquery/jquery/commit/e1cffdef277fcf543833a20d28cbadcd000ebece"><code>e1cffde</code></a> 3.5.1</li> <li><a href="https://github.com/jquery/jquery/commit/7d2ce691cdbd53956f5eeab2048a13efd372277c"><code>7d2ce69</code></a> Release: update AUTHORS.txt</li> <li><a href="https://github.com/jquery/jquery/commit/ea2d0d50c06e8d77ea3fdfa32fa0bfe6f91418d2"><code>ea2d0d5</code></a> Tests: Workaround failures in recent XSS tests in iOS 8 - 12</li> <li><a href="https://github.com/jquery/jquery/commit/ea3766c08156541617ca3d15755a9ade8fdedcc0"><code>ea3766c</code></a> Docs: Fix typos</li> <li><a href="https://github.com/jquery/jquery/commit/58a8e87979d68f001de9e52c00601b805bab303d"><code>58a8e87</code></a> Tests: Add tests for recently fixed manipulation XSS issues</li> <li><a href="https://github.com/jquery/jquery/commit/c1c0598d8fde1bb66a257d7e993dd940aa4f4ce7"><code>c1c0598</code></a> Tests: Cleanup <code>window</code> & <code>document</code> handlers in a new event test</li> <li><a href="https://github.com/jquery/jquery/commit/46ba70c5e82cf55965ffe8825ec9247066a01ddd"><code>46ba70c</code></a> Tests: Fix flakiness in the "jQuery.ajax() - JSONP - Same Domain" test</li> <li><a href="https://github.com/jquery/jquery/commit/f7fed7eec235fe6e1f55c5ad9c7193a507bf5713"><code>f7fed7e</code></a> Docs: Update the link to the jsdom repository</li> <li><a href="https://github.com/jquery/jquery/commit/205dd134b93c42d53e19078846a972f33fc9d8eb"><code>205dd13</code></a> Build: Test on Node.js 14, stop testing on Node.js 8 & 13</li> <li><a href="https://github.com/jquery/jquery/commit/b21d6710cf2d9e227396fe8d78b262dfeb8b3c28"><code>b21d671</code></a> Build: Enable reportUnusedDisableDirectives in ESLint</li> <li>Additional commits viewable in <a href="https://github.com/jquery/jquery/compare/3.4.1...3.5.1">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

obsolete

Thank you for the extra information. Please report this problem directly against the extension.

Bumps websocket-extensions from 0.1.3 to 0.1.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

This is not a security issue

+ [email protected]

Turns out napi handle scopes are not opened / closed like normal "scopes" instead you have to manually open/close them. Not a fan but hey, it's the API 😆

Issue Type: <b>Feature Request</b>

Error showing :- Your code installation appears to be corrupt. Please install. I even reinstalled after that. But the problem remains same.

VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z) OS version: Windows_NT x64 10.0.18362

<!-- generated by issue reporter -->

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@MyWorldG @sleien You both appear to be using the same extension that creates editors labeled "Response(xms)". As @joaomoreno asked, does this issue reproduce when disabling all extensions?

There is a special action, Cursor Undo (I believe bound to ctrl+u on Windows by default) which undoes the last cursor operation (up to the last edit), so you can use ctrl+a, ctrl+c, and ctrl+u. Cursor Undo is a helpful command to know about, since it works the same in all cases, not just for ctrl+a. For example, I use it a lot in combination with ctrl+d if I go one too many words, etc.

@joaomoreno So when you receive a click event, it is not possible to determine if the original mousedown occurred in the same element? What about e.relatedTarget? Maybe that one shows the element that received the initial mousedown? What other options do we have? Should we call e.preventDefault of the mouseup event? Would that prevent the click event from firing?

I think you are hitting https://bugs.chromium.org/p/chromium/issues/detail?id=1016062

In short, in order to fix https://bugs.chromium.org/p/chromium/issues/detail?id=934878 (where a transition animation would sometimes use LCD antialising and sometimes use grayscale antialising, which would cause a "wobble") , they have made it that if a layer uses will-change: translate or if a layer reaches a non-integer coordinate in its lifetime, it will be "locked" into grayscale anti-alising.

So it is not sufficient to have a layer at the beginning and at the end at integer coordinates, you need that animations avoid floats as well.

I'm also not 100% sure how long ago we shipped the Monaco Editor and if it avoid by now will-change:.

Please let me know if you find some repro steps, AFAIK we listen to file changes and compute a diff between the new state on disk and the state in memory and push an edit to bring the file in memory to the state on disk (which also lands on the undo stack).

@Li-YangZhong The mouse wheel zoom is a multiplier applied to font size. So if you configure editor.fontSize: 16 and zoom in once with ctrl + mouse wheel, the effective font size will be 16 * 1.1, etc.

Does this reproduce when disabling all extensions? Press F1 and then choose Developer: Reload Window with Extensions Disabled

@BAbdulBaki The terminal is a separate application. Here I am trying with a separate GUI application, and I still cannot reproduce:

@tj I could not reproduce the low FPS with the monochrome theme. I have tried "Monochrome Dark Subtle". AFAIK the very large layer is not problematic. I think browsers reduce the computations to the visible areas, otherwise compositing 1Mx1M pixels would take a very long time. I cannot say what would go wrong on your machine. Perhaps it is a bug of Chromium that occurs only on your GPU model. If you can check out vscode, it would be interesting to find out if the performance becomes 100 times better when replacing the 1000000 (1M) with 100000 (100k) in the editor here -- https://github.com/microsoft/vscode/blob/79e4925ae1e40d817ee148f131f000aa07482f70/src/vs/editor/browser/view/viewImpl.ts#L286-L287.

@fabiospampinato I don't think the lack of LCD text rendering (sub pixel anti aliasing) is caused by the large layer. IMHO this is most likely caused by your use of non-integer coordinates.

• See how long it took us to clean up our code and how we manage to constantly regress in this -- https://github.com/microsoft/vscode/issues?q=+label%3Alcd-text-rendering+
• See a good article about conditions which lead to Chromium to switch to gray-scale antialising -- https://www.html5rocks.com/en/tutorials/internals/antialiasing-101/ :
• If you have a lot of time, see https://bugs.chromium.org/p/chromium/issues/detail?id=1016062 and https://github.com/w3c/csswg-drafts/issues/4560

@BAbdulBaki I could not reproduce. I have tried the following steps:

1. open a file
2. edit the file from another process
3. undo in the file

Thank you! :heart:

I cannot reproduce this issue. Does this reproduce when disabling all extensions? Press F1 and then choose Developer: Reload Window with Extensions Disabled

@shangchengxiang :+1: You are using the API correctly. There is no further details regarding the root cause for the change.

Refs: https://github.com/microsoft/vscode/issues/100995

• [x] anyOS @alexdima
• [x] anyOS @bamurtaugh

Complexity: 3

Create Issue

Please read through the new sample extension showing how to authenticate to GitHub: https://github.com/microsoft/vscode-extension-samples/tree/master/github-authentication-sample

Test that the extension runs as expected, and that the comments and code are clear. Note that the link to authentication.getSession in the API will be broken until we publish the website.

@DanTup If you have a chance, could you please verify this?

From the build - https://monacotools.visualstudio.com/Monaco/_build/results?buildId=83323&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=f43345f0-e90d-5fa7-e3aa-7e223f6f3b99

Remote integration tests are failing because remote extensions are not running.

Also confirmed in our test resolver window

Sorry about that and thank you!

The fix was correct, as part of a refactoring I forgot to pass in remoteExtensions to the method call.

@rebornix noticed that extension debugging on OSS with the webworker extension host enabled does not work.

I traced it to this promise never resolving

https://github.com/microsoft/vscode/blob/83e542bd07927497c2af4da573b6af98b18bcb48/src/vs/workbench/contrib/debug/browser/debugService.ts#L272

Down to the _proxy never being resolved for the webworker extension host

https://github.com/microsoft/vscode/blob/83e542bd07927497c2af4da573b6af98b18bcb48/src/vs/workbench/services/extensions/common/extensionHostManager.ts#L125

To reproduce:

1. Run OSS with the web worker extension host turned on
2. Try to debug any project/any language
3. You get an "activating extensions" spinner for a bit, but nothing happens

Sorry about that!

Fixed via f3b79b0d36919289eb79158aad68be88b23c16dc

Thank you for the extra information. @deepak1556 from the following comments, this appears to me to be an Electron issue, not an issue specific to VS Code:

https://github.com/microsoft/vscode/issues/101742#issuecomment-663547194

Additionally, the same thing happened in GitKraken that also uses Electron.

https://github.com/microsoft/vscode/issues/101742#issuecomment-667809241

I cannot use devtools too because keyboard is not working.

@mikedld I'm sorry about that. I have tried with the gitlens extension and the following settings:

{
    "editor.renderWhitespace": "all"
}

but I could not reproduce:

Is this perhaps influenced by some of your settings? Can you please try commenting out your settings temporarily and check if this reproduces?

published [email protected]

I noticed that this generates a warning:

> node-gyp rebuild

  CXX(target) Release/obj.target/keymapping/src/string_conversion.o
  CXX(target) Release/obj.target/keymapping/src/keymapping.o
  CXX(target) Release/obj.target/keymapping/src/keyboard_mac.o
../src/keyboard_mac.mm:184:21: warning: unused variable 'scope' [-Wunused-variable]
  napi_handle_scope scope;
                    ^
1 warning generated.

That is OK for me if it avoids a crash, but it would be nice if we could avoid the warning :).

Required for Electron 10 where the memory-leak-handle-scope was removed

cc @deepak1556

I didn't see anything peculiar, except perhaps some unusual amount of time spent in parsing snippets (FYI @jrieken), but 80ms should not cause any major performance problems: