profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/albhaf/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Albert Hafvenström albhaf @slagkryssaren

Dahlgren/Mottagningen-2011 2

Mottagningen 2011 @ KTH Kista

albhaf/bikemap 1

Map showing the stations of Stockholm Citybikes

albhaf/CppCoreGuidelines 0

The C++ Core Guidelines are a set of tried-and-true guidelines, rules, and best practices about coding in C++

push eventsoundcloud/roshi

Matthias Rampke

commit sha 8551e202940fe890f9f175958904429d736e3ab6

Revert "Disable tests that fail in CI" This reverts commit ed4c119399d09aa8c6aa3b610254143bfe0d213e.

view details

Matthias Rampke

commit sha 2896b64b1be65a3fbf3b437fb9df4ba5a7316377

Test with race detector Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

Matthias Rampke

commit sha 37e77dceaadaf4a0a455079998d6128ef8383466

Merge pull request #50 from soundcloud/mr/fix-repairs Fix repair tests (maybe)

view details

push time in a month

delete branch soundcloud/roshi

delete branch : mr/fix-repairs

delete time in a month

PR merged soundcloud/roshi

Fix repair tests (maybe)
+1 -3

2 comments

2 changed files

matthiasr

pr closed time in a month

issue commentsoundcloud/roshi

Failed in testing repairs

There is something more going on here. I enabled running the tests in GitHub actions and these tests kept failing (#49). I disabled them, merged, and then realized that I hadn't turned on the race detector (which was on before). Weirdly, with the race detector on, they pass (#50)! Locally for me, they also pass without race detection. Maybe the tests are still timing sensitive, and fail if they run too fast?

yujunz

comment created time in a month

pull request commentsoundcloud/roshi

Fix repair tests (maybe)

Alright, better than not testing I guess. Reopening #45 to track this.

matthiasr

comment created time in a month

pull request commentsoundcloud/roshi

Fix repair tests (maybe)

Huh, this is weird, the tests work but only if the race detector is enabled …

matthiasr

comment created time in a month

IssuesEvent

PR opened soundcloud/roshi

Mr/fix repairs
+1 -3

0 comment

2 changed files

pr created time in a month

create barnchsoundcloud/roshi

branch : mr/fix-repairs

created branch time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha bda599af8d1d5f7cf1192ee2baebedd4eb0a2b76

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

Matthias Rampke

commit sha ed4c119399d09aa8c6aa3b610254143bfe0d213e

Disable tests that fail in CI but pass locally. #46 attempted to fix them, but maybe there is something else going on? Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

Matthias Rampke

commit sha 5804b776cdb69dce03b6d0e92456ef17c004be78

Merge pull request #49 from soundcloud/mr/gh-actions Build and test with GitHub Actions

view details

push time in a month

delete branch soundcloud/roshi

delete branch : mr/gh-actions

delete time in a month

PR merged soundcloud/roshi

Build and test with GitHub Actions

RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions.

+36 -16

0 comment

3 changed files

matthiasr

pr closed time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha ed4c119399d09aa8c6aa3b610254143bfe0d213e

Disable tests that fail in CI but pass locally. #46 attempted to fix them, but maybe there is something else going on? Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha bda599af8d1d5f7cf1192ee2baebedd4eb0a2b76

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha 0c8bd4fe719191804424a6f13c5efcdd5fc62adc

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha c771c12fb02b289e576a1eea1218f2774057ef3e

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha f5c5f45413bc41ee739227a469f6c96dc9a0217f

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha 981820aba66f2bdf7e7f9bc84b41146d6363126b

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha 1eeaac379c1354299c5cb03e3b01c7c1b6bb4971

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha 9b4e804860daaea9a45f8679d11699980a339b5d

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha dcec2cc079cfb97d62c3a24c2f5a538a237d9026

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha 4148304322c5dd7ee91b2485a6b316d8f09b1454

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

push eventsoundcloud/roshi

Matthias Rampke

commit sha 71de8abd8fbec9a087c6fd88d3f7a85e7fd8c357

Build and test with GitHub Actions RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions. Signed-off-by: Matthias Rampke <mr@soundcloud.com>

view details

push time in a month

PR opened soundcloud/roshi

Build and test with GitHub Actions

RIP Travis CI, we need a new build system. Reproduce what we had in GH Actions.

+30 -0

0 comment

1 changed file

pr created time in a month

create barnchsoundcloud/roshi

branch : mr/gh-actions

created branch time in a month

pull request commentsoundcloud/roshi

Support go 1.14

Thank you!

yujunz

comment created time in a month

push eventsoundcloud/roshi

Yujun Zhang

commit sha 8f310df4784622b63c0f8c5579455352f247626a

Fix build under go 1.14

view details

Yujun Zhang

commit sha 041438032d7b474b5eb5a99fda128dfe413d6c12

Fix race condition in mockCluster map

view details

Matthias Rampke

commit sha 58581a95b34a6fb917a1aa38d466c52c35504ee1

Merge pull request #46 from yujunz/go114 Support go 1.14

view details

push time in a month

PR merged soundcloud/roshi

Support go 1.14

Fixes #45

+142 -12

0 comment

6 changed files

yujunz

pr closed time in a month

issue closedsoundcloud/roshi

Failed in testing repairs

I tried to port roshi to go 1.14 but failed in some tests related to repair

https://travis-ci.com/github/yujunz/roshi/builds/176022842#L377

=== RUN   TestAllRepairs
    repair_strategies_test.go:34: pre-repair: cluster 2: only got 0 responses
    repair_strategies_test.go:34: pre-repair: cluster 3: only got 0 responses
--- FAIL: TestAllRepairs (0.00s)
=== RUN   TestRateLimitedRepairs
    repair_strategies_test.go:87: post-repair: cluster 0: has [{Key:foo Score:2.3 Member:delta} {Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha}]
    repair_strategies_test.go:87: post-repair: cluster 1: has [{Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha} {Key:foo Score:1.3 Member:delta}]
    repair_strategies_test.go:87: post-repair: cluster 2: has [{Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha}]
    repair_strategies_test.go:92: post-repair: cluster 2: expected [{Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha} {Key:foo Score:1.3 Member:delta}], got [{Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha}]
    repair_strategies_test.go:87: post-repair: cluster 3: has [{Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha}]
    repair_strategies_test.go:92: post-repair: cluster 3: expected [{Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha} {Key:foo Score:1.3 Member:delta}], got [{Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha}]
    repair_strategies_test.go:87: post-repair: cluster 4: has [{Key:foo Score:2.2 Member:beta} {Key:foo Score:2.1 Member:alpha} {Key:foo Score:1.3 Member:delta}]
--- FAIL: TestRateLimitedRepairs (0.00s)
=== RUN   TestExplodingGoroutines
--- PASS: TestExplodingGoroutines (0.03s)
=== RUN   TestMakeSet
--- PASS: TestMakeSet (0.00s)
=== RUN   TestAddHas
--- PASS: TestAddHas (0.00s)
=== RUN   TestAddMany
--- PASS: TestAddMany (0.00s)
=== RUN   TestOrderedLimitedSlice
--- PASS: TestOrderedLimitedSlice (0.00s)
FAIL
FAIL	github.com/yujunz/roshi/farm	0.052s

However, running test locally did PASS. What could be the problem?

closed time in a month

yujunz

issue commentsoundcloud/roshi

Project status

Unfortunately we do not use roshi at SoundCloud anymore. I can try to keep up with issues and PRs, but cannot make promises. All actual work will have to come from the community.

mrzahrada

comment created time in a month