profile
viewpoint

alanj853/esqlite 0

Erlang NIF for sqlite

alanj853/FYP 0

All of the Code For My Final Year Project.

alanj853/linux 0

Kernel source tree for Raspberry Pi Foundation-provided kernel builds. Issues unrelated to the linux kernel should be posted on the community forum at https://www.raspberrypi.org/forum

alanj853/Lumenia_App 0

Functional Score Generator

PR opened se-apc/plug

Reviewers
Upstream merge
+331 -197

0 comment

29 changed files

pr created time in an hour

create barnchse-apc/plug

branch : upstream_merge

created branch time in an hour

push eventse-apc/nerves_network

Alan Jackson

commit sha b8d4d422407473bcefbc27fc2822180c621e59aa

add .tool-versions

view details

push time in 2 hours

push eventse-apc/nerves_network_interface

alanj853

commit sha 83ccb5b8fa405371a0b19471c80c6f0f38003b87

Update .tool-versions reduce versions

view details

push time in 2 hours

push eventse-apc/absinthe_phoenix

alanj853

commit sha 9730ab7bb1042296825ce54f8064c7bc088c245b

update .tool-versions

view details

push time in 3 hours

Pull request review commentse-apc/nerves_wpa_supplicant

Devel/eapo support

 defmodule Nerves.WpaSupplicant do    defstruct port: nil,             ifname: nil,+            restart: :transient,+            control_socket_path: "",             requests: []    @doc """   Start and link a Nerves.WpaSupplicant that uses the specified control   socket.   """-  def start_link(ifname, control_socket_path, opts \\ []) do-    GenServer.start_link(__MODULE__, {ifname, control_socket_path}, opts)+  def start_link(ifname, control_socket_path, restart \\ :transient, opts \\ []) do+    GenServer.start_link(__MODULE__, {ifname, control_socket_path, restart}, opts)+  end+  def start_link([ifname, control_socket_path, restart, opts]) do

Can you not just keep them all in one way then, even if it is the old way? Just so that it is consistent

metelik

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentse-apc/nerves_wpa_supplicant

Devel/eapo support

 defmodule Nerves.WpaSupplicant do    defstruct port: nil,             ifname: nil,+            restart: :transient,+            control_socket_path: "",             requests: []    @doc """   Start and link a Nerves.WpaSupplicant that uses the specified control   socket.   """-  def start_link(ifname, control_socket_path, opts \\ []) do-    GenServer.start_link(__MODULE__, {ifname, control_socket_path}, opts)+  def start_link(ifname, control_socket_path, restart \\ :transient, opts \\ []) do+    GenServer.start_link(__MODULE__, {ifname, control_socket_path, restart}, opts)+  end+  def start_link([ifname, control_socket_path, restart, opts]) do

Why do we need so many cases for starting the module? Can we not just have one, and subsequently only one init as well?

metelik

comment created time in 4 days

delete branch se-apc/eradius

delete branch : ppi_removal

delete time in 2 months

PR merged se-apc/eradius

Reviewers
Remove PPI from the debug messages

Currently, the only PPI is the user_name

+14 -4

0 comment

1 changed file

alanj853

pr closed time in 2 months

push eventse-apc/eradius

alanj853

commit sha fc42f552e5bbbe15878103f7bd60056ac5b5d6b4

Remove PPI from the debug messages Currently, the only PPI is the user_name

view details

alanj853

commit sha afd9499dbbe3e9ac80c626407789e6dd8fe20418

Merge pull request #6 from se-apc/ppi_removal Remove PPI from the debug messages

view details

push time in 2 months

PR opened se-apc/eradius

Reviewers
Remove PPI from the debug messages

Currently, the only PPI is the user_name

+14 -4

0 comment

1 changed file

pr created time in 2 months

create barnchse-apc/eradius

branch : ppi_removal

created branch time in 2 months

PullRequestReviewEvent

PR opened se-apc/esqlite

Update for OTP24
  • Add tool-versions
  • Update rebar3 to suport otp24
+2 -1

0 comment

2 changed files

pr created time in 2 months

create barnchse-apc/esqlite

branch : otp24

created branch time in 2 months

push eventse-apc/nerves_network_interface

alanj853

commit sha 2b2dbaa73997284251f8a14f1b06b161e76e84cf

Update to OTP24 and Elixir 1.12.3 - Update deps - Use modern supervisor formats

view details

push time in 2 months

more