A tool that would help users understand and review pull requests better
akshita31/active-directory-aspnetcore-webapp-openidconnect-v2 0
An ASP.NET Core 2.x Web App which lets sign-in users (including in your org, many orgs, orgs + personal accounts, sovereign clouds) and call Web APIs (including Microsoft Graph)
akshita31/active-directory-dotnet-webapp-openidconnect-aspnetcore 0
An ASP.NET Core web application that signs-in Azure AD users from a single Azure AD tenant.
akshita31/akshita007.github.io 0
Build a Jekyll blog in minutes, without touching the command line.
akshita31/artifacts-credprovider 0
The Azure Artifacts Credential Provider enables dotnet, NuGet.exe, and MSBuild to interactively acquire credentials for Azure Artifacts feeds.
akshita31/ASP.NET-Learning-Sample 0
A sample repository for the PluralSight course - https://app.pluralsight.com/library/courses/aspdotnet-core-fundamentals/table-of-contents
Open source documentation of Microsoft Azure
akshita31/azure-quickstart-templates 0
Azure Quickstart Templates
akshita31/azure-rest-api-specs 0
The source for REST API specifications for Microsoft Azure.
issue closedOmniSharp/omnisharp-roslyn
Why is mono-6.4.0/msbuild-16.3.0 required?
Why have mono-6.4.0/msbuild-16.3.0 become a hard requirement? I am trying to use Omnisharp on a platform having mono6.8 available, but not having a readily available build of msbuild >= 16.3.0 (the only available version is msbuild15).
Since the task of upgrading the msbuild port does not appear to be trivial, as an alternative I am trying to assess the impact of patching Omnisharp to remove the hard requirement on msbuild 16.3.0 (and if this would be possible at all).
closed time in an hour
nkosi23issue commentOmniSharp/omnisharp-roslyn
Why is mono-6.4.0/msbuild-16.3.0 required?
It is not a hard requirement, OmniSharp ships with its own bundled MSBuild as well, however if global Mono is available, it is attempted to be used because it will have reference assemblies for desktop .NET, which the bundled one doesn't.
The reason why lowest version of Mono MSBuild is what it is, is because of requirements in .NET Core - e.g. 3.1 requires MSBuiild 16.3 and 5.0 requires 16.8.
You can disable the discovery of global Mono and global MSBuild by adding an omnisharp.json
file to the root of your project with the content
{
"msbuild": {
"useBundledOnly": true
}
}
This will work for loading .NET Core projects, for loading desktop .NET the reference assemblies from global Mono are required so you will need to upgrade global Mono.
comment created time in an hour
issue openedOmniSharp/omnisharp-roslyn
Why is mono-6.4.0/msbuild-16.3.0 required?
Why have mono-6.4.0/msbuild-16.3.0 become a hard requirement? I am trying to use Omnisharp on a platform having mono6.8 available, but not having a readily available build of msbuild >= 16.3.0 (the only available version is msbuild15).
Since the task of upgrading the msbuild port does not appear to be trivial, as an alternative I am trying to assess the impact of patching Omnisharp to remove the hard requirement on msbuild 16.3.0 (and if this would be possible at all).
created time in 2 hours
issue commentOmniSharp/omnisharp-vscode
No code actions available and no reference suggestion on Linux
Yes, it contains omnisharp server timeout only. Maybe I send the log later.
comment created time in 3 hours
issue commentOmniSharp/omnisharp-vscode
No code actions available and no reference suggestion on Linux
@peter7764 Does the OmniSharp log only contain a timeout or is there information before that? Without a log there is very little we can do to help.
comment created time in 7 hours
startedswc-project/swc
started time in 7 hours
issue commentOmniSharp/omnisharp-vscode
No code actions available and no reference suggestion on Linux
It starts with time out. I extended the time but no hope.
comment created time in 11 hours
fork cartermp/vscode-docs
Public documentation for Visual Studio Code
http://code.visualstudio.com/docs
fork in 12 hours
push eventOmniSharp/omnisharp-vscode
commit sha 5497895b44c4ecc625cd3d1241528f145ac7158b
Handle ProcessPicker via resolveDebugConfiguration (#4509) * Handle ProcessPicker via resolveDebugConfiguration VS Code commands are limited to only being able to have a single output. We will handle having an empty processId and show the dialog for ProcessPicker in resolveDebugConfigurationWithSubstitutedVariables. We need multiple outputs to handle the latest macOS on Apple M1. For Apple Silicon M1 (ARM64), we need to determine if we need to use the x86_64 or arm64 debugger. We are able to detect if the process is using S_TRANSLATED using the ps commandline with 'flags', if it is set with 0x20000, it is emulated. * Addressing PR issues Migrate remoteProcessPicker to also be in resolve configuration Handle 'clr' type for remote process picking. Addressing PR issues. Added comment about 0x20000 * Remove 'processId' from default config * Remove 'processId' from assets.ts
push time in 13 hours
PR merged OmniSharp/omnisharp-vscode
VS Code commands are limited to only being able to have a single output. We will handle having an empty processId and show the dialog for ProcessPicker in resolveDebugConfigurationWithSubstitutedVariables. We need multiple outputs to handle the latest macOS on Apple M1.
For Apple Silicon M1 (ARM64), we need to determine if we need to use the x86_64 or arm64 debugger. We are able to detect if the process is using S_TRANSLATED using the ps commandline with 'flags', if it is set with 0x20000, it is emulated.
pr closed time in 13 hours
created repositoryseesharper/notes
This repo contains my notes on various topics
created time in 14 hours
startedkvakvs/beam-wisdoms
started time in 15 hours
issue commentOmniSharp/omnisharp-vscode
Multiple Restore dependencies notifications
@ferenczy I agree we need to improve this dialog. The Restore button runs a restore for the entire solution, so we only need to display at most one popup.
comment created time in 16 hours
issue commentOmniSharp/omnisharp-vscode
No code actions available and no reference suggestion on Linux
@peter7764 Can you provide the OmniSharp log from the VS Code output pane?
comment created time in 16 hours
create barnchOmniSharp/omnisharp-roslyn
branch : dependabot/nuget/tools/System.Text.Encodings.Web-4.7.2
created branch time in 16 hours
PR opened OmniSharp/omnisharp-roslyn
Bumps System.Text.Encodings.Web from 4.7.1 to 4.7.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dotnet/corefx/releases">System.Text.Encodings.Web's releases</a>.</em></p> <blockquote> <h2>.NET Core 2.1.0 RC1</h2> <ul> <li><a href="https://github.com/dotnet/core/blob/master/release-notes/2.1/Preview/2.1.0-rc1.md">Release Notes</a></li> <li><a href="https://github.com/dotnet/core/blob/master/release-notes/2.1/Preview/2.1.0-rc1-known-issues.md">Known Issues</a></li> <li><a href="https://github.com/dotnet/core/blob/master/release-notes/download-archives/2.1.0-rc1-download.md">Download and Install</a></li> </ul> <h2>Repos</h2> <ul> <li><a href="https://github.com/dotnet/coreclr/releases/tag/v2.1-rc1">CoreCLR</a></li> <li><a href="https://github.com/dotnet/corefx/releases/tag/v2.1-rc1">CoreFX</a></li> <li><a href="https://github.com/dotnet/core-setup/releases/tag/v2.1-rc1">Core-Setup</a></li> <li><a href="https://github.com/dotnet/cli/releases/tag/v2.1.300-rc1-008673">CLI</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/dotnet/corefx/commits">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase
.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the Security Alerts page.
</details>
pr created time in 16 hours
issue commentOmniSharp/omnisharp-vscode
Improvement: Auto-Complete switch statements containing enums
This worked for me but a couple of gotchas:
- After enabling the Roslyn Analyzers you have to restart vsc or restart Omnisharp
- The "Add missing cases" only shows up for me if my ticker is just before the s in switch and default: is within the brackets already. If the switch is empty { } it wont work.
comment created time in 17 hours
issue openedOmniSharp/omnisharp-vscode
Multiple Restore dependencies notifications
Issue Description
When I open a .NET solution that doesn't have restored dependencies yet, the C# extension sometimes generates multiple identical notifications with the text "There are unresolved dependencies. Please execute the restore command to continue." and the Restore button, see below:
I'm guessing that it happens when there're multiple projects and each notification references one of those projects, but there's no way how to recognize that and how to identify what notification references what project.
It would be great if the notification contains some identifier (a project name) to help with that.
Steps to Reproduce
- Open a .NET solution containing multiple projects with dependencies you don't have already downloaded (restored)
- The C# extension generates multiple identical notifications
Expected Behavior
There's some identifier to recognize what project notification references.
Actual Behavior
The notification contains just generic text.
Environment information
VSCode version: 1.55.1 C# Extension: 1.23.11
<details><summary>Dotnet Information</summary> .NET SDK (reflecting any global.json): Version: 5.0.201 Commit: a09bd5c86c
Runtime Environment: OS Name: Windows OS Version: 10.0.19042 OS Platform: Windows RID: win10-x64 Base Path: C:\Program Files\dotnet\sdk\5.0.201\
Host (useful for support): Version: 5.0.4 Commit: f27d337295
.NET SDKs installed: 2.1.811 [C:\Program Files\dotnet\sdk] 3.1.404 [C:\Program Files\dotnet\sdk] 5.0.100 [C:\Program Files\dotnet\sdk] 5.0.201 [C:\Program Files\dotnet\sdk]
.NET runtimes installed: Microsoft.AspNetCore.All 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.All 2.1.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.App 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 2.1.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 5.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.NETCore.App 2.1.23 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.1.26 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 5.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.WindowsDesktop.App 3.1.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 3.1.11 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 3.1.13 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 5.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 5.0.4 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET runtimes or SDKs: https://aka.ms/dotnet-download </details> <details><summary>Visual Studio Code Extensions</summary>
Extension | Author | Version |
---|---|---|
Bookmarks | alefragnani | 13.0.4 |
bracket-pair-colorizer-2 | CoenraadS | 0.2.0 |
change-case | wmaurer | 1.0.0 |
code-spell-checker | streetsidesoftware | 1.10.2 |
code-spell-checker-czech | streetsidesoftware | 0.1.6 |
code-stats-vscode | riussi | 1.0.18 |
color-highlight | naumovs | 2.3.0 |
csharp | ms-dotnettools | 1.23.11 |
docs-view | bierner | 0.0.9 |
EditorConfig | EditorConfig | 0.16.4 |
git-graph | mhutchie | 1.30.0 |
githistory | donjayamanne | 0.6.16 |
gitlens | eamodio | 11.4.1 |
indent-rainbow | oderwat | 7.5.0 |
linesinfostatusbar | peterfh | 0.0.3 |
markdown-links | tchayen | 0.8.0 |
markdown-memo | svsool | 0.3.4 |
markdown-table-prettify | darkriszty | 3.4.0 |
markdown-toc | AlanWalk | 1.5.6 |
material-icon-theme | PKief | 4.6.0 |
overtype | DrMerfy | 0.4.0 |
project-manager | alefragnani | 12.1.0 |
rainbow-csv | mechatroner | 1.8.1 |
trailing-spaces | shardulm94 | 0.3.1 |
vscode-icons | vscode-icons-team | 11.4.0 |
vscode-nuget-package-manager-improved | maxbrister | 2.1.0 |
vscode-sql-formatter | adpyke | 1.4.4 |
xml | DotJoshJohnson | 2.5.1 |
</details>
created time in 17 hours
issue openedaspnet/Announcements
New Use middleware overload, can cause compiler errors if you don't call next
<!-- This issue template is for use in opening issues that document breaking changes. This template should be used to create an issue by Microsoft product team members who are documenting a breaking change.
Bracketed text is a placeholder; replace the text with the requested information and remove the brackets before submitting the issue. Also, remove this comment before submitting the issue.
-->
[New Use middleware overload, can cause compiler errors if you don't call next
]
A new overload of app.Use
has been introduced. If you were previously using app.Use
but never calling the next
middleware, you will now get a compiler error (CS0121). If that's the case you should use app.Run
instead of app.Use
.
Version introduced
ASP.NET Core 6.0-preview4
Old behavior
app.Use(async (context, next) =>
{
await next();
});
or
app.Use(async (context, next) =>
{
await SomeAsyncWork();
// next never called
});
New behavior
app.Use(async (context, next) =>
{
await next(context);
});
Notice that you can now pass context
to the next
delegate.
app.Run(async (context) =>
{
await SomeAsyncWork();
// next never called
});
Use app.Run
when your middleware never calls next
, otherwise you will get a compile error:
CS0121 The call is ambiguous between the following methods or properties: 'UseExtensions.Use(IApplicationBuilder, Func<HttpContext, Func, Task>)' and 'UseExtensions.Use(IApplicationBuilder, Func<HttpContext, RequestDelegate, Task>)'
Reason for change
The previous Use
method would allocate 2 objects per request. The new overload avoids these allocations with a small change to how you invoke the next middleware.
Recommended action
If you get a compile error, it means you are calling app.Use
without using the next
delegate. Switch to app.Run
to fix the error.
Category
ASP.NET
Affected APIs
Not detectable via API analysis
<!-- Do not modify anything below this line -->
Issue metadata
- Issue type: breaking-change
created time in 19 hours
starteddabutvin/Imgbot
started time in 21 hours
issue openedOmniSharp/omnisharp-vscode
No code actions available and no reference suggestion on Linux
Environment data
dotnet --info
output:
.NET SDK (reflecting any global.json):
Version: 5.0.202
Commit: db7cc87d51
Runtime Environment:
OS Name: arch
OS Version:
OS Platform: Linux
RID: arch-x64
Base Path: /usr/share/dotnet/sdk/5.0.202/
Host (useful for support):
Version: 5.0.5
Commit: 561d6ea60d
.NET SDKs installed:
5.0.202 [/usr/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 5.0.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 5.0.5 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download
VS Code version:
Version: 1.55.2
Commit: 3c4e3df9e89829dce27b7b5c24508306b151f30d
Date: 2021-04-13T09:37:02.931Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Linux x64 5.10.31-1-lts
C# Extension version:
Name: C#
Id: ms-dotnettools.csharp
Description: C# for Visual Studio Code (powered by OmniSharp).
Version: 1.23.11
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp
Steps to reproduce
- Create .NET5 API project
- Go to WeatherForecastController.cs
- Press F12 on WeatherForecast
- No reference shown & no reference suggestion
created time in 21 hours
startedadamralph/minver
started time in a day
push eventOmniSharp/omnisharp-vscode
commit sha 2a17228f569f1d29c1da18a6f357d402b4f4e924
Remove 'processId' from assets.ts
push time in 2 days
push eventOmniSharp/omnisharp-vscode
commit sha 93f562c1cba9f2ae50cdb7131bbf5f3ab0e3d3dc
Remove 'processId' from default config
push time in 2 days
Pull request review commentOmniSharp/omnisharp-vscode
Handle ProcessPicker via resolveDebugConfiguration
export function createAttachConfiguration(): string { "name": ".NET Core Attach", "type": "coreclr", "request": "attach",- "processId": "\${command:pickProcess}"+ "processId": ""
Sure, but that seems rare, and if you want to do it, seems like processName
would make more sense than processId
. The only reason I can think to of using processId
is if you are on an image without ps
(or with a ps
that acts differently than we expect).
comment created time in 2 days
issue commentOmniSharp/omnisharp-vscode
Remote attach to process doesn't support input variables in `pipeArgs`
I believe this will be addressed by https://github.com/OmniSharp/omnisharp-vscode/pull/4509
comment created time in 2 days
Pull request review commentOmniSharp/omnisharp-vscode
Handle ProcessPicker via resolveDebugConfiguration
export function createAttachConfiguration(): string { "name": ".NET Core Attach", "type": "coreclr", "request": "attach",- "processId": "\${command:pickProcess}"+ "processId": ""
I also had the same thought, if users wanted to override it themselves then they would most likely investigate the options in launch.json
and set it themselves.
comment created time in 2 days
Pull request review commentOmniSharp/omnisharp-vscode
Handle ProcessPicker via resolveDebugConfiguration
export function createAttachConfiguration(): string { "name": ".NET Core Attach", "type": "coreclr", "request": "attach",- "processId": "\${command:pickProcess}"+ "processId": ""
comment created time in 2 days
pull request commentOmniSharp/omnisharp-vscode
Handle ProcessPicker via resolveDebugConfiguration
Tested:
Type | Platform | Scenario | Result |
---|---|---|---|
clr | Windows | Launch | ✔ |
clr | Windows | Attach | ✔ |
coreclr | Windows | Attach | ✔ |
coreclr | Windows | Attach | ✔ |
coreclr | Windows | Attach to WSL | ✔ |
coreclr | macOS (ARM64) | Launch x86_64 dotnet | ✔ |
coreclr | macOS (ARM64) | Attach x86_64 dotnet | ✔ |
coreclr | macOS (ARM64) | Launch arm64 dotnet | ✔ |
coreclr | macOS (ARM64) | Attach arm64 dotnet | ✔ |
comment created time in 2 days