profile
viewpoint

akater/api-gentoo-org 0

[MIRROR] Seed data for api.gentoo.org

akater/cl-ledger 0

Port of the Ledger accounting system (see project "ledger") to Common Lisp

akater/elephant 0

Elephant is a persistent object database for Common Lisp with full transaction semantics.

akater/emacs-edbi 0

Database Interface for Emacs Lisp

akater/emacs-epc 0

A RPC stack for Emacs Lisp

akater/emacs-kv 0

Key/Value collection type functions: for alists, hashtables and plists. Useful stuff.

akater/emacs-libvterm 0

Emacs libvterm integration

akater/emacs-portage-navi 0

Portage Navigation GUI

akater/emacs-yeis 0

Yeis's Emacs' Input Switcher

akater/emacsql 0

A high-level Emacs Lisp RDBMS front-end

push eventakater/transient

Jonas Bernoulli

commit sha 202271f755497bacb50a1f2b3c93566e816f447e

Resurrect transient-files class Deprecating it in the previous commit was premature. However to make it actually useful it has to derive from `transient-option' and set some default values.

view details

Lars Ingebrigtsen

commit sha 7f5520b330d4d23e3241b731cb32f59a33aa251c

Add support for non-proportional text Add a new `variable-pitch' prefix slot to enable support.

view details

Jonas Bernoulli

commit sha 349116159f707a474926b47e5f6b6240e8997a4d

manual: Use Org macros

view details

Jonas Bernoulli

commit sha 4e8aa09b3f9b909dddde85269eb5051b5801a07c

transient-define-infix: Fix documentation Closes #175.

view details

akater

commit sha a82c54871da893a6473fe3d656c5145de7aa741a

Use (setf (oref ..) ..) instead of oset oset is obsolete since Emacs 28

view details

push time in 2 days

push eventakater/magit

Jonas Bernoulli

commit sha fd5b9eadf34de01a515f418c9d78a261f6825f24

magit-fetch-modules: With prefix argument act as transient prefix

view details

Jonas Bernoulli

commit sha 2039619696bafeeebff245e316af640c19d5cf1c

magit-remote-at-point: For branch section check type of parent

view details

Jonas Bernoulli

commit sha 15b2f277ae3ac6c3ea5a52e64698a84f8c03311f

magit-insert-error-header: Use error face

view details

Jonas Bernoulli

commit sha bf3bcbe051e5c397f50ba80e674d0751781e4fa8

magit-branch-warning: New face Closes #4550.

view details

Jonas Bernoulli

commit sha 5a8bbe1a8a296ed8edb416c310693f29b8edd953

magit-branch-upstream: Inherit from warning face

view details

Jonas Bernoulli

commit sha 1e8b9f5d492b920a2b8497fc1377348bf08920b4

magit-branch-delete: Improve other branch choice When offering to checkout another branch in response to the user requesting the deletion of the current branch, then propose that the upstream branch is checked out instead of the main branch if that is reasonable, i.e. if it actually exists. Closes #4549.

view details

Jonas Bernoulli

commit sha ff3269814c33a37ad7d4fd6ca927dcc6131b0bbd

magit-cherry-branch: Support using detached HEAD as source Closes #4534.

view details

Jonas Bernoulli

commit sha b81e1a867871fcf449560168b31fd1fe8b31b4c2

magit-cherry-{harvest,donate}: Improve prompt for single cherry case

view details

Jonas Bernoulli

commit sha dfe3d03a143c8cd718516b3cf3327d15b61cd95b

git-commit-save-message: Report whether message was saved

view details

Jonas Bernoulli

commit sha a121f3408940237253341ec755be2204f5fa1582

git-commit-search-message-{backward,forward}: New commands Closes #4537.

view details

Jonas Bernoulli

commit sha b6a103b6bf62dfea556f3e5523e52d1a16228ea8

Fix previous commit

view details

Akater

commit sha a40512f9e7b2c43ed876a167fa7e14ed2a3c57ee

Remove “99th submatch” condition on password hooks

view details

push time in 2 days

push eventakater/slime

Mark Evenson

commit sha 88d39e241bf6f6a2a1daced6d93c8e35692e8889

abcl: fix edit location finding in jar files (Alan Ruttenberg) Originally <https://github.com/alanruttenberg/slime/commit/1d17cbcafb4c4c2675c037c12f036b1a90e76bc7>. Addresses <https://github.com/armedbear/abcl/issues/411>.

view details

meister

commit sha 9005cdaac4c0adaa8e26ee5285c7b155762c0ce5

Change va-list to vaslist and renamed core package The name 'va-list' was changed to 'vaslist' within clasp and slime/swank/clasp.lisp referenced 'va-list'. The CORE package name in clasp is going to be removed and replaced with SYS. So all references to the package 'core' have been changed to 'sys'.

view details

akater

commit sha b30a2defe3be67c9d16165e9b7b119dd51200596

Support for grabbing multiple outputs in swank:eval-and-grab-output It is often desirable to get output from time and trace in Emacs, particularly in org-babel. This patch extends swank:eval-and-grab-output to support emitting *trace-output*; it also introduces *error-output*, for good measure. We check whether eval-and-grab-output caller presumes older interface to it and return a legacy list of two elements instead of alist in those cases. This check can very likely be dropped when either Emacs 27 or Org 9.4 become unsupported.

view details

push time in 6 days

push eventakater/slime

Mark Evenson

commit sha 88d39e241bf6f6a2a1daced6d93c8e35692e8889

abcl: fix edit location finding in jar files (Alan Ruttenberg) Originally <https://github.com/alanruttenberg/slime/commit/1d17cbcafb4c4c2675c037c12f036b1a90e76bc7>. Addresses <https://github.com/armedbear/abcl/issues/411>.

view details

meister

commit sha 9005cdaac4c0adaa8e26ee5285c7b155762c0ce5

Change va-list to vaslist and renamed core package The name 'va-list' was changed to 'vaslist' within clasp and slime/swank/clasp.lisp referenced 'va-list'. The CORE package name in clasp is going to be removed and replaced with SYS. So all references to the package 'core' have been changed to 'sys'.

view details

push time in 6 days

push eventakater/telega.el

Zajcev Evgeny

commit sha 0b9fcc044c049218a45b53d095f345b53680d8d9

[typofix] in the etc/langs/en.plist

view details

Zajcev Evgeny

commit sha 0110347aff98d92f1e41f6fdad18e8eba857fd37

[enh] Support for `ranger-mode' Makes it possible to use `C-c t f' to send marked files from ranger Fixes https://t.me/emacs_telega/30881

view details

akater

commit sha f6aa0cacc9d6e0345032fd7de752f1418570dec7

Do not attempt making any images when telega-use-images is nil

view details

push time in 6 days

push eventakater/telega.el

Zajcev Evgeny

commit sha 0b9fcc044c049218a45b53d095f345b53680d8d9

[typofix] in the etc/langs/en.plist

view details

Zajcev Evgeny

commit sha 0110347aff98d92f1e41f6fdad18e8eba857fd37

[enh] Support for `ranger-mode' Makes it possible to use `C-c t f' to send marked files from ranger Fixes https://t.me/emacs_telega/30881

view details

push time in 6 days

push eventakater/magit

Bastian Beranek

commit sha f29e5ca95b3892044c79fb400d2bbf60829019fd

git-rebase-action: New face

view details

Jonas Bernoulli

commit sha a66b86d51139479d74962cc077c5215d20dd72e6

Define empty face definitions without making them rogue

view details

Jonas Bernoulli

commit sha 6da7771b616d1cf781946f53b23ddfaeb23d5a73

magit-faces: Add diff-refine-{added,removed}

view details

Jonas Bernoulli

commit sha 84104e84bbf9811b49b0f9a2a29aa15ff72d39ce

manual: Correct face name

view details

Akater

commit sha d2e6b450e4d7ee4103b2f94f97bd2fc86c26d2fa

Remove “99th submatch” condition on password hooks

view details

push time in 6 days

push eventakater/telega.el

akater

commit sha 02b14453e7f3f8b2a8212025510b281fa91fca21

Do not attempt making any images when telega-use-images is nil

view details

push time in 13 days

push eventakater/magit

Jonas Bernoulli

commit sha 7d154b1f29214a6d6f2ebfb1af050d737c43e8b0

manual: Use Org macros

view details

Jonas Bernoulli

commit sha 58742e978384688401a7b4ddd9611a2ab5bc9032

Fix CI by relying less on Nix The previous implementation kept breaking and we got no help fixing that. More or less go back to the previous implementation, which we know how to keep running without any outside help. Previously testing using libgit was disabled because it was broken, while now there simply isn't any code to attempt to test that.

view details

Jonas Bernoulli

commit sha 473fc7ac528f042f3b417b2a543898123825181c

Various fixes for older Emacsen

view details

Jonas Bernoulli

commit sha f15becef69f4695f76dd8d00b7dd571663dd8a33

magit-merge-into: Fix doc-string typo

view details

Jonas Bernoulli

commit sha 9413847c1a085899d8de6f8d978bd7265f65e5d8

magit-diff-dwim: Compare unpushed/unpulled changes with merged-base The value of the unpushed/unpulled sections are ranges suitable for log. Diff doesn't deal with ranges but endpoints. In practice that means that if a log range uses ".." then "..." should be used in the respective diff and vice-versa.

view details

Jonas Bernoulli

commit sha c7fb546c4d4fe5610f701d6c4d51d8b2fcc7becc

git-commit: Use preferred form in face specs Use (DISPLAY . PLIST); (DISPLAY PLIST) is only supported for backward compatibility.

view details

Jonas Bernoulli

commit sha 523c05f5fe76cb7beea1e29bffd1f6cfac713025

git-rebase-comment-heading: Fix custom group

view details

Kyle Meyer

commit sha 877c389ca0161959081fa2c77045ce1ae9463be4

magit-list-worktrees: Fix comment typo

view details

Akater

commit sha 25c52245d6513d4a48f5b08c38c8f70139d943ce

Remove “99th submatch” condition on password hooks

view details

push time in 13 days

push eventakater/telega.el

Zajcev Evgeny

commit sha b6aa0b794768fd0de65b162a267a9b1b523a693d

[enh] `telega-sticker--convert-cmd' as string In case "dwebp" tool is unavailable, use "ffmpeg" to convert webp into png

view details

Zajcev Evgeny

commit sha 8a363753798a1eb2cb4f67b4db56b8ecf74ec46c

Support for TDLib 1.7.9: - animated emojis - video chats instead of voice chats - sponsored messages (`has-sponsored-messages' Chat Filter) + [feature] Draw my location in the other user location message + [new] rootbuf aux ewoc to insert additional data into rootbuf + [new] `telega-active-locations-mode' to display active Live locations in the rootbuf Docs regenerated Version -> 0.7.90

view details

akater

commit sha 5caf7fa6bb694b17be05a089c19bee8f42d21fe1

Do not attempt making any images when telega-use-images is nil

view details

push time in 13 days

push eventakater/telega.el

Zajcev Evgeny

commit sha b6aa0b794768fd0de65b162a267a9b1b523a693d

[enh] `telega-sticker--convert-cmd' as string In case "dwebp" tool is unavailable, use "ffmpeg" to convert webp into png

view details

Zajcev Evgeny

commit sha 8a363753798a1eb2cb4f67b4db56b8ecf74ec46c

Support for TDLib 1.7.9: - animated emojis - video chats instead of voice chats - sponsored messages (`has-sponsored-messages' Chat Filter) + [feature] Draw my location in the other user location message + [new] rootbuf aux ewoc to insert additional data into rootbuf + [new] `telega-active-locations-mode' to display active Live locations in the rootbuf Docs regenerated Version -> 0.7.90

view details

push time in 13 days

push eventakater/telega.el

Zajcev Evgeny

commit sha 0c376e8ddc5a54011aeefc5df1cb0cbfc5911345

Initial support for Chat Themes Version -> 0.7.82

view details

Zajcev Evgeny

commit sha 8a419597c2a58f37567efd75abe521ab5e2945a8

[fix] typo in telega-chat.el ROADMAP updated

view details

Zajcev Evgeny

commit sha bab4af8cf6208089f43f3175acb0bbc450b26734

[enh] Always show origin for the forwarded message

view details

Zajcev Evgeny

commit sha 611d01e5d21db5a21c6b0a350dc2731d226fbebf

[enh] Use <Ignored Message> instead of <IGNORED MESSAGE> So ignored message will be less noticeable

view details

akater

commit sha 619318702fc6fcc52aab599300ab68c13a390d82

[fix] `custom-declare-variable' wants a form rather than a value

view details

Zajcev Evgeny

commit sha d61623fccd008a80bddc260ece0285b043292bcb

Merge pull request #324 from akater/dired-dwim-target [fix] `custom-declare-variable' wants a form rather than a value

view details

Zajcev Evgeny

commit sha 532e663f5d833a1a879b2b97aa943a40795ca77f

[fix] docs for telega-notifications

view details

Zajcev Evgeny

commit sha f51c1857cc0c683d4137bd9764868936c43dd69a

[enh] root autofill When automatically refilling rootbuf take into account width occupied by `display-line-numbers-mode' Fixes #325

view details

Zajcev Evgeny

commit sha 9bc087dab6d2503da41881132664f5c0c979f4b6

[fix] Avoid using `display-line-numbers-mode' var Use `line-number-display-width<f>' directly to get number of pixels used to display line number.

view details

Zajcev Evgeny

commit sha 3a0b758275cfa1a990ed556e0f75cdc11c531c36

[fix] `telega-server-logfile' can be nil Fixes https://t.me/emacs_telega/30754

view details

Zajcev Evgeny

commit sha 627d9698edd189b9063476440d6de855ec923f3e

[enh] Do not strip properties for chatbuffer name Makes emojis correctly appear in minibuffer when selecting a chat

view details

akater

commit sha 75f4c8b5bbdcb46aab705e37c4144333284a8321

Do not attempt making any images when telega-use-images is nil

view details

push time in 17 days

push eventakater/telega.el

Zajcev Evgeny

commit sha 0c376e8ddc5a54011aeefc5df1cb0cbfc5911345

Initial support for Chat Themes Version -> 0.7.82

view details

Zajcev Evgeny

commit sha 8a419597c2a58f37567efd75abe521ab5e2945a8

[fix] typo in telega-chat.el ROADMAP updated

view details

Zajcev Evgeny

commit sha bab4af8cf6208089f43f3175acb0bbc450b26734

[enh] Always show origin for the forwarded message

view details

Zajcev Evgeny

commit sha 611d01e5d21db5a21c6b0a350dc2731d226fbebf

[enh] Use <Ignored Message> instead of <IGNORED MESSAGE> So ignored message will be less noticeable

view details

akater

commit sha 619318702fc6fcc52aab599300ab68c13a390d82

[fix] `custom-declare-variable' wants a form rather than a value

view details

Zajcev Evgeny

commit sha d61623fccd008a80bddc260ece0285b043292bcb

Merge pull request #324 from akater/dired-dwim-target [fix] `custom-declare-variable' wants a form rather than a value

view details

Zajcev Evgeny

commit sha 532e663f5d833a1a879b2b97aa943a40795ca77f

[fix] docs for telega-notifications

view details

Zajcev Evgeny

commit sha f51c1857cc0c683d4137bd9764868936c43dd69a

[enh] root autofill When automatically refilling rootbuf take into account width occupied by `display-line-numbers-mode' Fixes #325

view details

Zajcev Evgeny

commit sha 9bc087dab6d2503da41881132664f5c0c979f4b6

[fix] Avoid using `display-line-numbers-mode' var Use `line-number-display-width<f>' directly to get number of pixels used to display line number.

view details

Zajcev Evgeny

commit sha 3a0b758275cfa1a990ed556e0f75cdc11c531c36

[fix] `telega-server-logfile' can be nil Fixes https://t.me/emacs_telega/30754

view details

Zajcev Evgeny

commit sha 627d9698edd189b9063476440d6de855ec923f3e

[enh] Do not strip properties for chatbuffer name Makes emojis correctly appear in minibuffer when selecting a chat

view details

push time in 17 days

PR opened zevlg/telega.el

[fix] `custom-declare-variable' wants a form rather than a value

It's even highlighted in the docstring of custom-declare-variable but I missed it:

DEFAULT should be an expression to evaluate to compute the default value, not the default value itself.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchakater/telega.el

branch : dired-dwim-target

created branch time in a month

push eventakater/magit

Jonas Bernoulli

commit sha 1048d5a55032d8579ed2c0fcc8221c72f170f376

Fix what fill-paragraph did to a doc-string

view details

Jonas Bernoulli

commit sha f85c4efb52a2a6f6fa3376686c36d1698c1d95b9

magit-dispatch: Change binding that conflicts with transient-help

view details

Jonas Bernoulli

commit sha 2bd1d823ddebb0cfef31a3338916aaef9ae01660

magit-diff-wash-submodule: Account for empty commit messages Closes #4538.

view details

Akater

commit sha b982a3350fd90c19c7525c24fd82d03c6e1dccee

Remove “99th submatch” condition on password hooks

view details

push time in a month

push eventakater/transient

Jonas Bernoulli

commit sha badebdd1c1bad0b0d26ec78903a493c3a7d0a437

Set local checkdoc-symbol-words

view details

Mattias Engdegård

commit sha df13feff339f29d966c3c74128c1b09605a659eb

Remove various duplicated words * lisp/transient.el (transient-child, transient-files) (transient-infix-value): Remove duplicate words in comments, documentation etc. Backport commit 32de11d8de from Emacs.

view details

Jonas Bernoulli

commit sha ee8bdcfcee0ca3dc9ef9cb4e1c12ff4f9709127c

Fix alias definition Don't define an alias for a symbol that is itself an obsolete alias.

view details

Stefan Monnier

commit sha 7976562a3c1b2ecff086f14bb8200f1d6ef24834

Sharp-quote functions Co-authored-by: Jonas Bernoulli <jonas@bernoul.li> While touching these lines, we might as well update the alignment where appropriate.

view details

Jonas Bernoulli

commit sha 56fb7a91c8818992c869976e02931b1461fedacb

transient-setup: Cosmetics These two variables are always both nil or non-nil, but the latter is better at conveying the meaning "Is a prefix in effect?".

view details

Jonas Bernoulli

commit sha 7126d6aa7625037ce6714945b1e8ff9d9e9bd37c

Fix hydra-inspired colors Red means continue and blue means quit. That doesn't make sense to me but is what hydra uses, which we try to mimic. See https://oremacs.com/2015/02/19/hydra-colors-reloaded.

view details

Jonas Bernoulli

commit sha 791588d118d050727d9ac2050800d96ec6705a31

transient--emergency-exit: Fix doc-string

view details

Jonas Bernoulli

commit sha 0c2255a29636bf828da34291ffbebdbdb294c96f

transient-get-value: Add an emergency exit

view details

Jonas Bernoulli

commit sha 74cba5a418ff1b1661494fc2970c330ecdbb4b22

Release version 0.3.7

view details

Jonas Bernoulli

commit sha 938b059192f053fb69cc196507a25b7e274a9973

transient--show: Set point after displaying window again This fixes #173 a regression in [1: 7c677737]. 1: 2021-09-20 7c67773735dea5a0c41ad8afb69fdafb62c46c7c More flexible display of transient buffer

view details

Jonas Bernoulli

commit sha 62769279a6ff6c45562c95b365c490396ef63262

transient--describe-function: Move definition

view details

Jonas Bernoulli

commit sha 09c911e621fed58e9c8227a69163e31a596e985e

transient--show-manual: New function

view details

Jonas Bernoulli

commit sha 9b6a251f5ca7400e97d904edfc7cb09852d34ba9

transient-show-help: Avoid this-original-command Using `this-original-command' would suggests that the value of `this-command' may have changed but that isn't the case.

view details

Jonas Bernoulli

commit sha df1ba0f14420379a4e0a4eff4f76eb15bc9f5918

transient-show-help: Cosmetics

view details

Jonas Bernoulli

commit sha 222637523ad389a1dbf19e9a65fa1ae62de360dc

transient-show-help: Refactor and improve

view details

Jonas Bernoulli

commit sha ea5ac99ffc9e6acf1abe65625e053ef47ac5045c

transient-show-help: Support per-object help functions

view details

Jonas Bernoulli

commit sha c9ab648e5b59929e44970d7b59a2a61b11544572

transient--show-help: Update doc-strings

view details

Jonas Bernoulli

commit sha 667488ebffe015524e8bbd7eeced626ee52dd7bf

Extend multi-value support Extend `transient-option's methods to deal with it. Deprecate the `transient-files' class whose methods previously responsible for that. Add a second type of multi-value options. Previously only options that can take multiple values were supported, now options that can be repeated are supported as well. Support default values. Closes #154.

view details

akater

commit sha 74d39bb58ccd5171370d01d9f2da8427e9174a44

Use (setf (oref ..) ..) instead of oset oset is obsolete since Emacs 28

view details

push time in a month

delete branch akater/telega.el

delete branch : dired-dwim-target

delete time in a month

issue openedabo-abo/ace-window

Suggestion: ace-{shrink/enlarge}-window-{above/below/left/right}

Provide variations of shrink-window and so on, with avy-style pointers showing the new (upcoming) window border.

It would be best to display the pointers strictly between windows but it's not always possible in GUI. Pointers likely should be placed on both sides of the window but this might not be possible with GUI either, especially with modeline. Still, even inconsistently displayed pointers would be better than nothing.

Note: I don't actually use ace-window; I voiced the idea in a chatroom and it was suggested that this would be nice to have in ace-window.

created time in a month

push eventakater/telega.el

akater

commit sha a656ed5efa1d6234508d804c37d7c1fb9b26ff4d

[enh] Support dired-dwim-target Optionally guess default directory from dired buffers when picking attachments. By default, inherit user's dired-dwim-target setting (dynamically).

view details

Zajcev Evgeny

commit sha a762c08e56a7a73da6555d22c32cbfc951b5d083

[enh] Do not show "2x" button for audio messages

view details

akater

commit sha 29b70bfce6de26386723425d1afea21de4c1e071

322 code review: move read-file-name to util.el Also, make it a public name

view details

akater

commit sha f50894f1f18015d97e328c63fb89ffa2c3f1d87e

322 code review: use provided dir if non-nil

view details

akater

commit sha ee6466b79c39e0d28cb6fbf547df0f7ab1ea1dd5

322 code review: more straightforward interface

view details

akater

commit sha 1d4d8ae39c6d7829ba1488ef9bdc5b6af96180dc

322 code review: safer build

view details

akater

commit sha b9dcdbfe9eece8f0c8bb1b52de0e5b0e7afc9286

322 code review: fix build

view details

akater

commit sha e726c0f3259c27a27a482850d26019e82cc26cc1

322 code review: cleaner build

view details

Zajcev Evgeny

commit sha 7829e605467a3177e143f5c6ff9e55ac00803c8f

Merge pull request #322 from akater/dired-dwim-target [enh] Support dired-dwim-target

view details

akater

commit sha c778353ecf11ad13071694679fc4083f6e520b38

Do not attempt making any images when telega-use-images is nil

view details

push time in a month

push eventakater/telega.el

akater

commit sha a656ed5efa1d6234508d804c37d7c1fb9b26ff4d

[enh] Support dired-dwim-target Optionally guess default directory from dired buffers when picking attachments. By default, inherit user's dired-dwim-target setting (dynamically).

view details

Zajcev Evgeny

commit sha a762c08e56a7a73da6555d22c32cbfc951b5d083

[enh] Do not show "2x" button for audio messages

view details

akater

commit sha 29b70bfce6de26386723425d1afea21de4c1e071

322 code review: move read-file-name to util.el Also, make it a public name

view details

akater

commit sha f50894f1f18015d97e328c63fb89ffa2c3f1d87e

322 code review: use provided dir if non-nil

view details

akater

commit sha ee6466b79c39e0d28cb6fbf547df0f7ab1ea1dd5

322 code review: more straightforward interface

view details

akater

commit sha 1d4d8ae39c6d7829ba1488ef9bdc5b6af96180dc

322 code review: safer build

view details

akater

commit sha b9dcdbfe9eece8f0c8bb1b52de0e5b0e7afc9286

322 code review: fix build

view details

akater

commit sha e726c0f3259c27a27a482850d26019e82cc26cc1

322 code review: cleaner build

view details

Zajcev Evgeny

commit sha 7829e605467a3177e143f5c6ff9e55ac00803c8f

Merge pull request #322 from akater/dired-dwim-target [enh] Support dired-dwim-target

view details

push time in a month

push eventakater/telega.el

akater

commit sha e726c0f3259c27a27a482850d26019e82cc26cc1

322 code review: cleaner build

view details

push time in a month

push eventakater/telega.el

akater

commit sha b9dcdbfe9eece8f0c8bb1b52de0e5b0e7afc9286

322 code review: fix build

view details

push time in a month

push eventakater/telega.el

akater

commit sha ee6466b79c39e0d28cb6fbf547df0f7ab1ea1dd5

322 code review: more straightforward interface

view details

akater

commit sha 1d4d8ae39c6d7829ba1488ef9bdc5b6af96180dc

322 code review: safer build

view details

push time in a month

Pull request review commentzevlg/telega.el

[enh] Support dired-dwim-target

 COMMAND-FUNC - Command function to execute."   :type 'list   :group 'telega-chat) +(defcustom telega-dired-dwim-target 'inherit

This option is anticipated in dired-dwim-target proper and some reasonable choices are offered in its custom interface so it's arguably preferrable to reuse it via custom-variable-type which would also automatically adjust to dired-dwim feature as provided by Emacs, whatever the Emacs version is.

If custom-declare-variable is appropriate, this amounts to

(custom-declare-variable
 'telega-dired-dwim-target
 dired-dwim-target
 "*Value to bind `dired-dwim-target' to, in telega file pickers."
 :type
 (custom-variable-type 'dired-dwim-target)
 :group 'telega-chat)

Since custom-declare-variable is public, I consider this the best approach.

akater

comment created time in a month

PullRequestReviewEvent

Pull request review commentzevlg/telega.el

[enh] Support dired-dwim-target

 COMMAND-FUNC - Command function to execute."   :type 'list   :group 'telega-chat) +(defcustom telega-dired-dwim-target 'inherit
  1. I'm fine with this and I also suggest we drop defcustom telega-dired-dwim-target altogether and just use user's preference for dired-dwim-target.

If we keep it to bind dired-dwim-target to its value unconditionally, it'd make sense then to inherit everything from defcustom dired-dwim-target, including its type so we'd have to use custom-declare-variable rather than defcustom which might be undesirable.

  1. If we nevertheless keep the defcustom, maybe no need for when then? dired-dwim-target-directory will return nil if dired-dwim-target is bound to nil. Unless it's called from a dired buffer in which case it'll offer current dir but looks like it should not be an issue.
akater

comment created time in a month

PullRequestReviewEvent

push eventakater/telega.el

akater

commit sha 29b70bfce6de26386723425d1afea21de4c1e071

322 code review: move read-file-name to util.el Also, make it a public name

view details

akater

commit sha f50894f1f18015d97e328c63fb89ffa2c3f1d87e

322 code review: use provided dir if non-nil

view details

push time in a month

PR opened zevlg/telega.el

[enh] Support dired-dwim-target

Optionally guess default directory from dired buffers when picking attachments. By default, inherit user's dired-dwim-target setting (dynamically).

In telega-describe-chat--inserter you set dir to nil explicitly. I did not change that.

+33 -13

0 comment

2 changed files

pr created time in a month

more