profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/akashdotsrivastava/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Akash Srivastava akashdotsrivastava @bigbinary Bengaluru Developer when sane, writer when sleepless | SE @bigbinary | ex FSD @elitmus

akashdotsrivastava/MGT-automation 1

General purpose automation of time tracking on an assembly floor system

akashdotsrivastava/ace 0

Ace (Ajax.org Cloud9 Editor)

akashdotsrivastava/blog 0

elitmus blog

akashdotsrivastava/bootstrap-switch 0

Turn checkboxes and radio buttons in toggle switches.

akashdotsrivastava/chatwoot 0

Open-source live chat software, an alternative to Intercom, Zendesk, Drift, Crisp etc. 🔥💬

akashdotsrivastava/coderev 0

A toolkit generates side-by-side html pages for code review

akashdotsrivastava/diffy 0

Easy Diffing in Ruby

akashdotsrivastava/docker-api 0

A lightweight Ruby client for the Docker Remote API

PullRequestReviewEvent

Pull request review commentforem/forem

Added collapsed hidden comments to author's article/podcast episode view

 def bust_content_change_caches     Settings::General.admin_action_taken_at = Time.current # Used as cache key   end +  def set_current_user+    @current_user = current_user

@atsmith813 Thanks a lot for the explanation. 👍

@aitchiss @rhymes I'll change the approach and try coming up with a client-side solution. Most of the current code in this PR will be gone. Will keep you folks posted here. Thanks for the support 👍

akashdotsrivastava

comment created time in 22 days

Pull request review commentforem/forem

Added collapsed hidden comments to author's article/podcast episode view

+describe('Hiding article comments flow', () => {

@aitchiss Thank you. Let me give this splitting approach a shot and push changes. Will reach out if I need help.

akashdotsrivastava

comment created time in 22 days

PullRequestReviewEvent

Pull request review commentforem/forem

Added collapsed hidden comments to author's article/podcast episode view

 def bust_content_change_caches     Settings::General.admin_action_taken_at = Time.current # Used as cache key   end +  def set_current_user+    @current_user = current_user

@rhymes Yeah, of course, my first attempt was that, without this extra setup 😊. The thing is all the requests where we need this new current_user filter for hiding/showing/collapsing comments, are prepended with set_cache_control_headers. And there is a concern https://github.com/forem/forem/blob/3fb69eca20ab6e6a995b1768de29d739aea56f5f/app/controllers/concerns/edge_cache_safety_check.rb in play that doesn't let one use current_user anywhere down the tree in that request 😓. It throws this error if we attempt using the current_user directly in such requests:

You may not use current_user in this cached code path.

I know this doesn't look good, but this was the only way I could make current_user work in these requests, by setting an instance variable @current_user (the name can change) to it before set_cache_control_headers is called, for each of these requests.

Suggestion welcome. Happy to change it to something better. 🙏

akashdotsrivastava

comment created time in 23 days

PullRequestReviewEvent

pull request commentforem/forem

Added collapsed hidden comments to author's article/podcast episode view

I added an e2e test for hiding comments flow between an article author and a comment poster. The FE tests seem to be failing with a few other test cases, not relevant to the code/test changes made by me. Thank you.

akashdotsrivastava

comment created time in a month

push eventakashdotsrivastava/forem

Akash Srivastava

commit sha b5ad169082a2d1edae2a5b0e5668b27767bec2c2

Added e2e tests for hiding comments flow

view details

push time in a month

pull request commentforem/forem

Allow iframe inside details liquid tag

@maestromac Thanks for the update. I'll have a look and try to come up with a different PR using the route above in some time. I will update if I need help. Thanks again ♥️👍

akashdotsrivastava

comment created time in a month

pull request commentforem/forem

Added collapsed hidden comments to author's article/podcast episode view

@aitchiss Thanks a lot for the review ♥️. I've been working on an e2e cypress test for the areas covered after the last set of commits I pushed. I'll finish it up and push for review in some time. 👍

akashdotsrivastava

comment created time in a month

Pull request review commentforem/forem

Added collapsed hidden comments to author's article/podcast episode view

 function handleImageUpload(event, randomIdNumber) {   } } +function toggleItemSummaryHtml(item) {

Done

akashdotsrivastava

comment created time in a month

PullRequestReviewEvent

push eventakashdotsrivastava/forem

Akash Srivastava

commit sha 4cd2029ae82e2d619392dfd5c1810fd35212bf6a

1. toggleItemSummaryHtml => updateItemSummaryHtml 2. removed blur after comment html update 3. hidden comment top message different when viewed under post comments and under comment permalink 4. comment does not toggle back to hidden when a reply comment box is open

view details

push time in a month

issue commentforem/forem

Authors Can't Easily Access Hidden Comments on Their Post (to unhide them)

@cmgorton Thank you. A bit late, but I've added a PR for this. #14018

michael-tharrington

comment created time in a month

push eventakashdotsrivastava/forem

Akash Srivastava

commit sha 26c83d85b70cbf0876564d41a1863b43a97cfde5

Added system spec for user hiding a comment

view details

push time in a month

push eventakashdotsrivastava/forem

Suzanne Aitchison

commit sha d21a5d8ed4501d19c4f499013081b212cc8dd97f

Unfinished network requests cause problems with Cypress test setup (#14102) * add login and visit helper, add sign out command * refactors to the admin tests * update article tests * update dashboard flows * update feed nav and listings flows * update logout test * update mod and profile flows * update publishing flows * update reading list, search and tag index flows * wait for sign out, refactor * break chat message tests into more manageable chunks

view details

Mac Siri

commit sha c8e16808f4169a6625e59ef24b39650d47a1b854

Apply unstaged yarn.lock changes (#14112)

view details

Mac Siri

commit sha f4cf94d700100bff9d291b38528a0c3b7fb1aad8

Change default value for saw_onboarding (#14105)

view details

Mac Siri

commit sha fb07a5687956c215609ab3717277fc2ee6e8b2a5

Track Profile count in RecordDataCountsWorker (#14113)

view details

dependabot[bot]

commit sha b6e8d5891ea6aadb05510bda7f71c6152a843bf4

Bump stripe from 5.34.0 to 5.35.0 (#14116) Bumps [stripe](https://github.com/stripe/stripe-ruby) from 5.34.0 to 5.35.0. - [Release notes](https://github.com/stripe/stripe-ruby/releases) - [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md) - [Commits](https://github.com/stripe/stripe-ruby/compare/v5.34.0...v5.35.0) --- updated-dependencies: - dependency-name: stripe dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha e492324f0bf69a32376d17f6fbf10a729def9800

Bump fastly from 3.0.1 to 3.0.2 (#14117) Bumps [fastly](https://github.com/fastly/fastly-ruby) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/fastly/fastly-ruby/releases) - [Changelog](https://github.com/fastly/fastly-ruby/blob/master/CHANGELOG.md) - [Commits](https://github.com/fastly/fastly-ruby/compare/v3.0.1...v3.0.2) --- updated-dependencies: - dependency-name: fastly dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Suzanne Aitchison

commit sha 6bed507081b5a2b56bf9cb949e7478209404af23

[15 min fix] Stub article network requests in pinPost cypress test (#14111) * stub unneeded network requests * add to stub, wait on page load

view details

dependabot[bot]

commit sha 816855ce3b1c49eaa38f65c63878b33228b1ee9f

Bump rubocop from 1.17.0 to 1.18.0 (#14107) * Bump rubocop from 1.17.0 to 1.18.0 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * yarn install * Fix violations * Restore the default aligned setting * Trigger Travis CI * Escape HTML Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rhymes <github@rhymes.dev>

view details

dependabot[bot]

commit sha 53d3cc0c3471f20c333bee85b2d8b3a52471a4f1

Bump rubocop from 1.18.0 to 1.18.1 (#14118) Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.18.0...v1.18.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Michael Kohl

commit sha 83dc9408b602718d89c924b7d82fea643bb4e316

Drop profile fields for static attributes (#14109) * Drop profile fields for static attributes * Update profile page with static field form * Fix specs * Update Cypress test

view details

Akash Srivastava

commit sha 9373934d22fc43645159d0435a8c060e6a2515f5

Added collapsed hidden comments to author's article view

view details

Akash Srivastava

commit sha a7edc823c97348a28e49e9b64f04155d6d076ffb

Fixed comments display on articles show

view details

Akash Srivastava

commit sha 547e81c9e91b4807a40e9cca7c8a2e2b05257ea6

Fixed should_be_hidden? for public urls, fixed specs

view details

Akash Srivastava

commit sha 93970defdfafe48a812d78971fbd3d39739c63cd

Added comments helper spec

view details

Akash Srivastava

commit sha 32634fb82746045a4f66795191e5ea9722e42c68

Added comments helper spec for comments#tree_for

view details

push time in a month

startedwelldone-software/why-did-you-render

started time in a month

push eventakashdotsrivastava/forem

Akash Srivastava

commit sha f2de1e4b4d0698a10b6360cef79a84f694edcb12

Added comments helper spec for comments#tree_for

view details

push time in a month

push eventakashdotsrivastava/forem

Akash Srivastava

commit sha 2aa113ecbf846dad6172202cef9d58d27dcc98bc

Added comments helper spec

view details

push time in a month

push eventakashdotsrivastava/forem

dependabot[bot]

commit sha b248e466a486ef89ea31c9630d2a303726a4277a

Bump prettier from 2.3.1 to 2.3.2 (#14074) Bumps [prettier](https://github.com/prettier/prettier) from 2.3.1 to 2.3.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.3.1...2.3.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 3e25102cc464fa31a0bf7621c1473b7ffe555ebd

Bump @storybook/addon-storysource from 6.2.9 to 6.3.0 (#14073) Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.2.9 to 6.3.0. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.3.0/addons/storysource) --- updated-dependencies: - dependency-name: "@storybook/addon-storysource" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Michael Kohl

commit sha a627ede98d69b205c19b61fda90a6031bb021caf

Don't show "Skip to content" link for searches (#14072)

view details

dependabot[bot]

commit sha 04669c612fdeda530a23c2632e0f8a24342e92ea

Bump honeycomb-beeline from 2.4.1 to 2.4.2 (#14076) Bumps [honeycomb-beeline](https://github.com/honeycombio/beeline-ruby) from 2.4.1 to 2.4.2. - [Release notes](https://github.com/honeycombio/beeline-ruby/releases) - [Changelog](https://github.com/honeycombio/beeline-ruby/blob/main/CHANGELOG.md) - [Commits](https://github.com/honeycombio/beeline-ruby/compare/v2.4.1...v2.4.2) --- updated-dependencies: - dependency-name: honeycomb-beeline dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Suzanne Aitchison

commit sha 112c3d19b232c5f615b89c4b55e15e574d3a00b7

simplify metadata for preview cards and sticky nav (#14068)

view details

dependabot[bot]

commit sha 8be17b81fe323066050c9a4ea705942d49b50f44

Bump @storybook/addon-docs from 6.2.9 to 6.3.0 (#14077) Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.2.9 to 6.3.0. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.3.0/addons/docs) --- updated-dependencies: - dependency-name: "@storybook/addon-docs" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 8a33f71f65c8a09c69a5045fa9709bbfd4c7c864

Bump sass from 1.34.1 to 1.35.1 (#14081) Bumps [sass](https://github.com/sass/dart-sass) from 1.34.1 to 1.35.1. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.34.1...1.35.1) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

okyanusoz

commit sha c0dd9dc40e9b072d05e0fd617b15ca10c5069989

Update imgproxy.md (#14084)

view details

dependabot[bot]

commit sha b9b1becbe30b0323e35c8c8ee7540717b50bd395

Bump chart.js from 3.3.2 to 3.4.0 (#14088) Bumps [chart.js](https://github.com/chartjs/Chart.js) from 3.3.2 to 3.4.0. - [Release notes](https://github.com/chartjs/Chart.js/releases) - [Commits](https://github.com/chartjs/Chart.js/compare/v3.3.2...v3.4.0) --- updated-dependencies: - dependency-name: chart.js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Daniel Uber

commit sha d585ae2bf82ea3587f35a28ef51309dd85e4583f

Prevent occasional matching on random name by specifying one (#14087) We could mistakenly be picking up matches on user "name" rather than user username due to faker giving a name like "Gale" or "Haley" or "Annalee" which match the search term "ale". Give an explicitly non-matching pattern for the name string to prevent this. Sampling from Faker::Name.name and filtering for case insensitive matching against the search term shows slightly higher than 1% of results will match this "ale" triple. Low enough to go unnoticed for a long time.

view details

dependabot[bot]

commit sha 54a952e8537cf5e0752842a5e4c9d3e9d575ee18

Bump eslint from 7.28.0 to 7.29.0 (#14089) Bumps [eslint](https://github.com/eslint/eslint) from 7.28.0 to 7.29.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v7.28.0...v7.29.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha de0d71fe1430c6f5f69a7773b5c4021326e6a5bc

Bump @rails/ujs from 6.0.3-7 to 6.1.4 (#14080) Bumps [@rails/ujs](https://github.com/rails/rails) from 6.0.3-7 to 6.1.4. - [Release notes](https://github.com/rails/rails/releases) - [Commits](https://github.com/rails/rails/commits/v6.1.4) --- updated-dependencies: - dependency-name: "@rails/ujs" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 64573f4068cb3743753332de7d7bbfe7ce4c4efb

Bump @storybook/addon-links from 6.2.9 to 6.3.1 (#14093) Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/addons/links) from 6.2.9 to 6.3.1. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.3.1/addons/links) --- updated-dependencies: - dependency-name: "@storybook/addon-links" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha dd0796ec74a55e092935b38cc040bfc1c823b3f2

Bump web-share-wrapper from 0.2.1 to 0.2.2 (#14090) Bumps [web-share-wrapper](https://github.com/philnash/web-share-wrapper) from 0.2.1 to 0.2.2. - [Release notes](https://github.com/philnash/web-share-wrapper/releases) - [Commits](https://github.com/philnash/web-share-wrapper/compare/v0.2.1...v0.2.2) --- updated-dependencies: - dependency-name: web-share-wrapper dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Mac Siri

commit sha ffe31cd5aad3aa67daf3ff7ad4f415c062b4eb28

Change default value for editor version (#14063) * Create migration * Remove explicit "v2" usages * Fix broken spec * Update spec/system/user_uses_the_editor_spec.rb Co-authored-by: Jamie Gaskins <jgaskins@hey.com> Co-authored-by: Jamie Gaskins <jgaskins@hey.com>

view details

Suzanne Aitchison

commit sha ad5caa1f671f239e9d3c1fdf033cf174756556a8

remove extra margin (#14086)

view details

dependabot[bot]

commit sha 285462baac91cda2c8c85a238b25e2c5b7ef5fe0

Bump @storybook/addon-storysource from 6.3.0 to 6.3.1 (#14092) Bumps [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/addons/storysource) from 6.3.0 to 6.3.1. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.3.1/addons/storysource) --- updated-dependencies: - dependency-name: "@storybook/addon-storysource" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

rhymes

commit sha c2a7038406a44499ed29ff6d3d4cf90712a609fc

Chat: disconnect IntersectionObserver (#14091)

view details

dependabot[bot]

commit sha 8b888a61db847cff05d03548d2ec3722e1373524

Bump focus-trap from 6.4.0 to 6.5.1 (#14095) Bumps [focus-trap](https://github.com/focus-trap/focus-trap) from 6.4.0 to 6.5.1. - [Release notes](https://github.com/focus-trap/focus-trap/releases) - [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md) - [Commits](https://github.com/focus-trap/focus-trap/compare/v6.4.0...v6.5.1) --- updated-dependencies: - dependency-name: focus-trap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 0063a8be00a075930e9531d3f9f124d47c7d3b0a

Bump @storybook/addon-docs from 6.3.0 to 6.3.1 (#14096) Bumps [@storybook/addon-docs](https://github.com/storybookjs/storybook/tree/HEAD/addons/docs) from 6.3.0 to 6.3.1. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v6.3.1/addons/docs) --- updated-dependencies: - dependency-name: "@storybook/addon-docs" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in a month

push eventakashdotsrivastava/forem

Akash Srivastava

commit sha 0c9ea04b09e8d6b231b88feffa3a1b45710cad7d

Fixed should_be_hidden? for public urls, fixed specs

view details

push time in a month

push eventakashdotsrivastava/forem

Akash Srivastava

commit sha b04ca15b8225cdf9644890f9ad6c0f6bc3b7ba36

Fixed comments display on articles show

view details

push time in a month

push eventakashdotsrivastava/forem

Supritha

commit sha f67e6d01d911cde4d569b099a3515dce3bdea4a2

Fixed typo 'SlideSare' (#14011)

view details

Julien Maury

commit sha aba55f2a77dd5dd1e063a5339babfe909f0e1393

stories list script as separate js file - defer attribute (#13993) * stories list script as separate js file - defer attribute * change name storiesListScript for storiesList * remove legacy function hasClass() * add description to js pack * remove case that triggers nothing * Revert "remove case that triggers nothing" the if statement is on the element not its parents This reverts commit f4402f5456e15da122f9820917f5965a1ebc50a4. * remove deprecated code from storiesList pack * remove unused code

view details

Suzanne Aitchison

commit sha 1a417174c36b6ea845b3c4d067a9131c9524fd49

Profile Preview Cards (RFC #222): Article page author byline (#13990) * move current profile card content to shared view, create profile preview card shared view * article page: show link in small screens, button with preview card in larger * initialize the hover and click functionality * tweak class names * make sure modals sit at highest elevation level * add cypress tests * add a test to make sure mobile view unaffected * make sure follow buttons initialized in test before asserting on them

view details

dependabot[bot]

commit sha 5a75e303bded8de02ddf5d9c1a4fb5623e2f7873

Bump acts-as-taggable-on from 8.0.0 to 8.1.0 (#14027) Bumps [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on) from 8.0.0 to 8.1.0. - [Release notes](https://github.com/mbleigh/acts-as-taggable-on/releases) - [Changelog](https://github.com/mbleigh/acts-as-taggable-on/blob/master/CHANGELOG.md) - [Commits](https://github.com/mbleigh/acts-as-taggable-on/compare/v8.0.0...v8.1.0) --- updated-dependencies: - dependency-name: acts-as-taggable-on dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Mac Siri

commit sha 7ba3c3a81cd7147386dae9ce8c88b2ac0802744e

Add container tag expiration (#14040)

view details

Michael Kohl

commit sha 7fe5c54161a013af387bb3f9f30b08da6024fd0a

Consistently use ForemInstance.private? (#14021)

view details

dependabot[bot]

commit sha e56009bcda42823e4638e23e9f8c05ff1e53413e

Bump set-getter from 0.1.0 to 0.1.1 (#14039) Bumps [set-getter](https://github.com/doowb/set-getter) from 0.1.0 to 0.1.1. - [Release notes](https://github.com/doowb/set-getter/releases) - [Commits](https://github.com/doowb/set-getter/commits/0.1.1) --- updated-dependencies: - dependency-name: set-getter dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

rhymes

commit sha a9e7bc4361d24eeb19ff1601996778852ec5472b

Reading list: fix broken pagination (#14031)

view details

dependabot[bot]

commit sha 49e53bb8179ef8c632247bdd98112cb980291989

Bump @babel/core from 7.14.3 to 7.14.6 (#14024) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.14.3 to 7.14.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.6/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 767e1efdfe2f7f1e12455dea2ece13e467476c2f

Bump core-js from 3.14.0 to 3.15.0 (#14026) Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.14.0 to 3.15.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.15.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha bde3ebda8be588c3c1f27d03dbbd0ff59663385b

Bump @babel/preset-env from 7.14.4 to 7.14.7 (#14044) Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.4 to 7.14.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.14.7/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha d1c32b4e1272809c9af354df690165f87f51842c

Bump rails-settings-cached from 2.5.2 to 2.6.0 (#14042) * Bump rails-settings-cached from 2.5.2 to 2.6.0 Bumps [rails-settings-cached](https://github.com/huacnlee/rails-settings-cached) from 2.5.2 to 2.6.0. - [Release notes](https://github.com/huacnlee/rails-settings-cached/releases) - [Changelog](https://github.com/huacnlee/rails-settings-cached/blob/main/CHANGELOG.md) - [Commits](https://github.com/huacnlee/rails-settings-cached/compare/v2.5.2...v2.6.0) --- updated-dependencies: - dependency-name: rails-settings-cached dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Empty commit for travis Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Uber <dan@forem.com>

view details

Suzanne Aitchison

commit sha 546e64a0299265d63171ef6b9bccbf75bd5d1bfd

Always show preview card on hover (#14032) * always show preview on hover * avoid use of important

view details

Suzanne Aitchison

commit sha d448abae192e14d8b7842c5822843889c766ce89

remove instantclick change listener on analytics dashboard (#14046)

view details

Jamie Gaskins

commit sha f17d808cecef51f8d2cbeb8b539c7a4f135fd1f3

Fix sitemap for self host, including memory leak (#14036) * Only load Rake tasks once * Use local sitemap if AWS credentials are not set * Leave generated sitemaps out of git

view details

Suzanne Aitchison

commit sha a64611c03edf060eac4d7b9e5301144f614398a0

disable message options spec (#14047)

view details

dependabot[bot]

commit sha f24d3d157f25a6efe5a489014f2932363277543a

Bump rubocop-rails from 2.10.1 to 2.11.0 (#14043) * Bump rubocop-rails from 2.10.1 to 2.11.0 Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.10.1 to 2.11.0. - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.10.1...v2.11.0) --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Enable new cops and fix violations * Remove expected string literal As we're passing a block (that yields a string) there are no arguments to the debug call. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rhymes <github@rhymes.dev> Co-authored-by: Dan Uber <dan@forem.com>

view details

Michael Kohl

commit sha f03d56c8c9828b7a028664783cadd7d8c664a6ac

Remove badge notice from /settings/profile (#14019)

view details

Andy Zhao

commit sha 7d3bf4b7531eb0534de943f943888ead7e298ef4

[15-min-fix] Ensure mention worker delivers email (#14038) * Ensure mention worker delivers email * Fix spec to appropriately check if mailer was touched

view details

Mac Siri

commit sha 3b20edc9441715a108acee680276f53c1515465e

Resolve sitemap's undefined variable (#14050)

view details

push time in a month

PR opened forem/forem

Added collapsed hidden comments to author's article view

What type of PR is this? (check all applicable)

  • [ ] Refactor
  • [ ] Feature
  • [ ] Bug Fix
  • [ ] Optimization
  • [ ] Documentation Update

Description

Adds hidden comments on /comments page of an article only for the author/s

Related Tickets & Documents

#13360

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note on the devices and browsers this has been tested on, as well as any relevant images for UI changes.

UI accessibility concerns?

If your PR includes UI changes, please replace this line with details on how accessibility is impacted and tested. For more info, check out the Forem Accessibility Docs.

Added/updated tests?

  • [ ] Yes
  • [ ] No, and this is why: please replace this line with details on why tests have not been included
  • [ ] I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the development process, or any of our internal teams? If so, please note how you will share this change with the people who need to know about it.

  • [ ] I've updated the Developer Docs and/or Admin Guide, or Storybook (for Crayons components)
  • [ ] I've updated the README or added inline documentation
  • [ ] I will share this change in a Changelog or in a forem.dev post
  • [ ] I will share this change internally with the appropriate teams
  • [ ] I'm not sure how best to communicate this change and need help
  • [ ] This change does not need to be communicated, and this is why not: please replace this line with details on why this change doesn't need to be shared

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

+53 -23

0 comment

5 changed files

pr created time in a month

startedms-yogi/frontendQuickbytes

started time in 2 months

startedWebReflection/linkedom

started time in 2 months

issue commentforem/forem

Authors Can't Easily Access Hidden Comments on Their Post (to unhide them)

@nickytonline I'd like to give this a shot.

michael-tharrington

comment created time in 2 months