profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/agile6v/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
agile6v agile6v @Xiaomi Beijing, China

agile6v/awesome-nginx 851

A curated list of awesome Nginx distributions, 3rd party modules, Active developers, etc. :octocat:

agile6v/container_cpu_detection 34

Calculate the number of available CPUs in the container.

agile6v/my-shell-tool 3

useful shell toolkit for me, maybe for you.

agile6v/nginx_core_widget 2

collection of small and useful nginx add-ons.

agile6v/anti-emulator 0

Android Anti-Emulator

agile6v/apisix 0

The Cloud-Native API Gateway

agile6v/argo 0

Argo Workflows: Get stuff done with Kubernetes.

agile6v/awesome-github 0

An exquisite list of awesome :octocat: secrets.

agile6v/awesome-go 0

A curated list of awesome Go frameworks, libraries and software

issue commentkubernetes/ingress-nginx

split large configuration file

Hi @tao12345666333 if I understand it correctly splitting configuration file can reduce the memory consumption. Because the current strategy is to render the whole configuration file, so if there are many ingress resources, the configuration will be very large and frequent changes can cause excessive consumption. Thanks.

adou0510

comment created time in 5 days

issue commentkubernetes/ingress-nginx

New shared dict.

@sumitaneja @kys1230 Please see documentation here. Thanks.

sumitaneja

comment created time in 5 days

PR opened kubernetes/ingress-nginx

fix typos.

<!--- Provide a general summary of your changes in the Title above ---> <!--- Please don't @-mention people in PR or commit messages (do so in an additional comment). --->

What this PR does / why we need it:

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. -->

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

<!-- (optional, in fixes #<issue number> format, will close that issue when PR gets merged):

fixes # -->

How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. -->

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I've read the CONTRIBUTION guide
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
+2 -2

0 comment

2 changed files

pr created time in 10 days

push eventagile6v/ingress-nginx

Josh Soref

commit sha 28c8009850e46b352ead37a2dddabeeb728ac5d0

Grammar and spelling fixes

view details

Josh Soref

commit sha 0ad41bf4e5aa0671f83c31be79a6b119f78c48f2

Further clarifications Co-Authored-By: cmluciano <cmluciano@cruznet.org>

view details

Andrey Voronkov

commit sha bced1ed8b8142dbb5246e1db353b277a2b4e3a8f

Ability to separately disable access log in http and stream contexts Two new configuration options: `disable-http-access-log` `disable-stream-access-log` Should resolve issue with enormous amount of `TCP 200` useless entries in logs Signed-off-by: Andrey Voronkov <voronkovaa@gmail.com>

view details

Andrey Voronkov

commit sha 96d86995e1585641ba0295ee65bfe07ebb5b1046

Disable Access Log tests. Draft. Signed-off-by: Andrey Voronkov <voronkovaa@gmail.com>

view details

Gian Ortz

commit sha 3820aa416b7f13b8ea50854d00b9f0acfce5acf9

Add annotation to set value for burst multiplier on rate limit

view details

Manuel Alejandro de Brito Fontes

commit sha 90830034d34c730660a7bb04ab85dcc2b00a6ccc

Update trace modules

view details

Manuel Alejandro de Brito Fontes

commit sha 333288e755c1d5ca5474efcd6448388628c7e5a7

Library dd-opentracing cannot be static

view details

Adrian Joian

commit sha 062397649ec22cad9f13d4c183a6c7067aff44f2

AKS example of adding an internal loadbalancer This is a simple example of adding an Azure internal loadbalancer when creating the ingress controller.

view details

ozhuang

commit sha d1e0da7a360c2190fd62029f16b9335a5278788e

Fixed proxy protocol link

view details

Manuel Alejandro de Brito Fontes

commit sha c2884a3da2dd8b5735598431a85307acc352a9dd

Update test runner image

view details

Ashish Billore

commit sha 534b77a94a2b677c0e8e79afb9f8173dedfa1387

Update deploy instructions with corrections Fix minor typos and improve readability for deploy instructions.

view details

Kubernetes Prow Robot

commit sha bcd33a8d2522f21dc5b182c9bfe70147107f1194

Merge pull request #6130 from ashish-billore/patch-1 Update deploy instructions with corrections

view details

Manuel Alejandro de Brito Fontes

commit sha ccb1eb49251bdb801a30054918c7e3e463bbf896

Add e2e tests to verify opentracing libraries

view details

Manuel Alejandro de Brito Fontes

commit sha 0925f20d0585e629b84df078069e913bc698231a

Refactor load of tracer load

view details

Manuel Alejandro de Brito Fontes

commit sha 4ce686f8491b7eaa33bbd8e4f5cc1af7f9d2fb11

Update nginx image

view details

Manuel Alejandro de Brito Fontes

commit sha d1abba4c8aceb8b801521198dd51590d9ae77f18

Update test runner image

view details

Manuel Alejandro de Brito Fontes

commit sha d13fdf01f6db92bd0d0aba87ffffe36a87af78f0

Update zipkin library location

view details

Manuel Alejandro de Brito Fontes

commit sha b26ebb005024f209e31b9342887425ef70e107ca

Update default gzip level

view details

Kubernetes Prow Robot

commit sha 6a2d9b3b022ad37b237b1e45396cb40aa8c5a284

Merge pull request #6128 from ozhuang/patch-1 Fixed proxy protocol link

view details

Manuel Alejandro de Brito Fontes

commit sha f30a32a6e30533abca13f84b718c321e64286882

Switch modules to dynamic and remove http_dav_module

view details

push time in 10 days

issue commentkubernetes/ingress-nginx

Use body_filter is not working

@tangchen-blip Hope this will help you.

1. define nginx variable in your ingress resource

nginx.ingress.kubernetes.io/server-snippet: |
  set $upstream_response_body "";

2. write your lua plugin

See: https://github.com/kubernetes/ingress-nginx/blob/main/rootfs/etc/nginx/lua/plugins/README.md)

local ngx = ngx

local _M = {}

function _M.body_filter()
    local resp_body = ngx.arg[1]
    ngx.ctx.buffered = (ngx.ctx.buffered or "") .. (resp_body or "")
    if ngx.arg[2] then
        ngx.var.upstream_response_body = ngx.ctx.buffered
    end
end

return _M

3. change the log format & enable lua plugin in your configmap resource

log-format-upstream: '$upstream_response_body'
plugins: logging (your plugin name)

Note that Nginx variables cannot be created on-the-fly. See: https://github.com/openresty/lua-nginx-module#ngxvarvariable

tangchen-blip

comment created time in 10 days

push eventagile6v/apisix

agile6v

commit sha f94fb9aade8f729f55ca4166c4795b0ddc14221a

install proxy-cache plugin

view details

push time in 16 days

push eventagile6v/apisix

agile6v

commit sha bd30df27f36d3664fc457833a8a7be546859174b

Merge branch 'master' of https://github.com/apache/apisix

view details

Joey

commit sha c7725fec128809d059407a49ab99de1829ca0431

docs: Add ARM64 support for getting-started guide (#5025)

view details

agile6v

commit sha 1a787f51acefeacdafe183bada53232875019add

fix error for ci.

view details

agile6v

commit sha e5b43362cbb39a5dbd285f37dd610e802601608f

Merge branch 'master' of github.com:agile6v/apisix

view details

agile6v

commit sha 2b778b7d60a8771af15185fe4415c4ea6f7bec2b

Merge branch 'master' of https://github.com/apache/apisix

view details

push time in 16 days

issue commentapache/apisix

feature: introduce memory-based proxy-cache plugin.

@agile6v Try to set the proxy_temp_path to /dev/shm or other tmpfs file systems can be an alternative way to implement the memory-based proxy cache.

/dev/shm or tmpfs is a good workaround. But it has a serious problem that it cannot be cleaned up in time when the disk space is full. It may cause client receive 500 response code. Thanks.

agile6v

comment created time in 16 days

issue commentapache/apisix

feature: introduce memory-based proxy-cache plugin.

Sorry for the long delay.

agile6v

comment created time in 16 days

PR opened apache/apisix

feat(proxy-cache): support memory-based strategy

What this PR does / why we need it:

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. -->

#1304

Pre-submission checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [x] Have you added corresponding test cases?
  • [x] Have you modified the corresponding document?
  • [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
+1530 -295

0 comment

12 changed files

pr created time in 16 days

push eventagile6v/apisix

okaybase

commit sha 579ef5ad98bd5fa4e1f450f2615ef1af7b674158

docs(discovery): add eureka and nacos (#5018)

view details

agile6v

commit sha d05b6ca0add58bd52f4856e8ae746e4f36a6a3e8

Merge branch 'apache:master' into master

view details

push time in 16 days

push eventagile6v/apisix

agile6v

commit sha 71c3ac105cef17edd7f39bea9418d3a03f6cc1df

Update proxy-cache doc.

view details

push time in 16 days

push eventagile6v/apisix

罗泽轩

commit sha 6c6ad38c9e56a62bea375873431c3cf59de6770e

ci: switch to stale action (#4887)

view details

okaybase

commit sha 8c793ed7630f04becd894fc23196a445f11505cd

feat(kafka-logger): add required_acks option (#4878)

view details

大可

commit sha 0eeb7dd07862759ba10438d645dedbcaced5d93f

docs: remove slash for skywalking (#4894)

view details

罗泽轩

commit sha 949584bd8c57d51659ea847d635eee5aa3d2827a

docs: show how well APISIX is maintained (#4893) Someone asks about if APISIX is active, and here is the answer. Signed-off-by: spacewander <spacewanderlzx@gmail.com>

view details

tzssangglass

commit sha 12596ba6c070fb7ff76cdd5b8722c904218cedae

feat(kafka-logger): add cluster name support (#4876)

view details

罗泽轩

commit sha b198c0377c20a2331514a3ac9361ea16f17f8496

chore: check if the configuration file is loaded (#4900)

view details

okaybase

commit sha d3d477861069e53d359d47c6889189fbc2455618

refactor(kafka-logger): identify the broker ahead of time (#4863)

view details

罗泽轩

commit sha 302bbe5237b72448f7a9f4e281e53d0232e45b25

chore: remove unused items from gitignore (#4890) Signed-off-by: spacewander <spacewanderlzx@gmail.com>

view details

dependabot[bot]

commit sha 3c0547b87f08e989e8f672dcd244a8a3fe3a5de0

chore(deps): bump actions/setup-go from 2.1.3 to 2.1.4 (#4901) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.3 to 2.1.4. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](https://github.com/actions/setup-go/compare/v2.1.3...v2.1.4) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Xu_Mj

commit sha 5c831bb06e0b9e554738947ea72de448e932c622

docs: add upstream parameter for stream route description of admin-api.md (#4907) Co-authored-by: Alex Zhang <tokers@apache.org>

view details

罗泽轩

commit sha c924eb1cded079ec0d6279b211466b7d84a91ec2

feat: release 2.9 (#4883)

view details

Way2go

commit sha b1a9114cc0c308637fd9864ce40e2b78d35b3b0c

fix: validation during merging node_listen configuration (#4881)

view details

罗泽轩

commit sha 3707fe9a0909bb9d9fe6ba3561124d0096d85efb

docs: refer to the whole apisix-build-tools project for building APISIX OpenResty (#4913) Signed-off-by: spacewander <spacewanderlzx@gmail.com>

view details

Joey

commit sha be92ff937d2e2d2831daa6dfccff68fe7a3af8ea

chore(ci): bump build-tools version to v2.1.0 (#4914) Signed-off-by: imjoey <majunjie@apache.org>

view details

Kishani Kandasamy

commit sha b306e238762e0412b0b3e0f6e32b22b09d111c4f

docs: update Readme File (#4899) Co-authored-by: liuxiran <belovedxixi@126.com>

view details

okaybase

commit sha a60b7b939569c6d38fcae1708747b415695bf017

feat(referer-restriction): add blacklist and message (#4916)

view details

RocFang

commit sha a8355bae6911b8e5da5f60a161ead9fe5af34e14

style: unify some return type in logger handlers (#4915)

view details

jackstraw

commit sha 3c01202d704722b97751f111af6e6bb656d56d63

fix(plugin_config): recover plugin when plugin_config changed (#4888) Co-authored-by: spacewander <spacewanderlzx@gmail.com>

view details

罗泽轩

commit sha f73094bba9143a67490e998d3bc25d140fcb5ab7

docs: we support mTLS on L4 (#4927) Signed-off-by: spacewander <spacewanderlzx@gmail.com>

view details

okaybase

commit sha f8eac5e725edd7323ee7b1f7be05b3fbc080fe70

chore(kafka-logger): add brokers info to log and update docs (#4908)

view details

push time in 17 days

IssuesEvent

pull request commentkubernetes/kubernetes

Make label comamnd's response msg more exact.

ping @rikatz

agile6v

comment created time in 25 days

PR opened Kong/kong

fix(proxy-cache) invalid variable use

<!-- NOTE: Please read the CONTRIBUTING.md guidelines before submitting your patch, and ensure you followed them all: https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributing -->

Summary

fix invalid variable use

+2 -2

0 comment

1 changed file

pr created time in a month

push eventagile6v/kong

agile6v

commit sha ba63b882a20c9b3bdcd9e68aac1a9d47123c0d6f

fix(proxy-cache) invalid variable use

view details

push time in a month

fork agile6v/kong

🦍 The Cloud-Native API Gateway

https://konghq.com/install/#kong-community

fork in a month

pull request commentkubernetes/kubernetes

Make label comamnd's response msg more exact.

/test pull-kubernetes-node-e2e-containerd

agile6v

comment created time in a month

push eventagile6v/apisix

罗泽轩

commit sha ee990a0e28767d49e17178ed5ab8c20719be92e3

perf(ext-plugin): use new API to improve setting body (#4806) Signed-off-by: spacewander <spacewanderlzx@gmail.com>

view details

okaybase

commit sha b7cbaed5f59fcf7a941682183cdd3482a517c8a5

feat(limit-*): add custom reject-message for traffic control (#4808)

view details

juju

commit sha 4cf483d3c456593ec7a146838668c0f52acfa80a

docs: update the example of route's fields in English doc (#4811)

view details

Crazy_Coder

commit sha 3920160f98388c1d7afaaedd65c58436240f5a68

docs: fix the bug of route's example json (#4816)

view details

okaybase

commit sha 4a4b9463ffba0242cddeea02e354d9ca772c4b8c

test: correct typo in tests (#4818)

view details

罗泽轩

commit sha 03f09127f301165ca98e6b887004a60058055fb0

feat(real-ip): implement the first version (#4813)

view details

tzssangglass

commit sha 1cfbaa82f56444eca4c7db7b22beb55b333942a2

docs: improve bug report template (#4822)

view details

agile6v

commit sha ca5ea1ffa43881f418ca17c2627bcc4183756a59

fix(proxy-cache): keep cache_method same with nginx's proxy_cache_methods (#4814)

view details

RocFang

commit sha e244940ea69c00a1477e434f542fa8459d3ef302

feat(gzip): support special * to match any type (#4817)

view details

okaybase

commit sha a2723dc11bfb1a3869d487855e47d31dcded3e3d

docs: update file path of the ngx_tpl.lua (#4831)

view details

tzssangglass

commit sha fca0a8a26adc4cc4baa848abafd36b2921dd1996

fix: 4785 (#4832)

view details

Joey

commit sha 09978f280a354f2ff5bae5ae0a6595edcf24465f

ci: change centos7 package name with el7 (#4836) Signed-off-by: imjoey <majunjie@apache.org>

view details

罗泽轩

commit sha 21251d70e5904b57459f9b60a8c06d1480fbe048

chore: sync latest mime.types from Nginx (#4821) Signed-off-by: spacewander <spacewanderlzx@gmail.com>

view details

罗泽轩

commit sha 15a175a5115125f192c73ba74e22c533d1bc0f55

feat(cli): add options to configure max timers (#4826) Signed-off-by: spacewander <spacewanderlzx@gmail.com>

view details

罗泽轩

commit sha a671909576ae98f697df8f225124c0b09989cdb6

test: fuzz with the simple http case (#4815)

view details

罗泽轩

commit sha 8bebafcd74f45d29f59778dabe8626d171b2ef9a

ci: protect release branches from deleted (#4841)

view details

okaybase

commit sha 38ce585d0734c45dcac82e5ab2ae47786e458c43

chore(limit-count): don't return plugin inner error info to caller (#4830)

view details

Peter Yang

commit sha b0246c81ffb26f7e219b7a32b235b65a29256fcf

feat: add question issue template (#4833)

view details

罗泽轩

commit sha b72404f643f37b10eb164056d784c33a97251c46

feat(ext-plugin): support ExtraInfo (#4835) * feat(ext-plugin): support ExtraInfo Signed-off-by: spacewander <spacewanderlzx@gmail.com> * ensure to use str Signed-off-by: spacewander <spacewanderlzx@gmail.com> * fix test Signed-off-by: spacewander <spacewanderlzx@gmail.com> * ws Signed-off-by: spacewander <spacewanderlzx@gmail.com>

view details

Joey

commit sha f263079a1a6539cfa7b59bbfc3d81f5ebaa2765c

ci: Remove non-exist dependency packages for CentOS 7 (#4844)

view details

push time in a month

push eventagile6v/apisix

push time in a month

pull request commentkubernetes/kubernetes

Fix `kubectl unlabel` response msg

Hello @astraw99 @rikatz I think label command can provide more exact response msg.

Like this:


$ kubectl label pod apple-app foo=bar
pod/apple-app labeled

$ kubectl label pod apple-app foo=bar --overwrite
pod/apple-app not labeled

$ kubectl label pod apple-app foo=bar1 --overwrite
pod/apple-app labeled

$ kubectl label pod apple-app foofoo=barbar foo-
pod/apple-app labeled & unlabeled

$ kubectl label pod apple-app foofoo-
pod/apple-app unlabeled

I submitted a PR for this. Hopefully understand it correctly. Thanks.

astraw99

comment created time in a month

PR opened kubernetes/kubernetes

Make label comamnd's response msg more exact.

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide/first-contribution.md#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here: https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label
  3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
  4. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  5. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests -->

What type of PR is this?

<!-- Add one of the following kinds: /kind bug /kind cleanup /kind documentation /kind feature /kind design

Optionally add one or more of the following kinds if applicable: /kind api-change /kind deprecation /kind failing-test /kind flake /kind regression -->

/kind bug

What this PR does / why we need it:

Provide more exact response msg for users.

Which issue(s) this PR fixes:

<!-- Automatically closes linked issue when PR is merged. Usage: Fixes #<issue number>, or Fixes (paste link of issue). If PR is about failing-tests or flakes, please post the related issues/tests in a comment and do not use Fixes --> Fixes #104371

Special notes for your reviewer:

Does this PR introduce a user-facing change?

<!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md -->

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

<!-- This section can be blank if this pull request does not require a release note.

When adding links which point to resources within git repositories, like KEPs or supporting documentation, please reference a specific commit and avoid linking directly to the master branch. This ensures that links reference a specific point in time, rather than a document that may change over time.

See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files

Please use the following format for linking documentation:

-->


+47 -25

0 comment

2 changed files

pr created time in a month

push eventagile6v/kubernetes

agile6v

commit sha a39407265139205f2c719aa01a487afcac9b32a3

Make label comamnd's response msg more exact.

view details

push time in a month

push eventagile6v/kubernetes

astraw99

commit sha 7953cf0ce9f890b6cba7de3325a7ce68609832a0

fix typo of rate limiter

view details

qhdxssm@qq.com

commit sha 76f03f000a1b0d94fd20d24a9f0f63ae939c8fc8

Fix use variables in the loop in vsphere_util

view details

Jordan Liggitt

commit sha ccbdf041a2f73318fcebce9e3fe5818d152b7732

Fix slice type comparison bug

view details

Claudiu Belu

commit sha 3c1a3dea59c31ab9f5e1ff2350eca719af3c2b2c

test images: Adds Windows Server 2022 to the BASEIMAGEs The Container Images for Windows Server 2022 have been published, and we can start building test images using them, so we can start adding jobs for them. The image versions for the e2e test images have been bumped in a previous commit, but haven't been promoted yet. We don't need to bump them here. We're starting with windows-servercore-cache and busybox images, since they are needed for the other images the most. A previous added LD_FLAGS for the go binary compilation, but it's not defined for all images.

view details

fabiankramm

commit sha b1a6f8cdf90c0a3861157fea24dcfa89c2aafcf9

kubectl proxy: append context host path to request path Signed-off-by: fabiankramm <fab.kramm@googlemail.com>

view details

Antonio Ojea

commit sha 3a660b72941d95672633d78c6e0df9b56d92dab0

bump e2e loadbalancer timeouts to 15m

view details

Kubernetes Prow Robot

commit sha 40f05cec281bca57b898c3bf629dbc056eccf3da

Merge pull request #104373 from astraw99/fix_typo_rate_limiter Fix typo of rate limiter

view details

Kubernetes Prow Robot

commit sha f4e1558af0f409677237106f3dd52bfc0d3d64f5

Merge pull request #104451 from claudiubelu/test-images/windows-server-2022 test images: Adds Windows Server 2022 to the BASEIMAGEs

view details

Kubernetes Prow Robot

commit sha 341d312066bd650e70995cd1a15925035b524a7d

Merge pull request #97350 from FabianKramm/master kubectl proxy: append context host path to request path

view details

Kubernetes Prow Robot

commit sha c8a91dc3a81794c09ef9965a8cd3d3ffdfdbb961

Merge pull request #104478 from aojea/lb_timeouts bump e2e loadbalancer timeouts to 15m

view details

Kubernetes Prow Robot

commit sha 7652353523b5d49ad2d6a8766d4df5b1ce30d3e3

Merge pull request #104435 from liggitt/convertible-test Fix slice type comparison bug

view details

Jordan Liggitt

commit sha 322bc827771c70c6f3559d502156daee58b14589

Fix buffered signal channel go vet error

view details

Kubernetes Prow Robot

commit sha 499a1f99a93ebff836b0ebc4316f29c4600fc29e

Merge pull request #104489 from liggitt/signal-buffer Fix buffered signal channel go vet error

view details

Kubernetes Prow Robot

commit sha 3a26b864f4e17a6b7e0e673f583a551820a25b36

Merge pull request #104410 from skyguard1/fix_node_names_util Fix using variables in the loop in vsphere_util

view details

push time in a month

fork agile6v/kubernetes

Production-Grade Container Scheduling and Management

https://kubernetes.io

fork in a month

Pull request review commentapache/apisix

fix(proxy-cache): keep cache_method same with nginx's proxy_cache_methods

 http {             proxy_cache                         $upstream_cache_zone;             proxy_cache_valid                   any {% if proxy_cache.cache_ttl then %} {* proxy_cache.cache_ttl *} {% else %} 10s {% end %};             proxy_cache_min_uses                1;-            proxy_cache_methods                 GET HEAD;+            proxy_cache_methods                 GET HEAD POST;

It doesn't affect the default behavior of APISIX, which means that user can specify the POST method on APISIX.

Here you change the Nginx template, without a configurable setting. This is a change for default havior.

Whether to enable is here (cache_method)

agile6v

comment created time in a month

PullRequestReviewEvent

Pull request review commentapache/apisix

fix(proxy-cache): keep cache_method same with nginx's proxy_cache_methods

 http {             proxy_cache                         $upstream_cache_zone;             proxy_cache_valid                   any {% if proxy_cache.cache_ttl then %} {* proxy_cache.cache_ttl *} {% else %} 10s {% end %};             proxy_cache_min_uses                1;-            proxy_cache_methods                 GET HEAD;+            proxy_cache_methods                 GET HEAD POST;

Is it necessary to cache a POST request?

The only I can think of for caching POST requests is that some internal specification forces the consistent use of POST requests……

Yes. This is a very rare scenario. The users don't enable the method on APISIX, it doesn't take effect. If users enable it, they need to know what they are doing.

agile6v

comment created time in a month

PullRequestReviewEvent