profile
viewpoint
Adrien Baron adrienbaron The App Business London, UK https://www.clashofstats.com/ Creator of ClashOfStats.

VueGWT/vue-gwt 169

Vue.js Components/Custom Elements in Java with GWT. Developed at https://www.genmymodel.com.

VueGWT/vue-gwt-demo 13

Simple demo GWT app using Vue GWT

VueGWT/vue-gwt-eclipse-plugin 2

Eclipse Plugin for Vue GWT

VueGWT/vue-gwt-intellij-plugin 2

IntelliJ Plugin for Vue GWT

adrienbaron/vue-custom-element 1

Vue Custom Element - Web Components' Custom Elements for Vue.js

adrienbaron/Android-PWA-Wrapper 0

Android Wrapper to create native Android Apps from offline-capable Progressive Web Apps

adrienbaron/closure-vue-sample 0

Experiments on Vue.js + Closure compatibility

adrienbaron/consent-manager 0

Drop-in consent management plugin for analytics.js

push eventCarolineClark/GGJ2020

adrienbaron

commit sha aaa3d4def31e6279f1c2996b2bdf3d43a34eb5c1

Add floor tile model

view details

adrienbaron

commit sha b26e7086f5eaa33b35a0fb073ae132624c8ba49f

Add positioning of tiles

view details

Matt Radbourne

commit sha b1fc55102c1e7acd3b11f92dbe45cbbd9e949d35

Add title screen

view details

Matt Radbourne

commit sha b7f57fc144a723554cb2b28fb4eea117b0a2c767

Add SVG package and SVG player asset

view details

Matt Radbourne

commit sha f86aa16493453d28aa4233b55af73e350680cd91

Set up scenes in build settings

view details

Matt Radbourne

commit sha a911e7709f16265768f6110672afc5ec31d72e77

Update title screen bg image and allow game to be started with Enter

view details

Matt Radbourne

commit sha f2657a8a849a03b0e2a30c5c20e6046c4cd9ce78

Update title screen layout

view details

adrienbaron

commit sha 16d70839f31bc356bd2718892ba72d1786c67046

Reset angles to 0

view details

adrienbaron

commit sha f635dfb1062f350cdf04ca387e2613fb740e145a

Add gravestone model

view details

adrienbaron

commit sha a799c7f0cf0f4ce60b88f3f48087c7065325924f

Merge remote-tracking branch 'origin/master'

view details

CarolineClark

commit sha 14533bdff8256ac1d0c919c44e4bb5cf7b015280

WIP

view details

CarolineClark

commit sha 7ad7543689a499c6a440027007dc5feb34bbbf85

Merge branch 'master' of https://github.com/CarolineClark/GGJ2020

view details

Ryan Loader

commit sha 183dbaf74a31f958a3dcd0fdcaae05819e9fd6bd

Fix rotation of the control cube

view details

adrienbaron

commit sha 18bfcc090419328142b26edd4c8eecad6b880083

Add arrow up material to all tiles

view details

Ryan Loader

commit sha eef6aab41a094aa60a04e295e7f5726d9e05c8e4

Add debug texture to control cube

view details

CarolineClark

commit sha 96405971c83e4c5679063d1166ca1d7880f35e74

WIP

view details

CarolineClark

commit sha be113184c878a771273172c5d37d92b1a120ad4c

WIP

view details

Ryan Loader

commit sha 040ee7d87210e3929aff8a5d0aef61b0bf2ce079

Add debug tile materials

view details

Matt Radbourne

commit sha 87a4094f94eaf2ccf0d9e27ea5f5f9cce2e804ff

Ad PARALLAX to title screen

view details

Matt Radbourne

commit sha d2edd70a8e1a5327807d75fae4b4db9b25f9b88d

I HAVE ADDED A TREE

view details

push time in 22 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 2356fe758ac4b976016da4ee40d1e98f5696c24a

Add lights and mirroring to various levels

view details

adrien.baron

commit sha 0a3e296dc65b889e9eea9fc1113d7336e2dbd8a0

Merge remote-tracking branch 'origin/master' # Conflicts: # Assets/Scenes/AdrienScene.unity

view details

adrien.baron

commit sha f5cd72e588bb0acde90300de8ede4322babea497

Fix water and ending on AdrienScene

view details

push time in 23 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha ce54dcb776660170986010b3acf5197b9a9a5e6c

Resize player

view details

adrien.baron

commit sha 766fd0d490f82898ef72bc11552c76121c087bbb

Merge remote-tracking branch 'origin/master'

view details

push time in 23 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 84788955895a3a255cdff0724be1a2c3f2b72f0d

Improve gravestone on tutorial scene

view details

push time in 23 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 1c0f18703bed10941ac1d2e9621d1f2244a57a68

Add gravestones and goal to AdrienScene

view details

push time in 23 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 65afa56fad16bb666cdcb557ca80bea8d31efba6

Add camera transition to teleport

view details

adrien.baron

commit sha de30efbd0b9e26701c234a7f83461ada8c2b4d43

Merge branch 'master' of https://github.com/CarolineClark/GGJ2020

view details

adrien.baron

commit sha 703345eed7de4c4a0817f4f4c621bd5d08dc97ad

Add a prefab camera

view details

push time in 23 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha bf5b81a9e6dc3151e4c5646f75fec553ea391e39

Add portal transportation

view details

adrien.baron

commit sha e79c2a13098c4c5626cc71f1fce63ab114487638

Make maps separate on portal

view details

push time in 23 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 900595f3360711f52fd828d20af9dbf80e440209

Add particle effects

view details

push time in 23 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha a63a058e149078c35f5f84473789a69260299694

Add rotation to the tiles

view details

push time in 24 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 3aa8d26225db528b77adeba50e2247fd4708d60e

Add new grass material

view details

push time in 24 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 5a0a07b95aae8d56b2036f8bcee7bb78c59a2f8e

Add grass and stone materials and set them

view details

push time in 24 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 5351a2bcb63f8e37f284ae807ad71a7d209e36e8

Set tiles textures

view details

push time in 24 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 58a28c2bcebcccfe84381c480aec0c6246d0dcc1

Add rotation to tiles

view details

adrien.baron

commit sha 7e9d00d121fee095e559482ebb8e5091773b078e

Add rotation to right tiles

view details

adrien.baron

commit sha 80dc8254b2ac2953faa98d1631d7e615bacb5ef3

Merge animation and rotation

view details

push time in 24 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 0875ffb374c527b295f6b6a7c01006f7b0b7bea8

Add arrow up material to all tiles

view details

push time in 24 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 63165f57f621269b77f5ef44a8ef04b38de53a25

Reset angles to 0

view details

adrien.baron

commit sha 0a9bcf0fb8312603cc2aaf7f714aef258e0f9b8b

Add gravestone model

view details

adrien.baron

commit sha 749f782fe98096e73a262cfda4c13d2a3509f060

Merge remote-tracking branch 'origin/master'

view details

push time in 24 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha 79959bb851115eebbbaf12ca683ba59051737a5f

Add positioning of tiles

view details

push time in 24 days

push eventCarolineClark/GGJ2020

adrien.baron

commit sha d0ae14fa6226cb5f544fb52644e98954226c461a

Add floor tile model

view details

push time in 24 days

issue commentVueGWT/vue-gwt

Replace Nashorn

Ok! Looks easy enough then! Even better they seem to support Node, so we might even not have to run webpack to bundle all the JS of the template compiler together and commit the result, and just import the npm dependency 👌

adrienbaron

comment created time in a month

issue commentVueGWT/vue-gwt

Replace Nashorn

@mdavis95 https://github.com/VueGWT/vue-gwt/blob/master/processors/src/main/java/com/axellience/vuegwt/processors/component/template/builder/compiler/NashornVueTemplateCompiler.java

adrienbaron

comment created time in a month

push eventVueGWT/vue-gwt

adrienbaron

commit sha 425d4d28a715b5474b0bd82b47ca2988f3955cea

refactor: use collector joining instead of String.join + Collectors.toList

view details

adrienbaron

commit sha c3363b3381af9e1008406561bdf0eedd1646edb7

chore: start adding tests for J2CL disabling GWT2 tests for now, trying to get tests to pass for J2CL

view details

adrienbaron

commit sha ff3eb8f6af6812c6f9de393dbab70908d8133283

chore: temporarly disable J2CL plugin executions

view details

push time in a month

push eventVueGWT/vue-gwt

adrienbaron

commit sha 425d4d28a715b5474b0bd82b47ca2988f3955cea

refactor: use collector joining instead of String.join + Collectors.toList

view details

push time in a month

push eventVueGWT/vue-gwt

adrienbaron

commit sha 0f495fe8bbe8850762e9a52b6d8350d353cfd035

chore: temporarly disable J2CL plugin executions

view details

push time in a month

create barnchVueGWT/vue-gwt

branch : chore/j2cl-tests

created branch time in a month

push eventVueGWT/vue-gwt-demo

adrienbaron

commit sha 2021e173bbf1caab5a2932e2b5d83d813434843d

chore: add plugin repository for Vertispan repos

view details

push time in a month

delete branch VueGWT/vue-gwt-demo

delete branch : fix/j2cl-wip

delete time in a month

push eventVueGWT/vue-gwt-demo

adrienbaron

commit sha 65330b19ac1b26bb6baa09f362d864db4800b665

chore: update to latest J2CL maven plugin

view details

adrienbaron

commit sha 72d7dc6e2605d1cfd81c1dd9fa8ea876b415c775

chore: remove Vue externs, they are now included in Vue GWT library directly

view details

push time in a month

push eventVueGWT/vue-gwt

adrienbaron

commit sha 14f2a1afee7faee351f3d031a9eb1b2d0cd76f16

feature: add Vue externs

view details

push time in a month

pull request commentVueGWT/vue-gwt

Small changes to make j2cl and closure happier with this lib

Thanks @niloc132 !

niloc132

comment created time in a month

push eventVueGWT/vue-gwt

Colin Alworth

commit sha 6ed87c26c1fb8680829a404c62ce5291797f93ce

Small changes to make j2cl and closure happier with this lib

view details

push time in a month

PR merged VueGWT/vue-gwt

Small changes to make j2cl and closure happier with this lib

First, introduces a JS file for @externs, so that closure-compiler knows about the types and fields we insist will be present at runtime. If we had a real type for the constructor (instead of just Function), we would make a specific type for that instead. Without VCE, j2cl is believing that there is an actual module (closure, ecmascript, etc) names VueCustomElement instead of just a js.dot.separated.object. In theory we could change the name to something like name="VueCustomElement.createElement" instead, and mark the namespace as global, but it turns out that doesnt work in GWT2, so this hopefully serves as a consistent way to do it for everyone.

Finally, closure has changed its rules about invoking goog.define, the changes made here make it happy with our code. Chances are excellent we'll need to revisit superdevmode later and put it somewhere shared, but for now this at least compiles correctly.

+30 -6

0 comment

3 changed files

niloc132

pr closed time in a month

startedTypescript-TDD/ts-auto-mock

started time in a month

issue openedVueGWT/vue-gwt

Replace Nashorn

Nashorn engine has been deprecated as from JDK11, and is removed in JDK12. We should find a solution to replace it. Either using GraalVM: https://github.com/graalvm/graal-js-jdk11-maven-demo Or Rhino: https://github.com/mozilla/rhino

created time in a month

create barnchVueGWT/vue-gwt-demo

branch : fix/j2cl-wip

created branch time in a month

push eventVueGWT/vue-gwt

adrienbaron

commit sha 31dd67f204daab1576c576d908a259371b86fb65

chore: update node and yarn versions in tests

view details

adrienbaron

commit sha ea837c20d752e028d923490a31f74fb585348849

chore: update npm dependencies on tests

view details

push time in a month

startedposva/pinia

started time in 2 months

PR opened segmentio/consent-manager

Replace isomorphic-fetch with isomorphic-unfetch

Hi!

This PR switches from isomorphic-fetch to isomorphic-unfetch. There have been no commits in isomorphic-fetch in the last 4 years, and in the meantime (2 years ago) a new major version of node-fetch has been released.

Because of the dependency on isomorphic-fetch, we are getting the old version of node-fetch when depending on consent-manager on our project.

isomorphic-unfetch uses [unfetch])(https://github.com/developit/unfetch) on the client and the latest node-fetch on the server, and preserve the same API as isomorphic-fetch.

I recognise this would require a new major release of your library. I feel however it would be valuable for your users, and would avoid issues in the future as the new version (2.x) of node-fetch increases the compliance of WHATWG's Fetch Standard.

+13 -11

0 comment

3 changed files

pr created time in 3 months

push eventadrienbaron/consent-manager

adrien.baron

commit sha a649c2e6df500305bab0de23c8f1388f89c573a5

Replace isomorphic-fetch with isomorphic-unfetch

view details

push time in 3 months

startedvuejs/vue

started time in 3 months

PR closed vuetifyjs/vuetify

style(all): fix comma dangling error on .ts component files

<!-- MAKE SURE TO READ THE CONTRIBUTING GUIDE BEFORE CREATING A PR https://github.com/vuetifyjs/vuetify/blob/master/.github/CONTRIBUTING.md

Testing and markup sections can be removed for documentation changes -->

<!-- Provide a general summary of your changes in the Title above --> <!-- Keep the title short and descriptive, as it will be used as a commit message -->

Description

<!--- Describe your changes in detail --> I ran yarn lint:fix and comited the changes.

Motivation and Context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Running yarn lint on master currently results in a lot of linting error related to the rule 'comma-dangle': ['error', 'always-multiline'].

How Has This Been Tested?

<!--- Please describe how you tested your changes. --> <!--- Have you created new tests or updated existing ones? --> <!--- e.g. unit | visually | e2e | none --> No tests needed as it's only stylistic changes.

Markup:

<!--- Paste markup for testing your change ---> <details>

// Paste your FULL Playground.vue here

</details>

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] The PR title is no longer than 64 characters.
  • [x] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • [x] My code follows the code style of this project.
  • [ ] I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • [ ] I've added new examples to the kitchen (applies to new features and breaking changes in core library)
+194 -194

4 comments

122 changed files

adrienbaron

pr closed time in 4 months

pull request commentvuetifyjs/vuetify

style(all): fix comma dangling error on .ts component files

Ok will close then, I have to figure out what's happening on my machine 👍

adrienbaron

comment created time in 4 months

pull request commentvuetifyjs/vuetify

fix(VTooltip): make tooltip activator visible on SSR initial render

@KaedWD Would working on a potential reimplemation of detachable in a codesandbox be useful? Or do you already have a clear idea of how to go about it?

adrienbaron

comment created time in 4 months

pull request commentvuetifyjs/vuetify

fix(VTooltip): make tooltip activator visible on SSR initial render

Good catch for the flex layout! I forgot about that case :+1: If there is something I can do to help the detachable story feel free to tell me :).

adrienbaron

comment created time in 4 months

pull request commentvuetifyjs/vuetify

style(all): fix comma dangling error on .ts component files

I don’t think so, I tried deleting my node_modules and running yarn install again from the root of the project and the issue was still there. Happy to close if nobody else reproduces though.

adrienbaron

comment created time in 4 months

startedvuetifyjs/vuetify

started time in 4 months

PR opened vuetifyjs/vuetify

style(all): fix comma dangling error on .ts component files

<!-- MAKE SURE TO READ THE CONTRIBUTING GUIDE BEFORE CREATING A PR https://github.com/vuetifyjs/vuetify/blob/master/.github/CONTRIBUTING.md

Testing and markup sections can be removed for documentation changes -->

<!-- Provide a general summary of your changes in the Title above --> <!-- Keep the title short and descriptive, as it will be used as a commit message -->

Description

<!--- Describe your changes in detail --> I ran yarn lint:fix and comited the changes.

Motivation and Context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> Running yarn lint on master currently results in a lot of linting error related to the rule 'comma-dangle': ['error', 'always-multiline'].

How Has This Been Tested?

<!--- Please describe how you tested your changes. --> <!--- Have you created new tests or updated existing ones? --> <!--- e.g. unit | visually | e2e | none --> No tests needed as it's only stylistic changes.

Markup:

<!--- Paste markup for testing your change ---> <details>

// Paste your FULL Playground.vue here

</details>

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] The PR title is no longer than 64 characters.
  • [x] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • [x] My code follows the code style of this project.
  • [ ] I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • [ ] I've added new examples to the kitchen (applies to new features and breaking changes in core library)
+194 -194

0 comment

122 changed files

pr created time in 4 months

create barnchadrienbaron/vuetify

branch : style/fix-eslint

created branch time in 4 months

PR opened vuetifyjs/vuetify

fix(vtooltip): make tooltip activator visible on SSR initial render

<!-- MAKE SURE TO READ THE CONTRIBUTING GUIDE BEFORE CREATING A PR https://github.com/vuetifyjs/vuetify/blob/master/.github/CONTRIBUTING.md

Testing and markup sections can be removed for documentation changes -->

<!-- Provide a general summary of your changes in the Title above --> <!-- Keep the title short and descriptive, as it will be used as a commit message -->

Description

Remove display: none; from .v-tooltip class.

Motivation and Context

Upon initial SSR rendering, the activator for a tooltip is contained inside the root of the VTooltip component like so:

<span class="v-tooltip v-tooltip--bottom">
  <div
    class="v-tooltip__content"
    style="left:0px;max-width:auto;opacity:0;top:12px;z-index:0;display:none;"
  ></div>
  <div>ACTIVATOR</div>
</span>

Because v-tooltip is display: none; the activator is not visible.

When JS kicks in the DOM gets modified by the beforeMount of Detachable and the activator gets moved out like so:

<div>ACTIVATOR</div>
<span class="v-tooltip v-tooltip--bottom">
  <div class="v-tooltip__content" style="left:0px;max-width:auto;opacity:0;top:12px;z-index:0;display:none;"></div>
</span>

Removing this display: none; fix the SSR issue as the activator gets displayed before JS kicks in. Moreover as tooltip__content is empty before JS kicks in and also have display:none; set, this change shouldn't have any side effect on that front.

How Has This Been Tested?

<!--- Please describe how you tested your changes. --> <!--- Have you created new tests or updated existing ones? --> <!--- e.g. unit | visually | e2e | none --> I've tested this by overriding this style on my project that uses Nuxt + Vuetify and checking it fixes the SSR issue. I didn't notice any side effects, tooltips still work as expected. I've also tested in the playground and it also seems to work without issue.

Markup:

<!--- Paste markup for testing your change ---> <details>

<template>
  <v-container>
    <v-tooltip bottom>
      <template v-slot:activator="{ on }">
        <v-btn v-on="on">Hover me</v-btn>
      </template>
      This is a tooltip
    </v-tooltip>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
    //
    }),
  }
</script>

</details>

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] The PR title is no longer than 64 characters.
  • [x] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • [x] My code follows the code style of this project.
  • [ ] I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • [ ] I've added new examples to the kitchen (applies to new features and breaking changes in core library)
+0 -2

0 comment

1 changed file

pr created time in 4 months

push eventadrienbaron/vuetify

adrienbaron

commit sha 4493df98c122f6425b48b73366292bace5379b4c

fix(vtooltip): make tooltip activator visible on SSR initial render

view details

push time in 4 months

fork adrienbaron/vuetify

🐉 Material Component Framework for Vue.js 2

https://vuetifyjs.com

fork in 4 months

issue commentnuxt-community/vuetify-module

Vuetify with tree shake enabled in SSR doesn't render property

@freddy38510 good shout! Yes we would need to figure something out for the main style, I didn’t see it :)! For nuxt purge css you mean to drop unused CSS from the style that are injected in the SSR page?

vishr

comment created time in 4 months

issue commentnuxt-community/vuetify-module

Vuetify with tree shake enabled in SSR doesn't render property

@freddy38510 thanks! I think the only way for this to work is add this hook to every Vuetify components with a PR there. I’ve asked for opinions on their discord, waiting for feedback before proceeding with doing the PR of everything looks OK for them

vishr

comment created time in 4 months

startedzeit/ncc

started time in 4 months

issue commentnuxt-community/vuetify-module

Vuetify with tree shake enabled in SSR doesn't render property

Ok, I found a way to make it work 👍. Sadly it would require quite a few changes in Vuetify :(.

Basically we first would need to change Vuetify components like so:

// Name the styles import
import styles from './VCard.sass'

/* @vue/component */
export default mixins(
  Loadable,
  Routable,
  VSheet
).extend({
  // Add a beforeCreate hook that inject the styles if presents
  beforeCreate() {
    if(styles.__inject__) {
      styles.__inject__(this.$ssrContext)
    }
  },
  // ...
})

Then in Nuxt config you ask the vueStyle loader to use manualInject:

  /*
   ** Build configuration
   */
  build: {
    loaders: {
      vueStyle: { manualInject: true }
    }
  }

When doing so, the style get's injected in the SSR context correctly 👍. This behaviour also applies for SSR mode, the client one still behaves the same (see here for client and here for server)

If manualInject is not set to true, then the current behaviour applies and styles.__inject__ is undefined so the beforeCreate hooks doesn't do anything.

If would add that hook to every component though so it's still has a bit of a performance hit (even though it's just calling a function that immediately returns). Maybe we could find a way for that hook to be defined when running on the server?

Anyway that should probably move the the Vuetify repository if we want to take this further 👍

vishr

comment created time in 4 months

issue commentnuxt-community/vuetify-module

Vuetify with tree shake enabled in SSR doesn't render property

@enddevNZ Indeed, my bad, it does seem to only include the CSS for what's being used in the app, which is much better that what I first thought! However it only include styles for components that end up in the bundle, so components that are used only on a page for example, and would only be in this page bundle will still not have style on SSR (and get it when the bundle for that page loads). Moreover you still might have to load a bit more CSS than necessary (some components might make it to the bundle, but not be used on the actual page you are on, albeit that's probably an edge case :)). The manualInject option from vue-style-loader looks promising though, as it seems to state explicitly that style from non .vue files (which is the case for Vuetify components) would only get bundle in JS and not added to SSR unless you use that option. So maybe there is something there 👍

vishr

comment created time in 4 months

issue commentnuxt-community/vuetify-module

Vuetify with tree shake enabled in SSR doesn't render property

I'm currently investigating the same issue. From what I gathered so far when using treeShake generated style blocks don't get integrated in the SSR result. Using treeShake: false will integrate all Vuetify CSS in the page as a style tag (which we definitely don't want!). Finally the solution pointed out by @SLIpros (using extractCSS) seems to add all the CSS from Vuetify in an external CSS file and load that. We get styles with no JS enabled (Yay!) but we still ship way too much CSS :(. According to Vue Style Loader doc there should be a way to make it inject those style during SSR (which would be best of both world, minimal amount of CSS shipped + instant style without having to wait for JS to kick in). Not sure yet which project this change will impact though, so I'll keep investigating 🔎 !

vishr

comment created time in 4 months

push eventadrienbaron/twobunnies-workshop

adrienbaron

commit sha dcc433edbad615989b710745c26e3ad843ae52bf

add precision on item sprite position

view details

push time in 4 months

push eventadrienbaron/twobunnies-workshop

adrienbaron

commit sha a0dd405680d5188e6e04e4962dfa3f1fa0879ec2

fix instructions on animation

view details

adrienbaron

commit sha 85397673a8e0985a962d2b52b87d1f4977e21c6c

fix typo scale instead of scaleTo

view details

push time in 4 months

push eventadrienbaron/twobunnies-workshop

adrienbaron

commit sha 2006af11a96519032857627627b6510e7304faa3

improve tasks.md file

view details

push time in 4 months

create barnchadrienbaron/twobunnies-workshop

branch : master

created branch time in 4 months

created repositoryadrienbaron/twobunnies-workshop

created time in 4 months

issue commentVueGWT/vue-gwt

consider renaming repo/prj to "vue-java" or "java-vue"

Hi @baldram !

Vue GWT is actually polymorphic and support in theory both GWT2 and GWT3 (that uses J2CL as it's compiler). It doesn't use any specific GWT2 features in core, and the only specific GWT2 integrations (like the GWT Widgets integration) are in a separate optional gwt2 dependency. The only things that Vue GWT relies on for it's Java <=> JS bridge are JsInterop and Elemental2 both of which are compatible with J2CL.

However GWT3 is still being worked on, mostly on the Maven and Gradle plugins to make the J2CL pipeline more developer friendly. @niloc132 actually created a few PRs to add better GWT3 support to Vue GWT that got merged, and the current develop was capable of building a demo project both in GWT2 and GWT3 in June: https://github.com/VueGWT/vue-gwt/tree/develop

I have to get around and find the time to release it though... But you can experiment by cloning that branch locally and running mvn install then depending on 1.0-beta-10-SNAPSHOT :).

For Bazel support I'm not sure what would be required, basically as long as the annotation processor runs and rerun on changes to Java files, Vue GWT doesn't need anything special from the build system.

There are also some Gradle GWT plugin out there that supports Webpack/NPM and Vue GWT: https://github.com/ascendtech/gwt-gradle

As for the name J2CL should be released to the more general public as GWT 3 (as by itself it doesn't do much and needs a whole pipeline around for developer friendliness), so the name should work even for that 👍 I would be curious if you manage to get a project working with Bazel + Vue GWT + J2CL though, that would be quite cool!

janblok

comment created time in 5 months

more