profile
viewpoint
Adityarup Laha adityaruplaha India Just a regular student with interest in computers & code.

adityaruplaha/AarogyaSetu_Android 0

Aarogya Setu Android app native code

adityaruplaha/AlgoSpeedTest 0

A library to compare accuracy and speed of algorithms.

adityaruplaha/C1GamesStarterKit 0

Starter kit for new players of Terminal. Contains starter-algo and a basic CLI for running/debugging algo's locally.

adityaruplaha/citra 0

A Nintendo 3DS Emulator

adityaruplaha/CoinCounter 0

A C++ program to split any amount to coins & notes.

adityaruplaha/discord-bot 0

Citra bot for Discord

adityaruplaha/LemonLime 0

A Nintendo 3DS LLE emulator written in C#

pull request commentnic-delhi/AarogyaSetu_Android

Requesting some changes in the app.

This is an issue, not a PR. Requesting to close.

S1-1

comment created time in 3 days

issue commentnic-delhi/AarogyaSetu_Android

[Security] Protection against unofficial builds on the server side.

@aravindvnair99 that is indeed a good idea, I had thought of the same, but couldn't figure out the details of how to achieve that.

adityaruplaha

comment created time in 3 days

issue commentnic-delhi/AarogyaSetu_Android

Feat: Dark Mode for the App

Would be nice to have, but this is not the highest priority I would say.

NupurThakur27

comment created time in 3 days

pull request commentnic-delhi/AarogyaSetu_Android

Adding Urdu as an optional language.

Please add the following to the PR description to close the related issue automatically:

"Fixes #298."

Mrigank-Tandon

comment created time in 3 days

issue commentnic-delhi/AarogyaSetu_Android

Adding Urdu Language as an optional language.

Fixed by #301.

Mrigank-Tandon

comment created time in 3 days

issue openednic-delhi/AarogyaSetu_Android

Protection against unofficial builds on the server side.

Originally posted by @adityaruplaha in https://github.com/nic-delhi/AarogyaSetu_Android/issues/69#issuecomment-634594596

We need some form of license verification on the server side for all Release builds to ensure that the open-source nature of this app is not exploited.

Refer to https://developer.android.com/google/play/licensing/server-side-verification for how this may be achieved.

created time in 3 days

issue commentnic-delhi/AarogyaSetu_Android

[Request] [Feature] Improving battery life through Accelerometer.

Well I don't see this issue being any useful as given the current codebase, accelarometer use will do more harm than good. Requesting to close.

jash-maester

comment created time in 3 days

issue commentnic-delhi/AarogyaSetu_Android

App doesn't show any warning on connecting with PC by USB (High Priority)

Hey @robustTechie , I think it's the most crucial issue out of all 171 issues from the security point of view. Adding a simple check of BuildConfig.DEBUG will allow developers to develop. Users should be forced to switch to charge only while using the release version.

@pallav12 I see no point in doing that? What is the problem if a user reverses the Release build and accesses files, while they can see the source code anyways?

robustTechie

comment created time in 3 days

Pull request review commentnic-delhi/AarogyaSetu_Android

Create CODE_OF_CONDUCT.md

+# Citizen Code of Conduct++## 1. Purpose++A primary goal of Aarogya Setu Android is to be inclusive to the largest number of contributors, with the most varied and diverse backgrounds possible. As such, we are committed to providing a friendly, safe and welcoming environment for all, regardless of gender, sexual orientation, ability, ethnicity, socioeconomic status, and religion (or lack thereof).++This code of conduct outlines our expectations for all those who participate in our community, as well as the consequences for unacceptable behavior.++We invite all those who participate in Aarogya Setu Android to help us create safe and positive experiences for everyone.++## 2. Open [Source/Culture/Tech] Citizenship++A supplemental goal of this Code of Conduct is to increase open [source/culture/tech] citizenship by encouraging participants to recognize and strengthen the relationships between our actions and their effects on our community.++Communities mirror the societies in which they exist and positive action is essential to counteract the many forms of inequality and abuses of power that exist in society.++If you see someone who is making an extra effort to ensure our community is welcoming, friendly, and encourages all participants to contribute to the fullest extent, we want to know.++## 3. Expected Behavior++The following behaviors are expected and requested of all community members:++ * Participate in an authentic and active way. In doing so, you contribute to the health and longevity of this community.+ * Exercise consideration and respect in your speech and actions.+ * Attempt collaboration before conflict.+ * Refrain from demeaning, discriminatory, or harassing behavior and speech.+ * Be mindful of your surroundings and of your fellow participants. Alert community leaders if you notice a dangerous situation, someone in distress, or violations of this Code of Conduct, even if they seem inconsequential.+ * Remember that community event venues may be shared with members of the public; please be respectful to all patrons of these locations.++## 4. Unacceptable Behavior++The following behaviors are considered harassment and are unacceptable within our community:++ * Violence, threats of violence or violent language directed against another person.+ * Sexist, racist, homophobic, transphobic, ableist or otherwise discriminatory jokes and language.+ * Posting or displaying sexually explicit or violent material.+ * Posting or threatening to post other people's personally identifying information ("doxing").

Okay then.

rxtr007

comment created time in 4 days

pull request commentnic-delhi/AarogyaSetu_Android

Update LICENSE to standard Apache 2.0 Text

Superseded by #122.

ankitpati

comment created time in 4 days

Pull request review commentnic-delhi/AarogyaSetu_Android

Create CODE_OF_CONDUCT.md

+# Citizen Code of Conduct++## 1. Purpose++A primary goal of Aarogya Setu Android is to be inclusive to the largest number of contributors, with the most varied and diverse backgrounds possible. As such, we are committed to providing a friendly, safe and welcoming environment for all, regardless of gender, sexual orientation, ability, ethnicity, socioeconomic status, and religion (or lack thereof).++This code of conduct outlines our expectations for all those who participate in our community, as well as the consequences for unacceptable behavior.++We invite all those who participate in Aarogya Setu Android to help us create safe and positive experiences for everyone.++## 2. Open [Source/Culture/Tech] Citizenship++A supplemental goal of this Code of Conduct is to increase open [source/culture/tech] citizenship by encouraging participants to recognize and strengthen the relationships between our actions and their effects on our community.++Communities mirror the societies in which they exist and positive action is essential to counteract the many forms of inequality and abuses of power that exist in society.++If you see someone who is making an extra effort to ensure our community is welcoming, friendly, and encourages all participants to contribute to the fullest extent, we want to know.++## 3. Expected Behavior++The following behaviors are expected and requested of all community members:++ * Participate in an authentic and active way. In doing so, you contribute to the health and longevity of this community.+ * Exercise consideration and respect in your speech and actions.+ * Attempt collaboration before conflict.+ * Refrain from demeaning, discriminatory, or harassing behavior and speech.+ * Be mindful of your surroundings and of your fellow participants. Alert community leaders if you notice a dangerous situation, someone in distress, or violations of this Code of Conduct, even if they seem inconsequential.+ * Remember that community event venues may be shared with members of the public; please be respectful to all patrons of these locations.++## 4. Unacceptable Behavior++The following behaviors are considered harassment and are unacceptable within our community:++ * Violence, threats of violence or violent language directed against another person.+ * Sexist, racist, homophobic, transphobic, ableist or otherwise discriminatory jokes and language.+ * Posting or displaying sexually explicit or violent material.+ * Posting or threatening to post other people's personally identifying information ("doxing").

Should be doxxing.

rxtr007

comment created time in 4 days

pull request commentnic-delhi/AarogyaSetu_Android

isRooted Detection can be improved

I think root checks should be applied only on release versions, as debug version can be used to find vulnerabilities.

HaneetGH

comment created time in 4 days

Pull request review commentnic-delhi/AarogyaSetu_Android

fix: #179, not allowing release version from running on emulator

 class CorUtility {             return call.execute()         } +        fun checkIfEmulator() = Build.FINGERPRINT.startsWith("generic")+                || Build.FINGERPRINT.startsWith("unknown")+                || Build.MODEL.contains("google_sdk")+                || Build.MODEL.contains("Emulator")+                || Build.MODEL.contains("Android SDK built for x86")+                || Build.BOARD == "QC_Reference_Phone" //bluestacks+                || Build.MANUFACTURER.contains("Genymotion")+                || Build.HOST.startsWith("Build") //MSI App Player+                || (Build.BRAND.startsWith("generic") && Build.DEVICE.startsWith("generic"))+                || "google_sdk" == Build.PRODUCT+

In order to comply with the rest of codebase, please consider using {} and return.

pallav12

comment created time in 4 days

Pull request review commentnic-delhi/AarogyaSetu_Android

fix: #179, not allowing release version from running on emulator

 class CorUtility {                         try {                             val jsonObject = response.body()!!.asJsonObject                             if (jsonObject.has(Constants.FORCE_UPGRADE)) {-                                parseForceUpgradeJson(jsonObject.get(Constants.FORCE_UPGRADE).toString())+                                parseForceUpgradeJson(+                                    jsonObject.get(Constants.FORCE_UPGRADE).toString()+                                )

Minor nit: Code formatting isn't part of the PR, so can this be omitted?

pallav12

comment created time in 4 days

pull request commentnic-delhi/AarogyaSetu_Android

fix: #179, not allowing release version from running on emulator

My concern is, this will make development harder. Pushing dev builds to a physical device after each change isn't feasible. It will be difficult to debug issues.

The source code is public now anyways. What exactly will be the benefit achieved? And is it worth the extra effort in development and maintainance?

https://github.com/nic-delhi/AarogyaSetu_Android/issues/179#issuecomment-634598959

pallav12

comment created time in 4 days

issue commentnic-delhi/AarogyaSetu_Android

security: No checks for running release app on emulator

My concern is, this will make development harder. Pushing dev builds to a physical device after each change isn't feasible. It will be difficult to debug issues.

The source code is public now anyways. What exactly will be the benefit achieved? And is it worth the extra effort in development and maintainance?

pallav12

comment created time in 4 days

issue commentnic-delhi/AarogyaSetu_Android

[feature] dynamic status screen

I agree. Also we need protection against unofficial builds on the server side too.

parshnt

comment created time in 4 days

issue commentnic-delhi/AarogyaSetu_Android

[Request] [Feature] Improving battery life through Accelerometer.

That data can be fetched from internet(If an active internet connection is available) I mean nowadays most people using smartphones are on unlimited plans and are always connected. I am sure servers can handle such load. If an infected person is in an area... The server can send push notifications to nearby devices in that area. irrespective of BLE. 90% of people keep an active internet connection rather than Bluetooth turned ON. Hope this justifies the statement.

Well that is true for urban environments, but not so much for rural ones. Also if you're proposing contact tracing occur over the Internet, I would say that is very dangerous as attackers can intercept internet more easily than BluetoothLE (which is limited in range). This has a lot of privacy concerns, and is unrelated to the accelerometer issue anyways.

jash-maester

comment created time in 4 days

issue commentnic-delhi/AarogyaSetu_Android

Slight Correction in a word (Strings-Telugu)

Issues are related to unmerged PRs should be commented on the PR itself so as not to spam the issue tracker.

Requesting to close.

techy55

comment created time in 4 days

issue commentnic-delhi/AarogyaSetu_Android

[Request] [Feature] Improving battery life through Accelerometer.

What if people around you move about? Contact tracing needs to work in all cases. Even if you sitting still, people can pass near you, possibly causing infection. They also need to be traced.

jash-maester

comment created time in 4 days

issue commentnic-delhi/AarogyaSetu_Android

App doesn't show any warning on connecting with PC by USB (High Priority)

I don't see any need of doing that, source code is public anyways now.

robustTechie

comment created time in 4 days

issue commentnic-delhi/AarogyaSetu_Android

Display infected people details [Not an issue add new features]

I disagree, that undermines the privacy of patients.

Shivam-UI

comment created time in 4 days

PR opened nic-delhi/AarogyaSetu_Android

strings.xml: Update Bengali translations.

Fixes #153. I also translated some untranslated strings where it was needed. 2 strings have been left translated evrywhere, so I didn't touch them as I think it might be intentional.

+16 -16

0 comment

1 changed file

pr created time in 4 days

create barnchadityaruplaha/AarogyaSetu_Android

branch : bn-translation-fix

created branch time in 4 days

pull request commentnic-delhi/AarogyaSetu_Android

Implement Apache License 2.0 properly.

Should be done now.

adityaruplaha

comment created time in 5 days

push eventadityaruplaha/AarogyaSetu_Android

Adityarup Laha

commit sha 9263adc531b4a7201af01e3867cdd94b951189fd

Amend LICENSE.md and rename to LICENSE.

view details

adityaruplaha

commit sha 2b52f2041183aa07aa23a95d4b6b9adbc25113a7

Add license to all source files. (.java, .kt)

view details

push time in 5 days

pull request commentnic-delhi/AarogyaSetu_Android

Implement Apache License 2.0 properly.

You would want to change the file type from markdown to text. Essentially rename the file from LICENSE.md to LICENSE.

I'm aware, I've got a local commit ready for that, I'm currently writing some code to finish the TODO, push changes, and get this PR ready for review.

adityaruplaha

comment created time in 5 days

pull request commentnic-delhi/AarogyaSetu_Android

Implement Apache License 2.0 properly.

TODO: Add boilerplate declaration to all source files.

adityaruplaha

comment created time in 5 days

push eventadityaruplaha/AarogyaSetu_Android

Adityarup Laha

commit sha b610436222a1e420a47339f7787e51d2f13da9b7

Amend LICENSE.md

view details

push time in 5 days

create barnchadityaruplaha/test

branch : master

created branch time in 5 days

created repositoryadityaruplaha/test

created time in 5 days

push eventadityaruplaha/AarogyaSetu_Android

Adityarup Laha

commit sha 47a22f088a200e59171295936afac1ce23cfab30

Implement Apache License 2.0 properly. Fixes #115. The comma between the year and the copyright holder is an error. Also the trailing period has been removed as India is not an abbreviation.

view details

push time in 5 days

issue commentnic-delhi/AarogyaSetu_Android

Apachae LICENSE not implemented properly

Fix proposed.

kshithijiyer

comment created time in 5 days

PR opened nic-delhi/AarogyaSetu_Android

Implement Apache License 2.0 properly.

Fixes #115. The comma between the year and the copyright holder is an error. Also the trailing period has been removed as India is not an abbreviation.

+2 -2

0 comment

1 changed file

pr created time in 5 days

create barnchadityaruplaha/AarogyaSetu_Android

branch : apache-license-fix

created branch time in 5 days

delete branch adityaruplaha/AarogyaSetu_Android

delete branch : chandrapal-yadav-patch-1

delete time in 5 days

delete branch adityaruplaha/AarogyaSetu_Android

delete branch : chandrapal-yadav-update_readme

delete time in 5 days

delete branch adityaruplaha/AarogyaSetu_Android

delete branch : patch-1

delete time in 5 days

push eventadityaruplaha/AarogyaSetu_Android

Adityarup Laha

commit sha cccb77c6763754d54a9c09a5b266a19a90ac052b

Implement Apache License 2.0 properly. The comma placed between the year the copyright holder is an error. Fixes #115.

view details

push time in 5 days

pull request commentnic-delhi/AarogyaSetu_Android

Updated why_needed_fragment

If possible, can you please provide a screenshot of the changes? I don't see how the UI becomes "better".

techjd

comment created time in 5 days

pull request commentnic-delhi/AarogyaSetu_Android

readme_file edit.

This repository only conatins the code for the Android version, not iOS. So I don't think that the link to download from the app store belongs here.

mishraabhinn

comment created time in 5 days

Pull request review commentnic-delhi/AarogyaSetu_Android

use ssl always

  import android.text.TextUtils; -import nic.goi.aarogyasetu.BuildConfig;- import java.util.concurrent.Executors; +import nic.goi.aarogyasetu.BuildConfig;

Unintentional change maybe? Why was the order of imports changed?

ssrahul96

comment created time in 5 days

Pull request review commentnic-delhi/AarogyaSetu_Android

use ssl always

 import androidx.room.Insert; import androidx.room.Query; -import nic.goi.aarogyasetu.models.BluetoothData;

Why this change?

ssrahul96

comment created time in 5 days

pull request commentnic-delhi/AarogyaSetu_Android

Added isEmpty Checks to list

Is unnecessary.

patilashish312

comment created time in 5 days

issue commentnic-delhi/AarogyaSetu_Android

Daily assessment for User.

Nice idea but instead of daily, it could be set at some time interval based on user interest

Or based on the "risk" the person is living in.

developergirl53

comment created time in 5 days

issue commentnic-delhi/AarogyaSetu_Android

Mask detection can be added

I disagree, I would rather not have an app checking my camera whenever I go out.

skullcandy69

comment created time in 5 days

issue commentnic-delhi/AarogyaSetu_Android

[feature] dynamic status screen

I'm not sure if I should create a new issue for this, but I feel that a QR code based solution will work best. For securing entry, you have to scan a QR code presented at (say) the airport. This is highly contactless as no manual checks are needed. Only scan the QR, it sends the identity and location to the server, and now the server knows when and where you entered the country(/state, if implemented).

A possible downside of this may be that someone clicks a photo of the QR and it gets scanned unnecessarily. To counter this, we can add a simple OTP system, sent to a device located at the checkpost where the code is scanned. This code (6 or 8-digits will be good enough I think) changes every 20 seconds or so. The rest of the process is similar to that of apps like Google Authenticator.

parshnt

comment created time in 5 days

startednic-delhi/AarogyaSetu_Android

started time in 5 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha 1252f8660c3fe686a377aae35184ad040e304bfd

Add support for action viewers.

view details

push time in 10 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha 37081a197deda9dbbc17384a310f23e2eb923f3b

A bit of code restructuring and support for new changes to the database structure.

view details

push time in 10 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha 4eb893b2fb9085954d8cb1b54804d32013be46c6

Database restruture, more functionality in various places, and code cleanup.

view details

push time in 14 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha 6a71362e7387493daf19d05e20221a9f9971f6be

Greetings for logged in users and relevant links.

view details

push time in 21 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha 9e41972775113fbbed57675497979809ac6cd862

Implement logging in with Telegram. Security upgrades. Login now required to view anything.

view details

push time in 21 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha 5e519e825794a87e29000c2f165e66b6bfcddeec

Implement logging in with Telegram.

view details

push time in 21 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha d0ef0263827399ed8736cd98e06053875db083c9

Minor fixups.

view details

adityaruplaha

commit sha 6e1f2b839ed6ff5e575e922645c9718635bf3dce

Implement logging in with Telegram.

view details

push time in 21 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha c50eb46b0ded5d2e0d14adff9ab949f5c1c1d8a5

Code refactor to move to namespaces and OOP from procedural style.

view details

push time in 24 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha 2244c4254f1a00b5f083de13ae50254eb89d30a0

attendance: * Show attendance %age for each class * Add "NO DATA" messages. * Minor formatting changes and fixups. defs.php: Remove old comment.

view details

push time in 24 days

push eventadityaruplaha/adityaruplaha-school-website

adityaruplaha

commit sha 8ebfd805b660a04095ebed2befb441852fe515c7

Initial commit.

view details

push time in a month

create barnchadityaruplaha/adityaruplaha-school-website

branch : master

created branch time in a month

created repositoryadityaruplaha/adityaruplaha-school-website

created time in a month

startedImageMagick/ImageMagick

started time in a month

push eventadityaruplaha/adityaruplaha-school-projects

adityaruplaha

commit sha b19d06f356fafdbe4189bade59d4a4d1ffec567f

Algorithms: Add binary search algorithm.

view details

push time in 2 months

PublicEvent

push eventadityaruplaha/adityaruplaha-automail-sc-a

adityaruplaha

commit sha bd418b6e86526890c75a238fffcc990c3408e017

Initial commit.

view details

push time in 2 months

push eventadityaruplaha/OpenGL-Engine

adityaruplaha

commit sha b38f57c7692e63e13196d76e76e5ef212d916c95

Clang format all code.

view details

push time in 2 months

push eventadityaruplaha/OpenGL-Engine

adityaruplaha

commit sha 23d3dacdb908bd7a9870e921f3d2f37a407d5929

Clang format all code.

view details

push time in 2 months

push eventadityaruplaha/OpenGL-Engine

Adityarup Laha

commit sha 33d745673071c535dbf88223e657659de9e3e32d

Project reorganization and migration to CMake.

view details

adityaruplaha

commit sha 8b8b4375f20418a222714986eab1e3ff881b2d3b

Fix compilation on Linux.

view details

adityaruplaha

commit sha 9f9be69ce30a9da480d6a8d1ec7868d9d0eb3ff9

Miscellaneous changes. * common/map_funcs: Optimise implementation of map functions using fmod() to improve performance on Linux. * Use git branch and commit hash for title bar. * Log version info. * Code cleanup and other minor changes.

view details

Adityarup Laha

commit sha 446e2da89fb94a4c600c058d05efec747f78738c

Implement free camera movement. (#1) Implements the following: * Incremental yaw, pitch, roll. * Movement via relative directions. * Support for user control. Also cleans up the camera functionality.

view details

push time in 2 months

delete branch adityaruplaha/OpenGL-Engine

delete branch : free-cam

delete time in 2 months

push eventadityaruplaha/OpenGL-Engine

Adityarup Laha

commit sha f04e4ce73b89ca6f675a91134ecf3af392f6f13d

Implement free camera movement. (#1) Implements the following: * Incremental yaw, pitch, roll. * Movement via relative directions. * Support for user control. Also cleans up the camera functionality.

view details

push time in 2 months

PR merged adityaruplaha/OpenGL-Engine

Implement free camera movement.

Implements the following:

  • Incremental yaw, pitch, roll.
  • Movement via relative directions.
  • Support for user control.

Also cleans up the camera functionality.

+170 -85

0 comment

6 changed files

adityaruplaha

pr closed time in 2 months

PR opened adityaruplaha/OpenGL-Engine

Implement free camera movement.

Implements the following:

  • Incremental yaw, pitch, roll.
  • Movement via relative directions.
  • Support for user control.

Also cleans up the camera functionality.

+170 -85

0 comment

6 changed files

pr created time in 2 months

push eventadityaruplaha/OpenGL-Engine

adityaruplaha

commit sha 2082b379486987e4e35ce33b9e5528515abf569c

Implement keyboard input for controlling the camera. Seperate basic input controls from keyboard stuff.

view details

push time in 3 months

more