profile
viewpoint
Leon Brocard acme Fastly London, UK http://www.astray.com/ Orange HTTP Hacker. Senior Solutions Architect at Fastly.

acme/cpan-mini-webserver 18

Search and browse Mini CPAN

acme/bouncy 5

Playing with SDL

acme/dackup 5

Back up

acme/catalyst-plugin-simpleauth 3

Simple authentication for Catalyst

acme/bisect-perl-using-git 2

Help you to bisect Perl

acme/catalyst-plugin-cookiedsession 2

Store sessions in a browser cookie

acme/cpan-mini-live 2

CPAN::Mini::Live - Keep a live CPAN

acme/data-page 2

Help when paging through sets of results

acme/data-uuid-base64urlsafe 2

URL-safe UUIDs

acme/digest-md5-file-cached 2

Caching MD5 sums for files

issue commentplicease/Devel-ebug

Consider putting this dist up for adoption

Added PLICEASE to co-maintainers of Devel::ebug.

plicease

comment created time in 25 days

issue openedPublicHealthEngland/coronavirus-dashboard

Chart colours are too similar

The chart colours are both "dark blue" and are hard to distinguish:

image

Perhaps we could increase the contrast or use the colour palette in the GOV.UK Design System?

created time in a month

issue commentPublicHealthEngland/coronavirus-dashboard

Add gzip (or similar) to data_latest.json

For example, https://c19downloads.azureedge.net/downloads/data/data_latest.json includes many

{"date": "2020-04-02", "value": 652}

... which could instead be:

{"date":"2020-04-02","value":652}

ECMA-404 The JSON Data Interchange Standard says:

Insignificant whitespace is allowed before or after any token

Parsing JSON is a Minefield, but all parsers should be able to handle parsing without that insignificant whitespace.

Compressing the response with gzip will save more bandwidth.

dracos

comment created time in a month

issue commentPublicHealthEngland/coronavirus-dashboard

Add gzip (or similar) to data_latest.json

Another way to make the JSON file smaller would be to remove unnecessary whitespace, e.g.:

$ cat data_latest.json | jq --compact-output > data_latest_compact.json
$ ls -lh data_latest.json data_latest_compact.json
-rw-r--r--  1 acme  acme   1.6M 28 Apr 19:14 data_latest.json
-rw-r--r--  1 acme  acme   1.4M 29 Apr 14:47 data_latest_compact.json
$ gzip -9 data_latest.json; gzip -9 data_latest_compact.json
$ ls -lh data_latest.json.gz data_latest_compact.json.gz
-rw-r--r--@ 1 acme  acme   127K 28 Apr 19:14 data_latest.json.gz
-rw-r--r--  1 acme  acme   122K 29 Apr 14:47 data_latest_compact.json.gz
dracos

comment created time in a month

issue commentPublicHealthEngland/coronavirus-dashboard

Add gzip (or similar) to data_latest.json

data_latest.json is now even larger, about ~1.7MB, so this issue is more important.

dracos

comment created time in a month

issue commentPublicHealthEngland/coronavirus-dashboard

manifest.json is missing on website

Thanks! This looks good.

acme

comment created time in a month

issue commentPublicHealthEngland/coronavirus-dashboard

Explain the charts

Thanks, looks great.

acme

comment created time in a month

issue commentPublicHealthEngland/coronavirus-dashboard

Explain the charts

Thanks, the description in "About the data" is clear, however it is very separate to the charts.

acme

comment created time in a month

issue openedPublicHealthEngland/coronavirus-dashboard

Manifest.json is missing on website

The HTML pages link to a Web app manifest manifest.json: https://github.com/PublicHealthEngland/coronavirus-dashboard/blob/development/public/index.html#L13 but this manifest does not seem to be present on the website as https://coronavirus.data.gov.uk/manifest.json gives a 404 Not Found error response.

created time in a month

issue openedPublicHealthEngland/coronavirus-dashboard

Explain the charts

Thanks for the dashboard, but I think the charts need a little explanation.

I've seen many people take the drop in numbers for the last few days in the "Daily number of lab-confirmed cases in England by specimen date" chart as proof that the pandemic is over:

image

That's not the case. Instead, the reason is presumably that there is a reporting lag. Perhaps the last few days could be marked as having incomplete data?

There's also a weekly variation in the charts, presumably due to increased lag on weekends. Perhaps weekends could be highlighted on the charts?

I feel the Financial Times Coronavirus tracker does a great job on explaining the charts, for example using a 7-day rolling average to address reporting lag.

created time in a month

PR opened PublicHealthEngland/coronavirus-dashboard

Localise number on Y axis on the charts

All numbers on the page are localised, with the exception of numbers on the Y axis on the charts. Where I am, this means that numbers on the page are formatted with commas for thousands "93,873", but on the Y axis of the chart it has "80000". This commit localises the number of the Y axis, so it now shows "80,000".

+12 -0

0 comment

2 changed files

pr created time in a month

create barnchacme/coronavirus-dashboard

branch : add-commas-to-y-axis-on-charts

created branch time in a month

push eventfastly/fastly2git

Leon Brocard

commit sha 5398ddc58b28388b289f65dd6249dc9805a8d97c

Bump up rake version

view details

Leon Brocard

commit sha ee5459e0386c9a0e31ebddeed12f11644ef016f6

Merge pull request #18 from fastly/acme-bump-rake-version Bump up rake version

view details

push time in 3 months

PR merged fastly/fastly2git

Bump up rake version

Bump up the rake version.

+1 -1

0 comment

1 changed file

acme

pr closed time in 3 months

PR opened fastly/fastly2git

Bump up rake version
+1 -1

0 comment

1 changed file

pr created time in 3 months

create barnchfastly/fastly2git

branch : acme-bump-rake-version

created branch time in 3 months

more