profile
viewpoint

stripe/stripe-react-native 779

React Native library for Stripe.

Yonom/BotBits 10

Focus on your ideas, forget PlayerIOClient.

alexyorke/Rabbit 9

Rabbit is a C# library that intelligently uses the right PlayerIO authentication for your users

Yonom/CupCake 9

A robust bot library for Everybody Edits. Based on MuffinFramework.

kevin-brown/NetIRC 4

The event-driven IRC library for .NET

Yonom/ByteNom 3

A simple to use protocol for client/server communication.

Yonom/BitSend 2

BitSend allows you to send information over an unreliable source, reliably!

Yonom/BotBits.Commands 2

A BotBits extension that makes adding commands to your bots super easy.

Yonom/Edit 2

A CupCake plugin for editing worlds.

Yonom/BotBits.ChatExtras 1

A collection to tools and hacks to make working with chat commands easier.

push eventYonom/kvstore-demo

dependabot[bot]

commit sha f12faa49b5c200d58d931975b6025a4ba45c9a97

Bump follow-redirects from 1.13.0 to 1.14.7 Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.0 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.13.0...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Simon Farshid

commit sha 52679d98b80b1baf7875ab4c16971cd86bf1c384

Merge pull request #15 from Yonom/dependabot/npm_and_yarn/follow-redirects-1.14.7 Bump follow-redirects from 1.13.0 to 1.14.7

view details

push time in 4 days

PR merged Yonom/kvstore-demo

Bump follow-redirects from 1.13.0 to 1.14.7 dependencies

Bumps follow-redirects from 1.13.0 to 1.14.7. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2ede36d7c60d3acdcd324dcd99a9dbd52e4fb3a6"><code>2ede36d</code></a> Release version 1.14.7 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/8b347cbcef7c7b72a6e9be20f5710c17d6163c22"><code>8b347cb</code></a> Drop Cookie header across domains.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/6f5029ae1a0fdab4dc25f6379a5ee303c2319070"><code>6f5029a</code></a> Release version 1.14.6 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/af706bee57de954414c0bde0a9f33e62beea3e52"><code>af706be</code></a> Ignore null headers.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/d01ab7a5c5df3617c7a40a03de7af6427fdfac55"><code>d01ab7a</code></a> Release version 1.14.5 of the npm package.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/40052ea8aa13559becee5795715c1d45b1f0eb76"><code>40052ea</code></a> Make compatible with Node 17.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/86f7572f9365dadc39f85916259b58973819617f"><code>86f7572</code></a> Fix: clear internal timer on request abort to avoid leakage</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2e1eaf0218c5315a2ab27f53964d0535d4dafb51"><code>2e1eaf0</code></a> Keep Authorization header on subdomain redirects.</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/2ad9e82b6277ae2104f7770e9ff1186cc6da29d4"><code>2ad9e82</code></a> Carry over Host header on relative redirects (<a href="https://github-redirect.dependabot.com/follow-redirects/follow-redirects/issues/172">#172</a>)</li> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/77e2a581e1d1811674b7b74745a9c20a5b939488"><code>77e2a58</code></a> Release version 1.14.4 of the npm package.</li> <li>Additional commits viewable in <a href="https://github.com/follow-redirects/follow-redirects/compare/v1.13.0...v1.14.7">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 4 days

PR closed invertase/react-native-firebase

feat(firestore): stricter DocumentData type

Description

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request properly. --> <!-- Explain the motivation for making this change e.g. what existing problem does the pull request solve? -->

Beginning with react-native-firebase 12, setting undefined in a firestore object throws instead of setting it to null. However, typescript does not warn you if you do something like:

await ref.set({
  test: undefined,
});

This PR aims to fix that.

Release Summary

<!-- An optional description that you want to appear on the generated changelog -->

feat(firestore): stricter DocumentData type

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x] Yes
  • My change supports the following platforms;
    • [x] Android
    • [x] iOS
  • My change includes tests;
    • [ ] e2e tests added or updated in packages/\*\*/e2e
    • [ ] jest tests added or updated in packages/\*\*/__tests__
  • [x] I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • [x] Yes (but only typescript types)
    • [ ] No

Test Plan

<!-- Demonstrate the code you've added is solid, e.g. test logs or screenshots. -->

Set an object value to undefined and ensure that typescript shows an error:

image

+1 -1

8 comments

1 changed file

Yonom

pr closed time in 11 days

pull request commentinvertase/react-native-firebase

feat(firestore): stricter DocumentData type

Closing for inactivity

Yonom

comment created time in 11 days

PR closed smarkets/react-native-paypal

Fix Expo SDK 44 build error

Building a project using react-native-paypal and Expo SDK 44 (latest version) fails. This is because expo patches the react podspec for swift compatibility reasons (https://github.com/expo/expo/pull/15299) and that causes old style imports to not work (throwing duplicate interface definition errors)

I fixed the issue by changing the import style.

More information: https://github.com/expo/expo/issues/15622#issuecomment-997141629

Duplicate definition errors:

❌  (/Users/yonom/Documents/GitHub/app/ios/Pods/Headers/Public/React-Core/React/RCTBridgeModule.h:424:1)

  422 |  * A class that allows NativeModules and TurboModules to look up one another.
  423 |  */
> 424 | @interface RCTModuleRegistry : NSObject
      | ^ duplicate interface definition for class 'RCTModuleRegistry'
  425 | - (void)setBridge:(RCTBridge *)bridge;
  426 | - (void)setTurboModuleRegistry:(id<RCTTurboModuleRegistry>)turboModuleRegistry;
  427 | 
+0 -4

1 comment

1 changed file

Yonom

pr closed time in 11 days

pull request commentsmarkets/react-native-paypal

Fix Expo SDK 44 build error

Closing for inactivity.

Yonom

comment created time in 11 days

PR closed smarkets/react-native-paypal

bumped version to 4.2.0

I would really appreciate a new npm release with the recent commits

+5 -5

1 comment

2 changed files

Yonom

pr closed time in 11 days

pull request commentsmarkets/react-native-paypal

bumped version to 4.2.0

Closing for inactivity.

Yonom

comment created time in 11 days

issue commentexpo/expo

[RN 0.66][SDK 44][Android] `expo` package no longer compatible with RN 0.66 (`expo-file-system` issue)

The error also affects RN 0.65 (expo 44 officially only supports RN 0.64 I believe)

Yonom

comment created time in 11 days

issue commentgorhom/react-native-bottom-sheet

[v4] | BottomSheetScrollView doesn't drag the sheet up or down

Ah, iOS. I can reproduce the issue now! Interestingly enough, it doesn't happen on my ejected expo 44 project... I'll take a closer look at it later today 😊

In them meantime, @paranoia5 can you update the issue to say that the error happens on iOS (only)?

paranoia5

comment created time in 13 days

issue commentgorhom/react-native-bottom-sheet

[v4] | BottomSheetScrollView doesn't drag the sheet up or down

It works for me. I copied the example in the docs, had to fix a react issue, added GestureHandlerRootView, and ran it on my phone running Android 11 on Expo Go 2.23.2.

Look, we can go back and forth on how it works for me and it doesn't work for you, but we won't get anywhere. Can you make a small repository with the example in the docs and GestureHandlerRootView set up? Then I can look at it, reproduce the issue, and figure out why it doesn't work.

paranoia5

comment created time in 13 days

issue commentgorhom/react-native-bottom-sheet

[v4] | BottomSheetScrollView doesn't drag the sheet up or down

The example in the docs does not use a GestureHandlerRootView. You need a GestureHandlerRootView to make scrolling work.

paranoia5

comment created time in 13 days

issue commentexpo/expo

[SDK 44] Attempt to invoke interface method 'expo.modules.interfaces.facedetector.FaceDetectorInterface' on a null object reference

It seems like expo-camera v12.1 requires expo-barcode-scanner and expo-face-detector to work.

Running the following commands fixes the problem for me (but adds two unused dependencies)

expo install expo-barcode-scanner
expo install expo-face-detector
ajacquierbret

comment created time in 15 days

issue commentgorhom/react-native-bottom-sheet

[v4] | BottomSheetScrollView doesn't drag the sheet up or down

@Lurtt do you have a GestureHandlerRootView around your app's entry point?

If no: Follow these instructions to add a GestureHandlerRootView: https://docs.swmansion.com/react-native-gesture-handler/docs/#js

If yes: I cannot reproduce the issue you're having, so I'm gonna ask you to create a minimal reproducible repo so we can look into it

paranoia5

comment created time in 15 days

delete branch Yonom/mixpanel-react-native

delete branch : fix-expo-44

delete time in 15 days

issue commentgorhom/react-native-bottom-sheet

[v4] | BottomSheetScrollView doesn't drag the sheet up or down

I was also having this exact problem, my BottomSheetModals and BottomSheetScrollViews were not responding to touch events on Android.

Root Cause

react-native-gesture-handler requires a wrapper around the root view to function. In v1 of the library, this was done on the native side, and expo did this for you. In v2 of the library, you must use the GestureHandlerRootView in your app manually. Upgrading to SDK 44 of expo removes the native RNGH setup.

Fix

The GestureHandlerRootView must be applied as high as possible in your app's component tree.

In my case, I had my BottomSheetModalProvider outside the GestureHandlerRootView, and swapping these two components fixed the issue for me!

Before:

<BottomSheetModalProvider>
  <GestureHandlerRootView style={{ flex: 1 }}>
    <MainNavigation />
  </GestureHandlerRootView>
</BottomSheetModalProvider>

After:

<GestureHandlerRootView style={{ flex: 1 }}>
  <BottomSheetModalProvider>
    <MainNavigation />
  </BottomSheetModalProvider>
</GestureHandlerRootView>

@gorhom does it make sense to update the docs to say that BottomSheetModalProvider must be inside GestureHandlerRootView?

paranoia5

comment created time in 17 days

delete branch Yonom/react-native-purchases

delete branch : patch-expo-44

delete time in 23 days

pull request commentRevenueCat/react-native-purchases

Fix Expo SDK 44 compatibility

Awesome, thanks!

Yonom

comment created time in 23 days

issue commentexpo/expo

[SDK44][expo-updates][Android] M1 Mac build fails: Execution failed for task ':expo-updates:kaptDebugKotlin'

Woah, that's a clever fix, avoiding a compile version bump

I can also confirm that my builds work on my M1 Mac, thanks @Kudo!

Yonom

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentShopify/restyle

fix: Variant build stylesheet for RNW

@dobrea-v ahh, thank you for your thoughts!

In RN, Stylesheet.create is actually a no-op: https://github.com/facebook/react-native/blob/main/Libraries/StyleSheet/StyleSheet.js#L371

So my theory is that RNW compiles Stylesheet.create to a CSS class, it does not support nesting and that causes a deviance in behavior on RNW

dobrea-v

comment created time in a month

issue closedexpo/expo

[expo-av] app occasionally crashes with EXC_BAD_ACCESS

Summary

In about 1-2 % of our sessions involving expo-av's VideoPlayer, the iOS app crashes with a EXC_BAD_ACCESS error. We mount and unmount video players inside a flatlist.

Stack Trace

This is one of the 6 different stack traces we are getting (see my second post below for all of them)

Crashed: expo.modules.ExponentAVQueue
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000000

0  libsystem_platform.dylib       0x2554 os_unfair_lock_lock + 12
1  CoreFoundation                 0x5146c _cow_copy + 56
2  CoreFoundation                 0x55d64 -[__NSDictionaryM mutableCopyWithZone:] + 156
3  CoreFoundation                 0x5166c +[NSDictionary dictionaryWithDictionary:] + 44
4  app                            0xbfa168 -[EXVideoView _tryUpdateDataStatus:rejecter:] + 1229044
5  app                            0xbfb71c -[EXVideoView setStatus:resolver:rejecter:] + 1234600
6  app                            0xbfc8b0 __25-[EXVideoView setStatus:]_block_invoke + 1239100
7  libdispatch.dylib              0x1c04 _dispatch_call_block_and_release + 32
[...]

Code

The crash happens here: https://github.com/expo/expo/blob/master/packages/expo-av/ios/EXAV/Video/EXVideoView.m#L95

- (void)_tryUpdateDataStatus:(EXPromiseResolveBlock)resolve
                    rejecter:(EXPromiseRejectBlock)reject
{
  if (_data) {
    if ([_statusToSet count] > 0) {
      NSMutableDictionary *newStatus = [NSMutableDictionary dictionaryWithDictionary:_statusToSet]; // <- crash
      [_statusToSet removeAllObjects];
      [_data setStatus:newStatus resolver:resolve rejecter:reject];
    } else if (resolve) {
      resolve([_data getStatus]);
    }
  } else if (resolve) {
    resolve([EXAVPlayerData getUnloadedStatus]);
  }
}

My objective C knowledge is very limited, I thought of these two possibilities but I would need help answering them:

  • is the EXVideoView / _statusToSet dictionary being deallocated between the dispatch_async call and its callback?
  • NSMutableDictionary (_statusToSet) isn't thread-safe, is it being accessed on multiple threads?

Managed or bare workflow? If you have ios/ or android/ directories in your project, the answer is bare!

bare

What platform(s) does this occur on?

iOS

SDK Version (managed workflow only)

No response

Environment

 Expo CLI 4.13.0 environment info:
    System:
      OS: macOS 12.0.1
      Shell: 5.8 - /bin/zsh
    Binaries:
      Node: 17.0.1 - /opt/homebrew/bin/node
      Yarn: 1.22.17 - /opt/homebrew/bin/yarn
      npm: 8.1.4 - /opt/homebrew/bin/npm
      Watchman: 2021.11.15.00 - /opt/homebrew/bin/watchman
    Managers:
      CocoaPods: 1.11.2 - /opt/homebrew/bin/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 21.0.1, iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0
      Android SDK:
        API Levels: 29, 30, 31
        Build Tools: 29.0.2, 31.0.0, 32.0.0
        System Images: android-31 | Google Play ARM 64 v8a
        Android NDK: 22.1.7171670
    IDEs:
      Android Studio: 2020.3 AI-203.7717.56.2031.7784292
      Xcode: 13.1/13A1030d - /usr/bin/xcodebuild
    npmPackages:
      expo: ^43.0.1 => 43.0.1 
      react: ^17.0.2 => 17.0.2 
      react-dom: ^17.0.2 => 17.0.2 
      react-native: ^0.66.2 => 0.66.2 
      react-native-web: ^0.17.5 => 0.17.5 
    npmGlobalPackages:
      expo-cli: 4.13.0
    Expo Workflow: bare

Reproducible demo

Unfortunately, I am not able to reliably reproduce this error.

closed time in a month

Yonom

issue commentexpo/expo

[expo-av] app occasionally crashes with EXC_BAD_ACCESS

We had a useEffect hook that called .play() / .pause() on navigation focus / unfocus; adding a minimal delay to this hook fixed the problems for us!

Yonom

comment created time in a month

issue commentexpo/expo

[SDK44][expo-updates][Android] build fails: Execution failed for task ':expo-updates:kaptDebugKotlin'

I found the root cause!

The issue is on M1 macs only and is fixed by upgrading the used room version to 2.4.0. This however requires you to bump your compileSdkVersion to 31 in your build.gradle as well.

From the changelog:

Fixed an issue with Room’s SQLite native library to support Apple’s M1 chips.

expo-updates+0.11.2.patch

diff --git a/node_modules/expo-updates/android/build.gradle b/node_modules/expo-updates/android/build.gradle
index 924d240..14baa1c 100644
--- a/node_modules/expo-updates/android/build.gradle
+++ b/node_modules/expo-updates/android/build.gradle
@@ -95,7 +95,7 @@ dependencies {
   //noinspection GradleDynamicVersion
   implementation "com.facebook.react:react-native:+"
 
-  def room_version = "2.3.0"
+  def room_version = "2.4.0"
 
   implementation "androidx.room:room-runtime:$room_version"
   kapt "androidx.room:room-compiler:$room_version"
Yonom

comment created time in a month

more