profile
viewpoint
Igor Matuszewski Xanewok @paritytech Warsaw, Poland xanewok.github.io

rust-lang/rls 2815

Repository for the Rust Language Server (aka RLS)

rust-lang/rls-vscode 958

RLS-based plugin for VSCode

gluon-lang/lsp-types 48

Types for communicating with a language server

rust-dev-tools/rls-analysis 36

Core functionality for handling rustc's save-analysis data

rust-dev-tools/rls-vfs 13

Virtual File System for the RLS

rust-dev-tools/rls-data 10

Data structures used by the RLS and Rust compiler

rust-dev-tools/rls-span 8

Types for identifying code spans/ranges.

rust-dev-tools/rls-rustc 2

A simple shim around rustc to allow using save-analysis with a stable toolchain

Xanewok/IO2017 2

A simple 2.5D twin stick shooter game made with Unity

rust-dev-tools/rls-blacklist 1

Blacklist of crates for the RLS to skip

create barnchparitytech/substrate

branch : igor-ocw-async

created branch time in 2 days

Pull request review commentrust-lang/rust

Remove use of `unwrap()` from save-analysis

 impl<'l, 'tcx> SaveContext<'l, 'tcx> {                 match self.tables.expr_ty_adjusted(&hir_node).kind {                     ty::Adt(def, _) if !def.is_enum() => {                         let variant = &def.non_enum_variant();-                        let index = self.tcx.find_field_index(ident, variant).unwrap();-                        filter!(self.span_utils, ident.span);-                        let span = self.span_from_span(ident.span);-                        return Some(Data::RefData(Ref {-                            kind: RefKind::Variable,-                            span,-                            ref_id: id_from_def_id(variant.fields[index].did),-                        }));+                        if let Some(index) = self.tcx.find_field_index(ident, variant) {

Could we use map here? Since we indent by a level anyway and to avoid trailing None

JohnTitor

comment created time in 3 days

Pull request review commentrust-lang/rust

Remove use of `unwrap()` from save-analysis

+// compile-flags: -Zsave-analysis

I think we should have a dedicated regression test in src/test/ui/save-analysis and not rely on this flag in general src/test/ui directory

cc @Centril on test layout

JohnTitor

comment created time in 3 days

Pull request review commentrust-lang/rust

Remove use of `unwrap()` from save-analysis

+// compile-flags: -Zsave-analysis

Ditto

JohnTitor

comment created time in 3 days

pull request commentrust-lang/rust

Remove use of `unwrap()` from save-analysis

r? @Xanewok

JohnTitor

comment created time in 3 days

pull request commentrust-lang/rust

submodules: update rls from 10bf331 to 5fde462

Looks good, thanks!

@bors r+ p=1

matthiaskrgr

comment created time in 3 days

pull request commentemgre/win-crypto-ng

Implement hash object duplication

Rebased and CI is green. Do you think we could land this as well?

Xanewok

comment created time in 4 days

pull request commentemgre/win-crypto-ng

Implement standard Error trait for crate Error type

Updated and rebased; CI is green, do you think we could merge this now?

Xanewok

comment created time in 4 days

Pull request review commentemgre/win-crypto-ng

Implement standard Error trait for crate Error type

 pub enum Error {     Unknown(NTSTATUS), } +impl fmt::Display for Error {+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {+        fmt::Debug::fmt(self, f)

Changed the implementation to use write!.

Xanewok

comment created time in 4 days

push eventXanewok/win-crypto-ng

Igor Matuszewski

commit sha 82fb9b76a15dc8d68808c983d6cc993c18dc6e4f

Implement type-safe API for random number generation Co-authored-by: Émile Grégoire <eg@emilegregoire.ca>

view details

Igor Matuszewski

commit sha 44a49ff66384e938422357677240bceb9b2a6575

Make RandomNumberGenerator::system_preferred infallible

view details

Igor Matuszewski

commit sha 6b462687865781988eede44572d1db2be460bd4e

Hide some already private helper handle methods

view details

Émile Grégoire

commit sha e03796415058b0cc9ed156d8361dd5a7adc028e0

Provide rng module documentation and example.

view details

Émile Grégoire

commit sha 93bba6cc7983c73da9bc6161c342f04f0b022d5b

Merge pull request #1 from Xanewok/random Implement type-safe API for random number generation

view details

Igor Matuszewski

commit sha 801d49801fcb5ecc8f63b86d9b4e14d14c4dcbe0

Trigger CI on pull_request events as well See https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#example-using-a-list-of-events

view details

Émile Grégoire

commit sha ed331ef2854fa2da2bbed50fb95ef83ade6c6b99

Merge pull request #7 from Xanewok/ci-pr-trigger Trigger CI on pull_request events as well

view details

Igor Matuszewski

commit sha 103d1b7098ef9514d141a6f5f42a6867937d84b5

Fix a typo in README.md

view details

Émile Grégoire

commit sha d68327ea9e453e8f5f82cede7ea5d749cb3c732d

Merge pull request #9 from Xanewok/patch-1 Fix a typo in README.md

view details

Igor Matuszewski

commit sha d2457e43354763cd78dd0a54cc567d434d58a12e

Implement hash object duplication

view details

push time in 4 days

push eventXanewok/win-crypto-ng

Igor Matuszewski

commit sha 82fb9b76a15dc8d68808c983d6cc993c18dc6e4f

Implement type-safe API for random number generation Co-authored-by: Émile Grégoire <eg@emilegregoire.ca>

view details

Igor Matuszewski

commit sha 44a49ff66384e938422357677240bceb9b2a6575

Make RandomNumberGenerator::system_preferred infallible

view details

Igor Matuszewski

commit sha 6b462687865781988eede44572d1db2be460bd4e

Hide some already private helper handle methods

view details

Émile Grégoire

commit sha e03796415058b0cc9ed156d8361dd5a7adc028e0

Provide rng module documentation and example.

view details

Émile Grégoire

commit sha 93bba6cc7983c73da9bc6161c342f04f0b022d5b

Merge pull request #1 from Xanewok/random Implement type-safe API for random number generation

view details

Igor Matuszewski

commit sha 801d49801fcb5ecc8f63b86d9b4e14d14c4dcbe0

Trigger CI on pull_request events as well See https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#example-using-a-list-of-events

view details

Émile Grégoire

commit sha ed331ef2854fa2da2bbed50fb95ef83ade6c6b99

Merge pull request #7 from Xanewok/ci-pr-trigger Trigger CI on pull_request events as well

view details

Igor Matuszewski

commit sha 103d1b7098ef9514d141a6f5f42a6867937d84b5

Fix a typo in README.md

view details

Émile Grégoire

commit sha d68327ea9e453e8f5f82cede7ea5d749cb3c732d

Merge pull request #9 from Xanewok/patch-1 Fix a typo in README.md

view details

Igor Matuszewski

commit sha 0e40a0e923ccbb164d29f40da29a14b37f1e2aea

Implement Error trait for crate Error type

view details

Igor Matuszewski

commit sha ab0ea413e3d7a20c9198fabec7b52bf063a7b576

Use crate Result type in Error::check

view details

push time in 4 days

pull request commentrust-lang/rls

Update cargo.

Looks good, thank you for sending those

@bors r+

ehuss

comment created time in 6 days

pull request commentrust-lang/rust

submodules: update rls from 0100ac8 to 10bf331

@bors r+ p=1

Thanks!

matthiaskrgr

comment created time in 6 days

pull request commentrust-lang/rls

Update cargo

I'm not sure what happened with #1631 (...)

rustfmt 1.4.12 wasn't released to crates.io at the time but it was updated to latest master in the rust-lang/rust repository; that's why it worked there but not here (until a new rustfmt version was released).

ehuss

comment created time in 7 days

push eventrust-lang/rls

Eric Huss

commit sha 38ac9ea2b449f47d7e84f9a9cbf934e6258c285f

Update cargo

view details

Igor Matuszewski

commit sha 10bf331d4d1280d773045e57d65031969c51dec6

Merge pull request #1636 from ehuss/update-cargo Update cargo

view details

push time in 7 days

PR merged rust-lang/rls

Update cargo

Cargo has switched to BTreeMap for env vars for reproducibility.

Note: I had to update rustfmt-nightly to get the lock file to update properly. I'm not sure what happened with #1631, but there were a lot of conflicts with the rustc-ap-* crates pulling in two different versions. It looks like rust-lang/rust is already updated to the correct version.

Closes #1637

+231 -111

1 comment

5 changed files

ehuss

pr closed time in 7 days

PR closed rust-lang/rls

Unbreak build
+230 -107

0 comment

4 changed files

Xanewok

pr closed time in 7 days

pull request commentrust-lang/rls

Update cargo

Ah crap, didn't see the PR - that's what I get for having so many GH notification e-mails :sweat_smile: Thank you!

ehuss

comment created time in 7 days

pull request commentrust-lang/rls

Update cargo

Ah crap, didn't see the PR - that's what I get for having so many GH notification e-mails :sweat_smile: Thank you!

ehuss

comment created time in 7 days

PR opened rust-lang/rls

Unbreak build
+230 -107

0 comment

4 changed files

pr created time in 7 days

create barnchXanewok/rls

branch : unbreak-build

created branch time in 7 days

created tagBlazity/postgrest-filter-parser

tag0.0.6

Parser for PostgREST 5.x filter expressions

created time in 9 days

delete branch Blazity/postgrest-filter-parser

delete branch : list-parentheses

delete time in 9 days

push eventBlazity/postgrest-filter-parser

msxrx

commit sha 89e2bd328d35362dd63c15bae909b9e5db808f9b

fix printer to wrap lists in parentheses

view details

msxrx

commit sha 3f4c477f00985349365e6b20ed0240c2b4bea7a4

update printer tests, add proper condition for in operator

view details

Igor Matuszewski

commit sha 9dd679febe32b096a117ac5d4fd5efab87c1d3a3

Merge pull request #3 from Blazity/list-parentheses List parentheses

view details

push time in 9 days

PR merged Blazity/postgrest-filter-parser

List parentheses

PostgREST's in operator supports lists only so we have to normalize to parentheses instead of curly braces.

+13 -4

0 comment

2 changed files

msxrx

pr closed time in 9 days

push eventXanewok/substrate

Toralf Wittner

commit sha 9b33c4715bedc143e22fb0a5819d0d1810302472

Remove direct yamux dependency. (#4968) libp2p-0.16 allows configuring yamux through libp2p-yamux, so the direct dependency is no longer needed. While at it we also update to the latest versions of yamux and nohash-hasher, though the code changes do not depend on it.

view details

André Silva

commit sha e312eba8b96d99146f0890cab67005aac6e51123

sync: process empty response for justification requests (#4957) * sync: process empty response for justification request * sync: add test for justification request empty response * network: remove deprecated comment

view details

Nikolay Volf

commit sha 6f05ef203ade29ac8b909cb4584c22f75ea9b54a

Fix flaky finalisation test (#4967)

view details

Igor Matuszewski

commit sha 108e99155b352bda89935b4adde96db002115e93

Use a single version of once_cell

view details

push time in 9 days

create barnchXanewok/substrate

branch : unsafe-rpc-external

created branch time in 9 days

Pull request review commentBlazity/postgrest-filter-parser

List parentheses

 test("Conditions", () => {       operator: Operator.eq,       value: 20     },-    "cs.{example,new}": {+    "cs.(example,new)": {       negated: false,       operator: Operator.cs,-      value: ["example", "new"]+      value: {+        left: { kind: "excluding", value: "example" },+        right: { kind: "excluding", value: "new" }+      }     },+    //FIXME: PostgREST's 'in' operator supports parentheses-wrapped lists only, so this behaviour is incorrect

nitpick:

    // FIXME: PostgREST's 'in' operator supports parentheses-wrapped lists only, so this behaviour is incorrect
msxrx

comment created time in 9 days

Pull request review commentBlazity/postgrest-filter-parser

List parentheses

 test("Conditions", () => {       operator: Operator.eq,       value: 20     },-    "cs.{example,new}": {+    "cs.(example,new)": {

@msxrx is this accepted by PostgREST as well?

msxrx

comment created time in 9 days

issue commentrust-lang/rust

Re-land "add IntoFuture trait and support for await"

The linked PR has been merged and it looks like the async/await benchmark received quite a nice boost.

Is it blocked on https://github.com/rust-lang/rust/issues/68864 to make progress?

tmandry

comment created time in 9 days

pull request commentparitytech/substrate

Use a single version of once_cell

 failures:
    testing::pool::fork_aware_finalization

CI failure seems to be #4944

Xanewok

comment created time in 9 days

PR opened paritytech/substrate

Reviewers
Use a single version of once_cell A2-insubstantial B0-silent M5-dependencies

Related #808

+23 -77

0 comment

4 changed files

pr created time in 9 days

create barnchXanewok/substrate

branch : once_cell

created branch time in 9 days

delete branch Xanewok/substrate

delete branch : offchain-http-hyper-upgrade

delete time in 10 days

push eventXanewok/substrate

Igor Matuszewski

commit sha 10f06432e8b4259250ef03275ae40a5a682d2b72

grafana-data-source: Pull hyper/tokio only in native environment

view details

push time in 10 days

pull request commentrust-lang/rls-vscode

Update README.md in order to point correctly to Preferences

This doesn't seem to be correct; under Linux I still access it via File > Preferences > Settings. What system/VSCode version are you using?

andresgallego

comment created time in 10 days

push eventXanewok/substrate

Igor Matuszewski

commit sha d826bffa85b7da4a0307acec5d41aa34812ac0e4

grafana-data-source: Pull hyper/tokio only in native environment

view details

push time in 10 days

push eventXanewok/substrate

Alexander Popiak

commit sha f123c297de9f9159d034f1af1f132b16f302ab74

Rename StorageMap::exists to ::contains_key (Resolves #4839) (#4847) * rename StorageMap::exists(key) to ::contains_key(key) * bump impl_version

view details

Nikolay Volf

commit sha 0a894803c73175e08944e6032098deded1e65755

Alter usage collection a bit (#4863) * alter usage collection a bit * replace with mutex

view details

h4x3rotab

commit sha 3b21fb5020679236a8fe6d6b7a3a009a810d13a2

Wrap runtime_print! macro in its own scope (#4867) * Wrap runtime_print! macro in its own scope Before this fix runtime_print! can be used only once in a scope because of the name pollution. * Bump runtime impl versioin (no logic change)

view details

h4x3rotab

commit sha 8d822dad74598d924612c9cf915933ddc6345089

Remove the unnecessary std dependency from 'blake2-rfc' (#4868)

view details

h4x3rotab

commit sha 19b67cd93b56396e8921b5227add3f7de18c60f4

Export GRANDPA AuthorityPair when full_crypto is enabled (#4872) * Export crypto_full feature in primitives/finality-grandpa * Export GRANDPA AuthorityPair when full_crypto is enabled

view details

Shawn Tabrizi

commit sha 8b6b093dd9a84547fa1fbbfd88fbf45b545a9855

Create Benchmarking Setup for Identity Pallet #4695 (#4818) * Starting * closer * Compiles! * comments * Create seperate mock * Remove changes to test env * Fix step calculation * Add host function * Add runtime api * compiles * Update to use offchain timestamp * Gives a result * added some CLI wip * make generic * Update instance * Remove CLI stuff * Remove last cli stuff * undo more changes * Update benchmarks * Update Cargo.lock * remove test * Move loop out of runtime * Benchmarking externalities * Benchmarking state * Implemented commit * Make CLI work, move loop back into runtime * Wipe resets to genesis * Speedup benchmarks * Use enum to select extrinsic within pallet * CLI controls which module and extrinsic to call * Select a pallet with cli * Add steps and repeats to cli * Output as CSV format * Introduce benchmark pallet * Append bench * Use Results * fix merge * Clear Identity benchmark * Bench request judgment and cancel request * Add final benchmarks * Fix CSV output * Start cleaning up for PR * Bump numbers in `wasmtime` integration tests. * More docs * Add rockdb feature to bench * Fix formatting issues * Add test feature to bench * Add test feature to bench * Add rocksdb feature flag * Update bench.rs Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com> Co-authored-by: Gavin Wood <github@gavwood.com>

view details

Gavin Wood

commit sha f735d3e2491d347825ec9560e8916decd72a4f11

Fix vesting logic (#4864) * Fix vesting logic * Bump runtime version * Docs.

view details

Cecile Tonglet

commit sha 7e8ac2eb0df9a4a6154dc1ba6029caabcf5e7191

Update trie-db to the latest (#4874)

view details

Ashley

commit sha ae03ee918e6338a3afc5dbd3742f5b8d7fa35271

Fix timer panics in the wasm light client (#4561) * Make WASM browser thing compile * Fix * updated exit-future (github repo) * Switch to broadcast crate * Migrate client/cli * Switch exit-future to modernize branch * Small changes * Switch to cargo version and fix fg tests * fix basic-authorship * Fix crash on grafana macro * Fix grafana macro * Switch node python version * Disable record_metrics_slice in grafana macro on wasm * Update client/grafana-data-source/src/lib.rs * Revert "Update client/grafana-data-source/src/lib.rs" This reverts commit 888009a8e0b7051bd4bfbbfdb0448bcf2e2aae93. * Add wasm support for state machine * Switch to my own libp2p version * Revert "Switch to my own libp2p version" This reverts commit ce613871b59264b3165b45c37943e6560240daa7. * Revert "Add wasm support for state machine" This reverts commit de7eaa0694d9534fc3b164621737968e9a6a7c5f. * Add sc-browser * Squash * remove sc-browser * Fix keystore on wasm * stubs for removed functions to make env compatible with old runtimes * Add test (that doesn't work) * Fix build scripts * Revert basic-authorship due to no panics * Revert cli/informant * Revert consensus * revert offchain * Update utils/browser/Cargo.toml Co-Authored-By: Benjamin Kampmann <ben@gnunicorn.org> * export console functions * Add new chainspec * Fix ws in chain spec * revert chainspec * Fix chainspec * Use an Option<PathBuf> in keystore instead of cfg flags * Remove crud * Only use wasm-timer for instant and systemtime * Remove telemetry changes * Assuming this is ok * Add a KeystoreConfig * Add stubs back in * Update libp2p * Revert "Add stubs back in" This reverts commit 4690cf1882aa0f99f7f00a58c4080c8aa9b77c36. * Remove commented js again * Bump kvdb-web version * Fix cli * Switch branch on futures-timer * Fix tests * Remove sc-client test build in check-web-wasm because there isn't a good way to build futures-timer with wasm-bindgen support in the build * Remove more things ^^ * Switch branch on futures-timer back * Put DB io stats behind a cfg flag * Fix things * Don't timeout transports on wasm * Update branch of futures-timer and fix bad merge * Spawn informant * Fix network test * Fix delay resets * Changes * Fix tests * use wasm_timer for transaction pool * Fixes * Switch futures-timer to crates * Only diagnose futures on native * Fix sc-network-test tests * Select log level in js * Fix syncing ;^) * Allow disabling colours in the informant * Use OutputFormat enum for informant * MallocSizeOf impl on transaction pool broke stuff because wasm_timer::Instant doesnt impl it so just revert the transaction pool to master * Update futures-diagnose * Revert "MallocSizeOf impl on transaction pool broke stuff because wasm_timer::Instant doesnt impl it so just revert the transaction pool to master" This reverts commit baa4ffc94fd968b6660a2c17ba8113e06af15548. * Pass whole chain spec in start_client * Get Instant::now to work in transaction pool again * Informant dep reordering Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> Co-authored-by: Benjamin Kampmann <ben.kampmann@googlemail.com> Co-authored-by: Demi Obenour <48690212+DemiMarie-parity@users.noreply.github.com>

view details

Bastian Köcher

commit sha 0d4586b13f176ca35c65f288b59e4ecccd099313

Don't expose `Benchmarking` host functions by default (#4875) * Don't expose `Benchmarking` host functions by default * Fix tests Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>

view details

Marcio Diaz

commit sha 571e3c4d9cdcf55a7c09b7040061f6e096dd3b08

Add trace on import block. (#4871)

view details

Sergei Pepyakin

commit sha 1fa3f7f607351e008ec6d817ca218d9aade576f7

Refactor and document allocator (#4855) * Clarify code a bit. * Move code around. * Introduce `Order`. * Introduce `Link` structure. * Get rid of ptr_offset This is beneficial since ptr_offset is essentially makes us handle two different address spaces, global (i.e. `mem`) and heap local and without it things are becoming simpler. * Rename PREFIX_SIZE to HEADER_SIZE. This will come in the next commits. * Introduce a separate `Memory` trait. This is not necessary, but will come in handy for the upcoming changes. * Rename `ptr` to `header_ptr` where makes sense. * Introduce a `Header` type. * Make `bump` dumber. This allows us to pull `HEADER_SIZE` to see that we actually allocate `order.size() + HEADER_SIZE`. * Clean up. * Introduce a freelists struct. * Update documentation. * Make Sized requirement optional to make the PR truly back-compatible. * Apply suggestions from code review Co-Authored-By: Gavin Wood <gavin@parity.io> * Apply suggestions from code review Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Gavin Wood <github@gavwood.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

view details

Gavin Wood

commit sha d472cd6ef27c93a3f58b0c1efd0927fc49394387

Avoid challenging those that can't be suspended anyway (#4804) * Merge branch 'gav-split-balanecs-vesting' into gav-upsub # Conflicts: # Cargo.lock # cli/Cargo.toml # collator/Cargo.toml # primitives/Cargo.toml # runtime/common/Cargo.toml # runtime/common/src/claims.rs # runtime/kusama/Cargo.toml # runtime/polkadot/Cargo.toml # service/Cargo.toml * Fix tests

view details

Marcio Diaz

commit sha b388338814c5040f6a6b84018430f799445b4876

Add trait to get module and call names. (#4854) * Add trait to get module and call names. Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

view details

Bastian Köcher

commit sha 26a4b73931e636157a38a26a92f9103fe1b644c5

Fix runtime-interface tests on windows (#4805)

view details

Nikolay Volf

commit sha 613a3bc895f1031e7ede7c7232ae256efe11d8b2

update primitive types to 0.6.2 (#4866)

view details

Tomasz Drwięga

commit sha 671cb85238ce18b23392e3298a399ee8ee64e98d

Run offchain workers at hash, not number. (#4878) * Run offchain workers at particular hash, not number. * Don't run if not new best. * Don't run if not new best. * Update client/service/src/builder.rs Co-Authored-By: Nikolay Volf <nikvolf@gmail.com> * Update client/service/src/builder.rs Co-Authored-By: Nikolay Volf <nikvolf@gmail.com> * Update client/service/src/builder.rs Co-authored-by: Nikolay Volf <nikvolf@gmail.com>

view details

cheme

commit sha 50bb62fff79bb5c437634302d23fd97528369261

Use prefixed iterator from trie. (#4858)

view details

Hayden Bakkum

commit sha a5a61df9c442339a8b67fc467ea990867431f355

Add support for json output in subkey (#4882) * Add support for json output in subkey * Updates as per code review * Apply suggestions from code review Co-Authored-By: Nikolay Volf <nikvolf@gmail.com> * Apply suggestions from code review Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com> * Clean up error handler as per code review * Apply suggestions from code review Co-Authored-By: Marcio Diaz <marcio@parity.io> * Fix compilation error * Remove accidental file commit Co-authored-by: Nikolay Volf <nikvolf@gmail.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Marcio Diaz <marcio@parity.io>

view details

Robert Habermeier

commit sha 1dd662b5439841468a1f827a53731cb5ee91165b

impl Randomness trait for Babe and remove unused RandomBeacon trait (#4886) * impl Randomness trait for Babe and remove unused RandomBeacon trait * bump runtime version

view details

push time in 13 days

delete branch Xanewok/rust

delete branch : update-rls-rustfmt

delete time in 15 days

pull request commentrust-lang/rls

Update dependencies

Opened https://github.com/rust-lang/rust/pull/69097 to fix the toolstate breakage

Xanewok

comment created time in 15 days

create barnchXanewok/rust

branch : update-rls-rustfmt

created branch time in 15 days

PR opened rust-lang/rust

Update RLS and Rustfmt

Bumps rustc-ap-* packages to v642.

Closes #68916. Closes #68917.

+223 -113

0 comment

3 changed files

pr created time in 15 days

delete branch Xanewok/rls

delete branch : update-deps

delete time in 15 days

push eventrust-lang/rls

kngwyu

commit sha 4f47b20b22283c64edcb3c24d52271f8110b8b46

Update racer to 2.1.30

view details

Igor Matuszewski

commit sha b97f025942b03ef3fdc40cb217f9593972939b2b

Support new Union variants from Racer

view details

Igor Matuszewski

commit sha e3882c0251ce0331278414dfcbf351c8fba6a3a0

Use consistent completion item kinds for structs and unions

view details

Igor Matuszewski

commit sha 0c505b0e0686b02848ee8d844019eb958c8915f5

Bump jsonrpc-* crates to use syn et al. >= 1

view details

Igor Matuszewski

commit sha 5a805d027d17fd5db52c452909c43e5e26397a88

Update racer to 2.1.31

view details

Igor Matuszewski

commit sha 0100ac87b4ce5bbed6e56a62f313fbc3ff037a89

Merge pull request #1631 from Xanewok/update-deps Update dependencies

view details

push time in 15 days

PR merged rust-lang/rls

Update dependencies

...so that we require only a single version of syn.

Closes #1630 cc @kngwyu

+115 -120

2 comments

5 changed files

Xanewok

pr closed time in 15 days

pull request commentrust-lang/rls

Update dependencies

@topecongiro hey, could you please publish a 1.4.12 with the racer rustc-ap-* bump, please? Thanks! (It'd be nice to keep RLS master working without falling back to Rustfmt git revs)

Xanewok

comment created time in 15 days

push eventXanewok/rls

Igor Matuszewski

commit sha 5a805d027d17fd5db52c452909c43e5e26397a88

Update racer to 2.1.31

view details

push time in 15 days

PullRequestEvent

pull request commentrust-lang/rls

Fix rls-vfs line loading inclusivity

That's still a useful PR and I'm really sorry that I didn't get back to that in reasonable time. I'll gladly merge that after reviewing :)

bennetthardwick

comment created time in 15 days

push eventXanewok/substrate

Igor Matuszewski

commit sha 6eac6b87f82cbb8cd0cc03b188ab359677f19346

offchain: Upgrade hyper to 0.13, which uses tokio 0.2

view details

Igor Matuszewski

commit sha b36672ab8d9c60e107dd394f000c63a6d4fa766a

offchain: Adapt HTTP tests to Tokio 0.2

view details

Igor Matuszewski

commit sha 61323a3218b2a10dd7fa0b0ba0d0c064d8730d0e

WIP: Pull hyper in grafana-data-source only for native env

view details

push time in 17 days

Pull request review commentparitytech/substrate

offchain: Upgrade hyper to 0.13, which uses tokio 0.2

 sc-network = { version = "0.8", path = "../network" } sc-keystore = { version = "2.0.0", path = "../keystore" }  [target.'cfg(not(target_os = "unknown"))'.dependencies]-hyper = "0.12.35"-hyper-rustls = "0.17.1"+hyper = { version = "0.13.1", default-features = false, features = ["stream"] }

You're right, I originally copied it from grafana-data-source but forgot to change it, meanwhile hyper-rustls enabled the hyper/runtime via https://github.com/ctz/hyper-rustls/blob/f51987a477af6d104783dee3b354e3db244f61a4/Cargo.toml#L29.

I'll fix it to pull all default features here for clarity.

Xanewok

comment created time in 17 days

pull request commentparitytech/substrate

offchain: Upgrade hyper to 0.13, which uses tokio 0.2

If I were to guess, I'd say it's the new hyper-rustls here (by default) including runtime feature for hyper but it seems that the 0.13 version is also pulled in wasm in https://github.com/paritytech/substrate/blob/a9680b40469c8180e5b6b083c01dc04f69e4037c/utils/grafana-data-source/Cargo.toml#L11 hence we unfortunately conflate features and pull in the runtime to wasm accidentally.

Cargo features :angry:

Xanewok

comment created time in 19 days

Pull request review commentparitytech/substrate

offchain: Upgrade hyper to 0.13, which uses tokio 0.2

 impl fmt::Debug for HttpWorkerRequest {  #[cfg(test)] mod tests {+	use core::convert::Infallible; 	use crate::api::timestamp; 	use super::http;-	use futures::prelude::*;-	use futures01::Future as _; 	use sp_core::offchain::{HttpError, HttpRequestId, HttpRequestStatus, Duration};  	// Returns an `HttpApi` whose worker is ran in the background, and a `SocketAddr` to an HTTP 	// server that runs in the background as well. 	macro_rules! build_api_server { 		() => {{+			macro_rules! tokio_run {

Used a generic helper function.

Xanewok

comment created time in 19 days

push eventXanewok/substrate

Igor Matuszewski

commit sha 6aaca9f6a849d7ed3fc3f0276c58874870de84b7

offchain: Adapt HTTP tests to Tokio 0.2

view details

push time in 19 days

pull request commentparitytech/substrate

offchain: Upgrade hyper to 0.13, which uses tokio 0.2

Wasm build fails on cargo build --target=wasm32-unknown-unknown -p sc-consensus-aura due to pulling in optional net2 dependency of hyper but I'm opting out of default features... Hopefully it's not feature conflating Cargo bug; will investigate.

Xanewok

comment created time in 19 days

Pull request review commentparitytech/substrate

offchain: Upgrade hyper to 0.13, which uses tokio 0.2

 impl fmt::Debug for HttpWorkerRequest {  #[cfg(test)] mod tests {+	use core::convert::Infallible; 	use crate::api::timestamp; 	use super::http;-	use futures::prelude::*;-	use futures01::Future as _; 	use sp_core::offchain::{HttpError, HttpRequestId, HttpRequestStatus, Duration};  	// Returns an `HttpApi` whose worker is ran in the background, and a `SocketAddr` to an HTTP 	// server that runs in the background as well. 	macro_rules! build_api_server { 		() => {{+			macro_rules! tokio_run {

We can't use closures since the two futures differ in concrete types (this would require a generic closure, it's what I tried originally) - I can inline it or use a helper function :+1:

Xanewok

comment created time in 19 days

push eventXanewok/substrate

Igor Matuszewski

commit sha 4c2815ec5f4614e4a1c7e7dffffd8a510758bdd2

offchain: Adapt HTTP tests to Tokio 0.2

view details

push time in 19 days

push eventXanewok/substrate

Igor Matuszewski

commit sha 22781dc102474b34f8cd35355e453775d97646d7

offchain: Adapt HTTP tests to Tokio 0.2

view details

push time in 19 days

pull request commentparitytech/substrate

offchain: Upgrade hyper to 0.13, which uses tokio 0.2

Forgot to adapt the test code as well, let me fix it up real quick.

Xanewok

comment created time in 20 days

push eventXanewok/substrate

Igor Matuszewski

commit sha bc55edd178bba6077b31cc8a3c112353616982e7

offchain: Upgrade hyper to 0.13, which uses tokio 0.2

view details

push time in 20 days

PR opened paritytech/substrate

Reviewers
offchain: Upgrade hyper to 0.13, which uses tokio 0.2 A0-pleasereview B0-silent

Fixes the regressed offchain HTTP API by upgrading hyper to use tokio 0.2.

While an integration test for offchain HTTP API exists, it uses mocks in TestOffchainExt, so I decided against duplicating an another harness with actual HTTP.

I imagine a better approach would be to set up most of the runtime and test the HTTP from offchain workers directly but didn't want to block the fix here, let me know if I should work on setting that up as well.

Fixes #4647.

+48 -39

0 comment

3 changed files

pr created time in 20 days

create barnchXanewok/substrate

branch : offchain-http-hyper-upgrade

created branch time in 20 days

delete branch Xanewok/json

delete branch : serde-no-std-error

delete time in 20 days

pull request commentserde-rs/json

Require serde >= 1.0.100 due to no_std-related Error re-export

Oh, woops! I was sure you also published that, but now I can see that @cbeck88 is the publisher for alt crates. Sorry for the confusion!

Xanewok

comment created time in 20 days

create barnchXanewok/substrate

branch : offchain-worker-example

created branch time in 20 days

PR opened serde-rs/json

Require serde >= 1.0.100 due to no_std-related Error re-export

Relevant Serde PR: https://github.com/serde-rs/serde/pull/1620

To support both no-/std builds without using somewhat noisy conditional compilation directives, we implement the re-exported serde::de::StdError trait in https://github.com/serde-rs/json/pull/606.

However, this was only introduced in >= 1.0.100, so we need to bump the version requirement of serde.

On the off chance of someone pulling in incompatible 1.0.4{5,6} versions of serde_json, I believe it'd be good to yank those and cut a new release with this patch.

Sorry for the omission in the original PR.

Fixes #612.

@dtolnay By the way, is there a chance a new version of alt_serde_* could be published? It'd help work around the Cargo feature bug, where accidentally pulling in std through build/dev dep for no_std/alloc package breaks the build in no_std consumer crates.

+1 -1

0 comment

1 changed file

pr created time in 20 days

push eventXanewok/json

Igor Matuszewski

commit sha 8fdfedb5c1e44a42246444f5bdd23d515a62a54b

Require serde >= 1.0.100 due to no_std-related Error re-export Relevant Serde PR: https://github.com/serde-rs/serde/pull/1620 To support both no-/std builds without using somewhat noisy conditional compilation directives, we implement the re-exported `serde::de::StdError` trait in https://github.com/serde-rs/json/pull/606. However, this was only introduced in >= 1.0.100, so we need to bump the version requirement of serde. On the off chance of someone pulling in incompatible 1.0.4{5,6} versions of serde_json, I believe it'd be good to yank those and cut a new release with this patch. Sorry for the omission in the original PR. Fixes #612.

view details

push time in 20 days

push eventXanewok/json

Dean Karn

commit sha a240606c32464c2d923e0b2090cc26126ee59260

Add append to Map This adds append to the Map type. There are two underlying map type ATM: - BTreeMap - IndexMap For BTreeMap this exposes the existing append method which has some nice perf benefits vs doing a for on the other map and insert on each element. For IndexMap there is no existing append method and so as a fallback and convenience there is a for over the elements and insert simulating an append.

view details

Dean Karn

commit sha 5930359ec1024ae02015fc045125fd603927e72f

Make compatible with older veersions of rust reworked to use std::mem::replace instead of std::mem::take which was introduced in v1.40.0 which is just a wrapper for replace.

view details

Igor Matuszewski

commit sha bbfdaf04cfb87cbb200e20805279e38493ae6114

Update MSRV to 1.30 in README.md As it seems to be the case as of latest commit (https://github.com/serde-rs/json/commit/4b8380261b63e0758877ab9cfe7ed1652cca4f88)

view details

David Tolnay

commit sha 6434761d775be4b287381599e283478510b3c765

Merge pull request #605 from Xanewok/patch-1 Update MSRV to 1.30 in README.md

view details

David Tolnay

commit sha b6119e4c1e8c54a16ddce42c72df5df411e73a14

Merge pull request #600 from deankarn/master Add append to Map

view details

David Tolnay

commit sha 57bc9ae77b31969ee6888899ca39f3e86ff0890e

Resolve redundant_static_lifetimes lint This has been supported in rustc since 1.17. https://blog.rust-lang.org/2017/04/27/Rust-1.17.html

view details

David Tolnay

commit sha 88ee1a69dab73a45cd0eca5db505164fcd48cbf1

Ignore transmute_ptr_to_ptr lint `mem::transmute::<&str, &RawValue>(json)` is more readable and safer than Clippy's suggestion of `&*(json as *const str as *const RawValue)`.

view details

freax13

commit sha 4600a9af7ff58248271667d860879a6a18b6191b

add alloc/no_std support

view details

Tom Dohrmann

commit sha 65336702c3901206a188eb05adb994cb428db7c1

Fix std feature dependency for itoa

view details

Igor Matuszewski

commit sha 9ecf91504ae3fe33bbb16d71339c4993baf15999

Add facade around std/alloc/core like serde does

view details

Igor Matuszewski

commit sha 15bfaf6a07768ccac3a1fbcf661a66a9f6b26d19

Reorganize std::io facade

view details

Igor Matuszewski

commit sha b47d2d1aec9db161b2cfadf5c3b43215bbbc9646

Mention availability of alloc feature

view details

Igor Matuszewski

commit sha d7f7a51c720a8b2c9056e9a249dced1779097cae

travis: Test no_std/alloc on 1.36.0

view details

Igor Matuszewski

commit sha 176ff712f83038d334107574cc81d0ad4cb4386f

Inline the itoa::write calls Inlining this simple, already `core`-compatible function is better than noisily repeating the same definition that does exactly the same, albeit hidden behind a fn call.

view details

Igor Matuszewski

commit sha 7852d2f1e6e5a0f9849f96b4fe403788862a2746

Add user-friendly error when no alloc or std feature are enabled

view details

Igor Matuszewski

commit sha bac77ed0ff8b776f4bb50755e2c37c130e88dce2

Imply using alloc crate when `std` is not enabled

view details

Igor Matuszewski

commit sha 3b03040cf04eac8b28a2f5b65f84b018edddeea0

Make io a subset of `std::io` So that when implementing a no-`std` logic we don't break the build when some other dependency opts into `std` (causing API mismatch).

view details

Igor Matuszewski

commit sha 8e8058a491b746909824b8775d74e2aa4ff0609c

Move the core::io implementation to separate module

view details

David Tolnay

commit sha 91f791bd1c1fb17b33e0d39168f1e9cf6075fd40

Merge pull request #606 from Xanewok/no-std-patch Add a no_std/alloc feature

view details

David Tolnay

commit sha 83e35ec22a08ce2fe2609f9bb6c1811d4b52463a

Tweak feature check message

view details

push time in 20 days

create barnchXanewok/json

branch : serde-no-std-error

created branch time in 20 days

PR opened rust-lang/rls

Update dependencies

...so that we require only a single version of syn.

+115 -120

0 comment

5 changed files

pr created time in 20 days

create barnchXanewok/rls

branch : update-deps

created branch time in 20 days

PR opened racer-rust/racer

metadata: Don't use deprecated Error::description

we will forward to Display, which is implemented the same way, anyway.

See https://github.com/rust-lang/rust/pull/66919

+2 -11

0 comment

1 changed file

pr created time in 22 days

create barnchXanewok/racer

branch : deprecated-description

created branch time in 22 days

pull request commentracer-rust/racer

Upgrade dependencies

@kngwyu would it be possible to publish a point release with these changes?

It'd be great to get rid of syn < 1 in the RLS 😊

mati865

comment created time in 22 days

delete branch Xanewok/rls

delete branch : update-deps

delete time in 23 days

push eventrust-lang/rls

Igor Matuszewski

commit sha dcba729775568fadc0a905a27636ec79fdb52fb1

Upgrade to stable merge-friendly Cargo v2 lockfile format

view details

Igor Matuszewski

commit sha 791b764eef8a7ba18ffb0352ac90dbe01b8686cc

Update and unify some dependencies

view details

Igor Matuszewski

commit sha 29ee0df42f453cd8173baa42a742f6f94e82856e

Merge pull request #1629 from Xanewok/update-deps Update and unify some dependencies

view details

push time in 23 days

PR merged rust-lang/rls

Update and unify some dependencies
+1068 -1304

0 comment

2 changed files

Xanewok

pr closed time in 23 days

PR opened rust-lang/rls

Update and unify some dependencies
+1068 -1304

0 comment

2 changed files

pr created time in 23 days

push eventXanewok/rls

Igor Matuszewski

commit sha 791b764eef8a7ba18ffb0352ac90dbe01b8686cc

Update and unify some dependencies

view details

push time in 23 days

create barnchXanewok/rls

branch : update-deps

created branch time in 23 days

delete branch Xanewok/rls

delete branch : update-deps

delete time in 23 days

push eventrust-lang/rls

Igor Matuszewski

commit sha 630870eced885a258514d52eaca63a399071730b

Update crossbeam-channel to 0.4 To do so, we also upgrade the transient dependency ignore to 0.4.11

view details

Igor Matuszewski

commit sha 96993d2b17a0b7df3574ee247f42f65de5764fcf

Merge pull request #1627 from Xanewok/update-deps Update crossbeam-channel to 0.4

view details

push time in 23 days

PR merged rust-lang/rls

Update crossbeam-channel to 0.4

To do so, we also upgrade the transient dependency ignore to 0.4.11.

@mati865 I'm sorry for not addressing #1614 earlier. I understand to fix the underlying issue, we really need to bump the crossbeam-utils dep to 0.7?

To do so we need to coordinate another realease with Rustfmt (and so also bump the rustc-ap-data-structures), I believe.

+17 -17

1 comment

2 changed files

Xanewok

pr closed time in 23 days

push eventXanewok/rls

Igor Matuszewski

commit sha 22e2bbee280c826fbb38d2c83f3ed204d3188308

Remove Travis configuration

view details

Igor Matuszewski

commit sha 395d39ed84b91f85732fb69804e7049d636bf4a8

Merge pull request #1628 from Xanewok/remove-travis Remove Travis configuration

view details

Igor Matuszewski

commit sha 630870eced885a258514d52eaca63a399071730b

Update crossbeam-channel to 0.4 To do so, we also upgrade the transient dependency ignore to 0.4.11

view details

push time in 23 days

delete branch Xanewok/rls

delete branch : remove-travis

delete time in 23 days

push eventrust-lang/rls

Igor Matuszewski

commit sha 22e2bbee280c826fbb38d2c83f3ed204d3188308

Remove Travis configuration

view details

Igor Matuszewski

commit sha 395d39ed84b91f85732fb69804e7049d636bf4a8

Merge pull request #1628 from Xanewok/remove-travis Remove Travis configuration

view details

push time in 23 days

PR merged rust-lang/rls

Remove Travis configuration
+0 -47

0 comment

2 changed files

Xanewok

pr closed time in 23 days

PR opened rust-lang/rls

Remove Travis configuration
+0 -47

0 comment

2 changed files

pr created time in 23 days

create barnchXanewok/rls

branch : remove-travis

created branch time in 23 days

PR opened rust-lang/rls

Update crossbeam-channel to 0.4

To do so, we also upgrade the transient dependency ignore to 0.4.11.

@mati865 I'm sorry for not addressing #1614 earlier. I understand to fix the underlying issue, we really need to bump the crossbeam-utils dep to 0.7?

To do so we need to coordinate another realease with Rustfmt (and so also bump the rustc-ap-data-structures), I believe.

+17 -17

0 comment

2 changed files

pr created time in 23 days

create barnchXanewok/rls

branch : update-deps

created branch time in 23 days

pull request commentrust-lang/rls

deps: update cargo

Thanks!

matthiaskrgr

comment created time in 23 days

push eventrust-lang/rls

Matthias Krüger

commit sha 7b5471b646818445c13363d4cdf16f3bb162e1ac

deps: update cargo

view details

Igor Matuszewski

commit sha d60b6c98f6ba0805279bb83b5a34b526c3230d57

Merge pull request #1626 from matthiaskrgr/update_cargo deps: update cargo

view details

push time in 23 days

PR merged rust-lang/rls

deps: update cargo

get rls in sync with latest cargo r? @Xanewok

+31 -16

0 comment

4 changed files

matthiaskrgr

pr closed time in 23 days

delete branch Xanewok/win-crypto-ng

delete branch : random

delete time in a month

delete branch Xanewok/win-crypto-ng

delete branch : patch-1

delete time in a month

pull request commentemgre/win-crypto-ng

Trigger CI on pull_request events as well

Hi @emgre! :wave:

Did you have a chance to look at some of the PRs, by any chance? 😊

Xanewok

comment created time in a month

issue commentparitytech/jsonrpsee

Support no_std

serde_json with alloc-only support landed in 1.0.45 - https://github.com/serde-rs/json/pull/606#issuecomment-577445497

tomaka

comment created time in a month

delete branch Xanewok/json

delete branch : patch-1

delete time in a month

PR opened serde-rs/json

Correct no-std support in README.md

I forgot to include this as part of https://github.com/serde-rs/json/pull/606, sorry! I hope the wording is good enough.

+5 -2

0 comment

1 changed file

pr created time in a month

more