profile
viewpoint
Jacob Kiesel Xaeroxe Vivint Smart Home Utah, USA Engineer at Vivint Smart Home. Skilled in 7 different programming languages, including Rust, C++, C#, JavaScript, and SQL. I also do game dev and web dev.

Xaeroxe/FeatherPasswordManager 37

Highly portable extremely light-weight password manager that stores all your passwords in a local encrypted file.

Xaeroxe/nitro-game-engine 20

A game engine built in Rust for Windows, Mac OSX, and Linux.

Xaeroxe/atom-racer-plus 4

Intelligent code completion for Rust in the Atom Editor. Requires Racer.

Xaeroxe/hot_reload 1

A proof of concept for hot reloading Rust code from a DLL

Xaeroxe/lazy_cat 1

Lazy concatenation of strings and other things in Rust.

Xaeroxe/amethyst 0

Data-oriented game engine written in Rust

Xaeroxe/arrayvec 0

A vector with a fixed capacity. (Rust)

Xaeroxe/bimap-rs 0

A fast two-way bijective map for Rust.

pull request commentvivint-smarthome/opentelemetry-stackdriver

Non blocking send

Unfortunately it seems like the channel is never flushed, so these never actually get uploaded.

jasonahills

comment created time in 16 hours

push eventvivint-smarthome/opentelemetry-stackdriver

Deployment Bot (from Travis CI)

commit sha 3a955d25ad7f98f51eb5288c5f588eb459bbb82c

Deploy vivint-smarthome/opentelemetry-stackdriver to github.com/vivint-smarthome/opentelemetry-stackdriver.git:gh-pages

view details

push time in 2 days

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha ed0ecfdebc6363126f2b9158e112df56b64a8210

Remove execution of unit test from CI, it doesn't work right now.

view details

push time in 2 days

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 92c553e33bb2b8fa4a5796b897f249c01d90411b

Add rustfmt

view details

push time in 2 days

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 4d1e8d5027342dd7c418e16a132c837f894a0a0b

Update README.md

view details

push time in 2 days

PR merged vivint-smarthome/opentelemetry-stackdriver

Tonic

WIP: don't merge me until authentication is done. Only making a PR for your ease of reviewing it.

+224 -151

0 comment

3 changed files

jasonahills

pr closed time in 2 days

push eventvivint-smarthome/opentelemetry-stackdriver

Jason Hills

commit sha 62987d6317b25e80bbf1f12d686a4fd6e3458f6e

WIP moving to tonic

view details

Jason Hills

commit sha dcb0e7422a7bf874cf292a7fea10c3c8381812cc

use spans we build and use a runtime

view details

Jason Hills

commit sha 559eabd66b28b6b31a74a252a0c39e956d0f06c3

adds auth

view details

Jason Hills

commit sha bb511417d53afedade4df24b864a51bb59f23314

tokio spawner

view details

Jason Hills

commit sha bf6077974c1932a7efc46dade207f36067370c20

removes unneeded file

view details

Jason Hills

commit sha 879d065769d7db622087ae9943f4981485e7eeed

removes commented-out code

view details

Jason Hills

commit sha dc7059602b4882c5c328c7b93566db96fe16266c

actually uses tokio spawner

view details

Jacob Kiesel

commit sha 582cc91b16dec33c64dcc086ca8dc78cf842726a

Fix http2 negotiation and authentication

view details

Jacob Kiesel

commit sha e6482ad242d083d3d1cd0cf77a238855801a3dae

Merge pull request #1 from jasonahills/tonic Tonic

view details

push time in 2 days

push eventjasonahills/opentelemetry-stackdriver

Jacob Kiesel

commit sha 582cc91b16dec33c64dcc086ca8dc78cf842726a

Fix http2 negotiation and authentication

view details

push time in 2 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha 0ccd3f453aa4befd4d15dfdb3196651d123fe26e

Fix a couple clippy warnings

view details

push time in 3 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha cafb23feac6c914f93a664ad8800181d091a7b2f

Format and improve unit test

view details

push time in 3 days

pull request commentdanburkert/prost

Fix code generation for code blocks in prost-build

Btw it's worth noting this PR now includes breaking changes for tonic-build crate users. Not sure if that's a use case this project is trying to accomodate or not, but I will point it out.

Xaeroxe

comment created time in 3 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha 17f143a1b68f52ec6d2dc16bca5b564c9e698cff

Improve performance by altering constructor and inner types

view details

push time in 3 days

PR opened tokio-rs/tokio

Add optional support for futures-task::Spawn

<!-- Thank you for your Pull Request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests.

Contributors guide: https://github.com/tokio-rs/tokio/blob/master/CONTRIBUTING.md -->

Motivation

I want to abstract over future executors in my crate, but since tokio doesn't implement futures-task::Spawn I'm unable to. This PR provides an optional implementation of this trait, so that downstream users don't have to implement it for a struct in their own crate.

<!-- Explain the context and why you're making that change. What is the problem you're trying to solve? In some cases there is not a problem and this can be thought of as being the motivation for your change. -->

Solution

Add an optional dependency to tokio that when enabled provides a futures-task::Spawn implementation.

<!-- Summarize the solution and provide any necessary context needed to understand the code change. -->

+19 -0

0 comment

3 changed files

pr created time in 4 days

create barnchXaeroxe/tokio

branch : futures-task

created branch time in 4 days

fork Xaeroxe/tokio

A runtime for writing reliable asynchronous applications with Rust. Provides I/O, networking, scheduling, timers, ...

https://tokio.rs

fork in 4 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha 7b2c2dddeb433da7c0a5acdbfc5e8fcf490597bb

Fix generation of code blocks in Rust code

view details

push time in 4 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha 1a92481ad980fc10d36a79607cd5377390cbfc94

Format

view details

push time in 4 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha d19dcc33525ebff5630be54dd60a43e9e4f5efaf

Fix generation of code blocks in Rust code

view details

push time in 4 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha 3113e43c59ada3c6031d85dec42139d0ff916edc

Fix code generation for code blocks in prost-build

view details

push time in 5 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha 514b5e07cd4f338d087f3d09615bb09a69aee91f

Fix some indenting bugs and patch in a fence at the end of an indented code block if one wasn't reached

view details

push time in 5 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha 9826ce23fd9c096607fe73f613bc1a88a33acb45

DRY up code and fix a bug

view details

push time in 5 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha 62bb80c0160e3e2c2f6854a263497eaed9503ba3

Fix indented code blocks too

view details

push time in 5 days

push eventXaeroxe/prost

Jacob Kiesel

commit sha f157f4b27e9b20041a0c23d6762241eca7d78308

Format

view details

push time in 5 days

PR opened danburkert/prost

Fix code generation for code blocks in prost-build

If the generated doc comments include a code block rustdoc will erroneously try and execute them.

That's silly as these blocks almost never contain valid Rust, so this PR marks these blocks as text.

+60 -2

0 comment

4 changed files

pr created time in 5 days

create barnchXaeroxe/prost

branch : ignore-doc

created branch time in 5 days

fork Xaeroxe/prost

PROST! a Protocol Buffers implementation for the Rust Language

fork in 5 days

create barnchXaeroxe/rfcs

branch : my-rfc

created branch time in 17 days

push eventXaeroxe/xaeroxe.github.io

Jacob Kiesel

commit sha 8519ca2d1a02d0c671ec7592b578f7571bb92cc5

make builder example more idiomatic

view details

push time in 18 days

push eventXaeroxe/xaeroxe.github.io

Jacob Kiesel

commit sha c37b61e4500cd33aa47771e45c54d731d5a10dd4

Fix typo

view details

push time in 18 days

push eventXaeroxe/xaeroxe.github.io

Jacob Kiesel

commit sha 95cd190b37dce3496629af4291f95a1a05e229d6

Add init struct pattern blog post

view details

push time in 18 days

push eventXaeroxe/FeatherPasswordManager

Jacob Kiesel

commit sha 476501bf2958337042a5392f2cdd8275b6345194

Update screenshot

view details

push time in 19 days

push eventvivint-smarthome/opentelemetry-stackdriver

Deployment Bot (from Travis CI)

commit sha b27e42aedec862b3ab4df0a16b2d2c6f94fbad20

Deploy vivint-smarthome/opentelemetry-stackdriver to github.com/vivint-smarthome/opentelemetry-stackdriver.git:gh-pages

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 5bd57797f9ca1146d7842dfa6cb7ee7b58ffd1be

Propagate error initializing up to caller, and bump major version number

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Deployment Bot (from Travis CI)

commit sha 85f0e97178e01a3f3012954afd85a77745a8b558

Deploy vivint-smarthome/opentelemetry-stackdriver to github.com/vivint-smarthome/opentelemetry-stackdriver.git:gh-pages

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 08e92c5607d3f0901aa3ef1f2e221d458191c8e2

Don't block on uploading traces

view details

Jacob Kiesel

commit sha 23c623082b4537803bcdcea694a980d94b622f13

Bump to 0.1.3

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Deployment Bot (from Travis CI)

commit sha e9bf25326b7c7533b8fa0fd05182998a630128df

Deploy vivint-smarthome/opentelemetry-stackdriver to github.com/vivint-smarthome/opentelemetry-stackdriver.git:gh-pages

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Deployment Bot (from Travis CI)

commit sha 1a4b87a40012cbcf13cb41fa308c45598b7cd8d0

Deploy vivint-smarthome/opentelemetry-stackdriver to github.com/vivint-smarthome/opentelemetry-stackdriver.git:gh-pages

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 1940f0f3269c0f275abf7b8c03b84c0d9550dbb0

Bump patch version

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha b42ebe53a2455417c2c41342729831a3ad41f22f

Set span ID correctly

view details

Jacob Kiesel

commit sha 293cd34002f3bb9c76795c1d5adc0ff8b3f31414

Merge branch 'master' of github.com:vivint-smarthome/opentelemetry-stackdriver

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Deployment Bot (from Travis CI)

commit sha 586b5d1e6d009df31df581512be2566ade016a99

Deploy vivint-smarthome/opentelemetry-stackdriver to github.com/vivint-smarthome/opentelemetry-stackdriver.git:gh-pages

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 99e8cb30f478861e1a82bd6d71795dd5ad79a4d7

add doc link to readme

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Deployment Bot (from Travis CI)

commit sha b834e7d5773da50781d0c3e6a5512b0007c6e9b2

Deploy vivint-smarthome/opentelemetry-stackdriver to github.com/vivint-smarthome/opentelemetry-stackdriver.git:gh-pages

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 57fc2c13fd13e9bace8acacf507cc077f96bf2b2

Fix doc URL

view details

push time in a month

create barnchvivint-smarthome/opentelemetry-stackdriver

branch : gh-pages

created branch time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 0c26cd628708d123567a5f99c9b6e033515ad018

Sudo as needed

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 07fc6c3f55431a7461da807caadcff8803ee959f

Fix docs url

view details

Jacob Kiesel

commit sha 581a926b42e7003e81c674185523d7b8c316184a

Fetch proto 3 instead of proto 2

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha e42b61353aae59c9147fa1f196487e7ebe6e4d56

Add travis yml

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha df7a4a72a162947262e22b6eb73fd1d1c11ac812

Fix license

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha cd86d966258219ffc5a066239485972aa74e7929

Fix docs url

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 06a7c3b7d3f1565c174273555e90436784a5a5b3

Prepare for crates.io

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 385ec81bf12f24220f3288b70db44abcba857080

Fix proto privacy

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 5f590bf59e7bda98d660ebbe291d977999ef051e

Use code generator more intelligently

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 668294773951a63cf98e61e33f8f6adf991b6f99

Add a few fixes

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha feaffd767793ee4f174f097f4820fdefee193242

Transform span data into protobuf form

view details

push time in a month

created tagXaeroxe/FeatherPasswordManager

tag1.8

Highly portable extremely light-weight password manager that stores all your passwords in a local encrypted file.

created time in a month

push eventXaeroxe/FeatherPasswordManager

Jacob Kiesel

commit sha e36562261e425f92c1e98be18e77eb6cd83631c4

Fix PWA colors

view details

push time in a month

push eventXaeroxe/FeatherPasswordManager

Jacob Kiesel

commit sha f9e8ce952e3aa4901a85a79f754321daff33d4ae

Provide merge reports in the merge tool and provide a password load count in the main page

view details

Jacob Kiesel

commit sha 94133fd33a3714ed395c0449168dae519126328e

Merge branch 'master' of github.com:Xaeroxe/FeatherPasswordManager

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 9a1f5399d03406827fcd6ee4010eae994d8414c0

Run formatter

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha e2f7e61e8790d87b0f419de9e2e370867c56d464

Handle error

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha f8b4f33a4341da97828e8ca30cc1faae5edb44bf

Send an empty BatchWriteRequest

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha db09177f1d9972c291bbfbad7dfd3e736ce7e756

Switch to grpcio

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 1e9f059c9ec25dd1dfb4cc1ba991c57ab866e06b

Add a broken Dockerfile, will fix later

view details

Jacob Kiesel

commit sha df3ca5efb775cf2a4cec7f4d9fcff53664dfc2a5

Move generated proto to out dir

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 513fb2cf77e5d213a6394337e65e2ee00886e956

Create rust.yml

view details

push time in a month

push eventvivint-smarthome/opentelemetry-stackdriver

Jacob Kiesel

commit sha 660321e75d69e484cac1cd4cde2bcc7a2dfe8488

Provide skeleton implementation

view details

Jacob Kiesel

commit sha bda700ecb9fca0eacce57f2cb912685853eef486

Add dual license

view details

Jacob Kiesel

commit sha ee9b048a3690a6fc6244547b628b32d944c8ab3f

Add auto generated protobuf definitions for use with gRPC

view details

push time in a month

create barnchvivint-smarthome/opentelemetry-stackdriver

branch : master

created branch time in a month

created repositoryvivint-smarthome/opentelemetry-stackdriver

A Rust OpenTelemetry exporter for Google StackDriver

created time in a month

push eventXaeroxe/amethyst

Marco

commit sha 9c1b7af519c26815c399541957de5ada447fd79c

Implement mouse-axis as input

view details

jaynus

commit sha 34e0112b28b868fe41b6aae12278fcf5e97bc6e4

bug testing

view details

jaynus

commit sha b7a9db8ed0959910893dee26fd01a586d5c94b2c

Fix dimensions assumption error with encoding

view details

jaynus

commit sha b83427ddfd8d6a334eaac6e10a19c2268b9024f4

enter changelog entry

view details

jaynus

commit sha 9f72376a31185cdd1252485a26b94c8a4711d48d

shutup clippy

view details

jaynus

commit sha 28526faa2c1a9a05536350e6a108b02c30608abf

Merge branch 'master' of github.com:/amethyst/amethyst into tiles_broken

view details

jaynus

commit sha f71da1a5d9216a6da38de4ac58fdd38744a4ef3a

Merge branch 'master' into tiles_broken

view details

Aaron

commit sha 45fa91f1639ef5f2224718853a199fa263b5de6b

fix link to specs book

view details

Valkum

commit sha 262ebcd12913b1278ecded20d567182eb85048cf

Improve SpriteSheet loading from ron files This allows loading of grid definitions now. For this the current ron files must be wrapped in Grid() or List()

view details

Valkum

commit sha ba0ac5029fa83ec7268ef57679d516adf9f787a1

Improve error type for non parsable SpriteSheet ron

view details

Valkum

commit sha 01eba0b752fb6ea855669137443371c2988b122c

Add PR Link to CHANGELOG

view details

Valkum

commit sha 1e92e03029117f1c9b7de0a22a4dde3476fde1f6

cargo fmt

view details

Valkum

commit sha 0718924dd3de5f1177a2964d5592f687ac7ad473

Update book

view details

Valkum

commit sha 9e4c66c56217c576a663decaf8a3a09b70c05187

Update pong chapter in book

view details

Azriel Hoh

commit sha 3489c176a307e8558c7122f41ac56ed15a6ee39a

Merge branch 'master' into improve_spritesheetformat_loader

view details

Azriel Hoh

commit sha e61e16494ca118323e660faea2101455e4de1cc5

Implement `Copy` and `PartialEq` for `Tint`.

view details

Azriel Hoh

commit sha 44f163a6ff38d5e85bfde2edc40bcc5090a4cda7

Updated `CHANGELOG.md`.

view details

bors[bot]

commit sha 14dffc5e098c6cd9e5096b128bedcda016a3adb0

Merge #2021 2021: fix link to specs book r=azriel91 a=krehera previous link 404ed Co-authored-by: Aaron <chishx@gmail.com>

view details

bors[bot]

commit sha 38f04eb5709f892d9bdaed3a23ea1c5235584663

Merge #2023 #2033 2023: Improve SpriteSheetFormat::import_simple to support grids and lists r=azriel91 a=valkum ## Description Improve the loader of SpriteSheetFormat to allow loading of Grid definitions in ron files. Currently you can only specify sprites as `SpriteList` in ron files. Closes #1997 ## Modifications - `SpriteSheetFormat::import_simple` now uses the `Sprites` enum instead of using `SpriteList` directly. This is a breaking change in current ron files loaded using SpriteSheetFormat. ## PR Checklist By placing an x in the boxes I certify that I have: - [x] Updated the content of the book if this PR would make the book outdated. - [x] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - [x] Added unit tests for new code added in this PR. - [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. If this modified or created any rs files: - [x] Ran `cargo +stable fmt --all` - [x] Ran `cargo clippy --all --features "empty"` - [x] Ran `cargo test --all --features "empty"` 2033: Implement `Copy` and `PartialEq` for `Tint`. r=azriel91 a=azriel91 ## Description Derive `Copy` and `PartialEq` for `amethyst::renderer::resources::Tint`. ## Additions - Derive `Copy` and `PartialEq` for `amethyst::renderer::resources::Tint`. ## PR Checklist By placing an x in the boxes I certify that I have: - **n/a** Updated the content of the book if this PR would make the book outdated. - [x] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment. - **n/a** Added unit tests for new code added in this PR. - [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme. If this modified or created any rs files: - [x] Ran `cargo +stable fmt --all` - [x] Ran `cargo clippy --all --features "empty"` - [x] Ran `cargo test --all --features "empty"` Co-authored-by: Valkum <rudi.floren@gmail.com> Co-authored-by: Azriel Hoh <azriel91@gmail.com>

view details

0x40

commit sha 15dd8c96b5bb4c413b2b48e6412b5c2ec1e6c76c

fix spritesheet examples after #2023 broke them

view details

push time in a month

push eventXaeroxe/FeatherPasswordManager

Jacob Kiesel

commit sha 729d371072553e8a3e4a67c969217954206a66a9

Use Ubuntu Mono font for improved readability

view details

push time in a month

push eventXaeroxe/vimrc

Jacob Kiesel

commit sha f2c0297444ed78b9b251a4fe33dff695db1558a7

Fix custom prompt length calculation

view details

push time in 2 months

push eventXaeroxe/vimrc

Jacob Kiesel

commit sha 75cae3b6b87dd635db675e06928002cfb9544390

Set tab to two spaces

view details

push time in 2 months

created tagXaeroxe/FeatherPasswordManager

tag1.7

Highly portable extremely light-weight password manager that stores all your passwords in a local encrypted file.

created time in 2 months

release Xaeroxe/FeatherPasswordManager

1.7

released time in 2 months

push eventXaeroxe/FeatherPasswordManager

Jacob Kiesel

commit sha deaa684c8afe9190e0ee30027f125357540c5684

Conceal password after copying

view details

push time in 2 months

delete branch Xaeroxe/futures-rs

delete branch : map_ok_or_else

delete time in 2 months

Pull request review commentrust-lang/futures-rs

Add TryFutureExt::map_ok_or_else method

+use core::pin::Pin;+use futures_core::future::{FusedFuture, Future, TryFuture};+use futures_core::task::{Context, Poll};+use pin_utils::{unsafe_pinned, unsafe_unpinned};++/// Future for the [`map_ok_or_else`](super::TryFutureExt::map_ok_or_else) method.+#[derive(Debug)]+#[must_use = "futures do nothing unless you `.await` or poll them"]+pub struct MapOkOrElse<Fut, F, E> {+    future: Fut,+    f: Option<F>,+    e: Option<E>,+}++impl<Fut, F, E> MapOkOrElse<Fut, F, E> {+    unsafe_pinned!(future: Fut);+    unsafe_unpinned!(f: Option<F>);+    unsafe_unpinned!(e: Option<E>);++    /// Creates a new MapOkOrElse.+    pub(super) fn new(future: Fut, e: E, f: F) -> Self {+        Self { future, f: Some(f), e: Some(e) }+    }+}++impl<Fut: Unpin, F, E> Unpin for MapOkOrElse<Fut, F, E> {}++impl<Fut, F, E, T> FusedFuture for MapOkOrElse<Fut, F, E>+    where Fut: TryFuture,+          F: FnOnce(Fut::Ok) -> T,+          E: FnOnce(Fut::Error) -> T,+{+    fn is_terminated(&self) -> bool {+        self.f.is_none()

Good catch, fixed!

Xaeroxe

comment created time in 2 months

push eventXaeroxe/futures-rs

Jacob Kiesel

commit sha 41ecac03cee42aa98f1c698ec218000fc6757cb4

Fix is_terminated

view details

push time in 2 months

push eventXaeroxe/futures-rs

Jacob Kiesel

commit sha 8fdc90cb6016b473de4d3f4c4833a382d841d0c8

Fix doc link

view details

push time in 2 months

PR opened rust-lang/futures-rs

Add TryFutureExt::map_ok_or_else method

Similar to the recently stabilized Result::map_ok_or_else method, this adds a method to the TryFutureExt trait that fulfills a similar purpose.

+104 -0

0 comment

2 changed files

pr created time in 2 months

create barnchXaeroxe/futures-rs

branch : map_ok_or_else

created branch time in 2 months

fork Xaeroxe/futures-rs

Zero-cost asynchronous programming in Rust

https://rust-lang.github.io/futures-rs/

fork in 2 months

delete branch Xaeroxe/amethyst

delete branch : simplify-mouse-axis

delete time in 2 months

pull request commentamethyst/amethyst

Simplify mouse axis, only one radius value would ever be used for a given config

bors r=@jojolepro

Xaeroxe

comment created time in 2 months

push eventXaeroxe/amethyst

Jacob Kiesel

commit sha 09c64e5c294944e17ab48530db1841ec52fbd4e0

Add changelog entry

view details

push time in 2 months

PR opened amethyst/amethyst

Simplify mouse axis, only one radius value would ever be used for a given config

Description

For a mouse input axis one of the two radial values is guaranteed to go unused, so this simplifies the structure.

Additions

  • amethyst_input::Axis::Mouse::radius

Removals

  • amethyst_input::Axis::Mouse::radius_x
  • amethyst_input::Axis::Mouse::radius_y

Modifications

  • N/A

PR Checklist

By placing an x in the boxes I certify that I have:

  • N/A Updated the content of the book if this PR would make the book outdated.
  • [ ] Added a changelog entry if this will impact users, or modified more than 5 lines of Rust that wasn't a doc comment.
  • N/A Added unit tests for new code added in this PR.
  • [x] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme.

If this modified or created any rs files:

  • [x] Ran cargo +stable fmt --all
  • [x] Ran cargo clippy --all --features "empty"
  • [x] Ran cargo test --all --features "empty"
+5 -11

0 comment

2 changed files

pr created time in 2 months

push eventXaeroxe/amethyst

Jacob Kiesel

commit sha 13b7bf9680a247e803b3902435d7f1f5555e00f2

Fix unrelated clippy warning

view details

push time in 2 months

create barnchXaeroxe/amethyst

branch : simplify-mouse-axis

created branch time in 2 months

push eventamethyst/amethyst

lberrymage

commit sha 693dd0a272e57e34f65a7b319dbe051b50057806

Fix minor grammatical error in pong tutorial

view details

push time in 3 months

PR merged amethyst/amethyst

Fix minor grammatical error in pong tutorial status: done team: documentation

Description

The wrong form of "implementing" is used in the pong tutorial section of the book.

Additions

None

Removals

None

Modifications

Changing one word in the book.

PR Checklist

By placing an x in the boxes I certify that I have:

  • [X] Acknowledged that by making this pull request I release this code under an MIT/Apache 2.0 dual licensing scheme.
+1 -1

2 comments

1 changed file

lberrymage

pr closed time in 3 months

Pull request review commentamethyst/amethyst

Maintenance/update rodio cpal

 use crate::{  /// Builds an `AudioSystem`. #[derive(Default, Debug, new)]-pub struct AudioSystemDesc {-    /// Audio `Output`.-    pub output: Output,-}+pub struct AudioSystemDesc;  impl<'a, 'b> SystemDesc<'a, 'b, AudioSystem> for AudioSystemDesc {     fn build(self, world: &mut World) -> AudioSystem {         <AudioSystem as System<'_>>::SystemData::setup(world); -        world.insert(self.output.clone());+        world.insert(Output::default());

Being able to support a non default output is really important to gamers. This is an unfortunate limitation we should try and work around.

azriel91

comment created time in 3 months

pull request commentamethyst/amethyst

Fix minor grammatical error in pong tutorial

@bors r+

Thanks!

lberrymage

comment created time in 3 months

push eventXaeroxe/rust

push time in 3 months

push eventXaeroxe/rust

Georg Semmler

commit sha 089a894193c34babe51af62e570d295021c215d6

Merge branch 'bugfix/issue_66295' of github.com:weiznich/rust into bugfix/issue_66295

view details

Matthew Kraai

commit sha 0c4bc58cee1a6723d55f18b226bc46bfaefcbff3

Change "either" to "any" in Layout::from_size_align's docs

view details

Yuki Okushi

commit sha 2a4f638d245569580d95d4bc25bea1d41c4d1c2f

Rollup merge of #66846 - gizmondo:master, r=michaelwoerister Make try_mark_previous_green aware of cycles. Fixes #61323 r? @michaelwoerister

view details

Yuki Okushi

commit sha afd9e95b8b5aee4379a2ae2be680e391a3deca08

Rollup merge of #66959 - GuillaumeGomez:cfg-duplicates, r=eddyb Remove potential cfgs duplicates Fixes https://github.com/rust-lang/rust/issues/66921. Before going any further (the issue seems to be linked to metadata as far as I can tell). Do you think this is the good place to do it or should it be done before? r? @eddyb

view details

Yuki Okushi

commit sha 7249af0c7b7fbaefe9cb63f6e6c6fa35fb975cff

Rollup merge of #66988 - osa1:issue66985, r=matthewjasper Fix angle bracket formatting when dumping MIR debug vars Fixes #66985

view details

Yuki Okushi

commit sha cdbdb686f9a5f2ba5751e97d4a172d2d6ba0c62c

Rollup merge of #66998 - Wind-River:master_up, r=alexcrichton Modified the testcases for VxWorks

view details

Yuki Okushi

commit sha 0df1609215bb3080c463d38f899fc6b723229536

Rollup merge of #67008 - ollie27:rustdoc_issue_61732, r=Centril rustdoc: Add test for fixed issue #61732 was almost certainly fixed by #63400. Closes #61732

view details

Yuki Okushi

commit sha fd4cec0303d2256e37f3e926e112aaa2d8b38a8b

Rollup merge of #67023 - jethrogb:jb/bootstrap-target-linker, r=alexcrichton SGX: Fix target linker used by bootstrap Bootstrap, for some reason, overrides the target linker. This is not correct for x86_64-fortanix-unknown-sgx. Add such targets to the list of exceptions. r? @alexcrichton

view details

Yuki Okushi

commit sha 0b471bffc3a81a2b9f1c29debb53d2b3b6fbe117

Rollup merge of #67033 - cuviper:ValueName2, r=rkruppe Migrate to LLVM{Get,Set}ValueName2 The deprecated `LLVM{Get,Set}ValueName` only work with NUL-terminated strings, but the `2` variants use explicit lengths, which fits better with Rust strings and slices. We now use these in new helper functions `llvm::{get,set}_value_name` that convert to/from `&[u8]`. Closes #64223. r? @rkruppe

view details

Yuki Okushi

commit sha d1397db3f3e0010a2a2ce9efedc9903907143319

Rollup merge of #67049 - tmiasko:io-slice-advance, r=rkruppe Simplify {IoSlice, IoSliceMut}::advance examples and tests Remove unnecessary calls to `std::mem::replace` and make variables immutable.

view details

Yuki Okushi

commit sha c85284ec58f353c9df7615f9f130f65572a3f639

Rollup merge of #67054 - RalfJung:set-discriminant-unreachable, r=oli-obk codegen "unreachable" for invalid SetDiscriminant Follow-up from https://github.com/rust-lang/rust/pull/66960. I also realized I don't understand our policy for using `abort` vs `unreachable`. AFAIK `abort` is safe to call and just aborts the process, while `unreachable` is UB. But sometimes we use both, like here https://github.com/rust-lang/rust/blob/d825e35ee8325146e6c175a4c61bcb645b347d5e/src/librustc_codegen_ssa/mir/block.rs#L827-L828 and here https://github.com/rust-lang/rust/blob/d825e35ee8325146e6c175a4c61bcb645b347d5e/src/librustc_codegen_ssa/mir/block.rs#L264-L265 The second case is even more confusing because that looks like an unreachable `return` to me, so why would we codegen a safe abort there? r? @eddyb Cc @oli-obk

view details

Yuki Okushi

commit sha cc7c45fdc67a7e8439a502ef6de65f3d7db01dd8

Rollup merge of #67081 - osa1:fix_query_type_docs, r=Dylan-DPC Fix Query type docs `give` no longer exists, `compute` is used to generate query results now.

view details

Yuki Okushi

commit sha 931be6c3bccc38be9052433c321f11da033c57c5

Rollup merge of #67085 - reitermarkus:addr-parser, r=Mark-Simulacrum Remove boxed closures in address parser. Simplify address parser by removing unnecessary boxed closures. Also relevant for https://github.com/rust-lang/rfcs/pull/2832.

view details

bors

commit sha 9630dbbc3caca60f2482e6eae8904aa6bda54f93

Auto merge of #67091 - JohnTitor:rollup-kitphze, r=JohnTitor Rollup of 11 pull requests Successful merges: - #66846 (Make try_mark_previous_green aware of cycles.) - #66959 (Remove potential cfgs duplicates) - #66988 (Fix angle bracket formatting when dumping MIR debug vars) - #66998 (Modified the testcases for VxWorks) - #67008 (rustdoc: Add test for fixed issue) - #67023 (SGX: Fix target linker used by bootstrap) - #67033 (Migrate to LLVM{Get,Set}ValueName2) - #67049 (Simplify {IoSlice, IoSliceMut}::advance examples and tests) - #67054 (codegen "unreachable" for invalid SetDiscriminant) - #67081 (Fix Query type docs) - #67085 (Remove boxed closures in address parser.) Failed merges: r? @ghost

view details

Matthew Kraai

commit sha a3c85770fbf3ebe405dbc38c26483628146de240

Change "us" to "is" in Layout::for_value comment

view details

Matthew Kraai

commit sha 292b998c64ed0459b875eac9f5dccb2786a9deca

Change "wth" to "with" in `Layout::padding_needed_for` comment

view details

Janusz Marcinkiewicz

commit sha d419a5fdaebb36dbf3c600f624c964d9ea651661

Fix pointing at arg when cause is outside of call

view details

Ralf Jung

commit sha 49697ae38bb724fd4eff97c64e73a83b9c1a28df

get rid of __ in field names

view details

Ömer Sinan Ağacan

commit sha 2404a067eedd83ab69bb0e07fdc8145825741722

const-prop: Restrict scalar pair propagation We now only propagate a scalar pair if the Rvalue is a tuple with two scalars. This for example avoids propagating a (u8, u8) value when Rvalue has type `((), u8, u8)` (see the regression test). While this is a correct thing to do, implementation is tricky and will be done later. Fixes #66971 Fixes #66339 Fixes #67019

view details

Mark Mansi

commit sha 03222c037142e915e9ea75f681ab98a5a46b8739

Update rustc-guide

view details

push time in 3 months

delete branch Xaeroxe/rust

delete branch : patch-1

delete time in 3 months

push eventXaeroxe/vimrc

Jacob Kiesel

commit sha f8c83fa0f3840e8c0cc43bed77210b924a00263d

Add plugins and auto NERDTree

view details

push time in 3 months

pull request commentamethyst/amethyst

Implement the mouse as input axis

bors r=distransient,jojolepro,xaeroxe

minecrawler

comment created time in 3 months

push eventXaeroxe/webrtc-ice

Jacob Kiesel

commit sha 499fca0d7d75a7e900a881a5b949d4c03f450ba0

Update README.md

view details

push time in 3 months

push eventXaeroxe/webrtc-ice

Jacob Kiesel

commit sha 1bf31c8471dd21b82f3c44c23fb2299e810fd712

Setup CI

view details

push time in 3 months

more