profile
viewpoint

Tomsgu/PDFMerger 6

Simple wrapper for merging pdf files for PHP >= 7.2.

Tomsgu/PDFMergerBundle 3

Symfony bundle that integrates tomsgu/pdf-merger.

Tomsgu/dotfiles 1

My linux configuration

Tomsgu/Bomberman 0

An implementation of bomberman in ncurses.

Tomsgu/code 0

Code editor designed for elementary OS

Tomsgu/DatatablesBundle 0

This Bundle integrates the jQuery DataTables plugin into your Symfony application.

Tomsgu/extractor 0

Extracts translation strings from source code

Tomsgu/FOSUserBundle 0

Provides user management for your Symfony2 project. Compatible with Doctrine ORM & ODM, and Propel.

Tomsgu/Invoice 0

A personal project to manage invoices.

Tomsgu/LexikFormFilterBundle 0

This Symfony2 bundle aim to provide classes to build some form filters and then build a doctrine query from this form filter.

PR opened doctrine/orm

Add docs to export-ignore
+1 -0

0 comment

1 changed file

pr created time in 17 hours

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false

Service container linter is not available in symfony 3.4, so we can only implement that in the 2.0 branch

luca-rath

comment created time in 21 hours

PR closed doctrine/orm

php 8

doctrine/orm 2.7.4 requires php ^7.1 -> your PHP version (8.0.0) does not satisfy that requirement.

+1 -1

1 comment

1 changed file

psohm

pr closed time in 21 hours

pull request commentdoctrine/orm

php 8

In 2.8 will be added support PHP 8.0. See for details #8350

psohm

comment created time in 21 hours

PR opened doctrine/orm

php 8

doctrine/orm 2.7.4 requires php ^7.1 -> your PHP version (8.0.0) does not satisfy that requirement.

+1 -1

0 comment

1 changed file

pr created time in a day

issue openeddoctrine/orm

Make auto generated relation tables accessible for queries

Doctrine currently seems to be blind for its own auto generated relation tables. This leads into several performance and other kind of problems.

For example, if you define a many-many-relation in the two Entities thru the annotations, and later have to access info thru this relation, it leads into several performance problems. Let's say you have a entity A and B, and now want to count the number of Bs related to A for each entry of A in an inner select, you currently have to use the sql command MEMBER OF:

(SELECT COUNT(at.id) FROM entityA at WHERE entityB MEMBER OF entityA.entitiesB)

It seems to happen often then, that Doctrine now converts this kind of simple information request to at least two additional subqueries, in addition to this one! In a complex query context, this will lead into drastical performance problems. Let's say that MEMBER OF seems to be a very costly function.

On the other hand, if you could access the relation table itself, you simply could do a:

(SELECT COUNT(rt.entity_a_id) FROM entityA_entityB rt WHERE rt.entity_b_id = entityB.id)

This one is a ton faster than the query above. So why are the relation tables invisible? It seems to me a unneccessary handicap for the programmer. Why is that?

created time in a day

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: disabled+                          SYMFONY__PHPCR__TRANSPORT: doctrinedbal+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9201++                    - php-version: '7.4'+                      elasticsearch-version: '7'+                      code-coverage: true+                      test-flags: '--coverage-clover=clover.xml'+                      phpcr-transport: jackrabbit+                      composer-flags: '--prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, imagick'+                      tools: 'composer:v2'+                      phpstan: true+                      lint-container: true+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: weak+                          SYMFONY__PHPCR__TRANSPORT: jackrabbit+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9202++        services:+            mysql:+                image: mysql:5.7+                env:+                    MYSQL_ROOT_PASSWORD: root+                ports:+                    - 3306:3306+                options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5++            jackrabbit:+                image: sulu/jackrabbit:2.18+                env:+                    DATABASE_HOST: mysql+                    DATABASE_PORT: 3306+                    DATABASE_NAME: sulu_test_jackrabbit+                    DATABASE_USER: root+                    DATABASE_PASS: root+                    LOG_LEVEL: WARN+                ports:+                    - 8080:8080++            elasticsearch56:+                image: elasticsearch:5.6+                ports:+                    - 9201:9200+                options: -e="discovery.type=single-node"++            elasticsearch75:+                image: elasticsearch:7.9.3+                ports:+                    - 9202:9200+                options: -e="discovery.type=single-node"++        steps:+            - name: Checkout project+              uses: actions/checkout@v2++            - name: Install and configure PHP+              uses: shivammathur/setup-php@v2+              with:+                  php-version: ${{ matrix.php-version }}+                  extensions: ${{ matrix.php-extensions }}+                  tools: ${{ matrix.tools }}+                  coverage: xdebug++            - name: Get composer cache directory+              id: composer-cache-dir+              run: echo "::set-output name=dir::$(composer config cache-files-dir)"++            - name: Cache dependencies+              uses: actions/cache@v2+              id: composer-cache+              with:+                  path: ${{ steps.composer-cache-dir.outputs.dir }}+                  key: ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}+                  restore-keys: |+                      ${{ runner.os }}-composer-++            - name: Require elasticsearch dependency+              run: composer require --dev elasticsearch/elasticsearch:"^${{ matrix.elasticsearch-version }}" --no-interaction --no-update++            - name: Require phpstan dependency+              if: ${{ matrix.phpstan }}+              run: composer require --dev phpstan/phpstan --no-interaction --no-update++            - name: Install dependencies+              run: |+                  composer validate+                  composer update ${{ matrix.composer-flags }}++            - name: Create database and elasticsearch indices+              run: |+                  - ./Tests/app/console doctrine:database:create+                  - ./Tests/app/console doctrine:schema:update --force+                  - ./Tests/app/console sulu:document:initialize+                  - ./Tests/app/console ongr:es:index:create -m default+                  - ./Tests/app/console ongr:es:index:create -m live+              env: ${{ matrix.env }}++            - name: PHPStan+              if: ${{ matrix.phpstan }}+              run: |+                  bin/adminconsole cache:clear --env dev+                  bin/websiteconsole cache:clear --env dev+                  vendor/bin/phpstan analyze . --level 1 -c phpstan.neon+              env: ${{ matrix.env }}++            - name: Run tests+              run: time vendor/bin/phpunit ${{ matrix.test-flags }}+              env: ${{ matrix.env }}++            - name: Cache ocular runnable

can we add a scruntinizer badge to the README then? i doubt that anybody will even find that information otherwise 🙈

luca-rath

comment created time in a day

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: disabled+                          SYMFONY__PHPCR__TRANSPORT: doctrinedbal+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9201++                    - php-version: '7.4'+                      elasticsearch-version: '7'+                      code-coverage: true+                      test-flags: '--coverage-clover=clover.xml'+                      phpcr-transport: jackrabbit+                      composer-flags: '--prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, imagick'+                      tools: 'composer:v2'+                      phpstan: true+                      lint-container: true+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: weak+                          SYMFONY__PHPCR__TRANSPORT: jackrabbit+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9202++        services:+            mysql:+                image: mysql:5.7+                env:+                    MYSQL_ROOT_PASSWORD: root+                ports:+                    - 3306:3306+                options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5++            jackrabbit:+                image: sulu/jackrabbit:2.18+                env:+                    DATABASE_HOST: mysql+                    DATABASE_PORT: 3306+                    DATABASE_NAME: sulu_test_jackrabbit+                    DATABASE_USER: root+                    DATABASE_PASS: root+                    LOG_LEVEL: WARN+                ports:+                    - 8080:8080++            elasticsearch56:+                image: elasticsearch:5.6+                ports:+                    - 9201:9200+                options: -e="discovery.type=single-node"++            elasticsearch75:+                image: elasticsearch:7.9.3+                ports:+                    - 9202:9200+                options: -e="discovery.type=single-node"++        steps:+            - name: Checkout project+              uses: actions/checkout@v2++            - name: Install and configure PHP+              uses: shivammathur/setup-php@v2+              with:+                  php-version: ${{ matrix.php-version }}+                  extensions: ${{ matrix.php-extensions }}+                  tools: ${{ matrix.tools }}+                  coverage: xdebug++            - name: Get composer cache directory+              id: composer-cache-dir+              run: echo "::set-output name=dir::$(composer config cache-files-dir)"++            - name: Cache dependencies+              uses: actions/cache@v2+              id: composer-cache+              with:+                  path: ${{ steps.composer-cache-dir.outputs.dir }}+                  key: ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}+                  restore-keys: |+                      ${{ runner.os }}-composer-++            - name: Require elasticsearch dependency+              run: composer require --dev elasticsearch/elasticsearch:"^${{ matrix.elasticsearch-version }}" --no-interaction --no-update++            - name: Require phpstan dependency+              if: ${{ matrix.phpstan }}+              run: composer require --dev phpstan/phpstan --no-interaction --no-update++            - name: Install dependencies+              run: |+                  composer validate+                  composer update ${{ matrix.composer-flags }}++            - name: Create database and elasticsearch indices+              run: |+                  - ./Tests/app/console doctrine:database:create+                  - ./Tests/app/console doctrine:schema:update --force+                  - ./Tests/app/console sulu:document:initialize+                  - ./Tests/app/console ongr:es:index:create -m default+                  - ./Tests/app/console ongr:es:index:create -m live+              env: ${{ matrix.env }}++            - name: PHPStan+              if: ${{ matrix.phpstan }}+              run: |+                  bin/adminconsole cache:clear --env dev+                  bin/websiteconsole cache:clear --env dev+                  vendor/bin/phpstan analyze . --level 1 -c phpstan.neon+              env: ${{ matrix.env }}++            - name: Run tests+              run: time vendor/bin/phpunit ${{ matrix.test-flags }}+              env: ${{ matrix.env }}++            - name: Cache ocular runnable

i would do it ;) we have it - so we should keep it 👍

luca-rath

comment created time in a day

issue openedsulu/SuluArticleBundle

Versioning function missing in 2.2

Problem description

Versioning cannot be enabled as described in https://docs.sulu.io/en/2.2/cookbook/jackrabbit.html When following the guide it seems to work fine, but there is no possibility to revert to an earlier version.

Proposed solution

Create a possibility to revert a page to a previous version as stated in the documentation here: https://docs.sulu.io/en/2.2/bundles/page/versioning.html

created time in a day

created repositorycassidyjames/pinebook-pro-skin

Vinyl skin for Pinebook Pro laptop lid

created time in a day

issue commentdoctrine/orm

Doctrine 2 Criteria using multiple orderings

Is there an open issue for that @cdaguerre ? I've just come across this (more than 3 years old) problem...

pettersoderlund

comment created time in 2 days

pull request commentdoctrine/orm

Fix Hidden fields triggering error when using getSingleScalarResult()

Tests updated 🙂

Mediagone

comment created time in 2 days

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false

yes, I also do think it would be useful, just wanted to mention that

luca-rath

comment created time in 2 days

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false

yeah i know, i think it would be useful there too 😇 dont you think so? @sulu/core-team

luca-rath

comment created time in 2 days

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false

we also didn't do that in sulu/sulu

luca-rath

comment created time in 2 days

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: disabled+                          SYMFONY__PHPCR__TRANSPORT: doctrinedbal+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9201++                    - php-version: '7.4'+                      elasticsearch-version: '7'+                      code-coverage: true+                      test-flags: '--coverage-clover=clover.xml'+                      phpcr-transport: jackrabbit+                      composer-flags: '--prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, imagick'+                      tools: 'composer:v2'+                      phpstan: true+                      lint-container: true+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: weak+                          SYMFONY__PHPCR__TRANSPORT: jackrabbit+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9202++        services:+            mysql:+                image: mysql:5.7+                env:+                    MYSQL_ROOT_PASSWORD: root+                ports:+                    - 3306:3306+                options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5++            jackrabbit:+                image: sulu/jackrabbit:2.18+                env:+                    DATABASE_HOST: mysql+                    DATABASE_PORT: 3306+                    DATABASE_NAME: sulu_test_jackrabbit+                    DATABASE_USER: root+                    DATABASE_PASS: root+                    LOG_LEVEL: WARN+                ports:+                    - 8080:8080++            elasticsearch56:+                image: elasticsearch:5.6+                ports:+                    - 9201:9200+                options: -e="discovery.type=single-node"++            elasticsearch75:+                image: elasticsearch:7.9.3+                ports:+                    - 9202:9200+                options: -e="discovery.type=single-node"++        steps:+            - name: Checkout project+              uses: actions/checkout@v2++            - name: Install and configure PHP+              uses: shivammathur/setup-php@v2+              with:+                  php-version: ${{ matrix.php-version }}+                  extensions: ${{ matrix.php-extensions }}+                  tools: ${{ matrix.tools }}+                  coverage: xdebug++            - name: Get composer cache directory+              id: composer-cache-dir+              run: echo "::set-output name=dir::$(composer config cache-files-dir)"++            - name: Cache dependencies+              uses: actions/cache@v2+              id: composer-cache+              with:+                  path: ${{ steps.composer-cache-dir.outputs.dir }}+                  key: ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}+                  restore-keys: |+                      ${{ runner.os }}-composer-++            - name: Require elasticsearch dependency+              run: composer require --dev elasticsearch/elasticsearch:"^${{ matrix.elasticsearch-version }}" --no-interaction --no-update++            - name: Require phpstan dependency+              if: ${{ matrix.phpstan }}+              run: composer require --dev phpstan/phpstan --no-interaction --no-update++            - name: Install dependencies+              run: |+                  composer validate+                  composer update ${{ matrix.composer-flags }}++            - name: Create database and elasticsearch indices+              run: |+                  - ./Tests/app/console doctrine:database:create+                  - ./Tests/app/console doctrine:schema:update --force+                  - ./Tests/app/console sulu:document:initialize+                  - ./Tests/app/console ongr:es:index:create -m default+                  - ./Tests/app/console ongr:es:index:create -m live+              env: ${{ matrix.env }}++            - name: PHPStan+              if: ${{ matrix.phpstan }}+              run: |+                  bin/adminconsole cache:clear --env dev+                  bin/websiteconsole cache:clear --env dev+                  vendor/bin/phpstan analyze . --level 1 -c phpstan.neon+              env: ${{ matrix.env }}++            - name: Run tests+              run: time vendor/bin/phpunit ${{ matrix.test-flags }}+              env: ${{ matrix.env }}++            - name: Cache ocular runnable

/cc @sulu/core-team

luca-rath

comment created time in 2 days

issue commentdoctrine/orm

PHP 8 compatibility

Yes 2.8, will be released within days

BenMorel

comment created time in 2 days

push eventsulu/SuluArticleBundle

Prokyonn

commit sha 0c2c4519c38bffba4c6c33d3a67bcfcb62d353c2

Add SmartContent template filtering (#529) * Add type filtering * Add BC layer * Add test * Add comment

view details

Johannes Wachter

commit sha b6d2829898b908e36860ed1e60e70b45efc16b34

Merge branch '2.1' of github.com:sulu/SuluArticleBundle into 2.2

view details

push time in 2 days

created tagsulu/SuluArticleBundle

tag2.2.2

Bundle for managing localized content-rich entities like blog-posts in the Sulu content management system

created time in 2 days

release sulu/SuluArticleBundle

2.2.2

released time in 2 days

push eventsulu/SuluArticleBundle

Prokyonn

commit sha 0c2c4519c38bffba4c6c33d3a67bcfcb62d353c2

Add SmartContent template filtering (#529) * Add type filtering * Add BC layer * Add test * Add comment

view details

Johannes Wachter

commit sha b6d2829898b908e36860ed1e60e70b45efc16b34

Merge branch '2.1' of github.com:sulu/SuluArticleBundle into 2.2

view details

push time in 2 days

release sulu/SuluArticleBundle

2.1.4

released time in 2 days

created tagsulu/SuluArticleBundle

tag2.1.4

Bundle for managing localized content-rich entities like blog-posts in the Sulu content management system

created time in 2 days

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false

does anybody know why we dont do this here? 🤔

luca-rath

comment created time in 2 days

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: disabled+                          SYMFONY__PHPCR__TRANSPORT: doctrinedbal+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9201++                    - php-version: '7.4'+                      elasticsearch-version: '7'+                      code-coverage: true+                      test-flags: '--coverage-clover=clover.xml'+                      phpcr-transport: jackrabbit+                      composer-flags: '--prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, imagick'+                      tools: 'composer:v2'+                      phpstan: true+                      lint-container: true+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: weak+                          SYMFONY__PHPCR__TRANSPORT: jackrabbit+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9202++        services:+            mysql:+                image: mysql:5.7+                env:+                    MYSQL_ROOT_PASSWORD: root+                ports:+                    - 3306:3306+                options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5++            jackrabbit:+                image: sulu/jackrabbit:2.18+                env:+                    DATABASE_HOST: mysql+                    DATABASE_PORT: 3306+                    DATABASE_NAME: sulu_test_jackrabbit+                    DATABASE_USER: root+                    DATABASE_PASS: root+                    LOG_LEVEL: WARN+                ports:+                    - 8080:8080++            elasticsearch56:+                image: elasticsearch:5.6+                ports:+                    - 9201:9200+                options: -e="discovery.type=single-node"++            elasticsearch75:+                image: elasticsearch:7.9.3+                ports:+                    - 9202:9200+                options: -e="discovery.type=single-node"++        steps:+            - name: Checkout project+              uses: actions/checkout@v2++            - name: Install and configure PHP+              uses: shivammathur/setup-php@v2+              with:+                  php-version: ${{ matrix.php-version }}+                  extensions: ${{ matrix.php-extensions }}+                  tools: ${{ matrix.tools }}+                  coverage: xdebug++            - name: Get composer cache directory+              id: composer-cache-dir+              run: echo "::set-output name=dir::$(composer config cache-files-dir)"++            - name: Cache dependencies+              uses: actions/cache@v2+              id: composer-cache+              with:+                  path: ${{ steps.composer-cache-dir.outputs.dir }}+                  key: ${{ runner.os }}-composer-${{ hashFiles('composer.lock') }}+                  restore-keys: |+                      ${{ runner.os }}-composer-++            - name: Require elasticsearch dependency+              run: composer require --dev elasticsearch/elasticsearch:"^${{ matrix.elasticsearch-version }}" --no-interaction --no-update++            - name: Require phpstan dependency+              if: ${{ matrix.phpstan }}+              run: composer require --dev phpstan/phpstan --no-interaction --no-update++            - name: Install dependencies+              run: |+                  composer validate+                  composer update ${{ matrix.composer-flags }}++            - name: Create database and elasticsearch indices+              run: |+                  - ./Tests/app/console doctrine:database:create+                  - ./Tests/app/console doctrine:schema:update --force+                  - ./Tests/app/console sulu:document:initialize+                  - ./Tests/app/console ongr:es:index:create -m default+                  - ./Tests/app/console ongr:es:index:create -m live+              env: ${{ matrix.env }}++            - name: PHPStan+              if: ${{ matrix.phpstan }}+              run: |+                  bin/adminconsole cache:clear --env dev+                  bin/websiteconsole cache:clear --env dev+                  vendor/bin/phpstan analyze . --level 1 -c phpstan.neon+              env: ${{ matrix.env }}++            - name: Run tests+              run: time vendor/bin/phpunit ${{ matrix.test-flags }}+              env: ${{ matrix.env }}++            - name: Cache ocular runnable

should we still do this? has anybody looked at these reports in the prior year? 😅

luca-rath

comment created time in 2 days

Pull request review commentsulu/SuluArticleBundle

Run tests with github actions

 jobs:               run: curl "https://cs.symfony.com/download/php-cs-fixer-v2.phar" --output ${{ steps.php-cs-fixer-path.outputs.path }} && chmod +x ${{ steps.php-cs-fixer-path.outputs.path }}             - name: Run php-cs-fixer               run: ./${{ steps.php-cs-fixer-path.outputs.path }} fix --dry-run --diff++    test:+        name: "Run tests with php ${{ matrix.php-version }} (${{ matrix.phpcr-transport }})"+        runs-on: ubuntu-latest++        env:+            SYMFONY__DATABASE__DRIVER: pdo_mysql+            SYMFONY__DATABASE__VERSION: 5.7+            SYMFONY__DATABASE__PORT: 3306+            SYMFONY__DATABASE__HOST: 127.0.0.1+            SYMFONY__DATABASE__USER: root+            SYMFONY__DATABASE__PASSWORD: root++        strategy:+            fail-fast: false+            matrix:+                include:+                    - php-version: '5.6'+                      elasticsearch-version: '5'+                      code-coverage: false+                      test-flags: ''+                      phpcr-transport: doctrinedbal+                      composer-flags: '--prefer-lowest --prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, gd'+                      tools: 'composer:v1'+                      phpstan: false+                      lint-container: false+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: disabled+                          SYMFONY__PHPCR__TRANSPORT: doctrinedbal+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9201++                    - php-version: '7.4'+                      elasticsearch-version: '7'+                      code-coverage: true+                      test-flags: '--coverage-clover=clover.xml'+                      phpcr-transport: jackrabbit+                      composer-flags: '--prefer-dist --no-interaction'+                      php-extensions: 'ctype, iconv, mysql, imagick'+                      tools: 'composer:v2'+                      phpstan: true+                      lint-container: true+                      env:+                          SYMFONY_DEPRECATIONS_HELPER: weak+                          SYMFONY__PHPCR__TRANSPORT: jackrabbit+                          SYMFONY__ELASTICSEARCH__HOST: 127.0.0.1:9202++        services:+            mysql:+                image: mysql:5.7+                env:+                    MYSQL_ROOT_PASSWORD: root+                ports:+                    - 3306:3306+                options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5++            jackrabbit:+                image: sulu/jackrabbit:2.18+                env:+                    DATABASE_HOST: mysql+                    DATABASE_PORT: 3306+                    DATABASE_NAME: sulu_test_jackrabbit+                    DATABASE_USER: root+                    DATABASE_PASS: root+                    LOG_LEVEL: WARN+                ports:+                    - 8080:8080++            elasticsearch56:+                image: elasticsearch:5.6+                ports:+                    - 9201:9200+                options: -e="discovery.type=single-node"

in the demo, we also set a healthcheck 🙂 https://github.com/sulu/sulu-demo/blob/master/.github/workflows/test-application.yml#L23-L30

luca-rath

comment created time in 2 days

PR opened sulu/SuluArticleBundle

Run tests with github actions
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Run tests with github actions

Why?

To move away from travis

+158 -79

0 comment

3 changed files

pr created time in 2 days

issue commentdoctrine/orm

PHP 8 compatibility

Oh, I can see that some work has been done on 2.8.x for PHP 8 compatibility. I think we can expect PHP 8 support in 2.8.0 then?

Tests still fail in the 2.8.x branch though; do you need help in fixing them?

Finally, when can be expect 2.8.0 to be released? Thanks in advance for your insights!

BenMorel

comment created time in 2 days

push eventsulu/SuluArticleBundle

Prokyonn

commit sha 0c2c4519c38bffba4c6c33d3a67bcfcb62d353c2

Add SmartContent template filtering (#529) * Add type filtering * Add BC layer * Add test * Add comment

view details

push time in 2 days

PR merged sulu/SuluArticleBundle

Add SmartContent template filtering
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Adds SmartContent template filtering for articles.

BC Breaks/Deprecations

Describe BC breaks/deprecations here. (remove this section if not needed)

To Do

  • [ ] Add documentation page
+105 -6

0 comment

3 changed files

Prokyonn

pr closed time in 2 days

more