profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/Silverarmor/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

Silverarmor/angular-translate 0

Translating your AngularJS 1.x apps

Silverarmor/github-notification-markups 0

Set of notification pseudo-markups created for GitHub

Silverarmor/lhoraire-web 0

Practical Application for lhoraire-scheduler.

Silverarmor/LSSM-V.4 0

The Official Repository for the LSS Manager V4

push events1as3r/spotify-downloader

Silverarmor

commit sha d4f77b9aedad118cddd23ed198239461efc5de7a

Regenerate Cassettes

view details

push time in a day

push events1as3r/spotify-downloader

Jakub Kot

commit sha 94ac18c2ecfdc2deeb47350ed0ec7e9a87457888

misc improvements (#1392) * misc: removed gathering spotify metadata message * misc: removed debug termination * misc: bump default search threads to 4 for cli * Revert "misc: removed debug termination" This reverts commit 5787beafb28de1f7c152499c5c1c4e1be738a76e. Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>

view details

Silverarmor

commit sha 670240bf8117e6d70922095743383670167b1c8b

Merge branch 'dev' into pr/1397

view details

push time in a day

pull request commentspotDL/spotify-downloader

misc improvements

Thanks @xnetcat - finally merged this one :)

xnetcat

comment created time in a day

push eventspotDL/spotify-downloader

Jakub Kot

commit sha 94ac18c2ecfdc2deeb47350ed0ec7e9a87457888

misc improvements (#1392) * misc: removed gathering spotify metadata message * misc: removed debug termination * misc: bump default search threads to 4 for cli * Revert "misc: removed debug termination" This reverts commit 5787beafb28de1f7c152499c5c1c4e1be738a76e. Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>

view details

push time in a day

PR merged spotDL/spotify-downloader

misc improvements

Title

misc improvements

Description

look at commit messages

Related Issue

image

Motivation and Context

👆

How Has This Been Tested?

wasn't (yet)

Screenshots (if appropriate)

Types of Changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] My code follows the code style of this project
  • [x] My change requires a change to the documentation
  • [x] I have updated the documentation accordingly
  • [x] I have read the CONTRIBUTING document
  • [x] I have read the CORE VALUES document
  • [ ] I have added tests to cover my changes
  • [x] All new and existing tests passed
+3 -13

3 comments

4 changed files

xnetcat

pr closed time in a day

push events1as3r/spotify-downloader

Silverarmor

commit sha 0bb665633e65301510bf5b5e49e42eb58ebe3ce1

gitignore update and update tests for multithread search (#1398) * Add test coverage file to gitignore Also remove old .cache * Change tests to run with 1 search thread

view details

Silverarmor

commit sha bc2476853eea105bfe084fdddbc3732fb32e11c9

Merge branch 'dev' into pr/1397

view details

Silverarmor

commit sha f77cc4ae73ac5ce6967cb383b6b4ec52bedf5624

Merge branch 'dev' of https://github.com/s1as3r/spotify-downloader into pr/1397

view details

push time in a day

PullRequestReviewEvent

push eventxnetcat/spotify-downloader

Silverarmor

commit sha 440f1ac0b45f57ca5213385189b234df328b93fd

Merge pull request #1383 from spotDL/dev * misc: readme improvements (#1380) Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> * Remove unnecessary dependency and add demo to readme (#1382) Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com> Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com>

view details

Silverarmor

commit sha 71c5dcf370e0841cc92868e88e9f2328cd883e90

Merge branch 'master' into dev

view details

Silverarmor

commit sha 65ae4023ac3eb0f488d13caacd9263bd5bce5461

Bump version number to 3.9

view details

Silverarmor

commit sha 0bb665633e65301510bf5b5e49e42eb58ebe3ce1

gitignore update and update tests for multithread search (#1398) * Add test coverage file to gitignore Also remove old .cache * Change tests to run with 1 search thread

view details

Silverarmor

commit sha da84f9456ab10fe619be3ad389a9d5512d2ef1eb

Merge branch 'dev' into pr/1392

view details

push time in a day

delete branch Silverarmor/spotify-downloader

delete branch : update-gitignoroe

delete time in a day

push eventSilverarmor/spotify-downloader

Silverarmor

commit sha 9d7ec7db6d6d76b4d8f3d3a2d5edd377845031ec

Change tests to run with 1 search thread

view details

push time in 2 days

push eventspotDL/bot

Silverarmor

commit sha 6d1e8122eb828bd453c435e0a4459e01b51ae7a4

Add python to version command

view details

push time in 4 days

push eventspotDL/bot

Silverarmor

commit sha abd3e24219e8d0488fe761a58718ba46cdef6021

Lint to flake8 standards Ignoring E501,W605,E303

view details

push time in 6 days

PR opened spotDL/spotify-downloader

Add test coverage file to gitignore

Also remove old .cache

Title

<!--- Provide a general summary of your changes in the Title above -->

Description

<!--- Describe your changes in detail -->

Related Issue

<!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: -->

Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. -->

Screenshots (if appropriate)

Types of Changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [ ] My code follows the code style of this project
  • [ ] My change requires a change to the documentation
  • [ ] I have updated the documentation accordingly
  • [ ] I have read the CONTRIBUTING document
  • [ ] I have read the CORE VALUES document
  • [ ] I have added tests to cover my changes
  • [ ] All new and existing tests passed
+2 -2

0 comment

1 changed file

pr created time in 6 days

push eventSilverarmor/spotify-downloader

Silverarmor

commit sha 916fb33ce16fa340eab0b70ebb743733a0d5359f

Add test coverage file to gitignore Also remove old .cache

view details

push time in 6 days

create barnchSilverarmor/spotify-downloader

branch : update-gitignoroe

created branch time in 6 days

push eventxnetcat/spotify-downloader

Silverarmor

commit sha bd027891eeb38e970b55d4d27fff2c31eae6ce93

Revert "misc: removed debug termination" This reverts commit 5787beafb28de1f7c152499c5c1c4e1be738a76e.

view details

push time in 6 days

pull request commentspotDL/spotify-downloader

Multiple Lyrics Providers

(venv) PS G:\Programming\spotify-downloader> spotdl https://open.spotify.com/track/4EWCNWgDS8707fNSZ1oaA5 https://open.spotify.com/track/2SiXAy7TuUkycRVbbWDEpo     
Fetching Song...
Gathering Spotify Metadata for:
https://open.spotify.com/track/4EWCNWgDS8707fNSZ1oaA5
HTTP Error for GET to https://api.spotify.com/v1/tracks/4EWCNWgDS8707fNSZ1oaA5    
with Params: {'market': None} returned 401 due to The access token expired        

Traceback (most recent call last):
  File "g:\programming\spotify-downloader\venv\lib\site-packages\spotipy\client.py", line 245, in _internal_call
    response.raise_for_status()
  File "g:\programming\spotify-downloader\venv\lib\site-packages\requests\models.py", line 953, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api.spotify.com/v1/tracks/4EWCNWgDS8707fNSZ1oaA5

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "G:\Programming\spotify-downloader\venv\Scripts\spotdl-script.py", line 33, in <module>
    sys.exit(load_entry_point('spotdl', 'console_scripts', 'spotdl')())
  File "g:\programming\spotify-downloader\spotdl\console\__init__.py", line 81, in console_entry_point
    song_list = parse_query(
  File "g:\programming\spotify-downloader\spotdl\parsers\query_parser.py", line 23, in parse_query
    parse_request(
  File "g:\programming\spotify-downloader\spotdl\parsers\query_parser.py", line 74, in parse_request
    song = song_gatherer.from_spotify_url(
  File "g:\programming\spotify-downloader\spotdl\search\song_gatherer.py", line 38, in from_spotify_url
    raw_track_meta, raw_artist_meta, raw_album_meta = metadata_provider.from_url( 
  File "g:\programming\spotify-downloader\spotdl\providers\metadata_provider.py", 
line 11, in from_url
    raw_track_meta = spotify_client.track(spotify_url)
  File "g:\programming\spotify-downloader\venv\lib\site-packages\spotipy\client.py", line 345, in track
    return self._get("tracks/" + trid, market=market)
  File "g:\programming\spotify-downloader\venv\lib\site-packages\spotipy\client.py", line 297, in _get
    return self._internal_call("GET", url, payload, kwargs)
  File "g:\programming\spotify-downloader\venv\lib\site-packages\spotipy\client.py", line 267, in _internal_call
    raise SpotifyException(
spotipy.exceptions.SpotifyException: http status: 401, code:-1 - https://api.spotify.com/v1/tracks/4EWCNWgDS8707fNSZ1oaA5:
 The access token expired, reason: None
(venv) PS G:\Programming\spotify-downloader> spotdl https://open.spotify.com/track/0VjIjW4GlUZAMYd2vXMi3b
Fetching Song...
Gathering Spotify Metadata for:
https://open.spotify.com/track/0VjIjW4GlUZAMYd2vXMi3b
HTTP Error for GET to https://api.spotify.com/v1/tracks/0VjIjW4GlUZAMYd2vXMi3b    
with Params: {'market': None} returned 401 due to The access token expired        

Traceback (most recent call last):
  File "g:\programming\spotify-downloader\venv\lib\site-packages\spotipy\client.py", line 245, in _internal_call
    response.raise_for_status()
  File "g:\programming\spotify-downloader\venv\lib\site-packages\requests\models.py", line 953, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api.spotify.com/v1/tracks/0VjIjW4GlUZAMYd2vXMi3b

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "G:\Programming\spotify-downloader\venv\Scripts\spotdl-script.py", line 33, in <module>
    sys.exit(load_entry_point('spotdl', 'console_scripts', 'spotdl')())
  File "g:\programming\spotify-downloader\spotdl\console\__init__.py", line 81, in console_entry_point
    song_list = parse_query(
  File "g:\programming\spotify-downloader\spotdl\parsers\query_parser.py", line 23, in parse_query
    parse_request(
  File "g:\programming\spotify-downloader\spotdl\parsers\query_parser.py", line 74, in parse_request
    song = song_gatherer.from_spotify_url(
  File "g:\programming\spotify-downloader\spotdl\search\song_gatherer.py", line 38, in from_spotify_url
    raw_track_meta, raw_artist_meta, raw_album_meta = metadata_provider.from_url( 
  File "g:\programming\spotify-downloader\spotdl\providers\metadata_provider.py", 
line 11, in from_url
    raw_track_meta = spotify_client.track(spotify_url)
  File "g:\programming\spotify-downloader\venv\lib\site-packages\spotipy\client.py", line 345, in track
    return self._get("tracks/" + trid, market=market)
  File "g:\programming\spotify-downloader\venv\lib\site-packages\spotipy\client.py", line 297, in _get
    return self._internal_call("GET", url, payload, kwargs)
  File "g:\programming\spotify-downloader\venv\lib\site-packages\spotipy\client.py", line 267, in _internal_call
    raise SpotifyException(
spotipy.exceptions.SpotifyException: http status: 401, code:-1 - https://api.spotify.com/v1/tracks/0VjIjW4GlUZAMYd2vXMi3b:
 The access token expired, reason: None
s1as3r

comment created time in 6 days

pull request commentspotDL/spotify-downloader

misc improvements

If @aklajnert isn't able to help with the pytest issue (see Discord #spotdl-dev-2), might just be better to comment out the assert DownloadManager.download_multiple_songs.call_count == 1 for now.

xnetcat

comment created time in 6 days

pull request commentspotDL/spotify-downloader

misc improvements

actually i've just realised that the debug termination makes it so much nicer to ctrl+c cancel a process and terminal isn't filled with spam. Can you revert 5787bea?

xnetcat

comment created time in 6 days

create barnchSilverarmor/spotify-downloader

branch : searchthreads

created branch time in 6 days

delete branch Silverarmor/spotify-downloader

delete branch : test

delete time in 6 days

delete branch Silverarmor/spotify-downloader

delete branch : default_search_threads

delete time in 6 days

push eventSilverarmor/spotify-downloader

Jakub Kot

commit sha dba2fccbeeac4258b8f0f7c39ffda8e3df486dd5

bugfix: don't add cover if spotify does not provide album cover (#1384)

view details

Yasser Tahiri

commit sha 8bc236289effc79236947f33dc793d1108a56bc7

🪶: Refactor Code Expression (#1390) * 🪶: Refactor Code Expression (#1) * 🪶: Refactor Code Expression * 🪶: Refactor Code Expression * 🪶: Refactor Code Expression * Fix Linting Issue (Based on mypy & Flake8) * Using Black to Reformat Projects ✨(#2) * Revert Comments ✨ (#3) Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com> Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com>

view details

Jakub Kot

commit sha bea748b15fb0dd37797aabe521c5ed78f9e38d67

bugfix: replace rapidfuzz with thefuzz (#1391) * bugfix: replacez rapidfuzz with thefuzz * misc: run ci on python3.10

view details

Silverarmor

commit sha 71c5dcf370e0841cc92868e88e9f2328cd883e90

Merge branch 'master' into dev

view details

Silverarmor

commit sha 65ae4023ac3eb0f488d13caacd9263bd5bce5461

Bump version number to 3.9

view details

Silverarmor

commit sha 368242f3c58de9605cfb4ec6ae671f55ec15b86c

Merge branch 'dev' of https://github.com/spotDL/spotify-downloader into test

view details

push time in 6 days

push eventSilverarmor/spotify-downloader

Silverarmor

commit sha 1e356cf41d07fd4c69df313306e61ed8195a8b09

def 4

view details

push time in 6 days

create barnchSilverarmor/spotify-downloader

branch : test

created branch time in 6 days

create barnchSilverarmor/spotify-downloader

branch : default_search_threads

created branch time in 6 days

push eventSilverarmor/spotify-downloader

Jakub Kot

commit sha dba2fccbeeac4258b8f0f7c39ffda8e3df486dd5

bugfix: don't add cover if spotify does not provide album cover (#1384)

view details

Yasser Tahiri

commit sha 8bc236289effc79236947f33dc793d1108a56bc7

🪶: Refactor Code Expression (#1390) * 🪶: Refactor Code Expression (#1) * 🪶: Refactor Code Expression * 🪶: Refactor Code Expression * 🪶: Refactor Code Expression * Fix Linting Issue (Based on mypy & Flake8) * Using Black to Reformat Projects ✨(#2) * Revert Comments ✨ (#3) Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com> Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com>

view details

Jakub Kot

commit sha bea748b15fb0dd37797aabe521c5ed78f9e38d67

bugfix: replace rapidfuzz with thefuzz (#1391) * bugfix: replacez rapidfuzz with thefuzz * misc: run ci on python3.10

view details

Silverarmor

commit sha 71c5dcf370e0841cc92868e88e9f2328cd883e90

Merge branch 'master' into dev

view details

Silverarmor

commit sha 65ae4023ac3eb0f488d13caacd9263bd5bce5461

Bump version number to 3.9

view details

push time in 6 days

create barnchSilverarmor/spotify-downloader

branch : dev

created branch time in 6 days

push eventSilverarmor/spotify-downloader

Jakub

commit sha fb2eddab9d922f136f7f832bc361c5740aaf4e1e

skip song if it's not available (#1187) Authored by @xnetcat

view details

Peyton Creery

commit sha c3cb8cb15f482fa462a3240194118ae33f133e13

Fix issue with search result duration greater than 24 hours. (#1113) Authored by @phcreery * drop strptime for relative duration * fix regressions: duration AttributeError * better duration parsing * init provider testing and add parse_duration testing

view details

Jakub

commit sha ddda9048364e58d5ffa25c0fb88ebc1fa7b9ce46

always include main artist (#1176) Authored by @xnetcat * always include main artist * Update downloader.py * Apply suggestions from code review Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>

view details

Silverarmor

commit sha e763fa07d0f6963310e66d3a6b574a362da1afa5

Update setup.cfg

view details

Silverarmor

commit sha 5937ac249c8a60428ed0e8216f4794638edc5613

Merge pull request #1194 from spotDL/dev * skip song if it's not available (#1187) Authored by @xnetcat * Fix issue with search result duration greater than 24 hours. (#1113) Authored by @phcreery * always include main artist (#1176) Authored by @xnetcat Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com> Co-authored-by: Jakub <42355410+xnetcat@users.noreply.github.com> Co-authored-by: Peyton Creery <44987569+phcreery@users.noreply.github.com>

view details

Silverarmor

commit sha caabc720cf98dac6041e8ed5efad50e712a9dc4b

Critical fix for CLI usage

view details

Jakub

commit sha c7a71bf352db848123c07a3083ea53f0b32e6e00

added disc number metadata (#1195) * added disc number metadata * Update spotdl/search/songObj.py Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>

view details

Jakub

commit sha df34631c2a08ad592dde9a57759b065cee991778

fixed ffmpeg installation for tests (#1200) Authored by @xnetcat * fixed ffmpeg installation * Update __init__.py * Update setup.cfg

view details

Jakub

commit sha 5478228e57739905581044eb36567aeee64b1e32

skip results without videoId (#1202) Authored by @xnetcat * skip results without videoId * Update provider.py * Update provider.py * flake8

view details

Arbaaz Shafiq

commit sha 47abb0da022ca7cc2ca4c17ae9edff40080f16b6

Add Lyrics Support (#1201) Authored by @s1as3r * Add Lyrics Support * Use PEP-8 conventions * Fix flake8 reported errors * Update tests/cassettes

view details

xnetcat

commit sha ad17764af8088cbf045f144fde40e7ba634f3112

improved songs searching

view details

xnetcat

commit sha cb1e86c67f877fd6049562f50536359740e16b4b

fixed tests

view details

Jakub

commit sha fa6d14ddc8607ea1825dc80a58be0df7746399af

Update provider.py

view details

xnetcat

commit sha d701f72314884201183eebad5e46e925c34d79c7

update cassettes

view details

Silverarmor

commit sha 9d985fd801dec36f83c7141f9a9406eed7171087

improved songs searching (#1199) Authored by @xnetcat * improved songs searching * fixed tests * Update provider.py * update cassettes

view details

Silverarmor

commit sha 1b13805d5a0852a8a92b4c45838195b0f990b68b

Bump Version Number to 3.4.0

view details

Silverarmor

commit sha e314155b2bc25a2b3958dfe9fd2cbc03b30eceb4

@aklajnert's Allow specifying output directory (#1207) @aklajnert's Allow specifying output directory (#1207)

view details

Jakub

commit sha 38d6f7dd260cee6fc24315dfa3ee226c8da507f6

get all artist tracks (#1208) Authored by @xnetcat

view details

Silverarmor

commit sha dd57613573e3c63c2cbf46d179f5f0d66fb076ce

Merge pull request #1204 from spotDL/dev * added disc number metadata (#1195) Authored by @xnetcat * fixed ffmpeg installation for tests (#1200) Authored by @xnetcat * skip results without videoId (#1202) Authored by @xnetcat * Add Lyrics Support (#1201) Authored by @s1as3r * Bump Version Number to 3.4.0 @Silverarmor * @aklajnert's Allow specifying output directory (#1207) Authored by @aklajnert * get all artist tracks (#1208) Authored by @xnetcat Co-authored-by: Jakub <42355410+xnetcat@users.noreply.github.com> Co-authored-by: Arbaaz Shafiq <arbaazshafiq@gmail.com> Co-authored-by: Silverarmor <23619946+Silverarmor@users.noreply.github.com>

view details

Jakub

commit sha 98a819574cd1ff39b000bcc996ff31e125c20fc7

Artist albums fixes (#1212) Authored by @xnetcat * fixed artist tracks * added tox to gitignore * added tests for artist songs for some reason I couldn't create new cassette without recreating the whole cassettes directory. I was getting 401 not authorized when running pytest * Update utils.py

view details

push time in 6 days

Pull request review commentspotDL/spotify-downloader

Multiple Lyrics Providers

+from requests import get+from bs4 import BeautifulSoup+from typing import List+from urllib.parse import quote++user_agent = {+    "User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 Safari/537.36"+}+++def get_lyrics_genius(song_name: str, song_artists: List[str]) -> str:+    """+    `str` `song_name` : name of song+    `list<str>` `song_artists` : list containing name of contributing artists+    RETURNS `str`: Lyrics of the song.+    Gets the lyrics of the song.+    """+    headers = {+        "Authorization": "Bearer alXXDbPZtK1m2RrZ8I4k2Hn8Ahsd0Gh_o076HYvcdlBvmc0ULL1H8Z8xRlew5qaG",+    } | user_agent

Can we not use the merge operator since this was only added in py3.9 (see PEP 584)

s1as3r

comment created time in 6 days