profile
viewpoint
Samy Pessé SamyPesse GitBook Lyon, France https://twitter.com/SamyPesse CTO at @GitbookIO

ianstormtaylor/slate 17700

A completely customizable framework for building rich text editors. (Currently in beta.)

SamyPesse/betty 870

Google Voice with Receptionist abilities, built on top of Twilio

GitbookIO/markup-it 219

JavaScript library to parse and serialize markup content (Markdown and HTML)

GitbookIO/slate-edit-table 93

Slate plugin for table edition

cssinjs/aphrodite-jss 90

Aphrodite-like API on top of JSS.

GitbookIO/slate-edit-list 82

A Slate plugin to handle keyboard events in lists.

GitbookIO/slate-edit-code 42

A Slate plugin for code block editing

GitbookIO/react-rich-diff 38

React component to render rich diff between two documents (Markdown, HTML)

SamyPesse/code2stl 32

The Revolution is coming, 3D code like you’ve never seen it before!

GitbookIO/slate-prism 26

A Slate plugin to highlight code blocks using PrismJS

PR opened GitbookIO/proxies-on-cloudflare

Allow passing "cf" to proxy

This PR allows extending cf when using proxy.

+7 -1

0 comment

2 changed files

pr created time in 3 days

create barnchGitbookIO/proxies-on-cloudflare

branch : proxy-cf-options

created branch time in 3 days

delete branch GitbookIO/markup-it

delete branch : fix/to-markdown-html-tables-newline

delete time in 6 days

push eventGitbookIO/markup-it

Johan Preynat

commit sha e7022671e00449f00ca38ccf344b7090a7432364

Ensure HTML tables in markdown are properly followed by newlines (#154)

view details

push time in 6 days

PR merged GitbookIO/markup-it

Ensure HTML tables in markdown are properly followed by newlines ready for review

When exporting a complex table to markdown, it is written as HTML to preserve formatting.

However, markup-it currently doesn't append newline characters \n\n after the HTML table in the markdown output. This leads to invalid markdown when the table is not the last element of content, for instance:

<table aligns={[null, null]}>
    ...
</table>
<paragraph>Some text</paragraph>

leads to

<table>
  ...
</table>Some text

instead of

<table>
  ...
</table>

Some text

This PR fixes this issue by properly appending newline characters after the HTML table in markdown.

+34 -1

0 comment

3 changed files

jpreynat

pr closed time in 6 days

startedfacebookexperimental/Recoil

started time in 19 days

starteddevelopit/web-worker

started time in 2 months

startedmegahertz/electron-log

started time in 2 months

startedzeit/hazel

started time in 2 months

startedbloomberg/record-tuple-polyfill

started time in 2 months

PR opened firebase/firebase-js-sdk

Fix #2822: consistent write timing between refs and WriteBatch

This PR fixes #2822.

It ensures this._firestore.ensureClientConfigured().write(this._mutations); is being executed in the same event loop as the call of batch.commit().

+3 -1

0 comment

1 changed file

pr created time in 2 months

push eventSamyPesse/firebase-js-sdk

Samy Pessé

commit sha 284f0f574e4e008d105818565ee4ae7428899480

Fix #2822: consistent write timing between refs and WriteBatch

view details

push time in 2 months

issue openedfirebase/firebase-js-sdk

WriteBatch.commit cannot be used in a sync way

When using .set, .update on DocumentReference, we can directly do a .get after without risking invalid data in the "local database".

But since WriteBatch.commit is written as an AsyncFunction, it defers the commit to the "local database" to the next event loop.

I'm not sure wherever the original use case is supported, but it'd be great to have consistency between those methods. I've spent some time debugging a timing issue in my React application with a code like (where the navigate cause a read-sync in and use a suspense firestore cache):

const batch = firestore().batch();
const post = ...
batch.set(...)
batch.commit();  // The changes will no be applied in the local firestore before after the call to navigate.

navigate(`post/${post.id}`);

While it'll work with:

const post ...
firebase.firestore().collection('posts').doc(post.id).set(post)

navigate(`post/${post.id}`);

created time in 2 months

startedsiddharthkp/bundlesize

started time in 2 months

startedFirebaseExtended/reactfire

started time in 3 months

startedjaywcjlove/hotkeys

started time in 3 months

PR opened toba/vsfire

Allow "-" in collection group ID

It looks like Firestore allows the use of "-" in collection names, at least it's working on my application. This PR fixes the schema for the indexes file to support it as well.

+2 -2

0 comment

1 changed file

pr created time in 3 months

push eventSamyPesse/vsfire

Samy Pessé

commit sha 788174622f89d17ead49327fdad83eaf1823b0ba

Allow "-" in collection group ID

view details

push time in 3 months

fork SamyPesse/vsfire

Visual Studio Code extension for syntax highlighting, hover help and code completions with Firestore security rules and index definition files

https://marketplace.visualstudio.com/items?itemName=toba.vsfire

fork in 3 months

startedrsms/inter

started time in 3 months

push eventSamyPesse/qmk_firmware

Samy Pessé

commit sha ed0a8fab3318904e611e374ebf5576971ce2af47

Update README.md

view details

push time in 3 months

push eventSamyPesse/qmk_firmware

Samy Pessé

commit sha ea328022adf1dfe3a4cafe7e9e902a96e1da9e4d

GitBook: [master] 2 pages modified

view details

push time in 3 months

issue commentfirebase/firebase-js-sdk

@firebase/firestore: Firestore (7.9.2): FIRESTORE (7.9.2) INTERNAL ASSERTION FAILED: value must be undefined or Uint8Array

Another solution is to use this jest config: https://jestjs.io/docs/en/configuration#extraglobals-arraystring

  extraGlobals: ['Uint8Array', 'ArrayBuffer']
Gurey

comment created time in 3 months

more