profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/Progi1984/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

Progi1984/DVP 3

Code relatif à mes articles sur Developpez.com

Progi1984/Moebius 2

Purebasic Userlib Creator

Progi1984/mozFxOsStats 2

Mozilla Marketplace Statistics

jf-viguier/PrestaShop 0

My PrestaShop fork

matks/docs 0

PrestaShop technical documentation

matks/PrestaShop 0

PrestaShop offers a free, fully scalable, Open Source e-commerce solution.

Progi1984/autoupgrade 0

Upgrade module for PrestaShop

Progi1984/blockwishlist 0

Adds a block containing the customer's wishlists.

pull request commentPrestaShop/PrestaShop

Fixed modal content when bulk delete combinations

Thanks @florine2623

Progi1984

comment created time in a few seconds

delete branch Progi1984/PrestaShop

delete branch : issue25901

delete time in a few seconds

push eventPrestaShop/PrestaShop

Progi1984

commit sha fad1aefa0e772b266e310a55fd53b7bbf111ed45

Fixed modal content when bulk delete combinations

view details

Progi1984

commit sha 9da71bd5bb16aed675e93026386764c49fcb65ff

Merge pull request #25904 from Progi1984/issue25901 Fixed modal content when bulk delete combinations

view details

push time in a few seconds

PR merged PrestaShop/PrestaShop

Fixed modal content when bulk delete combinations QA ✔️ Bug fix Wording ✔️ 1.7.8.x

<!----------------------------------------------------------------------------- Thank you for contributing to the PrestaShop project!

Please take the time to edit the "Answers" rows below with the necessary information.

Check out our contribution guidelines to find out how to complete it: https://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#pull-requests ------------------------------------------------------------------------------>

Questions Answers
Branch? 1.7.8.x
Description? Fixed modal content when bulk delete combinations
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #25901
How to test? Cf. #25901
Possible impacts? N/A

<!-- Click the form's "Preview" button to make sure the table is functional in GitHub. Thank you! -->

<!-- Reviewable:start -->

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+1 -0

4 comments

1 changed file

Progi1984

pr closed time in a few seconds

push eventProgi1984/PrestaShop

Progi1984

commit sha 13c76eadeaa486fad6a8c067254d03d492729ec2

Added support for WebP

view details

push time in 34 minutes

push eventProgi1984/PrestaShop

Progi1984

commit sha 401d27916ddefbc7e6dda6faf08d67f826035269

Added support for WebP

view details

push time in an hour

push eventProgi1984/PrestaShop

Progi1984

commit sha 4e5b24f795bad4ca4e85a153ceac8124ff763447

Added support for WebP

view details

push time in 2 hours

push eventProgi1984/PrestaShop

Progi1984

commit sha db7a52e61599525d915451249bbff054b3ce3b5f

Added support for WebP

view details

push time in 2 hours

push eventProgi1984/PrestaShop

Progi1984

commit sha af8699ad17bb38ddc10b53545e7d418c05848e5f

Added support for WebP

view details

push time in 2 hours

push eventProgi1984/PrestaShop

Progi1984

commit sha 0ef844e5e49811a051a119364b931273e5d7d25c

PHPStan (Level 1) on classes/

view details

push time in 3 hours

push eventProgi1984/PrestaShop

Progi1984

commit sha 61e957ffa82be834be5fb254e25c7486e2bfb7c1

PHPStan (Level 1) on classes/

view details

push time in 3 hours

push eventProgi1984/PrestaShop

Progi1984

commit sha 1dcf6888db14a43d9eba09e2061f8773a9d19d1a

FrontOffice : Use formatted ecotax price

view details

Progi1984

commit sha fd9683d38c0e0f92f244f950d4456bb3b632d421

Fixed comma in conditional variable for JSON-LD

view details

NeOMakinG

commit sha 111afe181e252058016c8f24637e1d028f806ee9

Fix product list layout on responsive on classic theme

view details

matthieu-rolland

commit sha 35c6885572883e65424c80480f76939249260bc9

rely on context when there is no ShopConstraint specified

view details

matthieu-rolland

commit sha bb71f3c45bb017ee7ab01ce3540e9b05095b9446

not specifying a ShopConstraint is now deprecated

view details

matthieu-rolland

commit sha 4f0654b50ca062390dfaefec203d462c5a4b5a55

build shop constraint if no ShopConstraint is specified

view details

matthieu-rolland

commit sha ab0d4cfadc73f2fc916bf85d6e4f91e4a19b2c6b

small refactor

view details

matthieu-rolland

commit sha 7274cf1f8d085b45429aa9a732f8eb98016389a3

fix integration test issue

view details

Matthieu Rolland

commit sha e052e9853b6c1313677a8543de1730532752ad39

Update src/Adapter/Configuration.php Co-authored-by: Pablo Borowicz <pablo.borowicz@prestashop.com>

view details

Matthieu Rolland

commit sha 215c75f5cfa12a6e3ee6cfe74b80ead1615f7d19

Update tests-legacy/PrestaShopBundle/Utils/DatabaseCreator.php Co-authored-by: Pablo Borowicz <pablo.borowicz@prestashop.com>

view details

Progi1984

commit sha 059a51b440e444c9227320986ec7e4eb58b3c8ec

Removed ecotax in invoice/orderslip PDF if ecotax is disabled

view details

matthieu-rolland

commit sha 14ebbd4d4a40c196ad46758859656c6902420550

check value before instantiating value object

view details

matthieu-rolland

commit sha 2cedcf512355863c3a2b1b1e2aa98e9132231a34

revert

view details

matthieu-rolland

commit sha 2e0d7bec0c58ab1e83fe25f053de0520b6f52cc0

use static methods to get shop constraint

view details

matthieu-rolland

commit sha a4fde89defca3a03cb1bd1cbcd8104ea9398bff5

small refactor

view details

matthieu-rolland

commit sha 5241056417ba03b0793242a432f3fca572e9ce3a

allow zero value

view details

matthieu-rolland

commit sha 9adf34fbdce594eb4e26df4dbdfc651d80b63586

use context

view details

matthieu-rolland

commit sha ee8d75380126d695393d0535ab5f4442be03737d

use shop constraint value instead of context

view details

matthieu-rolland

commit sha b19342bf97ea67768d5cb4035ed09e7d3ec45724

add private getStrictValue

view details

matthieu-rolland

commit sha e783ec9ecd06445dbae4636595aa880694e5c5a0

do not give a default value in all shop strict mode

view details

push time in 3 hours

pull request commentPrestaShop/PrestaShop

Fixed import of macros for infotip use in multistore mode

@florine2623 Fixed

Progi1984

comment created time in 5 hours

push eventProgi1984/PrestaShop

matthieu-rolland

commit sha fb232e7c24ec000ccb454b163c6c17c26125479c

fix broken javascript

view details

Thomas BACCELLI

commit sha 83977178c98e95be1ca6b7393d16a40766feb8c5

Fix wrong template directory

view details

Thomas BACCELLI

commit sha ddded1e18f148124a84a04ca31a535e875d601ce

Fix deprecation

view details

matks

commit sha e423d7ee2cac3b848d41c9e9a67761d04ab00c92

Use AsyncToggleColumnExtension for Customers list

view details

matks

commit sha dda0b566caeea4313d8ca2e9524daa05a0417b2d

Rebase and fix PHP CS

view details

matks

commit sha 1f55fc6b10ae8d6ccba2a074b1253ae6cc5d1d14

Apply feedback review

view details

Mathieu Ferment

commit sha 0338a8a3061acbd5c71932f3506f5cc6f64e18fd

Apply suggestions from code review Co-authored-by: Progi1984 <franck.lefevre@prestashop.com>

view details

matks

commit sha f239d33200c0910a611625d59134038bd4b27726

Fix bad rebase

view details

matks

commit sha 884f621d3c2899c2e1814992495261349f475248

Apply code review feedbacks

view details

Julius Zukauskas

commit sha 248b19797303a08eb45abc27dc9bfb82f79328cb

register not implemented command handler

view details

Julius Zukauskas

commit sha 3b1938e0a18255570cef76938b5f644724fbd7d4

implement EditSpecificPriceHandler

view details

Julius Zukauskas

commit sha 9a7b5386f11156cc61c0bfc0f16d783389f9732c

rename behat feature update_specific_prices -> add_specific_price

view details

Julius Zukauskas

commit sha 6318e934bd6f9fbe2c58282fa540013ebbd6d06e

implement behat test and single test case

view details

Julius Zukauskas

commit sha 443b42a824af93b41c3d9373959355757b02058b

add more behat scenarios and fix bugs

view details

Julius Zukauskas

commit sha 359a8f74fcc47c78b04d6139fca11c73763bc897

add scneario for date ranges & todo

view details

Julius Zukauskas

commit sha 984fa73059627c4397c5cea2fef70a385adc6eb2

use correct SpecificPriceId

view details

Julius Zukauskas

commit sha dafd7f7e8ca521c0fc245ecaf6da55d95efbe432

cs fix

view details

Julius Zukauskas

commit sha aa022705c8308fe1ed13c3792113f58b705607f8

use string value for reduction value

view details

Julius Zukauskas

commit sha 6b21150c3ead7d3f6fe48180aff28e5edcbd8c18

introduce ShopGroupIdInterface

view details

Julius Zukauskas

commit sha e5769ea35e0d8463bf0bcdf439033c8e42ed0ca4

introduce ShopIdInterface

view details

push time in 5 hours

push eventProgi1984/PrestaShop

Progi1984

commit sha 1dcf6888db14a43d9eba09e2061f8773a9d19d1a

FrontOffice : Use formatted ecotax price

view details

Progi1984

commit sha fd9683d38c0e0f92f244f950d4456bb3b632d421

Fixed comma in conditional variable for JSON-LD

view details

NeOMakinG

commit sha 111afe181e252058016c8f24637e1d028f806ee9

Fix product list layout on responsive on classic theme

view details

matthieu-rolland

commit sha 35c6885572883e65424c80480f76939249260bc9

rely on context when there is no ShopConstraint specified

view details

matthieu-rolland

commit sha bb71f3c45bb017ee7ab01ce3540e9b05095b9446

not specifying a ShopConstraint is now deprecated

view details

matthieu-rolland

commit sha 4f0654b50ca062390dfaefec203d462c5a4b5a55

build shop constraint if no ShopConstraint is specified

view details

matthieu-rolland

commit sha ab0d4cfadc73f2fc916bf85d6e4f91e4a19b2c6b

small refactor

view details

matthieu-rolland

commit sha 7274cf1f8d085b45429aa9a732f8eb98016389a3

fix integration test issue

view details

Matthieu Rolland

commit sha e052e9853b6c1313677a8543de1730532752ad39

Update src/Adapter/Configuration.php Co-authored-by: Pablo Borowicz <pablo.borowicz@prestashop.com>

view details

Matthieu Rolland

commit sha 215c75f5cfa12a6e3ee6cfe74b80ead1615f7d19

Update tests-legacy/PrestaShopBundle/Utils/DatabaseCreator.php Co-authored-by: Pablo Borowicz <pablo.borowicz@prestashop.com>

view details

Progi1984

commit sha 059a51b440e444c9227320986ec7e4eb58b3c8ec

Removed ecotax in invoice/orderslip PDF if ecotax is disabled

view details

matthieu-rolland

commit sha 14ebbd4d4a40c196ad46758859656c6902420550

check value before instantiating value object

view details

matthieu-rolland

commit sha 2cedcf512355863c3a2b1b1e2aa98e9132231a34

revert

view details

matthieu-rolland

commit sha 2e0d7bec0c58ab1e83fe25f053de0520b6f52cc0

use static methods to get shop constraint

view details

matthieu-rolland

commit sha a4fde89defca3a03cb1bd1cbcd8104ea9398bff5

small refactor

view details

matthieu-rolland

commit sha 5241056417ba03b0793242a432f3fca572e9ce3a

allow zero value

view details

matthieu-rolland

commit sha 9adf34fbdce594eb4e26df4dbdfc651d80b63586

use context

view details

matthieu-rolland

commit sha ee8d75380126d695393d0535ab5f4442be03737d

use shop constraint value instead of context

view details

matthieu-rolland

commit sha b19342bf97ea67768d5cb4035ed09e7d3ec45724

add private getStrictValue

view details

matthieu-rolland

commit sha e783ec9ecd06445dbae4636595aa880694e5c5a0

do not give a default value in all shop strict mode

view details

push time in 5 hours

PullRequestReviewEvent

Pull request review commentPrestaShop/PrestaShop

Replace Shudrum ArrayFinder usage by Symfony ArrayFinder in PhpParameters

+<?php++return array(+    'parameters' => array(+            'a' => '127.0.0.1',+            'b' => '',+            'c_d' => '1234',
        'a' => '127.0.0.1',
        'b' => '',
        'c_d' => '1234',
matks

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentPrestaShop/PrestaShop

Replace Shudrum ArrayFinder usage by Symfony ArrayFinder in PhpParameters

+<?php+/**+ * Copyright since 2007 PrestaShop SA and Contributors+ * PrestaShop is an International Registered Trademark & Property of PrestaShop SA+ *+ * NOTICE OF LICENSE+ *+ * This source file is subject to the Open Software License (OSL 3.0)+ * that is bundled with this package in the file LICENSE.md.+ * It is also available through the world-wide-web at this URL:+ * https://opensource.org/licenses/OSL-3.0+ * If you did not receive a copy of the license and are unable to+ * obtain it through the world-wide-web, please send an email+ * to license@prestashop.com so we can send you a copy immediately.+ *+ * DISCLAIMER+ *+ * Do not edit or add to this file if you wish to upgrade PrestaShop to newer+ * versions in the future. If you wish to customize PrestaShop for your+ * needs please refer to https://devdocs.prestashop.com/ for more information.+ *+ * @author    PrestaShop SA and Contributors <contact@prestashop.com>+ * @copyright Since 2007 PrestaShop SA and Contributors+ * @license   https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0)+ */++declare(strict_types=1);++namespace Tests\Unit\Adapter\Configuration;++use InvalidArgumentException;+use PHPUnit\Framework\TestCase;+use PrestaShop\PrestaShop\Adapter\Configuration\PhpParameters;++class PhpParametersTest extends TestCase+{+    /** @var string */+    protected $parametersSampleFile;+    /** @var string */+    protected $parametersSampleFileContent;++    protected $sampleParams = [+        'parameters' => [+            'a' => '127.0.0.1',+            'b' => '',+            'c_d' => '1234',+        ],+    ];++    /**+     * {@inheritDoc}+     */+    protected function setUp(): void+    {+        $this->parametersSampleFile = dirname(__DIR__, 2) . '/Resources/config/params.php';+        $this->parametersSampleFileContent = file_get_contents($this->parametersSampleFile);+    }++    protected function tearDown(): void+    {+        // restore parameters sample file content as it can be modified+        file_put_contents($this->parametersSampleFile, $this->parametersSampleFileContent);+    }++    public function testCannotReadInputFile(): void+    {+        $this->expectException(InvalidArgumentException::class);+        $this->expectExceptionMessage('File a is not readable for configuration');++        new PhpParameters('a');+    }++    public function testGetConfiguration(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $this->assertEquals($this->sampleParams, $parameterReader->getConfiguration());+    }++    public function testSetProperties(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $parameterReader->setProperty('a.b.c', 'OSS');+        $parameterReader->setProperty('parameters.b', 'PrestaShop');+        $modifiedParams = $this->sampleParams;+        $modifiedParams['a'] = ['b' => ['c' => 'OSS']];+        $modifiedParams['parameters']['b'] = 'PrestaShop';++        $this->assertEquals($modifiedParams, $parameterReader->getConfiguration());+    }++    public function testSaveConfigurationWithoutModifications(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $result = $parameterReader->saveConfiguration();++        $this->assertTrue(($result));++        $parametersSampleFileContentAfterSave = file_get_contents($this->parametersSampleFile);++        $this->assertParametersPhpFileContentAreEqual(+            $this->parametersSampleFileContent,+            $parametersSampleFileContentAfterSave+        );+    }++    public function testSaveConfigurationWithModifications(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);+        $parameterReader->setProperty('parameters.b', 'PrestaShop');++        $result = $parameterReader->saveConfiguration();++        $this->assertTrue(($result));++        $parametersSampleFileContentModified = file_get_contents(+            dirname(__DIR__, 2) . '/Resources/config/params_modified.php'+        );+        $parametersSampleFileContentAfterSave = file_get_contents($this->parametersSampleFile);++        $this->assertParametersPhpFileContentAreEqual(+            $parametersSampleFileContentModified,+            $parametersSampleFileContentAfterSave+        );+    }++    /**+     * Asserts whether payloads like below are valid, ignoring line breaks and whitespace+     * return array(\n+     *    'parameters' =>\n+     *        array(\n+     *            'a' => '127.0.0.1',\n+     *           'c_d' => '1234',\n
     *            'c_d' => '1234',\n
matks

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentPrestaShop/PrestaShop

Replace Shudrum ArrayFinder usage by Symfony ArrayFinder in PhpParameters

+<?php+/**+ * Copyright since 2007 PrestaShop SA and Contributors+ * PrestaShop is an International Registered Trademark & Property of PrestaShop SA+ *+ * NOTICE OF LICENSE+ *+ * This source file is subject to the Open Software License (OSL 3.0)+ * that is bundled with this package in the file LICENSE.md.+ * It is also available through the world-wide-web at this URL:+ * https://opensource.org/licenses/OSL-3.0+ * If you did not receive a copy of the license and are unable to+ * obtain it through the world-wide-web, please send an email+ * to license@prestashop.com so we can send you a copy immediately.+ *+ * DISCLAIMER+ *+ * Do not edit or add to this file if you wish to upgrade PrestaShop to newer+ * versions in the future. If you wish to customize PrestaShop for your+ * needs please refer to https://devdocs.prestashop.com/ for more information.+ *+ * @author    PrestaShop SA and Contributors <contact@prestashop.com>+ * @copyright Since 2007 PrestaShop SA and Contributors+ * @license   https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0)+ */++declare(strict_types=1);++namespace Tests\Unit\Adapter\Configuration;++use InvalidArgumentException;+use PHPUnit\Framework\TestCase;+use PrestaShop\PrestaShop\Adapter\Configuration\PhpParameters;++class PhpParametersTest extends TestCase+{+    /** @var string */+    protected $parametersSampleFile;+    /** @var string */+    protected $parametersSampleFileContent;++    protected $sampleParams = [+        'parameters' => [+            'a' => '127.0.0.1',+            'b' => '',+            'c_d' => '1234',+        ],+    ];++    /**+     * {@inheritDoc}+     */+    protected function setUp(): void+    {+        $this->parametersSampleFile = dirname(__DIR__, 2) . '/Resources/config/params.php';+        $this->parametersSampleFileContent = file_get_contents($this->parametersSampleFile);+    }++    protected function tearDown(): void+    {+        // restore parameters sample file content as it can be modified+        file_put_contents($this->parametersSampleFile, $this->parametersSampleFileContent);+    }++    public function testCannotReadInputFile(): void+    {+        $this->expectException(InvalidArgumentException::class);+        $this->expectExceptionMessage('File a is not readable for configuration');++        new PhpParameters('a');+    }++    public function testGetConfiguration(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $this->assertEquals($this->sampleParams, $parameterReader->getConfiguration());+    }++    public function testSetProperties(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $parameterReader->setProperty('a.b.c', 'OSS');+        $parameterReader->setProperty('parameters.b', 'PrestaShop');+        $modifiedParams = $this->sampleParams;+        $modifiedParams['a'] = ['b' => ['c' => 'OSS']];+        $modifiedParams['parameters']['b'] = 'PrestaShop';++        $this->assertEquals($modifiedParams, $parameterReader->getConfiguration());+    }++    public function testSaveConfigurationWithoutModifications(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $result = $parameterReader->saveConfiguration();++        $this->assertTrue(($result));++        $parametersSampleFileContentAfterSave = file_get_contents($this->parametersSampleFile);++        $this->assertParametersPhpFileContentAreEqual(+            $this->parametersSampleFileContent,+            $parametersSampleFileContentAfterSave+        );+    }++    public function testSaveConfigurationWithModifications(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);+        $parameterReader->setProperty('parameters.b', 'PrestaShop');++        $result = $parameterReader->saveConfiguration();++        $this->assertTrue(($result));
        $this->assertTrue($result);
matks

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentPrestaShop/PrestaShop

Replace Shudrum ArrayFinder usage by Symfony ArrayFinder in PhpParameters

+<?php+/**+ * Copyright since 2007 PrestaShop SA and Contributors+ * PrestaShop is an International Registered Trademark & Property of PrestaShop SA+ *+ * NOTICE OF LICENSE+ *+ * This source file is subject to the Open Software License (OSL 3.0)+ * that is bundled with this package in the file LICENSE.md.+ * It is also available through the world-wide-web at this URL:+ * https://opensource.org/licenses/OSL-3.0+ * If you did not receive a copy of the license and are unable to+ * obtain it through the world-wide-web, please send an email+ * to license@prestashop.com so we can send you a copy immediately.+ *+ * DISCLAIMER+ *+ * Do not edit or add to this file if you wish to upgrade PrestaShop to newer+ * versions in the future. If you wish to customize PrestaShop for your+ * needs please refer to https://devdocs.prestashop.com/ for more information.+ *+ * @author    PrestaShop SA and Contributors <contact@prestashop.com>+ * @copyright Since 2007 PrestaShop SA and Contributors+ * @license   https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0)+ */++declare(strict_types=1);++namespace Tests\Unit\Adapter\Configuration;++use InvalidArgumentException;+use PHPUnit\Framework\TestCase;+use PrestaShop\PrestaShop\Adapter\Configuration\PhpParameters;++class PhpParametersTest extends TestCase+{+    /** @var string */+    protected $parametersSampleFile;+    /** @var string */+    protected $parametersSampleFileContent;++    protected $sampleParams = [+        'parameters' => [+            'a' => '127.0.0.1',+            'b' => '',+            'c_d' => '1234',+        ],+    ];++    /**+     * {@inheritDoc}+     */+    protected function setUp(): void+    {+        $this->parametersSampleFile = dirname(__DIR__, 2) . '/Resources/config/params.php';+        $this->parametersSampleFileContent = file_get_contents($this->parametersSampleFile);+    }++    protected function tearDown(): void+    {+        // restore parameters sample file content as it can be modified+        file_put_contents($this->parametersSampleFile, $this->parametersSampleFileContent);+    }++    public function testCannotReadInputFile(): void+    {+        $this->expectException(InvalidArgumentException::class);+        $this->expectExceptionMessage('File a is not readable for configuration');++        new PhpParameters('a');+    }++    public function testGetConfiguration(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $this->assertEquals($this->sampleParams, $parameterReader->getConfiguration());+    }++    public function testSetProperties(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $parameterReader->setProperty('a.b.c', 'OSS');+        $parameterReader->setProperty('parameters.b', 'PrestaShop');+        $modifiedParams = $this->sampleParams;+        $modifiedParams['a'] = ['b' => ['c' => 'OSS']];+        $modifiedParams['parameters']['b'] = 'PrestaShop';++        $this->assertEquals($modifiedParams, $parameterReader->getConfiguration());+    }++    public function testSaveConfigurationWithoutModifications(): void+    {+        $parameterReader = new PhpParameters($this->parametersSampleFile);++        $result = $parameterReader->saveConfiguration();++        $this->assertTrue(($result));
        $this->assertTrue($result);
matks

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentPrestaShop/PrestaShop

Replace Shudrum ArrayFinder usage by Symfony ArrayFinder in PhpParameters

     __DIR__.'/controllers',     __DIR__.'/tests',     __DIR__.'/tools/profiling',+])->exclude([+    'Unit/Resources',

It's a bad practice to ignore a full directory.

You should ignore parts of the file : https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-parts-of-a-file

matks

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentPrestaShop/PrestaShop

Replace Shudrum ArrayFinder by Symfony ArrayFinder in Theme

+<?php+/**+ * Copyright since 2007 PrestaShop SA and Contributors+ * PrestaShop is an International Registered Trademark & Property of PrestaShop SA+ *+ * NOTICE OF LICENSE+ *+ * This source file is subject to the Open Software License (OSL 3.0)+ * that is bundled with this package in the file LICENSE.md.+ * It is also available through the world-wide-web at this URL:+ * https://opensource.org/licenses/OSL-3.0+ * If you did not receive a copy of the license and are unable to+ * obtain it through the world-wide-web, please send an email+ * to license@prestashop.com so we can send you a copy immediately.+ *+ * DISCLAIMER+ *+ * Do not edit or add to this file if you wish to upgrade PrestaShop to newer+ * versions in the future. If you wish to customize PrestaShop for your+ * needs please refer to https://devdocs.prestashop.com/ for more information.+ *+ * @author    PrestaShop SA and Contributors <contact@prestashop.com>+ * @copyright Since 2007 PrestaShop SA and Contributors+ * @license   https://opensource.org/licenses/OSL-3.0 Open Software License (OSL 3.0)+ */++declare(strict_types=1);++namespace Tests\Unit\Core\Addon\Theme;++use PHPUnit\Framework\TestCase;+use PrestaShop\PrestaShop\Core\Addon\Theme\Theme;++class ThemeTest extends TestCase+{+    /**+     * @var Theme+     */+    protected $theme;++    public function testGetThemeAttributes(): void+    {+        $theme = new Theme(+            [+                'name' => 'foo',+                'bar' => 'preston',+                'directory' => 'a/',+            ],+            '', '');

Better reading, simply. In the first time, I didn't see that it has two arguments.

matks

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentPrestaShop/PrestaShop

Replace Shudrum ArrayFinder by Symfony ArrayFinder in Theme

 use AbstractAssetManager; use Configuration; use PrestaShop\PrestaShop\Core\Addon\AddonInterface;+use PrestaShop\PrestaShop\Core\Util\ArrayFinder; use PrestaShop\PrestaShop\Core\Util\File\YamlParser;-use Shudrum\Component\ArrayFinder\ArrayFinder;  class Theme implements AddonInterface {+    /**+     * @var ArrayFinder+     */     private $attributes; -    public function __construct(array $attributes)+    /**+     * @param array $attributes Theme attributes+     * @param string $configurationCacheDirectory Default _PS_CACHE_DIR_
     * @param string|null $configurationCacheDirectory Default _PS_CACHE_DIR_
matks

comment created time in 5 hours

PullRequestReviewEvent