profile
viewpoint
遗忘
OmniSharp OmniSharp http://www.omnisharp.net OmniSharp - Cross platform .NET development in the editor of your choice

OmniSharp/omnisharp-vscode 1578

Official C# support for Visual Studio Code (powered by OmniSharp)

OmniSharp/omnisharp-vim 1172

Vim omnicompletion (intellisense) and more for C#

OmniSharp/generator-aspnet 896

yo generator for ASP.NET Core

OmniSharp/omnisharp-roslyn 894

OmniSharp server (HTTP, STDIO) based on Roslyn workspaces

OmniSharp/omnisharp-sublime 543

C# IDE Plugin for Sublime Text 3

OmniSharp/omnisharp-emacs 488

Troll coworkers - use Emacs at work for csharp!

OmniSharp/omnisharp-server 373

HTTP wrapper around NRefactory allowing C# editor plugins to be written in any language.

OmniSharp/omnisharp-atom 327

Omnisharp support for the atom editor

OmniSharp/csharp-language-server-protocol 189

Language Server Protocol in C#

OmniSharp/Kulture 74

Sublime extension for ASP.NET vNext

issue openedOmniSharp/omnisharp-vscode

Wrong syntax highlighting when using `await using`

<!-- To prefill this information:

  1. Open Visual Studio Code
  2. Bring up the command palette (press <kbd>F1</kbd>)
  3. Type CSharp: Report an issue

If the CSharp: Report an issue command doesn't appear, make sure that you have C# extension version 1.17.0 or newer installed. -->

When creating a simple file that uses the await using construct, syntax highlighting is broken below the point where it is used. For example, keywords like public are no longer displayed in dark blue, see screenshot below. This is a simple example code:

using System;
using System.Threading.Tasks;

namespace vscode_await_using_bug
{
    class Program : IAsyncDisposable
    {
        static async Task Main(string[] args)
        {
            await using (var v = new Program())
            {
                Foo();
            }
        }

        public async ValueTask DisposeAsync()
        {
            await Task.Delay(50);
            Console.WriteLine("Byebye");
        }

        public static void Foo()
        {
            Console.WriteLine("Hello World!");
        }
    }
}

Environment data

dotnet --info output: .NET Core SDK (reflecting any global.json): Version: 3.1.301 Commit: 7feb845744

Runtime Environment: OS Name: ubuntu OS Version: 20.04 OS Platform: Linux RID: linux-x64 Base Path: /usr/share/dotnet/sdk/3.1.301/

Host (useful for support): Version: 3.1.5 Commit: 65cd789777

.NET Core SDKs installed: 3.1.301 [/usr/share/dotnet/sdk]

.NET Core runtimes installed: Microsoft.AspNetCore.App 3.1.5 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App] Microsoft.NETCore.App 3.1.5 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs: https://aka.ms/dotnet-download

VS Code version: 1.47.1

C# Extension version: 1.22.1

OmniSharp log

Starting OmniSharp server at 7/16/2020, 5:33:04 PM Target: /home/gidoca/src/vscode-await-using-bug

OmniSharp server started. Path: /home/gidoca/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/run PID: 264088

    Starting OmniSharp on ubuntu 20.4 (x64)
    DotNetPath set to dotnet
    Located 1 MSBuild instance(s)
        1: StandAlone 16.4 - "/home/gidoca/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin"
    MSBUILD_EXE_PATH environment variable set to '/home/gidoca/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin/MSBuild.dll'
    Registered MSBuild instance: StandAlone 16.4 - "/home/gidoca/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin"
        CscToolExe = csc.exe
        MSBuildToolsPath = /home/gidoca/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin
        CscToolPath = /home/gidoca/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin/Roslyn
        BypassFrameworkInstallChecks = true
        MSBuildExtensionsPath = /home/gidoca/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild
    Detecting Cake files in '/home/gidoca/src/vscode-await-using-bug'.
    Could not find any Cake files
    No solution files found in '/home/gidoca/src/vscode-await-using-bug'
    Detecting CSX files in '/home/gidoca/src/vscode-await-using-bug'.
    Could not find any CSX files
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140
    Configuration finished.
    Omnisharp server running using Stdio at location '/home/gidoca/src/vscode-await-using-bug' on host 263959.

Steps to reproduce

  • Create a file named Program.cs with the content above.

Expected behavior

The syntax highlight is the same as synchronous using. image

Actual behavior

The syntax highlighting no longer marks keywords correctly. using is yellow, public and static are light blue. image

created time in 21 minutes

startedOmniSharp/omnisharp-sublime

started time in 2 hours

fork DasCleverle/omnisharp-vim

Vim omnicompletion (intellisense) and more for C#

http://www.omnisharp.net

fork in 2 hours

issue commentOmniSharp/omnisharp-vscode

[question] Razor runtime dependency license

Thank you!

muhammadsammy

comment created time in 3 hours

issue commentOmniSharp/omnisharp-vscode

Some lines don't get formatted

I hope my question fits within this issue.

I have the following example:

public void Test()
{
    string foo         = "bar";
    string foe;
    foe = "bar";
}

The variable declaration of foo does get space ignored with SpacesIgnoreAroundVariableDeclaration: true, but the variable assignment of foe does not. It might not be a declaration per se, but I cannot for the life of me find the right setting to accomplish this.

Rechdan

comment created time in 5 hours

issue commentOmniSharp/omnisharp-roslyn

[LSP] languageserver not working with vim/neovim+lsp plugins

If you're still having the issue with diagnostics not updating, can you verify msbuild is in your path? I can consistently get this error to come back by removing msbuild from my $PATH.

To be clear, the diagnostics update just fine for me - with the exception when I remove the very last error on the file. In those cases I need to restart the LSP.

Shihira

comment created time in 13 hours

issue closedOmniSharp/omnisharp-vscode

Extension not suggesting to use explicit type instead of var

Issue Description

I have a couple of variables declaration using var instead of the explicit type. In Visual Studio, Omnisharp would suggest me to use the explicit type instead and I could make the change automatically by using the keyboard shortcut (Ctrl+.).

This was super useful and I can't figure out how to make it work inside VS Code. I was not able to find any documentation, issues or articles related to this so I'm creating a new issue.

In this specific case I was doing a LINQ group by and I wanted to be able to use the explicit type and then go look at the type definition for IGrouping.

Steps to Reproduce

var myCustomObject = new CustomObject();

Expected Behavior

Suggest the option to use the explicit type when using the code actions keyboard shortcut.

Actual Behavior

Missing suggestion: image image

Environment information

VSCode version: 1.46.1 C# Extension: 1.22.1

<details><summary>Dotnet Information</summary> .NET Core SDK (reflecting any global.json): Version: 3.1.301 Commit: 7feb845744

Runtime Environment: OS Name: Windows OS Version: 10.0.18362 OS Platform: Windows RID: win10-x64 Base Path: C:\Program Files\dotnet\sdk\3.1.301\

Host (useful for support): Version: 3.1.5 Commit: 65cd789777

.NET Core SDKs installed: 3.1.301 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed: Microsoft.AspNetCore.All 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.All 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.App 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.NETCore.App 2.1.19 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.WindowsDesktop.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs: https://aka.ms/dotnet-download </details> <details><summary>Visual Studio Code Extensions</summary>

Extension Author Version
auto-run-command gabrielgrinberg 1.6.0
azure-account ms-vscode 0.8.11
csharp ms-dotnettools 1.22.1
githistory donjayamanne 0.6.5
powershell-preview ms-vscode 2020.6.1
prettier-vscode esbenp 5.1.3
vscode-azurefunctions ms-azuretools 0.23.0
vscode-icons vscode-icons-team 10.1.1
vscode-nuget-package-manager jmrog 1.1.6

</details>

closed time in 14 hours

jffaust

issue commentOmniSharp/omnisharp-vscode

Extension not suggesting to use explicit type instead of var

That's exactly what I was looking for :)

Thanks a lot :)

jffaust

comment created time in 14 hours

delete branch OmniSharp/omnisharp-node-client

delete branch : dependabot/npm_and_yarn/lodash-4.17.13

delete time in 19 hours

PR closed OmniSharp/omnisharp-node-client

Bump lodash from 4.17.4 to 4.17.13 dependencies

Bumps lodash from 4.17.4 to 4.17.13. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+23 -1521

1 comment

1 changed file

dependabot[bot]

pr closed time in 19 hours

pull request commentOmniSharp/omnisharp-node-client

Bump lodash from 4.17.4 to 4.17.13

Superseded by #512.

dependabot[bot]

comment created time in 19 hours

PR opened OmniSharp/omnisharp-node-client

Bump lodash from 4.17.4 to 4.17.19

Bumps lodash from 4.17.4 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.4...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+23 -1521

0 comment

1 changed file

pr created time in 19 hours

issue commentOmniSharp/omnisharp-vscode

Omnisharp not working in VS Code online (code spaces) for standard dotnet web api application.

@hansenms Thanks for reporting this issue. I was able to reproduce it.

From the command line the project restores and builds fine. The design time build seems to be fine because the project loads and errors are reported. But it seems the sdk reference assemblies are not being added properly to the workspace. Will need some additional investigation to determine where the issue lies.

hansenms

comment created time in 20 hours

issue commentOmniSharp/omnisharp-vscode

unable to debug unit test

I don't understand how this is a duplicate.

Issue #3459 is two years old. This was working for me up until a few weeks ago.

mrj001

comment created time in a day

pull request commentOmniSharp/omnisharp-vscode

Update Razor to include various improvments

Thanks @ryanbrandenburg!

ryanbrandenburg

comment created time in a day

push eventOmniSharp/omnisharp-vscode

Ryan Brandenburg

commit sha 93cf3366d1a463023fa8b9c9a176e3b47bbaeaa8

Update contributes

view details

Ryan Brandenburg

commit sha bc597719b408aa6fdbe7c141f0ca99a8d9cd5111

PR feedback

view details

Ryan Brandenburg

commit sha 70416981cabeb3ceac17a6765a4cd900daca2552

Remove duplicate

view details

Ryan Brandenburg

commit sha 107dd7e73751ab37e0257955340a23a8695ded19

Run npm i

view details

Joey Robichaud

commit sha b695724b9114cb1a86ebfc1d9acf2ea8b344430d

Merge pull request #3906 from ryanbrandenburg/rybrande/RazorInsertion Update Razor to include various improvments

view details

push time in a day

PR merged OmniSharp/omnisharp-vscode

Update Razor to include various improvments
+88 -317

2 comments

3 changed files

ryanbrandenburg

pr closed time in a day

pull request commentOmniSharp/omnisharp-vscode

Update Razor to include various improvments

@JoeRobich updated.

ryanbrandenburg

comment created time in a day

issue openedOmniSharp/omnisharp-vscode

Omnisharp not working in VS Code online (code spaces) for standard dotnet web api application.

Issue Description

In VS Code online (codespaces), Omnisharp seems to not work anymore. It doesn't find any of the system libraries, etc:

image

Lot's of error messages like:

The type or namespace name 'System' could not be found (are you missing a using directive or an assembly reference?) [TestApi, TestApi]

Steps to Reproduce

  1. Create a new VS code online (codespaces) instance with the standard image.
  2. Create a new web api with dotnet new webapi
  3. Install C# extensions
  4. Open .cs file and look at the highlighting and errors.

Expected Behavior

Omnisharp and C# extensions should work out of the box.

Actual Behavior

As described above. Highlighting and intellisense does not appear to work.

Logs

OmniSharp log

Starting OmniSharp server at 7/15/2020, 4:14:17 PM Target: /home/codespace/workspace

OmniSharp server started. Path: /home/codespace/.vscode-remote/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/run PID: 1885

    Starting OmniSharp on debian 9.0 (x64)
    DotNetPath set to dotnet
    Located 1 MSBuild instance(s)
        1: StandAlone 16.4 - "/home/codespace/.vscode-remote/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin"
    MSBUILD_EXE_PATH environment variable set to '/home/codespace/.vscode-remote/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin/MSBuild.dll'
    Registered MSBuild instance: StandAlone 16.4 - "/home/codespace/.vscode-remote/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin"
        CscToolExe = csc.exe
        MSBuildToolsPath = /home/codespace/.vscode-remote/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin
        CscToolPath = /home/codespace/.vscode-remote/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin/Roslyn
        BypassFrameworkInstallChecks = true
        MSBuildExtensionsPath = /home/codespace/.vscode-remote/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild
    Detecting Cake files in '/home/codespace/workspace'.
    Could not find any Cake files
    No solution files found in '/home/codespace/workspace'
    Queue project update for '/home/codespace/workspace/TestApi/TestApi.csproj'
    Detecting CSX files in '/home/codespace/workspace'.
    Could not find any CSX files
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
    Loading project: /home/codespace/workspace/TestApi/TestApi.csproj
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140
    Configuration finished.
    Omnisharp server running using Stdio at location '/home/codespace/workspace' on host 1783.
    Successfully loaded project file '/home/codespace/workspace/TestApi/TestApi.csproj'.
    Adding project '/home/codespace/workspace/TestApi/TestApi.csproj'
    Update project: TestApi

C# log

It is empty

Environment information

VSCode version: 1.45.1 C# Extension: 1.22.1

<details><summary>Mono Information</summary> OmniSharp using built-in mono</details> <details><summary>Dotnet Information</summary> .NET Core SDK (reflecting any global.json): Version: 3.1.202 Commit: 6ea70c8dca

Runtime Environment: OS Name: debian OS Version: 9 OS Platform: Linux RID: debian.9-x64 Base Path: /opt/dotnet/sdks/3.1.202/sdk/3.1.202/

Host (useful for support): Version: 3.1.4 Commit: 0c2e69caa6

.NET Core SDKs installed: 1.1.14 [/home/codespace/.dotnet/sdk] 2.1.806 [/home/codespace/.dotnet/sdk] 2.2.402 [/home/codespace/.dotnet/sdk] 3.0.103 [/home/codespace/.dotnet/sdk] 3.1.202 [/home/codespace/.dotnet/sdk]

.NET Core runtimes installed: Microsoft.AspNetCore.All 2.2.7 [/home/codespace/.dotnet/shared/Microsoft.AspNetCore.All] Microsoft.AspNetCore.App 2.2.7 [/home/codespace/.dotnet/shared/Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.0.3 [/home/codespace/.dotnet/shared/Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.4 [/home/codespace/.dotnet/shared/Microsoft.AspNetCore.App] Microsoft.NETCore.App 1.1.13 [/home/codespace/.dotnet/shared/Microsoft.NETCore.App] Microsoft.NETCore.App 2.2.7 [/home/codespace/.dotnet/shared/Microsoft.NETCore.App] Microsoft.NETCore.App 3.0.3 [/home/codespace/.dotnet/shared/Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.4 [/home/codespace/.dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs: https://aka.ms/dotnet-download </details> <details><summary>Visual Studio Code Extensions</summary>

Extension Author Version
csharp ms-dotnettools 1.22.1
vscode-pull-request-github GitHub 0.16.0
vsonline ms-vsonline 1.0.2471

</details>

created time in a day

issue commentOmniSharp/omnisharp-vscode

Support Windows ARM64

Hello, just wanted to bump this, was wondering if this would be coming anytime in the near future. I use a Surface Pro X for developing.

richlander

comment created time in a day

pull request commentOmniSharp/omnisharp-vscode

Update Razor to include various improvments

@ryanbrandenburg I think you need to run npm i after your last change.

npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! 
npm ERR! Invalid: lock file's microsoft.aspnetcore.razor.vscode@https://download.visualstudio.microsoft.com/download/pr/a8595bc4-2076-4272-9d89-e7e3f1c7291d/96243f8fdb1470a808d5a16fd85f8086/microsoft.aspnetcore.razor.vscode-5.0.0-preview.8.20359.1.tgz does not satisfy microsoft.aspnetcore.razor.vscode@https://razorvscodetest.blob.core.windows.net/npm/microsoft.aspnetcore.razor.vscode-5.0.0-preview.8.20359.1.tgz
npm ERR! 
ryanbrandenburg

comment created time in a day

issue commentOmniSharp/omnisharp-sublime

Error talking to localhost:49923/autocomplete

I'm also having this issue. Omnisharp is installed in the sublime package.

setup

C:\Users\gamedev>mono --version
Mono JIT compiler version 6.8.0 (Visual Studio built mono)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
C:\Users\gamedev>msbuild /version
Microsoft (R) Build Engine version 16.5.0-ci for Mono
Copyright (C) Microsoft Corporation. All rights reserved.

16.5.0.16201
C:\Users\gamedev>C:/Users/gamedev/apps/st3/Data/Packages/OmniSharp/prebuilt-omnisharp-roslyn/omnisharp.cmd
Application startup exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at OmniSharp.MSBuild.ProjectSystem..ctor(IOmniSharpEnvironment environment, OmniSharpWorkspace workspace, IMSBuildLocator msbuildLocator, IDotNetCliService dotNetCliService, SdksPathResolver sdksPathResolver, MetadataFileReferenceCache metadataFileReferenceCache, IEventEmitter eventEmitter, IFileSystemWatcher fileSystemWatcher, FileSystemHelper fileSystemHelper, ILoggerFactory loggerFactory, IEnumerable`1 eventSinks)
(long traceback)
Nishit-Dua

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

@vuciv I don't think it can, with the stdio server.

I've just done it with the HTTP server successfully though. Note that it takes a little while for the server to warm up, and most requests will time out during the warm up period.

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

@nickspoons Pretty much the exact same result. Maybe cygwin just can't communicate with the server :|

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

@vuciv instead of this:

let g:OmniSharp_server_path = 'C:\cygwin64\home\jf\.omnisharp\OmniSharp.exe'

Try this:

let g:OmniSharp_server_install = '/home/jf/.omnisharp'

This should have a similar effect, except it will let you re-install to this location (if you set g:OmniSharp_server_path, OmniSharp-vim won't allow you to overwrite that location with a fresh :OmniSharpInstall).

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

@vuciv you'll need to reinstall the server, since the HTTP server is a different binary

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Omnisharp dies when connecting to LiveShare session

Hmm @baronmog are you saying that you get no C# experience even in C# files? Or is it just the Razor experience that dies?

baronmog

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Hm, now I get the "No Pattern Found" error when I attempted to see what is going on in the log. Similar to the issue in @ #591

Here is my log output

2020-07-14 19:56:43,445 ERROR Could not connect to OmniSharp server: http://localhost:55167/checkalivestatus Traceback (most recent call last): File "/home/fonseca/.vim/plugged/omni:OmniSharpOpenLogsharp-vim/python/omnisharp/util.py", line 220, in doRequest response = opener.open(req, body, timeout) File "/usr/lib/python2.7/urllib2.py", line 429, in open response = self._open(req, data) File "/usr/lib/python2.7/urllib2.py", line 447, in _open '_open', req) File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain result = func(*args) File "/usr/lib/python2.7/urllib2.py", line 1228, in http_open return self.do_open(httplib.HTTPConnection, req) File "/usr/lib/python2.7/urllib2.py", line 1198, in do_open raise URLError(err) URLError: <urlopen error timed out> 2020-07-14 19:56:50,020 ERROR Could not connect to OmniSharp server: http://localhost:55167/checkalivestatus Traceback (most recent call last): File "/home/fonseca/.vim/plugged/omnisharp-vim/python/omnisharp/util.py", line 220, in doRequest response = opener.open(req, body, timeout) File "/usr/lib/python2.7/urllib2.py", line 429, in open response = self._open(req, data) File "/usr/lib/python2.7/urllib2.py", line 447, in _open '_open', req) File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain result = func(*args) File "/usr/lib/python2.7/urllib2.py", line 1228, in http_open return self.do_open(httplib.HTTPConnection, req) File "/usr/lib/python2.7/urllib2.py", line 1198, in do_open raise URLError(err) URLError: <urlopen error timed out> 2020-07-14 19:57:02,293 ERROR Could not connect to OmniSharp server: http://localhost:55167/checkalivestatus Traceback (most recent call last): File "/home/fonseca/.vim/plugged/omnisharp-vim/python/omnisharp/util.py", line 220, in doRequest response = opener.open(req, body, timeout) File "/usr/lib/python2.7/urllib2.py", line 429, in open response = self._open(req, data) File "/usr/lib/python2.7/urllib2.py", line 447, in _open '_open', req) File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain result = func(*args) File "/usr/lib/python2.7/urllib2.py", line 1228, in http_open return self.do_open(httplib.HTTPConnection, req) File "/usr/lib/python2.7/urllib2.py", line 1198, in do_open raise URLError(err) URLError: <urlopen error timed out> 2020-07-14 19:57:02,697 ERROR Could not connect to OmniSharp server: http://localhost:55167/checkalivestatus Traceback (most recent call last): File "/home/fonseca/.vim/plugged/omnisharp-vim/python/omnisharp/util.py", line 220, in doRequest response = opener.open(req, body, timeout) File "/usr/lib/python2.7/urllib2.py", line 429, in open

vuciv

comment created time in 2 days

IssuesEvent

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Oops, I didn't mean to close this... Sorry.

vuciv

comment created time in 2 days

issue closedOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Error and details"

Failed to install the OmniSharp-Roslyn server

Error: failed to download the server, possibly a network issue

The full error log can be found in the file: /home/jf/.vim/plugged/omnisharp-vim/log/install.log

Could not run command: /cygdrive/c/Users/jf/AppData/Local/omnisharp-vim/omnisharp-roslyn/OmniSharp.exe -s \home\jf\development\project\project.sln -e utf-8

channel 0 closed: 'executing job failed: No such file or directory'

Log file:

`VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar 30 2020 21:58:19), Included patches: 1-486 OmniSharp server started.

Path: /cygdrive/c/Users/jf/AppData/Local/omnisharp-vim/omnisharp-roslyn/OmniSharp.exe

Target: /home/jf/development/project/project.sln PID: 591 `

Can anyone help?

closed time in 2 days

vuciv

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

@nickspoons Thanks for all of your inputs.

The issue with installing the server seemed to be with $HOME. I changed location = "$HOME/.omnisharp" to location="C:/cygwin64/home/<username>/.omnisharp"

I also added let g:OmniSharp_server_path = 'C:\cygwin64\home\jf\.omnisharp\OmniSharp.exe' to my .vimrc

Now, what you are describing @nickspoons is happening. The server starts, but nothing else happens. There are never any popups or autocomplete suggestions. I have tried going back to the HTTP server, but there are still no popups.

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

I have tried installing cygwin to have a play with this. I just used the default home location, and OmniSharp-vim was able to install the server with no problems - it was installed to default the Windows location C:\Users\<username>\AppData\Local\omnisharp-vim\omnisharp-roslyn.

However ... OmniSharp-vim doesn't appear to work. It starts the server, sends and receives messages over stdio, but the server doesn't appear to be receiving more than the first request from the client. This may simply be a limitation of cygwin's ability to communicate over stdio.

@vuvic verfication of this from you would be very helpful. If you get the server installed but still don't get any feedback from the server, we'll need to assume that the stdio server simply doesn't work in cygwin. In which case your options will be either to fall back to the HTTP server with let g:OmniSharp_server_stdio = 0, or to use a different environment like WSL.

vuciv

comment created time in 2 days

issue closedOmniSharp/omnisharp-vscode

Some lines don't get formatted

Here is the code, I left a comment where the formatter is not working:

using System;
using System.Net;
using System.Net.Sockets;

namespace ProjectNamespace {
	public class Server {
		public string ip { get; private set; } = null;

		private Socket socket { get; set; } = null;

		public Server ( string ip ) {
			this.ip = ip;

			if ( IPAddress.TryParse ( ip , out IPAddress ipad ) ) {
				IPEndPoint ipep=new IPEndPoint(ipad,8281); // not formatted

				this.socket = new Socket ( AddressFamily.InterNetwork , SocketType.Stream , ProtocolType.Tcp );
				this.socket.Bind ( ipep );
				this.socket.Listen ( 1000 );
			}
		}

		private void waitConnection ( ) {
			this.socket.BeginAccept ( this.onConnection , null );
		}

		private void onConnection ( IAsyncResult ar ) {
			try {
				Socket socket=this.socket.EndAccept(ar); // not formatted
			}
			catch { }
			finally { this.waitConnection ( ); }
		}
	}
}

And here is my omnisharp.json:

{
	"FormattingOptions": {
		"EnableEditorConfigSupport": true,
		"IndentationSize": 3,
		"IndentBlock": true,
		"IndentBraces": false,
		"IndentSwitchCaseSection": true,
		"IndentSwitchCaseSectionWhenBlock": true,
		"IndentSwitchSection": true,
		"LabelPositioning": "oneLess",
		"NewLine": "\n",
		"NewLineForCatch": true,
		"NewLineForClausesInQuery": false,
		"NewLineForElse": true,
		"NewLineForFinally": true,
		"NewLineForMembersInAnonymousTypes": false,
		"NewLineForMembersInObjectInit": false,
		"NewLinesForBracesInAccessors": false,
		"NewLinesForBracesInAnonymousMethods": false,
		"NewLinesForBracesInAnonymousTypes": false,
		"NewLinesForBracesInControlBlocks": false,
		"NewLinesForBracesInLambdaExpressionBody": false,
		"NewLinesForBracesInMethods": false,
		"NewLinesForBracesInObjectCollectionArrayInitializers": false,
		"NewLinesForBracesInProperties": false,
		"NewLinesForBracesInTypes": false,
		"SpaceAfterCast": true,
		"SpaceAfterComma": true,
		"SpaceAfterColonInBaseTypeDeclaration": true,
		"SpaceAfterControlFlowStatementKeyword": true,
		"SpaceAfterDot": false,
		"SpaceAfterMethodCallName": true,
		"SpaceAfterSemicolonsInForStatement": true,
		"SpaceBeforeColonInBaseTypeDeclaration": true,
		"SpaceBeforeComma": true,
		"SpaceBeforeDot": false,
		"SpaceBeforeOpenSquareBracket": true,
		"SpaceBeforeSemicolonsInForStatement": true,
		"SpaceBetweenEmptyMethodCallParentheses": true,
		"SpaceBetweenEmptyMethodDeclarationParentheses": true,
		"SpaceBetweenEmptySquareBrackets": false,
		"SpacesIgnoreAroundVariableDeclaration": true,
		"SpaceWithinCastParentheses": true,
		"SpaceWithinExpressionParentheses": true,
		"SpaceWithinMethodCallParentheses": true,
		"SpaceWithinMethodDeclarationParenthesis": true,
		"SpaceWithinOtherParentheses": true,
		"SpaceWithinSquareBrackets": true,
		"SpacingAfterMethodDeclarationName": true,
		"SpacingAroundBinaryOperator": "single",
		"TabSize": 3,
		"UseTabs": true,
		"WrappingKeepStatementsOnSingleLine": true,
		"WrappingPreserveSingleLine": true
	}
}

closed time in 2 days

Rechdan

issue commentOmniSharp/omnisharp-vscode

Some lines don't get formatted

Closing as answered

Rechdan

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

[question] Razor runtime dependency license

Closing as per the link to the license

muhammadsammy

comment created time in 2 days

issue closedOmniSharp/omnisharp-vscode

[question] Razor runtime dependency license

Hello! Could you please clarify the license of the "Razor" runtime dependency of the extension? Thank you!

closed time in 2 days

muhammadsammy

issue closedOmniSharp/omnisharp-vscode

Debugging doesn't work, error: Error processing launch options at field: program.

Issue Description

Tests debugging doesn't work.

Steps to Reproduce

Repro repository: https://github.com/vchirikov/omnisharp_vscode_repro

Click on Debug test codelens link on UnitTest1.Test1

Expected Behavior

Debugging works

Actual Behavior

I got image

Debugging doesn't work

Logs

OmniSharp log

<details>Starting OmniSharp server at 10.07.2020, 14:28:26 Target: c:\code\vchirikov\omnisharp-vscode-repro

OmniSharp server started. Path: c:\Users\verysimplenick.vscode\extensions\ms-dotnettools.csharp-1.22.1.omnisharp\1.35.3\OmniSharp.exe PID: 4000

    Starting OmniSharp on Windows 6.2.9200.0 (x64)
    DotNetPath set to dotnet
    Located 2 MSBuild instance(s)
        1: Visual Studio Community 2019 16.7.30218.91 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin"
        2: StandAlone 16.4 - "c:\Users\verysimplenick\.vscode\extensions\ms-dotnettools.csharp-1.22.1\.omnisharp\1.35.3\.msbuild\Current\Bin"
    Registered MSBuild instance: Visual Studio Community 2019 16.7.30218.91 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Current\Bin"
    Detecting Cake files in 'c:\code\vchirikov\omnisharp-vscode-repro'.
    Could not find any Cake files
    No solution files found in 'c:\code\vchirikov\omnisharp-vscode-repro'
    Queue project update for 'c:\code\vchirikov\omnisharp-vscode-repro\omnisharp-vscode-repro.csproj'
    Detecting CSX files in 'c:\code\vchirikov\omnisharp-vscode-repro'.
    Could not find any CSX files
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
    Loading project: c:\code\vchirikov\omnisharp-vscode-repro\omnisharp-vscode-repro.csproj
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110
    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140
    Configuration finished.
    Omnisharp server running using Stdio at location 'c:\code\vchirikov\omnisharp-vscode-repro' on host 19368.
    Successfully loaded project file 'c:\code\vchirikov\omnisharp-vscode-repro\omnisharp-vscode-repro.csproj'.
    Adding project 'c:\code\vchirikov\omnisharp-vscode-repro\omnisharp-vscode-repro.csproj'
    Update project: omnisharp-vscode-repro
    Solution initialized -> queue all documents for code analysis. Initial document count: 4.
    read: {"MessageType":"TestSession.Connected","Payload":null}
    read: {"MessageType":"ProtocolVersion","Payload":1}
    Debug session started.
    Debug session ended.</details>

C# log

<details>-> (C) {"command":"initialize","arguments":{"clientID":"vscode","clientName":"Visual Studio Code","adapterID":"coreclr","pathFormat":"path","linesStartAt1":true,"columnsStartAt1":true,"supportsVariableType":true,"supportsVariablePaging":true,"supportsRunInTerminalRequest":true,"locale":"en-us","supportsProgressReporting":true},"type":"request","seq":1} -> (C) {"command":"launch","arguments":{"logging":{"engineLogging":false},"type":"coreclr","name":".NET Test Launch","request":"launch","debuggerEventsPipeName":"\\.\pipe\Microsoft.VSCode.CSharpExt.TestDebugEvents-19368","program":null,"args":null,"cwd":"C:\code\vchirikov\omnisharp-vscode-repro","internalConsoleOptions":"openOnSessionStart","__sessionId":"29b9572b-dc2b-4f38-88a6-3b05cf5b4de0"},"type":"request","seq":2} <- (E) {"seq":3,"type":"event","event":"output","body":{"category":"telemetry","output":"VS/Diagnostics/Debugger/vsdbg/CommandFailed","data":{"VS.Diagnostics.Debugger.vsdbg.OSFamily":"Windows","VS.Diagnostics.Debugger.vsdbg.Version":"16.6.20415.1 commit:0184bb70e1ed40656c0dfa53125805036207007b","VS.Diagnostics.Debugger.vsdbg.WindowsVersion":"10.0.19041","VS.Diagnostics.Debugger.vsdbg.Command":"Launch","VS.Diagnostics.Debugger.vsdbg.ErrorCode":1006,"VS.Diagnostics.Debugger.vsdbg.AdditionalData":"program","VS.Diagnostics.Debugger.vsdbg.AdapterId":"coreclr"}}} <- (R) {"seq":4,"type":"response","request_seq":2,"success":false,"command":"launch","message":"Error processing launch options at field: program"}</details>

Environment information

VSCode version: 1.46.1 C# Extension: 1.22.1

<details><summary>Dotnet Information</summary> .NET SDK (reflecting any global.json): Version: 5.0.100-preview.6.20318.15 Commit: 4356580024

Runtime Environment: OS Name: Windows OS Version: 10.0.19041 OS Platform: Windows RID: win10-x64 Base Path: C:\Program Files\dotnet\sdk\5.0.100-preview.6.20318.15\

Host (useful for support): Version: 5.0.0-preview.6.20305.6 Commit: 4ba9ecaabd

.NET SDKs installed: 3.1.101 [C:\Program Files\dotnet\sdk] 3.1.201 [C:\Program Files\dotnet\sdk] 3.1.301 [C:\Program Files\dotnet\sdk] 3.1.400-preview-015151 [C:\Program Files\dotnet\sdk] 3.1.400-preview-015178 [C:\Program Files\dotnet\sdk] 5.0.100-preview.6.20318.15 [C:\Program Files\dotnet\sdk]

.NET runtimes installed: Microsoft.AspNetCore.All 2.1.16 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.All 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All] Microsoft.AspNetCore.App 2.1.16 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 5.0.0-preview.6.20312.15 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App] Microsoft.NETCore.App 2.1.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 2.2.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 5.0.0-fork.vchirikov [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.NETCore.App 5.0.0-preview.6.20305.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App] Microsoft.WindowsDesktop.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 3.0.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 3.1.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 3.1.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 3.1.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 3.1.5 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App] Microsoft.WindowsDesktop.App 5.0.0-preview.6.20308.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET runtimes or SDKs: https://aka.ms/dotnet-download </details> <details><summary>Visual Studio Code Extensions</summary>

Extension Author Version
aspnet-helper schneiderpat 0.6.4
auto-close-tag formulahendry 0.5.8
auto-rename-tag formulahendry 0.1.4
blazor-snippet-pack adrianwilczynski 2.6.1
blazorsnippets ScottSauber 1.3.0
bracket-pair-colorizer CoenraadS 1.0.61
classynaming reflectiondm 1.2.0
code-settings-sync Shan 3.4.3
code-spell-checker streetsidesoftware 1.9.0
code-spell-checker-russian streetsidesoftware 0.2.4
csharp ms-dotnettools 1.22.1
csharp-grammar-extended dannymcgee 1.1.1
csharp2ts rafaelsalguero 0.0.24
csharpextensions jchannon 1.3.1
csharpfixformat Leopotam 0.0.84
dark-plus-syntax dunstontc 0.0.167
debugger-for-edge msjsdiag 1.0.15
docker-explorer formulahendry 0.1.7
docomment k--kato 0.1.13
dotnet-test-explorer formulahendry 0.7.3
EditorConfig EditorConfig 0.15.1
embrace mycelo 1.0.0
excel-to-markdown-table csholmq 1.2.2
git-project-manager felipecaputo 1.7.1
githistory donjayamanne 0.6.5
gitlens eamodio 10.2.2
hexeditor ms-vscode 1.1.0
html-css-class-completion Zignd 1.19.0
ilspy-vscode icsharpcode 0.8.0
js-debug-nightly ms-vscode 2020.7.917
linecount yycalm 0.1.7
macros geddski 1.2.1
markdown-all-in-one yzhang 3.1.0
markdown-mermaid bierner 1.5.1
markdown-table-prettify darkriszty 2.5.0
mermaid-markdown-syntax-highlighting bpruitt-goddard 1.0.3
msbuild-project-tools tintoy 0.3.8
namespace adrianwilczynski 1.1.2
nuget-reverse-package-search jesschadwick 0.1.68
path-intellisense christian-kohler 2.2.1
powershell-preview ms-vscode 2020.6.1
prettier-vscode esbenp 5.1.3
quicktype quicktype 12.0.46
rainbow-csv mechatroner 1.7.0
razor-plus austincummings 0.1.4
remote-wsl ms-vscode-remote 0.44.4
supersharp craigthomas 0.1.4
vscode-commitizen KnisterPeter 0.9.2
vscode-custom-css be5invis 3.0.10
vscode-docker ms-azuretools 1.3.1
vscode-drawio hediet 0.7.2
vscode-extensions-pack-builder mrluje 0.1.4
vscode-markdownlint DavidAnson 0.36.1
vscode-mscgen mscgenjs 1.2.0
vscode-nuget-package-manager jmrog 1.1.6
vscode-paste-image mushan 1.0.4
vscode-pull-request-github GitHub 0.17.0
vscode-scss mrmlnc 0.9.0
vscode-text-tables RomanPeshkov 0.1.5
vscode-wsl-workspacefolder lfurzewaddock 1.1.2
xml DotJoshJohnson 2.5.0
yandex-translate airstep 1.0.7

</details>

closed time in 2 days

vchirikov

issue commentOmniSharp/omnisharp-vscode

Debugging doesn't work, error: Error processing launch options at field: program.

Yep, duplicate of https://github.com/OmniSharp/omnisharp-vscode/issues/3459 - looks like it's related to the custom output path

vchirikov

comment created time in 2 days

issue closedOmniSharp/omnisharp-vscode

fix his

Please paste the o.NET Core SDK (reflecting any global.json): Version: 3.0.100-preview6-012103 Commit: d0d02f6552

Runtime Environment: OS Name: Mac OS X OS Version: 10.13 OS Platform: Darwin RID: osx.10.13-x64 Base Path: /usr/local/share/dotnet/sdk/3.0.100-preview6-012103/

Host (useful for support): Version: 3.0.0-preview6-27728-04 Commit: b2f8fc281d

.NET Core SDKs installed: 2.1.505 [/usr/local/share/dotnet/sdk] 3.0.100-preview6-012103 [/usr/local/share/dotnet/sdk]

.NET Core runtimes installed: Microsoft.AspNetCore.All 2.1.9 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.All] Microsoft.AspNetCore.App 2.1.9 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App] Microsoft.AspNetCore.App 3.0.0-preview6-19278-02 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App] Microsoft.NETCore.App 2.1.9 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App] Microsoft.NETCore.App 3.0.0-preview6-27728-04 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs: https://aka.ms/dotnet-downloadutput from your clipboard

closed time in 2 days

camsdono

issue commentOmniSharp/omnisharp-vscode

Extension not suggesting to use explicit type instead of var

This is driven from a .editorconfig where conventions for var vs. explicit types are configured. Roslyn uses that to determine when to suggest style changes. Is .editorconfig in use for your codebase? image

jffaust

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Keep getting: [ERROR] Error: spawn cmd ENOENT despite updating system path

@QuecisJoshua Does this still reproduce for you? Generally we wouldn't recommending changing your PATH but that should be unrelated. Are there any logs that could be shared?

QuecisJoshua

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Omnisharp server not starting

@taunon it looks like you have a beta version of omnisharp set. If you go to the omnisharp.path setting, can you set this to the default and check if this reproduces for your solution?

taunon

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Omnisharp dies when connecting to LiveShare session

cc @NTaylorMullen looks like the stack trace is from the razor language server

baronmog

comment created time in 2 days

issue closedOmniSharp/omnisharp-vscode

Possible wrong color coding for nested function return type

To be honest I'm not sure this is the right place to post this issue.

Anyway I think this is wrong (more easy if I attach a screenshot): colorcoding-nestedreturn

Regards, Giacomo S. S.

closed time in 2 days

gsscoder

issue commentOmniSharp/omnisharp-vscode

Possible wrong color coding for nested function return type

Closing out - this is ultimately controlled at the VSCode platform level where each theme needs to opt in to semantic colorization.

gsscoder

comment created time in 2 days

issue openedOmniSharp/csharp-language-server-protocol

Consider adding a ToString() or a DebuggerDisplay for Position and Range types

Debugging is extremely painful with having to expand every single Position and Range to look at its Start and End properties. Given these types form the basis for almost every LSP request, having this would save countless headaches and time.

created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

So it error is this:

But for whatever reason when (or even before) it was passed to Curl, it expanded jf to JerseyFonseca

@vuciv are you using a symlink for your home directory? Or is this a cygwin thing?

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

That part will now be overridden by the -W flag anyway, as g:OmniSharp_translate_cygwin_wsl is always 1 in cygwin:

https://github.com/OmniSharp/omnisharp-vim/blob/38db559fb8273c42464d26aeb73ba6cca3b6e3ed/installer/omnisharp-manager.sh#L108-L111

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Oh so it does

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Honestly I wasn't sure, as it's been a while, but it seems that the script automatically detects Cygwin and installs the Windows version of the server.

https://github.com/OmniSharp/omnisharp-vim/blob/38db559fb8273c42464d26aeb73ba6cca3b6e3ed/installer/omnisharp-manager.sh#L81-L89

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

I believe the Bash script is supposed to be used by Cygwin rather than the PowerShell script.

Really? We've had this in the README for a long time:

The automatic installation script for cygwin downloads the Windows OmniSharp-roslyn release.

And it must have been doing that using the powershell script, right? I only just added the -W flag to the bash script a few days ago.

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

seems to be using the bash install script though, instead of the powershell script, which (I think) is what normally gets used by cygwin.

@nickspoons, yes, I believe the Bash script is supposed to be used by Cygwin rather than the PowerShell script.

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

I've done some experimenting and have managed worked out why the server download was failing, but I don't know how to fix it, or what is causing it.

OmniSharp-Vim told the installer to install to this location:

/cygdrive/c/Users/jf/AppData/Local/omnisharp-vim/omnisharp-roslyn

But for whatever reason when (or even before) it was passed to Curl, it expanded jf to JerseyFonseca:

/cygdrive/c/Users/JerseyFonseca/AppData/Local/omnisharp-vim/omnisharp-roslyn/

But that path didn't exist (because the installer created the first path), so the download failed.

We can add the --create-dirs option to Curl, to create the missing directories, but the problem is that OmniSharp-Vim will be looking in the wrong directory.

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

/cygdrive/c/Users/jf/AppData/Local/omnisharp-vim/omnisharp-roslyn/OmniSharp.exe -s \home\jf\development\project\project.sln -e utf-8

This is a very confusing line. This is the cygwin path to the server, but a weird hybrid path to your .sln, with back slashes but no C:\

vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Hmm. I made a couple of changes lately to allow installing the Windows server from wsl, but I don't think the cygwin part changed. Your system seems to be using the bash install script though, instead of the powershell script, which (I think) is what normally gets used by cygwin.

What is the output of echo has('win32') in cygwin? (I used to know this but it's been a long time since I used that environment)

vuciv

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Update Razor to include various improvments

     "workspaceContains:**/*.cake"   ],   "contributes": {+    "breakpoints": [

And merged. We now contribute breakpoints.

ryanbrandenburg

comment created time in 2 days

PR merged OmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory Debugger

Fixes https://github.com/OmniSharp/omnisharp-vscode/issues/3512

  • Removes the "csharp.coreclrAdapterExecutableCommand" & "csharp.clrAdapterExecutableCommand"
  • Registers a DebugAdapterExecutableFactory with the logic from the getAdapterExecutionCommand method.

cc: @gregg-miskelly, @WardenGnaw

+538 -127

0 comment

4 changed files

JoeRobich

pr closed time in 2 days

push eventOmniSharp/omnisharp-vscode

Joey Robichaud

commit sha 86ddffcd47977189665990973badf9983955a0b7

Run npm audit fix

view details

Joey Robichaud

commit sha 7b8778e87d373f325ca8529c3c0cace7ee51b7ee

Register debuggers through a DebugAdapterFactory

view details

Joey Robichaud

commit sha f0f10a897f15a42aae536264cfdb361bcb7e7772

Register debugger for 'clr'

view details

Joey Robichaud

commit sha 38926158f71f050957d80af53c3933e15f650715

Fix urls in package.json

view details

Joey Robichaud

commit sha 90e77ffbd2af5b8c77eb77fdc447de49d88bafad

Remove unneeded comments

view details

Joey Robichaud

commit sha 5c114296dae72ec9a11103278ff65e8ef83a4637

Merge pull request #3912 from JoeRobich/debugger-registration Register DebugAdapterExecutableFactory

view details

push time in 2 days

issue closedOmniSharp/omnisharp-vscode

Please consider to move off from deprecated APIs

While investigating which debugger extensions are using deprecated extension API I found two issues with coreclr:

  • In the package.json "enableBreakpointsFor" is used as a property of the "debuggers" extension point (see here). This is deprecated and it is flagged as an error in the editor. Please use the "breakpoints" extension point (on the same level as "debuggers") instead:
    "contributes": {
      "breakpoints": [
        { "language": "csharp" },
        { "language": "razor" },
        { "language": "qsharp" ,
        { "language": "aspnetcorerazor" }
      ],
      "debuggers": [
        // ...
      [
    
  • In the package.json the deprecated "debuggers.adapterExecutableCommand" is used. Please use the "vscode.DebugAdapterDescriptorFactory" and a "vscode.DebugAdapterExecutable" instead like shown here with Mock debug. You can register the adapter factory in the extensions "activate" function like this:
    
    context.subscriptions.push(vscode.debug.registerDebugAdapterDescriptorFactory('coreclr', factory));;
    

closed time in 2 days

weinand

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

 export default function registerCommands(context: vscode.ExtensionContext, serve     disposable.add(vscode.commands.registerCommand('csharp.listRemoteProcess', async (args) => RemoteAttachPicker.ShowAttachEntries(args, platformInfo)));      // Register command for adapter executable command.

nit: remove outdated comment

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

 function showDotnetToolsWarning(message: string): void {     } } -interface AdapterExecutableCommand {-    command: string;-}--// The default extension manifest calls this command as the adapterExecutableCommand+// The activate method registers this factory to provide DebugAdapterDescriptors // If the debugger components have not finished downloading, the proxy displays an error message to the user // Else it will launch the debug adapter-export async function getAdapterExecutionCommand(platformInfo: PlatformInformation, eventStream: EventStream, packageJSON: any, extensionPath: string): Promise<AdapterExecutableCommand> {-    let util = new CoreClrDebugUtil(common.getExtensionPath());--    // Check for .debugger folder. Handle if it does not exist.-    if (!CoreClrDebugUtil.existsSync(util.debugAdapterDir())) {-        // our install.complete file does not exist yet, meaning we have not completed the installation. Try to figure out what if anything the package manager is doing-        // the order in which files are dealt with is this:-        // 1. install.Begin is created-        // 2. install.Lock is created-        // 3. install.Begin is deleted-        // 4. install.complete is created--        // install.Lock does not exist, need to wait for packages to finish downloading.-        let installLock = false;-        let debuggerPackage = getRuntimeDependencyPackageWithId("Debugger", packageJSON, platformInfo, extensionPath);-        if (debuggerPackage && debuggerPackage.installPath) {-            installLock = await common.installFileExists(debuggerPackage.installPath, common.InstallFileType.Lock);-        }+export class DebugAdapterExecutableFactory implements vscode.DebugAdapterDescriptorFactory { -        if (!installLock) {-            eventStream.post(new DebuggerNotInstalledFailure());-            throw new Error('The C# extension is still downloading packages. Please see progress in the output window below.');-        }-        // install.complete does not exist, check dotnetCLI to see if we can complete.-        else if (!CoreClrDebugUtil.existsSync(util.installCompleteFilePath())) {-            let success: boolean = await completeDebuggerInstall(platformInfo, eventStream);+    constructor(private readonly platformInfo: PlatformInformation, private readonly eventStream: EventStream, private readonly packageJSON: any, private readonly extensionPath: string) {+    } -            if (!success) {-                eventStream.post(new DebuggerNotInstalledFailure());-                throw new Error('Failed to complete the installation of the C# extension. Please see the error in the output window below.');+    async createDebugAdapterDescriptor(_session: vscode.DebugSession, executable: vscode.DebugAdapterExecutable | undefined): Promise<vscode.DebugAdapterDescriptor> {+        let util = new CoreClrDebugUtil(common.getExtensionPath());++        // Check for .debugger folder. Handle if it does not exist.+        if (!CoreClrDebugUtil.existsSync(util.debugAdapterDir())) {+            // our install.complete file does not exist yet, meaning we have not completed the installation. Try to figure out what if anything the package manager is doing+            // the order in which files are dealt with is this:+            // 1. install.Begin is created+            // 2. install.Lock is created+            // 3. install.Begin is deleted+            // 4. install.complete is created++            // install.Lock does not exist, need to wait for packages to finish downloading.+            let installLock = false;+            let debuggerPackage = getRuntimeDependencyPackageWithId("Debugger", this.packageJSON, this.platformInfo, this.extensionPath);+            if (debuggerPackage && debuggerPackage.installPath) {+                installLock = await common.installFileExists(debuggerPackage.installPath, common.InstallFileType.Lock);+            }++            if (!installLock) {+                this.eventStream.post(new DebuggerNotInstalledFailure());+                throw new Error('The C# extension is still downloading packages. Please see progress in the output window below.');+            }+            // install.complete does not exist, check dotnetCLI to see if we can complete.+            else if (!CoreClrDebugUtil.existsSync(util.installCompleteFilePath())) {+                let success: boolean = await completeDebuggerInstall(this.platformInfo, this.eventStream);++                if (!success) {+                    this.eventStream.post(new DebuggerNotInstalledFailure());+                    throw new Error('Failed to complete the installation of the C# extension. Please see the error in the output window below.');+                }             }         }-    } -    // debugger has finished installation, kick off our debugger process-    return {-        command: path.join(common.getExtensionPath(), ".debugger", "vsdbg-ui" + CoreClrDebugUtil.getPlatformExeExtension())-    };+        // debugger has finished installation, kick off our debugger process++        // use the executable specified in the package.json if it exists or determine it based on some other information (e.g. the session)+        if (!executable) {+            const command = path.join(common.getExtensionPath(), ".debugger", "vsdbg-ui" + CoreClrDebugUtil.getPlatformExeExtension());+            //const args = [

nit: leftover comments?

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

                   "items": {                     "type": "string"                   },-                  "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",

Fixed

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

 export async function activate(thisExtension: vscode.Extension<CSharpExtensionEx     } else if (!CoreClrDebugUtil.existsSync(_debugUtil.installCompleteFilePath())) {         completeDebuggerInstall(platformInformation, eventStream);     }++    const factory = new DebugAdapterExecutableFactory(platformInformation, eventStream, thisExtension.packageJSON, thisExtension.extensionPath);+    context.subscriptions.push(vscode.debug.registerDebugAdapterDescriptorFactory('coreclr', factory));

Added registration for 'clr'

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

                   "items": {                     "type": "string"                   },-                  "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",

I'll fix it by running the update dependencies task.

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

 function showDotnetToolsWarning(message: string): void {     } } -interface AdapterExecutableCommand {-    command: string;-}--// The default extension manifest calls this command as the adapterExecutableCommand+// The activate method registers this factory to provide DebugAdapterDescriptors // If the debugger components have not finished downloading, the proxy displays an error message to the user // Else it will launch the debug adapter-export async function getAdapterExecutionCommand(platformInfo: PlatformInformation, eventStream: EventStream, packageJSON: any, extensionPath: string): Promise<AdapterExecutableCommand> {-    let util = new CoreClrDebugUtil(common.getExtensionPath());--    // Check for .debugger folder. Handle if it does not exist.-    if (!CoreClrDebugUtil.existsSync(util.debugAdapterDir())) {-        // our install.complete file does not exist yet, meaning we have not completed the installation. Try to figure out what if anything the package manager is doing-        // the order in which files are dealt with is this:-        // 1. install.Begin is created-        // 2. install.Lock is created-        // 3. install.Begin is deleted-        // 4. install.complete is created--        // install.Lock does not exist, need to wait for packages to finish downloading.-        let installLock = false;-        let debuggerPackage = getRuntimeDependencyPackageWithId("Debugger", packageJSON, platformInfo, extensionPath);-        if (debuggerPackage && debuggerPackage.installPath) {-            installLock = await common.installFileExists(debuggerPackage.installPath, common.InstallFileType.Lock);-        }+export class DebugAdapterExecutableFactory implements vscode.DebugAdapterDescriptorFactory { -        if (!installLock) {-            eventStream.post(new DebuggerNotInstalledFailure());-            throw new Error('The C# extension is still downloading packages. Please see progress in the output window below.');-        }-        // install.complete does not exist, check dotnetCLI to see if we can complete.-        else if (!CoreClrDebugUtil.existsSync(util.installCompleteFilePath())) {-            let success: boolean = await completeDebuggerInstall(platformInfo, eventStream);+    constructor(private readonly platformInfo: PlatformInformation, private readonly eventStream: EventStream, private readonly packageJSON: any, private readonly extensionPath: string) {

This is amazing! I've always assigned parameters to the object. Now to never have to write self.parameter = parameter in Typescript again.

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

 function showDotnetToolsWarning(message: string): void {     } } -interface AdapterExecutableCommand {-    command: string;-}--// The default extension manifest calls this command as the adapterExecutableCommand+// The activate method registers this factory to provide DebugAdapterDescriptors // If the debugger components have not finished downloading, the proxy displays an error message to the user // Else it will launch the debug adapter-export async function getAdapterExecutionCommand(platformInfo: PlatformInformation, eventStream: EventStream, packageJSON: any, extensionPath: string): Promise<AdapterExecutableCommand> {-    let util = new CoreClrDebugUtil(common.getExtensionPath());--    // Check for .debugger folder. Handle if it does not exist.-    if (!CoreClrDebugUtil.existsSync(util.debugAdapterDir())) {-        // our install.complete file does not exist yet, meaning we have not completed the installation. Try to figure out what if anything the package manager is doing-        // the order in which files are dealt with is this:-        // 1. install.Begin is created-        // 2. install.Lock is created-        // 3. install.Begin is deleted-        // 4. install.complete is created--        // install.Lock does not exist, need to wait for packages to finish downloading.-        let installLock = false;-        let debuggerPackage = getRuntimeDependencyPackageWithId("Debugger", packageJSON, platformInfo, extensionPath);-        if (debuggerPackage && debuggerPackage.installPath) {-            installLock = await common.installFileExists(debuggerPackage.installPath, common.InstallFileType.Lock);-        }+export class DebugAdapterExecutableFactory implements vscode.DebugAdapterDescriptorFactory { -        if (!installLock) {-            eventStream.post(new DebuggerNotInstalledFailure());-            throw new Error('The C# extension is still downloading packages. Please see progress in the output window below.');-        }-        // install.complete does not exist, check dotnetCLI to see if we can complete.-        else if (!CoreClrDebugUtil.existsSync(util.installCompleteFilePath())) {-            let success: boolean = await completeDebuggerInstall(platformInfo, eventStream);+    constructor(private readonly platformInfo: PlatformInformation, private readonly eventStream: EventStream, private readonly packageJSON: any, private readonly extensionPath: string) {

It is a TypeScript shorthand. They are private fields.

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

 export async function activate(thisExtension: vscode.Extension<CSharpExtensionEx     } else if (!CoreClrDebugUtil.existsSync(_debugUtil.installCompleteFilePath())) {         completeDebuggerInstall(platformInformation, eventStream);     }++    const factory = new DebugAdapterExecutableFactory(platformInformation, eventStream, thisExtension.packageJSON, thisExtension.extensionPath);+    context.subscriptions.push(vscode.debug.registerDebugAdapterDescriptorFactory('coreclr', factory));

Doh, thanks!

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

 function showDotnetToolsWarning(message: string): void {     } } -interface AdapterExecutableCommand {-    command: string;-}--// The default extension manifest calls this command as the adapterExecutableCommand+// The activate method registers this factory to provide DebugAdapterDescriptors // If the debugger components have not finished downloading, the proxy displays an error message to the user // Else it will launch the debug adapter-export async function getAdapterExecutionCommand(platformInfo: PlatformInformation, eventStream: EventStream, packageJSON: any, extensionPath: string): Promise<AdapterExecutableCommand> {-    let util = new CoreClrDebugUtil(common.getExtensionPath());--    // Check for .debugger folder. Handle if it does not exist.-    if (!CoreClrDebugUtil.existsSync(util.debugAdapterDir())) {-        // our install.complete file does not exist yet, meaning we have not completed the installation. Try to figure out what if anything the package manager is doing-        // the order in which files are dealt with is this:-        // 1. install.Begin is created-        // 2. install.Lock is created-        // 3. install.Begin is deleted-        // 4. install.complete is created--        // install.Lock does not exist, need to wait for packages to finish downloading.-        let installLock = false;-        let debuggerPackage = getRuntimeDependencyPackageWithId("Debugger", packageJSON, platformInfo, extensionPath);-        if (debuggerPackage && debuggerPackage.installPath) {-            installLock = await common.installFileExists(debuggerPackage.installPath, common.InstallFileType.Lock);-        }+export class DebugAdapterExecutableFactory implements vscode.DebugAdapterDescriptorFactory { -        if (!installLock) {-            eventStream.post(new DebuggerNotInstalledFailure());-            throw new Error('The C# extension is still downloading packages. Please see progress in the output window below.');-        }-        // install.complete does not exist, check dotnetCLI to see if we can complete.-        else if (!CoreClrDebugUtil.existsSync(util.installCompleteFilePath())) {-            let success: boolean = await completeDebuggerInstall(platformInfo, eventStream);+    constructor(private readonly platformInfo: PlatformInformation, private readonly eventStream: EventStream, private readonly packageJSON: any, private readonly extensionPath: string) {

I'm not sure if this is a new Typescript feature, but are these arguments saved to the object?

Does this.packageJSON/this.platformInfo exist?

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

 export async function activate(thisExtension: vscode.Extension<CSharpExtensionEx     } else if (!CoreClrDebugUtil.existsSync(_debugUtil.installCompleteFilePath())) {         completeDebuggerInstall(platformInformation, eventStream);     }++    const factory = new DebugAdapterExecutableFactory(platformInformation, eventStream, thisExtension.packageJSON, thisExtension.extensionPath);+    context.subscriptions.push(vscode.debug.registerDebugAdapterDescriptorFactory('coreclr', factory));

We will also need a DebugAdapterDescriptor for DesktopCLR debugging.

context.subscriptions.push(vscode.debug.registerDebugAdapterDescriptorFactory('clr', factory));

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory

                   "items": {                     "type": "string"                   },-                  "description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.",

Undo removing \u200b

We use '\u200b' (unicode zero-length space character) to break VS Code's URL detection regex for URLs that are examples.

JoeRobich

comment created time in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Update Razor to include various improvments

     "workspaceContains:**/*.cake"   ],   "contributes": {+    "breakpoints": [

I opened https://github.com/OmniSharp/omnisharp-vscode/pull/3912 to move us off the deprecated API

ryanbrandenburg

comment created time in 2 days

PR opened OmniSharp/omnisharp-vscode

Register DebugAdapterExecutableFactory Debugger

Fixes https://github.com/OmniSharp/omnisharp-vscode/issues/3512

  • Removes the "csharp.coreclrAdapterExecutableCommand" & "csharp.clrAdapterExecutableCommand"
  • Registers a DebugAdapterExecutableFactory with the logic from the getAdapterExecutionCommand method.

cc: @gregg-miskelly, @WardenGnaw

+560 -141

0 comment

4 changed files

pr created time in 2 days

fork alanjclark/omnisharp-roslyn

OmniSharp server (HTTP, STDIO) based on Roslyn workspaces

fork in 2 days

fork alanjclark/omnisharp-vscode

Official C# support for Visual Studio Code (powered by OmniSharp)

fork in 2 days

Pull request review commentOmniSharp/omnisharp-vscode

Update Razor to include various improvments

     "workspaceContains:**/*.cake"   ],   "contributes": {+    "breakpoints": [

It's unclear to me, should I not have copied these over? It seemed like they got added by @captainsafia's work. If they SHOULDN'T be copied to here I suggest we note that in the AspNetCore-Tooling repo's package.json to avoid repeats.

ryanbrandenburg

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Ah, oops. I was able to install unzip, but still did not have luck

> /bin/sh '/home/jf/.vim/plugged/omnisharp-vim/installer/omnisharp-manager.sh'   -l '/cygdrive/c/Users/jf/AppData/Local/omnisharp-vim/omnisharp-roslyn'  -W
  2 ================================================================================
  3   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
  4                                  Dload  Upload   Total   Spent    Left  Speed
  5  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0100   632  100   632    0     0    632          0  0:00:01 --:--:--  0:00:01  1926
  6 Warning: Failed to create the file
  7 Warning: /cygdrive/c/Users/JerseyFonseca/AppData/Local/omnisharp-vim/omnisharp
  8 Warning: roslyn/omnisharp-win-x64.zip: No such file or directory
  9  0 33.0M    0 16967    0     0  16967      0  0:34:05 --:--:--  0:34:05 16967
 10 curl: (23) Failed writing body (0 != 16384)
 11 Error: failed to download the server, possibly a network issue
vuciv

comment created time in 2 days

issue commentOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Could you please share the contents of the error log file at: /home/jf/.vim/plugged/omnisharp-vim/log/install.log

vuciv

comment created time in 2 days

issue openedOmniSharp/omnisharp-vim

Error installing the OmniSharp-Roslyn server on cygwin

Error and details"

Failed to install the OmniSharp-Roslyn server

Error: failed to download the server, possibly a network issue

The full error log can be found in the file: /home/jf/.vim/plugged/omnisharp-vim/log/install.log

Could not run command: /cygdrive/c/Users/jf/AppData/Local/omnisharp-vim/omnisharp-roslyn/OmniSharp.exe -s \home\jf\development\project\project.sln -e utf-8

channel 0 closed: 'executing job failed: No such file or directory'

Log file:

`VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar 30 2020 21:58:19), Included patches: 1-486 OmniSharp server started.

Path: /cygdrive/c/Users/jf/AppData/Local/omnisharp-vim/omnisharp-roslyn/OmniSharp.exe

Target: /home/jf/development/project/project.sln PID: 591 `

Can anyone help?

created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Debugging failed that "Could not locate .NET Core project. Assets were not generated.".

So..how do I "Create new .NET Core 3.0 console application(con30) with reference to a .NET Standard 2.1 class library(cla21) via CLI"?

YunWeiaa

comment created time in 2 days

startedOmniSharp/omnisharp-vscode

started time in 2 days

issue closedOmniSharp/omnisharp-vscode

The type or namespace name 'Drawing' does not exist in the namespace 'System'

Issue Description

Error (The type or namespace name 'Drawing' does not exist in the namespace 'System' (are you missing an assembly reference?))

Steps to Reproduce

  • Create a project with dotnet new console
  • Open the project with Visual Studio Code.

Expected Behavior

  • No error happens.

Actual Behavior

Lots of error like The type or namespace name 'Drawing' does not exist in the namespace 'System' (are you missing an assembly reference?) though dotnet publish works well. image image

OmniSharp log

<details>

Starting OmniSharp server at 7/2/2020, 11:49:46 PM
    Target: /home/cipher/Projects/sunshine

OmniSharp server started with Mono 6.4.0.
    Path: /home/cipher/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/OmniSharp.exe
    PID: 9085

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on arch 0.0 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Mono 16.4 - "/usr/lib/mono/msbuild/Current/bin"
            2: StandAlone 16.4 - "/home/cipher/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Mono 16.4 - "/usr/lib/mono/msbuild/Current/bin"
            CscToolExe = csc.exe
            CscToolPath = /home/cipher/.vscode/extensions/ms-dotnettools.csharp-1.22.1/.omnisharp/1.35.3/omnisharp/.msbuild/Current/Bin/Roslyn
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/home/cipher/Projects/sunshine'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.MSBuild.ProjectSystem
        No solution files found in '/home/cipher/Projects/sunshine'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/home/cipher/Projects/sunshine/src/sunshine.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/home/cipher/Projects/sunshine'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /home/cipher/Projects/sunshine/src/sunshine.csproj
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location '/home/cipher/Projects/sunshine' on host 8947.
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/home/cipher/Projects/sunshine/src/sunshine.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Adding project '/home/cipher/Projects/sunshine/src/sunshine.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: sunshine
[info]: OmniSharp.Roslyn.CSharp.Services.Diagnostics.CSharpDiagnosticWorkerWithAnalyzers
        Solution initialized -> queue all documents for code analysis. Initial document count: 23.

</details>

C# log

(No output.)

Environment information

VSCode version: 1.46.0 C# Extension: 1.22.1

<details><summary>Mono Information</summary> OmniSharp using global mono :6.4.0</details> <details><summary>Dotnet Information</summary> .NET Core SDK (reflecting any global.json): Version: 3.1.103 Commit: 6f74c4a1dd

Runtime Environment: OS Name: arch OS Version:
OS Platform: Linux RID: arch-x64 Base Path: /usr/share/dotnet/sdk/3.1.103/

Host (useful for support): Version: 3.1.5 Commit: 65cd789777

.NET Core SDKs installed: 3.1.103 [/usr/share/dotnet/sdk]

.NET Core runtimes installed: Microsoft.NETCore.App 3.1.3 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs: https://aka.ms/dotnet-download </details> <details><summary>Visual Studio Code Extensions</summary>

Extension Author Version
cpptools ms-vscode 0.28.3
csharp ms-dotnettools 1.22.1
discord-vscode icrawl 3.14.0
gitlens eamodio 10.2.2
go golang 0.15.0
python ms-python 2020.6.91350
vscode-docker ms-azuretools 1.3.1
vscode-firefox-debug firefox-devtools 2.9.0
vscode-github KnisterPeter 0.30.3
vscode-wakatime WakaTime 4.0.0

</details>

closed time in 2 days

minhducsun2002

issue commentOmniSharp/omnisharp-vscode

The type or namespace name 'Drawing' does not exist in the namespace 'System'

Thank you, ignoring the global Mono installation fixed the issue.

minhducsun2002

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Possible wrong color coding for nested function return type

@gsscoder To workaround some of the limitations of our C# textmate theme, you can enable editor.semanticHighlighting.enabled and csharp.semanticHighlighting.enabled. It required using a theme that supports semantic highlight. You can try our Visual Studio 2019 Dark theme if you like, or you can tell VS Code that you current theme supports semanticHighlighting by following the instructions here (https://github.com/microsoft/vscode/issues/92740#issuecomment-600100176) to update your "editor.tokenColorCustomizations".

gsscoder

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Intellisense continues to highlight fixed/stale errors (only if they were in the last compile attempt)

As a workaround to stop reporting errors from the build task, you could update your tasks.json such that the "build" task doesn't define a problemMatcher.

example:

    {
      "label": "build",
      "command": "dotnet",
      "type": "process",
      "args": [
        "build",
        "${workspaceFolder}/src/dotnet-format.csproj",
        "/property:GenerateFullPaths=true",
        "/consoleloggerparameters:NoSummary"
      ],
-     "problemMatcher": "$msCompile"
+     "problemMatcher": []
    },
sky-lake

comment created time in 2 days

issue openedOmniSharp/omnisharp-vscode

Possible wrong color coding for nested function return type

To be honest I'm not sure this is the right place to post this issue.

Anyway I think this is wrong (more easy if I attach a screenshot): colorcoding-nestedreturn

Regards, Giacomo S. S.

created time in 2 days

issue commentOmniSharp/omnisharp-vscode

[question] Razor runtime dependency license

https://github.com/dotnet/aspnetcore-tooling/blob/master/LICENSE.txt

😄

muhammadsammy

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

[question] Razor runtime dependency license

cc: @NTaylorMullen

muhammadsammy

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Always show "Downloading package 'OmniSharp (.NET 4.6 / x64)' (12310 KB) ."

@tluyben @breadnone The only reason I can think of that it would be continually downloading is that the setting omnisharp.path has accidentally been set to latest. If this is the case, you can set it back to default or remove it.

qslcna

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

IntelliSense not working with Unity, since omnisharp can't start up / Ubuntu 18.04

@aryan29 Can you open a new issue for the problem you are experiencing? Be sure to include the OmniSharp log from the output pane. Thanks!

RipplB

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

Only loads after file is modified

@sguillia Sorry things aren't working as expected. I was unable to reproduce the behavior you are seeing. Can you tell me more about the workflow you use to reproduce this?

  • Did you open a folder in VS Code that contains your source along side a .csproj or .sln file, then select a file from the explorer pane? Or are you opening a single .cs file on its own?
  • Do you have a repo where this reproduces reliably?
sguillia

comment created time in 2 days

issue commentOmniSharp/omnisharp-vscode

The type or namespace name 'Drawing' does not exist in the namespace 'System'

@minhducsun2002 Sorry you are having issues. This might be a case where the msbuild in the mono package isn't complete. There is a msbuild-stable package you could install that may resolve this issue. If you find things just work better with the included mono, you can also set omnisharp.useGlobalMono to never and it will only use the included mono.

minhducsun2002

comment created time in 3 days

issue commentOmniSharp/omnisharp-vscode

The SDK 'Microsoft.NET.Sdk' specified could not be found.

Having the same problem on Windows 10 Adding "UseLegacySdkResolver": true to my omnisharp.json file fixed the issue.

Fixed for me too.

File location at Windows is C:\Users\%USERNAME%\.omnisharp\. The folder was empty in my case so I just created omnisharp.json

richlander

comment created time in 3 days

startedOmniSharp/omnisharp-emacs

started time in 3 days

startedOmniSharp/omnisharp-roslyn

started time in 3 days

issue commentOmniSharp/omnisharp-vscode

Debugging failed that "Could not locate .NET Core project. Assets were not generated.".

@KitsuneShan When you ran dotnet new console did it also create a .csproj file along side the Program.cs file? If you reopen the folder that contains the .csproj, are you able to generate launch assets?

YunWeiaa

comment created time in 3 days

issue commentOmniSharp/omnisharp-vscode

Some lines don't get formatted

Hi @Rechdan, Those lines are both variable declarations and the setting you need to change is "SpacesIgnoreAroundVariableDeclaration". At the moment you are ignoring the spacing around variable declarations. -Joey

Rechdan

comment created time in 3 days

issue commentOmniSharp/omnisharp-vscode

XML documentation doesn't render properly in the intellisense preview

Note that the Hover returned by HoverProvider can use MarkdownString to embed code blocks - https://code.visualstudio.com/api/references/vscode-api#MarkdownString

CozyPenguin

comment created time in 3 days

more