profile
viewpoint
Mike McQuaid MikeMcQuaid @GitHub Edinburgh, Scotland https://mikemcquaid.com @Homebrew Project Leader. @github engineer. @GitInPractice author. Rude people blocker. Wife, child, dog and Apple things lover.

github/opensource.guide 7020

📚 Community guides for open source creators

MikeMcQuaid/GitInPractice 766

📖 An opinionated intermediate/advanced Git book

Homebrew/braumeister 212

💀 An deprecated formulae browser for Homebrew

MikeMcQuaid/dotfiles 178

:computer: My dot files shared between machines.

aymannadeem/yourhaq 41

Community driven content for people navigating changing US immigration laws.

MikeMcQuaid/GitInPracticeRedux 33

👩🏼‍💻 A repository created by working through the examples in Git In Practice

MikeMcQuaid/gitinpractice.com 10

🏡 The home page for an opinionated intermediate/advanced Git book

MikeMcQuaid/brew 6

🍺 The missing package manager for macOS

MikeMcQuaid/cantyoujust.no 5

Can't you just ...? NO.

MikeMcQuaid/Fabula 4

:book: A RPG conversation editor.

push eventHomebrew/brew

Bo Anderson

commit sha d5d3fc0f4bc75aa725fbc5557ff5f3050c1ca978

formula: use installed_prefixes in opt_or_installed_prefix_keg

view details

Mike McQuaid

commit sha b8018b49dae2f5ef8c680239d74b16fc6fa4e907

Merge pull request #7967 from Bo98/opt_or_installed_prefix_keg formula: use installed_prefixes in opt_or_installed_prefix_keg

view details

push time in an hour

pull request commentHomebrew/brew

formula: use installed_prefixes in opt_or_installed_prefix_keg

Merging to fix CI, thanks @Bo98!

Bo98

comment created time in an hour

PR merged Homebrew/brew

formula: use installed_prefixes in opt_or_installed_prefix_keg
  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

installed_prefix always refers to the latest version - which may not necessarily be installed like the name suggests. installed_prefixes meanwhile guarantees to return paths that actually exist.

This should fix the brew doctor failure if an old python is installed, as seen in recent CI failures.

+2 -2

0 comment

1 changed file

Bo98

pr closed time in an hour

created tagHomebrew/brew

tag2.4.5

🍺 The missing package manager for macOS (or Linux)

created time in 16 hours

release Homebrew/brew

2.4.5

released time in 16 hours

PR opened Homebrew/brew

cleanup: check path exists before cleanup.

It may have been already cleaned up by an earlier step.

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+1 -0

0 comment

1 changed file

pr created time in 16 hours

create barnchMikeMcQuaid/brew

branch : cleanup-exist

created branch time in 16 hours

push eventgithub/opensource.guide

Mike McQuaid

commit sha f7bb97940c9c387a3bdfa65c186330e932aeba7f

Use blob/HEAD instead of blob/master. This fixes one currently broken link and will fix future cases if people rename their default branches.

view details

Mike McQuaid

commit sha 6d684aa22e682613a0a61c03d7d620aa7bed0b9d

Merge pull request #1704 from MikeMcQuaid/master-head Use blob/HEAD instead of blob/master.

view details

push time in 16 hours

PR merged github/opensource.guide

Use blob/HEAD instead of blob/master.

This fixes one currently broken link and will fix future cases if people rename their default branches.

+144 -144

0 comment

72 changed files

MikeMcQuaid

pr closed time in 16 hours

PR merged Homebrew/brew

keg: delete more alias LinkedKegs symlinks.

We don't actually care what it points to because we shouldn't have LinkedKegs around for aliases at all (unlike opt links).

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+2 -8

0 comment

1 changed file

MikeMcQuaid

pr closed time in 16 hours

push eventHomebrew/brew

Mike McQuaid

commit sha 66230fa84279b22d374b5a306beef54dfaf01c01

keg: delete more alias LinkedKegs symlinks. We don't actually care what it points to because we shouldn't have LinkedKegs around for aliases at all (unlike `opt` links).

view details

Mike McQuaid

commit sha 6d2c39579e22d0ee9baccdccdd8a12efb8b00304

Merge pull request #7960 from MikeMcQuaid/delete-more-linkedkegs-symlinks keg: delete more alias LinkedKegs symlinks.

view details

push time in 16 hours

push eventMikeMcQuaid/brew

Mike McQuaid

commit sha 66230fa84279b22d374b5a306beef54dfaf01c01

keg: delete more alias LinkedKegs symlinks. We don't actually care what it points to because we shouldn't have LinkedKegs around for aliases at all (unlike `opt` links).

view details

push time in 17 hours

PR opened Homebrew/brew

keg: delete more alias LinkedKegs symlinks.

We don't actually care what it points to because we shouldn't have LinkedKegs around for aliases at all (unlike opt links).

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+3 -5

0 comment

1 changed file

pr created time in 17 hours

create barnchMikeMcQuaid/brew

branch : delete-more-linkedkegs-symlinks

created branch time in 17 hours

PR opened github/opensource.guide

Use blob/HEAD instead of blob/master.

This fixes one currently broken link and will fix future cases if people rename their default branches.

+144 -144

0 comment

72 changed files

pr created time in 17 hours

create barnchMikeMcQuaid/opensource.guide

branch : master-head

created branch time in 17 hours

fork MikeMcQuaid/opensource.guide

📚 Community guides for open source creators

https://opensource.guide/

fork in 17 hours

pull request commentHomebrew/brew

language/python: allow python@3.7 to be used for virtualenvs

👍 to holding off for now so we can land this PR and get a release out ASAP.

Bo98

comment created time in 18 hours

Pull request review commentHomebrew/brew

language/python: allow python@3.7 to be used for virtualenvs

 def message   end end +class FormulaUnknownPythonError < RuntimeError+  def initialize(formula)+    super <<~EOS+      The version of Python to use with the virtualenv in the `#{formula.full_name}` formula+      cannot be guessed automatically because a recognised Python dependency could not be found.++      If you are using a non-standard Python depedency, please add `:using => "python@x.y"` to+      `virtualenv_install_with_resources` to resolve the issue manually.

❤️

Bo98

comment created time in 18 hours

PR merged Homebrew/brew

formula: look harder for a linked keg.

Add and use a possible_names method to find a linked keg based on an old name or alias.

Use this both for link_overwrite and for linked_keg (which is what brew upgrade uses to find outdated kegs).

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+14 -11

0 comment

1 changed file

MikeMcQuaid

pr closed time in 18 hours

delete branch MikeMcQuaid/brew

delete branch : formula-linked-keg

delete time in 18 hours

push eventHomebrew/brew

Mike McQuaid

commit sha 82e249b92fda53d8ae5468e00e63842da3173fac

formula: look harder for a linked keg. Add and use a `possible_names` method to find a linked keg based on an old name or alias. Use this both for `link_overwrite` and for `linked_keg` (which is what `brew upgrade` uses to find outdated kegs).

view details

Mike McQuaid

commit sha a3c89ff93b21c9e0db47b7b5c6cfa7f3566aa471

Merge pull request #7955 from MikeMcQuaid/formula-linked-keg formula: look harder for a linked keg.

view details

push time in 18 hours

push eventMikeMcQuaid/brew

vidusheeamoli

commit sha 76a2e699907655f641dfadfcc3e7d579457049ce

sorbet: set utils/git.rb to true (cherry picked from commit 44a04adb1de430066af73a65766eb644c0f5bd41)

view details

Issy Long

commit sha eee17fd1b56c553372765ef2a4d3e3f570ec7510

Merge pull request #7933 from vidusheeamoli/utils-gem-to-true sorbet: set utils/git.rb to true

view details

vidusheeamoli

commit sha 79ac3875d5234fd382163c3645b8734a78007f43

sorbet: set utils/notability.rb to true

view details

Issy Long

commit sha d1f6296f0fef3c06ddd29630ca00f950a8f7b762

Merge pull request #7943 from vidusheeamoli/utils-notability-to-true sorbet: set utils/notability.rb to true

view details

Claudia

commit sha 374c734d9b3f8e6fa20810ad4d049ca2711e2156

Make `Hardware.oldest_cpu` depend on architecture Starting with Xcode 12 Beta 2, builds that used to work on Apple Silicon now break due to `Hardware#oldest_cpu` returning `:nehalem` [1]. This commit is the first in a series of improvements to `Hardware#oldest_cpu`. It resolves the Xcode 12 Beta 2 issue for now. [1]: https://github.com/Homebrew/brew/issues/7857#issuecomment-655536261

view details

Claudia Pellegrino

commit sha 0735915dc58470e310ac81a5a09c07e6cb64a6cb

Merge pull request #7945 from claui/oldest_cpu Make Homebrew work with Xcode 12 Beta 2 on Apple Silicon

view details

Michka Popoff

commit sha 9c3cc31cb4055efe618bb6d463ddc8682a15b904

uses_from_macos: move cpio to shadowed by macos list

view details

Michka Popoff

commit sha 369f919dabef295bb0260b63f34e0c49e723a642

Merge pull request #7947 from iMichka/cpio2 uses_from_macos: move cpio to shadowed by macos list

view details

Seeker

commit sha 02d6b671e6bc2ad2bb26306966b68d78d5d07696

Revert "python_virtualenv_constants: upgrade virtualenv to 20.0.26" This reverts commit 6dbcf83a21d36a0c03990a923cc07ef4a06e4e7f.

view details

Issy Long

commit sha 2c3b2f68cd2b22e08b8841cc4de3d67593284b9f

Revert #7933 ("sorbet: set utils/git.rb to true") - My refactoring of #7933 went wrong in that the tests passed for `brew extract` and my manual testing, but both forgot about third-party taps exist, so that functionality broke as follows (courtesy of Misty). Before: ``` # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"]) => ["ac0665d", ["README.md"]] ``` After: ``` # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"]) => [nil, []] ``` - While we think about how to do splats in Sorbet, revert this so that users are able to `brew extract` from third party taps again. - A TODO for later in a separate PR is to write a test for `brew extract` that tests the behaviour of third-party taps. --- - Reverted this manually because the GitHub UI couldn't do it. - Arguably I didn't need to remove the RBI file, but it's easier to have everything gone for now and then revert this revert in future once we have a strategy for dealing with splats in Sorbet than have inconsistency.

view details

Jonathan Chang

commit sha 5c8ad2fb4841bd38feeeab188c332e5309a8880e

Merge pull request #7950 from SeekingMeaning/venv-hotfix Revert "python_virtualenv_constants: upgrade virtualenv to 20.0.26"

view details

Mike McQuaid

commit sha 146eca4608e93f0ec95ea03e13c15071c86ca8bb

Merge pull request #7951 from issyl0/revert-7933 Revert #7933 ("sorbet: set utils/git.rb to true")

view details

Bo Anderson

commit sha 2afa8497c096ba85489b4f242c64a0cdf1b06214

formula: consider aliases in installed_prefixes

view details

Mike McQuaid

commit sha 386747c73371593ff184acdd3d78fa24ea6173e1

keg: unlink alias linkedkegs. We did these for opt symlinks already but not linkedkegs.

view details

Mike McQuaid

commit sha 91b0bd37987d3aaf5ebc9766fc550327acc6ff51

Merge pull request #7952 from Bo98/alias_prefixes formula: consider aliases in installed_prefixes

view details

Mike McQuaid

commit sha 50d12ce900b95e2f0865d781f884ab9093187654

Merge pull request #7956 from MikeMcQuaid/keg-unlink-more-aliases keg: unlink alias linkedkegs.

view details

Mike McQuaid

commit sha 82e249b92fda53d8ae5468e00e63842da3173fac

formula: look harder for a linked keg. Add and use a `possible_names` method to find a linked keg based on an old name or alias. Use this both for `link_overwrite` and for `linked_keg` (which is what `brew upgrade` uses to find outdated kegs).

view details

push time in 18 hours

delete branch MikeMcQuaid/brew

delete branch : keg-unlink-more-aliases

delete time in 19 hours

push eventHomebrew/brew

Mike McQuaid

commit sha 386747c73371593ff184acdd3d78fa24ea6173e1

keg: unlink alias linkedkegs. We did these for opt symlinks already but not linkedkegs.

view details

Mike McQuaid

commit sha 50d12ce900b95e2f0865d781f884ab9093187654

Merge pull request #7956 from MikeMcQuaid/keg-unlink-more-aliases keg: unlink alias linkedkegs.

view details

push time in 19 hours

PR merged Homebrew/brew

keg: unlink alias linkedkegs.

We did these for opt symlinks already but not linkedkegs.

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+20 -9

0 comment

1 changed file

MikeMcQuaid

pr closed time in 19 hours

push eventHomebrew/brew

Bo Anderson

commit sha 2afa8497c096ba85489b4f242c64a0cdf1b06214

formula: consider aliases in installed_prefixes

view details

Mike McQuaid

commit sha 91b0bd37987d3aaf5ebc9766fc550327acc6ff51

Merge pull request #7952 from Bo98/alias_prefixes formula: consider aliases in installed_prefixes

view details

push time in 19 hours

PR merged Homebrew/brew

formula: consider aliases in installed_prefixes
  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

Before:

[#<Pathname:/usr/local/Cellar/python@3.8/3.8.3_1>]

After:

[#<Pathname:/usr/local/Cellar/python@3.8/3.8.3_1>, #<Pathname:/usr/local/Cellar/python/3.7.8>]
+10 -1

0 comment

1 changed file

Bo98

pr closed time in 19 hours

push eventMikeMcQuaid/brew

Chongyu Zhu

commit sha 6dbcf83a21d36a0c03990a923cc07ef4a06e4e7f

python_virtualenv_constants: upgrade virtualenv to 20.0.26

view details

Mike McQuaid

commit sha d5123743b68eb770f72c6a0899999b11224873ef

Merge pull request #7941 from lembacon/virtualenv-20.0.26 python_virtualenv_constants: upgrade virtualenv to 20.0.26

view details

Bo Anderson

commit sha e3c4dea80775888be047b08f3962b13e53c243b9

formula: consider aliases in installed_prefixes

view details

Mike McQuaid

commit sha 03cbc4ef133b4ee4991641b317759cac0602affd

formula: look harder for a linked keg. Add and use a `possible_names` method to find a linked keg based on an old name or alias. Use this both for `link_overwrite` and for `linked_keg` (which is what `brew upgrade` uses to find outdated kegs).

view details

push time in 19 hours

PR opened Homebrew/brew

keg: general cleanup.

Some refactoring while doing #7956.

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+7 -6

0 comment

1 changed file

pr created time in 19 hours

create barnchMikeMcQuaid/brew

branch : keg-refactoring

created branch time in 19 hours

PR opened Homebrew/brew

keg: unlink alias linkedkegs.

We did these for opt symlinks already but not linkedkegs.

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+20 -9

0 comment

1 changed file

pr created time in 19 hours

create barnchMikeMcQuaid/brew

branch : keg-unlink-more-aliases

created branch time in 19 hours

PR opened Homebrew/brew

formula: look harder for a linked keg.

Add and use a possible_names method to find a linked keg based on an old name or alias.

Use this both for link_overwrite and for linked_keg (which is what brew upgrade uses to find outdated kegs).

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+9 -2

0 comment

1 changed file

pr created time in 19 hours

create barnchMikeMcQuaid/brew

branch : formula-linked-keg

created branch time in 19 hours

Pull request review commentHomebrew/brew

formula: consider aliases in installed_prefixes

 def rack   # All currently installed prefix directories.   # @private   def installed_prefixes-    rack.directory? ? rack.subdirs.sort : []+    prefixes = rack.directory? ? rack.subdirs : []++    prefixes += (aliases + Array(oldname)).map do |alias_name|+      rack_alias = HOMEBREW_CELLAR/alias_name+      next unless rack_alias.directory?++      rack_alias.subdirs+    end.compact++    prefixes.flatten.sort_by(&:basename)
    prefixes += (aliases + Array(oldname)).flat_map do |alias_name|
      rack_alias = HOMEBREW_CELLAR/alias_name
      next unless rack_alias.directory?

      rack_alias.subdirs
    end.compact

    prefixes.sort_by(&:basename)

Sorry to bike shed. Feel free to pass on this if desired.

Bo98

comment created time in 19 hours

pull request commentHomebrew/homebrew-core

python@3.8: install pip3 and wheel3 to /usr/local/bin/

Thanks. Fine to leave as-is then 👍

Bo98

comment created time in 20 hours

pull request commentHomebrew/homebrew-core

python@3.8: install pip3 and wheel3 to /usr/local/bin/

Perhaps we could adjust the test to use HOMEBREW_PREFIX/bin?

Bo98

comment created time in 21 hours

Pull request review commentHomebrew/brew

formula: consider aliases in installed_prefixes

 def rack   # All currently installed prefix directories.   # @private   def installed_prefixes-    rack.directory? ? rack.subdirs.sort : []+    prefixes = rack.directory? ? rack.subdirs.sort : []++    aliases.each do |alias_name|+      rack_alias = HOMEBREW_CELLAR/alias_name+      next unless rack_alias.directory?++      prefixes += rack_alias.subdirs.sort+    end++    prefixes

Yeh, would be ideal just in case it's not been run yet.

Bo98

comment created time in 21 hours

pull request commentHomebrew/homebrew-core

python@3.8: install pip3 and wheel3 to /usr/local/bin/

Hmm, wonder why system bin/"pip3", "list", "--format=columns" in the test didn't catch this...

Bo98

comment created time in a day

pull request commentHomebrew/homebrew-core

python@3.8: install pip3 and wheel3 to /usr/local/bin/

Shouldn't block this PR but: a test do block to catch this would be handy.

Bo98

comment created time in a day

issue commentHomebrew/brew

macOS 10.16/11.0 Big Sur compatibility

We could have separate bottles wherever it’s necessary, with each bottle containing only a single architecture. We could then have Homebrew choose the architecture per-formula at brew install time.

@claui We are unlikely to take this approach because you wouldn't be able to have e.g. a x86_64 and ARM OpenSSL installed at the same time.

The best approach I can think of so far is allowing you to specify on ARM to use entirely x86_64 bottles through Rosetta and have one-homebrew-installation-per-architecture.

claui

comment created time in a day

Pull request review commentHomebrew/brew

formula: consider aliases in installed_prefixes

 def rack   # All currently installed prefix directories.   # @private   def installed_prefixes-    rack.directory? ? rack.subdirs.sort : []+    prefixes = rack.directory? ? rack.subdirs.sort : []++    aliases.each do |alias_name|+      rack_alias = HOMEBREW_CELLAR/alias_name+      next unless rack_alias.directory?++      prefixes += rack_alias.subdirs.sort+    end++    prefixes

Oh: may want to include oldname (or old_name) in here too.

Bo98

comment created time in a day

Pull request review commentHomebrew/brew

formula: consider aliases in installed_prefixes

 def rack   # All currently installed prefix directories.   # @private   def installed_prefixes-    rack.directory? ? rack.subdirs.sort : []+    prefixes = rack.directory? ? rack.subdirs.sort : []++    aliases.each do |alias_name|+      rack_alias = HOMEBREW_CELLAR/alias_name+      next unless rack_alias.directory?++      prefixes += rack_alias.subdirs.sort+    end++    prefixes
    prefixes = rack.directory? ? rack.subdirs : []

    prefixes += aliases.map do |alias_name|
      rack_alias = HOMEBREW_CELLAR/alias_name
      next unless rack_alias.directory?

      rack_alias.subdirs.sort
    end.compact

    prefixes.sort

This will ensure that they are all sorted.

Bo98

comment created time in a day

Pull request review commentHomebrew/brew

Utils::Bottles::tag: ARM tag is arm64_big_sur

 class << self       undef tag        def tag-        tag = MacOS.version.to_sym-        tag = "#{tag}_arm".to_sym if Hardware::CPU.arm?-        tag+        if Hardware::CPU.intel?+          MacOS.version.to_sym+        else+          "#{ENV["HOMEBREW_PROCESSOR"]}_#{MacOS.version}".to_sym

Gotcha. I'd be fine with arm64_big_sur or apple_silicon_big_sur.

My reasoning for big_sur_arm was that we will likely end up having a 11.x where they/we don't support x86_64 any longer.

sjackman

comment created time in a day

issue commentHomebrew/brew

macOS 10.16/11.0 Big Sur compatibility

@adib We don't have one yet. Our current plan is "get everything working on Apple Silicon/ARM". We're primarily a binary package manager so we're optimising for that use-case. I remember when universal binaries/libraries were all the rage on PPC/x86 and then x86/x86_64 and they caused us no end of pain. I'd rather we avoid that pain as long as possible.

claui

comment created time in a day

Pull request review commentHomebrew/brew

Utils::Bottles::tag: ARM tag is arm64_big_sur

 class << self       undef tag        def tag-        tag = MacOS.version.to_sym-        tag = "#{tag}_arm".to_sym if Hardware::CPU.arm?-        tag+        if Hardware::CPU.intel?+          MacOS.version.to_sym+        else+          "#{ENV["HOMEBREW_PROCESSOR"]}_#{MacOS.version}".to_sym

Given that I wonder about using one of the terms they actually use? Can you summarise them at all @claui?

sjackman

comment created time in a day

Pull request review commentHomebrew/brew

Utils::Bottles::tag: ARM tag is arm64_big_sur

 class << self       undef tag        def tag-        tag = MacOS.version.to_sym-        tag = "#{tag}_arm".to_sym if Hardware::CPU.arm?-        tag+        if Hardware::CPU.intel?+          MacOS.version.to_sym+        else+          "#{ENV["HOMEBREW_PROCESSOR"]}_#{MacOS.version}".to_sym

Thanks! In that case:

          "#{ENV["HOMEBREW_PROCESSOR"]}_#{MacOS.version.to_sym}".to_sym

At least so we're not referring to it as 11.0 (which isn't even a "valid" symbol).

Does Apple refer to it as ARM64 much/at all?

sjackman

comment created time in a day

issue commentHomebrew/brew

macOS 10.16/11.0 Big Sur compatibility

Shared libraries should always be fat, by the way.

We're not going to do this.

claui

comment created time in a day

Pull request review commentHomebrew/brew

License forbidden

 def puts_requirement_messages      $stderr.puts @requirement_messages   end++  def forbidden_license_check+    forbidden_licenses = (Homebrew::EnvConfig.forbidden_licenses || "").split(" ")
    forbidden_licenses = Homebrew::EnvConfig.forbidden_licenses.to_s.split(" ")
lionellloh

comment created time in a day

pull request commentHomebrew/brew

python_virtualenv_constants: upgrade virtualenv to 20.0.26

Thanks @Bo98 and @vladimyr.

@vladimyr Check your email! I replied to your one and haven't seen a reply yet.

lembacon

comment created time in a day

pull request commentHomebrew/linuxbrew-core

rubberband: depend on openjdk

Looks like on_macos and on_linux can't be used in the install method.

My bad, we talked about supporting this but I guess it doesn't work yet. Suggested new PR for you, @Rylan12 😁

Rylan12

comment created time in a day

Pull request review commentHomebrew/brew

Allow references to casks when running upgrade and outdated

 def upgrade           opoo "#{f.full_specified_name} #{version} already installed"         end       end-      return if outdated.empty?     end +    return if outdated.empty?
    return if outdated.blank?
whoiswillma

comment created time in a day

Pull request review commentHomebrew/brew

Allow references to casks when running upgrade and outdated

 def outdated_args       flag   "--json",              description: "Print output in JSON format. Currently the default and only accepted "\                           "value for <version> is `v1`. See the docs for examples of using the JSON "\-                          "output: <https://docs.brew.sh/Querying-Brew>"+                          "output: <https://docs.brew.sh/Querying-Brew>. "\+                          "By default, this option treats all arguments as formulae. "\+                          "To treat arguments as casks, use the --cask-only option."       switch "--fetch-HEAD",              description: "Fetch the upstream repository to detect if the HEAD installation of the "\                           "formula is outdated. Otherwise, the repository's HEAD will only be checked for "\                           "updates when a new stable or development version has been released."+      switch "--greedy",+             description: "Print outdated casks with `auto_updates` or `version :latest`"+      switch "--formula",+             description: "Treat all arguments as formulae"+      switch "--cask",+             description: "Treat all arguments as casks"       switch :debug       conflicts "--quiet", "--verbose", "--json"+      conflicts "--formula-only", "--cask-only"     end   end    def outdated     outdated_args.parse -    formulae = if args.resolved_formulae.blank?-      Formula.installed-    else-      args.resolved_formulae-    end+    formula_only = args.formula?     if args.json       raise UsageError, "invalid JSON version: #{args.json}" unless ["v1", true].include? args.json -      outdated = print_outdated_json(formulae)+      # When user asks for json, print json for formula only unless the user explicitly asks for casks+      formula_only = !args.cask?+    end++    if formula_only+      formulae = args.resolved_formulae.blank? ? Formula.installed : args.resolved_formulae
      formulae = args.resolved_formulae.presence || Formula.installed
whoiswillma

comment created time in a day

Pull request review commentHomebrew/brew

Allow references to casks when running upgrade and outdated

 def outdated_args       flag   "--json",              description: "Print output in JSON format. Currently the default and only accepted "\                           "value for <version> is `v1`. See the docs for examples of using the JSON "\-                          "output: <https://docs.brew.sh/Querying-Brew>"+                          "output: <https://docs.brew.sh/Querying-Brew>. "\+                          "By default, this option treats all arguments as formulae. "\+                          "To treat arguments as casks, use the --cask-only option."       switch "--fetch-HEAD",              description: "Fetch the upstream repository to detect if the HEAD installation of the "\                           "formula is outdated. Otherwise, the repository's HEAD will only be checked for "\                           "updates when a new stable or development version has been released."+      switch "--greedy",+             description: "Print outdated casks with `auto_updates` or `version :latest`"+      switch "--formula",+             description: "Treat all arguments as formulae"+      switch "--cask",+             description: "Treat all arguments as casks"       switch :debug       conflicts "--quiet", "--verbose", "--json"+      conflicts "--formula-only", "--cask-only"     end   end    def outdated     outdated_args.parse -    formulae = if args.resolved_formulae.blank?-      Formula.installed-    else-      args.resolved_formulae-    end+    formula_only = args.formula?     if args.json       raise UsageError, "invalid JSON version: #{args.json}" unless ["v1", true].include? args.json -      outdated = print_outdated_json(formulae)+      # When user asks for json, print json for formula only unless the user explicitly asks for casks+      formula_only = !args.cask?+    end++    if formula_only
    outdated = if formula_only

then you can remove the outdated assignments

whoiswillma

comment created time in a day

Pull request review commentHomebrew/brew

Allow references to casks when running upgrade and outdated

 def outdated_args       flag   "--json",              description: "Print output in JSON format. Currently the default and only accepted "\                           "value for <version> is `v1`. See the docs for examples of using the JSON "\-                          "output: <https://docs.brew.sh/Querying-Brew>"+                          "output: <https://docs.brew.sh/Querying-Brew>. "\+                          "By default, this option treats all arguments as formulae. "\+                          "To treat arguments as casks, use the --cask-only option."       switch "--fetch-HEAD",              description: "Fetch the upstream repository to detect if the HEAD installation of the "\                           "formula is outdated. Otherwise, the repository's HEAD will only be checked for "\                           "updates when a new stable or development version has been released."+      switch "--greedy",+             description: "Print outdated casks with `auto_updates` or `version :latest`"+      switch "--formula",+             description: "Treat all arguments as formulae"+      switch "--cask",+             description: "Treat all arguments as casks"       switch :debug       conflicts "--quiet", "--verbose", "--json"+      conflicts "--formula-only", "--cask-only"     end   end    def outdated     outdated_args.parse -    formulae = if args.resolved_formulae.blank?-      Formula.installed-    else-      args.resolved_formulae-    end+    formula_only = args.formula?     if args.json       raise UsageError, "invalid JSON version: #{args.json}" unless ["v1", true].include? args.json -      outdated = print_outdated_json(formulae)+      # When user asks for json, print json for formula only unless the user explicitly asks for casks+      formula_only = !args.cask?+    end++    if formula_only+      formulae = args.resolved_formulae.blank? ? Formula.installed : args.resolved_formulae+      outdated = print_outdated_formulae(formulae)+    elsif args.cask?+      casks = args.named.blank? ? Cask::Caskroom.casks : args.named
      casks = args.named.presence || Cask::Caskroom.casks
whoiswillma

comment created time in a day

Pull request review commentHomebrew/brew

Allow references to casks when running upgrade and outdated

 def outdated_args       flag   "--json",              description: "Print output in JSON format. Currently the default and only accepted "\                           "value for <version> is `v1`. See the docs for examples of using the JSON "\-                          "output: <https://docs.brew.sh/Querying-Brew>"+                          "output: <https://docs.brew.sh/Querying-Brew>. "\+                          "By default, this option treats all arguments as formulae. "\+                          "To treat arguments as casks, use the --cask-only option."
                          "To treat arguments as casks, use the --cask option."
whoiswillma

comment created time in a day

pull request commentHomebrew/brew

Make Homebrew work with Xcode 12 Beta 2 on Apple Silicon

Thanks for the fix @claui!

claui

comment created time in a day

pull request commentHomebrew/brew

Revert #7933 ("sorbet: set utils/git.rb to true")

Thanks @issyl0!

issyl0

comment created time in a day

push eventHomebrew/brew

Issy Long

commit sha 2c3b2f68cd2b22e08b8841cc4de3d67593284b9f

Revert #7933 ("sorbet: set utils/git.rb to true") - My refactoring of #7933 went wrong in that the tests passed for `brew extract` and my manual testing, but both forgot about third-party taps exist, so that functionality broke as follows (courtesy of Misty). Before: ``` # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"]) => ["ac0665d", ["README.md"]] ``` After: ``` # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"]) => [nil, []] ``` - While we think about how to do splats in Sorbet, revert this so that users are able to `brew extract` from third party taps again. - A TODO for later in a separate PR is to write a test for `brew extract` that tests the behaviour of third-party taps. --- - Reverted this manually because the GitHub UI couldn't do it. - Arguably I didn't need to remove the RBI file, but it's easier to have everything gone for now and then revert this revert in future once we have a strategy for dealing with splats in Sorbet than have inconsistency.

view details

Mike McQuaid

commit sha 146eca4608e93f0ec95ea03e13c15071c86ca8bb

Merge pull request #7951 from issyl0/revert-7933 Revert #7933 ("sorbet: set utils/git.rb to true")

view details

push time in a day

PR merged Homebrew/brew

Revert #7933 ("sorbet: set utils/git.rb to true")
  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

  • My refactoring of #7933 went wrong in that the tests passed for brew extract and my manual testing, but both forgot about third-party taps exist, so that functionality broke as follows (courtesy of Misty).

    Before:

    # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"])
    => ["ac0665d", ["README.md"]]
    

    After:

    # Git.last_revision_commit_of_files("/usr/local/Homebrew", ["LICENSE.txt", "README.md"])
    => [nil, []]
    
  • While we think about how to do splats in Sorbet, revert this so that users are able to brew extract from third party taps again.

  • A TODO for later in a separate PR is to write a test for brew extract that tests the behaviour of third-party taps.


  • Reverted this manually because the GitHub UI couldn't do it.
  • Arguably I didn't need to remove the RBI file, but it's easier to have everything gone for now and then revert this revert in future once we have a strategy for dealing with splats in Sorbet than have inconsistency.
+2 -17

0 comment

3 changed files

issyl0

pr closed time in a day

pull request commentHomebrew/brew

update: delete python from cellar

(I'll try to take a look today)

iMichka

comment created time in a day

pull request commentHomebrew/brew

update: delete python from cellar

We can also put this operation in the postinstall block of the python@3.8 formula. This is something we have already done to cleanup files from the system.

@iMichka That seems like an acceptable workaround but I think we still have to handle the case for users who have already installed it (and for future formulae taking this approach).

iMichka

comment created time in a day

issue commentHomebrew/brew

Homebrew picks Xcode from /Volumes/Macintosh HD on multi-partition/system

Im simply pointing out that homebrew is picking up Xcode from other system.

Ok, in this case: this is intentional behaviour.

jozefvaclavik

comment created time in a day

Pull request review commentHomebrew/brew

Utils::Bottles::tag: ARM tag is arm64_big_sur

 class << self       undef tag        def tag-        tag = MacOS.version.to_sym-        tag = "#{tag}_arm".to_sym if Hardware::CPU.arm?-        tag+        if Hardware::CPU.intel?+          MacOS.version.to_sym+        else+          "#{ENV["HOMEBREW_PROCESSOR"]}_#{MacOS.version}".to_sym

Just to keep up with the most recent conversation: what does this output on Apple Silicon, currently? What does it output on Linux-on-ARM?

sjackman

comment created time in a day

Pull request review commentHomebrew/brew

Allow references to casks when running upgrade and outdated

 def outdated_args       flag   "--json",              description: "Print output in JSON format. Currently the default and only accepted "\                           "value for <version> is `v1`. See the docs for examples of using the JSON "\-                          "output: <https://docs.brew.sh/Querying-Brew>"+                          "output: <https://docs.brew.sh/Querying-Brew>. "\+                          "By default, this option treats all arguments as formulae. "\+                          "To treat arguments as casks, use the --cask-only option."       switch "--fetch-HEAD",              description: "Fetch the upstream repository to detect if the HEAD installation of the "\                           "formula is outdated. Otherwise, the repository's HEAD will only be checked for "\                           "updates when a new stable or development version has been released."+      switch "--greedy",+             description: "Print outdated casks with `auto_updates` or `version :latest`"+      switch "--formula-only",+             description: "Treat all arguments as formulae"+      switch "--cask-only",+             description: "Treat all arguments as casks"       switch :debug       conflicts "--quiet", "--verbose", "--json"+      conflicts "--formula-only", "--cask-only"     end   end    def outdated     outdated_args.parse -    formulae = if args.resolved_formulae.blank?-      Formula.installed-    else-      args.resolved_formulae-    end     if args.json       raise UsageError, "invalid JSON version: #{args.json}" unless ["v1", true].include? args.json+    end -      outdated = print_outdated_json(formulae)+    if args.formula_only? || !args.cask_only? && args.json

Sorry, I mean: can you add parentheses somewhere here 😁

whoiswillma

comment created time in 2 days

Pull request review commentHomebrew/brew

Allow references to casks when running upgrade and outdated

 def outdated_args       flag   "--json",              description: "Print output in JSON format. Currently the default and only accepted "\                           "value for <version> is `v1`. See the docs for examples of using the JSON "\-                          "output: <https://docs.brew.sh/Querying-Brew>"+                          "output: <https://docs.brew.sh/Querying-Brew>. "\+                          "By default, this option treats all arguments as formulae. "\+                          "To treat arguments as casks, use the --cask-only option."       switch "--fetch-HEAD",              description: "Fetch the upstream repository to detect if the HEAD installation of the "\                           "formula is outdated. Otherwise, the repository's HEAD will only be checked for "\                           "updates when a new stable or development version has been released."+      switch "--greedy",+             description: "Print outdated casks with `auto_updates` or `version :latest`"+      switch "--formula-only",+             description: "Treat all arguments as formulae"+      switch "--cask-only",+             description: "Treat all arguments as casks"       switch :debug       conflicts "--quiet", "--verbose", "--json"+      conflicts "--formula-only", "--cask-only"     end   end    def outdated     outdated_args.parse -    formulae = if args.resolved_formulae.blank?-      Formula.installed-    else-      args.resolved_formulae-    end     if args.json       raise UsageError, "invalid JSON version: #{args.json}" unless ["v1", true].include? args.json+    end -      outdated = print_outdated_json(formulae)+    if args.formula_only? || !args.cask_only? && args.json
    if (args.formula_only? || !args.cask_only?) && args.json

(assuming that's correct)

whoiswillma

comment created time in 2 days

Pull request review commentHomebrew/brew

License forbidden

 def puts_requirement_messages      $stderr.puts @requirement_messages   end++  def env_forbidden_licenses+    Homebrew::EnvConfig.forbidden_licenses.split(" ")+  end++  def forbidden_license_check(f)+    return if ENV["HOMEBREW_FORBIDDEN_LICENSES"].blank?++    forbidden_licenses = env_forbidden_licenses++    if forbidden_licenses.include? f.license+      raise CannotInstallFormulaError, <<~EOS+        #{f.name} has a forbidden license #{f.license}.+      EOS+    end++    fi = FormulaInstaller.new(f)+    fi.compute_dependencies.each do |dep, _|
    compute_dependencies.each do |dep, _|
lionellloh

comment created time in 2 days

Pull request review commentHomebrew/brew

License forbidden

 def puts_requirement_messages      $stderr.puts @requirement_messages   end++  def env_forbidden_licenses+    Homebrew::EnvConfig.forbidden_licenses.split(" ")+  end++  def forbidden_license_check(f)+    return if ENV["HOMEBREW_FORBIDDEN_LICENSES"].blank?++    forbidden_licenses = env_forbidden_licenses++    if forbidden_licenses.include? f.license+      raise CannotInstallFormulaError, <<~EOS+        #{f.name} has a forbidden license #{f.license}.+      EOS+    end
    if forbidden_licenses.include? formula.license
      raise CannotInstallFormulaError, <<~EOS
        #{formula.name} has a forbidden license #{formula.license}.
      EOS
    end
lionellloh

comment created time in 2 days

Pull request review commentHomebrew/brew

License forbidden

 def puts_requirement_messages      $stderr.puts @requirement_messages   end++  def env_forbidden_licenses+    Homebrew::EnvConfig.forbidden_licenses.split(" ")+  end++  def forbidden_license_check(f)+    return if ENV["HOMEBREW_FORBIDDEN_LICENSES"].blank?++    forbidden_licenses = env_forbidden_licenses
  def forbidden_license_check
    forbidden_licenses = Homebrew::EnvConfig.forbidden_licenses.split(" ")
    return if forbidden_licenses.blank?
lionellloh

comment created time in 2 days

Pull request review commentHomebrew/brew

License forbidden

 module EnvConfig         description: "Output this many lines of output on formula `system` failures.",         default:     15,       },+      HOMEBREW_FORBIDDEN_LICENSES:        {+        description: "Use this environment variable to define a blacklist of space separated licenses and Homebrew " \
        description: "Use this environment variable to define a denylist of space separated licenses and Homebrew " \
lionellloh

comment created time in 2 days

pull request commentHomebrew/homebrew-cask

workflows/style: run `brew cask style`.

Run failed for master (0dadf1e)

Got an email notification about this. That's super odd/confusing because it isn't the actual commit I made. Any reason this isn't part of the CI actions job?

MikeMcQuaid

comment created time in 2 days

PR opened Homebrew/homebrew-cask

ditworkflows/style: run `brew cask style`.

Do this for all casks instead of a single cask.

As-of https://github.com/Homebrew/brew we will need to ensure that this never fails to avoid breaking Homebrew/brew CI (and vice versa).

+1 -10

0 comment

1 changed file

pr created time in 2 days

create barnchHomebrew/homebrew-cask

branch : brew-cask-style

created branch time in 2 days

Pull request review commentHomebrew/linuxbrew-core

rubberband: add java dependency to use JAVA_HOME

 class Rubberband < Formula   depends_on "pkg-config" => :build   depends_on "libsamplerate"   depends_on "libsndfile"-  unless OS.mac?+  on_macos do
  on_linux do

because I can't unless 😭

Rylan12

comment created time in 2 days

pull request commentHomebrew/brew

Unify (mostly) Homebrew code style

@vitorgalvao et. al: this has been updated to have a (more) consistent style between Homebrew/brew, casks and formulae. The fixtures are the best place to look here to see the cask style. Once we're 👍 on this approach: I'll mass update homebrew-core and homebrew-cask and push directly to them (without PRs).

MikeMcQuaid

comment created time in 2 days

push eventMikeMcQuaid/brew

Mike McQuaid

commit sha 16f304c3e01203005b72338ba81aff585dd73e75

workflows/doctor: add macOS `brew doctor` CI. When we change any of the files related to `brew doctor` or Xcode versions ensure that we test them on the macOS self-hosted workers so we don't merge changes here that break `brew doctor` there.

view details

Sean Molenaar

commit sha 3f6d3e5cf0abea0c10c4efbdc245e76131fd7ebd

Support casks in readall

view details

William Ma

commit sha cbfea6c125247fa302b11c3062df570d5847501a

args: Add field for kegs and unknowns

view details

William Ma

commit sha 90c26dadc7ec5021716fc0674b4b8b8dd8965293

uninstall: Add ability to reference casks from brew uninstall

view details

William Ma

commit sha 16f16f3a383b8094c25ec97441c5944c7aee735a

uninstall: Add test for uninstalling cask

view details

William Ma

commit sha 5900263cabb8cb653ea698ea89990cf134afb3d1

args: Add resolved_formulae_and_unknowns

view details

William Ma

commit sha d1004c81430d6b893ff487a32b9c4fe70131a943

reinstall: Add ability to reference casks from brew reinstall

view details

William Ma

commit sha e733fa16a2365003d94d1fa7eccaa1f2adfcf324

uninstall: Refactor to use AbstractCommand instead of declaring a class method

view details

William Ma

commit sha f03336bb4077f5dd0c71f44088ed29ec638749e4

uninstall: Clean up cask-appdir after tests

view details

William Ma

commit sha 1044cb91c3409ec21f8c15b1016581d90e4dde07

Merge branch 'master' into integrate-uninstall-reinstall

view details

William Ma

commit sha 4dc2df6e6a8c69365a0990bba707bf81c8e2eb7f

uninstall: Run cask uninstall tests only on macos

view details

Rylan Polster

commit sha d921e94a2b72aaa6b6232a13c045d62578e29dfe

rubocop: separate args for shell commands Use `system "foo", "bar"` instead of `system "foo bar"`. Also applies to `Utils.popen_read` and `Utils.popen_write` commands. RuboCop can automatically fix these problems.

view details

Rylan Polster

commit sha 35a8c336902d9a18be81d16981da35724e94e19b

Update shell metacharacter list

view details

William Ma

commit sha 8a05b5258a23125bd4cbadb8a8c8bb15f8ff3e96

args: Refactor to load casks directly

view details

William Ma

commit sha dff61c9eab54f21329e537b8d7c34a9671805db7

style: Fix style issues

view details

William Ma

commit sha f3ae2fdfdc6adf14285f99d55af5592810cacd55

reinstall: Replace with more specific imports

view details

William Ma

commit sha bb939323a7e7bf9abb64c54d1cd05d578b3b4c98

Merge branch 'master' into integrate-uninstall-reinstall

view details

William Ma

commit sha 72dcbd6fda2c884f54edd0ded42bcfed2f276342

style: Dedent cask uninstall block

view details

William Ma

commit sha ac5f0c10e5a4fa9ab0397f58d2a9cf683e22ef27

style: Dedent some autoformatted code in uninstall test case

view details

Mike McQuaid

commit sha 7d53104c4680dc24a0f1398e79ce296052ea85e1

cmd/search_spec: split Linux/macOS tests.

view details

push time in 2 days

pull request commentHomebrew/brew

tab: add built_on information

@sjackman Good to go with this (I think @Bo98?) once you're 👍.

Bo98

comment created time in 2 days

pull request commentHomebrew/linuxbrew-core

rubberband: add java dependency to use JAVA_HOME

Ideally they'd all be in on_macos blocks.

Rylan12

comment created time in 2 days

Pull request review commentHomebrew/brew

Audit --> RuboCop migration

 def audit_formula(_node, _class_node, _parent_class_node, body_node)               problem "Do not concatenate paths in string interpolation"             end           end++          find_strings(body_node).each do |n|+            next unless regex_match_group(n, /JAVA_HOME/i)++            next if @formula_name.match?(/^openjdk(@|$)/)++            next if find_every_method_call_by_name(body_node, :depends_on).any? do |dependency|+              dependency.each_descendant(:str).count.zero? ||+              regex_match_group(dependency.each_descendant(:str).first, /^openjdk(@|$)/) ||+              depends_on?(:java)+            end

Sorry, missed that! I wonder why that isn't just depends_on "openjdk"? Maybe it could/should be?

Rylan12

comment created time in 2 days

Pull request review commentHomebrew/brew

Audit --> RuboCop migration

 def audit_formula(_node, _class_node, _parent_class_node, body_node)               problem "Do not concatenate paths in string interpolation"             end           end++          find_strings(body_node).each do |n|+            next unless regex_match_group(n, /JAVA_HOME/i)++            next if @formula_name.match?(/^openjdk(@|$)/)++            next if find_every_method_call_by_name(body_node, :depends_on).any? do |dependency|+              dependency.each_descendant(:str).count.zero? ||+              regex_match_group(dependency.each_descendant(:str).first, /^openjdk(@|$)/) ||+              depends_on?(:java)+            end

adoptopenjdk is a cask so can't be depended on. Not sure where you saw this, I'm maybe missing something here?

Rylan12

comment created time in 2 days

Pull request review commentHomebrew/homebrew-core

Update Contributing.md

 brew style foo ```  After testing, if you think it is needed to force the corresponding bottles to be-rebuilt and redistributed, add a line of the form `revision 1` to the formula,-or add 1 to the revision number already present.+rebuilt and redistributed, add a line of the form `revision 1` to the formula above the `head` line,

Yeh, it feels like it makes more sense earlier. I like the idea of just recommending brew style --fix before committing 👍

cortices

comment created time in 2 days

pull request commentgithub/opensource.guide

Update translation for portuguese

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @finhaa!

finhaa

comment created time in 2 days

push eventgithub/opensource.guide

Rafael Farias Lima

commit sha 3426d2b5b2fc6bd6ed491c9c0916104779468825

Update translation for portuguese

view details

Mike McQuaid

commit sha df9681502e36f1fb1209f6cd41b441c55ffaca7e

Merge pull request #1702 from finhaa/master Update translation for portuguese

view details

push time in 2 days

PR merged github/opensource.guide

Update translation for portuguese
  • [x] Have you followed the contributing guidelines?
  • [x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Just a little modification in translation for portuguese to get that more friendly. It isn't a spell check, but a more cultural adjustment since we are not in the habit of saying "leave something in a better place than when you found it", but "leave something better than when you found it"

+1 -1

0 comment

1 changed file

finhaa

pr closed time in 2 days

push eventHomebrew/brew

Chongyu Zhu

commit sha 6dbcf83a21d36a0c03990a923cc07ef4a06e4e7f

python_virtualenv_constants: upgrade virtualenv to 20.0.26

view details

Mike McQuaid

commit sha d5123743b68eb770f72c6a0899999b11224873ef

Merge pull request #7941 from lembacon/virtualenv-20.0.26 python_virtualenv_constants: upgrade virtualenv to 20.0.26

view details

push time in 2 days

pull request commentHomebrew/brew

python_virtualenv_constants: upgrade virtualenv to 20.0.26

Thanks @lembacon!

lembacon

comment created time in 2 days

PR merged Homebrew/brew

python_virtualenv_constants: upgrade virtualenv to 20.0.26
  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [ ] Have you successfully run brew style with your changes locally?
  • [ ] Have you successfully run brew tests with your changes locally?

+4 -4

0 comment

1 changed file

lembacon

pr closed time in 2 days

Pull request review commentHomebrew/homebrew-core

Update Contributing.md

 brew style foo ```  After testing, if you think it is needed to force the corresponding bottles to be-rebuilt and redistributed, add a line of the form `revision 1` to the formula,-or add 1 to the revision number already present.+rebuilt and redistributed, add a line of the form `revision 1` to the formula above the `head` line,

Not every formula has a head line so this is a bit confusing 🤔. Maybe we could recommend brew style --fix instead which will fix this up?

cortices

comment created time in 2 days

push eventHomebrew/brew

dependabot-preview[bot]

commit sha 47b4182c87363b4bdcb9f7d71fa48e2158a95928

build(deps): bump codecov from 0.1.17 to 0.1.19 in /Library/Homebrew Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.1.17 to 0.1.19. - [Release notes](https://github.com/codecov/codecov-ruby/releases) - [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-ruby/compare/v0.1.17...v0.1.19) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Mike McQuaid

commit sha 5168e147969ab43af23634c1052e7025cfd6f7ea

.gitignore: update codecov dependencies.

view details

Mike McQuaid

commit sha b763d29df2db6acbdc48868690b7692b6253d366

Merge pull request #7935 from Homebrew/dependabot/bundler/Library/Homebrew/codecov-0.1.19 build(deps): bump codecov from 0.1.17 to 0.1.19 in /Library/Homebrew

view details

push time in 2 days

delete branch Homebrew/brew

delete branch : dependabot/bundler/Library/Homebrew/codecov-0.1.19

delete time in 2 days

PR merged Homebrew/brew

build(deps): bump codecov from 0.1.17 to 0.1.19 in /Library/Homebrew dependencies

Bumps codecov from 0.1.17 to 0.1.19. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md">codecov's changelog</a>.</em></p> <blockquote> <h3><code>0.1.19</code></h3> <ul> <li>fix colorize</li> </ul> <h3><code>0.1.18</code></h3> <ul> <li>refactor and move to use v2 endpoint</li> <li>use Timeout::Error</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/codecov/codecov-ruby/commit/10b2ef171a80243de436e29eb9037695f3832194"><code>10b2ef1</code></a> Move colorize from Gemfile to gemspec (<a href="https://github-redirect.dependabot.com/codecov/codecov-ruby/issues/68">#68</a>)</li> <li><a href="https://github.com/codecov/codecov-ruby/commit/cded2396e4730b81fb94df9e80f6a019309e282e"><code>cded239</code></a> remove unused url dependency (<a href="https://github-redirect.dependabot.com/codecov/codecov-ruby/issues/44">#44</a>)</li> <li><a href="https://github.com/codecov/codecov-ruby/commit/76088e71a1aa27d6a89ab2e4fe3cebf392418a16"><code>76088e7</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/codecov/codecov-ruby/issues/66">#66</a> from codecov/0.1.18</li> <li><a href="https://github.com/codecov/codecov-ruby/commit/ce8681384f645428a193ef7f2a1f8993912e3f3f"><code>ce86813</code></a> Bump to 0.1.18</li> <li><a href="https://github.com/codecov/codecov-ruby/commit/021c415b37a810a69be782e31282fc722e277dab"><code>021c415</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/codecov/codecov-ruby/issues/65">#65</a> from y-yagi/use_timeout_error</li> <li><a href="https://github.com/codecov/codecov-ruby/commit/5adb7fe64892c52d6df9b9c177d81082887f423b"><code>5adb7fe</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/codecov/codecov-ruby/issues/64">#64</a> from codecov/refactor-for-v2</li> <li><a href="https://github.com/codecov/codecov-ruby/commit/2b17bd060a4d738601995c3583a59c823b3cf9a7"><code>2b17bd0</code></a> Use <code>Timeout::Error</code> instead of deprecated <code>TimeoutError</code></li> <li><a href="https://github.com/codecov/codecov-ruby/commit/e4d3622d955b070d4c9efec829c6c486332e7f86"><code>e4d3622</code></a> fix tests</li> <li><a href="https://github.com/codecov/codecov-ruby/commit/7229755ade95ae7fc5daf63bf71e3694cefb5bc7"><code>7229755</code></a> Refactor code for v2 uploads</li> <li>See full diff in <a href="https://github.com/codecov/codecov-ruby/compare/v0.1.17...v0.1.19">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+4 -4

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 2 days

push eventHomebrew/brew

vidusheeamoli

commit sha 0d58d2a46cd76b7cf3d43239b4db551ced92ec87

srb/files: add new files. 13 errors => 14 errors.

view details

vidusheeamoli

commit sha 1d2e68d184a62eb0dad72c1be4e479c008da3d61

srb/tapioca: update rbi of recently bumped gems

view details

vidusheeamoli

commit sha c8c8839ba27007cf166d9108c5986a02a3dbbfc9

sorbet: update hidden definitions srb/tapioca: update rbi of recently bumped gems

view details

dependabot-preview[bot]

commit sha 14384fc5dfb6c66a1fd29f36f28085c3a0d80dfb

build(deps): bump rubocop from 0.87.0 to 0.87.1 in /Library/Homebrew Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.87.0 to 0.87.1. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.87.0...v0.87.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Mike McQuaid

commit sha 20d28e26fe60d479b08bfa9b248f85487158eba5

Merge pull request #7934 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-0.87.1 build(deps): bump rubocop from 0.87.0 to 0.87.1 in /Library/Homebrew

view details

Issy Long

commit sha b4c171b78d310734c9ca9ac1d1754059898b2851

Merge pull request #7932 from vidusheeamoli/add-new-files sorbet/files.yaml: add new files

view details

Mike McQuaid

commit sha 7c30fadc34f28f605a70756a62c4f76acab38af1

workflows/tests: link python@3.8. Investigated a full uninstall but it takes too long (>5m).

view details

Mike McQuaid

commit sha 62643529785e0c0288c94761190584e1fd049bf9

Merge pull request #7939 from MikeMcQuaid/uninstall-formulae workflows/tests: link python@3.8.

view details

dependabot-preview[bot]

commit sha 47b4182c87363b4bdcb9f7d71fa48e2158a95928

build(deps): bump codecov from 0.1.17 to 0.1.19 in /Library/Homebrew Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.1.17 to 0.1.19. - [Release notes](https://github.com/codecov/codecov-ruby/releases) - [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md) - [Commits](https://github.com/codecov/codecov-ruby/compare/v0.1.17...v0.1.19) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Mike McQuaid

commit sha 5168e147969ab43af23634c1052e7025cfd6f7ea

.gitignore: update codecov dependencies.

view details

push time in 2 days

push eventHomebrew/brew

Mike McQuaid

commit sha 7c30fadc34f28f605a70756a62c4f76acab38af1

workflows/tests: link python@3.8. Investigated a full uninstall but it takes too long (>5m).

view details

Mike McQuaid

commit sha 62643529785e0c0288c94761190584e1fd049bf9

Merge pull request #7939 from MikeMcQuaid/uninstall-formulae workflows/tests: link python@3.8.

view details

push time in 2 days

delete branch MikeMcQuaid/brew

delete branch : uninstall-formulae

delete time in 2 days

PR merged Homebrew/brew

workflows/tests: link python@3.8.

Investigated a full uninstall but it takes too long (>5m).

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your changes? Here's an example.
  • [x] Have you successfully run brew style with your changes locally?
  • [x] Have you successfully run brew tests with your changes locally?

+3 -3

0 comment

1 changed file

MikeMcQuaid

pr closed time in 2 days

push eventMikeMcQuaid/brew

Mike McQuaid

commit sha 7c30fadc34f28f605a70756a62c4f76acab38af1

workflows/tests: link python@3.8. Investigated a full uninstall but it takes too long (>5m).

view details

push time in 2 days

push eventMikeMcQuaid/brew

Mike McQuaid

commit sha 1c50c3bac77d77972434de253a70b81b72ca7602

workflows/tests: link python@3.8. Investigated a full uninstall but it takes too long (>5m).

view details

push time in 2 days

push eventMikeMcQuaid/brew

Mike McQuaid

commit sha f38365487e5b7de923791e279ffa8fb5ad61636d

workflows/tests: remove all formulae.

view details

push time in 2 days

more