profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/MichaelAquilina/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Michael Aquilina MichaelAquilina @snyk London, United Kingdom

mackwic/colored 797

(Rust) Coloring terminal so simple you already know how to do it !

MichaelAquilina/apm-ansible 3

Manage your Atom packages using ansible

MichaelAquilina/adventofcode2018 1

My solutions to advent of code 2018 in Rust

MichaelAquilina/adventofcode2020 1

Solutions for https://adventofcode.com/2020/

MichaelAquilina/atom-better-window-title 1

Improve Atom's window title

MichaelAquilina/atom-pgp 1

:key: Atom plugin to open and save PGP encrypted files

MichaelAquilina/adventofcode2017 0

http://adventofcode.com/2017

MichaelAquilina/agnoster-zsh-theme 0

A ZSH theme designed to disclose information contextually, with a powerline aesthetic

MichaelAquilina/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.

issue commentphw/peek

Recording as webm throws error

Experiencing the same issue.

Peek version 1.5.1

ffmpeg version 4.4 Copyright (c) 2000-2021 the FFmpeg developers
  built with gcc 11 (SUSE Linux)
  configuration: --prefix=/usr --libdir=/usr/lib64 --shlibdir=/usr/lib64 --incdir=/usr/include/ffmpeg --extra-cflags='-O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -ffat-lto-objects -g' --optflags='-O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -ffat-lto-objects -g' --disable-htmlpages --enable-pic --disable-stripping --enable-shared --disable-static --enable-gpl --enable-version3 --enable-libsmbclient --disable-openssl --enable-avresample --enable-gnutls --enable-ladspa --enable-vulkan --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --enable-libcelt --enable-libcdio --enable-libcodec2 --enable-libdav1d --enable-libdc1394 --enable-libdrm --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgsm --enable-libjack --enable-libmp3lame --enable-libmysofa --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librav1e --enable-librubberband --enable-libsvtav1 --enable-libsoxr --enable-libspeex --enable-libssh --enable-libsrt --enable-libtheora --enable-libtwolame --enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libv4l2 --enable-libvpx --enable-libwebp --enable-libxml2 --enable-libzimg --enable-libzmq --enable-libzvbi --enable-lto --enable-lv2 --enable-libmfx --enable-vaapi --enable-vdpau --enable-version3 --enable-libfdk-aac-dlopen --enable-nonfree --enable-libvo-amrwbenc --enable-libx264 --enable-libx265 --enable-librtmp --enable-libxvid
DasJott

comment created time in 3 days

pull request commentmbrn/material-table

Update Vulnerable version of jspdf package

any chance of getting this merged soon :) ?

jonathansantilli

comment created time in 5 days

startedrafaelmardojai/firefox-gnome-theme

started time in 8 days

issue commentflathub/us.zoom.Zoom

Screen share not showing windows contents on recipient's screen

I'm also experiencing this issue right now :/ has anyone found a workaround for this?

I'm running gnome 40 on openSUSE Tumbleweed

alexandrucalcatinge

comment created time in 10 days

push eventMichaelAquilina/tumbleweed-ansible

Michael Aquilina

commit sha 20e53b44a733fbcc9efe84338f406714f87acdb8

[kitty] hide window decorations

view details

push time in 10 days

pull request commentMichaelAquilina/flake8-spellcheck

Add pathlib to python.txt

Thanks @papr :)

papr

comment created time in 11 days

push eventMichaelAquilina/flake8-spellcheck

Pablo Prietz

commit sha 212acf616076d3389cf6601abc7c5338b566d58b

Add pathlib to python.txt

view details

Michael Aquilina

commit sha 60bc474f84d0e8093535d55bf186a266a9dcfac8

Merge pull request #50 from papr/patch-1 Add pathlib to python.txt

view details

push time in 11 days

issue commentMichaelAquilina/flake8-spellcheck

Whitelist names from the standard lib?

@ojomio would you like to try opening a PR that adds those into python.txt?

aileoia

comment created time in 19 days

pull request commentMichaelAquilina/zsh-autoswitch-virtualenv

Fix proposal for #149

I'm actually quite convinced that we should actually just remove these warnings.

These were just an attempt to improve the security of the plugin - but as some have pointed out before, the reality is that they are not actually that useful.

I was under the impression that I had already removed these, but it turns out I was wrong. @rnc would you like to open a PR that removes them instead?

3isenHeiM

comment created time in 21 days

startednanotee/nvim-lua-guide

started time in 24 days

push eventMichaelAquilina/django-stubs

Michael Aquilina

commit sha 008dcdbcb6c13ba6c0639b9f42b4850e7f1856d0

chore: remove excess # type: ignore comments in _ValuesQuerySet (#662)

view details

horpto

commit sha d9c63f5e71818a3e751a78bc9bca90768def63e5

fix CursorWrapper iter method (#628)

view details

Nikita Sobolev

commit sha 552f2ffc0c2481b592b9f634c245c615acf48c7f

Adds more rules to mypy config, related #662 (#663) * Adds more rules to mypy config, related #662 * Removes plugin.ini for mypy settings * Fixes build

view details

Nikita Sobolev

commit sha d5e45db79bcea6d6f4f45eacca3a2fe6e125e2e3

Better linting config (#664) * Better linting config * Applies isort on django-stubs, only style changes * Fixes black and isort compat

view details

push time in a month

pull request commentMichaelAquilina/synapse-project

Improved esperanto translation

Hi @jakubfabijan I am indeed no longer using or maintaining this project.

I must have forgotten to add a note on the README to explain this. I'll take some to do this today

jakubfabijan

comment created time in a month

delete branch MichaelAquilina/django-stubs

delete branch : chore/remove-excess-type-ignores

delete time in a month

delete branch MichaelAquilina/django-stubs

delete branch : feat/more-method-stubs

delete time in a month

pull request commenttypeddjango/django-stubs

Add more method signatures for _ValuesQuerySet

Do you have some free time to try this out? slightly_smiling_face I would love to have this ValuesQuerySet removed for good!

I'd definitely want to give it a try at the very least :) is there anything in particular I should be aware of before diving in?

MichaelAquilina

comment created time in a month

Pull request review commenttypeddjango/django-stubs

chore: remove excess # type: ignore comments in _ValuesQuerySet

 _Row = TypeVar("_Row", covariant=True) class _ValuesQuerySet(Generic[_T, _Row], Collection[_Row], Reversible[_Row], QuerySet[_T], Sized): # type: ignore     def __len__(self) -> int: ...     def __contains__(self, x: object) -> bool: ...-    def __iter__(self) -> Iterator[_Row]: ...  # type: ignore-    @overload  # type: ignore+    def __iter__(self) -> Iterator[_Row]: ...+    @overload     def __getitem__(self, i: int) -> _Row: ...     @overload     def __getitem__(self: _QS, s: slice) -> _QS: ... # type: ignore

probably makes sense to leave a comment explaining why this is needed for the next person - but wanted to check with what the best way to phrase it is

MichaelAquilina

comment created time in a month

PullRequestReviewEvent

PR opened typeddjango/django-stubs

chore: remove excess # type: ignore comments in _ValuesQuerySet

I have made things!

I noticed that a lot of # type: ignore comments (including mine) might have been added over time without really understand why they were needed.

I've left the ones that seem to cause errors. From what I can tell, this is because _ValuesQuerySet inherits both Collection[_Row] and QuerySet[_T]. Because QuerySet[_T] also inherits Collection[_T], this seems to confuse mypy:

Cannot determine consistent method resolution order (MRO) for "_ValuesQuerySet"

<!-- Hi, thanks for submitting a Pull Request. We appreciate it.

Please, fill in all the required information to make our review and merging processes easier.

Cheers! -->

Related issues

<!-- Mark what issues this Pull Request closes or references.

Format is:

  • Closes #issue-number
  • Refs #issue-number

Example. Refs #0 Documentation: https://blog.github.com/2013-05-14-closing-issues-via-pull-requests/ -->

<!-- If you have any feedback, just write it here.

It can be whatever you want! -->

+11 -11

0 comment

1 changed file

pr created time in a month

create barnchMichaelAquilina/django-stubs

branch : chore/remove-excess-type-ignores

created branch time in a month

push eventMichaelAquilina/django-stubs

Michael Aquilina

commit sha 13c620f572f67c768d9099f8fd3d824184f6881c

chore: remove unused class stubs from query.pyi (#660)

view details

Michael Aquilina

commit sha 5c3ce171b20804c990c1dcbffaf4c40940e5add0

Add more method signatures for _ValuesQuerySet (#661)

view details

push time in a month

startedtypeddjango/django-stubs

started time in a month

Pull request review commenttypeddjango/django-stubs

Add more method signatures for _ValuesQuerySet

 -   case: values_list_supports_queryset_methods     main: |         from myapp.models import MyUser+        from django.db.models.functions import Length         query = MyUser.objects.values_list('name')         reveal_type(query.order_by("name").get())  # N: Revealed type is "Tuple[builtins.str]"         reveal_type(query.distinct("name").get()) # N: Revealed type is "Tuple[builtins.str]"         reveal_type(query.distinct().get()) # N: Revealed type is "Tuple[builtins.str]"         reveal_type(query.all().get()) # N: Revealed type is "Tuple[builtins.str]"+        reveal_type(query.filter(age__gt=16).get()) # N: Revealed type is "Tuple[builtins.str]"+        reveal_type(query.exclude(age__lte=16).get()) # N: Revealed type is "Tuple[builtins.str]"+        reveal_type(query.annotate(name_length=Length("name")).get()) # N: Revealed type is "Any"

might be worth checking this one is correct - I wasnt 100% sure about the approach for annotate

MichaelAquilina

comment created time in a month

PullRequestReviewEvent

PR opened typeddjango/django-stubs

Add more method signatures for _ValuesQuerySet

I have made things!

Follow up from #657 - I found more cases in my codebase where method signatures where incorrectly missing.

Looking at https://github.com/typeddjango/django-stubs/issues/608 it seems like this issue has been discussed at length already about why this is an issue.

My initial thoughts was that maybe there was a way of having:

  • an internal _QuerySet[_T, _Row] type
  • an external facing alias QuerySet[_T] which is equivalent to _QuerySet[_T, _T]
  • values list would then return _QuerySet[_T, _Row] as appropriate.

But based on the conversation you've had it seems like this might be harder than I assume it is?

The downside of keeping it in the current way is that we essentially need to redefine all QuerySet method signatures twice: Once for QuerySet and once for _ValuesQuerySet

<!-- Hi, thanks for submitting a Pull Request. We appreciate it.

Please, fill in all the required information to make our review and merging processes easier.

Cheers! -->

Related issues

<!-- Mark what issues this Pull Request closes or references.

Format is:

  • Closes #issue-number
  • Refs #issue-number

Example. Refs #0 Documentation: https://blog.github.com/2013-05-14-closing-issues-via-pull-requests/ -->

<!-- If you have any feedback, just write it here.

It can be whatever you want! -->

+7 -0

0 comment

2 changed files

pr created time in a month

create barnchMichaelAquilina/django-stubs

branch : feat/more-method-stubs

created branch time in a month

delete branch MichaelAquilina/django-stubs

delete branch : chore/cleanup-unused-stubs

delete time in a month

PR opened typeddjango/django-stubs

chore: remove unused class stubs from query.pyi

I have made things!

Cleanup what appear to be unused class stubs.

Follow up from #657

<!-- Hi, thanks for submitting a Pull Request. We appreciate it.

Please, fill in all the required information to make our review and merging processes easier.

Cheers! -->

Related issues

<!-- Mark what issues this Pull Request closes or references.

Format is:

  • Closes #issue-number
  • Refs #issue-number

Example. Refs #0 Documentation: https://blog.github.com/2013-05-14-closing-issues-via-pull-requests/ -->

<!-- If you have any feedback, just write it here.

It can be whatever you want! -->

+0 -18

0 comment

1 changed file

pr created time in a month

create barnchMichaelAquilina/django-stubs

branch : chore/cleanup-unused-stubs

created branch time in a month

push eventMichaelAquilina/django-stubs

David Szotten

commit sha 739b1711a9df342fd9e53efbbf982db917723e7a

Use `Sequence` instead of `List` for `path` param (#659) Unlike `List`, which is invariant, `Sequence` is covariant, which lets `path` accept lists of subsets of the `Union` as well. I believe this is safe, as django doesn't mutate this input. I found [this comment](https://github.com/python/mypy/issues/3351#issuecomment-300447832) helpful

view details

Michael Aquilina

commit sha ded66f6937552f773524d12d101106cf99f6e344

Add distinct, order_by and all method signatures for _ValuesQuerySet (#657)

view details

push time in a month