profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/MaxDesiatov/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Max Desiatov MaxDesiatov Cambridge, United Kingdom https://desiatov.com Software consultant, mostly coding for iOS and web in Swift and TypeScript. I co-maintain @SwiftWasm and @TokamakUI.

apple/swift 57265

The Swift Programming Language

apple/swift-package-manager 8486

The Package Manager for the Swift Programming Language

apple/swift-corelibs-foundation 4404

The Foundation Project, providing core utilities, internationalization, and OS independence

apple/sourcekit-lsp 2393

Language Server Protocol implementation for Swift and C-based languages

CoreOffice/CoreXLSX 543

Excel spreadsheet (XLSX) format parser written in pure Swift

apple/swift-tools-support-core 253

Contains common infrastructural code for both SwiftPM and llbuild.

akkyie/WAKit 33

WebAssembly Runtime written in Swift.

JadenGeller/Axiomatic 29

Swift unification framework for logic programming

CoreOffice/OLEKit 9

Swift support for Microsoft OLE2 (also known as Structured Storage or Compound File Binary Format)

startedfacebook/fishhook

started time in 3 hours

push eventMaxDesiatov/Kara

Max Desiatov

commit sha 9e792a49e253332f45726a948653dfa535afed36

Implement function case in `jsDeclarationCodegen`

view details

push time in 5 hours

create barnchMaxDesiatov/Kara

branch : js-codegen

created branch time in 6 hours

push eventMaxDesiatov/Lite

Max Desiatov

commit sha 6468e62bd7f109ba7318389534287d88dd7322a3

Use `main` branch of TSC

view details

push time in 8 hours

startedkewlbear/YoutubeDL-iOS

started time in 11 hours

push eventMaxDesiatov/Kara

Max Desiatov

commit sha 4b3a2106d184ddc900ec82cffb30755212ffd7ea

Fix remaining tests

view details

push time in 12 hours

push eventMaxDesiatov/Kara

Max Desiatov

commit sha 12f3b315f266d09ee0ee74a4cfbd8a9177c500ae

Fix most of the tests

view details

push time in 14 hours

PullRequestReviewEvent

push eventMaxDesiatov/Kara

Max Desiatov

commit sha 90ff7028f5d02c5441081af3c0b17b4eff5b0a8f

Add comments for the `DelimitedSequence` type

view details

push time in a day

push eventMaxDesiatov/Kara

Max Desiatov

commit sha 75f486cbed05169730c4253bed3d01b0cb6d7ba2

Re-enable remaining parsers, refactor `IfThenElse`

view details

push time in a day

push eventMaxDesiatov/Kara

Max Desiatov

commit sha 713b7e959c7755c3754a53c3e8f8c393f8c00da2

Convert `Expr` and `Type` to `SyntaxNode`

view details

push time in a day

push eventapple/swift

Max Desiatov

commit sha a723e6d4c233c654a58ab5900f98361bd45ae0fe

CMake: disable libdispatch when targeting Wasm/WASI (#39274) Wasm/WASI doesn't currently support multi-threading, and libdispatch should be disabled when building for this target. Related to SR-12097.

view details

push time in a day

delete branch apple/swift

delete branch : maxd/wasi-libdispatch

delete time in a day

PR merged apple/swift

CMake: disable libdispatch when targeting Wasm/WASI

Wasm/WASI doesn't currently support multi-threading, and libdispatch should be disabled when building for this target.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: --> Related to SR-12097.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+2 -1

1 comment

1 changed file

MaxDesiatov

pr closed time in a day

push eventswiftwasm/swift

LucianoAlmeida

commit sha c3c1e6df8df638632a054bf9df2f30751f2db759

[Benchmarks][stdlib] Adding an extra benchmark for set isDisjoint for disjoint sets of different size

view details

Doug Gregor

commit sha 5b027ca456bd4fdda36f7c2769d55ab102d6e24c

Back-deploy creation of global-actor-qualified function type metadata. When back-deploying, create global-actor-qualified function types via a separate entrypoint (`swift_getFunctionTypeMetadataGlobalActorBackDeploy`) in the compatibility library, which checks whether it is running with a new-enough runtime to use `swift_getFunctionTypeMetadataGlobalActor`. Failing that, it calls into a separate copy of the implementation that exists only in the back-deployed concurrency library. Fixes rdar://79153988.

view details

Nate Chandler

commit sha d002471784f911eef5dfcb9a1af36fe67e164bfa

Added -enable-experimental-defined-lifetimes. The new flag will guard work on the experimental implementation of tracking lexical lifetimes in SIL.

view details

Nate Chandler

commit sha a0c47cb32eb1d5d5c40900f2456b3e95e17b5e52

[SILGen] Emitted [defined] borrow scopes for lets. When -enable-experimental-defined-lifetimes is passed, SILGen emits lexical scopes for lets.

view details

Doug Gregor

commit sha 128257f83fcf8f4ff376279f040b5a0c7cfa31d5

Consistently use `dlsym` for finding global-actor-qualified function builder

view details

Thomas

commit sha 9ea48da9cc755e61c134efbc0502a64cbe613a98

Shouldn't this be labeled as a C++ file?

view details

Evan Wilde

commit sha ddf210b44919a3db9d38ced30f8eed6a80c82142

Disabling arm64e testing in two tests I wasn't aware that arm64e was a thing in open-source, but these two tests are failing on Apple Silicon both on the main branch and on the rebranch branch, so I'm disabling it for now. The failing tests are: - ModuleInterface/arm64e-fallback.swift - stdlib/Reflection_objc.swift

view details

Doug Gregor

commit sha d6a0b937e40171c7c360acfdf1a909abf04d89ee

Add test for `@Sendable` inference through an optional type. We previously had a bug where `@Sendable` would not be propagated to a closure when that closure was assigned to a property or passed to a parameter of optional `@Sendable` function type. This has already been fixed in the type checker, but add a test to ensure that we don't regress this behavior. rdar://77789778

view details

Boris Bügling

commit sha 3053e6de67a55bfb9294c2d60d38682e732e6be0

Fix TOC entry for Linux in GettingStarted The TOC was referencing a no longer existing "Ubuntu Linux" section.

view details

Alexis Laferrière

commit sha c38d1773d23fccb6fb3bc5d885d7aee2380cf4eb

[Serialization] Restrict loading swiftmodule files to the builder's SDK Serialize the canonical name of the SDK used when building a swiftmodule file and use it to ensure that the swiftmodule file is loaded only with the same SDK. The SDK name must be passed down from the frontend. This will report unsupported configurations like: - Installing roots between incompatible SDKs without deleting the swiftmodule files. - Having multiple targets in the same project using different SDKs. - Loading a swiftmodule created with a newer SDK (and stdlib) with an older SDK. All of these lead to hard to investigate deserialization failures and this change should detect them early, before reaching a deserialization failure. rdar://78048939

view details

Alexis Laferrière

commit sha bccea96fccfa1fc132aa8730a3ca0b0015fa98dd

[Test] Use -parse-stdlib to avoid loading an incompatible stdlib Tests using a mock SDK can't load the stdlib of the normal SDK (or the just-built one) with the recent changes. Use `-parse-stdlib` in those tests to prevent loading the stdlib implicitly.

view details

Alexis Laferrière

commit sha 51cec860852c8cf5b009fc8ba9865234bcc1ffa7

[APIDigester] Don't check whether the stdlib was built for a different SDK The API digester forces loading the stdlib which may pick up an stdlib from a different SDK than the one being tested. Disable the check enforcing loading only swiftmodules built for the same SDK.

view details

Nate Chandler

commit sha b57b222b54015d7d38601954ffd2084d2144621b

[SIL] Added lexical flag to alloc_stack. The new flag will be used to track whether a borrow scope corresponds to a source-level lexical scope. Here, the flag is just documented, added to the instruction, represented in textual and serialized SIL, and cloned.

view details

Joe Groff

commit sha 4fb2d07b2513b599cc546a4f327984f968f00670

Refactor IsBindableVisitor's handling of generic nominals. In order to correctly handle upper bound requirements arising from conditional conformances, we need to be able to ingest requirements introduced by conditional conformance extensions, which means recursively visiting the parent is no longer possible to do cleanly. It is simpler to substitute the generic type's entire generic context as a whole.

view details

Joe Groff

commit sha 85c7228df84a4c819a6b06ccbeb6dd9ceab82ce0

Have IsBindableVisitor consider conditional conformances. The upper bound on a nominal type's generic argument can have more requirements imposed on it than those written in the original nominal type's generic signature, depending on the requirements imposed on the nominal type itself, thanks to conditional conformances. IsBindableVisitor failed to take this into account when visiting the bindings of generic type arguments. This could cause Type::isBindableTo to provide a false positive for a substituted type that doesn't satisfy conditional conformances, but more importantly, SIL type lowering uses the same visitor to extract an upper bound generic signature for substituted SIL function types, and if it doesn't preserve requirements from conditional conformances on nominal types in that signature, it can end up building an incorrect substitution map. Fix this by passing down the upper bound from generic arguments even when visiting nominal types, and using those upper bounds to check for conditional conformances that add requirements to generic arguments while visiting them.

view details

Slava Pestov

commit sha 2feb76d50443bd64b5bea331531dee6684934831

Run type_lowering_subst_function_type_conditional_conformance.swift test with requirement machine enabled

view details

Slava Pestov

commit sha eeae6cfa17cafcc5c0176a6a56c18f7542307f8b

SIL: Fix for when conditional requirements reference nested type parameters

view details

Doug Gregor

commit sha 7edec3f4a71df7323c4b50ee906213828fbf9d30

Install Clang when building the macOS source compatibility suite. We need the just-built Clang to build the back-deployed concurrency libraries.

view details

Konrad `ktoso` Malawski

commit sha 11943005c3ce38fc9be0c26a6fc0459e52b9295c

[Concurrency] Call TaskGroupImpl destructor; stop leaking groups

view details

Doug Gregor

commit sha da2b7232cebe6d17dee0f09dcca7dd12de1a2a1f

Merge pull request #39280 from DougGregor/back-deploy-global-actor-qualified-function-types

view details

push time in 2 days

PR merged swiftwasm/swift

[pull] swiftwasm from main :arrow_heading_down: Upstream Tracking

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

+1421 -241

0 comment

68 changed files

pull[bot]

pr closed time in 2 days

PullRequestReviewEvent

startedawwbees/BespokeSynth

started time in 2 days

pull request commentMaxDesiatov/XMLCoder

Optionally expose indexes for interleaved elements

The new files need to be added to the existing .xcodeproj for CI to pass. I know this is a chore, but we're still keeping compatibility with Carthage (for now), which does require this Xcode project cruft to exist in the repository.

liambutler-lawrence

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentMaxDesiatov/XMLCoder

Optionally expose indexes for interleaved elements

 extension XMLKeyedDecodingContainer {         }          let elements = container-            .withShared { keyedBox -> [KeyedBox.Element] in-                keyedBox.elements[key.stringValue].map {-                    if let singleKeyed = $0 as? SingleKeyedBox {-                        return singleKeyed.element.isNull ? singleKeyed : singleKeyed.element-                    } else {-                        return $0+            .withShared { keyedBox -> [KeyedBox.Element] in                +                if type is XMLPositionIndexedSequenceProtocol.Type {+                    return keyedBox.elements+                        .indexedValues(for: key.stringValue)+                        .map { indexedValue -> Box in+                            KeyedBox(+                                elements: [+                                    ("index", StringBox(xmlString: String(indexedValue.index))),+                                    ("value", indexedValue.value)+                                ],+                                attributes: []+                            )+                        }+                } else {+                    return keyedBox.elements[key.stringValue].map {+                        if let singleKeyed = $0 as? SingleKeyedBox {+                            return singleKeyed.element.isNull ? singleKeyed : singleKeyed.element+                        } else {+                            return $0+                        }                     }                 }             }-+        

Please run SwiftFormat on the source code to clean up trailing whitespaces. You can also install pre-commit hooks for it as described in the "Coding Style" section of README.md, which will make swiftformat run before you commit.

liambutler-lawrence

comment created time in 2 days

push eventswiftwasm/swift

Erik Eckstein

commit sha 982ed06e86def26b4d5db889d618a45715ee6a84

sil-opt: add an option "-serialize" for testing serialization. This is similar to the existing -emit-sib, except that not everything is serialized, but only functions which are marked as "serializable".

view details

Erik Eckstein

commit sha 83184a9680309333fe07e25dccedd9998be51565

Serialization: include global variables in the worklist-processing It's not sufficient to first serialize all functions and then serialize all globals, because a function can be referenced from the initializer expression of a global. Therefore the worklist processing must include both, functions and globals. This fixes a crash in the serializer, which is exposed through cross-module-optimization. https://bugs.swift.org/browse/SR-15162 rdar://82827256

view details

Nate Cook

commit sha c1f6b9d28b9c9e9aeec176999cf48ad0c5179e2e

XFAIL a test to unblock the release/5.5 bots

view details

eeckstein

commit sha 9c5b3a10faf6e2b2b3f900dcbc43e60516916a6e

Merge pull request #39223 from eeckstein/fix-serialization-5.5 [5.5] Serialization: include global variables in the worklist-processing

view details

Max Desiatov

commit sha 8d966d38690910b514ebcc4ce07c528f41ac803e

Merge pull request #3522 from swiftwasm/release/5.5 [pull] swiftwasm-release/5.5 from release/5.5

view details

push time in 2 days

PR merged swiftwasm/swift

[pull] swiftwasm-release/5.5 from release/5.5 :arrow_heading_down: Upstream Tracking

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

+76 -30

0 comment

4 changed files

pull[bot]

pr closed time in 2 days

push eventswiftwasm/swift

Max Desiatov

commit sha 46de0a06f0cfad947f08633604aee8d28df8e34b

Enable arm64 build distribution for 5.4 and 5.5

view details

push time in 2 days

delete branch swiftwasm/swift

delete branch : maxd/m1-build-5.4

delete time in 2 days

push eventswiftwasm/swift

Max Desiatov

commit sha c490f901f741d307538bda1b9bea8df6e00dafc9

Add M1 build to `build-toolchain.yml` for 5.4 (#3528) Cherry-pick of #3463 for the 5.4 release branch.

view details

push time in 2 days

PR merged swiftwasm/swift

Add M1 build to `build-toolchain.yml` for 5.4 continuous integration release

Cherry-pick of #3463 for the 5.4 release branch.

+53 -27

0 comment

2 changed files

MaxDesiatov

pr closed time in 2 days

pull request commentTokamakUI/Tokamak

Refactor NavigationView

Hm, fair enough. @kateinoigakukun do you have any ideas? Could this be something related to how function builders work, or is there something else going on that isn't a simple stack overflow?

ezraberch

comment created time in 2 days

pull request commentapple/swift

Driver: add support for the WebAssembly toolchain

@swift-ci please smoke test

MaxDesiatov

comment created time in 3 days