profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/MasoniteFramework/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Masonite MasoniteFramework New York https://masoniteproject.com The Masonite Organization. Home Of The Modern And Developer Centric Python Web Framework.

MasoniteFramework/masonite 1649

The Modern And Developer Centric Python Web Framework. Be sure to read the documentation and join the Slack channel questions: http://slack.masoniteproject.com

MasoniteFramework/core 83

Main pip package location for Masonite

MasoniteFramework/docs 29

Documentation for Masonite

MasoniteFramework/masonite4 13

Temporary Repository for a Masonite Rewrite for Masonite 4

MasoniteFramework/api 9

Masonite API package currently in development

MasoniteFramework/billing 5

Masonite Billing

MasoniteFramework/exceptionite 5

A Python Exception Library. Designed to make handling and displaying exceptions a cinch.

MasoniteFramework/forms 4

A forms package for Masonite

MasoniteFramework/contest 3

For the Masonite Blog contest

MasoniteFramework/craft 3

Craft command line tool

startedMasoniteFramework/masonite

started time in 2 days

startedMasoniteFramework/masonite

started time in 3 days

startedMasoniteFramework/masonite4

started time in 3 days

issue commentMasoniteFramework/masonite4

When do you expect to release the official version of masonite4?

I come to see it every day

goophps

comment created time in 3 days

startedMasoniteFramework/masonite

started time in 4 days

issue commentMasoniteFramework/masonite4

When do you expect to release the official version of masonite4?

@goophps Able the notifications for all of this repository. You'll keep updated about some news.

goophps

comment created time in 6 days

issue commentMasoniteFramework/masonite4

Version 4 deployment checklist

I am really looking forward to it. I have come here every day recently.

josephmancuso

comment created time in 6 days

issue commentMasoniteFramework/masonite4

When do you expect to release the official version of masonite4?

I am really looking forward to it. I have come here every day recently.

goophps

comment created time in 6 days

startedMasoniteFramework/masonite

started time in 6 days

startedMasoniteFramework/masonite

started time in 6 days

issue commentMasoniteFramework/masonite4

I suggest making it an asynchronous framework, using async def and await.

目前没有计划使它成为一个异步框架

josephmancuso

goophps

comment created time in 7 days

issue commentMasoniteFramework/masonite4

I suggest making it an asynchronous framework, using async def and await.

It can improve performance and is recommended to be included in the development plan.

goophps

comment created time in 7 days

issue closedMasoniteFramework/masonite

Is this an asynchronous web framework?

Is this an asynchronous web framework? I heard that the syntax is async def and await.

closed time in 7 days

goophps

issue commentMasoniteFramework/masonite4

I suggest making it an asynchronous framework, using async def and await.

Currently no plans to make this an asynchronous framework

goophps

comment created time in 7 days

startedMasoniteFramework/masonite4

started time in 7 days

startedMasoniteFramework/masonite4

started time in 7 days

issue openedMasoniteFramework/masonite

Is this an asynchronous web framework?

Is this an asynchronous web framework? I heard that the syntax is async def and await.

created time in 7 days

issue commentMasoniteFramework/orm

Migrations not wrapping table/column names

Alter queries should wrap the table. Anywhere really there is a table, it should be using self.wrap_table(table_name)

This is specifically for the use case where you name the table keyword or something

Thanks @josephmancuso Yeah that makes sense. After thinking about this further I realised that the format strings are a command layout vs a specific formatting per grammar for the values to be input.

ok so I will put a PR together to make this more robust. This will then bring them inline with how the QueryBuilder wraps tables and columns.

Cheers for the input

circulon

comment created time in 8 days

issue commentMasoniteFramework/orm

Allow database configuration/settings path to be specified for CLI commands

Yeah. You understand the problem we're trying to solve here lol. Can you open a PR for this?

alexpdr

comment created time in 8 days

issue commentMasoniteFramework/orm

Migrations not wrapping table/column names

Alter queries should wrap the table. Anyway really there is a table, it should be using self.wrap_table(table_name)

This is specifically for the use case where you name the table keyword or something

circulon

comment created time in 8 days

issue openedMasoniteFramework/orm

Migrations not wrapping column names

Describe the bug When using migrations the alter queries are not wrapping table and column names correctly. This causes an issue when using a table name that is also a reserved keyword.

eg the following will produce a syntax error in postgres and possibly other engines. In this example there is already a table created called "user"

        with self.schema.create("user_profile") as table:
            table.uuid("id").default_raw("uuid_generate_v4()").primary()
            table.uuid("user_id").add_foreign("user_id.id.user").on_update('cascade').on_delete("restrict")

This throws a syntax error from psycopg2 like this

psycopg2.errors.SyntaxError: syntax error at or near "user"
LINE 1: ..._user_id_foreign FOREIGN KEY (user_id) REFERENCES user(id) O...
                                                                                                         ^

My initial thought was to update the "get_foreign_key_constraint_string()" to include the '"' in the appropriate spots but then looking at the other Platforms format strings none of them have their respective table/column identifiers (eg mssql is []) either.

So the other option is to use the self.wrap_table() in all the appropriate places but this makes the code slightly less readable.

@josephmancuso I would appreciate your input for a direction on this as it will affect all platforms at some point and I would like to put another PR to fix this in.

Expected behavior The alter query that is built should have appropriately wrapped table and column identifiers

What database are you using?

  • Type: Postgres
  • Version 10
  • Masonite ORM latest

created time in 8 days

issue commentMasoniteFramework/orm

Allow database configuration/settings path to be specified for CLI commands

That could work 😄I think using a controllable parameter like a environment variable would still be preferable, but they're also not mutually exclusive? Like it could attempt to load from environment and then default to the locate, aka something like:

  • DB = os.getenv("DB_CONFIG_PATH", pydoc.locate('config.database.DB'))
  • DB = os.getenv("DB_CONFIG_PATH", None) or pydoc.locate('config.database.DB'))

🤔 try/catch/finally would also give some additional implementation options

alexpdr

comment created time in 8 days

Pull request review commentMasoniteFramework/orm

postgres use UUID datatype

 def after(self, after):         self.after = after         return self -    def default(self, value):+    def default(self, value, raw=False):

@josephmancuso

Added the default_raw() method as suggested Added variations across all grammars tests for both .default("value", True) and .default_raw("value")

circulon

comment created time in 9 days

PullRequestReviewEvent

startedMasoniteFramework/masonite

started time in 10 days

Pull request review commentMasoniteFramework/orm

postgres use UUID datatype

 def after(self, after):         self.after = after         return self -    def default(self, value):+    def default(self, value, raw=False):

Yep NP Will work on these this afternoon

circulon

comment created time in 10 days