profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/LeoNatan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Leo Natan LeoNatan Tel Aviv, Israel http://stackoverflow.com/users/983912/leo-natan Senior macOS & iOS software engineer at InVision. Previously mobile technology leading at Wix and Check Point Software Technologies

LeoNatan/LNPopupController 2776

LNPopupController is a framework for presenting view controllers as popups of other view controllers, much like the Apple Music and Podcasts apps.

LeoNatan/LNNotificationsUI 803

A framework for displaying notifications similar to Apple's iOS 8 and iOS 9 notifications.

LeoNatan/Apple-Runtime-Headers 187

Objective-C runtime headers for Apple's iOS, macOS, tvOS and watchOS frameworks

LeoNatan/LNPopupUI 84

A SwiftUI-friendly API for the LNPopupController framework

LeoNatan/LNPropertyListEditor 73

A property list editor for macOS, similar to Xcode's.

LeoNatan/LNWindowManager 37

A window manager that makes working with UIWindow objects easily using an API similar to the UIViewController modal presentation API.

LeoNatan/LNPreviewToContextMenu 36

LNPreviewToContextMenu is a framework for automatically transforming your existing 3D Touch Peek&Pop preview controllers and actions into the new UIContextMenu system in iOS 13.

LeoNatan/LNInterpolation 30

An interpolation framework for Cocoa and Cocoa Touch.

LeoNatan/LNChevronView 20

Implementation of a chevron view similar to Apple's as seen in Springboard / Apple Music.

LeoNatan/LNTouchVisualizer 8

Touch visualizing framework for iOS

release LeoNatan/LNPopupController

2.12.5

released time in 4 hours

created tagLeoNatan/LNPopupController

tag2.12.5

LNPopupController is a framework for presenting view controllers as popups of other view controllers, much like the Apple Music and Podcasts apps.

created time in 4 hours

push eventLeoNatan/LNPopupController

Leo Natan

commit sha e54cdc05c54d51194883eb026bfaa1c90287012c

2.12.5

view details

push time in 4 hours

push eventLeoNatan/LNPopupController

Leo Natan

commit sha 12b51f242aa8d863d5e0d25bd929dd8c4ac84c3f

Add support for attributedTitle and attributedSubtitle

view details

push time in 4 hours

issue commentLeoNatan/LNPopupController

Question

I am sorry, I don't understand what you are saying. You keep saying "window", but I don't think you mean a window.

If you want the popup bar to appear above the navigation bar, you should present it like this:

self.navigationController.presentPopupBar(withContentViewController: popupContentViewController, animated: true, completion: nil)
rastaman111

comment created time in 9 days

issue closedLeoNatan/LNPopupController

Question

My application does not have a tabBarController, only a navigationController, and when I click on the bottom plate, a new window opens, the navigationController remains, how can I hide it? I attach a photo

image image image

closed time in 9 days

rastaman111

issue commentLeoNatan/LNPopupController

Question

You are presenting the bar on the wrong controller. As @iDevelopper said, you need to present it on the navigation bar.

rastaman111

comment created time in 9 days

issue commentLeoNatan/LNPopupUI

popup bar and popup content can get stuck in wrong position when dismissing a modal sheet with the keyboard in a transitory state

Screen Shot 2021-09-10 at 05 55 36

So, if I do this hack, it fixes the issues. 🙈 The problem comes from bad state management inside SwiftUI, where if the keyboard will hide notification is sent too early (~5 runloop spins), SwiftUI layout breaks.

Unfortunately, I don't feel comfortable adding this hack into LNPopupUI. If you'd like to add it, you can just register some object to listen to UIApplication.keyboardWillHideNotification and repost the notification again, after 5 runloop spins. You can maybe only run it if iOS 14 and below.

svenoaks

comment created time in 10 days

issue commentLeoNatan/LNPopupUI

popup bar and popup content can get stuck in wrong position when dismissing a modal sheet with the keyboard in a transitory state

You know, I'm not even sure this is a bug with the popup. It seems like resigning the first responder too quickly breaks the internal layout handling for safe areas. Even without any popup, notice how your tab view looks:

Simulator Screen Shot - iPhone 12 Pro Max - 2021-09-10 at 03 31 01

On iOS 15, this is fixed:

Simulator Screen Shot - iPhone 12 Pro Max - 2021-09-10 at 03 33 37

Likewise, your issue doesn't occur there:

https://user-images.githubusercontent.com/2270433/132779968-52b35cc1-561c-4db5-af37-3792e877ebf1.mp4

I'm not sure what more I can do here. It seems SwiftUI layout is broken on iOS 14.

svenoaks

comment created time in 10 days

issue commentLeoNatan/LNPopupUI

popup bar and popup content can get stuck in wrong position when dismissing a modal sheet with the keyboard in a transitory state

Not reproducing:

https://user-images.githubusercontent.com/2270433/132774955-78cdb510-3b25-4514-9779-e55724b21498.MP4

Please find a consistent way to reproduce this issue.

svenoaks

comment created time in 10 days

issue commentLeoNatan/LNPopupUI

popup bar and popup content can get stuck in wrong position when dismissing a modal sheet with the keyboard in a transitory state

Sorry, unable to reproduce.

https://user-images.githubusercontent.com/2270433/132773698-88e1df42-9658-4d8f-b839-7a5797c2f452.mp4

https://user-images.githubusercontent.com/2270433/132773717-6e87e9d1-e4f2-48cc-af42-c10494ed00a2.mp4

svenoaks

comment created time in 10 days

issue commentLeoNatan/LNPopupUI

popup bar and popup content can get stuck in wrong position when dismissing a modal sheet with the keyboard in a transitory state

Interesting, it doesn't reproduce on iOS 15. That's good. I will see what hacks are necessary on iOS 14 to resolve this.

svenoaks

comment created time in 10 days

IssuesEvent

release LeoNatan/LNPopupUI

1.2.17

released time in 11 days

created tagLeoNatan/LNPopupUI

tag1.2.17

A SwiftUI-friendly API for the LNPopupController framework

created time in 11 days

issue closedLeoNatan/LNPopupUI

popup bar and popup content can get stuck in wrong position when dismissing a modal sheet with the keyboard in a transitory state

This probably needs to be done on LNPopupController, but I'm posting it here for now since I'm using LNPopupUI.

If the keyboard comes out, the position of the popup bar will move to be on top of the keyboard. Is there a way to prevent this behavior so the popup bar stays fixed behind the keyboard. It seems the moving can cause certain bugs where the bar gets stuck in the wrong position as in the attached video. It can get stuck in even worse positions where opening the popup will not fix it.

Even if you need to keep this behavior, maybe there is some easy way to prevent it from within LNPopupController, so that I can make the change just for my case?

https://user-images.githubusercontent.com/5206058/132543998-c1a87255-5ebf-4d24-a8ba-e376e842350a.mp4

closed time in 11 days

svenoaks

push eventLeoNatan/LNPopupUI

Leo Natan

commit sha 63b7ec660a4ef7a86d10050bad00606fd5404a71

Fix custom popup bar view layout when keyboard is open Closes #11

view details

Leo Natan

commit sha b139d1b8013cd4e740a1f1fc5e0a645d3b0cbde4

Remove uneccesary line from demo project

view details

Leo Natan

commit sha 8d3cde50d538507236b8b97c22bbd7ed1b0d3a0f

1.2.17

view details

push time in 11 days

issue commentLeoNatan/LNPopupUI

popup bar and popup content can get stuck in wrong position when dismissing a modal sheet with the keyboard in a transitory state

This seems like a bug in SwiftUI. It is hellbent on providing the incorrect layout size for the custom popup bar view. There is no issue that I could see with a standard bar (because it is all UIKit). I've implemented a nasty hack that basically ignores popup bar size changes when the keyboard is open, and when it gets closed, it updates the size in case an actual size update is necessary. I think this is a relatively safe hack, as the custom popup bar view would normally change size only after user interaction.

svenoaks

comment created time in 11 days

issue commentLeoNatan/LNPopupUI

Possible to prevent the popup bar position from being adjusted when the keyboard comes out?

Yes, please. That would be helpful.

svenoaks

comment created time in 11 days

issue commentLeoNatan/LNPopupUI

Possible to prevent the popup bar position from being adjusted when the keyboard comes out?

BTW, this isn’t supposed to happen. The popup bar is supposed to remain glued to the tab bar. What OS is this?

svenoaks

comment created time in 11 days

issue commentLeoNatan/LNPopupUI

Possible to prevent the popup bar position from being adjusted when the keyboard comes out?

Hmm, wow, never seen that. Need to check if this is a SwiftUI layout bug, or my underlying framework is buggy. Will look soon.

svenoaks

comment created time in 11 days

issue commentLeoNatan/LNPopupUI

Change color of now playing bar background

You can try something like the following:

.popupBarInheritsAppearanceFromDockingView(false)
.popupBarCustomizer { popupBar in
	popupBar.standardAppearance.configureWithOpaqueBackground()
	popupBar.standardAppearance.backgroundColor = .white
}
lmick002

comment created time in 12 days

issue commentLeoNatan/LNPopupUI

Change color of now playing bar background

Check out the customization in the example project.

lmick002

comment created time in 12 days

issue commentLeoNatan/LNPopupUI

Change color of now playing bar background

Hello, I need more information. What view are you presenting the popup on? If a tab view or a navigation view (with a toolbar), the bar inherits appearance from the bottom view. You need to disable that, then change the appearance of the popup.

lmick002

comment created time in 12 days

push eventLeoNatan/LNPopupUI

Leo Natan

commit sha 9caadb0f3ce2b24a90f547dd932375f68ddbb92e

Update README.md

view details

push time in 12 days

push eventLeoNatan/LNPopupUI

Leo Natan

commit sha 62361a95b5704a254b2bf10aa3e2906eece84693

Create FUNDING.yml

view details

push time in 12 days

push eventLeoNatan/LNPopupController

Leo Natan

commit sha d7e97ccbb05f06361afe7bbd920e9a482bc4594e

Update README.md

view details

push time in 12 days