profile
viewpoint
Laurence Armstrong LaurenceGA Tokyo, Japan Software Engineer working in Japan

reviewdog/action-eslint 41

Run eslint with reviewdog

LaurenceGA/Pong 16

The classic game Pong, written in Go

LaurenceGA/kwamp 8

A Kotlin implementation of the Web Application Messaging Protocol (WAMP)

LaurenceGA/adventofcode2019 1

Go solutions for Advent of Code 2019

LaurenceGA/arm 1

A rudimentary programming language with c-like syntax

LaurenceGA/DifferentialCalculator 1

A short script that can derive basic equations for you

LaurenceGA/go-crev 1

A cryptographically verifiable code review system for go packages.

LaurenceGA/osdev 1

A very simple kernel/OS

LaurenceGA/programmingProjects 1

Main repo, lots of uni work and personal projects

LaurenceGA/ProjectEuler 1

A repository for problems solved from project euler

pull request commentLaurenceGA/go-crev

Bump github.com/stretchr/testify from 1.5.1 to 1.6.0

@dependabot merge

dependabot-preview[bot]

comment created time in 11 hours

startedopen-telemetry/opentelemetry-go

started time in a day

startedgo-vgo/robotgo

started time in a day

startedflutter/flutter

started time in 3 days

startedvektra/mockery

started time in 9 days

issue commentreviewdog/action-shellcheck

Level seems to have no effect

I'm also a bit unsure how shellcheck_flags works. It says that its default value is --external-sources, so if I set shellcheck_flags to something else, does that mean --external-sources is unset?

Yeah I think that's correct. You can see they're passed as ${INPUT_SHELLCHECK_FLAGS:-'--external-sources'}, so I think a custom value will override it. Not sure about why you're not seeing your desired outcome.

This is your current PR to test? Under the check it says:

reviewdog: This is Pull-Request from forked repository. GitHub token doesn't have write permission of Review API, so reviewdog will report results via logging command [1] and create annotations similar to github-pr-check reporter as a fallback.

You can see it in the logs That explains why you aren't seeing a PR review. It seems like it has correctly annotated this line that I assume you changed for testing purposes.

Were you expecting the check to fail? 🤔 It wouldn't if you had the level set to warning or info, only error would fail.

asbjornu

comment created time in 11 days

issue commentactions/stale

NOT Closing issues / PRs immediately after adding the 'stale' label

It hasn't been happening prior to v3 though 🤷 Just started after upgrading for me at least. It's not related to #64?

xakraz

comment created time in 12 days

delete branch LaurenceGA/github-action-rotate-aws-secrets

delete branch : session-token

delete time in 13 days

pull request commentkneemaa/github-action-rotate-aws-secrets

Use AWS session token when available

@kneemaa Could you take a look if you get a chance?

LaurenceGA

comment created time in 13 days

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 51d21390b787a0a0cbd743e558bb0d24cb09aa80

Inject verify flag into commands

view details

LaurenceGA

commit sha 0befa35bf797bb120c0749f54f252f2cbbe974d5

Don't panic when github request fails

view details

LaurenceGA

commit sha 57ea83d2679c2aeff2a9de2d810471c24e71b87d

Add verbose output to trust flow

view details

push time in 14 days

issue openedLaurenceGA/go-crev

Create commit when creating trust proof

At the moment we just create and save the file.

Should create the commit for the user.

created time in 14 days

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 9f8f4f6e0e30d808b81fbff57f675e26e7673d31

Update flag declaration formatting

view details

LaurenceGA

commit sha 52d8ce26361d47824de0024f42791b7793795d67

Add flag for verbose output

view details

push time in 14 days

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 7d153c1a2c618633a6287dc9e5dec1b7a890b841

Move create trust into subcommand of larger struct command

view details

LaurenceGA

commit sha c5df79ebc63aa6bbaea9b6db796e4ee4279fd77a

Create a review command

view details

LaurenceGA

commit sha cf552fe4a8bb7f5a1207e1fd681609196ce8733f

Change trust create flow filename

view details

LaurenceGA

commit sha 3085e0b7cf119503d056bc9b43de3c3a7665fa13

Change trust creator receiver name

view details

LaurenceGA

commit sha a8ca97146d40130ca522a43699bf18e5924fec4f

Simplify trust create constructor name

view details

LaurenceGA

commit sha a9a37bd9fc8c09c96d74ef4b20efd75de904dc5b

Start creating review flow

view details

LaurenceGA

commit sha ef33ae9115e88db5504e4fd02cc3c5d7ea2006b8

Update func call formatting

view details

LaurenceGA

commit sha 99d6e8a1055557afde76898d3cdc3cb178396799

Call create review flow from command

view details

push time in 14 days

startedposener/goaction-example

started time in 15 days

issue closedLaurenceGA/go-crev

Create community health files

Community will be vital to this project, so these files are important.

https://help.github.com/en/github/building-a-strong-community/creating-a-default-community-health-file

closed time in 15 days

LaurenceGA

issue commentLaurenceGA/go-crev

Create community health files

LaurenceGA

comment created time in 15 days

push eventLaurenceGA/go-crev

Laurence Armstrong

commit sha b5e4e5fad363097a08e4cf9154ec2eebcbaec5a1

Create SECURITY.md

view details

push time in 15 days

push eventLaurenceGA/go-crev

LaurenceGA

commit sha a27a370bff89c11e383e3a93968f8e1c908e1cf5

Bump golangci version to 1.27

view details

LaurenceGA

commit sha 6179833102c460cf51217259ffbfa80b9c9242ab

Add code of conduct

view details

LaurenceGA

commit sha 013d03a12413e7225d69800768db45d4ac13823b

Add code of conduct badge to readme

view details

LaurenceGA

commit sha 1f317a8363b95d1620f66de10535699b2969721e

Add contributing document

view details

LaurenceGA

commit sha faa5137694b616716731d2324b3cee54918f384b

Reduce written file permissions

view details

LaurenceGA

commit sha c6d174ea569e37b173b406afcea142ba56aecdba

End comments with full stops

view details

LaurenceGA

commit sha 70e39d7bf906cb931b5d02cc6b837c6b17db2c46

Make const function-local

view details

LaurenceGA

commit sha e3fc37520306ac5b3974abc3ff2e6ea37b0369b6

No dynamic errors

view details

LaurenceGA

commit sha e6723e69e1fbd5b321febe5c290c308b47f88ed9

Enable gomodguard

view details

LaurenceGA

commit sha 24a0838972cfb9f3329208f087ca6ab5376ad79d

Enable nestif

view details

LaurenceGA

commit sha 33aeceb8867ad1bd4e2e4334b280c2a7dec71b34

Enable nolintlint linter

view details

push time in 15 days

PR closed LaurenceGA/go-crev

Reviewers
Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0 dependencies

Bumps gopkg.in/yaml.v2 from 2.2.8 to 2.3.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/go-yaml/yaml/commit/0b1645d91e851e735d3e23330303ce81f70adbe3"><code>0b1645d</code></a> Set the default line length to infinity (-1) (<a href="https://github-redirect.dependabot.com/go-yaml/yaml/issues/571">#571</a>)</li> <li>See full diff in <a href="https://github.com/go-yaml/yaml/compare/v2.2.8...v2.3.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -1

2 comments

2 changed files

dependabot-preview[bot]

pr closed time in 16 days

pull request commentLaurenceGA/go-crev

Bump gopkg.in/yaml.v2 from 2.2.8 to 2.3.0

Dependency no longer exists

dependabot-preview[bot]

comment created time in 16 days

delete branch LaurenceGA/go-crev

delete branch : create-trust

delete time in 16 days

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 966ad9877149fdf6d5aa82addcee86c7cc95530f

Add identity flag and implementation plan

view details

LaurenceGA

commit sha 68bb7ff43e6272a47435c721b6ec218f2c3a1a3c

Bump golangci version

view details

LaurenceGA

commit sha fac6ef687668723bfbc508753a042d9381f6100a

Load config

view details

LaurenceGA

commit sha 30eb04c57dd2c0fe3ffbee7239b4660a7a02acdb

Validate user config

view details

LaurenceGA

commit sha 1412451df1f31aa36ed29f51a1b2ec879f9fced4

Put config loading and validation into its own function

view details

LaurenceGA

commit sha 880cae7f32f16102a0dd104e2a023265eed4859b

Pass username input to test

view details

LaurenceGA

commit sha ff20bad820cc19b1816abfc4ac5285853e4e368e

Upgrade yaml to v3

view details

LaurenceGA

commit sha 3bd09feaf881b1a72fa785c40f85e8f8a70476e2

Start create proof with common fields

view details

LaurenceGA

commit sha 07d3d55899266a49c48a8b97f1c243747f185a54

Mock github client

view details

LaurenceGA

commit sha 0782b54cd14e7a41760f1f802864d488fe285880

Get username when creating trust

view details

LaurenceGA

commit sha 80ccf809cbb4ac93b57947a66e1f6d450047b167

Fetch a user's crev proof repo automatically

view details

LaurenceGA

commit sha cebdd04ba62f90f84366fd3bbcd3c905591d4d7b

Add select prompt for trust level

view details

LaurenceGA

commit sha 604d82ca3d95724057150aa46a73550a57d2dccd

Get comment from the user

view details

LaurenceGA

commit sha ba57420e4cd43a701928ee5e520bb2d4dbff7c9e

Start generating trust object

view details

LaurenceGA

commit sha ddc4dcd2b74bab26edb93588cd6bebb760892084

Update testing style

view details

LaurenceGA

commit sha 67422ad70421433759b88f84e88a3886483c6d5b

Don't shadow package name

view details

LaurenceGA

commit sha 79e83f8ccfe5f8c69514af5c0f8d429b8603dc8c

Lowercase trust level during serialisation

view details

LaurenceGA

commit sha ba585090518563f907a174511ea30f0fdc832205

Remove placeholder comments

view details

LaurenceGA

commit sha 766f01592b94adc6c24c355fa9f3799cb08f7609

Load SSH keys

view details

LaurenceGA

commit sha 9f449e49c7b34d4daf0a5e4d56f8d9cde7b260c7

Sign trust

view details

push time in 16 days

PR merged LaurenceGA/go-crev

Create trust feature

Closes #18

Problem

We need to be able to declare our trust for other IDs.

Solution

Trust proofs!

+1397 -110

0 comment

23 changed files

LaurenceGA

pr closed time in 16 days

issue closedLaurenceGA/go-crev

Create trust proofs

Problem to solve

We need to be able to create trust proofs so the user can build their web of trust.

Solution

./gocrev trust <ID> sounds good. We'll need a trust level and a comment.

closed time in 16 days

LaurenceGA

push eventLaurenceGA/go-crev

LaurenceGA

commit sha ab6fc35ca2da3a7fcd64ce92c3206e926dba3e58

Give each trust a uuid

view details

push time in 16 days

PR opened kneemaa/github-action-rotate-aws-secrets

Use AWS session token when available

Hi 👋

In some cases users of this action may which to assume a dedicated role and then update the keys of a user from there.

When you configure AWS credentials you can assume a role. This will put the session token in your env variables.

To allow for this, this action has to provide the session token to the boto client, so this PR does that if the env var exists.

I've also updated the readme.

+9 -4

0 comment

2 changed files

pr created time in 16 days

delete branch LaurenceGA/github-action-rotate-aws-secrets

delete branch : patch-1

delete time in 16 days

push eventLaurenceGA/github-action-rotate-aws-secrets

Laurence Armstrong

commit sha 38e55e2579079e33b04920b971f540c2da4019c4

Update readme descriptions

view details

push time in 16 days

push eventLaurenceGA/github-action-rotate-aws-secrets

Laurence Armstrong

commit sha 38e55e2579079e33b04920b971f540c2da4019c4

Update readme descriptions

view details

push time in 16 days

create barnchLaurenceGA/github-action-rotate-aws-secrets

branch : session-token

created branch time in 16 days

push eventLaurenceGA/github-action-rotate-aws-secrets

Laurence Armstrong

commit sha e2b6f489a7dcdabb446d552105a0d8f381ba2f43

Use AWS session token

view details

push time in 16 days

fork LaurenceGA/github-action-rotate-aws-secrets

Github Action to rotate AWS Access Keys stored in a repositories secrets

fork in 16 days

startedgolangci/golangci-lint

started time in 17 days

startednabeken/go-check-smtp

started time in 19 days

PR opened reviewdog/action-eslint

Provide a default Github token bump:minor documentation enhancement

See similar PR for other reviewdog action here.

This makes it so that users of this action no longer need to pass github_token: ${{ secrets.github_token }}, we just provide it by default. They can still pass it if they like. Makes the workflow file less noisy.

+2 -7

0 comment

3 changed files

pr created time in 19 days

create barnchreviewdog/action-eslint

branch : default-github-token

created branch time in 19 days

push eventreviewdog/action-golangci-lint

LaurenceGA

commit sha ce304e3a07328545d9d78c78f073f42e510602fc

Fix misplaced input

view details

push time in 19 days

push eventreviewdog/action-golangci-lint

LaurenceGA

commit sha f3a043ee2eb825c049417ed5549e73f4cd4631f3

Update readme to clarify explit token setting for pre-built use with docker images

view details

push time in 19 days

Pull request review commentreviewdog/action-golangci-lint

Provide default Github token

 jobs:       - name: golangci-lint (All-In-One config)         uses: docker://reviewdog/action-golangci-lint:v1         with:-          github_token: ${{ secrets.github_token }}

I'll update the readme too...

LaurenceGA

comment created time in 19 days

Pull request review commentreviewdog/action-golangci-lint

Provide default Github token

 jobs:       - name: golangci-lint (All-In-One config)         uses: docker://reviewdog/action-golangci-lint:v1         with:-          github_token: ${{ secrets.github_token }}

Oooh okay, I didn't know that was a thing :open_mouth: Thanks for your timely help! :grin:

Will revert :+1:

LaurenceGA

comment created time in 19 days

push eventreviewdog/action-golangci-lint

LaurenceGA

commit sha bb2e2a9d52b439dd182924f9e48f7e85ce2c2d21

Explicitly set github token when using pre-build docker images

view details

push time in 19 days

pull request commentreviewdog/action-golangci-lint

Provide default Github token

Seems to have half worked... :confused:

LaurenceGA

comment created time in 19 days

push eventreviewdog/action-golangci-lint

LaurenceGA

commit sha df37e36388aae273ec8a43bd34901624c44aceb4

Don't explicitly set github token in tests

view details

push time in 19 days

PR opened reviewdog/action-golangci-lint

Provide default Github token documentation enhancement

I saw that this was possible in some other actions. Instead of making every single user always have github_token: ${{ secrets.github_token }}, we can just provide this for them, while still allowing them to change it.

Also, we don't have to put ${{ secrets.github_token }}, we can just put ${{ github.token }}. They're equivalent.

If this works and everyone thinks it's a good idea, I think we should have it in other reviewdog actions too.

Just makes people's workflows a tiny bit less noisy :slightly_smiling_face:

+2 -17

0 comment

3 changed files

pr created time in 19 days

create barnchreviewdog/action-golangci-lint

branch : default-token

created branch time in 19 days

delete branch reviewdog/action-eslint

delete branch : workdir-docs-typo

delete time in 20 days

PR opened reviewdog/action-eslint

Add missing word to workdir input description documentation

Oops, made a typo from #19/#25

"...from which look for..." -> "...from which to look for..."

+2 -2

0 comment

2 changed files

pr created time in 20 days

create barnchreviewdog/action-eslint

branch : workdir-docs-typo

created branch time in 20 days

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 75f8825bedb025b11fad9f33027eec457ec16f51

Load ssh key after verifying user during trust

view details

push time in 20 days

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 6e6e4152d2f73e93bc011a7f49fff3092895644e

Collect trusts by month

view details

LaurenceGA

commit sha 765ab1a190c363b692750f8dcff55b08709e6799

Save trustee ID

view details

LaurenceGA

commit sha 2b4e916d00c74474626a02cb9de15d7cb615f814

Handle encrypted SSH keys

view details

push time in 20 days

Pull request review commentreviewdog/reviewdog

Add Code of Conduct

+# Contributor Covenant Code of Conduct
# Reviewdog Code of Conduct

or maybe

# Reviewdog community Code of Conduct

I looked at their examples and it seems like a lot of people leave Contributor Covenant in, but I don't think their meant to...? Seems weird... Quite a few people replace it too. There's already an Attribution section at the bottom, so I think it's obvious where it comes from.

haya14busa

comment created time in 21 days

pull request commentreviewdog/reviewdog

Add Code of Conduct

I created a google mailing list (https://groups.google.com/forum/#!forum/reviewdog) as a contact in the code of contact.

I don't plan to use the mailing list for other purposes for now, but please feel free to join.

Don't have permission to access group when opening link. Might be misconfigured :thinking:

haya14busa

comment created time in 21 days

startedankidroid/Anki-Android

started time in 21 days

startedunidoc/unipdf

started time in 22 days

delete branch LaurenceGA/action-eslint

delete branch : working-dir

delete time in 23 days

pull request commentreviewdog/action-eslint

Add working directory flag to allow use of action from non-root directory

📝 Tests don't actually run properly as the PR is from my forked repo 🤔

LaurenceGA

comment created time in 23 days

Pull request review commentreviewdog/action-eslint

Add working directory flag to allow use of action from non-root directory

 cd "$GITHUB_WORKSPACE"  export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}" -if [ ! -f "$(npm bin)/eslint" ]; then-  npm install+ESLINT_COMMAND="$(npm bin --prefix $INPUT_WORKDIR)/eslint"

Great work @haya14busa ! I'll update the PR and change the action argument to directory (?).

LaurenceGA

comment created time in 23 days

push eventLaurenceGA/action-eslint

Laurence Armstrong

commit sha 3bd14674618c677d476a9c870ac76a97e56e16dd

Change subdirectory logic

view details

push time in 23 days

push eventLaurenceGA/go-crev

LaurenceGA

commit sha ba585090518563f907a174511ea30f0fdc832205

Remove placeholder comments

view details

LaurenceGA

commit sha 766f01592b94adc6c24c355fa9f3799cb08f7609

Load SSH keys

view details

LaurenceGA

commit sha 9f449e49c7b34d4daf0a5e4d56f8d9cde7b260c7

Sign trust

view details

LaurenceGA

commit sha bb31f798f37092d4a7eae155c701ea8b67e9c3a6

Create proof interface

view details

LaurenceGA

commit sha a0da1a57824de9ba1e291576a4b182f1fd07c60f

Give IDs an alias

view details

LaurenceGA

commit sha 7a700799ef25fde9d6bfe1afa0de8dd3e4094c89

Write trust to store

view details

LaurenceGA

commit sha ceb16f864d9a7a0171413b5de087e24ee179f159

Fix ID yaml declaration

view details

LaurenceGA

commit sha eede3bc449dba59cf9d1bde610a4c8651bf01a63

Write out test trust

view details

push time in 25 days

issue commentLaurenceGA/go-crev

Create trust proofs

Thanks for the info! Very helpful - good to get an idea of what design decisions have already been made.

I was more concered about the performance of checkouts / switching branches / scanning the directory

Ah okay. Can't be that impactful can it? Same amount of data, but I guess fewer sys calls to open files? 🤔

I was mostly imitating armoered gpg output, while stuffing a yaml in it.

I see. According to the go package for pgp armor format, it's basically PEM + a checksum.

I'm not sure what you ask about exactly

Sorry, I wasn't clear. I was just wondering if there was special logic for the user typing something like cargo-crev trust <myself>. Just curious.

LaurenceGA

comment created time in a month

issue openedLaurenceGA/go-crev

A basic getting started guide

Problem to solve

How do you even use this thing...?

Solution

At first, a small guide in the readme might be good.

created time in a month

issue openedLaurenceGA/go-crev

Create package reviews

Problem to solve

We need to be able to create package review proofs because, well, it's kind of the point.

Solution

Implementation could be complicated. How does the user fill out the proof fields? How do they review the code?etc.

created time in a month

issue commentLaurenceGA/go-crev

Create trust proof

Also, do you let user's create trust proofs for themselves? How does cargo crev handle that? (I guess they can always manually create one if they really want to, even if the CLI stops them... :thinking: )

LaurenceGA

comment created time in a month

issue commentLaurenceGA/go-crev

Create trust proof

@dpc hey, I'm working on implementing allowing users to create trust proofs. I was just wanting to get some more information about ideas about how proofs are stored.

So my current understanding is that a single .crev.proof file is all of the proofs (separated by kind (trust or review)) for a given month, separated by a salt unique to a machine that is generated when a user sets/creates their ID. I recall this is also simply convention to make things human readable.

I was just wondering about the advantages of storing many proofs in a single file. I guess this means there are fewer files, so less clutter. I guess one drawback is it hinders the ability to share proofs individually (not that there's a use case at the moment :shrug: ) I suppose this partially comes from the PEM format crev proofs are based on? (I was hoping to parse them with an existing library, but it seems will require a custom (de)serialisation)

I was thinking for my implementation of storing 1 proof per file. They could be put in folders by time or something for sorting convenience. Then to avoid merge conflict issues each proof could be given its own UUID :thinking:

Just wondering what you thought? You feedback is appreciated :grin:

LaurenceGA

comment created time in a month

PR opened LaurenceGA/go-crev

Create trust feature

Closes #18

Problem

We need to be able to declare our trust for other IDs.

Solution

Trust proofs!

+823 -84

0 comment

18 changed files

pr created time in a month

issue openedLaurenceGA/go-crev

Create trust proof

Problem to solve

We need to be able to create trust proofs so the user can build their web of trust.

Solution

./gocrev trust <ID> sounds good. We'll need a trust level and a comment.

created time in a month

issue openedLaurenceGA/go-crev

Add completions

Problem to solve

Shell completions are awesome and help out a lot

Solution

Cobra should make this easy for us. See bash completions and zsh completions and fish completions and powershell completions

Additional context

If this is released on brew in the future, we'll want to use it to auto-install completions.

created time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 79e83f8ccfe5f8c69514af5c0f8d429b8603dc8c

Lowercase trust level during serialisation

view details

push time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 67422ad70421433759b88f84e88a3886483c6d5b

Don't shadow package name

view details

push time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 604d82ca3d95724057150aa46a73550a57d2dccd

Get comment from the user

view details

LaurenceGA

commit sha ba57420e4cd43a701928ee5e520bb2d4dbff7c9e

Start generating trust object

view details

LaurenceGA

commit sha ddc4dcd2b74bab26edb93588cd6bebb760892084

Update testing style

view details

push time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha cebdd04ba62f90f84366fd3bbcd3c905591d4d7b

Add select prompt for trust level

view details

push time in a month

startedkneemaa/github-action-rotate-aws-secrets

started time in a month

startedpion/webrtc

started time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 0782b54cd14e7a41760f1f802864d488fe285880

Get username when creating trust

view details

LaurenceGA

commit sha 80ccf809cbb4ac93b57947a66e1f6d450047b167

Fetch a user's crev proof repo automatically

view details

push time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 07d3d55899266a49c48a8b97f1c243747f185a54

Mock github client

view details

push time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha ff20bad820cc19b1816abfc4ac5285853e4e368e

Upgrade yaml to v3

view details

LaurenceGA

commit sha 3bd09feaf881b1a72fa785c40f85e8f8a70476e2

Start create proof with common fields

view details

push time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 68bb7ff43e6272a47435c721b6ec218f2c3a1a3c

Bump golangci version

view details

LaurenceGA

commit sha fac6ef687668723bfbc508753a042d9381f6100a

Load config

view details

LaurenceGA

commit sha 30eb04c57dd2c0fe3ffbee7239b4660a7a02acdb

Validate user config

view details

LaurenceGA

commit sha 1412451df1f31aa36ed29f51a1b2ec879f9fced4

Put config loading and validation into its own function

view details

LaurenceGA

commit sha 880cae7f32f16102a0dd104e2a023265eed4859b

Pass username input to test

view details

push time in a month

create barnchLaurenceGA/go-crev

branch : create-trust

created branch time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 9e2a926dc4c9ca3652865df6f06ad1f1da05eefa

Update argument comment for commands

view details

LaurenceGA

commit sha e34a02996a455816edd80a1d7a59407fe66abbfd

Update command comments

view details

LaurenceGA

commit sha 8a5f3ef603f575c0634313df8a31acfb7f931f97

Add new trust command

view details

LaurenceGA

commit sha bd77f022961e4b2af6eaaaeca2dbc50cb852290a

Rename idset flow files

view details

LaurenceGA

commit sha 205db287f9889a91868ae63bd5ffe3e226d65da5

Create trust user scaffolding

view details

LaurenceGA

commit sha 91d9f319a2d31219392724d17686ffbf5e1fc961

Unify files interface

view details

LaurenceGA

commit sha 0e0ed740366f7506886e14b102678a37a55543c1

Divide command flows into separate packages

view details

push time in a month

issue commentterraform-providers/terraform-provider-aws

Amazon API Gateway HTTP APIs

@podrezo See this issue: #12893 There is a PR open too.

ewbankkit

comment created time in a month

issue commentterraform-providers/terraform-provider-aws

Amazon API Gateway HTTP APIs

@podrezo See this issue: #12893 There is a PR open too.

ewbankkit

comment created time in a month

issue commentterraform-providers/terraform-provider-aws

Amazon API Gateway HTTP APIs

@podrezo See this issue: #12893 There is a PR open too.

ewbankkit

comment created time in a month

issue openedterraform-providers/terraform-provider-aws

aws_apigatewayv2_stage failing to update when no changes

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.12.24
+ provider.archive v1.3.0
+ provider.aws v2.58.0
+ provider.random v2.2.1
+ provider.template v2.1.2

Affected Resource(s)

aws_apigatewayv2_stage

Terraform Configuration Files

resource "aws_apigatewayv2_stage" "default_stage" {
  api_id      = aws_apigatewayv2_api.api.id
  name        = "$default"
  auto_deploy = true

  tags = {
    Project     = var.project_name
    Environment = var.env
  }
}

Expected Behavior

As no changes have been made to the configuration, terraform shouldn't be trying to update the stage with new values

Actual Behavior

Apply fails with:

Error: error updating API Gateway v2 stage ($default): BadRequestException: Execution logs are not supported on protocolType HTTP

The plan says:

default_route_settings {
        data_trace_enabled       = false
        detailed_metrics_enabled = false
      + logging_level            = "OFF"
        throttling_burst_limit   = 0
        throttling_rate_limit    = 0
}

(This is running terraform apply immediately after the resources is created without changing the config in between)

If make an aws cli call to get info on the current state of this stage, it shows DefaultRouteSettings as:

"DefaultRouteSettings": {
    "DetailedMetricsEnabled": false
},

with no other settings.

Steps to Reproduce

  1. Add stage to terraform config
  2. terraform apply (resource created fine)
  3. terraform apply (error shows up)

References

  • #9232 (resource introduced)

created time in a month

startedhashicorp/go-memdb

started time in a month

startedmanifoldco/promptui

started time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 2e1ca3924ec00f2d191053fadb9e66c6f95a0d17

Add gitter badge to README

view details

push time in a month

delete branch LaurenceGA/go-crev

delete branch : templates

delete time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 27d1228ac41de0153821b0dcb2ecd52c749a5c5e

Create PR template

view details

LaurenceGA

commit sha efccf97a624882fd7f5501ede5445b3ed4f849b9

Add some issue templates

view details

Laurence Armstrong

commit sha ef0718b47af5190bd7ddb56ecde7f912718ec31d

Merge pull request #16 from LaurenceGA/templates PR and issue templates

view details

push time in a month

PR merged LaurenceGA/go-crev

PR and issue templates documentation

Closes #10

+52 -0

0 comment

3 changed files

LaurenceGA

pr closed time in a month

issue closedLaurenceGA/go-crev

PR and Issues templates

To help structure contributions...

Issue templates PR tempaltes

closed time in a month

LaurenceGA

PR opened LaurenceGA/go-crev

PR and issue templates documentation

Closes #10

+52 -0

0 comment

3 changed files

pr created time in a month

create barnchLaurenceGA/go-crev

branch : templates

created branch time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 83f0da7fa283ca6f4a7ca025e5cebf78574d1476

Add codeowner

view details

push time in a month

delete branch LaurenceGA/go-crev

delete branch : check-existing-repo

delete time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 910c2ccb116dfc55e662d583be9e6b4412c9ba1b

Add call to fetch standard repo

view details

LaurenceGA

commit sha 4a21a30422e37fd0e6beb6ff118edff9ae6a8f7b

Merge branch 'master' into check-existing-repo

view details

LaurenceGA

commit sha 208d103c56fadc025fa34ad2d57b2ec770dfbae6

Detect existing proof repo

view details

LaurenceGA

commit sha cb6d9e57558a8afcdf955e7046ed7d79cd1604e8

Clone repo if exists

view details

LaurenceGA

commit sha 6b2e2c382ea5cb598e3b85f556d56e7e14a538a6

Return proof store from fetch

view details

LaurenceGA

commit sha 3452cff8800cf780b6e39a379d2b218864dcbadf

Auto set crev store on ID set

view details

Laurence Armstrong

commit sha 8854658bf99f59466993e8324d6d22a6fbfa1c31

Merge pull request #15 from LaurenceGA/check-existing-repo Check existing repo

view details

push time in a month

PR merged LaurenceGA/go-crev

Check existing repo enhancement

Check for standard crev proof repo at https://github.com/{username}/crev-proofs and load it if it exists

+518 -93

0 comment

16 changed files

LaurenceGA

pr closed time in a month

PR opened LaurenceGA/go-crev

Check existing repo enhancement

Check for standard crev proof repo at https://github.com/{username}/crev-proofs and load it if it exists

+518 -93

0 comment

16 changed files

pr created time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 6b2e2c382ea5cb598e3b85f556d56e7e14a538a6

Return proof store from fetch

view details

LaurenceGA

commit sha 3452cff8800cf780b6e39a379d2b218864dcbadf

Auto set crev store on ID set

view details

push time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha cb6d9e57558a8afcdf955e7046ed7d79cd1604e8

Clone repo if exists

view details

push time in a month

push eventLaurenceGA/go-crev

LaurenceGA

commit sha 208d103c56fadc025fa34ad2d57b2ec770dfbae6

Detect existing proof repo

view details

push time in a month

more