profile
viewpoint

Koala-gentil/DeepReinforcementLearning 0

A replica of the AlphaZero methodology for deep reinforcement learning in Python

Koala-gentil/tsconfig.json 0

Quickly create an opinionated tsconfig.json

Koala-gentil/vscode-sql-tagged-template-literals 0

VS Code extension, which enables syntax highlighting for SQL in template literals tagged with an `sql` function

startedvendure-ecommerce/vendure

started time in a month

startedcodemix/ts-sql

started time in a month

issue closedkelektiv/node.bcrypt.js

Feature request: calibrate salt_rounds

The bcrypt-ruby gem has a function called calibrate(max_time) (doc) which return the max salt_rounds to hash a password in less than max_time.

This feature is very useful to get the best salt_rounds on your running server.

Is it possible to add the same function ?

closed time in a month

Koala-gentil

issue openedkelektiv/node.bcrypt.js

Feature request: calibrate salt_rounds

The bcrypt-ruby gem has a function called calibrate(max_time) (doc) which return the max salt_rounds to hash a password in less than max_time.

This feature is very useful to get the best salt_rounds on your running server.

Is it possible to add the same function ?

created time in a month

fork Koala-gentil/tsconfig.json

Quickly create an opinionated tsconfig.json

fork in a month

issue openedbenawad/tsconfig.json

Node versions

The tsconfig for node is not optimal if using node v14. Could we add new configs suffixed with node version ? And maybe we could use process.version to infer the correct config.

More information about optimal tsconfig for node v14 can be found here

created time in 2 months

issue commentsideway/joi

stripUnknown doesn't work for nested objects

In this case everything work as expected, the validation fail but continue and strip unknown fields

const Joi = require('joi');

const schema = Joi.object({
    foo: Joi.string(),
    nested: Joi.object({
        bar: Joi.string(),
    })
})

const options = {
    abortEarly: false,
    allowUnknown: true,
    presence: 'required',
    stripUnknown: true,
}

const input = {
    foo: null, // invalid value
    unknown: 'unknown',
    nested: {
        bar: 'bar', // valid value
        unknown: 'unknown',
    }
}

const { value } = schema.validate(input, options)
// { foo: null, nested: { bar: 'bar' } }

There is definitely an inconsistent behavior with nested objects and stripUnknown when abortEarly is false. Please re-open @hueniverse

Koala-gentil

comment created time in 2 months

issue commentsideway/joi

stripUnknown doesn't work for nested objects

unless the abortEarly option has been set to false.

Koala-gentil

comment created time in 2 months

issue openedsideway/joi

stripUnknown doesn't works for nested objects

<!-- ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ You must complete this entire issue template to receive support. You MUST NOT remove, change, or replace the template with your own format. A missing or incomplete report will cause your issue to be closed without comment. Please respect the time and experience that went into this template. It is here for a reason. Thank you! ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ -->

Support plan

<!-- We are here to help!

Community based support is, by its nature, limited to available community members able to help. Most community support issues are resolved within 2 weeks. Before submitting an issue, please review the various support options available at https://hapi.dev/support/. That page includes useful information about different ways to ask questions. -->

  • is this issue currently blocking your project? (yes/no): yes
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: v14.6.0
  • module version with issue:
  • last module version without issue:
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): standalone
  • any other relevant information:

What are you trying to achieve or the steps to reproduce?

<!-- Describe your issue in detail, including full steps to reproduce the issue, any configuration, schemas, code samples, or inputs needed. Make sure to wrap all code examples in backticks so that they display correctly. Before submitting an issue, make sure to click on the Preview tab above to verify everything is formatted correctly. -->

It looks like stripUnknown doesn't works for nested object when the nested object has invalid fields.

const schema = Joi.object({
    foo: Joi.string(),
    nested: Joi.object({
        bar: Joi.string(),
    })
})

const options = {
    abortEarly: false,
    allowUnknown: true,
    presence: 'required',
    stripUnknown: true,
}

const input = {
    foo: null, // invalid value
    unknown: 'unknown',
    nested: {
        bar: null, // invalid value
        unknown: 'unknown',
    }
}

const { value } = schema.validate(input, options)
// { foo: 'foo', nested: { bar: 12, unknown: 'unknown' } }

What was the result you got?

bar.unknow is still present

What result did you expect?

It should have been "stripped"

created time in 2 months

fork Koala-gentil/joi

The most powerful data validation library for JS

fork in 2 months

issue closedKoala-gentil/hello-github-actions

Congratulations

Nice work!

celebrate

You've created your first GitHub Action and this course is now complete! I'll stop responding but the fun doesn't have to stop here.

Want to keep learning?

<!-- Continue learning about actions by taking the next course in the GitHub Actions Learning Path -->

In this repository:

  • Your merge should trigger your action again, check it out in the Actions tab.
  • The Dockerfile contains metadata for your action. Try changing some of that. You could, for example, change the icon that displays when the action is running.
  • Change the MY_NAME environment variable to use your name instead of Mona's in .github/workflows/main.yml.
  • Change the contents of entrypoint.sh to output a different message.

Outside of this repository:

Now...what will you learn next?

closed time in 3 months

github-learning-lab[bot]

delete branch Koala-gentil/hello-github-actions

delete branch : first-action

delete time in 3 months

push eventKoala-gentil/hello-github-actions

Hugo Doyer

commit sha 0371ef626c92898d996f0bffc7f1920cf04e5d94

first action

view details

Hugo Doyer

commit sha bd82c373aa0c99c998700b92d956472133aed506

add entrypoint.sh

view details

Hugo Doyer

commit sha 1e78e52f965f403547f2360d88a58e8b0b9654f2

add action.yml

view details

Hugo Doyer

commit sha 970bd7eef975ceead14f142e98d77bd56261b87a

add main.yml

view details

Hugo Doyer

commit sha 1a6aefaa2b7558be5f5787425ea5c0daebc81cd3

update main.yml

view details

Koala-gentil

commit sha 7eff866eb463acac9ed52298e02970cae7176acf

Merge pull request #2 from Koala-gentil/first-action first action

view details

push time in 3 months

push eventKoala-gentil/hello-github-actions

Hugo Doyer

commit sha 1a6aefaa2b7558be5f5787425ea5c0daebc81cd3

update main.yml

view details

push time in 3 months

push eventKoala-gentil/hello-github-actions

Hugo Doyer

commit sha 970bd7eef975ceead14f142e98d77bd56261b87a

add main.yml

view details

push time in 3 months

push eventKoala-gentil/hello-github-actions

Hugo Doyer

commit sha 1e78e52f965f403547f2360d88a58e8b0b9654f2

add action.yml

view details

push time in 3 months

push eventKoala-gentil/hello-github-actions

Hugo Doyer

commit sha bd82c373aa0c99c998700b92d956472133aed506

add entrypoint.sh

view details

push time in 3 months

create barnchKoala-gentil/hello-github-actions

branch : first-action

created branch time in 3 months

create barnchKoala-gentil/hello-github-actions

branch : master

created branch time in 3 months

created repositoryKoala-gentil/hello-github-actions

created time in 3 months

more