profile
viewpoint
Wenlu Wang Kingwl @Microsoft Beijing, China 专业LGTM👍

HearTao/ts-bc 12

Yet another JS to JS transpiler implemented in JS

HearTao/class-component-converter 7

Transform your vue class component to functional api

HearTao/ts-cli-creator 5

Yet another cli generator based TypeScript code

HearTao/ts-binary-ast 4

An implement for https://tc39.github.io/proposal-binary-ast/

HearTao/ts-ez-host 1

Easy TypeScript VFS implement, make with ❤

Kingwl/ant-design 1

🐜 A UI Design Language

pull request commentmicrosoft/TypeScript

Add static index signature

@typescript-bot run tests.

Kingwl

comment created time in 20 hours

pull request commentmicrosoft/TypeScript

Add static index signature

@typescript-bot test this.

Kingwl

comment created time in 20 hours

issue commentmicrosoft/vscode

Var in function gets Codelens if same name

And it's has merged. ping @mjbvz .

pushkine

comment created time in 20 hours

issue commentmicrosoft/vscode

Var in function gets Codelens if same name

Sorry....But I think I have already resolved the issue.

pushkine

comment created time in a day

Pull request review commentmicrosoft/vscode

Add better support for checkout type config

 async function categorizeResourceByResolution(resources: Resource[]): Promise<{  function createCheckoutItems(repository: Repository): CheckoutItem[] { 	const config = workspace.getConfiguration('git');-	const checkoutType = config.get<string>('checkoutType') || 'all';-	const includeTags = checkoutType === 'all' || checkoutType === 'tags';-	const includeRemotes = checkoutType === 'all' || checkoutType === 'remote';--	const heads = repository.refs.filter(ref => ref.type === RefType.Head)-		.map(ref => new CheckoutItem(ref));-	const tags = (includeTags ? repository.refs.filter(ref => ref.type === RefType.Tag) : [])-		.map(ref => new CheckoutTagItem(ref));-	const remoteHeads = (includeRemotes ? repository.refs.filter(ref => ref.type === RefType.RemoteHead) : [])-		.map(ref => new CheckoutRemoteHeadItem(ref));--	return [...heads, ...tags, ...remoteHeads];+	const checkoutType = config.get<string>('checkoutType') || 'local,remote,tags';+	const checkoutTypes = checkoutType.trim().split(',').map(type => type.trim());++	const results: CheckoutItem[] = [];+	const invalids = new Set<string>();+	const seens = new Set<string>();+	checkoutTypes.forEach(type => {+		if (seens.has(type)) {+			return;+		}+		seens.add(type);++		switch (type) {+			case 'local':+				results.push(...repository.refs.filter(ref => ref.type === RefType.Head).map(ref => new CheckoutItem(ref)));+				break;+			case 'remote':+				results.push(...repository.refs.filter(ref => ref.type === RefType.RemoteHead).map(ref => new CheckoutRemoteHeadItem(ref)));+				break;+			case 'tags':+				results.push(...repository.refs.filter(ref => ref.type === RefType.Tag).map(ref => new CheckoutTagItem(ref)));+				break;+			default:+				invalids.add(type);

I‘m not sure. Any suggestions?

Kingwl

comment created time in a day

pull request commentmicrosoft/TypeScript

[Expirement] [WIP] Add deprecated related feature

Added some test, something need confirm:

  1. I ’m not very familiar with these, what kind of tests do I need to add. 2.Should all part of qualified name (eg: type T = [|Foo.Bar|] ) marked as deprecated?
Kingwl

comment created time in a day

push eventKingwl/TypeScript

Jacob Bandes-Storch

commit sha 61f60057f1798cae92781a1f2d6521a5f378a1a1

Better error message for accidental calls to get-accessors

view details

Jacob Bandes-Storch

commit sha d00a5c954f3a032226a7249e3e97f93bc9060986

Add _0_is_declared_here pointing to accessor declaration

view details

Jacob Bandes-Storch

commit sha d00f2b53adb1dafbba33ac07227b21a62d4acb53

replace the original not-callable error

view details

Jacob Bandes-Storch

commit sha 6051fc1814e9344c5c0f35eec9bac325822ea23a

move to invocationErrorDetails

view details

Jacob Bandes-Storch

commit sha fd4eccee6cd7fb816cac00b1a625e4b43bf0d1a3

Merge remote-tracking branch 'upstream/master' into diagnose-accidental-accessor-call

view details

Jacob Bandes-Storch

commit sha 0b1cb745301e2582d6ba18fd3817d40f6d4b13a4

fix order and tests

view details

David Sherret

commit sha 84f89f8702cc4472b949eb980db23fef564936a6

Fix some JSDoc factory function return types.

view details

Song Gao

commit sha df772327fe2f9089bcc534eccbf36026b69db03d

make last para of Actomics.notify optional.

view details

Alexander T

commit sha 1c72da6e49b15ee160e162eaf24ad0047e7ac7ea

fix(38463): show completions for index access properties

view details

Alexander T

commit sha 528d82afd1a4d67a905fc789f71ca830bc7fa28a

Merge branch 'master' of https://github.com/microsoft/TypeScript into bug/38463

view details

Alexander T

commit sha e04ab6938a9ad017f9c71e40553455a440e1a5b3

fix(38295): handle duplicate object literal keys which contain '+' and '-' tokens

view details

Dmitry Makhnev

commit sha dbaeed5ad87cf846dddf0d278df3699e9f91cd21

Add d.ts for Intl.RelativeTimeFormat (#36084) * feat(lib/es2020.intl): Add `Intl.RelativeTimeFormat` (part of #29129); * fix(lib/es2020.intl): fix for tests and linters `Intl.RelativeTimeFormat` (part of #29129); * feat(lib/es2020.intl): Add TSDoc for `Intl.RelativeTimeFormat` by review request https://github.com/microsoft/TypeScript/pull/36084#issuecomment-584769420; * fix(lib/es2020.intl): Fix for tests; Co-authored-by: Dmitry Makhnev <dmitriy.makhnev@jugru.org>

view details

Alexander T

commit sha 2cea9d9d956f2577dfabee05e1abd0ef8b1074e8

fix(38682): use stable typescript version (#38683)

view details

Alexander T

commit sha a7364bf534660590c5032f863b67d530f62462f4

Merge branch 'master' of https://github.com/microsoft/TypeScript into bug/38463

view details

Alexander T

commit sha bbf56b044bd29d77b319ccb3b34671cb143afc0b

Merge branch 'master' of https://github.com/microsoft/TypeScript into bug/38295

view details

Anders Hejlsberg

commit sha a56960303d18eae609493b4225f4c7de5e87c89d

Intersection check for empty object type shouldn't cause circularities (#38673) * isEmptyAnonymousObjectType shouldn't require full member resolution * Add regression test

view details

Nathan Shively-Sanders

commit sha c526b425efd253c1624db89a753f0e74ef8eaf5f

Merge pull request #38498 from ShuiRuTian/make-atomics.notify-type-correct make Atomics.notify last parameter optional

view details

Nathan Shively-Sanders

commit sha 68f8f220323f5ec62cdc5157e03b82ad92d5b458

Merge pull request #38425 from dsherret/fixJSDocTagFactoryFuncReturnTypes Fix some JSDoc factory function return types

view details

Alexander T

commit sha 4e945fbc98451ea5e2b627c2dfff2edea1c7aacd

fix(38299): use string literals as keys to creating rest result (#38600)

view details

Nathan Shively-Sanders

commit sha 3340142dda47f52af55144130304eef19a97ec31

Merge pull request #38607 from a-tarasyuk/bug/38295 fix(38295): Duplicated object key in const not detected when the key is a number preceded by `-` or `+`

view details

push time in a day

push eventKingwl/TypeScript

kingwl

commit sha e796f20cf20702f6843ee22964ab26f943284fb8

Add tests

view details

push time in a day

issue openedmicrosoft/vscode

[Git] git add for current file command

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. --> It's useful for only add one file who with many other files inside the same level of folder.

- src
- - fileA.ts
- - fileB.ts
- - fileC.ts
- - fileD.ts

both of file A, B, C, D has modified, but only want to add A into the index.

created time in 4 days

pull request commentmicrosoft/TypeScript

[Expirement] [WIP] Add deprecated related feature

For Milestones Bug I guess.

Kingwl

comment created time in 4 days

issue commentmicrosoft/TypeScript

Feature Request / Proposal: constructor type guard

Because #32774 is merged.

sheley1998

comment created time in 6 days

push eventKingwl/TypeScript

kingwl

commit sha fed922a5cbe0d50c491e009c488f7303a15e5b95

Accept baseline

view details

push time in 6 days

push eventKingwl/TypeScript

kingwl

commit sha 2997860c2e475bd2a9950f55c5ac8b386639301a

fix names

view details

push time in 6 days

push eventKingwl/TypeScript

kingwl

commit sha b73411c985be1406de882af076e07b829b458eb8

Fix type and simplify code

view details

push time in 6 days

issue commentmicrosoft/TypeScript

Refactoring to convert && chain to optional chain expression

Are there any existed tools or algorithms to compare expression and judge they are equality? I have some ugly work about it but they cannot work well.

DanielRosenwasser

comment created time in 7 days

pull request commentmicrosoft/TypeScript

Add static index signature

Seems eslint is broken, not my fault.

Kingwl

comment created time in 7 days

push eventKingwl/TypeScript

kingwl

commit sha a13190af8a4ce477f10abc2203a3270446bf2695

Add more case

view details

kingwl

commit sha 52884cc5b2185958d9be421962d633ff376bb34b

accept baseline

view details

kingwl

commit sha 56099855b27a1a4a56d73e10e8c76580498ae192

fix error if extends others

view details

push time in 7 days

pull request commentmicrosoft/TypeScript

Add static index signature

Seems something wrong if extends others

Kingwl

comment created time in 7 days

push eventKingwl/TypeScript

Alexander T

commit sha 72a04117769a740acea8add41a678023dd0448c2

fix(37431): allow only one space between async keyword and method name (#37504)

view details

Andrew Branch

commit sha 3810c2fe6b345f5ab9fb613421f6d68b573ec2e9

Fix rename for type symbols imported as a different name (#37745) * Add failing test * Fix getMeaningFromLocation for imports * Only the name of an ImportEqualsDeclaration counts * Commit baseline

view details

Zixiang Li

commit sha 54b0e4acc56384780f08db0a255e848d3d3c3020

Fix goto implementation does not suggest all subtypes (#33652)

view details

Wenlu Wang

commit sha afc41f095d9337d57bee71f287ebf7ef39c8bdfb

Quick fix for functions lacking return expressions (#26434) * stash * add surmise for return type * add support for more case * add more test case * add more testcase and fix all test * fix changed diagnosis * fix broken test case * add more case * rename quickfix * fix conflict * fix fix desc * fix semi * Avoid replace brace with paren * Split fix all action * Add return work in same line * fix test cases * rename baseline * refactor and handle comment * Support semi * make helper internal

view details

Alexander T

commit sha 696413749b485c085fe8aff0efbe21339d0c5c53

fix(37456): add tests for JsxOpeningElement nodes (#37752)

view details

Nathan Shively-Sanders

commit sha 527f4679269f998a104708f91c73a0b8629b8fbb

Remove error when spreading optional any (#37757) Previously, spreading an optional any gave a bogus error when the name conflicted with earlier properties in the object literal. Now the code checks any types for optionality before issuing the error. Fixes #37740

view details

Andrew Branch

commit sha 2187ba1f848ebfbb5ab2f0aeef2abca8167eb5ba

Fix variable name collisions (#37761)

view details

Anders Hejlsberg

commit sha 349ae45a2c2a0cefd034491624f095e68ae5c757

Reduce intersections with conflicting privates, elaborate on reasons (#37762) * Elaborate on reasons for 'never' intersections * Accept new API baselines * Accept new baselines * Add tests * Accept new baselines * Address CR feedback

view details

Wesley Wigham

commit sha 6d25c01d0973254038bb20ac8a088e67ff87f48d

Cache the regularized form of union types (#37749) * Cache the regularized form of union types * Inline function because why not * Introduce two fastpasths into isRelatedTo

view details

csigs

commit sha c787252e00d29027760b55d9e8c33a9ddd2c7b28

LEGO: check in for master to temporary branch.

view details

csigs

commit sha d68295e74e4897f588e73edf72089eb238904f02

LEGO: Merge pull request 37766 LEGO: Merge pull request 37766

view details

Nathan Shively-Sanders

commit sha 7cf4b12d8835ebaf590d8a29a23290500c756fec

Fix crash for private identifier in expando assignments (#37764) * Fix crash for private identifier in expando assignments It does this by disallowing private identifiers from expando assignments entirely. I haven't thought of a scenario where they make sense, but I haven't thought about it exhaustively either. Fixes #37356 * Update baselines I think the new error is probably better. It's certainly different!

view details

Wesley Wigham

commit sha 731729278294e57159951086cf37f10693e250df

Consider arrays and tuples within one another as possibly requiring deferral (#37776)

view details

Orta

commit sha 20ecbb0f46105ccaead2970f6ef23188955e023e

Allow Source Mapping inside destructuring assignment (#37298) * Add support for source maps inside of destructured code * Adds tests for the source maps inside destructured code

view details

Nathan Shively-Sanders

commit sha eac073894b172ec719ca7f28b0b94fc6e6e7d4cf

Fix serialisation of static class members in JS (#37780) * Fix serialisation of static class members in JS Previously static class members would be treated the same way as expando namespace assignments to a class: ```ts class C { static get x() { return 1 } } C.y = 12 ``` This PR adds a syntactic check to the static/namespace filter that treats symbols whose valueDeclaration.parent is a class as statics. Fixes #37289 * fix messed-up indent * Extract function

view details

Anders Hejlsberg

commit sha 5a4024dd9d2d6c67ce017eba01cec7397f446f71

Generic functions are never context sensitive (#37811) * Functions with type parameters are never contextsensitive * Add tests

view details

Anders Hejlsberg

commit sha a2609b1f1b58f9b6ef62cb3b6ff47efb35059eee

Extra check in assignment of intersections with generic constituents (#37537) * Consolidated extra property check with intersections * Fix comment * Add tests * Properly propagate intersectionState * Route property check through recursive type tracking logic * Accept new baselines * Skip check when apparent type of source is never * Accept new baselines * Only check when apparent type of source is a structured type

view details

Nathan Shively-Sanders

commit sha 7ca6334dbd1d58984dc364b7b7fb3e453e3b1649

Look for outer type parameters on VariableStatements (#37819) This only applies in JS, where `@template` tags can apply to initialisers of variable declarations: ```js /** * @template T * @returns {(b: T) => T} */ const seq = a => b => b ``` Fixes #36201

view details

Bannerets

commit sha c47aca0da321663415b7fc2ed000f66c4d7bcb5d

Accurate Array.prototype.flat definition (#32131) * Better Array.prototype.flat definition * Use more meaningful names * Rename 'Flat' to 'FlatArray'

view details

Andrew Branch

commit sha 3e86f15f5101a354625427befbd907e3bac57b30

Disambiguate types with same name from different namespaces in mapToTypeNodes (#37543) * Disambiguate types with same name from different namespaces in mapToTypeNodes * Update baseline with additional example * Fix typo

view details

push time in 7 days

push eventKingwl/TypeScript

kingwl

commit sha 2d61217b8d7c46a5c3c89497eaa9b4d07e7b8bb1

add more cases

view details

push time in 7 days

startedcli/cli

started time in 7 days

push eventKingwl/TypeScript

kingwl

commit sha b59e4c51ae37ced7ea097011834cf31fbec6b117

Merge branch 'master' into logical_assignment

view details

push time in 7 days

Pull request review commentmicrosoft/TypeScript

Add logical assignment operator

 namespace ts {                         case "readonly":
                             tag = parseSimpleTag(start, SyntaxKind.JSDocReadonlyTag, tagName);
                             break;
+                        case "deprecated":

Oh ....

Kingwl

comment created time in 7 days

Pull request review commentmicrosoft/TypeScript

Add logical assignment operator

 namespace ts {                         case "readonly":
                             tag = parseSimpleTag(start, SyntaxKind.JSDocReadonlyTag, tagName);
                             break;
+                        case "deprecated":

What's up...

Kingwl

comment created time in 7 days

push eventKingwl/TypeScript

Alexander T

commit sha ee3f2ce36258bf8c32e304d3a676068c674872d8

regression(38485): allow using rawText property in processing a tagged template

view details

Alexander T

commit sha 2b703d254a72d78740d65dc1c6743ae00245e404

fix(33233): add outlining for comments before property access expression

view details

csigs

commit sha 48d6e8dee5f5218c52a0aeee32d009e95b867439

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 160d201fe6b0c0ae31a0014972f9c7e1e7d1fc80

LEGO: Merge pull request 38639 LEGO: Merge pull request 38639

view details

csigs

commit sha 92dc5b8754c71ff1d69a3f317984248bd4cfa1ad

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 6ba8c2725b748b257d9a5e86e421d8f29facb04f

LEGO: Merge pull request 38650 LEGO: Merge pull request 38650

view details

csigs

commit sha 90b772a751c6cd56a9f5f07a7cec5bf0cc4ed151

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 611dd22b9afd72a48b052d639988d0b6058fffff

LEGO: Merge pull request 38655 LEGO: Merge pull request 38655

view details

Tim van der Lippe

commit sha e72e01d9ff551b7cf927dccbf26ceec2a2e9acfe

Remove mentions of runtests-browser in CONTRIBUTING.md The gulp tasks were removed in #30054, but the contributing guidelines weren't updated accordingly.

view details

Tim van der Lippe

commit sha 77075df2d7c63d4dcdf3989d1b80bb90a09cd7c4

Fix debug command for Node debugging If you would run with `--inspect=true`, the following error would be thrown: [12:08:13] > node --inspect-brk=true TypeScript/node_modules/mocha/bin/_mocha -R scripts/failed-tests -O "reporter=mocha-fivemat-progress-reporter" -g "implementsJSDocReferencesDeclarationEmit" --colors -t 0 built/local/run.js Unable to resolve "true": unknown node or service

view details

Andrew Branch

commit sha 707e9770564865d10168e3722eec4eb9e20d32db

Ensure formatter can always get a newline character (#38579) * Ensure formatter can always get a newline character * Make FormatContext.host optional since it’s not necessary if format options are all applied * Make FormattingHost required again

view details

Nathan Shively-Sanders

commit sha f7007174f60ee74a115e342d2c5eb90e3f2eed2e

Merge pull request #38660 from TimvdLippe/patch-4 Fix debug command for Node debugging

view details

Nathan Shively-Sanders

commit sha 2227ba749c675545c682f48d7a1bda767abacc82

Merge branch 'master' into patch-3

view details

Anders Hejlsberg

commit sha 7ba0a6592d159999cb4a9dcb91fca0e7765bbbf1

No contextual types from circular mapped type properties (#38653) * No contextual types from circular mapped type properties * Add regression test

view details

Nathan Shively-Sanders

commit sha c5cca0ec1881f9ff934db0d6d4af9ed57eaea2ad

Merge pull request #38659 from TimvdLippe/patch-3 Remove mentions of runtests-browser in CONTRIBUTING.md

view details

Nathan Shively-Sanders

commit sha 415b2e7969d8f43a111231e98264a34edc80e919

Merge pull request #38656 from a-tarasyuk/bug/33233 fix(33233): Code Folding on es5 object functions does not work (getOutliningSpans)

view details

Daniel Rosenwasser

commit sha 46f100f8acb9e8b3eb0f186551facc3516a7f26c

Merge pull request #38500 from a-tarasyuk/bug/38485 regression(38485): Unable to specify `rawText` when programmatically creating tagged template literals

view details

Jack Works

commit sha 7ec467e270699aba9978cad5d672ca5718ee47c2

fix: extract const in jsx (#37912) * fix: extract const in jsx * Update src/services/refactors/extractSymbol.ts Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com> * Update src/services/refactors/extractSymbol.ts Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com> Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>

view details

csigs

commit sha 0e4f1cb407055143f524162c76ab6cbaffae8f33

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 24f53b06d23d30c437f7926c95f8784b8b06366a

LEGO: Merge pull request 38670 LEGO: Merge pull request 38670

view details

push time in 7 days

push eventKingwl/TypeScript

kingwl

commit sha 6ff08ee950b204f6f8f8a6963b58e986172fd64a

Add logical assignment operator

view details

kingwl

commit sha f512328f332f402a0a7398729bd3a1773652d4da

Add more case

view details

kingwl

commit sha 49404f974acacb252b456a9a05d684b7617566a8

Add mission semi

view details

kingwl

commit sha 5bcfafac47598552beace2cbc99d24e3b8ebcc3c

Add contextual types infer

view details

kingwl

commit sha f8812c906676900df1ed1e093fd7994549f1ff93

Add cfa

view details

kingwl

commit sha f8bf4e1e33afc9e1b49cab9c71ea4ef604aa0824

Add more check

view details

Wenlu Wang

commit sha 0a68f379d9246595eb90a26f1050c19db4ce6ed5

Update src/compiler/transformers/utilities.ts Co-Authored-By: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

view details

kingwl

commit sha cd6e46963223b1e310cbf8d6f02d4984f930d837

Fix cfa

view details

kingwl

commit sha 1c92781ad7630da4a3689b4417ad1010fe896b67

Merge branch 'master' into logical_assignment

view details

kingwl

commit sha de6eadf825e35e956207af8d8a9b438cbc80f2d0

make ci happy

view details

kingwl

commit sha a6e0086462f097c885d3937a5126891e6bb0b847

fix operator

view details

kingwl

commit sha 1ed6a3e396ea8e16fc76a01140dd5095885aed3a

Refactor logical assignment

view details

kingwl

commit sha 8a9e234518c492ae3cb21b99feb2ea428e12eeeb

Add more case

view details

kingwl

commit sha 0117e482b3051d7e697d0944644099755c087de4

Add type narrow

view details

kingwl

commit sha 2b2ad52632f8494592957abad0b600e800b36d88

fix assignment check of logical assignment

view details

Wenlu Wang

commit sha ecc0828420e3732535cbd3cb89b73c60ea26d2ee

Merge branch 'master' into logical_assignment

view details

Daniel Rosenwasser

commit sha e02591dfcb53ca02c7293728fd0ecd2b7d999d48

Remove newline

view details

kingwl

commit sha b62c8c8d1bdf9b55d07059f282deb65409702d39

avoid shouldCaptureInTempVariable

view details

kingwl

commit sha 77ab110870da3cff8d81857d6f1c0c3f1c9e7149

Merge branch 'master' into logical_assignment

view details

kingwl

commit sha db68092435b2bf7f14df7a6160ac5ade1a07d373

fix mission baseline

view details

push time in 7 days

push eventKingwl/TypeScript

Alexander T

commit sha ee3f2ce36258bf8c32e304d3a676068c674872d8

regression(38485): allow using rawText property in processing a tagged template

view details

Alexander T

commit sha 2b703d254a72d78740d65dc1c6743ae00245e404

fix(33233): add outlining for comments before property access expression

view details

csigs

commit sha 48d6e8dee5f5218c52a0aeee32d009e95b867439

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 160d201fe6b0c0ae31a0014972f9c7e1e7d1fc80

LEGO: Merge pull request 38639 LEGO: Merge pull request 38639

view details

csigs

commit sha 92dc5b8754c71ff1d69a3f317984248bd4cfa1ad

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 6ba8c2725b748b257d9a5e86e421d8f29facb04f

LEGO: Merge pull request 38650 LEGO: Merge pull request 38650

view details

csigs

commit sha 90b772a751c6cd56a9f5f07a7cec5bf0cc4ed151

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 611dd22b9afd72a48b052d639988d0b6058fffff

LEGO: Merge pull request 38655 LEGO: Merge pull request 38655

view details

Tim van der Lippe

commit sha e72e01d9ff551b7cf927dccbf26ceec2a2e9acfe

Remove mentions of runtests-browser in CONTRIBUTING.md The gulp tasks were removed in #30054, but the contributing guidelines weren't updated accordingly.

view details

Tim van der Lippe

commit sha 77075df2d7c63d4dcdf3989d1b80bb90a09cd7c4

Fix debug command for Node debugging If you would run with `--inspect=true`, the following error would be thrown: [12:08:13] > node --inspect-brk=true TypeScript/node_modules/mocha/bin/_mocha -R scripts/failed-tests -O "reporter=mocha-fivemat-progress-reporter" -g "implementsJSDocReferencesDeclarationEmit" --colors -t 0 built/local/run.js Unable to resolve "true": unknown node or service

view details

Andrew Branch

commit sha 707e9770564865d10168e3722eec4eb9e20d32db

Ensure formatter can always get a newline character (#38579) * Ensure formatter can always get a newline character * Make FormatContext.host optional since it’s not necessary if format options are all applied * Make FormattingHost required again

view details

Nathan Shively-Sanders

commit sha f7007174f60ee74a115e342d2c5eb90e3f2eed2e

Merge pull request #38660 from TimvdLippe/patch-4 Fix debug command for Node debugging

view details

Nathan Shively-Sanders

commit sha 2227ba749c675545c682f48d7a1bda767abacc82

Merge branch 'master' into patch-3

view details

Anders Hejlsberg

commit sha 7ba0a6592d159999cb4a9dcb91fca0e7765bbbf1

No contextual types from circular mapped type properties (#38653) * No contextual types from circular mapped type properties * Add regression test

view details

Nathan Shively-Sanders

commit sha c5cca0ec1881f9ff934db0d6d4af9ed57eaea2ad

Merge pull request #38659 from TimvdLippe/patch-3 Remove mentions of runtests-browser in CONTRIBUTING.md

view details

Nathan Shively-Sanders

commit sha 415b2e7969d8f43a111231e98264a34edc80e919

Merge pull request #38656 from a-tarasyuk/bug/33233 fix(33233): Code Folding on es5 object functions does not work (getOutliningSpans)

view details

Daniel Rosenwasser

commit sha 46f100f8acb9e8b3eb0f186551facc3516a7f26c

Merge pull request #38500 from a-tarasyuk/bug/38485 regression(38485): Unable to specify `rawText` when programmatically creating tagged template literals

view details

Jack Works

commit sha 7ec467e270699aba9978cad5d672ca5718ee47c2

fix: extract const in jsx (#37912) * fix: extract const in jsx * Update src/services/refactors/extractSymbol.ts Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com> * Update src/services/refactors/extractSymbol.ts Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com> Co-authored-by: Andrew Branch <andrewbranch@users.noreply.github.com>

view details

csigs

commit sha 0e4f1cb407055143f524162c76ab6cbaffae8f33

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 24f53b06d23d30c437f7926c95f8784b8b06366a

LEGO: Merge pull request 38670 LEGO: Merge pull request 38670

view details

push time in 7 days

push eventKingwl/TypeScript

Ron Buckton

commit sha 1cbe7ef0004d2ab716dd66571ded6379b20e71c2

Fix crash in JS declaration emit (#38508) * Fix crash in JS decl emit * Emit as class with private ctor

view details

Jesse Trinity

commit sha 1a15717bc4ad50a9ca3e0b5fbfa23ed2048a35ae

Fix regression organize imports duplicates comments (#38599) * delete import comments on organize imports * add unit test * accept new baseline * respond to review comment

view details

Eli Barzilay

commit sha d7dd06e36d9930898064135e5cc0884252f4735e

goToDefinition: find only the value if it's the RHS of an assignment

view details

Eli Barzilay

commit sha 33c3e9e2c6d1e67f90896aa7596a3144549b84cd

Make `processTaggedTemplateExpression` visit a returned node This problem was introduced in 70399e146e2 (from PR #23801), which added a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`, before that, it would fallback to the default of `visitNode`. So re-add that happen in `processTaggedTemplateExpression`. Since it doesn't hurt, I left a `Debug.checkDefined(property.name)` instead of `!`-ing it. Fixes #38558.

view details

csigs

commit sha d154b58406cfaf5a499b0ed8cdb697fb5390c74c

LEGO: check in for master to temporary branch.

view details

csigs

commit sha bc0d2ec26c36dbbbadfc04693f991e4e9bc0f8b6

LEGO: Merge pull request 38614 LEGO: Merge pull request 38614

view details

Anders Hejlsberg

commit sha 3c1f37e913d2ef3c359a4b04d414d3aba5f3f85c

Use control flow analysis to check 'super(...)' call before 'this' access (#38612) * Use CFA graph to check this/super accesses are preceded by super() call * Accept cleaned-up API baselines * Accept new baselines * Add tests

view details

csigs

commit sha 437d68d64b69e51270866101d38753f83e8c0970

LEGO: check in for master to temporary branch.

view details

csigs

commit sha b58c9f4f8e552c1c60c0bfeef957f2fa4628bc20

LEGO: Merge pull request 38633 LEGO: Merge pull request 38633

view details

kingwl

commit sha 6c7697a6a3e7eb27b9fd4df1190374dc4c4015d8

Merge branch 'master' of github.com:microsoft/TypeScript

view details

push time in 7 days

push eventKingwl/vscode

kingwl

commit sha f83949be5ebca7e21446e086c8aaf1c0d7287763

Add temp deps for build

view details

push time in 8 days

pull request commentmicrosoft/TypeScript

Add static index signature

Hi, Folks, I don't know what I can do. Should I work with the parser issue inside this PR?

Kingwl

comment created time in 8 days

push eventKingwl/vscode

kingwl

commit sha b516be9b5bb906b795ec6aad6d8f35fc48a644f5

Avoid styles

view details

push time in 8 days

push eventKingwl/vscode

kingwl

commit sha e71cbf5654334ed02c36be2c6661de575ab1175a

Avoid changes

view details

push time in 8 days

push eventKingwl/vscode

kingwl

commit sha f5e3a3b1d35c69fbb543e78f145688c38cb4d4f2

Avoid assign

view details

push time in 8 days

push eventKingwl/vscode

kingwl

commit sha 93bc5717b60023e5a43728e7ed2514baf70641f2

Avoid changes

view details

push time in 8 days

push eventKingwl/vscode

kingwl

commit sha faa29c094af4b7636774c894f3a7aa28827974a1

fix lint

view details

push time in 8 days

push eventKingwl/vscode

kingwl

commit sha 9cdfa00a9c8331a9334589c05f9cb564625822b1

fix lint

view details

push time in 8 days

pull request commentmicrosoft/TypeScript

[Expirement] [WIP] Add deprecated related feature

Finally, It passed tests. I'll add more tests soon. @typescript-bot pack this.

Kingwl

comment created time in 9 days

push eventKingwl/TypeScript

kingwl

commit sha ceeaead35e17e4fad7683b5a11480a8602865f6d

Avoid useless changes

view details

push time in 9 days

push eventKingwl/TypeScript

kingwl

commit sha c0a26e96ba000b1cd4206f290865e7aabf710d37

fix incorrect fix

view details

push time in 9 days

push eventKingwl/TypeScript

Wenlu Wang

commit sha 9725d623cea96f5e30dde3f330abed31cc445782

Fix build type error (#38525)

view details

Alexander T

commit sha 71711257eafedd26992dc1c640b6bbe029f898e7

fix(33836): allow readonly modifier for a field with only get accessor (#36543)

view details

Anders Hejlsberg

commit sha c1f676dd3f1337286bd99d3d189bc59c930b703d

Perform intersection reduction before and after getApparentType (#38565) * Perform intersection reduction before and after getApparentType * Add regression tests

view details

Greg Hurrell

commit sha cfc4573c827b8ed482e36546fa33be4152950a84

Fix (cosmetic) typos in checker.ts comments Just some small things I noticed while looking at some recent PRs.

view details

Daniel Rosenwasser

commit sha 89f7797f7e7c3985285ad8113eccf560bf9fecde

Merge pull request #38576 from wincent/typos Fix (cosmetic) typos in checker.ts comments

view details

Wesley Wigham

commit sha 7fc456f2d70348725bbef92732b98a33c07f85ad

Include unknown in spread prop override check (#38577)

view details

kingwl

commit sha 7b9ca8a122600595b2ba567a2433bf0b3edc6c40

Merge branch 'master' of github.com:microsoft/TypeScript

view details

Ron Buckton

commit sha 1cbe7ef0004d2ab716dd66571ded6379b20e71c2

Fix crash in JS declaration emit (#38508) * Fix crash in JS decl emit * Emit as class with private ctor

view details

Jesse Trinity

commit sha 1a15717bc4ad50a9ca3e0b5fbfa23ed2048a35ae

Fix regression organize imports duplicates comments (#38599) * delete import comments on organize imports * add unit test * accept new baseline * respond to review comment

view details

Eli Barzilay

commit sha d7dd06e36d9930898064135e5cc0884252f4735e

goToDefinition: find only the value if it's the RHS of an assignment

view details

Eli Barzilay

commit sha 33c3e9e2c6d1e67f90896aa7596a3144549b84cd

Make `processTaggedTemplateExpression` visit a returned node This problem was introduced in 70399e146e2 (from PR #23801), which added a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`, before that, it would fallback to the default of `visitNode`. So re-add that happen in `processTaggedTemplateExpression`. Since it doesn't hurt, I left a `Debug.checkDefined(property.name)` instead of `!`-ing it. Fixes #38558.

view details

csigs

commit sha d154b58406cfaf5a499b0ed8cdb697fb5390c74c

LEGO: check in for master to temporary branch.

view details

csigs

commit sha bc0d2ec26c36dbbbadfc04693f991e4e9bc0f8b6

LEGO: Merge pull request 38614 LEGO: Merge pull request 38614

view details

Anders Hejlsberg

commit sha 3c1f37e913d2ef3c359a4b04d414d3aba5f3f85c

Use control flow analysis to check 'super(...)' call before 'this' access (#38612) * Use CFA graph to check this/super accesses are preceded by super() call * Accept cleaned-up API baselines * Accept new baselines * Add tests

view details

csigs

commit sha 437d68d64b69e51270866101d38753f83e8c0970

LEGO: check in for master to temporary branch.

view details

csigs

commit sha b58c9f4f8e552c1c60c0bfeef957f2fa4628bc20

LEGO: Merge pull request 38633 LEGO: Merge pull request 38633

view details

kingwl

commit sha 6c7697a6a3e7eb27b9fd4df1190374dc4c4015d8

Merge branch 'master' of github.com:microsoft/TypeScript

view details

kingwl

commit sha a81c55f0834da80556c0ae545382877edefc1c3e

Merge branch 'master' into deprecated_support

view details

kingwl

commit sha af0189cfef0458c4908ffe88df49cea2ea47513b

fix jsdoc cache

view details

push time in 9 days

push eventKingwl/TypeScript

kingwl

commit sha ccb6301338e97f270338a5dd41311a5d4ec73995

fix baseline

view details

push time in 9 days

push eventKingwl/TypeScript

kingwl

commit sha 97fb3b7b39a64ac17fd245aae00ed967d5c003aa

Check deprecated in binder

view details

push time in 9 days

push eventKingwl/TypeScript

kingwl

commit sha 1801134eec595bc4df78a39f2f546239a24f468e

accept baseline

view details

push time in 10 days

push eventKingwl/TypeScript

kingwl

commit sha 1fad543f9595340766203140e2c75c6ac2d75926

avoid tags

view details

push time in 10 days

push eventKingwl/vscode

kingwl

commit sha 5d5df000b6af80754273c72c8457eb6dbb540b0c

avoid tags

view details

push time in 10 days

startedorta/playground-collaborate

started time in 10 days

push eventKingwl/TypeScript

kingwl

commit sha 7f4015137bd5606d4d7cf06ab9322f63ea46b186

avoid new tag

view details

push time in 10 days

pull request commentmicrosoft/TypeScript

Add logical assignment operator

Only one pipeline failed with ECONNRESET.

Kingwl

comment created time in 11 days

push eventKingwl/TypeScript

kingwl

commit sha 94a1b83eb2529c17ae732883d52ba38b5460a824

improve diagnostic

view details

push time in 11 days

push eventKingwl/TypeScript

kingwl

commit sha 6f393e9196d6df56024a0a6e5f53b8e0c6ab2f52

accept new baseline

view details

push time in 12 days

push eventKingwl/TypeScript

kingwl

commit sha acc167dfc473aa01fd7609105a3820d29c0c3d9e

fix rebase conflict

view details

push time in 12 days

push eventKingwl/TypeScript

Ron Buckton

commit sha 1cbe7ef0004d2ab716dd66571ded6379b20e71c2

Fix crash in JS declaration emit (#38508) * Fix crash in JS decl emit * Emit as class with private ctor

view details

Jesse Trinity

commit sha 1a15717bc4ad50a9ca3e0b5fbfa23ed2048a35ae

Fix regression organize imports duplicates comments (#38599) * delete import comments on organize imports * add unit test * accept new baseline * respond to review comment

view details

Eli Barzilay

commit sha d7dd06e36d9930898064135e5cc0884252f4735e

goToDefinition: find only the value if it's the RHS of an assignment

view details

Eli Barzilay

commit sha 33c3e9e2c6d1e67f90896aa7596a3144549b84cd

Make `processTaggedTemplateExpression` visit a returned node This problem was introduced in 70399e146e2 (from PR #23801), which added a `visitTaggedTemplateExpression` case for `TaggedTemplateExpression`, before that, it would fallback to the default of `visitNode`. So re-add that happen in `processTaggedTemplateExpression`. Since it doesn't hurt, I left a `Debug.checkDefined(property.name)` instead of `!`-ing it. Fixes #38558.

view details

kingwl

commit sha 1d93db81cc2182a026017b94a9a37730ed82aea1

Add logical assignment operator

view details

kingwl

commit sha da16b3e30beeeb0601c120f66ed75fe26f496375

Add more case

view details

kingwl

commit sha f92242719601224ecab193700d0b2e7b341eecfc

Add mission semi

view details

kingwl

commit sha 9190a2c4e8a9c5b87a3843d5268a3142d3406adb

Add contextual types infer

view details

kingwl

commit sha 82fe658a48076cb3d0aa53e9c2d49b75508735f6

Add cfa

view details

kingwl

commit sha ede6214157990584c678bbdb8c55f1b397a8f627

Add more check

view details

Wenlu Wang

commit sha 944bcf8459efe8eb678e0fde8e6fcb78add26eeb

Update src/compiler/transformers/utilities.ts Co-Authored-By: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>

view details

kingwl

commit sha ff4fca527dab06e89f15c862b9e27de77a3c84ae

Fix cfa

view details

kingwl

commit sha fafb82b01a91b9904d4d032b9b22e10a30e38b69

make ci happy

view details

kingwl

commit sha cb2e71cdb9c9de5087a9acfd2a63f3775d7cb500

fix operator

view details

kingwl

commit sha 81ce254a739305a4300766a8898dc05e5e3a1f50

Refactor logical assignment

view details

kingwl

commit sha 67a4943e1f01da13a036609adee7a2c526ac4757

Add more case

view details

kingwl

commit sha d2be8900dc8feff8eeed84e4168d4f3d83955f47

Add type narrow

view details

kingwl

commit sha be708bbb0a0e4350636e4ecc3b84d16fe26f5f86

fix assignment check of logical assignment

view details

Daniel Rosenwasser

commit sha 9681c1611cf9662efd3ae20b3648685eabe4e098

Remove newline

view details

kingwl

commit sha 11bed4456bb2f050e32ae11999bc75f8a30cafb7

avoid shouldCaptureInTempVariable

view details

push time in 12 days

pull request commentmicrosoft/TypeScript

Add logical assignment operator

@elibarzilay Yep, thanks.

Kingwl

comment created time in 12 days

push eventKingwl/TypeScript

kingwl

commit sha f17eb881b270a56aaef94230961ff94096c24b2e

add missing semi

view details

push time in 12 days

push eventKingwl/TypeScript

kingwl

commit sha 229acaacb4d91d3155853248abfcd9c8ae383f80

Add more check

view details

push time in 12 days

Pull request review commentmicrosoft/TypeScript

Add logical assignment operator

+//// [logicalAssignment2.ts]
+interface A {+    foo: {+        bar(): {+            baz: 0 | 1 | 42 | undefined | ''+        }+        baz: 0 | 1 | 42 | undefined | ''+    }+    baz: 0 | 1 | 42 | undefined | ''+}++declare const result: A+declare const a: A+declare const b: A+declare const c: A++a.baz &&= result.baz+b.baz ||= result.baz+c.baz ??= result.baz++a.foo["baz"] &&= result.foo.baz+b.foo["baz"] &&= result.foo.baz+c.foo["baz"] &&= result.foo.baz++a.foo.bar().baz &&= result.foo.bar().baz+b.foo.bar().baz ||= result.foo.bar().baz+c.foo.bar().baz ??= result.foo.bar().baz++
+
+//// [logicalAssignment2.js]
+"use strict";
+var _a, _b;
+a.baz && (a.baz = result.baz);
+b.baz || (b.baz = result.baz);
+(_a = c.baz) !== null && _a !== void 0 ? _a : (c.baz = result.baz);
+a.foo["baz"] && (a.foo["baz"] = result.foo.baz);

Should I consider of something like new F() ?? 1 ?

Kingwl

comment created time in 12 days

push eventKingwl/TypeScript

Alexander T

commit sha 52d32e55972d1c918fd7586d217efbf2bca6b904

Add outlining spans for object destructuring elements

view details

Alexander T

commit sha 57f161eaa8eaf08de3ebf6b14645e50c9ce3e782

feat(38225): change diagnostic message for remove braces from arrow function body

view details

Alexander T

commit sha ef72e8431487dbe2eb158d1975c8e78a4c0aecab

Merge branch 'master' of https://github.com/microsoft/TypeScript into feat/add-outlining-spans-for-object-destructuring-elements

view details

Eli Barzilay

commit sha 29cf049e61fccbc237771f13be775a92a9b55f41

moveToNewFile: handle namespace imports too Fixes #35591

view details

csigs

commit sha 1d2414822d3d22aa74ecfa2d9dee1efb2785772e

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 35d4a063eb64aeced89a45c805a1a4db39f86f38

LEGO: Merge pull request 38393 LEGO: Merge pull request 38393

view details

TypeScript Bot

commit sha f08863d2fcde8cbbb451be6a23e342cbd74f497e

Update user baselines (#38128) Co-authored-by: typescript-bot <typescript@microsoft.com>

view details

Anders Hejlsberg

commit sha 7798f532dfdabe2976d812d8bfebde60fa719f13

Fix crash caused by assertion with evolving array type (#38398) * Properly finalize evolving array type in getTypeAtFlowCall * Add regression test

view details

Anders Hejlsberg

commit sha 0091fd6c64052b5d7c0ec468fd04c105d9681987

Exclude arrays and tuples from full intersection property check (#38395) * Exclude arrays and tuples from full intersection property check * Add regression test

view details

csigs

commit sha 9ba861904b1c0fbe42d9de9baa70d93be74c3874

LEGO: check in for master to temporary branch.

view details

csigs

commit sha e4950b245f00384ffbd98339c742473781fbec85

LEGO: Merge pull request 38404 LEGO: Merge pull request 38404

view details

csigs

commit sha ece47d9d9a3552c74f3910006b20f4f44f92d54c

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 7ac641d6a4d3c0e6b4657ca09b9921c849d3c98c

LEGO: Merge pull request 38411 LEGO: Merge pull request 38411

view details

Manuel Thalmann

commit sha cbc959ba355d4c2e6d6fda3d2ad005b62a30b001

Make isDynamicFileName available publicly (#38269) * Make isDynamicFileName available publicly This commit fixes #37987 * Acknowledge Public APIs

view details

csigs

commit sha 92b7d8b6f28ac0131223746073c84782c40d7d48

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 083dbe4b8c7994201c3aaabfb42e65653f85543e

LEGO: Merge pull request 38424 LEGO: Merge pull request 38424

view details

Wesley Wigham

commit sha 7b03835b779950e926a7281030fcf9b4dc4d5ffd

Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit (#38368) * Fix js missing type arguments on existing nodes and jsdoc object literal declaration emit * Add special lookups test case, rename helper * Accept slightly modified baselines

view details

lissein

commit sha 946abeadb053d0c0bce2ca00142b33432f2211ba

Changed template strings to emit void 0 instead of undefined (#38430) undefined is not a keyword in es5 and es3 so we now emit void 0 instead in template strings.

view details

TypeScript Bot

commit sha 5653cecc17fbb1be37ce307ddfb453c09b532c85

Update user baselines (#38405) Co-authored-by: typescript-bot <typescript@microsoft.com>

view details

TypeScript Bot

commit sha 4109bba9e15717fee2c0d34ec2c24561a59919f3

Update user baselines (#38472) Co-authored-by: typescript-bot <typescript@microsoft.com>

view details

push time in 12 days

push eventKingwl/TypeScript

Alexander T

commit sha 52d32e55972d1c918fd7586d217efbf2bca6b904

Add outlining spans for object destructuring elements

view details

Nathan Shively-Sanders

commit sha 63ff6572ae92224a26012a58b847f2e845f492bc

Fix use-before-def with methods on esnext+useDefineForClassFields (#38033) * Fix use-before-def with methods on esnext+useDefineForClassFields It was incorrectly flagging methods as used before their definition, but this is allowed under any emit. * Add instance function test case

view details

Alexander T

commit sha 1e48057b9e2290ac238f35d2474812b03efdd1b5

fix(15398): skip adding line breaks when replacing JS checks directives (#38086)

view details

Nathan Shively-Sanders

commit sha 6ea291a14267f8d3b12a01b4f950dfe66e975bf9

Remove superCallShouldBeFirst error (#37947) * Remove superCallShouldBeFirst error It seems redundant since TS gives an error on any use of `this` before super, and non-`this` uses before `super` should be fine. Fixes #37371 * Revert "Remove superCallShouldBeFirst error" This reverts commit 3c09153c8ad00d73d60e7000a0e6263a6028615a. * error except for target:"esnext" && useDefineForClassFields

view details

Wesley Wigham

commit sha 136f728bb011ecf1bbf0ff2aac6dacc5cb6568cb

Fix js declaration emit for inherited and this-typed inherited fields (#37970)

view details

Wesley Wigham

commit sha a72e49e8750b7d56968db5fe577a6c5bec344d41

Delay pulling on signature contextual type until absolutely needed (#37851)

view details

csigs

commit sha 9dd881ba6c4dccbf507cd062af1d8bbb73021e5f

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 892427a7ed4183aba2e7a58e30f4b8de23a401a8

LEGO: Merge pull request 38100 LEGO: Merge pull request 38100

view details

Nathan Shively-Sanders

commit sha d571a09cf8b95dba36ef8ec85e56c3e8e9cb147c

Navto covers all projects (#38027) * Remove needless structure/destructuring Just pass multiple arguments! Sheesh! * Basic working prototype * Cleaned up version 1. Add test 2. Change protocol. navto-all only happens when filename is undefined or missing. 3. Change location to earlier code path. This change was largely type-guided and resulted in some duplicated code, but I think it's less fault-prone. * remove temp notes * Single-project hits if projectFileName is provided and file is not * use original code as fallback

view details

Andrew Branch

commit sha 7d4fc7333105ef426a5a6605a75b5febff2d40be

Fix preserveNewlines printer option when a list child has the same start or end as its parent (#37846) * Fix preserveNewlines printer option when a list child has the same start or end as its parent * Fix leading line separator calculation and JSX bug

view details

TypeScript Bot

commit sha 3c3b7dc4c3306d007046ee2c62373c72b452639a

Update user baselines (#37995) Co-authored-by: typescript-bot <typescript@microsoft.com>

view details

csigs

commit sha 2784e03d7e5fa8969d9f53dc2b3635b5896ccf8b

LEGO: check in for master to temporary branch.

view details

csigs

commit sha 052d3f9fafd7cab25b1d798e14c07fb6df07be8a

LEGO: Merge pull request 38104 LEGO: Merge pull request 38104

view details

Wenlu Wang

commit sha 39beb1d011a6bc412a67e1dfa2ec1cb1de438b4f

Add check for delete expression must be optional (#37921) * Add check for delete expression must be optional * Add more tests

view details

Alexander T

commit sha 92a63741a288ff34f47df5505dbbd7ab19490493

fix(38080): add outlining spans for TypeLiteral (#38089)

view details

Alexander T

commit sha d2016912b5f8778b25c8f7c2dc4e82dbd5e27843

fix(37825): exclude private fields from completions in subclasses (#37906)

view details

Nathan Shively-Sanders

commit sha f248567dabd1b9cc11bb53d815e79c80becaee51

Filter undefined only in binding patterns in params (#38116) initialiser. But this is only correct when the initialiser is for a parameter. For example: ```ts declare let x: { s: string } | undefined; const { s } = x; ``` This PR removes undefined from the type of a binding pattern only when the binding pattern's parent is a parameter. This fixes the regression from 3.8. However, it's still not the ideal fix; we should be able to use control flow to solve this problem. Consider: ```ts const { s }: { s: string } | undefined = { s: 'hi' } declare function f({ s }: { s: string } | undefined = { s: 'hi' }): void ``` Neither line should have an error, but the first does in 3.8 and after this change.

view details

Josh Goldberg

commit sha ef83109dbf122644bdba9a8cb97ea007c7668ea0

Prefer a likely literal over anonymous type in --noImplicitAny codefixes (#36015) * Prefer a likely literal over anonymous type in --noImplicitAny codefixes Before trying to make an anonymous type for a type's usage, we'll first check if there is exactly one builtin primitive the usage is assignable to, and use it if so. Right now that's only `number` and `string` because `boolean` has no distinguishable members. A couple of implementation details: * `tryInsertTypeAnnotation` needed to know to insert a type _after_ a node's `exclamationToken` if it exists * This code area was written before `??` :wink: * Used unknown/any instead of void when applicable * Fix little whitespace change in tests/cases/fourslash/codeFixInferFromUsagePropertyAccessJS.ts * Undid some now-unnecessary unknown additions * Took advice on restricting void to just call expressions

view details

Nathan Shively-Sanders

commit sha 032aa90289e52d6e49ba4abdb098b3bf6d55fa67

Filter undefined from binding elements with initialisers without undefined in the type (#38122) * Filter undefined from binding elts w/o undefined-containing inits * use getTypeOfInitializer instead * improve comment based on Wesleys suggestion

view details

TypeScript Bot

commit sha ab0428c82e9ac16b825aa95d143ab02367c76b2e

Update user baselines (#38109) Co-authored-by: typescript-bot <typescript@microsoft.com>

view details

push time in 12 days

pull request commentmicrosoft/TypeScript

[Expirement] [WIP] Add deprecated related feature

Does the protocol looks good?I'm not sure🤷‍♂️

Kingwl

comment created time in 12 days

pull request commentmicrosoft/TypeScript

[Expirement] [WIP] Add deprecated related feature

Another problem is, where's the line:

a.b.c.d // c is deprecated

What is the expected behavior?

  1. [a.b.c].d
  2. a.b.[c].d
  3. a.b.[c.d]

And if:

a.b.c.d // c and d is deprecated

What is the expected behavior

  1. [a.b.c.d]
  2. a.b.[c].[d]
  3. a.b.[c.d]
Kingwl

comment created time in 13 days

pull request commentmicrosoft/TypeScript

[Expirement] [WIP] Add deprecated related feature

Ping, need some help.
@sheetalkamat, @amcasey, @mjbvz, @minestarks, @DanielRosenwasser

Kingwl

comment created time in 13 days

push eventKingwl/TypeScript

kingwl

commit sha 3991974c741f00bc267f7aeeece9cdcbd762cec0

fix crash

view details

push time in 13 days

push eventKingwl/TypeScript

kingwl

commit sha d026553a9e9a2ca191d3c0fd4bd29984c587997a

fix more crash

view details

push time in 13 days

push eventKingwl/TypeScript

kingwl

commit sha 5d8bd2eb87b4a3048c8905ab10e75ee32c7c89b2

fix crash

view details

push time in 13 days

push eventKingwl/TypeScript

kingwl

commit sha 968aece033f75a5c858eb8ae6f0bde36b2998350

Add more deprecated

view details

push time in 13 days

push eventKingwl/TypeScript

kingwl

commit sha 41e68395bef5535a186888f55c94acca35f2d593

Add identifier check

view details

push time in 13 days

push eventKingwl/vscode

kingwl

commit sha e1a9c1ed818b2bf074cf0d38df06c3305aa64045

Support callhierarchy

view details

push time in 13 days

PR opened microsoft/vscode

Add ts/js deprecated support

<!-- Thank you for submitting a Pull Request. Please:

  • Read our Pull Request guidelines: https://github.com/Microsoft/vscode/wiki/How-to-Contribute#pull-requests.
  • Associate an issue with the Pull Request.
  • Ensure that the code is up-to-date with the master branch.
  • Include a description of the proposed changes and how to test them. -->

This PR fixes #77760

https://github.com/microsoft/TypeScript/pull/38523

+45 -17

0 comment

11 changed files

pr created time in 14 days

create barnchKingwl/vscode

branch : ts-deprecated

created branch time in 14 days

push eventKingwl/TypeScript

kingwl

commit sha 8184a1d2a68b092fa2b8c30d327fe2002a0400dd

fix navtree

view details

push time in 14 days

startedHearTao/ts-upgrade

started time in 14 days

push eventKingwl/TypeScript

kingwl

commit sha a587d538b99d317287d6d8dee031bbe74c4336a6

Add more support

view details

push time in 14 days

delete branch Kingwl/TypeScript

delete branch : build_error

delete time in 14 days

pull request commentmicrosoft/TypeScript

[Expirement] [WIP] Add deprecated related feature

@typescript-bot pack this.

Kingwl

comment created time in 14 days

push eventKingwl/TypeScript

kingwl

commit sha 726b93311b92f209242c2c02efc8fe514d290a89

Fix build type error

view details

push time in 14 days

issue openedHearTao/ts-upgrade

Lodash / Ramda support

created time in 14 days

issue commentmicrosoft/TypeScript

Refactoring to convert && chain to optional chain expression

if TS could automatically refactor lodash/get usages and/or ramda/pathOr usages.

Good idea. IMO TypeScript cannot provide that but there's outside tools. eg: https://github.com/HearTao/ts-upgrade

DanielRosenwasser

comment created time in 14 days

push eventKingwl/TypeScript

kingwl

commit sha 19624faea7a3cbbd5b8d0b0665e1dd28b496b273

Fix build type error

view details

push time in 14 days

PR opened microsoft/TypeScript

Build error

<!-- Thank you for submitting a pull request!

Please verify that:

  • [ ] There is an associated issue in the Backlog milestone (required)
  • [ ] Code is up-to-date with the master branch
  • [ ] You've successfully run gulp runtests locally
  • [ ] There are new or updated unit tests validating the change

Refer to CONTRIBUTING.MD for more details. https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md -->

Fixes Nothing but https://github.com/microsoft/TypeScript/pull/38518

+146 -53

0 comment

16 changed files

pr created time in 14 days

create barnchKingwl/TypeScript

branch : build_error

created branch time in 14 days

pull request commentmicrosoft/TypeScript

Add deprecated related feature

@typescript-bot pack this.

Kingwl

comment created time in 14 days

PR opened microsoft/TypeScript

Add deprecated related feature

<!-- Thank you for submitting a pull request!

Please verify that:

  • [ ] There is an associated issue in the Backlog milestone (required)
  • [ ] Code is up-to-date with the master branch
  • [ ] You've successfully run gulp runtests locally
  • [ ] There are new or updated unit tests validating the change

Refer to CONTRIBUTING.MD for more details. https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md -->

Fixes #390

+143 -50

0 comment

15 changed files

pr created time in 14 days

create barnchKingwl/TypeScript

branch : deprecated_support

created branch time in 14 days

issue commentmicrosoft/TypeScript

import ConstJson from './config.json' as const;

// CC: @DanielRosenwasser @RyanCavanaugh

How about syntax import const ConstJson from './config' and limited for the json modules.

slorber

comment created time in 14 days

issue commentmicrosoft/TypeScript

@‌deprecated JSDoc tag

I'd like to work on this both ts and vscode side.

DickvdBrink

comment created time in 14 days

issue commentmicrosoft/TypeScript

Refactoring to convert && chain to optional chain expression

Ahhhh, i have some existed work about this. And I'm happy to port here

DanielRosenwasser

comment created time in 14 days

issue commentmicrosoft/vscode

Ability to contribute context menu entries for Terminal

I'd like to work on this.

usernamehw

comment created time in 15 days

push eventKingwl/vscode

Danny Lin

commit sha 4cd01cd563ce16c04fa5e168aa3316ebfa3a2bb6

Revert "Fixes #94144: Remove special dark theme cursor" This reverts commit a915df17f58315bf1245d27701f3f7a818a71564. The special macOS dark cursor is still useful for users stuck on older versions of macOS. Even on macOS Catalina, this cursor is helpful for reducing visual bloat.

view details

Danny Lin

commit sha 87e43131262feb76d718f305f076cd092825cee7

Replace text cursor styles with mouse-text class This reduces code duplication and makes it significantly easier to make changes to the text cursor without having to individually modify several files.

view details

Danny Lin

commit sha 54aeb0014f92562a210a383049125b95afa05d85

Apply special macOS dark text cursor to all mouse-text elements Now that there's a common mouse-text class for text cursors, we can apply the special macOS dark cursor to many elements at once to improve consistency. Since the cursor is now applied to all relevant elements, this fixes #94144 without needing to revert the cursor entirely.

view details

Ladislau Szomoru

commit sha d357d0283ee9917f31cc9bee0196f8d3f2a1f881

Add setting to control the sash size

view details

Martin Aeschlimann

commit sha 76d612786aa01ce9430e3964649b981f954155ab

Themes: set classes to the <body> element. Fixes #92953

view details

Ladislau Szomoru

commit sha 2f9ac60b17a8c6b710db9fd346a23aa110693e5d

Pull request feedback

view details

Ladislau Szomoru

commit sha 88440bdcdf2c62ce16d317d6ae9d49bd98adb52c

Fixed issue with creating a new sash

view details

Alex Dima

commit sha 09a4c6fd9ce9527a4142ccb92e40d8e034ffd7c2

Extract the custom mouse cursor to `vs/base` to get it also in the standalone editor

view details

Ladislau Szomoru

commit sha 37cb93ffa763b363cb399e0894e7ce2875c1a306

Switched to 'editor' in favor of 'inherit' and improved the setting descritpion (#97508)

view details

Johannes Rieken

commit sha 1843faa32b9cac7add2976cd22adf2af9095b3e9

notebook outline - don't focus notebook

view details

Benjamin Pasero

commit sha a9486cbf683b0e3ece7583b22ea605b4a84b0a31

Pinned Release Notes tab is blank (looks weird) (fix #97218) (#97468)

view details

isidor

commit sha 39e2f450e8d47f93d1912770d38c3ff8ca6d098a

fixes #97471

view details

Rachel Macfarlane

commit sha bbb54b5ffc372a3ee465a93edc8f5c426abb4266

Remove trace setting from microsoft auth provider

view details

Rob Lourens

commit sha 7c599cc4328c8458d176f6bf87cb6dab75bc458c

Fix 'undefined' showing up in notebook webview

view details

rebornix

commit sha 3507e2dc3a20042c7dd0e62391426bcd9a6c7471

Retained notebook editor under workbench.

view details

rebornix

commit sha f63c75a9b0bbcc3b9b049558eaf7df6f633a8e65

extract notebook editor widget

view details

Jackson Kearl

commit sha 451c76d5d4347ad60511f5432f8af0dc2f66f238

Add schema for open new search editor command args #95582

view details

Matt Bierner

commit sha e3bc0ad257c3868ff7ee4cc2eb50eb5dce5ad5ac

Unregister capabilities on provider dispose Fixes #97060

view details

Matt Bierner

commit sha b01489a20e1876c3468cdf4e23418c2ef94c89f5

Fixes #97462

view details

rebornix

commit sha 83a363337992e255361cadf5dcef7df16296513e

fix dnd.

view details

push time in 15 days

pull request commentmicrosoft/vscode

refacte extHostTypes edits with semantically const enum insted of mag…

Could I cherry-pick this commit inside other PR?

Kingwl

comment created time in 15 days

PR opened microsoft/vscode

Add next/prev conflicts

<!-- Thank you for submitting a Pull Request. Please:

  • Read our Pull Request guidelines: https://github.com/Microsoft/vscode/wiki/How-to-Contribute#pull-requests.
  • Associate an issue with the Pull Request.
  • Ensure that the code is up-to-date with the master branch.
  • Include a description of the proposed changes and how to test them. -->

This PR fixes #38321

There's an existed pr https://github.com/microsoft/vscode/pull/47884 but not updated about 2 years

+19 -3

0 comment

2 changed files

pr created time in 15 days

create barnchKingwl/vscode

branch : next-conflict

created branch time in 15 days

push eventKingwl/vscode

petevdp

commit sha a2fa9497d02b3530ca7e7ffbb6e1ba6f8bed1874

allow the inline diff editor to be centered

view details

Rob Lourens

commit sha 56c6946bf285da6be5fdb92ce6f3f5dafaa88772

Fix issue with searching using workspace folder name. Add file search integration tests Fix #97352

view details

Benjamin Pasero

commit sha ee8c99a27f163231c1a871103038caf76f697090

:up: playwright@1.0.1

view details

Benjamin Pasero

commit sha 5356ceb23cca764874d675fc01f3c09839cb26f0

windows - ensure new-window request has right window context (fix #97172)

view details

Martin Aeschlimann

commit sha 67cfd21b80752b134416ec517e0efd85bc8e86d2

Feedback on "Ok to install". Fixes #92139

view details

Matt Bierner

commit sha ba33738bb3db01e37e3addcdf776c5a68d64671c

Pick up TS 3.9.2 insiders

view details

Benjamin Pasero

commit sha 6177de0c0f52b6977b5d2f2bdf9482620c4fd5c5

debt - remove unused method from launch service

view details

Benjamin Pasero

commit sha 210263b177190c53e5416e8ece42dc78895c761e

menu - simpler lazy instantiation

view details

Benjamin Pasero

commit sha 0e70726bf900d64b85773d3dc48b100ec66cce93

actions - remove some unused event/context from run()

view details

João Moreno

commit sha 44bcbe587d7f265ab0457c7931a7baab2419ad66

fix retriggering broken builds

view details

isidor

commit sha 13df275761d906f37a53ceef7eb274630ffc418e

debug: remove support to open config file to the side fixes #97470

view details

isidor

commit sha c650757bd48b936987f1be4350a8f359b1a76550

fixes #97431

view details

Johannes Rieken

commit sha 136bbd3b3b1924ab5ced5cb8a78a9a854298aef8

rework gotoError logic to be fit for #96708

view details

Johannes Rieken

commit sha 337c788e89b157b64e51b38f62e5d751e6075282

add marker list provider, #96708

view details

Johannes Rieken

commit sha 2b472d1e4aaaecdda5ca96289869f90ae82de3a1

register a marker list provider for notebooks, #96708

view details

Dirk Baeumer

commit sha 480272dc7989404049f7bb2d3a4d30313f3d6822

Add map state test to forEach

view details

Johannes Rieken

commit sha 99de27bd7cda217e5f954d7568267606ccff6ce3

:lipstick: simpler menu registration

view details

Isidor Nikolic

commit sha 8f0f44cd0f718e9c2277758b400b7b34676d7bf6

Merge pull request #97311 from petevdp/allow-centered-inline-diff-editor Allow the inline diff editor to be centered.

view details

João Moreno

commit sha c1dce208791cfee08904d806fc47d37f5ff2a360

fixes #97059

view details

Ladislau Szomoru

commit sha 6c39ddaea0dc34eb1bf281962582755f32e667e4

Add settings for SCM input font family (#97139) * Add settings for input message font family

view details

push time in 15 days

PR opened microsoft/vscode

Add force checkout and smart checkout

<!-- Thank you for submitting a Pull Request. Please:

  • Read our Pull Request guidelines: https://github.com/Microsoft/vscode/wiki/How-to-Contribute#pull-requests.
  • Associate an issue with the Pull Request.
  • Ensure that the code is up-to-date with the master branch.
  • Include a description of the proposed changes and how to test them. -->

This PR fixes #

+57 -13

0 comment

2 changed files

pr created time in 16 days

create barnchKingwl/vscode

branch : smart-checkout

created branch time in 16 days

push eventKingwl/vscode

petevdp

commit sha a2fa9497d02b3530ca7e7ffbb6e1ba6f8bed1874

allow the inline diff editor to be centered

view details

Rob Lourens

commit sha 56c6946bf285da6be5fdb92ce6f3f5dafaa88772

Fix issue with searching using workspace folder name. Add file search integration tests Fix #97352

view details

Benjamin Pasero

commit sha ee8c99a27f163231c1a871103038caf76f697090

:up: playwright@1.0.1

view details

Benjamin Pasero

commit sha 5356ceb23cca764874d675fc01f3c09839cb26f0

windows - ensure new-window request has right window context (fix #97172)

view details

Martin Aeschlimann

commit sha 67cfd21b80752b134416ec517e0efd85bc8e86d2

Feedback on "Ok to install". Fixes #92139

view details

Matt Bierner

commit sha ba33738bb3db01e37e3addcdf776c5a68d64671c

Pick up TS 3.9.2 insiders

view details

Benjamin Pasero

commit sha 6177de0c0f52b6977b5d2f2bdf9482620c4fd5c5

debt - remove unused method from launch service

view details

Benjamin Pasero

commit sha 210263b177190c53e5416e8ece42dc78895c761e

menu - simpler lazy instantiation

view details

Benjamin Pasero

commit sha 0e70726bf900d64b85773d3dc48b100ec66cce93

actions - remove some unused event/context from run()

view details

João Moreno

commit sha 44bcbe587d7f265ab0457c7931a7baab2419ad66

fix retriggering broken builds

view details

isidor

commit sha 13df275761d906f37a53ceef7eb274630ffc418e

debug: remove support to open config file to the side fixes #97470

view details

isidor

commit sha c650757bd48b936987f1be4350a8f359b1a76550

fixes #97431

view details

Johannes Rieken

commit sha 136bbd3b3b1924ab5ced5cb8a78a9a854298aef8

rework gotoError logic to be fit for #96708

view details

Johannes Rieken

commit sha 337c788e89b157b64e51b38f62e5d751e6075282

add marker list provider, #96708

view details

Johannes Rieken

commit sha 2b472d1e4aaaecdda5ca96289869f90ae82de3a1

register a marker list provider for notebooks, #96708

view details

Dirk Baeumer

commit sha 480272dc7989404049f7bb2d3a4d30313f3d6822

Add map state test to forEach

view details

Johannes Rieken

commit sha 99de27bd7cda217e5f954d7568267606ccff6ce3

:lipstick: simpler menu registration

view details

Isidor Nikolic

commit sha 8f0f44cd0f718e9c2277758b400b7b34676d7bf6

Merge pull request #97311 from petevdp/allow-centered-inline-diff-editor Allow the inline diff editor to be centered.

view details

João Moreno

commit sha c1dce208791cfee08904d806fc47d37f5ff2a360

fixes #97059

view details

Ladislau Szomoru

commit sha 6c39ddaea0dc34eb1bf281962582755f32e667e4

Add settings for SCM input font family (#97139) * Add settings for input message font family

view details

push time in 16 days

push eventKingwl/vscode

kingwl

commit sha 31ee5b96449103913998a073686fe69f1f6e3eef

fix something

view details

push time in 16 days

pull request commentmicrosoft/vscode

Add rename by git context menu

The known problem is: After rename, current opened files inside editor will marked as deleted

Kingwl

comment created time in 16 days

PR opened microsoft/vscode

Add rename by git context menu

<!-- Thank you for submitting a Pull Request. Please:

  • Read our Pull Request guidelines: https://github.com/Microsoft/vscode/wiki/How-to-Contribute#pull-requests.
  • Associate an issue with the Pull Request.
  • Ensure that the code is up-to-date with the master branch.
  • Include a description of the proposed changes and how to test them. -->

This PR fixes #93299

+48 -2

0 comment

6 changed files

pr created time in 16 days

push eventKingwl/vscode

kingwl

commit sha b24cb8b47d4ed3703e5018f6c45f5feee70d2095

Add rename by git context menu

view details

push time in 16 days

more