profile
viewpoint
Changyu Geng KingMario VMware Inc. Shanghai

KingMario/Baidu-Map-Indoor-Lite 6

Baidu map customized layer tiles cut lite solution.

KingMario/angular2-trim-on-blur 3

Angular Trim on Blur Directive. For Trim on Input and/or blur, see ngx-trim-directive.

KingMario/960-Grid-System 0

The 960 Grid System is an effort to streamline web development workflow.

KingMario/adm-zip 0

A Javascript implementation of zip for nodejs. Allows user to create or extract zip files both in memory or to/from disk

KingMario/amazeui 0

Amaze UI, a mobile-first and modular front-end framework.

KingMario/angular 0

One framework. Mobile & desktop.

KingMario/angular-cn 0

Chinese localization of angular.io

KingMario/angular-dragdrop 0

Implementing jQueryUI Drag and Drop functionality in AngularJS (with Animation) is easier than ever

KingMario/angular-express-seed 0

A great starting point for writing AngularJS apps backed by an Express-powered node.js server.

startedKingMario/packages

started time in 18 days

startedzzarcon/video-snapshot

started time in a month

push eventKingMario/clarity

Bozhidar Dryanovski

commit sha 6ff149efcb9a5a33078065f597b1ec3a0edd5be1

feat(stack-view): a11y aria-level, aria-posinset and aria-setsize Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

Bozhidar Dryanovski

commit sha eba399a1da6473d93f9a5bfb0ec95dc8210c62b0

fix(datalist): wrong import path for DynamicWrapper Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

Bozhidar Dryanovski

commit sha d3c145643894ce95b4a9632b9465ffbc47e2d84c

feat: update the limit of header-max-length from 72 to 100 characters Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

smathis

commit sha a1a60bf9a716663fad3e8c952214a597b8b667bf

feat(build): typescript cleanup • added union type for default sizes (default|sm) that we see in buttons and alerts • added union types for t-shirt sizes used in modals • added union types for statuses found in alerts, badges, tags, and buttons Signed-off-by: Scott Mathis <smathis@vmware.com>

view details

smathis

commit sha e787579457b67453f274591bc1fd8d7aa32a3bde

feat: deprecating dir attr in core icons • dir is being replaced by the direction attribute • using dir as an attribute confuses ltr localization Signed-off-by: Scott Mathis <smathis@vmware.com>

view details

Cory Rylan

commit sha 32fbdeda4d75eb868604f71e3fe78e87d1224d83

fix: auto update attr for prop decorator Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Cory Rylan

commit sha 66d238b57938f02ad0f23f730f6acc2ffc95c9cc

fix: core support typed events with @event Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Jeremy Wilken

commit sha d1225c8dcac0d6a2b2a6ca095f418a6eccdf2da7

chore: fix lint scripts The linter scripts were not running against all of the code correctly due to incorrect paths declared when running the linter. This also fixes the linting errors reported in current master since it stopped running correctly. It will again protect us against runtime import issues. Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>

view details

Matt Hippely

commit sha 661ef351c232722cbdc9913b99a3da69043fedcb

fix(datalist): adds optional service The [datalist] directive needs to guard against non clarity usage. This adds the optional decorator to the service and guards against its presence before setting any id values. closes #4192 Signed-off-by: Matt Hippely <mhippely@vmware.com>

view details

Matt Hippely

commit sha 68eb03ba8587115bae69285c607185e8d511dcb6

fix(datagrid): adds a11y attributes to datagrid filter button In the conversion to the new popover utility a11y attributes were missed. This adds: aria-label, aria-expanded and aria-controls to the datagrid filter button. This change closes #3985. Signed-off-by: Matt Hippely <mhippely@vmware.com>

view details

Cory Rylan

commit sha 1b5a4a577eacef441b2e46918d0227c176173f99

fix: core ts build - compile core directly from tsc - improve core build times - consistent output, dev app uses same output as npm Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

push time in a month

push eventKingMario/clarity

Bozhidar Dryanovski

commit sha 043654e30145b06e4ff92f16c7bb2cd7b0fbf56e

fix: missing dependency for tree-node Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

Bozhidar Dryanovski

commit sha 89e569f6c7b8b1d364028044c2f423a51db43992

fix: datagrid clrDgFilterOpenChange was not fired Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

Jeremy Wilken

commit sha a7736834ca648d8c5496e7ca60b018690ec5fdf3

docs: use vertical nav In order to better align our website with recommended patterns, this changes out the original side-nav for the vertical-nav Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>

view details

Andrei Constantin

commit sha bd4e2d90eadabe3d15cb28a1929b35ef324de829

fix(vertical-nav): add aria-expanded to vertical nav - Adds aria-expanded to the main expand/collapse vertical nav button - Adds aria-expanded to the nav-group expand/collapse button - Adds view tests for the correct state of the aria-expanded attribute on both components closes #3575 and #3919 Signed-off-by: Andrei Constantin <andrei.constantin@bytex.ro> fix(vertical-nav): adds aria-expanded to groups and fixes testing This change adds aria-expanded attribute to the vertical-nav-group buttons to reflect the correct state when it is expanded/collapsed. It finished the work started in pr 3919 and closes #3919 (original pr) and #3575 (issue). Signed-off-by: Matt Hippely <mhippely@vmware.com>

view details

stsogoo

commit sha 8a1ad9674032a1a3bf1119abf507f3a61d188689

fix: select-all checkmark position Signed-off-by: stsogoo <stsogoo@vmware.com>

view details

Cory Rylan

commit sha 65fb103d5d364397009b5d95120b2dccc5630f77

chore: add core to npm publish scripts Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Cory Rylan

commit sha b73d92b850f9f2fe5ea3ff7cae4f9c4fc57399bc

build: update core sass paths - delete unused UI files - update paths in prep for cl-angular file migrations Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Cory Rylan

commit sha bf7a14bf2932a987a4dfe02b8d64e90d2cf4e5a6

docs: minimal core getting started guide Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Alex Mellnik

commit sha 5ea6611babb9d251d595e964123dbee1ea8f0c25

docs(grid): clean up and move useage notes to end Signed-off-by: Alex Mellnik <a.r.mellnik@gmail.com>

view details

Jeeyun Lim

commit sha 5e78aaf952b1ddb59a52fb03d0d40e4502958a65

chore: release v3.0.0.next.3 Signed-off-by: Jeeyun Lim <jeeyun.lim@gmail.com>

view details

Jeeyun Lim

commit sha 0c71ec1d1727b038f74ba512b5820f99ebfe6bb4

chore: website update for v3.0.0.next.3 Signed-off-by: Jeeyun Lim <jeeyun.lim@gmail.com>

view details

Bozhidar Dryanovski

commit sha 08c00e8622dc6db4907b2e3a2278895185e27693

fix: aria-live.service to handle SR for all browsers and OS This service is for internal use only! - new service - remove some of the [aria-live] attributes - test page into the dev app - added tests Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

smathis

commit sha 331a9f7a9ab5b6fe87f0a0620443d9d262e02ef8

fix(build): stop csso from restructuring our styles • style restructuring was breaking our CSS cascades within styles • this was revealed by csso re-ordering our IE defaults for custom properties • without this change, theming with css custom properties is broken • i mistakenly thought csso was only being used in one spot • this updates package.json to cover the other scripts that were using it • expected output 100% verified with local build Signed-off-by: Scott Mathis <smathis@vmware.com>

view details

Jeeyun Lim

commit sha d33dbadfa3e3c1f8229cc4e8f038ff79db81898c

feat(button): improvements to base button - adding readonly attr for non-clickable elements - changing state attr to status to align across component library - clean up style to make text inside button not selectable Signed-off-by: Jeeyun Lim <jeeyun.lim@gmail.com>

view details

Cory Rylan

commit sha 013273481b655c76ae3496ca0d73cedcee1c86a5

build: exclude generated files from lint Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Cory Rylan

commit sha 0bfde01e5af0d0ed510e8f2dd73e82f9635a261e

build: correct core dependencies - correct dependency types with direct and optional dependencies - externalize core font as optional dependency Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Cory Rylan

commit sha f1c38cb9106869c07c0c5d002cb74c1428be3254

build: add core to clr-angular schematic Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Jeremy Wilken

commit sha 5d6ebb81af2d91b6e71e19d5637ad0afcb98a97f

chore: enable more applitools tests This enables the easy demos that don't require a lot of cleanup to start using Applitools for testing. Approximately half of the gemini tests are now in Applitools. Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>

view details

Massimo Costa

commit sha e4b0446bb7829b2f2654c0de370f06ee3b1bfe1e

docs(stepper): fix type for clrInitialStep Input Signed-off-by: Massimo Costa <costa.massimo@gmail.com>

view details

Ivan Donchev

commit sha 41bd0794e951b612ce5c5f0bd363dd67567acbe5

fix: datagrid animation performance issues issue #3864 Signed-off-by: Ivan Donchev <idonchev@vmware.com>

view details

push time in a month

startedvmware-tanzu/antrea

started time in 2 months

startedcmiscm/leonsans

started time in 2 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha bc7d8d98471df7f0a23b1d11dc4e4c7240346ac1

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 2 months

push eventKingMario/packages

KingMario

commit sha 97dcd0523b76a5dd235d50892505f29cb44f425e

trim directive V1.0.11

view details

push time in 2 months

issue closedKingMario/packages

Cannot enter whitespace with trim="blur" (ngx-trim-directive)

In our project we have some fields where we cannot insert or append whitespaces. We had no problems with 1.0.3 but we had to update angular and the ngx-trim-directive package (from 1.03 to 1.10).

From my analysis I think the problem is: If you have multiple fields at once that bind to the same value and they all use trim="blur" a change in one field causes the call of writeValue() in the valueAccessor.

You can view a sample of the described behaviour here: https://stackblitz.com/edit/ngx-trim-directive-issue-13

What are your reasons for doing a trim in writeValue()?

In our case we don't need to trim the values initially and we don't set the values programmatically, so a solution for our scenario I can imagine would be: Let users of the package turn off trimming in writeValue() optionally.

What do you think? I would create a Pull Request if this would be a solution and you want it. But I want to know what you think before starting coding something.

closed time in 2 months

tpeter1985

issue commentKingMario/packages

Cannot enter whitespace with trim="blur" (ngx-trim-directive)

Thanks & take care @tpeter1985.

tpeter1985

comment created time in 2 months

push eventKingMario/packages

Timo Peter

commit sha 0000565f3bafe68253166cfbdcb01b6d844689d3

add "trimOnWriteValue" input parameter (ngx-trim-directive) makes it possible to disable trimming when "writeValue()" gets called by the "ControlValueAccessor"; needed when multiple inputs bind the same value and trim-on-blur is needed

view details

Timo Peter

commit sha d14bbb11668cadda4bb9d4278407ff9bc6d65413

add tests for "trimOnWriteValue" (ngx-trim-directive)

view details

Changyu Geng

commit sha 1eaf2a95b08e6c8ee491b4d1653c544ee3cec0e5

Merge pull request #15 from tpeter1985/master Enable blur-trim for values bound by multiple fields

view details

push time in 2 months

PR merged KingMario/packages

Enable blur-trim for values bound by multiple fields

My pull request as discussed here: https://github.com/KingMario/packages/issues/13 Binding the same value by multiple input fields lets writeValue() be called by ControlValueAccessor which trims the value. To be able to only trim the value bound by multiple input fields on blur I implemented an option to disable the trim in writeValue() of ControlValueAccessor by setting trimOnWriteValue to false.

+47 -4

0 comment

2 changed files

tpeter1985

pr closed time in 2 months

push eventKingMario/ng-zorro-antd

Hsuan Lee

commit sha f7e9a7c98834f2183db352506921adef38fd0166

fix(module:tree,tree-select): fix the styles of connecting line (#3385) * fix(module:tree,tree-select): fix the styles of connecting line * fix(module:tree): fix styles * fix(module:tree-select): fix file name close #3382

view details

JerryHong

commit sha 906a48be67e25e8657909c3c069c8179dbf4355a

docs: update rxjs thirty days link (#3435)

view details

Wendell

commit sha 8037e9d27758d8d6b31ac069e9ca94aee85bf4d7

chore: fix definitions not exported (#3410)

view details

卡色

commit sha 7e7b4e46250d4f97868c14b1635b734118d5eadb

docs: update typo (#3452)

view details

binglingshuang

commit sha c63849ff1fcc35e0653c1283d2a2b489498b9e6e

fix(module:cascader,checkbox,switch,tooltip): fix memory leak problem (#3416) * fix(module:cascader,checkbox,switch,tooltip): fix memory leak problem * fix(module:tooltip): fix memory leak problem * fix(module:tooltip): remove license

view details

Hsuan Lee

commit sha 2015021e94f52637d7a7b1986a9ed4dbc2e0e774

feat(module:card): support setting size (#3429) fix(module:card): fix missing class

view details

Wenqi

commit sha 0deda73ca27fa65e8e53093f0076819caa960285

feat(module:tree-select): support customized icon (#3395) * feat(module:tree-select): support customized icon * feat: support nzTreeTemplate to customize icon fix: change tree template type * feat: support tree template as @Input and @ContentChild

view details

Wendell

commit sha 9d495fcdb6e4313a0f9079bc796c8ff216923ae1

fix(module:carousel): fix carousel in entry components (#3367) * fix(module:carousel): fix carousel in entry components * fix: test * fix: typo

view details

Hsuan Lee

commit sha 6458c57e764b1ce8ee67fcdc8a05466cc9a4918b

fix(module:modal): content not work in confirm mode when the type is component (#3415) close #3407

view details

Wendell

commit sha 80c6ed4114d1c2b24ee0710d7d33cf26d6d98d83

fix(module:progress): fix stroke color is not updated (#3445) * fix(module:progress): fix stroke color is not updated close #3441 * chore: remove color in demo * fix: type Co-Authored-By: Hsuan Lee <HsuanGM@gmail.com> * fix: type

view details

Wenqi

commit sha fd4760545639d36585224f09b75436b1677c2c41

fix(module:menu): submenu should not remain highlighted (#3455) * fix(module:menu): submenu should not remain highlighted * fix: add unit test * fix: set isMouseHover when overlay collapse

view details

Hsuan Lee

commit sha 663f6c1722aba8ec411c65d3e5b018cadcba4edb

fix(module:drawer): fix z-index level (#3405) close #3402

view details

Hsuan Lee

commit sha 0533c32d8a81c7c22d072e16a990dd5cf32f2aa5

fix(module:modal): cannot to close in order of overlay opens when using esc (#3339) close #3338

view details

Hsuan Lee

commit sha 3742edafe645fa24ff37af4f81bf8f3dde8cad79

feat(module:drawer): support `nzOnCancel` for service mode (#3376) close #3372 * feat(module:drawer): support `nzOnCancel` for service mode * docs(module:drawer): fix docs * docs(module:drawer): fix docs

view details

Hsuan Lee

commit sha 82e488aaafad69a04afd73ec312095dd9ebf8870

fix(module:modal): should not close when mousedown in the body (#3400) * fix(module:modal): should not close when mousedown in the body * chore(module:modal): use variable to save classname string close #3394

view details

Wendell

commit sha fd43ec562e1bfecd926e1ac7f4fad00bf8a2032d

fix(module:breadcrumb): fix input boolean and router event not caught error (#3185) * fix(module:breadcrumb): fix input boolean and lazy module slash docs: add link fix: fix breadcrumb not updated fix: typo * test: add test * chore: cleanup code * chore: rollback * chore: remove vscode close #3186

view details

Wenqi

commit sha 9e6dce23801276109a4d88fe1e0834377e9279b3

release(7.4.0): release 7.4.0 (#3462)

view details

Hsuan Lee

commit sha 2c4df76c3fe21fede0497c7423b18338c3c3f80a

docs: fix some errors and update users (#3466)

view details

Wenqi

commit sha 3e04f4b1756a4b406b45bf6c00078677b9245c76

release(7.4.1): release 7.4.1 (#3470)

view details

Wendell

commit sha 6342657d6738632ba2c92bd9337edd4fb6196f9c

build: hack to prevent bug of ng-packagr (#3469)

view details

push time in 2 months

startedHugueLiu/magicCube

started time in 2 months

issue commentKingMario/packages

nm, m istake

Hi @jarrodmedrano, it's a feature called add period with double-space of Mac OS and can be turned off from keyboard text preferences.

jarrodmedrano

comment created time in 3 months

issue commentKingMario/packages

Cannot enter whitespace with trim="blur" (ngx-trim-directive)

@tpeter1985 The reason for doing a trimming in writeValue() is to trim the value initially and trim the value while it's updated programmatically. I think it's a common feature that might be required by users of the directive.

tpeter1985

comment created time in 3 months

issue commentKingMario/packages

Cannot enter whitespace with trim="blur" (ngx-trim-directive)

Hi @tpeter1985,

I think an option to turn off the trimming in writeValue() is good. Please create a Pull Request to add it. And don't forget to add test cases for it.

Thanks.

tpeter1985

comment created time in 3 months

push eventKingMario/clarity

Cory Rylan

commit sha 662d151a27e6288ca91320dfa05409ac06aa585f

build: add commit lint - Add pre hook for commit formatting - Add github PR template Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Cory Rylan

commit sha c487f2533feec5961b3ac1c853b3336973415660

build: fixup pr Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Jeremy Wilken

commit sha e6db0cc426eb27444cc04d2b19c0cfdc67d8a014

fix(forms) link helper text to input with aria-describedby closes #3554 Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>

view details

Alexander Tseung

commit sha 61155a257de6d1070c2df84551bb0be59278dfdc

Update themes.demo.html Signed-off-by: Alex Tseung <alextsg@users.noreply.github.com>

view details

Scott Mathis

commit sha a4b63da4d31d2c8b947a5da3c0b52c85ef577f1a

fix: reverting app-level orange alerts to intended color (#3612) • During the SASS variable cleanup, I made updates to the orange color palette that broke the a11y contrast of app-level alerts • This change fixes that regression Tested in: ✔︎ Chrome ✔︎ Firefox Fixes #3604 Signed-off-by: Scott Mathis <smathis@vmware.com>

view details

Cory Rylan

commit sha 6bd0fcb44940c4593b28c283f6325d4779b6eded

fix: attempt to fix github PR template Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Bozhidar Dryanovski

commit sha 5e1d0bf39266ded61cbace32f9afc02c1ee1a0c3

Icons in buttons need accessible names #3530 (#3555) Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

Cory Rylan

commit sha 770ca966b9b5d1b245dd27978e9f9b44571c5b7b

[NG] steppr a11y states - describe state with button - disable button when locked on step closes #3529 Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Matt Hippely

commit sha c35cb6af493c384f82d11096f7525c056f7ee15c

build: adds file formatting script for npm users (#3615) * build: adds file formatting script for npm users * usage: `npm run format:file -- path/to/file` * multiple files can be passed to the script as needed * build: adds notes for format:file usage Signed-off-by: Matt Hippely <mhippely@vmware.com>

view details

stsogoo

commit sha 3b77397445b9dc93acd3b237a7e2d53075ec6b2d

fix(datagrid): input on hideable column Signed-off-by: stsogoo <stsogoo@vmware.com>

view details

Cory Rylan

commit sha 730e080e585defd98c9477807f7f9a5b24ba01fd

fix(forms): describe by for input validation errors Set the proper describe by when error message is visible on an input. closes #3561 Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

smathis

commit sha b7d0befc6f6a4c0ffeb8b279e6cf7b301bd4f7e6

fix: adding the text-edit set to the svg icon build script Signed-off-by: Scott Mathis <smathis@vmware.com>

view details

Bozhidar Dryanovski

commit sha 1190d0bd32409971cb29bb884b907f44b5b7acde

feat: clrSpinner component Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

Jeremy Wilken

commit sha 6604ba66926492efb42ceb55b204cc7031a4989c

fix(login): add labels for screen readers to form login controls fixes #3522 Signed-off-by: Jeremy Wilken <gnomation@gnomeontherun.com>

view details

Jeeyun Lim

commit sha 5fd4fd0e03ef143a32d40630fec0a5438ecc4ada

fix: dropdown item count by screen reader + docs update Signed-off-by: Jeeyun Lim <jeeyun.lim@gmail.com>

view details

Bozhidar Dryanovski

commit sha f8cf49852c3397f94579e94b657812853233fc5b

fix: Update line-height for clr-control-label Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

Jeeyun Lim

commit sha bcd032c4ef35e1dae3d0b536f9abffbd44d3a62a

fix(ng): dropdown item should add disabled attribute if set by input - closes #3634 Signed-off-by: Jeeyun Lim <jeeyun.lim@gmail.com>

view details

Cory Rylan

commit sha c58007e2405f3634334f842427559ea4455c693e

fix(stepper): remove interstitial content Move description as part of the button content to prevent interstitial content between button and panel for screen readers closes #3560 Signed-off-by: Cory Rylan <crylan@vmware.com>

view details

Bozhidar Dryanovski

commit sha 256df22bf2abc146179d15395619103b700e4f8c

fix: change clrSpinner API Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

Bozhidar Dryanovski

commit sha dc1dc2bde938f80894914c56a9eb04a93b6b78a2

fix: adding labels to datagrid single & expandable column Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>

view details

push time in 3 months

issue commentangular/angular

`as local-val` without *ngIf

@ohjames

Thanks. I think whether the let directive works or not, with only little effort put in the directive, I'm still in lodash-pipes.

And since most kinds of results of lodash pipes can be used in *ngFor, I'm not worry about it.

Thanks again.

kylecordes

comment created time in 4 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha f04ad484d5e3b8a093edbdab7884add912619dac

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 4 months

push eventKingMario/packages

KingMario

commit sha be884af4847b3bcf95849dca85097964154a17dc

update .travis.yml

view details

push time in 4 months

issue commentangular/angular

`as local-val` without *ngIf

@ohjames @amitport

Thanks. I have just updated ngx-let-directive to version 1.0.1. I created this directive by copying and modifying ngIf but made a stupid mistake because I didn't understand ng-if.ts throughly.

Now I think the new version allows rebinding.

Besides, I created this directive to be used in my ngx-lodash-pipes, hoping that I can declaratively write templates with some simple program logic. Then I found this thread.

I hope it'll be enough for my purpose. And if it's not. I think I can still use *ngIf.

kylecordes

comment created time in 4 months

push eventKingMario/packages

KingMario

commit sha 8417f73f3a60bfa6a6a984a0b4d4be2c990e9731

let-bug-fix

view details

push time in 4 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha db2a7ae39136b9aeb70438da6518b7239b049857

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 4 months

push eventKingMario/packages

KingMario

commit sha 8868d2744c986521e21d2f0a64b26f7bc5239a26

ngx-let

view details

push time in 4 months

issue commentangular/angular

`as local-val` without *ngIf

Just published a standalone let directive:

https://www.npmjs.com/package/ngx-let-directive

kylecordes

comment created time in 4 months

startedngrx-utils/ngrx-utils

started time in 4 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha 70ade88ff59b0bdda4c7b14af97d91c3b843a3c5

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 4 months

push eventKingMario/packages

KingMario

commit sha 3f54055b7f73193d37759d96c75c5672df291b1a

ngx-lodash-pipes WebStorm auto code reformat

view details

KingMario

commit sha 138953e2122bf014f2f1c32a838325ff9800d010

finish collection pipes and lodash-pipes samples refactor

view details

push time in 4 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha 2103d8b214822ff38c89e1a5f7ddd62ba2349df0

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 4 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha cd91b038aa8420019a78dd6bdf31112e1813f242

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 4 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha 403c93bbf0e939ee1812d002cab2427e1b1e1f5a

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 4 months

PR merged KingMario/packages

Bump mixin-deep from 1.3.1 to 1.3.2 dependencies

Bumps mixin-deep from 1.3.1 to 1.3.2. <details> <summary>Commits</summary>

  • 754f0c2 1.3.2
  • 90ee1fa ensure keys are valid when mixing in values
  • See full diff in compare view </details> <details> <summary>Maintainer changes</summary>

This version was pushed to npm by doowb, a new releaser for mixin-deep since your current version. </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 4 months

push eventKingMario/packages

dependabot[bot]

commit sha 00e9cf9d9e8938381fc0538793038e5feb1d0dd5

Bump mixin-deep from 1.3.1 to 1.3.2 Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

Changyu Geng

commit sha 4afb1fbcb8add8dd421586bbd7d7efa7816d7724

Merge pull request #12 from KingMario/dependabot/npm_and_yarn/mixin-deep-1.3.2 Bump mixin-deep from 1.3.1 to 1.3.2

view details

push time in 4 months

push eventKingMario/packages

dependabot[bot]

commit sha 16859a908a986c999bb91747e833bf03d614c1c1

Bump lodash from 4.17.11 to 4.17.13 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.13) Signed-off-by: dependabot[bot] <support@github.com>

view details

Changyu Geng

commit sha 08005188c53115fc54cacf9f9dc723ef73edc336

Merge pull request #11 from KingMario/dependabot/npm_and_yarn/lodash-4.17.13 Bump lodash from 4.17.11 to 4.17.13

view details

push time in 4 months

PR merged KingMario/packages

Bump lodash from 4.17.11 to 4.17.13 dependencies

Bumps lodash from 4.17.11 to 4.17.13. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -4

0 comment

2 changed files

dependabot[bot]

pr closed time in 4 months

PR merged KingMario/packages

Bump extend from 3.0.1 to 3.0.2 dependencies

Bumps extend from 3.0.1 to 3.0.2. <details> <summary>Changelog</summary>

Sourced from extend's changelog.

3.0.2 / 2018-07-19

  • [Fix] Prevent merging __proto__ property (#48)
  • [Dev Deps] update eslint, @ljharb/eslint-config, tape
  • [Tests] up to node v10.7, v9.11, v8.11, v7.10, v6.14, v4.9; use nvm install-latest-npm </details> <details> <summary>Commits</summary>
  • 8d106d2 v3.0.2
  • e97091f [Dev Deps] update tape
  • e841aac [Tests] up to node v10.7
  • 0e68e71 [Fix] Prevent merging proto property
  • a689700 Only apps should have lockfiles
  • f13c1c4 [Dev Deps] update eslint, @ljharb/eslint-config, tape
  • f3570fe [Tests] up to node v10.0, v9.11, v8.11, v7.10, v6.14, v4.9; use...
  • See full diff in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -9

0 comment

1 changed file

dependabot[bot]

pr closed time in 4 months

push eventKingMario/packages

dependabot[bot]

commit sha 65667615001a3d086b888263b4d15107f9380a1e

Bump extend from 3.0.1 to 3.0.2 Bumps [extend](https://github.com/justmoon/node-extend) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/justmoon/node-extend/releases) - [Changelog](https://github.com/justmoon/node-extend/blob/master/CHANGELOG.md) - [Commits](https://github.com/justmoon/node-extend/compare/v3.0.1...v3.0.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

Changyu Geng

commit sha db7ec5018f2a0996d724b1b0fff06735daa4d6ff

Merge pull request #10 from KingMario/dependabot/npm_and_yarn/extend-3.0.2 Bump extend from 3.0.1 to 3.0.2

view details

push time in 4 months

issue commentKingMario/packages

ERROR TypeError: value.trim is not a function

Hi @NeoSimvolist

Please use v 1.0.10 with one more bug-fix.

Thanks.

NeoSimvolist

comment created time in 4 months

issue commentKingMario/packages

BUG: Trim Directive is not working for input type="email"

Hi @amaneer94,

https://angular-y2xtgu.stackblitz.io

I tried it in Firefox and found it worked.

However, in Chrome, the current version of the trim directive will not work because the element value is not the value you typed when you added some spaces on either end.

It's more like a browser's quirks, not an error, I will leave it to be fixed later.

amaneer94

comment created time in 4 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha a0a601873267d194302a2b39e0fa8a652a590d49

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 4 months

push eventKingMario/packages

KingMario

commit sha 7f3b11b285b374fe0d7cfcc051a78ce0ad296bae

ngx-trim update, keep non-string model untouched

view details

push time in 4 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha e63cf2ee39f8d640aed334e1c53a9fea4fce5849

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 4 months

issue closedKingMario/packages

ERROR TypeError: value.trim is not a function

an error is issued here if the field type is number

https://github.com/KingMario/packages/blob/5b3dd84eb1b1adb2d510eb1b65a6604eb74239f3/projects/ngx-trim-directive/src/lib/ngx-trim.directive.ts#L103

At least make the shutdown work like this <input [trim] = "false">. This does not help at the moment.

closed time in 4 months

NeoSimvolist

issue commentKingMario/packages

ERROR TypeError: value.trim is not a function

Hi @NeoSimvolist

The issue is addressed. Please verify it with the new version 1.0.9.

Thanks.

NeoSimvolist

comment created time in 4 months

push eventKingMario/packages

KingMario

commit sha 77629f94a5cda015d57fb94bfac35f13384b39e5

ngx-trim update, treat model type and [trim]=false with gloves in writeValue wrapper

view details

push time in 4 months

issue commentKingMario/packages

ERROR TypeError: value.trim is not a function

Hi @NeoSimvolist

Thanks for the bug report.

But I'm curious that, why will you trim a number?

Could you please give me the use case before I make the update?

Thanks.

NeoSimvolist

comment created time in 4 months

startedvuejs/vue-next

started time in 5 months

push eventKingMario/view-background-image

kingmario

commit sha 5fb3f2b12fa916cd58be1c3ceefa72f431e1e6a0

enhancements for sites * Bing

view details

push time in 5 months

startedlulop-k/kurento-rtsp2webrtc

started time in 5 months

startedStreamedian/html5_rtsp_player

started time in 5 months

startedgwuhaolin/livego

started time in 5 months

startedwinlinvip/videojs-flow

started time in 5 months

startedawslabs/aws-cognito-angular-quickstart

started time in 5 months

issue openedlodash/lodash

[Feature Request] boolean xor

_.xor(true, false) === true _.xor(true, true) === xor(false, false) === false

created time in 5 months

created repositoryKingMario/full-stack-project

created time in 5 months

issue closedKingMario/packages

Angular 8 compatibiliy: ngx-trim directive fails on undefined input value

I used the library (last version) with angular 6 and I found no issue. After upgrading to angular 8 the following error appears.

This is my html file: <input type="text" [(ngModel)]="host" class="form-control" placeholder="e.g 192.168.1.1" aria-label="Host" aria-describedby="basic-addon1" trim>

I defined in the related file.ts the following property: private host: string;

This is the error when page is loaded: TypeError: Cannot read property 'trim' of undefined TypeError: Cannot read property 'trim' of undefined at DefaultValueAccessor._valueAccessor.writeValue (ngx-trim-directive.js:105)

The error disappear if i set this: private host: string= "";

Hope is simple to solve. Many thanks

closed time in 5 months

n1c086

issue commentKingMario/packages

Angular 8 compatibiliy: ngx-trim directive fails on undefined input value

@n1c086Thank you for reporting this issue.

It was resolved in the just released version 1.0.8.

BTW, you might also be interested in another input manipulating directive by me, ngx-cleave-directive.

Demo of both directives: https://stackblitz.com/edit/angular-7o3mug

&

cleave.js office site

Thanks.

n1c086

comment created time in 5 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha beed2eb1d0591524495a83e10ed951bffa574aea

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 5 months

push eventKingMario/packages

KingMario

commit sha d78314d8448ce5004fe515d67de3152e845d33b5

add ignore-bound-class-methods rule of semicolon for tslint

view details

KingMario

commit sha 5b3dd84eb1b1adb2d510eb1b65a6604eb74239f3

ngx-trim update * #7 Angular 8 compatibility issue addressed * test case update * rename the parameter for trim setter

view details

push time in 5 months

push eventKingMario/angular

hugoer

commit sha f4cd3740b20fbe483fbee54b0039eb487b82630e

fix(docs-infra): update tooltip of events link (#30643) PR Close #30643

view details

Paul Gschwendtner

commit sha aca339e8642c58607ffac3a973db973a6c803ae4

fix(ivy): unable to project into multiple slots with default selector (#30561) With View engine it was possible to declare multiple projection definitions and to programmatically project nodes into the slots. e.g. ```html <ng-content></ng-content> <ng-content></ng-content> ``` Using `ViewContainerRef#createComponent` allowed projecting nodes into one of the projection defs (through index) This no longer works with Ivy as the `projectionDef` instruction only retrieves a list of selectors instead of also retrieving entries for reserved projection slots which appear when using the default selector multiple times (as seen above). In order to fix this issue, the Ivy compiler now passes all projection slots to the `projectionDef` instruction. Meaning that there can be multiple projection slots with the same wildcard selector. This allows multi-slot projection as seen in the example above, and it also allows us to match the multi-slot node projection order from View Engine (to avoid breaking changes). It basically ensures that Ivy fully matches the View Engine behavior except of a very small edge case that has already been discussed in FW-886 (with the conclusion of working as intended). Read more here: https://hackmd.io/s/Sy2kQlgTE PR Close #30561

view details

Santosh Yadav

commit sha 876cd603f18b17f059bb635fde56f99f10601d29

docs(docs-infra): remove deprecated `Buffer` usage from stackblitz builder (#30369) Fixes #30364 PR Close #30369

view details

crisbeto

commit sha f93659057309ea30f73bf3168f8d1df9923ab599

fix(ivy): DebugNode.queryAll matching sibling nodes (#30788) Inside of `DebugNode.queryAll` we walk through all of the descendants of the node that we're querying against, however the logic that walks sideways through a node siblings also applies to the root node. This means that eventually we'll match against its nodes as well which will give us invalid results. These changes add an extra check to ensure that we aren't matching against the siblings of the root node. This PR resolves FW-1353. PR Close #30788

view details

George Kalpakas

commit sha 8ce288a8524ccb73c9e472020dcb93d136bc7b1b

fix(docs-infra): add v7 in versions dropdown (#30775) Fixes #30769 PR Close #30775

view details

Michael Head

commit sha 1315d23aa419fd51e51ecd6a08a074abad9f8387

docs: increase color contrast on elements in tutorial This increases the color contrast of elements in the tutorial (parts 1-6) in order to meet WCAG 2.0 AA standards.

view details

Brandon

commit sha fcef39048aa7697e67ce72fe96ee021fec70316c

refactor(docs-infra): update loading of custom elements to use dynamic import syntax (#30704) Removes the usage of `NgModuleFactoryLoader` and string-based imports for lazy loading. PR Close #30704

view details

Brandon

commit sha 32886cf9ace539e14e2b387cd8afb10715c8d3de

docs(docs-infra): compile module first for Ivy when loading element modules (#30704) In View Engine, NgModule factories are created for each NgModule and loaded when the module is requested. Ivy doesn't generate the factories by design and only loads the module class, so it must be compiled after being loaded. PR Close #30704

view details

Brandon

commit sha 8bedf50073a14a7992aa09b01913e6d071bceb3c

docs: update example references from "my-app" to "app-root" (#30789) "app" is the default prefix for CLI projects when generating components. This updates our examples to conform that that default Closes #19778 PR Close #30789

view details

Tim Deschryver

commit sha dd8cf19352f006ec1fac80066cbf574c529f359a

docs: fix a small typo in injectable decorator description (#30785) PR Close #30785

view details

Vikram Subramanian

commit sha 21328f2373dddf4a7dfdb194438732d26b102986

fix(ivy): add back ngDevMode to r3_injector (#30707) Import the definition so that it doesn't cause breakage with closure conformance rules. FW-1307 #resolve PR Close #30707

view details

Olivier Combe

commit sha 680d38513b4da21b30e2c92103c66942db5e46dd

fix(ivy): correctly project bare ICU expressions (#30696) Projecting bare ICU expressions failed because we would assume that component's content nodes would be projected later and doing so at that point would be wasteful. But ICU nodes are handled independently and should be inserted immediately because they will be ignored by projections. FW-1348 #resolve PR Close #30696

view details

Ben Lesh

commit sha b4e68025f8dbe825fc1e3edc126b8a48d18c8d50

refactor(ivy): add ɵɵupdateSyntheticHostBinding command (#30670) - Refactors `ɵɵcomponentHostSyntheticProperty` into `ɵɵupdateSyntheticHostBinding`, to better align it with other new instructions. PR Close #30670

view details

Umberto Tarantino

commit sha a981dd2aab4e060ac01d2e1a3441364b0481727b

docs(core): fix typo in style bindings comment (#30661) PR Close #30661

view details

Misko Hevery

commit sha fcdd7846674978f4f06f50cc0ccfc317e4751dd6

refactor(core): cleanup code with side-effects which was preventing tree-shaking (#30580) PR Close #30580

view details

Bruno João

commit sha cd6fc8bf064315aca8ee93451969d68667413e5c

docs: document UrlTree in guard return type in cheatsheet (#30822) Add UrlTree to the types of returned values in guard methods PR Close #30822

view details

Sergey Volynkin

commit sha 07cd65b5ec75aee59f8fde164c41539536e1017c

docs: fix `quickstart` link in readme (#30807) PR Close #30807

view details

Pawel Kozlowski

commit sha 815443313044e0ec0ec87af588d09eda6b88f0c8

perf(ivy): limit allocation of LQueries_ objects (#30664) Before this change we would systematically call LQueries.clone() when executting elementStart / elementContainerStart instructions. This was often unnecessary as LQueries can be mutated under 2 conditions only: - we are crossing an element that has directives with content queries (new queries must be added); - we are descending into element hierarchy (creating a child element of an existing element) and the current LQueries object is tracking shallow queries (shallow queries are removed). With this PR LQueires.clone() is only done when needed and this gratelly reduces number of LQueries object created: in the "expanding rows" benchmark number of allocated (and often GCed just after!) LQueries is reduced from ~100k -> ~35k. This represents over 1MB of memory that is not allocated. PR Close #30664

view details

Pandiyan Murugan

commit sha 3ed7463ad73b049b7ee4fee52c4be40b05f4f843

docs: rename component for constructor example (#30845) PR Close #30845

view details

Brandon

commit sha 812c231b0c08a18487c08b594b0832c93b46d261

docs: update example dependencies to 8.x release (#30755) PR Close #30755

view details

push time in 5 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha 6faa3519caaa90d393138fea0c9d9b9e98d273a1

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 5 months

push eventKingMario/packages

KingMario

commit sha a5d1e192166f25b78cc0fab76f5dc6420902fc39

Array pipes finished

view details

push time in 5 months

push eventKingMario/packages

Deployment Bot (from Travis CI)

commit sha aa4c702444236d35557ee12bcb187331dcfb0472

Deploy KingMario/packages to github.com/KingMario/packages.git:gh-pages

view details

push time in 5 months

push eventKingMario/packages

KingMario

commit sha ce90756bdeacae1c7e82e8bf3d3b5a706cc0b50a

Array pipes finished

view details

push time in 5 months

more