KELiON ( Alexandr Subbotin )

 public final class AppboosterSDK: NSObject {     return value(key)   } -  public var userProperties: [String: Any] {-    var userProperties: [String: Any] = [:]+  public var userTests: [String: Any] {

@VladimirKhuraskin давай может просто experiments назовём, чтобы везде одна терминология была? Длинновато, но вроде без путаницы

VladimirKhuraskin

comment created time in 2 months

Pull request review commentappbooster/appbooster-sdk-ios

Create deploy_to_cocoapods.yml

+name: deploy_to_cocoapods++on:+  push:+    branches: +      - master

Т.к. это библиотека – я бы это поменял и паблишил при создании релиза на гитхабе, вместо пуша в мастер

VladimirKhuraskin

comment created time in 2 months

MemberEvent

issue commentandresz1/size-limit-action

Unable to skip step for base branch

@andresz1 it doesn't work because in this line it runs /usr/bin/yarn run NODE_ENV=production yarn build

Komalov

comment created time in 2 months

startedpassbolt/passbolt_api

started time in 2 months

issue commentandresz1/size-limit-action

Unable to skip step for base branch

@andresz1 thanks for your reply! I would like to join the conversation and explain more details.

I think we use the common flow:

install dependencies, create a production build, measure
switch to master branch, install dependencies, measure
compare

But there is a dilemma with the environment. When we use NODE_ENV=production in github action ENV yarn install doesn't install devDependencies (including webpack) so build script doesn't work. On the other side when we use NODE_ENV=development we have a development build that is not used in production and doesn't make sense to be compared.

So we tried to use skip_step, run NODE_ENV=development yarn install, NODE_ENV=production yarn build manually in both current and master branches and compare build sizes using this action. But it also doesn't work since build_step works only in the current branch, not in master.

Would be nice if you have any suggestions on how can we solve it. Thanks!

Komalov

comment created time in 3 months