profile
viewpoint
Jonathan Downing JonathanDowning @popsa-hq San Francisco, CA https://jonathandowning.uk Software Engineer, Pilot ✈️ 💻 🏳️‍🌈

JonathanDowning/WebAuthenticationSession 8

A drop in replacement for SFAuthenticationSession and ASWebAuthenticationSession.

JonathanDowning/SwiftMETAR 6

A METAR parser written in Swift

JonathanDowning/OpenVPNAdapter 1

Objective-C wrapper for OpenVPN library. Compatible with iOS and macOS.

JonathanDowning/braintree_ios 0

Braintree SDK for iOS

JonathanDowning/CryptoSwift 0

CryptoSwift is a growing collection of standard and secure cryptographic algorithms implemented in Swift

JonathanDowning/CV 0

My Curriculum Vitae

JonathanDowning/ios-branch-deep-linking-attribution 0

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.

JonathanDowning/Leanplum-iOS-SDK 0

Leanplum's integrated solution delivers meaningful engagement across messaging and the in-app experience.

JonathanDowning/mapkit-jwt-signer 0

MapKit JWT Signing Service

startedOliver-Binns/tube-status-ios

started time in 6 hours

delete branch JonathanDowning/Leanplum-iOS-SDK

delete branch : fix/casting-warning

delete time in a day

delete branch JonathanDowning/sentry-cocoa

delete branch : fix/deployment-targets

delete time in 4 days

push eventJonathanDowning/sentry-cocoa

Jonathan Downing

commit sha fee6005a4e25e875bb5758db2ced7c1b4cb463fa

Update CHANGELOG.md

view details

push time in 4 days

startednalexn/clean-architecture-swiftui

started time in 5 days

push eventJonathanDowning/Leanplum-iOS-SDK

Mayank Sanganeria

commit sha 2e25033776f9e01ab19e36bea6b8c2c477418ff8

Rename Track methods for Swift (#379)

view details

Jonathan Downing

commit sha 657fb8411b28b1b0f25744e04840d0a0fe41f1a0

Merge branch 'master' into fix/casting-warning

view details

push time in 6 days

delete branch JonathanDowning/Leanplum-iOS-SDK

delete branch : fix/nullability-warnings

delete time in 7 days

pull request commentgetsentry/sentry-cocoa

Remove Explicit Deployment Targets

All done! Thank you all for your time!

JonathanDowning

comment created time in 7 days

push eventJonathanDowning/sentry-cocoa

Jonathan Downing

commit sha ffcf9d313fdc584ae687729d52302001ef725560

Update Package.swift

view details

push time in 7 days

push eventJonathanDowning/Leanplum-iOS-SDK

Jonathan Downing

commit sha 53898023177dccf57f387cdace16e478df8dc252

Fix Catalyst Build Error

view details

push time in 8 days

PR opened Leanplum/Leanplum-iOS-SDK

Fix Catalyst Build Error

Background

SKPaymentTransaction.transactionReceipt is marked as unavailable on Mac Catalyst, in favor of NSBundle.mainBundle.appStoreReceiptURL. This PR compiles the old API when building for Catalyst.

Implementation

N/A

Testing steps

N/A

Is this change backwards-compatible?

Yes

+2 -0

0 comment

1 changed file

pr created time in 8 days

create barnchJonathanDowning/Leanplum-iOS-SDK

branch : fix/catalyst-receipt

created branch time in 8 days

create barnchJonathanDowning/Leanplum-iOS-SDK

branch : spm

created branch time in 8 days

delete branch JonathanDowning/Leanplum-iOS-SDK

delete branch : spm

delete time in 8 days

PR opened Leanplum/Leanplum-iOS-SDK

Fix Nullability Annotation Warnings

Background

Two arguments in the + (void)startWithUserId:userAttributes:responseHandler:) method are incorrectly annotated as nonnull (owing to NS_ASSUME_NONNULL_BEGIN) when they should be nullable. This results in the following error in the following code in `Leanplum.m:348 :

Null passed to a callee that requires a non-null argument

+ (void)start
{
    [self startWithUserId:nil userAttributes:nil responseHandler:nil];
}

Implementation

I have annotated the relevant arguments with nullable to silence this warning and more accurately reflect the fact that the method can accept nil arguments.

Testing steps

N/A

Is this change backwards-compatible?

Yes, making non null arguments nullable does not cause backwards compatibility issues, the reverse is not necessarily true.

+2 -2

0 comment

1 changed file

pr created time in 8 days

PR opened Leanplum/Leanplum-iOS-SDK

Fix Integer Format Specifier Warning

Background

Since NSUInteger is variable size based on architecture, it’s best to cast the variable to an explictly sized unsigned long and use the appropriate format specifier

Implementation

N/A

Testing steps

N/A

Is this change backwards-compatible?

Yes

+1 -1

0 comment

1 changed file

pr created time in 8 days

create barnchJonathanDowning/Leanplum-iOS-SDK

branch : fix/casting-warning

created branch time in 8 days

create barnchJonathanDowning/Leanplum-iOS-SDK

branch : fix/nullability-warnings

created branch time in 8 days

push eventJonathanDowning/sentry-cocoa

Philipp Hofmann

commit sha 002efa6304a355a80f8c94fab2d5487e744ace1b

feat: Simplified SDK start (#580) Add startWithConfigureOptions to SentrySDK to make setting up the SDK with SentryOptions easier. Fixes GH-516

view details

Jonathan Downing

commit sha 65ec95d58a5a6f6d156c223507174db8500b5ccb

Merge branch 'master' into fix/deployment-targets

view details

push time in 8 days

pull request commentgetsentry/sentry-cocoa

Remove Explicit Deployment Targets

@ohitsdaniel The original proposed PR removed the explicit deployment targets, to achieve your goal of supporting iOS 8 on Xcode 11 and iOS 9 on Xcode 12. I'd be more than happy to revert those changes. What do you think?

JonathanDowning

comment created time in 8 days

pull request commentLeanplum/Leanplum-iOS-SDK

Add Swift Package Manager Support

Hey @milos1290 ! I've updated the PR with a version compatible with resources (in Xcode 12).

Would you be opposed to keeping the Package@swift-5.1 for developers such as myself who don't rely on the view controllers and would like to use SPM before September?

JonathanDowning

comment created time in 8 days

push eventJonathanDowning/Leanplum-iOS-SDK

Jonathan Downing

commit sha 277d0598f7698c165edef0220bc5d1f4b028edb5

Add Support For Resources

view details

push time in 8 days

PR opened mixpanel/mixpanel-swift

Add Swift Package Manager Support

This PR adds support for Swift Package manager.

There are two Package.swift files, one compatible with swift 5.3 and resources, another which is compatible with Swift 5.2 without resources, since they're not supported in that version.

I added the 5.2 version since there may be some users who wish to use Mixpanel with Swift Package Manager right now and don't use the features which require resources.

I tried to keep file system changes to a minimum, but some changes were needed to simplify the Package.swift file.

Looking forward to discussing this!

+86 -10

0 comment

16 changed files

pr created time in 8 days

push eventJonathanDowning/mixpanel-swift

Jonathan Downing

commit sha 30e2e6b7ed636f13d9f79e6ed0017199e5b2d0a1

Add version check

view details

push time in 8 days

push eventJonathanDowning/mixpanel-swift

Jonathan Downing

commit sha 93a7001313e9ca3702dda26656397df3e8879cd0

Add Swift Package Manager Support

view details

push time in 8 days

create barnchJonathanDowning/mixpanel-swift

branch : feature/swift-package-manager

created branch time in 8 days

push eventJonathanDowning/mixpanel-swift

Ben Gottlieb

commit sha 625095de5deaba94bf0478851ea75222c6fd58f7

fixed 2 build warnings

view details

Ben Gottlieb

commit sha f4e540fce71188f34f106378f4ef2d4e8830ea08

tweaked spacing

view details

Zihe Jia

commit sha 06d878896af66ec2f1184b2ccfd3c8aa2e101e30

fix potential crash from check decide

view details

Zihe Jia

commit sha 78e13f300e27a9a32bc51bcb5d97a8efde503fbc

use serviceCurrentRadioAccessTechnology over deprecated telephonyInfo.currentRadioAccessTechnology

view details

Zihe Jia

commit sha fdebc388f55fb7549b1260e8713a8a7650e02b25

Merge pull request #369 from mixpanel/setCurrentRadio-crash-fix Fix deprecated `currentRadioAccessTechnology` in CTTelephonyNetworkInfo

view details

Zihe Jia

commit sha 8e0f481f34b868961a9af81c3080bd5d5938a2db

add NSNumber support as a property value type, using NSNumber with Bool value can avoid swift bool type decoding to int from disk issue.

view details

Zihe Jia

commit sha d0cbe6b2782f14da8a011a245bd3d036ff4daa2f

Merge pull request #366 from mixpanel/fix-check-decide-crash fix potential crash from check decide

view details

Zihe Jia

commit sha 9169ec13a2e35d8ca027faea7438ae6c91eb8a5d

add a new public property `trackAutomaticEventsEnabled` to Mixpanel instance for toggling automatic events without server(AutoTrack)

view details

Zihe Jia

commit sha 92042b5d01490ba69d82926b51d28bb187a2e8f0

Merge pull request #371 from mixpanel/fix-bool-archive add NSNumber support as a property value type

view details

Zihe Jia

commit sha 4d1a5f48ff1b328a871c2430ac2a7e87b4443260

Merge pull request #351 from bengottlieb/master Fixed two minor build warnings for Xcode 11.4b3

view details

Zihe Jia

commit sha 35e006e57e72ea7f702aa5478fa631647171137b

Merge pull request #370 from mixpanel/add-turn-off-automatic-events add a new public property `trackAutomaticEventsEnabled` to Mixpanel

view details

Zihe Jia

commit sha 7fc5e018d74b034c10d5ea3c5e6bcfc1324ddb5e

Version 2.7.2

view details

Zihe Jia

commit sha 9e78257f7729480d72694e7d1e153b04e47eba79

Merge branch 'master' of github.com:mixpanel/mixpanel-swift

view details

Zihe Jia

commit sha c28606227ae56dd46126b9d9bb04e29757fd4a5e

Update docs

view details

Zihe Jia

commit sha 2bc0e1a0a33619fdb8b149e3bc23c30556b7311b

critical fix for a flush and archive bug: - make archive/unarchive always respect queue size limit (since we merge the flush queue and the tracking queue together, without this change, there is a possibility to go over the limit) - save progress when flush a queue, call archive right after successfully flushed for each batch of events, this is to prevent we send duplicated events or lost events. - make archive always happens inside a network queue, this is to prevent race conditions for both flush queue and track queue. The flush queue and track queue transitions happens in network queue so archive should be in the same queue.

view details

Zihe Jia

commit sha 4dcb3e9ed2637b1822f0c3983c11efa46609f5d2

fix sending bool value using NSNumber should get correct bool

view details

Zihe Jia

commit sha c93c457f8cdef0d10ea4aaba5c52d681597632f0

Version 2.7.3

view details

Zihe Jia

commit sha d7e96948e5e6d186eb3b22c788b6294405cd3b2e

Merge pull request #373 from mixpanel/zihe-fix-flush-event-queue critical fix for issues with flush and archive

view details

Zihe Jia

commit sha e7e3c28d82ecbd992708621908ade83f52c9dcb2

Update docs

view details

RamblinWreck77

commit sha de36e6a4177ba51398fbd2aa875bfb1556cad0bd

Additional safety when reading device radio props

view details

push time in 8 days

created tagJonathanDowning/mixpanel-swift

tagv2.7.2

Mixpanel tracking library for iOS (Swift)

created time in 8 days

created tagJonathanDowning/mixpanel-swift

tagv2.7.3

Mixpanel tracking library for iOS (Swift)

created time in 8 days

push eventJonathanDowning/Leanplum-iOS-SDK

Jonathan Downing

commit sha 375d0f402d38c9a8ef9a04bcd2a2df5f3412c42b

Delete contents.xcworkspacedata

view details

push time in 9 days

PR opened Leanplum/Leanplum-iOS-SDK

Add Swift Package Manager Support

Background

Swift Package Manager functionality is currently broken in master. SPM requires all public headers be located in a single directory, since .h files are nested in many folders.

Implementation

I have added symbolic links to a new include folder to satisfy this requirement whilst retaining the current folder structure for compatibility with the current Podspec, etc.

Testing steps

I have tested this in my own project and everything works as expected.

Is this change backwards-compatible?

Yes, to my knowledge since SPM never worked in this project.

+92 -3

0 comment

84 changed files

pr created time in 9 days

create barnchJonathanDowning/Leanplum-iOS-SDK

branch : feature/spm-symlinks

created branch time in 9 days

push eventJonathanDowning/Leanplum-iOS-SDK

Mayank Sanganeria

commit sha e371ac57a89ffd2a4aeab03e2b5f2f4f66749bc1

add react native trigger

view details

Mayank Sanganeria

commit sha d17e9edeba08a7aabf02335673bf53cb271cabba

add react native trigger

view details

Mayank Sanganeria

commit sha 70a8d5ea63ae917e50255a053f2ced016da29553

trigger location

view details

Mayank Sanganeria

commit sha 8c342d24b5de0ab5a22ec321e2e6874c27cab0e9

fix web background color (#362)

view details

dejan2k

commit sha 27bb3b632cf24b2a234e9b4e53b86be25ef5730a

Fix banner (#363) * fix banner template * refactor

view details

Milos Jakovljevic

commit sha 179beaf4640f25270442c7479917522c2217fdfe

Fixing chained iam not displayed (#365)

view details

Mayank Sanganeria

commit sha dbb88fbd695e679a4be9f28dab0d190114ec1249

Release/2.7.2 (#368) * release candidate * update version * update github key * update version * add method for cleaning Leanplum_Resources cache folder on every new … (#353) * add method for cleaning Leanplum_Resources cache folder on every new version of the sdk * changing the place where clearCacheIfNeeded method is called. Instead of calling it in start method now it is called in startWith.... method because this method is doing all the work for starting the sdk * changing the name of the method to be more understandable * update version to beta3 * update version * release * update version * dont crash on start in dev mode * version bump * update version * return on start repeat * update version * bump v * update version * add module map Co-authored-by: dejan2k <dejan.krstevski@leanplum.com>

view details

Mayank Sanganeria

commit sha 5181d4c6e375b0e7472fee78cea6e0725a6d016b

Release/2.8.0 (#369) * version bump * update version * version bump * update version * version bump * update version * Fixing an issue with preprocessor macro (#360) Co-authored-by: Mayank Sanganeria <mayank.sanganeria@leanplum.com> * version bump * update version * bump version * update version * bump version * update version * bump version * update version * run after deploy once * bump version * update version * fix visual appearance * trigger location earlier * version bump * update version * add module map * version bump * update version * version bump * update version * update docs * bump version * update version * dont crash on start in dev mode * version bump * update version * release version * update version Co-authored-by: Milos Jakovljevic <milos1290@users.noreply.github.com>

view details

Milos Jakovljevic

commit sha e8e8e48feb6bb8be40b7e5a2d48573646b280521

Additional swift support, renaming classes for swift (#361) * Additional swift support, renaming classes for swift * Renaming message class * Reverting advance to accept nil * Improving swift support * Additional support * Removing empty block * Fixing failing tests * Renaming enum to avoid conflict Co-authored-by: Mayank Sanganeria <mayank.sanganeria@leanplum.com>

view details

Milos Jakovljevic

commit sha 80fa3d7b28cc7054082866b8d6067293b8e0b386

Fixing an issue where new and old user id match (#370)

view details

Beniamin

commit sha e04215edf7538fbf54c63a1acfe0d7b12a3a87d2

Fix carthage issue (#372) Co-authored-by: Beniamin Sarkisian <bsarkisyan@projectx019.com>

view details

Milos Jakovljevic

commit sha 57da191170d3618c78719c34f6b832665f417324

[LP-11296] Remove deprecated code (#366) * Remove deprecated code * Remove UIEditor remaining references * Fixing failing test, renaming file * Removing unused code * Fixing failing test * Renaming constants for swift

view details

dejan2k

commit sha b0acd7f6eb03f649f9f1981d824e3c0a9f8206ce

Centralize push notifications logic (#371) * push notifications logic centralized * organizing files in groups and create LPNotificationsConstants file * fixing warnings and more refactor * more refactoring (split the logic between manager and handler) unit tests * added some tests, and refactor * add missing bracket * clean leftovers * change push registration after push ask to ask is received * fix handling popup even if actionName is Push Ask To Ask * use weak self in blocks * move swizzling initialization from LPActionManager to LPPushNotificationManger * import UIKit where using UI classes

view details

Milos Jakovljevic

commit sha 26dfe53f55263ca5f4608e238ae2dfb47cb79b25

Exposing PN headers (#375)

view details

Nikola Zagorchev

commit sha a7291c5958cb0430273bad83ca7b010afd4e5759

Fix Open action when Mute Inside App used (#373)

view details

Mayank Sanganeria

commit sha 7b60e1c9a95a3b5e2b37d600f4ccf48e7406062a

change method to properties (#374) * change method to properties * fix nullability

view details

Milos Jakovljevic

commit sha 3003f9ac0b3f7f444d2f35d9dc6dda95031573a4

Fixing LPActionManager warnings (#376)

view details

Milos Jakovljevic

commit sha 79614ba574b5ee6949e25dca3dcb00a4688bc489

Reverting swift removal of start methods (#377)

view details

push time in 9 days

pull request commentBranchMetrics/ios-branch-deep-linking-attribution

Add Swift Package Manager Support

Thanks for the PR. Unfortunately cocoapods and carthage rely on the unusual filesystem layout to function correctly. I'm working on correcting this issue, but have been pulled off onto other projects. The proper fix is to bring the filesystem to a standard layout as you've done, fix cocoapods, carthage and add SPM all in one go.

I'll bring this up with Product again though. It's something that really needs to be done.

Thanks for the reply, I look forward to seeing this get done!

JonathanDowning

comment created time in 9 days

push eventJonathanDowning/sentry-cocoa

Jonathan Downing

commit sha 358293efded97bb8d6219f0730ee4c9b345f9a32

Update Package.swift

view details

push time in 9 days

push eventJonathanDowning/sentry-cocoa

Jonathan Downing

commit sha 6b62bead39b28b9711ff8c0536b03c6d34c1105b

Update Package.swift

view details

push time in 9 days

push eventJonathanDowning/sentry-cocoa

Philipp Hofmann

commit sha 047512bdc2d17299e0029ba93d1eaf6d74af67e9

fix: Custom release name for crash reports (#590) * fix: Custom release name for crash reports Custom release names configured in SentryOptions are ignored in crash reports. This is fixed by passing the release name of the options to the user info of SentryCrash. Fixes GH-581

view details

Jonathan Downing

commit sha d3d329209809ccb56186e6166995667312039c5b

Merge branch 'master' into fix/deployment-targets

view details

push time in 9 days

Pull request review commentgetsentry/sentry-cocoa

Remove Explicit Deployment Targets

 import PackageDescription  let package = Package(     name: "Sentry",-    platforms: [-        .macOS(.v10_10),-        .iOS(.v8),-        .tvOS(.v9),-        .watchOS(.v2)-    ],

Hey! I’m happy to make this change.

However.

The reason I removed the explicit deployment targets is this will retain the previous behavior of having iOS 8 as the deployment target for Xcode 11.

I figured in a years fine when iOS 9 is possibly removed from Xcode 13, we will need to do a similar PR to change the minimum deployment target to iOS 10.

Omitting the target all together will do this automatically and implicitly.

Same is true of watchOS, tvOS, and macOS.

What do you think is the better approach? I personally advocate for removing the explicit versioning since there is no practical reason for it in Sentry’s case.

JonathanDowning

comment created time in 9 days

create barnchJonathanDowning/stripe-ios

branch : spm

created branch time in 10 days

PR opened getsentry/sentry-cocoa

Reviewers
Remove Explicit Deployment Targets

:scroll: Description

This PR removes explicit deployment targets for Sentry when using Swift Package Manager.

:bulb: Motivation and Context

In Xcode 12.0 beta, the minimum supported deployment target is iOS 9.0. Consequently, Sentry explicitly choosing iOS 8 as a minimum deployment target results in an error: Screen Shot 2020-06-22 at 2 29 52 PM

This will have no effect on Xcode 11, since the explicitly chosen OS deployment targets are the default targets.

:green_heart: How did you test it?

Running project on both Xcode 11 and 12.

:pencil: Checklist

<!--- Put an x in the boxes that apply -->

  • [X] I reviewed submitted code
  • [X] I added tests to verify the changes
  • [X] All tests are passing
  • [ ] I've updated the CHANGELOG

:crystal_ball: Next steps

+0 -6

0 comment

1 changed file

pr created time in 11 days

create barnchJonathanDowning/sentry-cocoa

branch : fix/deployment-targets

created branch time in 11 days

fork JonathanDowning/sentry-cocoa

The official Sentry SDK for iOS, tvOS, macOS, watchOS

https://sentry.io/for/cocoa/

fork in 11 days

issue commentSwiftGen/SwiftGen

SwiftGen 6.2.0 generates default.profraw files

I've added a workaround for this in our Xcode project in the meantime!

if which swiftgen >/dev/null; then
swiftgen
rm "$SRCROOT/default.profraw" # Workaround for Swiftgen 6.2.0 producing this file.
else
echo "warning: SwiftGen not installed, download it from https://github.com/SwiftGen/SwiftGen"
fi
marcelofabri

comment created time in 14 days

PR opened BranchMetrics/ios-branch-deep-linking-attribution

Implement Swift Package Manager

This PR implements Swift Package Manager Support

I attempted to achieve this without filesystem changes, but I was not able to. Instead I flattened the source's folder structure to one level.

I really look forward to discussing this PR and hopefully getting it merged in one form or another.

+22 -4

0 comment

44 changed files

pr created time in 16 days

push eventJonathanDowning/ios-branch-deep-linking-attribution

Jonathan Downing

commit sha 1bf30fd4dbe1d6cfee70f5fc6783203ef5262d96

Implement Swift Package Manager

view details

push time in 16 days

push eventJonathanDowning/ios-branch-deep-linking-attribution

Jonathan Downing

commit sha 12e56fe7765e7cd8c48c1ee1204ed03c5a17e627

Implement Swift Package Manager

view details

push time in 16 days

push eventJonathanDowning/ios-branch-deep-linking-attribution

Jonathan Downing

commit sha dff1fa61559d710bd01f0ce15122f4d43fbd806e

Implement Swift Package Manager

view details

push time in 16 days

push eventJonathanDowning/ios-branch-deep-linking-attribution

Jonathan Downing

commit sha af1ef255ce6adc1768f10d5b91af1d08142afee6

Implement Swift Package Manager

view details

push time in 16 days

push eventJonathanDowning/ios-branch-deep-linking-attribution

Jonathan Downing

commit sha 49486a899347e99efcc8783e82d9c9b2b88e97a9

Implement Swift Package Manager

view details

push time in 16 days

create barnchJonathanDowning/ios-branch-deep-linking-attribution

branch : spm

created branch time in 16 days

fork JonathanDowning/ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.

https://docs.branch.io/apps/ios/

fork in 16 days

push eventJonathanDowning/jonathandowning.github.io

Jonathan Downing

commit sha 655574775bdad691ec060bd2b683ebb141b95a8a

Update index.html

view details

push time in a month

push eventJonathanDowning/Website

Jonathan Downing

commit sha 302640a211cb7d6e9ced627f794495d73501912c

Publish deploy 2020-05-10 18:51

view details

push time in 2 months

push eventJonathanDowning/Website

Jonathan Downing

commit sha 8803bed14289ab714065835754d92d557c97b6a9

Publish deploy 2020-05-10 18:49

view details

push time in 2 months

create barnchJonathanDowning/Website

branch : master

created branch time in 2 months

created repositoryJonathanDowning/Website

created time in 2 months

PR closed Leanplum/Leanplum-iOS-SDK

Add Support for Swift Package Manager

Background

This PR adds support for Swift Package Manager. I would have created an issue for this but since they're not enabled for this project, I chose to make a reference implementation instead.

Implementation

Due to the nature of Swift Package Manager directory structures for Objective-C code, I needed to move the files into a new directory structure. You'll notice all header files are now situated in an include directory. Implementation files have stayed put.

I believe it is possible to achieve support for SPM without moving files around, this PR demonstrates this, however I was unable to get this working in a reasonable time so I opted for the include route.

Code reviewers may be uncomfortable with this PR because files have been relocated, in this case I hope this PR acts as inspiration to get this feature implemented. We would love to have this SDK support Swift Package Manager!

Testing steps

Opening Package.swift in Xcode and verifying the package builds for iOS.

+2172 -1691

0 comment

98 changed files

JonathanDowning

pr closed time in 2 months

push eventJonathanDowning/Leanplum-iOS-SDK

Jonathan Downing

commit sha f623cdaac9e7e15fca8081e2cd89f36294e83988

Fix Catalyst Issue

view details

push time in 2 months

create barnchJonathanDowning/Leanplum-iOS-SDK

branch : spm

created branch time in 2 months

fork JonathanDowning/Leanplum-iOS-SDK

Leanplum's integrated solution delivers meaningful engagement across messaging and the in-app experience.

https://www.leanplum.com

fork in 2 months

startedLeanplum/Leanplum-iOS-SDK

started time in 2 months

create barnchJonathanDowning/ios-branch-deep-linking-attribution

branch : spm

created branch time in 2 months

fork JonathanDowning/ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.

https://docs.branch.io/apps/ios/

fork in 2 months

push eventJonathanDowning/mixpanel-swift

Jonathan Downing

commit sha 830cf4a1d9821344e6d2d10eb7d9f8ee62d629cc

Add Swift Package Manager Support

view details

push time in 2 months

create barnchJonathanDowning/mixpanel-swift

branch : spm

created branch time in 2 months

pull request commentpusher/pusher-websocket-swift

Add Swift 5 Support

Closing due to #261, thanks @TomKemp !

JonathanDowning

comment created time in 2 months

delete branch JonathanDowning/pusher-websocket-swift

delete branch : swift-5

delete time in 2 months

PR closed pusher/pusher-websocket-swift

Reviewers
Add Swift 5 Support

Description of the pull request

This PR drops support for Swift 4.2, updates dependencies to latest versions, and changes syntax to be compatible with Swift 5 and the newer dependencies.

Why is the change necessary?

PusherSwift currently uses older versions of dependencies to maintain support for Swift 4.2, since Swift 5.1 is now the latest, it's perhaps high time to drop 4.2.

+41 -38

6 comments

12 changed files

JonathanDowning

pr closed time in 2 months

push eventJonathanDowning/pusher-websocket-swift

Tom Kemp

commit sha 245a63be81cb7e4832bd3fa97ccbf2f8047ced39

Replace CryptoSwift with CommonCrypto HMAC functions

view details

Tom Kemp

commit sha e24a95771f187361fce68bc1963b14d28ffb63e2

Remove redundant nil check

view details

Tom Kemp

commit sha 29d1eb99f545a9c39b8c9658d5dc8d5aa07c975e

Remove CryptoSwift from example project builds

view details

OliverPearmain-Pusher

commit sha 07f8a81341cf8bcc2cc7efa63aecff86d84f4ca5

Merge pull request #245 from pusher/remove-cryptoswift Replace CryptoSwift with CommonCrypto HMAC functions

view details

Jonathan Downing

commit sha 1dd1329c71460b306eedad187e9c00355371ac90

Merge branch 'master' of https://github.com/pusher/pusher-websocket-swift into swift-5 # Conflicts: # Cartfile # Cartfile.resolved # Package.resolved # Package.swift # PusherSwift.podspec # Sources/PusherConnection.swift

view details

Jonathan Downing

commit sha 9148673335e2d8fd9af48fc5675417080f7cc9ec

Fix deprecation warning

view details

push time in 3 months

PR closed MihaelIsaev/branch.io.spm

Add include directory

This package does not work unless the header files are in an include directory. (I think there are alternatives but this is the standard approach)

+10 -4

0 comment

150 changed files

JonathanDowning

pr closed time in 3 months

PR opened MihaelIsaev/branch.io.spm

Add include directory

This package does not work unless the header files are in an include directory. (I think there are alternatives but this is the standard approach)

+10 -4

0 comment

150 changed files

pr created time in 3 months

push eventJonathanDowning/branch.io.spm

Jonathan Downing

commit sha cdd79ff48845d13961c73908e5e9f3238366f587

Add include directory

view details

push time in 3 months

fork JonathanDowning/branch.io.spm

Branch.io iOS SDK with SPM support (cleaned from `framework` files)

fork in 3 months

more