profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/JohnMcLear/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
John McLear JohnMcLear @ether Bradford http://mclear.co.uk 🌞 My work is now donated to the Etherpad Foundation (ether/). I'm offline till ~Sep 2021 so please don't assign me things or expect any input from me :)

ether/ep_comments_page 32

Comments in Etherpad - No Longer Highly Experimental, now highly awesome!

ether/ep_headings2 13

Headings Plugin for Etherpad

clkao/ep_author_neat 9

Use colored underline for authorship instead of background color

ether/ep_cursortrace 9

Etherpad plugin to trace the cursor(actually caret) of other users in real time

ether/ep_email_notifications 9

Subscribe to a pad and recieve an email when someone edits your pad

ether/ep_adminpads2 7

Etherpad plugin to list and delete pads in /admin

ether/ep_align 5

Align text (left, middle, right) in Etherpad

ether/ep_author_hover 5

Hover over Etherpad pad contents to see who the author is

ether/ep_hash_auth 4

Etherpad plugin that allows the usage of hash values for authentoication in settings.json

citizenos/ep_image_upload 3

Add images to etherpad and upload them to Amazon S3

create barnchether/etherpad-lite

branch : snyk-fix-7422c89323461d4d0e46f07a1789e602

created branch time in 5 days

push eventether/etherpad-lite

snyk-bot

commit sha 8efb0fa1e453af1f48a61bfb8243cb5eeab0a80e

fix: src/package.json & src/package-lock.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908

view details

push time in 5 days

issue commentether/etherpad-lite

CONF: DB configuration "dbSettings" connection string support has been dropped (>1.8.7)?

Just to distill for myself. The dbSettings string is important for reasons @tiblu mentions, https://github.com/ether/ueberDB/blob/master/databases/postgres_db.js doesn't have any parsing logic, perhaps before it did? Either way, OP wants the string method for accessing a postgres database supported by UeberDB, which feels like a fair enough request.

tiblu

comment created time in 6 days

issue commentether/etherpad-lite

Facility to prevent focus theft when embedded (in Element for example)

Ready for testing and feedback :)

ScottRochford

comment created time in 6 days

push eventether/etherpad-lite

John McLear

commit sha cbcb96b64b9be0e6146b3ffc9671b49d0713f652

docs: doc for focusOnEditor URL Param

view details

push time in 6 days

push eventether/etherpad-lite

John McLear

commit sha 963cf1b92c815735e411834bf9513456e05515bd

ux: allow for ?focusOnEditor URL Param to disable focus on Editor with false value

view details

push time in 6 days

issue commentether/etherpad-lite

Ordered list not incrementing when put directly after an unordered list

Test coverage is available, I intend to work on a fix once we have some bad weather and I'm stuck inside.

Vringe

comment created time in 6 days

issue commentether/etherpad-lite

Facility to prevent focus theft when embedded (in Element for example)

RE http query, that's actually really the best approach here. @flotho If you want to contribute we have Github sponsors: https://github.com/ether/ - it's never expected but always appreciated and all funds go to devs.

I will try sort out http param approach today, that should be a walk in the park.

ScottRochford

comment created time in 6 days

PR opened ether/etherpad-lite

Correct ol number is placed after uls

Test coverage for https://github.com/ether/etherpad-lite/issues/5160

Still to-do:

  • [ ] Diagnose
  • [ ] Fix
+44 -0

0 comment

1 changed file

pr created time in 7 days

create barnchether/etherpad-lite

branch : jm-ol-after-ul

created branch time in 7 days

issue commentether/etherpad-lite

Facility to prevent focus theft when embedded (in Element for example)

I put forward a patch, I'm a little uneasy about this being a default user experience change tho.. Should we consider putting this under a setting in settings.json? I can imagine some embedded user experiences might want to draw focus on pad load?

ScottRochford

comment created time in 7 days

PR opened ether/etherpad-lite

ux: dont take focus when a pad is embedded in another page

When a pad is embedded in a page it's improbable you will want to draw focus as such if Etherpad is not the parent then do not pull caret or focus away from the parent page to the editor.

https://github.com/ether/etherpad-lite/issues/4996

+1 -1

0 comment

1 changed file

pr created time in 7 days

create barnchether/etherpad-lite

branch : jm-dont-focus-when-embedded

created branch time in 7 days

issue commentether/etherpad-lite

Text export includes attribs

If we already return foo.text.text we'd also need to return foo.text when rev is specified so not ideal to duplicate the data, if we dropped foo.text.textit would break existing installs... I think we should..

  1. Also return foo.text when rev is specified
  2. Docs to say to migrate from foo.text.text(when rev is specified) to foo.text
  3. Make a new API version that supports foo.text for when rev is specified & drop the attribs blob
webzwo0i

comment created time in 7 days

issue commentether/etherpad-lite

🚨 Potential Security Vulnerability

Tests available, needs final review and merge in, I bumped @rhansen for this.

ranjit-git

comment created time in 7 days

pull request commentether/etherpad-lite

RO export in HTML and Etherpad format should not expose the writeable pad id

tests now included.

webzwo0i

comment created time in 7 days

push eventether/etherpad-lite

John McLear

commit sha 4d17482f5e72298e60d298325318465d41278baf

tests: check that read only exports dont include the original padId

view details

push time in 7 days

push eventether/etherpad-lite

John McLear

commit sha 4fc5198bc6e016e9db2933383f23d5fd65ba447e

Trigger Test Action

view details

push time in 7 days

issue commentether/etherpad-lite

🚨 Potential Security Vulnerability

Picking back up on this now, hope to have it resolved this week.

ranjit-git

comment created time in 7 days

issue commentether/etherpad-lite

Missing line numbers in timeslider - regression?

https://www.npmjs.com/package/ep_timesliderdiff is worth referring to here. Note that timeslider never had line numbers, not even back in the day..

So is this a bug? I don't think so, but I would say that your line numbers should be present in the time-slider if you have them present in the editor.

It's technically not a bug tho as it's expected behaviour at this point albeit not ideal 🖌️

webzwo0i

comment created time in 12 days

issue commentether/etherpad-lite

Missing line numbers in timeslider - regression?

yeah that's weird, I don't recall dropping it. Will investigate.

webzwo0i

comment created time in 12 days

issue closedether/etherpad-lite

Plugins can't open dropdowns from within editor

Clicking on an item created by ep_mathjax will not result in the dropdown being opened.

Ref: https://github.com/ether/ep_mathjax/blob/master/static/js/hooks.js#L92 -- Note the setTimeout.

This is due to a function that closes elements.. https://github.com/ether/etherpad-lite/blob/develop/src/static/js/ace2_inner.js#L2646

Ideally the editorClick function events would be exposed to the plugin framework as a specific thing with an option to say if the plugin handled (similar to how we do handleMessage)..

The hack workaround will suffice for now but it may sting us later :)

closed time in 12 days

JohnMcLear

issue commentether/etherpad-lite

Plugins can't open dropdowns from within editor

Resolved. :)

JohnMcLear

comment created time in 12 days

issue closedether/etherpad-lite

Line number linking doesn’t work

Describe the bug I enabled line numbers in the pad settings and clicking a line number links to the anchor (e.g.) #L156. However, opening the pad with the #L156 anchor does not scroll down to line 156.

Server (please complete the following information):

  • Etherpad version: 1.8.12 (from Git)
  • OS: FreeBSD 12
  • Node.js version (node --version): v15.11.0
  • npm version (npm --version): 6.14.8

Desktop (please complete the following information):

  • OS: macOS Big Sur
  • Browser: Safari
  • Version: 14.0.3

closed time in 12 days

dertuxmalwieder

issue commentether/etherpad-lite

Line number linking doesn’t work

I just double checked this and it's working fine

dertuxmalwieder

comment created time in 12 days

issue commentether/etherpad-lite

Installed plugins won’t appear as installed

Clean install, the issue is caused by this command

npm install sqlite3

So why is this command being run in root? Well because ueberdb needs it as an optional dep: https://github.com/ether/ueberDB/blob/master/package.json#L38

dertuxmalwieder

comment created time in 12 days

issue commentether/etherpad-lite

Installed plugins won’t appear as installed

[2021-09-09 15:08:46.098] [INFO] plugins - Successfully installed plugin ep_define
[2021-09-09 15:08:46.098] [INFO] plugins - Running npm to get a list of installed plugins...
[2021-09-09 15:08:47.744] [INFO] plugins - Loading plugin ep_align...
[2021-09-09 15:08:47.745] [INFO] plugins - Loading plugin ep_etherpad-lite...
[2021-09-09 15:08:47.745] [INFO] plugins - Loaded 2 plugins

Clicking uninstall gave me

[2021-09-09 15:10:20.663] [INFO] plugins - Running npm to get a list of installed plugins...
[2021-09-09 15:10:22.334] [ERROR] runCmd|npm - npm ERR! missing: ep_align@0.3.38, required by 1
[2021-09-09 15:10:22.354] [ERROR] server - Metrics at time of fatal error:
{
  "httpStartTime": 1631196608975,
  "memoryUsage": 149770240,
  "memoryUsageHeap": 38681672,
  "ueberdb_lockAwaits": 0,
  "ueberdb_lockAcquires": 34,
  "ueberdb_lockReleases": 34,
  "ueberdb_reads": 34,
  "ueberdb_readsFailed": 0,
  "ueberdb_readsFinished": 34,
  "ueberdb_readsFromCache": 4,
  "ueberdb_readsFromDb": 30,
  "ueberdb_readsFromDbFailed": 0,
  "ueberdb_readsFromDbFinished": 30,
  "ueberdb_writes": 2,
  "ueberdb_writesFailed": 0,
  "ueberdb_writesFinished": 2,
  "ueberdb_writesObsoleted": 0,
  "ueberdb_writesToDb": 2,
  "ueberdb_writesToDbFailed": 0,
  "ueberdb_writesToDbFinished": 2,
  "ueberdb_writesToDbRetried": 0,
  "totalUsers": 2,
  "activePads": 1,
  "connects": {
    "mean": 0.24107085975809048,
    "count": 6,
    "currentRate": 0.24107051953102882,
    "1MinuteRate": 0.07924065389357614,
    "5MinuteRate": 0.01908009291112165,
    "15MinuteRate": 0.006562648554003328
  },
  "lastDisconnect": 1631196622354,
  "disconnects": {
    "mean": 0.18168431093882845,
    "count": 4,
    "currentRate": 0.18168433415927793,
    "1MinuteRate": 0.051980165726729914,
    "5MinuteRate": 0.012683646180155266,
    "15MinuteRate": 0.004371006723728731
  },
  "httpRequests": {
    "meter": {
      "mean": 0.18181908263305996,
      "count": 4,
      "currentRate": 0.18181911732626924,
      "1MinuteRate": 0.04981557799809247,
      "5MinuteRate": 0.012577951575277016,
      "15MinuteRate": 0.004358865069613559
    },
    "histogram": {
      "min": 0.6988010406494141,
      "max": 7.081258058547974,
      "sum": 9.73059606552124,
      "variance": 9.641934701956965,
      "mean": 2.43264901638031,
      "stddev": 3.1051464863927056,
      "count": 4,
      "median": 0.9752684831619263,
      "p75": 5.598810791969299,
      "p95": 7.081258058547974,
      "p99": 7.081258058547974,
      "p999": 7.081258058547974
    }
  }
}
[2021-09-09 15:10:22.354] [ERROR] server - Error: Command exited with code 1: npm ls --long --json --depth=0 --no-production
    at exports (/home/jose/proxyDemo/1/src/node/utils/run_cmd.js:119:25)
    at Object.exports.getPackages (/home/jose/proxyDemo/1/src/static/js/pluginfw/plugins.js:125:48)
    at Object.exports.update (/home/jose/proxyDemo/1/src/static/js/pluginfw/plugins.js:99:34)
    at Object.exports.uninstall (/home/jose/proxyDemo/1/src/static/js/pluginfw/installer.js:45:17)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
[2021-09-09 15:10:22.355] [INFO] server - Exiting...
[2021-09-09 15:10:22.355] [INFO] server - Stopping Etherpad...
[2021-09-09 15:10:22.355] [INFO] http - Closing HTTP server...
[2021-09-09 15:10:22.355] [INFO] socket.io - Closing socket.io engine...
[2021-09-09 15:10:22.356] [INFO] access - [LEAVE] pad:5ymYEsn1Pl0qhbvSzJt9 socket:cgb0F-lOuKq1StzDAAAF IP:127.0.0.1 authorID:a.Q5oT7SV1YdSxvVPA username:admin
[2021-09-09 15:10:22.356] [INFO] socket.io - All socket.io clients have disconnected
[2021-09-09 15:10:22.358] [INFO] http - Waiting for 2 HTTP clients to disconnect...
[2021-09-09 15:10:22.358] [INFO] console - Database closed
[2021-09-09 15:10:22.360] [INFO] http - HTTP server closed
[2021-09-09 15:10:22.361] [INFO] server - Etherpad stopped
[2021-09-09 15:10:22.361] [INFO] server - Waiting for Node.js to exit...
dertuxmalwieder

comment created time in 12 days

issue commentether/etherpad-lite

Installed plugins won’t appear as installed

Wait I think I can replicate... Commands...

npm install sqlite3
bin/installDeps.sh 
npm install sqlite3
NODE_ENV=production ./bin/run.sh
dertuxmalwieder

comment created time in 12 days

issue commentether/etherpad-lite

Installed plugins won’t appear as installed

@dertuxmalwieder Can you still produce this on the latest version of Etherpad? Also same issue if you use fastRun.sh?

dertuxmalwieder

comment created time in 12 days