profile
viewpoint

JohnBlood/awesome-basic 4

A curated list of awesome BASIC dialects, IDEs, and tutorials

JohnBlood/ANGRYsearch 1

a snap for ANGRYsearch

JohnBlood/cup-a-joe-wallpapers 1

Simple wallpapers for everyone

JohnBlood/dosage 1

a snap for dosage

JohnBlood/Adom-10 0

an IF game

JohnBlood/Archlabs-Pipemenus 0

Pipemenus used in ARCHLabs

JohnBlood/awesome-bsd 0

A collection of awesome BSD related stuff

JohnBlood/awesome-dart 0

A curated list of awesome Dart frameworks, libraries, and software

JohnBlood/beautifulhugo 0

Theme for the Hugo static website generator

JohnBlood/book 0

The Redox book

startedthethumbler/os

started time in 2 hours

startedReturnInfinity/BareMetal-OS-legacy

started time in 2 hours

startedHIPERCUBE/64bit-Multicore-OS

started time in 2 hours

push eventgohugoio/hugo

Cameron Moore

commit sha 5862fd2a60b5d16f2437bd8c8b7bac700de5f047

tpl: Fix substr when length parameter is zero When length parameter is zero, always return an empty string. Updates #7993

view details

push time in 3 hours

PR merged gohugoio/hugo

tpl: Fix substr when length parameter is zero

When length parameter is zero, always return an empty string.

Updates #7993

+9 -3

0 comment

2 changed files

moorereason

pr closed time in 3 hours

issue commentgohugoio/hugo

Add Darwin ARM64 build

It's certainly not related to this particular issue, try https://discourse.gohugo.io/

bep

comment created time in 3 hours

issue commentgohugoio/hugo

Add tabindex to highlight template func markup

The internal function wraps the code in a div tag.

https://github.com/gohugoio/hugo/blob/f0266e2ef3487bc57dd05402002fc816e3b40195/markup/highlight/highlight.go#L88-L92

Would it be possible to move this to the short code?

https://github.com/gohugoio/hugo/blob/64789fb5dcf8326f14f13d69a2576ae3aa2bbbaa/tpl/tplimpl/embedded/templates/shortcodes/highlight.html#L1

That way users have more flexibility in wrapping the generated pre block.

gpanders

comment created time in 8 hours

push eventhaiku/website

Humdinger

commit sha dcacd3975f2b4305e419520d459f184158304c03

Sounds contest: add link to tar.gz with all entries The link https://oshi.at/ATySSh expires on Dec. 31st 2020

view details

push time in 9 hours

pull request commentwebcomics/dosage

Fix for Ruthe.de and NichtLustig.de (now joscha.com)

Fix for NichtLustig.de moved to joscha.com

Arwarld

comment created time in 11 hours

Pull request review commentwereturtle/ghostwriter

WIP: CMake build

+find_package(Qt5 COMPONENTS Widgets LinguistTools)++set(ghostwriter_TRANSLATIONS+  ghostwriter_ar.ts+  ghostwriter_cs.ts+  ghostwriter_de.ts+  ghostwriter_en.ts+  ghostwriter_es.ts+  ghostwriter_fr.ts+  ghostwriter_it.ts+  ghostwriter_ja.ts+  ghostwriter_nl.ts+  ghostwriter_pl.ts+  ghostwriter_pt_BR.ts+  ghostwriter_ru.ts+  ghostwriter_zh.ts+)++qt5_add_translation(QM_FILES+  ${ghostwriter_TRANSLATIONS}+)+add_custom_target(add_translations ALL DEPENDS ${QM_FILES})++qt5_create_translation(QM_FILE_UPDATES+  ${CMAKE_SOURCE_DIR}/src+  ${ghostwriter_TRANSLATIONS}+)+add_custom_target(update_translations DEPENDS ${QM_FILE_UPDATES})++install(FILES ${QM_FILES}+  DESTINATION ${CMAKE_INSTALL_DATADIR}/ghostwriter/translations+)

It may be possible to conditionalize this for MacOS, and handle it directly from CMake instead of using the helper script.

ferdnyc

comment created time in 12 hours

Pull request review commentwereturtle/ghostwriter

WIP: CMake build

+################################################################################+#+# Copyright (C) 2014-2020 wereturtle+# Copyright (C) 2009, 2010, 2011, 2012, 2013, 2014 Graeme Gott <graeme@gottcode.org>+# CMake configuration (C) 2020 FeRD (Frank Dana)+#+# This program is free software: you can redistribute it and/or modify+# it under the terms of the GNU General Public License as published by+# the Free Software Foundation, either version 3 of the License, or+# (at your option) any later version.+#+# This program is distributed in the hope that it will be useful,+# but WITHOUT ANY WARRANTY; without even the implied warranty of+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the+# GNU General Public License for more details.+#+# You should have received a copy of the GNU General Public License+# along with this program.  If not, see <http://www.gnu.org/licenses/>.+#+################################################################################+cmake_minimum_required(VERSION 3.1...3.19 FATAL_ERROR)++set(ghostwriter_VERSION_FULL "2.0.0-rc")++# Extract Major.Minor.Patch[.Tweak] version from full string+string(REGEX MATCH+  "([0-9]+\.[0-9]+\.[0-9]+)(\.[0-9]+)?"+  _version+  ${ghostwriter_VERSION_FULL}+)++# Must be set before project() command+set(CMAKE_OSX_DEPLOYMENT_TARGET "10.10" CACHE STRING+  "Deployment Target for MacOS" FORCE)++project(ghostwriter VERSION ${_version} LANGUAGES C CXX)++# Support for standard install paths+include(GNUInstallDirs)+# Report configuration state of dependencies and options+include(FeatureSummary)++set(ghostwriter_SOURCES+  src/abstractstatisticswidget.cpp+  src/appmain.cpp+  src/appsettings.cpp+  src/cmarkgfmapi.cpp+  src/cmarkgfmexporter.cpp+  src/colorschemepreviewer.cpp+  src/commandlineexporter.cpp+  src/documenthistory.cpp+  src/documentmanager.cpp+  src/documentstatistics.cpp+  src/documentstatisticswidget.cpp+  src/exportdialog.cpp+  src/exporter.cpp+  src/exporterfactory.cpp+  src/exportformat.cpp+  src/htmlpreview.cpp+  src/localedialog.cpp+  src/mainwindow.cpp+  src/markdowndocument.cpp+  src/markdowneditor.cpp+  src/markdownhighlighter.cpp+  src/markdownast.cpp+  src/markdownnode.cpp+  src/memoryarena.cpp+  src/messageboxhelper.cpp+  src/outlinewidget.cpp+  src/preferencesdialog.cpp+  src/previewoptionsdialog.cpp+  src/sandboxedwebpage.cpp+  src/sessionstatistics.cpp+  src/sessionstatisticswidget.cpp+  src/sidebar.cpp+  src/simplefontdialog.cpp+  src/stringobserver.cpp+  src/stylesheetbuilder.cpp+  src/textblockdata.cpp+  src/theme.cpp+  src/themeeditordialog.cpp+  src/themerepository.cpp+  src/themeselectiondialog.cpp+  src/timelabel.cpp+  src/color_button.cpp+  src/findreplace.cpp+  src/spelling/dictionary_manager.cpp+  src/spelling/spell_checker.cpp+)++set(ghostwriter_HEADERS+  src/abstractstatisticswidget.h+  src/appsettings.h+  src/cmarkgfmapi.h+  src/cmarkgfmexporter.h+  src/colorscheme.h+  src/colorschemepreviewer.h+  src/commandlineexporter.h+  src/documenthistory.h+  src/documentmanager.h+  src/documentstatistics.h+  src/documentstatisticswidget.h+  src/exportdialog.h+  src/exporter.h+  src/exporterfactory.h+  src/exportformat.h+  src/htmlpreview.h+  src/localedialog.h+  src/mainwindow.h+  src/markdowndocument.h+  src/markdowneditor.h+  src/markdowneditortypes.h+  src/markdownhighlighter.h+  src/markdownast.h+  src/markdownnode.h+  src/markdownstates.h+  src/memoryarena.h+  src/messageboxhelper.h+  src/outlinewidget.h+  src/preferencesdialog.h+  src/previewoptionsdialog.h+  src/sandboxedwebpage.h+  src/sessionstatistics.h+  src/sessionstatisticswidget.h+  src/sidebar.h+  src/simplefontdialog.h+  src/stringobserver.h+  src/stylesheetbuilder.h+  src/textblockdata.h+  src/theme.h+  src/themeeditordialog.h+  src/themerepository.h+  src/themeselectiondialog.h+  src/timelabel.h+  src/findreplace.h+  src/color_button.h+  src/spelling/abstract_dictionary.h+  src/spelling/abstract_dictionary_provider.h+  src/spelling/dictionary_manager.h+  src/spelling/dictionary_ref.h+  src/spelling/spell_checker.h+)++add_executable(ghostwriter+  ${ghostwriter_SOURCES}+  resources.qrc+)++target_include_directories(ghostwriter PRIVATE+  ${CMAKE_CURRENT_SOURCE_DIR}/src+  ${CMAKE_SOURCE_DIR}+)++set_target_properties(ghostwriter PROPERTIES+  AUTOMOC TRUE+  AUTORCC TRUE+)++target_compile_features(ghostwriter PRIVATE+  cxx_std_11+  # XXX: Plus any specific features the code uses from this list:+  # https://cmake.org/cmake/help/latest/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html+)++# Compile warnings+target_compile_options(ghostwriter PRIVATE+  $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:-Wall>+  $<$<CXX_COMPILER_ID:MSVC>:/W4>+)

I noticed the .pro file had CONFIG += warn_on in it, so I added this. It could be made conditional via a cmake option(), though. Even if it defaults to ON, it would at least give builders a way to disable warnings if desired.

That'd look like:

option(ENABLE_WARNINGS "Build with warnings enabled" ON)
if(ENABLE_WARNINGS)
  target_compile_options(ghostwriter PRIVATE
    $<$<OR:$<CXX_COMPILER_ID:Clang>,$<CXX_COMPILER_ID:AppleClang>,$<CXX_COMPILER_ID:GNU>>:-Wall>
    $<$<CXX_COMPILER_ID:MSVC>:/W4>
  )
endif()

And then turning warnings off would just be a matter of adding -DENABLE_WARNINGS:BOOL=OFF to the cmake command line.

ferdnyc

comment created time in 12 hours

Pull request review commentwereturtle/ghostwriter

WIP: CMake build

+find_package(Qt5 COMPONENTS Widgets LinguistTools)++set(ghostwriter_TRANSLATIONS+  ghostwriter_ar.ts+  ghostwriter_cs.ts+  ghostwriter_de.ts+  ghostwriter_en.ts+  ghostwriter_es.ts+  ghostwriter_fr.ts+  ghostwriter_it.ts+  ghostwriter_ja.ts+  ghostwriter_nl.ts+  ghostwriter_pl.ts+  ghostwriter_pt_BR.ts+  ghostwriter_ru.ts+  ghostwriter_zh.ts+)++qt5_add_translation(QM_FILES+  ${ghostwriter_TRANSLATIONS}+)+add_custom_target(add_translations ALL DEPENDS ${QM_FILES})++qt5_create_translation(QM_FILE_UPDATES+  ${CMAKE_SOURCE_DIR}/src+  ${ghostwriter_TRANSLATIONS}+)+add_custom_target(update_translations DEPENDS ${QM_FILE_UPDATES})

The targets here are primarily for dependency management. add_translations is marked ALL so it will be run every build, since all it does is ensure the compiled translations exist in the build dir. update_translations will respond to changes in the source tree when needed. It should run automatically, but can also be triggered manually with a cmake --build <build_dir> --target update_translations

ferdnyc

comment created time in 12 hours

Pull request review commentwereturtle/ghostwriter

WIP: CMake build

  *  ***********************************************************************/ +#ifndef MEMORY_ARENA_CPP+#define MEMORY_ARENA_CPP

As the commit message for these changes notes, I ran into trouble with src/memoryarena.cpp when gcc went to compile that file itself. It includes memoryarena.h, which in turn includes memoryarena.cpp... Honestly, I'm confused how that even works under qmake, it doesn't seem like it should.

Adding include guards to the .cpp file itself fixed that issue for me, though.

Similarly, adding an empty src/textblockdata.cpp was necessary to get CMake's AUTOMOC to moc the corresponding header file.

ferdnyc

comment created time in 12 hours

Pull request review commentwereturtle/ghostwriter

WIP: CMake build

 void MemoryArena<T>::freeAll()     slotIndex = 0; } } // namespace ghostwriter++#endif  // MEMORY_ARENA_CPP
#endif  // MEMORY_ARENA_CPP

ferdnyc

comment created time in 12 hours

PR opened wereturtle/ghostwriter

WIP: CMake build

This PR adds configuration for building with CMake, as an (optional) alternative to qmake.

This is nearly complete:

  • For Linux, I believe it is complete
  • Windows builds are untested, but also may be complete. (Though I'm not 100% confident it's correctly using things like the Windows resource file and icon path.)
  • MacOS builds are also untested, and definitely NOT complete, at least in terms of installation / use of macdeployqt, etc. I can probably make some more inroads on that still, I just ran out of time/energy for the moment and figured it would be best to submit what I have so far for review and feedback.

Fixes #547

+435 -1

0 comment

8 changed files

pr created time in 12 hours

issue commentgohugoio/hugo

Add Darwin ARM64 build

It stuck to "Building ugo" on a Mac mini m1. Is this normal?

bep

comment created time in 12 hours

fork ddevault/FUZIX

FuzixOS: Because Small Is Beautiful

fork in 12 hours

issue commentgohugoio/hugo

TOC incorrect link when Header is a link

also existing on 0.79.0

jhollowe

comment created time in 12 hours

issue commentgohugoio/hugo

TOC incorrect link when Header is a link

just confirming same problem still exists

❯ hugo version
Hugo Static Site Generator v0.78.0/extended darwin/amd64 BuildDate: unknown
# I'm not worried about that BuildDate: unknown, probably just because I am on a mac as I am reporting this but you can see  I am on the latest version, and this also happens on the Linux box where I do the builds for production.

Here is what the resulting HTML looks like for the TOC for me when I have links in my headers:

<li>
    <a href="#a-link-as-a-headinghttpswwww3schoolscomtagstag_hnasp"></a>
    <a href="https://www.w3schools.com/tags/tag_hn.asp">A Link As A Heading</a>
</li>

it makes two links in the TOC. The first is empty for the > text < portion so it cant be clicked and the second shouldn't be there at all. That is the anchor id that is generated so the first link would be functional otherwise

<h2 id="a-link-as-a-headinghttpswwww3schoolscomtagstag_hnasp">
    <a href="https://www.w3schools.com/tags/tag_hn.asp">A Link As A Heading</a>
</h2>

original markdown is

## [A Link As A Heading](https://www.w3schools.com/tags/tag_hn.asp)

and my TOC shortcode is

{{ if (.Params.toc) }}
<aside>
    Table of Contents:
    {{.TableOfContents}}
</aside>
<hr>
{{ end }}
jhollowe

comment created time in 12 hours

issue commentgohugoio/hugo

Make minify rename javascript variables to make javascript even shorter

Yes, that one renames variables correctly

kssilveira

comment created time in 15 hours

issue commentgohugoio/hugo

Make minify rename javascript variables to make javascript even shorter

The output is the same as the one mentioned in the issue in both cases.

No, I meant something like this:

{{ $js := resources.Get "test.js" }}
{{ $jsm := $js | js.Build (dict "minify" true) }}
kssilveira

comment created time in 15 hours

issue commentgohugoio/hugoThemes

Theme submission Stada

@digitalcraftsman hello) I corrected all the comments, will it be possible to see how it will be possible?

denisotree

comment created time in 15 hours

issue commentgohugoio/hugo

Make minify rename javascript variables to make javascript even shorter

I though about that too. I have been checking the code proposed by @kssilveira with these 2 methods:

  • hugo --minify
  • asset minification using Hugo Pipes
    {{ $js := resources.Get "test.js" }}
    {{ $jsm := $js | resources.Minify }}

The output is the same as the one mentioned in the issue.

kssilveira

comment created time in 15 hours

issue commentgohugoio/hugo

Make minify rename javascript variables to make javascript even shorter

I guess this issue is talking about the --minify flag, but if you're talking about external JS files, note that js.Build also has an minify option, which I'm pretty sure is doing a great job:

https://gohugo.io/hugo-pipes/js#import-js-code-from-assets

As to updating the upstream minifier. We have had a couple of breaking changes with this recently, and the problem with these breaks is that they don't just put a scratch in your site. We currently don't have a good enough test suite on the Hugo side of the fence to make sure that all is OK, so upgrades requires manual work, and this has not been a priority of me lately.

kssilveira

comment created time in 16 hours

Pull request review commentgohugoio/hugo

Add template execution tracing

 func (t *templateExec) Execute(templ tpl.Template, wr io.Writer, data interface{ 		defer t.Metrics.MeasureSince(templ.Name(), time.Now()) 	} +	if t.d.Cfg.GetBool("debug") {+		t.d.Log.Debug().Printf("Execute template: %q", templ.Name())

I'm not merging this debug statement (see my previous comment; in this case it's the cost of the .GetBool). I'm fine with the first change

isotopp

comment created time in 16 hours

issue closedgohugoio/hugo

Generate footnote items without <p>

<!-- Please answer these questions before submitting your issue. Thanks! -->

What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.75.1/extended windows/amd64 BuildDate: unknown

Does this issue reproduce with the latest release?

Yes.


Building a website with Goldmark, I found that <li> in footnotes has <p> as its children. However, this behavior is incorrect because, accroding the MDN Docs and Lighthouse's audit logs, <li> is allowed to contain Flow content only, which does not include <p>.

It would better to generate footnote items with content text and HTML elements belonging to the flow content.

Current

<section class="footnotes" role="doc-endnotes">
    <hr>
    <ol>
        <li id="fn:1" role="doc-endnote">
            <p>
                This is a footnote. <a href="#fnref:1" class="footnote-backref" role="doc-backlink">↩︎</a>
            </p>
        </li>
    </ol>
</section>

Expected output

<section class="footnotes" role="doc-endnotes">
    <hr>
    <ol>
        <li id="fn:1" role="doc-endnote">
            This is a footnote. <a href="#fnref:1" class="footnote-backref" role="doc-backlink">↩︎</a>
        </li>
    </ol>
</section>

closed time in 17 hours

Meiryo7743

issue commentgohugoio/hugo

Generate footnote items without <p>

Oops! I have misread the documentation. In addition Lighthouse didn't log such an error ... There is nothing wrong with that.

Maybe I was a little tired. Sorry for the inconvenience.

Meiryo7743

comment created time in 17 hours

issue commentgohugoio/hugo

Generate footnote items without <p>

flow-element

Meiryo7743

comment created time in 17 hours

issue commentgohugoio/hugo

The internal GA template does not work with the new analytics version

I had the same problem. Google Analytics 4 Property ID (G-XXXXXXXX) vs UA-XXXXXXX-X. I found solution by creating a Universal Analytics property.

Tracking ID and property number.

onedrawingperday

comment created time in 18 hours

more